opendevreview | Chuan Miao proposed openstack/manila master: NetApp: fix delay clone split when creating share from snapshot (#124) https://review.opendev.org/c/openstack/manila/+/891569 | 08:27 |
---|---|---|
opendevreview | Saravanan Manickam proposed openstack/manila master: OpenStack Shares Backup management documentation https://review.opendev.org/c/openstack/manila/+/913213 | 08:58 |
ccokeke[m] | gireesh: Can you take a look https://review.opendev.org/c/openstack/manila-ui/+/923597 looks like i am having api version issues | 10:36 |
opendevreview | tspyderboy proposed openstack/manila-ui master: Share Network Subnet create UI option added https://review.opendev.org/c/openstack/manila-ui/+/924174 | 11:11 |
opendevreview | tspyderboy proposed openstack/manila-ui master: Share Network Subnet create UI option added https://review.opendev.org/c/openstack/manila-ui/+/924174 | 11:14 |
carloss | > hey Carloss good morning | 11:15 |
carloss | > — ccokeke[m] uploaded an image: (359KiB) < https://matrix.org/_matrix/media/v3/download/matrix.org/OglttcaiHqPFXqKoHAgEIccJ/Screenshot%20from%202024-07-21%2013-47-27.png > | 11:15 |
carloss | hey ccokeke[m], so I believe you should update the microversion that is currently set in the manila-ui repository. What is the current version set? | 11:15 |
ccokeke[m] | 2.53 | 11:15 |
ccokeke[m] | so i should update it to 2.7 right? | 11:16 |
*** iurygregory__ is now known as iurygregory | 11:18 | |
carloss | ccokeke[m]: https://docs.openstack.org/manila/latest/contributor/api_microversion_history.html this should be the place to look | 11:18 |
carloss | according to it, share snapshots metadata was introduced in the 2.73 microversion | 11:19 |
carloss | so that's the version you should have in your code as well | 11:19 |
ccokeke[m] | nice.Thanks | 11:19 |
gireesh | Thanks @carloss for resolving the issue | 11:58 |
carloss | ccokeke[m]: np | 11:58 |
gireesh | "gireesh: when constructing export locations, shouldn't the driver just ignore management LIFs? @gouthamr, I follow-up with ONTAP SME and here is their reply "NFS Kerberos configurations are maintained at the LIF level, so We need to make sure only data LIF configurations are checked and not the mgmt VSM LIFs.". I requested "Williams, Jonathan " to file the bug, we will fix this soon. | 12:03 |
*** iurygregory__ is now known as iurygregory | 13:01 | |
stephenfin | carloss: gouthamr: I think my comments on https://review.opendev.org/c/openstack/manila/+/922566 might be helpful RE: putting together a mental list of things to look for in review of schema changes | 14:23 |
stephenfin | I'm not sure why the issues were not picked up in the tests by way of https://review.opendev.org/c/openstack/manila/+/917157 but I think that's happening because OpenAPI 3.1 removed the requirement to prefix custom properties with 'x-', which means it very permissive :( | 14:24 |
stephenfin | s/OpenAPI 3.1/JSONSchema Draft 2020-12/ | 14:25 |
stephenfin | I need to figure out how we can make the jsonschema validation added in https://review.opendev.org/c/openstack/manila/+/917157 stricter. There must be some way to do it. If either of ye have time this week, I think it would be a good use of time since it'll remove the need to watch for those things in reviews | 14:26 |
opendevreview | Carlos Eduardo proposed openstack/python-manilaclient master: Add source share server ID param to server list https://review.opendev.org/c/openstack/python-manilaclient/+/924539 | 14:32 |
carloss | stephenfin: thanks for sharing it. indeed a good list | 14:33 |
opendevreview | Carlos Eduardo proposed openstack/python-manilaclient master: Add new filter options for share server list https://review.opendev.org/c/openstack/python-manilaclient/+/924539 | 16:58 |
opendevreview | Carlos Eduardo proposed openstack/python-manilaclient master: Add new filter options for share server list https://review.opendev.org/c/openstack/python-manilaclient/+/924539 | 16:58 |
opendevreview | Chuan Miao proposed openstack/manila master: NetApp: fix delay clone split when creating share from snapshot (#124) https://review.opendev.org/c/openstack/manila/+/891569 | 18:06 |
opendevreview | Carlos Eduardo proposed openstack/manila master: WIP APIs for ensure shares https://review.opendev.org/c/openstack/manila/+/924279 | 18:45 |
opendevreview | Carlos Eduardo proposed openstack/python-manilaclient master: WIP Add ensure shares command https://review.opendev.org/c/openstack/python-manilaclient/+/924675 | 18:58 |
gouthamr | > gireesh: I requested "Williams, Jonathan " to file the bug, we will fix this soon. | 19:48 |
gouthamr | perfect. thank you gireesh | 19:48 |
gouthamr | stephenfin: thanks for sharing; that is a pretty detailed review | 19:50 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!