| opendevreview | Tony Faijue proposed openstack/manila master: updated share group type doc https://review.opendev.org/c/openstack/manila/+/942967 | 01:54 |
|---|---|---|
| opendevreview | Tony Faijue proposed openstack/manila master: Share Group Type Documentation Commands Updated https://review.opendev.org/c/openstack/manila/+/942967 | 01:56 |
| opendevreview | kiran pawar proposed openstack/manila master: Pass share network subnet metadata updates to backend drivers https://review.opendev.org/c/openstack/manila/+/929091 | 07:11 |
| opendevreview | kiran pawar proposed openstack/manila master: NetApp: Implement share network subnet metadata update method https://review.opendev.org/c/openstack/manila/+/942888 | 07:11 |
| opendevreview | kiran pawar proposed openstack/manila master: Pass share network subnet metadata updates to backend drivers https://review.opendev.org/c/openstack/manila/+/929091 | 07:15 |
| opendevreview | kiran pawar proposed openstack/manila master: NetApp: Implement share network subnet metadata update method https://review.opendev.org/c/openstack/manila/+/942888 | 07:15 |
| opendevreview | Gireesh Awasthi proposed openstack/manila master: NetApp - Restrict LIF Creation Per HA Pair https://review.opendev.org/c/openstack/manila/+/942216 | 10:44 |
| opendevreview | Takashi Kajinami proposed openstack/manila master: Drop direct test dependency on iso8601 https://review.opendev.org/c/openstack/manila/+/943024 | 15:56 |
| opendevreview | Ashley Rodriguez proposed openstack/manila-tempest-plugin master: Disable Ingress https://review.opendev.org/c/openstack/manila-tempest-plugin/+/942862 | 17:42 |
| opendevreview | Ashley Rodriguez proposed openstack/devstack-plugin-ceph master: Disable Ingress https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/942861 | 17:44 |
| opendevreview | Ashley Rodriguez proposed openstack/manila-tempest-plugin master: Metadata for Share Export Location https://review.opendev.org/c/openstack/manila-tempest-plugin/+/925621 | 17:54 |
| gouthamr | hey kpdev, can we chat here, or on the change itself? | 18:02 |
| gouthamr | i can clarify the comment on the deletion method.. the API is invoked to delete a single metadata item | 18:02 |
| kpdev | on change, it will take time, as we get reviews close to freeze | 18:02 |
| kpdev | for delete metadata, what do you expect ? | 18:03 |
| gouthamr | sure, np, the intention is to be open with our reviews.. and this channel is logged, where private messages aren't | 18:03 |
| kpdev | yes | 18:03 |
| gouthamr | yes, so when the user expects to delete a single key, the code seems to be reading all the metadata that's set on the subnet, why? | 18:04 |
| kpdev | i was considering all metadata, but as you said, just key is enough | 18:04 |
| kpdev | so you want error message without key, will that be enough ? | 18:04 |
| gouthamr | sure, but you can set the error message right there too | 18:04 |
| gouthamr | no need to invoke the share/api method | 18:04 |
| kpdev | yes, thats ok | 18:05 |
| gouthamr | you could instantiate the message/api object | 18:05 |
| gouthamr | and create a user message | 18:05 |
| kpdev | ok, so error message without key mentined,, got it | 18:06 |
| kpdev | second part, | 18:06 |
| kpdev | imagine having a cloud with two backends, one that supports updates and one that doesn't.. how would the user know which of their updates are taking effect? | 18:06 |
| kpdev | what do we expect here ? | 18:06 |
| kpdev | in error_message | 18:06 |
| gouthamr | the error message ("UPDATE_METADATA_FAILURE") is fine.. | 18:07 |
| gouthamr | you're ignoring "NotImplementedError" | 18:07 |
| gouthamr | which isn't necessary | 18:07 |
| gouthamr | you should set "UPDATE_METADATA_FAILURE" even when the backend doesn't implement the update method | 18:07 |
| kpdev | so error message for the notImeplemtedError.. | 18:07 |
| kpdev | ok got it | 18:07 |
| kpdev | >I'm not suggesting we change all the drivers right now, but i want us to acknowledge this is a broken design and try to rectify it as a bug fix. | 18:08 |
| kpdev | this is clear and needs to address as bug fix | 18:08 |
| gouthamr | sure, please report a known issue/bug so we can track it | 18:08 |
| kpdev | for migration of metadata, I will add in releasenotes that it will be ignored by manila for now. | 18:09 |
| gouthamr | ack | 18:09 |
| kpdev | and we will keep this is future work to support if customer asks. | 18:09 |
| gouthamr | you can clarify the behavior in the docs | 18:09 |
| kpdev | ok, can you point to which file in docs it should go ? | 18:10 |
| gouthamr | https://docs.openstack.org/manila/latest/user/share-network-subnet-operations.html#id4 | 18:11 |
| kpdev | thanks, those were only questions. | 18:13 |
| gouthamr | ack, ty! | 18:14 |
| opendevreview | Merged openstack/manila master: Drop direct test dependency on iso8601 https://review.opendev.org/c/openstack/manila/+/943024 | 18:38 |
| opendevreview | kiran pawar proposed openstack/manila master: Pass share network subnet metadata updates to backend drivers https://review.opendev.org/c/openstack/manila/+/929091 | 18:52 |
| opendevreview | kiran pawar proposed openstack/manila master: NetApp: Implement share network subnet metadata update method https://review.opendev.org/c/openstack/manila/+/942888 | 18:52 |
| opendevreview | Ashley Rodriguez proposed openstack/devstack-plugin-ceph master: Disable Ingress https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/942861 | 19:07 |
| opendevreview | Merged openstack/manila master: [NetApp] Certificate based authentication for NetApp drivers https://review.opendev.org/c/openstack/manila/+/942675 | 23:25 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!