| opendevreview | OpenStack Proposal Bot proposed openstack/manila-ui master: Imported Translations from Zanata https://review.opendev.org/c/openstack/manila-ui/+/960226 | 03:43 |
|---|---|---|
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Drop eventlet usage in ssh pools https://review.opendev.org/c/openstack/manila/+/960231 | 05:15 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Drop eventlet usage in ssh pools https://review.opendev.org/c/openstack/manila/+/960231 | 05:20 |
| gouthamr | Sai: kpdev: can you review https://review.opendev.org/c/openstack/manila/+/959104 when you get a chance | 16:42 |
| gouthamr | Sai's tested this, and posted on https://review.opendev.org/c/openstack/manila/+/955393 | 16:45 |
| tkajinam | one good benefit of that refactoring is that it allows you to use service token implementation in barbican keymanager in casetellan | 17:28 |
| tkajinam | an alternative approach is to get rid of castellan and vendor own options (because current implementation only import castellan options with some of them unused... though I prefer tight-integration approach because of that benefit | 17:29 |
| tkajinam | (I think I've never explained this properly, so leaving it here for record/reference | 17:30 |
| tkajinam | we could probably provide the same functionality in castellan in the future though I have to check how the interface should look like for the other drivers we maintain | 17:30 |
| gouthamr | yes, we totally went with that approach when designing that feature, but, we wrongly assumed that castellan was not actively maintained | 17:31 |
| tkajinam | it's not maintained unless someone aim to use and maintain it :-) | 17:32 |
| gouthamr | ? i thought it was mostly "complete" :) | 17:32 |
| tkajinam | I mean the door is open | 17:32 |
| tkajinam | It has been stable and has looked "unmaintained" due to no one actually trying to add new things | 17:33 |
| gouthamr | true; i hope we can find/flag issues and help the maintenance now that folks intend to use it for newer use cases | 17:33 |
| tkajinam | :-) | 17:33 |
| gouthamr | thanks for the simplification/refactor tkajinam - very glad to have it prior to RC1! | 17:33 |
| tkajinam | :-) | 17:34 |
| tkajinam | I'll see if I can import some of these code to castellan early next cycle | 17:36 |
| tkajinam | to avoid future problems caused by "internal" change | 17:36 |
| gouthamr | ++ awesome! | 18:01 |
| opendevreview | Jonathan Koerber proposed openstack/manila master: Adding JSONSchema to shares https://review.opendev.org/c/openstack/manila/+/956053 | 21:39 |
| opendevreview | Merged openstack/manila master: Add barbican set up to devstack https://review.opendev.org/c/openstack/manila/+/955393 | 22:09 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!