| opendevreview | Kumar Tadepalli proposed openstack/manila master: NetApp-Fix Sync replication related feedback comments https://review.opendev.org/c/openstack/manila/+/978604 | 03:54 |
|---|---|---|
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: admin guide: Switch manila CLI to openstackcli https://review.opendev.org/c/openstack/manila/+/978275 | 06:06 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: config guide: Switch manila CLI to openstackcli https://review.opendev.org/c/openstack/manila/+/978274 | 06:06 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: install & contributor guide: Switch manila CLI to openstackcli https://review.opendev.org/c/openstack/manila/+/978273 | 06:06 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: user-guide: Switch manila CLI to openstackcli https://review.opendev.org/c/openstack/manila/+/978272 | 06:06 |
| hong-p[m] | gouthamr: hi, I'd like to add this feature to the Gazpacho release. For now, how about using a private storage and adding it to the admin metadata feature in the next release? https://review.opendev.org/c/openstack/manila/+/969546 | 08:03 |
| opendevreview | kiran pawar proposed openstack/manila master: Fix QoS type review optimizations. https://review.opendev.org/c/openstack/manila/+/978294 | 09:38 |
| opendevreview | Siddharth Kumar proposed openstack/manila master: Dell PowerScale: Add QoS support https://review.opendev.org/c/openstack/manila/+/976101 | 09:42 |
| Sai | Hi carloss | 10:16 |
| Sai | Regarding this patch, https://review.opendev.org/c/openstack/manila/+/978319 | 10:16 |
| Sai | We took a look at it the code and it doesn't seem to impact share encryption workflow | 10:17 |
| Sai | How mandatory is testing this patch w.r.t NetApp driver? | 10:18 |
| Sai | And if we need to test, by when we should test ? | 10:19 |
| opendevreview | Takashi Kajinami proposed openstack/manila master: Adopt to new castellan https://review.opendev.org/c/openstack/manila/+/978319 | 10:33 |
| opendevreview | Takashi Kajinami proposed openstack/manila master: Enforce castellan >= 5.6.0 https://review.opendev.org/c/openstack/manila/+/978321 | 10:34 |
| opendevreview | Sylvan Le Deunff proposed openstack/manila master: decorate wrapper method with functools.wrap to keep func name in hooks https://review.opendev.org/c/openstack/manila/+/978699 | 10:35 |
| opendevreview | Medha Choudhary proposed openstack/manila master: NetApp: Handle node failures in multi-node share creation https://review.opendev.org/c/openstack/manila/+/978462 | 11:34 |
| carloss | > We took a look at it the code and it doesn't seem to impact share encryption workflow | 11:49 |
| carloss | isn't the netapp storage using the key href? | 11:49 |
| carloss | Sai ^ :) | 11:49 |
| Sai | Yes it is using. | 11:51 |
| carloss | then it completely impacts the workflow | 11:52 |
| carloss | let me do a recap | 11:52 |
| carloss | this change was merged into castellan: https://github.com/openstack/castellan/commit/a227bd9c4c29707239a46211af1af276df2a1464 | 11:52 |
| Sai | We use the secret generated from "openstack secret store" | 11:52 |
| carloss | yes, you do | 11:53 |
| carloss | but how do you get the href? :) | 11:53 |
| carloss | our code is using a private function that got removed by the commit I linked | 11:54 |
| Sai | > but how do you get the href? :) | 11:54 |
| carloss | meaning our workflow will be broken. Then we have a new fix that is addressing that and we're switching away from getting the href the way we used to. The dummy driver seems to be behaving just fine | 11:55 |
| carloss | I assume the NetApp driver would be too with that patch | 11:55 |
| Sai | "openstack secret store" | 11:57 |
| Sai | This actually gets secret href with new change as well right ? | 11:57 |
| carloss | it will, in a different way, but will | 11:59 |
| carloss | the thing is that we're adapting to that new way in Manila | 11:59 |
| carloss | meaning it should work, but we need to ensure that the new way we're doing it works | 11:59 |
| Sai | > the thing is that we're adapting to that new way in Manila | 11:59 |
| Sai | Example mentioned some where? | 11:59 |
| Sai | > meaning it should work, but we need to ensure that the new way we're doing it works | 12:00 |
| Sai | I get your point ! | 12:00 |
| carloss | > https://review.opendev.org/c/openstack/manila/+/978319 | 12:00 |
| carloss | this is the example | 12:00 |
| carloss | tkajinam: already did all the heavy lifting for you | 12:00 |
| carloss | you folks just need to test to ensure we're not shipping bugs with share encryption in the netapp driver in gazpacho and making it unusable | 12:01 |
| carloss | btw, tkajinam++ :) | 12:01 |
| carloss | we expect that things work just fine, but we need confirmation | 12:01 |
| Sai | Okay if testing is mandatory, how much time we have for this? | 12:02 |
| carloss | > And if we need to test, by when we should test ? | 12:03 |
| carloss | like today or as soon as you folks can, but this week preferrably | 12:03 |
| Sai | The team pretty busy in release and FST activities, hence seeking info to update you back | 12:03 |
| carloss | If we get the +2s we'll merge the change anyways because it is blocking the bump of upper constraints in castellan | 12:03 |
| carloss | meaning we're impacting other team's release | 12:03 |
| carloss | but if we merge anyways and the netapp driver doesn't work with the implementation, you folks will have a bug | 12:04 |
| carloss | in the driver that makes share encryption useless | 12:04 |
| carloss | at the moment my concern is not on the change getting in. it will, but I am trying to signal this to you so you are not caught by surprise if it doesn't work | 12:05 |
| Sai | I get your point...! Really thanks for the heads up! | 12:09 |
| carloss | anytime | 12:12 |
| carloss | we'll try getting the change in as soon as we can, so please get back to the change when you've completed the testing for it | 12:15 |
| Sai | Sure carloss, thanks. | 12:16 |
| opendevreview | Takashi Kajinami proposed openstack/manila master: wip: Use endpoint detection to obtain full secret href https://review.opendev.org/c/openstack/manila/+/978556 | 12:38 |
| opendevreview | Ivan Anfimov proposed openstack/manila master: tox: Drop basepython https://review.opendev.org/c/openstack/manila/+/975605 | 15:33 |
| opendevreview | kiran pawar proposed openstack/manila master: NetApp: Support force delete volume https://review.opendev.org/c/openstack/manila/+/978780 | 16:16 |
| opendevreview | Sylvan Le Deunff proposed openstack/manila master: decorate wrapper method with functools.wrap to keep func name in hooks https://review.opendev.org/c/openstack/manila/+/978699 | 16:35 |
| opendevreview | Merged openstack/manila master: Adopt to new castellan https://review.opendev.org/c/openstack/manila/+/978319 | 18:18 |
| opendevreview | Merged openstack/manila master: NetApp-Fix Sync replication related feedback comments https://review.opendev.org/c/openstack/manila/+/978604 | 19:39 |
| opendevreview | Merged openstack/manila master: Implementation of NAE support for NetApp Driver https://review.opendev.org/c/openstack/manila/+/977290 | 19:46 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: [WIP] Remove eventlet from manila-scheduler https://review.opendev.org/c/openstack/manila/+/972972 | 22:18 |
| opendevreview | Merged openstack/manila master: decorate wrapper method with functools.wrap to keep func name in hooks https://review.opendev.org/c/openstack/manila/+/978699 | 22:44 |
| opendevreview | Merged openstack/manila master: Fix to create share group when only share properties are provided in filter function https://review.opendev.org/c/openstack/manila/+/952120 | 23:48 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!