| opendevreview | Amarachi Ogbonnaya proposed openstack/manila master: Add documentation for Shared File Systems telemetry https://review.opendev.org/c/openstack/manila/+/982149 | 00:24 |
|---|---|---|
| opendevreview | Fiyin Peter proposed openstack/python-manilaclient master: Fix silent no-op in OSC set commands with all-optional args https://review.opendev.org/c/openstack/python-manilaclient/+/982518 | 00:32 |
| FiyinPeter[m] | Hello, I'd like to work on https://bugs.launchpad.net/python-manilaclient/+bug/2146281 | 00:50 |
| nathan_akin[m] | <FiyinPeter[m]> "Hello, I'd like to work on https..." <- hello, you can actually work on this issue, since its not assigned to anyone | 01:03 |
| FiyinPeter[m] | Thank you for the pointer | 01:04 |
| nathan_akin[m] | FiyinPeter[m]: anytime, just make sure to assign yourself | 01:04 |
| FiyinPeter[m] | I am not certain I know how to do that. | 01:04 |
| nathan_akin[m] | ok thats fine | 01:05 |
| nathan_akin[m] | are you currently on the issue page? | 01:05 |
| FiyinPeter[m] | Yes | 01:05 |
| * nathan_akin[m] uploaded an image: (183KiB) < https://matrix.org/oftc/media/v1/media/download/AYC9ZYXeN1ygJRDKwo9XtygiphehMosaP27MRrEc_1HefJvkUcN2uj1ktHP2VqMDgY97Hr8-FD9T8_7Fj4nM991CedehNYvQAG1hdHJpeC5vcmcvZk12cEdTSWNPUEhRRnZGZUNjbFZyUElO > | 01:06 | |
| nathan_akin[m] | ok just click on the pen (pencil) next to the unassigned text | 01:06 |
| nathan_akin[m] | you should see "assign me" text in green, click on it | 01:06 |
| FiyinPeter[m] | nathan_akin[m]: Right | 01:06 |
| nathan_akin[m] | FiyinPeter[m]: once you do that you have successfully assigned yourself , | 01:07 |
| * FiyinPeter[m] uploaded an image: (32KiB) < https://matrix.org/oftc/media/v1/media/download/AcZw8LspbveAQaIEBQkXrBiTimjySF68IdSJejCrV4-vfE0wMQ8RRTnuEWp-0519kND4f44MExDUlgUBtuUUuDBCedehW-NQAG1hdHJpeC5vcmcvYUdycG1XUVNJQVRiTGVRSXhpTmxERG9H > | 01:08 | |
| FiyinPeter[m] | the trouble is I don't see a pencil | 01:09 |
| nathan_akin[m] | Oh thats strange, | 01:10 |
| nathan_akin[m] | Do you have an account? | 01:10 |
| FiyinPeter[m] | On launchpad? I do | 01:11 |
| nathan_akin[m] | let me see your top right corner of that page | 01:12 |
| * FiyinPeter[m] uploaded an image: (13KiB) < https://matrix.org/oftc/media/v1/media/download/AaombmB9WsUb5XsKb7wJYcmLpVv6uOyvfCo2LQ78c0T_2h4xzv5EPr5tKzAzLczA8y4Ub6n3ZxSoqy-oxhMMBhZCedehn83gAG1hdHJpeC5vcmcveHB6YkpSSkVDcWVxeHJUTkRPdU1LRHF5 > | 01:13 | |
| nathan_akin[m] | oh thats strange, | 01:15 |
| nathan_akin[m] | ok this is what you should do | 01:15 |
| nathan_akin[m] | when did you create your launchpad account | 01:17 |
| FiyinPeter[m] | Two, maybe three days ago | 01:17 |
| nathan_akin[m] | oh ok | 01:18 |
| nathan_akin[m] | <FiyinPeter[m]> "Hello, I'd like to work on https..." <- ok try leaving a comment on the bug | 01:19 |
| nathan_akin[m] | then refresh the page and lets see if the pencil appears | 01:19 |
| FiyinPeter[m] | I'll give that a go rn | 01:19 |
| nathan_akin[m] | FiyinPeter[m]: alright great, just let me know | 01:20 |
| FiyinPeter[m] | I am still missing the pencil | 01:20 |
| nathan_akin[m] | ok so i am trying to figure out why | 01:22 |
| nathan_akin[m] | give me a min | 01:22 |
| nathan_akin[m] | because i can see the pencil from my end | 01:24 |
| nathan_akin[m] | but hold on please | 01:24 |
| nathan_akin[m] | ok so not to worry, launchpad has like a karma type of thing going on, so its based off of your activities on launchpad , i have been working on some projects and pushing fixes so i guess thats why my pencil showed up | 01:29 |
| FiyinPeter[m] | So I have to earn the pencil? | 01:29 |
| FiyinPeter[m] | Got it. | 01:30 |
| nathan_akin[m] | kind of yes, but one last question just to confirm, have you pushed any Prs or bug fixes , or this is your first time | 01:31 |
| FiyinPeter[m] | nathan_akin[m]: I have pushed just the one. | 01:32 |
| FiyinPeter[m] | And it's yet to be approved | 01:33 |
| FiyinPeter[m] | This is my second attempt at a fix | 01:33 |
| nathan_akin[m] | FiyinPeter[m]: you were assigned right? | 01:33 |
| FiyinPeter[m] | To the first, yes | 01:34 |
| nathan_akin[m] | ok i understand now, its normal dont worry, its gonna unlock, just keep making sure you are commenting under bugs you wanna be assigned to, and push your work | 01:35 |
| FiyinPeter[m] | Sure. Thank you, Nathan. | 01:35 |
| nathan_akin[m] | anytime, No worries at all, this is pretty common for new Launchpad accounts. It usually unlocks after you get a bit more activity.... (full message at <https://matrix.org/oftc/media/v1/media/download/AS99sJH_7bIwsknvjz4Dx7rqZblQZpMLZ9TdNvS-cL5EW8mJUhniTAgu-iZT7QRmGHU-Tep_mQrfSXtbQocaQsRCedejEVgwAG1hdHJpeC5vcmcvYWRPUmpHcWFaQ1hCb1VVUmNOUFBDck5P>) | 01:38 |
| nathan_akin[m] | they are going to assign it to you | 01:39 |
| FiyinPeter[m] | Alright | 01:46 |
| Priestess[m] | <FiyinPeter[m]> "Hello, I'd like to work on https..." <- I think leaving a comment on the bug should work tho. | 02:14 |
| Priestess[m] | One of the mentors will assign it to you when they're available. | 02:14 |
| Priestess[m] | 🤷🏽♀️ | 02:14 |
| Priestess[m] | <nathan_akin[m]> "hello, you can actually work..." <- It has the `in-progress` tag too.... (full message at <https://matrix.org/oftc/media/v1/media/download/AYLn01s_2Jz95p6Lf-PfqwJ5S6GG8ZUashtIPcN-IuhSdFTNX6LrLv-nvNaijtrGlgNUehpMpNxsK6vwcwbIvE9CedelOlkQAG1hdHJpeC5vcmcvcnlhTUZHT0JOa0dUcWFUb1h0aVd1VWVJ>) | 02:16 |
| nathan_akin[m] | Priestess[m]: Yes | 02:17 |
| Priestess[m] | Priestess[m]: Or rather the bug wasn't assigned to them. | 02:20 |
| Priestess[m] | (Lol. Just tried imagining being assigned to a bug 😅) | 02:20 |
| nathan_akin[m] | <Priestess[m]> "Or rather the bug wasn't..." <- You should pick one and apply to work on it | 02:26 |
| nathan_akin[m] | 😅😅 | 02:26 |
| opendevreview | OpenStack Proposal Bot proposed openstack/manila-ui master: Imported Translations from Zanata https://review.opendev.org/c/openstack/manila-ui/+/982524 | 03:26 |
| opendevreview | Amarachi Ogbonnaya proposed openstack/manila master: Add documentation for Shared File Systems telemetry https://review.opendev.org/c/openstack/manila/+/982149 | 05:46 |
| opendevreview | Amarachi Ogbonnaya proposed openstack/manila master: Add documentation for Shared File Systems telemetry https://review.opendev.org/c/openstack/manila/+/982149 | 06:22 |
| carloss | it should be okay (and it's recommended) that if you can assign yourself to a bug, please do so. You should only need us if that is the first bug you're assigning to yourself, otherwise if you're logged in and you're in the bug page, you should see a pencil icon right under "Assigned to" | 08:34 |
| carloss | that said, I assigned FiyinPeter[m] to the bug :) | 08:35 |
| carloss | please feel free to pick up any bugs from the lhf list | 08:36 |
| nathan_akin[m] | carloss: Thank you for the clarification | 08:46 |
| nathan_akin[m] | oh also gouthamr carloss thank you for the clarification on my PR , just pushed patchset 4 on 982050 , i addressed all three comments. removed the duplicate Change-Id, replaced the brittle tuple unpacking with just checking the check name string, and switched the call_args index access to use .args[0] and .kwargs to make it more readable. thanks for the detailed feedback, really helpful, | 09:28 |
| nathan_akin[m] | https://review.opendev.org/c/openstack/manila/+/982050 | 09:28 |
| nathan_akin[m] | Oh.. also 😅 carloss been reading through the scheduler code and noticed something in the affinity filter. when a user passes an invalid share UUID as a scheduler hint, the filter catches the exception and returns None (which stops scheduling), but there's no call to message_api.create() before that happens. so from the user's side they just get NoValidHost, last filter AffinityFilter with no explanation. other scheduler | 09:28 |
| nathan_akin[m] | paths like missing share type already use the message API to give user facing feedback. would it be worth filing a bug and adding that here too? gouthamr | 09:28 |
| opendevreview | Amarachi Ogbonnaya proposed openstack/manila master: Add documentation for Shared File Systems telemetry https://review.opendev.org/c/openstack/manila/+/982149 | 13:52 |
| opendevreview | Olamide Ojo proposed openstack/manila master: Create a new transaction for processing each table https://review.opendev.org/c/openstack/manila/+/982534 | 14:43 |
| opendevreview | Silvia Wachira proposed openstack/python-manilaclient master: Fix DictColumn JSON serialization error https://review.opendev.org/c/openstack/python-manilaclient/+/981744 | 15:01 |
| opendevreview | Amarachi Ogbonnaya proposed openstack/manila master: Add documentation for Shared File Systems telemetry https://review.opendev.org/c/openstack/manila/+/982149 | 15:59 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: Allow 'latest' as a valid API version string https://review.opendev.org/c/openstack/manila/+/982536 | 18:22 |
| opendevreview | Silvia Wachira proposed openstack/python-manilaclient master: Show share type names in share group type list and show https://review.opendev.org/c/openstack/python-manilaclient/+/982538 | 21:02 |
| hashaaam | Hi, I'm hashaaam, an Outreachy applicant interested in the "Integrate manila client plugin commands into OpenStack Client" project. I'd love to start contributing. Can someone guide me on where to begin? gouthamr carloss | 22:16 |
| opendevreview | Meer Hashaam Khan proposed openstack/manila master: Remove stale api-paste.ini override in grenade upgrade script https://review.opendev.org/c/openstack/manila/+/982539 | 22:43 |
| hashaaam | Hi gouthamr carloss, I've submitted my first patch for bug #2146268. Review: https://review.opendev.org/c/openstack/manila/+/982539 | 22:44 |
| opendevreview | Meer Hashaam Khan proposed openstack/python-manilaclient master: Add additional tests for client version handling Add tests to explicitly verify: - APIVersion instance passed as kwarg is not re-converted - get_client_class returns correct v1 client class Related-Bug: #2145056 Signed-off-by: Meer Hashaam Khan <hashaamkhan975@gmail.com> https://review.opendev.org/c/openstack/python-manilaclient/+/982540 | 23:09 |
| hashaaam | gouthamr carloss I've submitted a second patch to python-manilaclient adding unit tests. Review: https://review.opendev.org/c/openstack/python-manilaclient/+/982540 | 23:11 |
| opendevreview | Meer Hashaam Khan proposed openstack/manila master: t review::wq!:wq!api-ref: Add metadata param to manage snapshot docs The manage snapshot endpoint accepts an optional metadata parameter from API version 2.73, but this was not documented in snapshots.inc. This patch adds the missing metadata parameter with min_version 2.73. Closes-Bug: #2146271 Signed-off-by: Meer Hashaam Khan <hashaamkhan975@gmail.com> https://review.opendev. | 23:46 |
| opendevreview | Meer Hashaam Khan proposed openstack/manila master: api-ref: Add metadata param to manage snapshot docs https://review.opendev.org/c/openstack/manila/+/982542 | 23:50 |
| hashaaam | Hi gouthamr carloss, I hope you're doing well. I've been working on another contribution and just submitted a patch to document the missing metadata parameter in the manage snapshot endpoint (v2.73+). I would really appreciate your feedback when you get a chance. Review: https://review.opendev.org/c/openstack/manila/+/982542 | 23:53 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!