| Amarachi20 | Hi Carloss, I'm done with https://review.opendev.org/c/openstack/manila/+/982727 kindly review and still open to more tasks if there's any available | 04:45 |
|---|---|---|
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Fix AZ creation race on concurrent service start https://review.opendev.org/c/openstack/manila/+/982739 | 05:34 |
| opendevreview | Lizzy Njoroge proposed openstack/python-manilaclient master: OSC: Add missing tests for share groups and fix snapshot filter https://review.opendev.org/c/openstack/python-manilaclient/+/982663 | 06:39 |
| opendevreview | kiran pawar proposed openstack/manila master: NetApp: Support force delete volume https://review.opendev.org/c/openstack/manila/+/978780 | 07:52 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: Validate 'ensuring' filter value in services list API https://review.opendev.org/c/openstack/manila/+/982716 | 08:34 |
| nathan_akin[m] | Gm gouthamr thank you for the review on my patch, i have made the required fixes and all tests pass. https://review.opendev.org/c/openstack/manila/+/982716. | 08:37 |
| *** JoyAkinyi is now known as Guest6254 | 08:57 | |
| *** JoyAkinyi is now known as Guest6255 | 08:57 | |
| nathan_akin[m] | gouthamr: i was looking at the patch and i also checked the rally task files... i was thinking, maybe we could add some heavier scenarios like snapshot create/delete or access rule stuff? i feel like those might show more issues with the eventlet removal since they're more complex operations. i don't know if that's a good idea but i could maybe try adding them to the yaml file if it helps, or what do you think | 09:00 |
| opendevreview | Merged openstack/manila master: Fix jsonschema enum (list instead of tuple) https://review.opendev.org/c/openstack/manila/+/982081 | 09:17 |
| opendevreview | Denver Baraka proposed openstack/manila master: api-ref: fix incorrect parameter for metadata keys https://review.opendev.org/c/openstack/manila/+/982756 | 09:23 |
| opendevreview | Amarachi Ogbonnaya proposed openstack/manila master: api-ref: fix scheduler_hints min_version to 2.67 https://review.opendev.org/c/openstack/manila/+/982727 | 10:44 |
| Amarachi20 | Hi gouthamr, Please kindly check https://review.opendev.org/c/openstack/manila/+/982149 I've done the correction I was told to do yesterday | 10:58 |
| denver | hi gouthamr and carloss, i made a patch, please check https://review.opendev.org/c/openstack/manila/+/982756 | 11:08 |
| comfortoyewole[m] | Hello gouthamr @_oftc_gouthamr:matrix.org: updated the changes in the files you mentioned. | 11:10 |
| comfortoyewole[m] | https://review.opendev.org/c/openstack/manila/+/982140 | 11:10 |
| comfortoyewole[m] | * Hello | 11:10 |
| comfortoyewole[m] | @_oftc_gouthamr:matrix.org: | 11:10 |
| comfortoyewole[m] | I've updated the changes in the files you mentioned. https://review.opendev.org/c/openstack/manila/+/982140 | 11:10 |
| opendevreview | Silvia Wachira proposed openstack/manila master: Include share network ID in subnet error messages https://review.opendev.org/c/openstack/manila/+/981465 | 11:49 |
| opendevreview | Amarachi Ogbonnaya proposed openstack/manila master: api-ref: fix scheduler_hints min_version to 2.67 https://review.opendev.org/c/openstack/manila/+/982727 | 12:10 |
| opendevreview | Amarachi Ogbonnaya proposed openstack/manila master: api-ref: fix scheduler_hints min_version to 2.67 https://review.opendev.org/c/openstack/manila/+/982727 | 13:06 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: Add unit tests for manila.cmd.status module https://review.opendev.org/c/openstack/manila/+/982050 | 13:23 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: Replace assertTrue/assertFalse with assertEqual/assertNotEqual https://review.opendev.org/c/openstack/manila/+/982052 | 13:23 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: api-ref: add missing fields to share server responses https://review.opendev.org/c/openstack/manila/+/982058 | 13:23 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: api-ref: fix share_server_id used as path param but defined in body https://review.opendev.org/c/openstack/manila/+/982328 | 13:23 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: api-ref: add missing availability_zone to replica responses https://review.opendev.org/c/openstack/manila/+/982329 | 13:23 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: [CephFS driver] Make update_access idempotent when share is missing https://review.opendev.org/c/openstack/manila/+/982785 | 13:23 |
| nathan_akin[m] | hello gouthamr carloss please a new patch has been released. https://review.opendev.org/c/openstack/manila/+/982785 | 13:29 |
| opendevreview | Amarachi Ogbonnaya proposed openstack/manila master: api-ref: fix scheduler_hints min_version to 2.67 https://review.opendev.org/c/openstack/manila/+/982727 | 13:43 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: NetApp driver: raise clear error on auth failure (HTTP 401) https://review.opendev.org/c/openstack/manila/+/982787 | 13:43 |
| nathan_akin[m] | hello gouthamr and carloss i just wanted to check in on my patches, some of them have been waiting a few days and i wanted to make sure i haven't missed anything on my end. happy to make any changes if needed, just let me know, thank you | 13:47 |
| opendevreview | Silvia Wachira proposed openstack/python-manilaclient master: Show share type names in share group type list and show https://review.opendev.org/c/openstack/python-manilaclient/+/982538 | 13:52 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: Force delete share when host service is down https://review.opendev.org/c/openstack/manila/+/982791 | 14:11 |
| nathan_akin[m] | gouthamr: i wanted to share a fix i worked on for bug #2073883 when a share's host service is down, force deleting it would leave the share stuck in 'deleting' forever because the rpc message never gets picked up. i added a check in the api layer so that if the service is down, it deletes directly from the db instead. i also tested it in devstack which i killed the share service, force deleted a share, and it was gone | 14:29 |
| nathan_akin[m] | immediately. patch is here if you have time to take a look https://review.opendev.org/c/openstack/manila/+/982791 | 14:29 |
| opendevreview | Simon Dodsley proposed openstack/manila master: WIP: Add Everpure FlashArray driver https://review.opendev.org/c/openstack/manila/+/795180 | 14:43 |
| opendevreview | Silvia Wachira proposed openstack/python-manilaclient master: Fix DictColumn JSON serialization error https://review.opendev.org/c/openstack/python-manilaclient/+/981744 | 16:14 |
| opendevreview | Denver Baraka proposed openstack/manila master: Remove deprecated contrib/ci scripts https://review.opendev.org/c/openstack/manila/+/982889 | 17:48 |
| FiyinPeter[m] | Hey carloss . I am uncertain as to why a bug I was assigned was reassigned sequel to my completing it | 17:56 |
| opendevreview | Silvia Wachira proposed openstack/python-manilaclient master: Fix DictColumn JSON serialization error https://review.opendev.org/c/openstack/python-manilaclient/+/981744 | 18:38 |
| gouthamr | Hey Outreachy applicants... thanks for taking keen interest in the project. Please don't ask carloss or me to review changes, or update you on your specific changes. Whether your change(s) merged or not, you can still link it in your internship application. Know that we'll review each change before we make a selection. Don't stop asking other questions though | 18:39 |
| opendevreview | Simon Dodsley proposed openstack/manila master: WIP: Add Everpure FlashArray driver https://review.opendev.org/c/openstack/manila/+/795180 | 18:40 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: Add unit tests for manila.cmd.status module https://review.opendev.org/c/openstack/manila/+/982050 | 19:26 |
| opendevreview | Silvia Wachira proposed openstack/python-manilaclient master: Fix DictColumn JSON serialization error https://review.opendev.org/c/openstack/python-manilaclient/+/981744 | 19:27 |
| nathan_akin[m] | hello gouthamr thanks for the detailed feedback. i've addressed all three comments in patchset 6 removed the internal tuple unpacking from the policy check test and replaced it with a behavioral test, updated the call_args assertions to use .args and .kwargs, and cleaned up the commit message to have a single Change-Id and Signed-off-by, thank you https://review.opendev.org/c/openstack/manila/+/982050. | 19:32 |
| nathan_akin[m] | gouthamr: Oh noted | 19:35 |
| gouthamr | hey nathan_akin[m], looks like all your changes are stacked one on top of the other | 19:51 |
| nathan_akin[m] | gouthamr: Oh let me check | 19:51 |
| gouthamr | they all seem unrelated to me.. | 19:52 |
| gouthamr | you can rebase them on master directly via gerrit if you'd like, or just fix things locally and send it back to gerrit | 19:52 |
| nathan_akin[m] | ok ill do just that, thanks | 19:52 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: [CephFS driver] Make update_access idempotent when share is missing https://review.opendev.org/c/openstack/manila/+/982785 | 19:54 |
| gouthamr | also a reminder to all outreachy interns: | 19:56 |
| gouthamr | if you used AI assistance, please add a commit message tag: https://openinfra.org/legal/ai-policy/ | 19:56 |
| gouthamr | i see a number of changes that certainly look over engineered to have been written by humans.. we allow AI assisted contributions as long as you know what you're doing and you declare it up front using the commit message tag as the policy states | 19:56 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: Replace assertTrue/assertFalse with assertEqual/assertNotEqual https://review.opendev.org/c/openstack/manila/+/982052 | 19:57 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: api-ref: add missing fields to share server responses https://review.opendev.org/c/openstack/manila/+/982058 | 19:57 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: api-ref: fix share_server_id used as path param but defined in body https://review.opendev.org/c/openstack/manila/+/982328 | 19:57 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: api-ref: add missing availability_zone to replica responses https://review.opendev.org/c/openstack/manila/+/982329 | 19:57 |
| denver_ba | Hi @Gouthamr, please also check my patches, most have been minor changes , here is a link to my opendev profile instead of adding many single links https://review.opendev.org/q/owner:denverbaraka@gmail.com | 19:58 |
| opendevreview | Silvia Wachira proposed openstack/manila master: Include share network ID in subnet error messages https://review.opendev.org/c/openstack/manila/+/981465 | 19:59 |
| nathan_akin[m] | gouthamr: denver_ba: please read this | 19:59 |
| nathan_akin[m] | gouthamr: thank you i have started doing that | 20:00 |
| opendevreview | Silvia Wachira proposed openstack/manila master: Include share network ID in subnet error messages https://review.opendev.org/c/openstack/manila/+/981465 | 20:07 |
| gouthamr | i tagged all open outreachy changes with a hashtag "outreachy-2026-prospect" | 20:10 |
| denver_ba | sure, seen the change | 20:11 |
| gouthamr | i'll tack that hashtag on any further changes if i see that doesn't have it.. but, this hash tag will help me/carloss keep up with reviews | 20:11 |
| gouthamr | https://review.opendev.org/q/hashtag:outreachy-2026-prospect | 20:11 |
| opendevreview | Merged openstack/manila-ui master: Imported Translations from Zanata https://review.opendev.org/c/openstack/manila-ui/+/982524 | 20:42 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: Allow 'latest' as a valid API version string https://review.opendev.org/c/openstack/manila/+/982536 | 21:05 |
| opendevreview | Meer Hashaam Khan proposed openstack/manila master: Remove stale Keystone v2 reference in client_auth.py https://review.opendev.org/c/openstack/manila/+/982589 | 21:06 |
| opendevreview | Meer Hashaam Khan proposed openstack/manila master: api-ref: Add missing network_allocation_update_support in share network responses The share network view builder returns network_allocation_update_support from API v2.70+, but it was missing from the response parameters in share-networks.inc. Closes-Bug: #2146275 Signed-off-by: Meer Hashaam Khan <hashaamkhan975@gmail.com> https://review.opendev.org/c/openstack/manila/+/982926 | 21:06 |
| nathan_akin[m] | hello everyone, i'm working on a patch to allow 'latest' as a valid API version string in manila similar to how nova handles it. carloss mentioned it's been discussed before and worth getting more opinions on. is this something the team would want to support, or is there a reason manila intentionally avoids it? patch is here if anyone wants to take a look https://review.opendev.org/c/openstack/manila/+/982536 | 21:07 |
| gouthamr | maybe add that to the weekly meeting to get some more opinions | 21:07 |
| nathan_akin[m] | gouthamr: ok i will thanks | 21:08 |
| opendevreview | Merged openstack/manila master: Fix typos and formatting errors in parameters.yaml https://review.opendev.org/c/openstack/manila/+/982063 | 21:14 |
| carloss | nathan_akin[m]: worth adding a topic here https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting for that purpose | 21:14 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: Remove deprecated contrib/ci scripts https://review.opendev.org/c/openstack/manila/+/982509 | 21:14 |
| nathan_akin[m] | carloss: ok let me do that now | 21:15 |
| carloss | thank you! | 21:17 |
| opendevreview | Merged openstack/manila master: api-ref: Fix project_id reference in share-networks add security service https://review.opendev.org/c/openstack/manila/+/982218 | 21:18 |
| opendevreview | Merged openstack/manila master: Add metadata to share replica API docs https://review.opendev.org/c/openstack/manila/+/982140 | 21:19 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: api-ref: add missing availability_zone to replica responses https://review.opendev.org/c/openstack/manila/+/982329 | 21:43 |
| opendevreview | Merged openstack/python-manilaclient master: fix stale API examble and typo in user/api.rst https://review.opendev.org/c/openstack/python-manilaclient/+/982303 | 21:50 |
| opendevreview | Meer Hashaam Khan proposed openstack/manila master: api-ref: Add missing network_allocation_update_support in share network responses The share network view builder returns network_allocation_update_support from API v2.70+, but it was missing from the response parameters in share-networks.inc. Closes-Bug: #2146275 Signed-off-by: Meer Hashaam Khan <hashaamkhan975@gmail.com> https://review.opendev.org/c/openstack/manila/+/982926 | 21:51 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: NetApp driver: raise clear error on non-2xx HTTP responses https://review.opendev.org/c/openstack/manila/+/982787 | 22:03 |
| opendevreview | Meer Hashaam Khan proposed openstack/manila master: api-ref: Add network_allocation_update_support https://review.opendev.org/c/openstack/manila/+/982926 | 22:07 |
| opendevreview | Amarachi Ogbonnaya proposed openstack/manila master: Add documentation for Shared File Systems telemetry https://review.opendev.org/c/openstack/manila/+/982149 | 22:24 |
| opendevreview | Roger Koranteng proposed openstack/manila master: Hitachi HSP: Add configurable TLS certificate verification https://review.opendev.org/c/openstack/manila/+/982292 | 22:40 |
| opendevreview | Meer Hashaam Khan proposed openstack/manila master: api-ref: Add network_allocation_update_support https://review.opendev.org/c/openstack/manila/+/982926 | 22:52 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: api-ref: fix share_server_id used as path param but defined in body https://review.opendev.org/c/openstack/manila/+/982328 | 23:24 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: Force delete share when host service is down https://review.opendev.org/c/openstack/manila/+/982791 | 23:33 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: api-ref: document metadata param in manage snapshot https://review.opendev.org/c/openstack/manila/+/982508 | 23:39 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: [CephFS driver] Make update_access idempotent when share is missing https://review.opendev.org/c/openstack/manila/+/982785 | 23:49 |
| opendevreview | Simon Dodsley proposed openstack/manila master: WIP: Add Everpure FlashArray driver https://review.opendev.org/c/openstack/manila/+/795180 | 23:54 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!