| opendevreview | Amarachi Ogbonnaya proposed openstack/manila master: api-ref: fix scheduler_hints min_version to 2.67 https://review.opendev.org/c/openstack/manila/+/982727 | 03:29 |
|---|---|---|
| opendevreview | Goutham Pacha Ravi proposed openstack/manila stable/2026.1: Migrate grenade resources.sh from manila CLI to openstack CLI https://review.opendev.org/c/openstack/manila/+/983509 | 05:38 |
| opendevreview | Merged openstack/manila master: Move module-level docstring to the top in client_auth.py https://review.opendev.org/c/openstack/manila/+/983151 | 05:43 |
| opendevreview | Amarachi Ogbonnaya proposed openstack/manila master: Fix access rule deletion not completing https://review.opendev.org/c/openstack/manila/+/983367 | 07:33 |
| opendevreview | Merged openstack/manila master: Migrate grenade resources.sh from manila CLI to openstack CLI https://review.opendev.org/c/openstack/manila/+/981631 | 08:51 |
| opendevreview | Silvia Wachira proposed openstack/manila master: Improve test coverage for subnet delete failure cases https://review.opendev.org/c/openstack/manila/+/983520 | 08:57 |
| opendevreview | Silvia Wachira proposed openstack/manila master: Improve test coverage for subnet delete failure cases https://review.opendev.org/c/openstack/manila/+/983520 | 09:12 |
| opendevreview | Fiyin Peter proposed openstack/python-manilaclient master: Add missing unit tests for share_network_subnets metadata methods https://review.opendev.org/c/openstack/python-manilaclient/+/983522 | 09:51 |
| stephenfin | carloss: Sorry, I was out last week. Regarding https://review.opendev.org/c/openstack/manila/+/965781, iirc, there was a performance issue but that was simply disguising the issue. I thought gouthamr found the root cause in the end but I must be misremembering | 10:05 |
| opendevreview | Denver Baraka proposed openstack/python-manilaclient master: Improve test coverage for v2/share_transfers https://review.opendev.org/c/openstack/python-manilaclient/+/983547 | 12:29 |
| opendevreview | Silvia Wachira proposed openstack/python-manilaclient master: Fix DictColumn JSON serialization error https://review.opendev.org/c/openstack/python-manilaclient/+/981744 | 13:11 |
| opendevreview | Silvia Wachira proposed openstack/python-manilaclient master: Fix DictColumn JSON serialization error https://review.opendev.org/c/openstack/python-manilaclient/+/981744 | 13:59 |
| carloss | stephenfin: ack, thanks! I think we got it to work now | 14:03 |
| carloss | Saurabh - o/ hey there saw your message earlier this week but as you got disconnected, you would not get the reply unless you looked at the channel logs | 14:04 |
| Saurabh | Trying to add a new Manila driver for HPE storage. Are these rules absolutely mandatory1. Drivers must support read-write and read-only access levels for each supported protocol ===> Our storage only supports R/w for all clients and there is no support for making it read-only 2. Drivers must implement a share extend function that allows share size to be increased. ===> In our storage there no concept of size for a share and the share can occupy | 14:04 |
| carloss | Saurabh: please take a look at https://docs.openstack.org/manila/latest/contributor/irc-quick-and-dirty.html for IRC connection, I think this can help not getting disconnected | 14:06 |
| carloss | Saurabh: good questions. We expect that the drivers can restrict the access to the shares by design, so I'm not sure it would be the end of the world to be able to only grant RW access to shares | 14:07 |
| carloss | this needs to be discussed with more people though | 14:07 |
| carloss | the part that is more concerning is 2. - in Manila, in the share creation, we need to allocate quotas (which also helps with billing in some cases), but sizes more importantly are used in a lot of places like scheduling new shares and determining which storage the request should go to | 14:09 |
| carloss | the quota part, where admins expect that tenants can control how much quota a share is using | 14:09 |
| Saurabh | Yeah, I wanted to clarify these before trying to add a new driver. The read-only and the share size might come in future versions of HPE storage but I wanted to know if I need to wait until it's implemented on HPE side before trying to add new driver code or if it would be ok to do it right now with the limitations | 14:09 |
| carloss | I could keep going on the importance of share size | 14:09 |
| carloss | that said, I think this is a good topic for our PTG in a couple of weeks | 14:10 |
| carloss | if you'd like to gather more members from the community, please add the topic to https://etherpad.opendev.org/p/hibiscus-ptg-manila-planning | 14:10 |
| carloss | and we'll discuss it | 14:10 |
| carloss | if you'd like to have this discussion sooner, we can also do it during one of our manila weekly meetings https://wiki.openstack.org/wiki/Manila/Meetings | 14:11 |
| carloss | they happen every Thursday | 14:11 |
| carloss | at 15:00 UTC | 14:11 |
| carloss | weekly meetings are text only, PTGs are an actual meeting in a room with other people and we usually have more time for discussions like this | 14:12 |
| opendevreview | Joy Akinyi proposed openstack/manila master: Fix missing share_networks in security service show https://review.opendev.org/c/openstack/manila/+/983347 | 14:31 |
| opendevreview | Olamide Ojo proposed openstack/manila master: Add unit test for delete share clone https://review.opendev.org/c/openstack/manila/+/981873 | 15:12 |
| opendevreview | Olamide Ojo proposed openstack/manila master: Add test for delete_share unexpected backend exception https://review.opendev.org/c/openstack/manila/+/982181 | 15:13 |
| opendevreview | Olamide Ojo proposed openstack/manila master: Add unit test for delete share clone https://review.opendev.org/c/openstack/manila/+/981873 | 15:13 |
| opendevreview | Olamide Ojo proposed openstack/manila master: Add unit test for create_share with share group ID https://review.opendev.org/c/openstack/manila/+/982704 | 15:13 |
| opendevreview | Olamide Ojo proposed openstack/manila master: Add unit tests for ceph_mon_version property https://review.opendev.org/c/openstack/manila/+/981606 | 15:14 |
| opendevreview | Olamide Ojo proposed openstack/manila master: Add unit tests for CephFS driver uncovered lines https://review.opendev.org/c/openstack/manila/+/965900 | 15:14 |
| opendevreview | Olamide Ojo proposed openstack/manila master: Add manage_existing resize test for CephFS https://review.opendev.org/c/openstack/manila/+/981861 | 15:15 |
| nathan_akin[m] | hey carloss gouthamr sorry i have a question. For api-ref response samples that include admin only fields like host and topic in share backup responses, is the convention to show a single sample with null for those fields, or should we provide a separate admin response example showing them populated? | 15:20 |
| nathan_akin[m] | I noticed some resources like share servers have separate admin samples but others don't seem to follow a consistent pattern. | 15:20 |
| OlamideOjo[m] | <nathan_akin[m]> "hey carloss gouthamr sorry i..." <- > <@nathan_akin:matrix.org> hey carloss gouthamr sorry i have a question. For api-ref response samples that include admin only fields like host and topic in... (full message at <https://matrix.org/oftc/media/v1/media/download/AXxZvKWxKKQHm739eVycB2Y4Ns5wmphYvmmnosdyR3b3c9rQ6ssOh2JMbxbatwca-ytCETr6YPSnY38EPy20SHtCedsLV7WAAG1hdHJpeC5vcmcvWnBLTXZUZFFpaWtaVnBRa05lZEdoQWtE>) | 15:42 |
| nathan_akin[m] | OlamideOjo[m]: Yes exactly, share servers have quite a few admin only fields so a separate sample makes sense there. For share backups it's just host and topic, so I'm not sure if that warrants a separate sample or if null is enough that's why I'm asking the mentors. | 15:44 |
| OlamideOjo[m] | nathan_akin[m]: Okay we would wait, but IMO, I feel that’s the reason and that’s why I asked the question | 15:46 |
| *** profcorey1 is now known as profcorey | 15:48 | |
| SilviaWachira[m] | <nathan_akin[m]> "hey carloss gouthamr sorry i..." <- I'm also curious to know if there are there any existing guidelines in the Manila contributor docs about when a separate admin sample is warranted or if it is mostly decided case by case based on how many admin-only fields there are? | 15:54 |
| nathan_akin[m] | <OlamideOjo[m]> "Okay we would wait, but IMO, I..." <- Yeah actually | 16:13 |
| opendevreview | Simon Dodsley proposed openstack/manila master: WIP: Add Everpure FlashArray driver https://review.opendev.org/c/openstack/manila/+/795180 | 16:48 |
| gouthamr | nathan_akin[m]: i don't have a strong opinion on this.. the option's description at the very least should clarify the policy that the option would be based off of - the API sample may be less useful given that we update those opportunistically | 16:51 |
| nathan_akin[m] | gouthamr: oh got it, thank you, So I'll make sure the parameter descriptions in parameters.yaml clearly state that host and topic are only visible to administrators. The samples showing null should be fine as it is then. | 16:54 |
| gouthamr | nathan_akin[m]: i'd check the actual policy around the parameters.. we're trying to avoid using the catch-all "is_admin" check in a number of places | 16:56 |
| opendevreview | Simon Dodsley proposed openstack/manila master: WIP: Add Everpure FlashArray driver https://review.opendev.org/c/openstack/manila/+/795180 | 17:00 |
| nathan_akin[m] | gouthamr: Thanks for pointing that out. I checked and host/topic in backup responses are gated by check_is_host_admin, which resolves to the context_is_host_admin policy rule which is role:admin and project_id. I was going to update the descriptions in parameters.yaml to reference the specific policy rule rather than just saying "only visible to administrators" something like "Visible to users with the context_is_host_admin | 17:01 |
| nathan_akin[m] | policy". Does that sound like the right approach to do from my end , or is there a preferred way | 17:01 |
| gouthamr | yeah that sounds good, nathan_akin[m] | 17:02 |
| nathan_akin[m] | oh okk thankss, ill check it out | 17:02 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: api-ref: add missing backup_type, host and topic to share backup responses https://review.opendev.org/c/openstack/manila/+/983463 | 17:03 |
| -opendevstatus- NOTICE: Load on the opendev.org Gitea backends is under control again for now, if any Zuul jobs failed with SSL errors or disconnects reaching the service prior to 16:15 UTC they can be safely rechecked | 17:03 | |
| opendevreview | Denver Baraka proposed openstack/python-manilaclient master: Improve test coverage for v2/share_backups https://review.opendev.org/c/openstack/python-manilaclient/+/983604 | 17:06 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: api-ref: document targeted restore for share backups (microversion 2.91) https://review.opendev.org/c/openstack/manila/+/983607 | 17:34 |
| opendevreview | Merged openstack/manila-tempest-plugin master: Add share server subnet filter tempest tests https://review.opendev.org/c/openstack/manila-tempest-plugin/+/981671 | 17:56 |
| opendevreview | Silvia Wachira proposed openstack/python-manilaclient master: Remove past-due deprecated kwargs from v1 and v2 clients https://review.opendev.org/c/openstack/python-manilaclient/+/983616 | 18:44 |
| opendevreview | Silvia Wachira proposed openstack/python-manilaclient master: Remove past-due deprecated kwargs from v1 and v2 clients https://review.opendev.org/c/openstack/python-manilaclient/+/983616 | 18:53 |
| opendevreview | Meer Hashaam Khan proposed openstack/manila master: My first test commit https://review.opendev.org/c/openstack/manila/+/983650 | 21:42 |
| hashaaam | Review request please: https://review.opendev.org/c/openstack/manila/+/983392 PS3 updated, Zuul green (Verified +1). Thanks! | 21:58 |
| rogerkorantenng | Hi gouthamr, carlos, I've uploaded patchset 2 addressing the review comments for Hitachi HSP: Add configurable TLS certificate verification. Would appreciate your review when you get a chance. https://review.opendev.org/c/openstack/manila/+/982292 Thanks! | 22:04 |
| opendevreview | Fiyin Peter proposed openstack/python-manilaclient master: Add missing unit tests for share_export_locations metadata methods https://review.opendev.org/c/openstack/python-manilaclient/+/983661 | 23:23 |
| opendevreview | Meer Hashaam Khan proposed openstack/python-manilaclient master: Add unit tests for share export location metadata APIs https://review.opendev.org/c/openstack/python-manilaclient/+/983662 | 23:32 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!