| opendevreview | Fiyin Peter proposed openstack/manila master: doc: document encryption_key_ref prerequisites and microversion https://review.opendev.org/c/openstack/manila/+/983951 | 01:19 |
|---|---|---|
| opendevreview | Meer Hashaam Khan proposed openstack/manila master: Add api_audit_map.conf for CADF audit middleware https://review.opendev.org/c/openstack/manila/+/983952 | 01:44 |
| hashaaam | Hi all, I've submitted a fix for bug #1929936 (missing api_audit_map.conf for Manila). The patch adds the audit map file, wires it into api-paste.ini with a keystone_audit pipeline, and includes admin docs. Review at: https://review.opendev.org/c/openstack/manila/+/983952 Would appreciate reviews when you get a chance. Thanks! | 01:46 |
| opendevreview | Medha Choudhary proposed openstack/manila-tempest-plugin master: Add replication_policy metadata tests for SnapMirror policies https://review.opendev.org/c/openstack/manila-tempest-plugin/+/983154 | 07:34 |
| opendevreview | Olamide Ojo proposed openstack/manila master: use openstack cli commands https://review.opendev.org/c/openstack/manila/+/946272 | 08:36 |
| opendevreview | Kimberly Cruz proposed openstack/manila master: Add JSON schema validation for show share transfer https://review.opendev.org/c/openstack/manila/+/983987 | 08:44 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: api-ref: add missing backup_type, host and topic to share backup responses https://review.opendev.org/c/openstack/manila/+/983463 | 08:49 |
| nathan_akin[m] | hi gouthamr i am just following up , I was assigned the backup_type api-ref bug in yesterday's meeting. I already have a patch up for it https://review.opendev.org/c/openstack/manila/+/983463. I've also updated the commit message to correctly reference the bug number. | 08:51 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: api-ref: add missing backup_type, host and topic to share backup responses https://review.opendev.org/c/openstack/manila/+/983463 | 09:12 |
| opendevreview | Nikita Skakun proposed openstack/manila master: Share server migration complete should adjust device id on ports https://review.opendev.org/c/openstack/manila/+/983052 | 09:35 |
| opendevreview | Nikita Skakun proposed openstack/manila master: NetApp error in get_performance_counters when node is down https://review.opendev.org/c/openstack/manila/+/981476 | 10:00 |
| opendevreview | Nikita Skakun proposed openstack/manila master: Fix NetApp perf counter retrieval when node down https://review.opendev.org/c/openstack/manila/+/981476 | 10:17 |
| opendevreview | Nikita Skakun proposed openstack/manila master: Adjust device_id on ports after share server migration https://review.opendev.org/c/openstack/manila/+/983052 | 10:21 |
| opendevreview | Nikita Skakun proposed openstack/manila master: Adjust device_id on ports after migration https://review.opendev.org/c/openstack/manila/+/983052 | 10:22 |
| opendevreview | Nikita Skakun proposed openstack/manila master: Adjust device_id on ports after migration https://review.opendev.org/c/openstack/manila/+/983052 | 10:25 |
| opendevreview | Medha Choudhary proposed openstack/manila-tempest-plugin master: Add replication_policy metadata tests for SnapMirror policies https://review.opendev.org/c/openstack/manila-tempest-plugin/+/983154 | 11:31 |
| opendevreview | Fiyin Peter proposed openstack/manila master: api-ref: fix "a export" grammar in export location metadata docs https://review.opendev.org/c/openstack/manila/+/984008 | 11:53 |
| opendevreview | Silvia Wachira proposed openstack/python-manilaclient master: Improve --share-type help text for share create https://review.opendev.org/c/openstack/python-manilaclient/+/984010 | 11:55 |
| comfortoyewole[m] | Hello gouthamr @_oftc_gouthamr:matrix.org: | 11:59 |
| comfortoyewole[m] | In the manila-tempest-plugin repository, when a test case is decorated with @ddt.data('version-1', 'version-2'), both the test method and the setUp() function are executed once for each version. | 11:59 |
| comfortoyewole[m] | The current version can be accessed in the test method by including a version parameter in its signature, is there a way to access the current version within the setUp() method as well? | 11:59 |
| opendevreview | Silvia Wachira proposed openstack/python-manilaclient master: Improve --share-type help text for share create https://review.opendev.org/c/openstack/python-manilaclient/+/984010 | 12:25 |
| opendevreview | Fiyin Peter proposed openstack/manila master: api-ref: document metadata in Create share network subnet endpoint https://review.opendev.org/c/openstack/manila/+/984020 | 13:08 |
| opendevreview | Saikumar Pulluri proposed openstack/manila master: Derive Barbican endpoint path from service catalog https://review.opendev.org/c/openstack/manila/+/983705 | 13:09 |
| carloss | > The current version can be accessed in the test method by including a version parameter in its signature, is there a way to access the current version within the setUp() method as well? | 13:58 |
| carloss | comfortoyewole[m] you can pick that up from the configuration option in case you're looking for the latest version, rather than the test version | 13:58 |
| comfortoyewole[m] | carloss: I noticed that too, I was able to get the latest version from the configuration option with `config.CONF`, but what I’m looking to access is the version under test inside the setup() method. | 14:07 |
| carloss | comfortoyewole[m]: which test are you referring to? | 14:08 |
| comfortoyewole[m] | I’m running the test in this file: `manila-tempest-plugin/manila_tempest_tests/tests/api/test_security_services_mapping.py`, particularly the `test_map_ss_to_sn_and_list` test case. | 14:11 |
| carloss | comfortoyewole[m]: in that case you won't be able to access the version in the setup because of the way this is designed | 14:12 |
| carloss | the setup is overriding its base class setup, meaning the setup method is called before the test is run | 14:13 |
| carloss | when setup is called, the test doesn't even exist | 14:13 |
| comfortoyewole[m] | Okay. I guess I’d create a utility method to create the test case instead. | 14:15 |
| SilviaWachira[m] | Hi carloss and gouthamr I was reviewing python-novaclient’s deprecation policy but couldn’t find similar guidance for python-manilaclient. Should we follow the same conventions? Also, should a DeprecationWarning be raised at parse time or only when the deprecated argument is actually consumed? | 14:30 |
| carloss | SilviaWachira[m]: you mean for the manilaclient? | 14:39 |
| carloss | like the shell commands? | 14:39 |
| SilviaWachira[m] | Yes, carloss. specifically for CLI arguments, such as --group-specs and --extra-specs, which I'm deprecating in my current patches in favor of --spec and --extra-spec. | 15:47 |
| opendevreview | Comfort Oyewole proposed openstack/manila-tempest-plugin master: Remove status field from security services API https://review.opendev.org/c/openstack/manila-tempest-plugin/+/845603 | 15:54 |
| comfortoyewole[m] | Hi @car | 15:59 |
| opendevreview | Fiyin Peter proposed openstack/python-manilaclient master: Add missing share backup and share transfer sections to CLI docs https://review.opendev.org/c/openstack/python-manilaclient/+/984064 | 16:12 |
| comfortoyewole[m] | opendevreview: Hi [carloss](https://matrix.to/#/@_oftc_carloss:matrix.org), [gouthamr](https://matrix.to/#/@_oftc_gouthamr:matrix.org), while working on fixing this, I noticed 2 failing tests:... (full message at <https://matrix.org/oftc/media/v1/media/download/AfiEoig_UTyjBS_78NITldn_Su40DmiptIyli4aeqLpInP4aPLcgevCOscYD7APu2kFWnMvWHJPM-GF5qV_8gsVCedwEoL9QAG1hdHJpeC5vcmcvdWlIWnNhdGh0cFdEQU9PZG11bkZUbVhs>) | 16:19 |
| comfortoyewole[m] | s/carloss/@_oftc_carloss:matrix.org/, s/gouthamr/@_oftc_gouthamr:matrix.org/ | 16:31 |
| comfortoyewole[m] | * Hi [@_oftc_carloss:matrix.org](https://matrix.to/#/@_oftc_carloss:matrix.org), [@_oftc_gouthamr:matrix.org](https://matrix.to/#/@_oftc_gouthamr:matrix.org), while working on fixing this, I noticed 2 failing... (full message at <https://matrix.org/oftc/media/v1/media/download/AcTdt1V1BGSJRa0EEvGOCuHd4tERul_qeh6_q7pGAFyb2V54iwTemLuOY7flCCFNGYVmNcza1TEVXTUnniUMNZJCedwFiNmAAG1hdHJpeC5vcmcvb0R2YlFubmlyVlF1ZHBDdlhkWFlmdFRr>) | 16:35 |
| *** vhari_ is now known as vhari | 16:59 | |
| carloss | comfortoyewole[m]: can you please link me the job that is failing? | 17:32 |
| carloss | I looked at the changes you submitted commits but their failures are different | 17:33 |
| opendevreview | Joses De Carlos proposed openstack/manila master: add share network get schema validation https://review.opendev.org/c/openstack/manila/+/979348 | 19:20 |
| * nathan_akin[m] uploaded an image: (101KiB) < https://matrix.org/oftc/media/v1/media/download/ASogCu0zzbwtLByePK2etYDzOtG0e6PT--Rk7BmWySVroUFJ0t-AqwdZQVV1FpXLOMDgVIrIgU0GYruz0ZdRp8ZCedwRthpAAG1hdHJpeC5vcmcvbkdxRGtYUlJKalR2c0F0aUhITlJJZ2Rh > | 20:08 | |
| nathan_akin[m] | hello good evening gouthamr carloss so i checked Stephen's patches to understand the migration pattern and i tried it locally with share_limits then i migrated the command and tests into python-openstackclient and both tests pass. | 20:08 |
| nathan_akin[m] | but i noticed something actually.... so after migration, the commands still import api_versions from manilaclient for microversion checks, Is that like temporary until the underlying library moves to SDK, or is there a plan to replace those checks with something in openstackclient itself? i would love to understand | 20:10 |
| opendevreview | Fiyin Peter proposed openstack/python-manilaclient master: Fix TestShareRestore tests nested inside setUp https://review.opendev.org/c/openstack/python-manilaclient/+/984122 | 20:11 |
| carloss | SilviaWachira[m]: apologies, I missed your reply. So the manila shell client was removed and we should have no deprecated options/commands at the momeng | 20:25 |
| carloss | > or is there a plan to replace those checks with something in openstackclient itself? | 20:26 |
| carloss | nathan_akin[m] with time, I think we'll naturally shift all to the openstackclient | 20:26 |
| nathan_akin[m] | carloss: oh i understand | 20:27 |
| nathan_akin[m] | thanks for the clarification | 20:27 |
| opendevreview | Fiyin Peter proposed openstack/python-manilaclient master: Add missing share backup and share transfer sections to CLI docs https://review.opendev.org/c/openstack/python-manilaclient/+/984064 | 20:41 |
| opendevreview | Oluwasola Akintewe proposed openstack/manila master: share: fix malformed log format string in create_backup_continue https://review.opendev.org/c/openstack/manila/+/984125 | 20:48 |
| opendevreview | Denver Baraka proposed openstack/manila master: add missing unit tests for manila/share/qos_types https://review.opendev.org/c/openstack/manila/+/984127 | 20:49 |
| SilviaWachira[m] | carloss: carloss: no worries and thank you for the clarification .... (full message at <https://matrix.org/oftc/media/v1/media/download/Abuq3-UZBXlwjaWlZaAyEXoDATpV8s0sikq7iPKLdKqaTNOuFr-MgJgcFV6fTazhuVABUeXtHui8sv7ZlK5QLG9CedwUdkMgAG1hdHJpeC5vcmcvc3BuR0tYQWNkcVpXZmlYQlVmYWJqRFdj>) | 20:56 |
| *** denver is now known as denver_ba | 21:11 | |
| opendevreview | Fiyin Peter proposed openstack/python-manilaclient master: Add missing share export location set and unset to CLI docs https://review.opendev.org/c/openstack/python-manilaclient/+/984130 | 21:11 |
| denver_ba | hi @carloss and @gouthamr, I have been working on improving test coverage for Manila and python-manilaclient. Do you recommend writing missing unit tests as new patches, like what I have done here? https://review.opendev.org/c/openstack/manila/+/984127 Is this a good approach to contribute?? | 21:11 |
| denver_ba | + as the contribution period is almost ending, please advice which type of patches should we list, only merged or all?? | 21:13 |
| denver | @Gouthamr I updated the note for the Ceph drivers here as per your review https://review.opendev.org/c/openstack/manila/+/981633 | 21:17 |
| opendevreview | Denver Baraka proposed openstack/manila master: add missing unit tests for manila/share/qos_types https://review.opendev.org/c/openstack/manila/+/984127 | 21:23 |
| opendevreview | Comfort Oyewole proposed openstack/manila-tempest-plugin master: Remove status field from security services API https://review.opendev.org/c/openstack/manila-tempest-plugin/+/845603 | 21:30 |
| comfortoyewole[m] | carloss: [carloss](https://matrix.to/#/@_oftc_carloss:matrix.org) The failing tests are from local runs. | 21:36 |
| comfortoyewole[m] | carloss: Yeah, I saw that, I’ve fixed those. I’ll share the jobs if they also fail on the patch. | 21:37 |
| opendevreview | Fiyin Peter proposed openstack/python-manilaclient master: Fix dead link, removed CLI reference and typo in contributing.rst https://review.opendev.org/c/openstack/python-manilaclient/+/984137 | 23:37 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!