| srinesh[m] | carloss: gouthamr Sure, for now I will try to go with the approach where in case user tries to set access rules for mountable snapshot, we will error the operation and report that it is not supported through user messages. | 05:39 |
|---|---|---|
| srinesh[m] | In case a separate capability for snapshot allow/deny like the goutham mentioned were to be implemented, would you expect us to implement it. Or it will be taken up as part of this or next release. | 11:06 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Re-enable IPv6 tests https://review.opendev.org/c/openstack/manila-tempest-plugin/+/895211 | 14:04 |
| hong-p[m] | carloss: hi I prepare the spec for availability_zone filter. could you see this? https://review.opendev.org/c/openstack/manila-specs/+/988650 | 15:06 |
| opendevreview | Jonathan Koerber proposed openstack/manila master: api: Add Schema to share: manage share POST v2/share/manage https://review.opendev.org/c/openstack/manila/+/988786 | 16:27 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline momentarily while we restart it onto a new patch release | 18:04 | |
| carloss | > In case a separate capability for snapshot allow/deny like the goutham mentioned were to be implemented, would you expect us to implement it. Or it will be taken up as part of this or next release. | 18:10 |
| carloss | srinesh[m] I think this release would be better, considering that it would already help erroring out earlier | 18:10 |
| carloss | hong-p[m]: sure, will take a look | 18:10 |
| gouthamr | hong-p[m]: carloss: i think the AZ filter not working as intended is a bug | 18:15 |
| carloss | yeah, it should be already there | 18:16 |
| carloss | I could not find it in the API though | 18:21 |
| carloss | however, we do allow az filtering for services | 18:21 |
| gouthamr | yeah looks like it's an omission | 18:21 |
| gouthamr | i'd be inclined to treat this as a bug | 18:22 |
| carloss | I feel like it's a bug though | 18:22 |
| carloss | yeah | 18:22 |
| carloss | there's no reason why not to allow it | 18:22 |
| gouthamr | today, sending the "availability_zone" as a filter will be ignored | 18:22 |
| gouthamr | so you'll get a list of shares regardless of "availability_zone", when we fix this, the users will get a filtered subset | 18:29 |
| gouthamr | we've treated filter additions as API behavior changes warranting a microversion bump | 18:29 |
| gouthamr | this has been contentious | 18:29 |
| gouthamr | other teams have a policy that they published stating that they consider things like this as bug fixes and will still backport without a microversion bump | 18:30 |
| gouthamr | for this issue, i feel the approach other services took seems saner | 18:30 |
| carloss | agreed | 18:34 |
| carloss | the only downside with that is that if a non-existent az is provided at the time of the request, currently the filter is just dropped | 18:35 |
| carloss | and life goes on | 18:35 |
| carloss | with this change, if it's an non-existent az that is part of the request, we might need to raise an exception | 18:36 |
| carloss | which changes the behavior of the API | 18:36 |
| carloss | unless we ignore the failure and life goes on as it does today | 18:36 |
| gouthamr | do we? | 18:36 |
| gouthamr | i mean.. today if you filter by a non-existent name, you would get an empty list? | 18:37 |
| carloss | i might be trippin', but confirming | 18:37 |
| carloss | today, if we filter by a non-existent name, or if we just set *any* azs, we'll get the whole shares list | 18:43 |
| carloss | and it won't filter | 18:43 |
| carloss | https://github.com/openstack/manila/blob/master/manila/api/v2/shares.py#L1468 | 18:43 |
| carloss | share's api _get_share_search_options() method does not have availability zone listed there | 18:43 |
| carloss | > the only downside with that is that if a non-existent az is provided at the time of the request, currently the filter is just dropped and life goes on | 18:44 |
| carloss | meaning this is correct indeed | 18:44 |
| carloss | https://paste.opendev.org/show/boQhPBYww46fpvzCcCJl/ | 18:46 |
| carloss | maybe we should just preserve the behavior if we're treating this as a bugfix | 18:46 |
| carloss | we ack that an availability zone is part of the request and try to filter shares with it. if it's non-existent, we just return the list of shares if nothing happened | 18:46 |
| carloss | we took a similar approach for service filters: https://github.com/openstack/manila/blob/master/manila/api/v2/services.py#L85 | 18:48 |
| carloss | but in this case instead, we return an empty list | 18:48 |
| carloss | I'd be okay following the same approach | 18:49 |
| gouthamr | +1 | 18:50 |
| gouthamr | and probably wrote this down in the contrib guide | 18:50 |
| gouthamr | "how to handle filters consistently" | 18:51 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila stable/2025.2: Support IPv6 wildcard ::/0 in Ganesha https://review.opendev.org/c/openstack/manila/+/988820 | 20:02 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila stable/2025.1: Support IPv6 wildcard ::/0 in Ganesha https://review.opendev.org/c/openstack/manila/+/988821 | 20:03 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: [DNM] Test IPv6 wildcard ::/0 in CephFS NFS https://review.opendev.org/c/openstack/manila-tempest-plugin/+/988824 | 21:45 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: [DNM] Prove ::/0 bug in CephFS NFS (no fix) https://review.opendev.org/c/openstack/manila-tempest-plugin/+/988825 | 21:48 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Re-enable IPv6 tests https://review.opendev.org/c/openstack/manila-tempest-plugin/+/895211 | 22:05 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: [DNM] Test IPv6 wildcard ::/0 in CephFS NFS https://review.opendev.org/c/openstack/manila-tempest-plugin/+/988824 | 22:05 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Re-enable IPv6 tests https://review.opendev.org/c/openstack/manila-tempest-plugin/+/895211 | 22:05 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: [DNM] Prove ::/0 bug in CephFS NFS (no fix) https://review.opendev.org/c/openstack/manila-tempest-plugin/+/988825 | 22:05 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!