| opendevreview | Soyoon Lee proposed openstack/manila master: Fix share list sorting by availability zone https://review.opendev.org/c/openstack/manila/+/994380 | 00:03 |
|---|---|---|
| opendevreview | Kumar Tadepalli proposed openstack/manila master: NetApp-SnapMirror Active Sync(SM-as) for NAS support https://review.opendev.org/c/openstack/manila/+/991844 | 04:15 |
| itaiweismanweka | gouthamr: hi, just posted a summary comment on change 989998 (Weka share driver) — PS11 addresses all your review feedback, CI is green. Could you take another look when you get a chance? | 05:17 |
| opendevreview | kiran pawar proposed openstack/python-manilaclient master: added properties column to share replica list command https://review.opendev.org/c/openstack/python-manilaclient/+/994409 | 08:27 |
| opendevreview | Claudiu Belu proposed openstack/manila master: tests: Enforce autospec=True on mock patches https://review.opendev.org/c/openstack/manila/+/994191 | 09:38 |
| opendevreview | kiran pawar proposed openstack/python-manilaclient master: added properties column to share replica list command https://review.opendev.org/c/openstack/python-manilaclient/+/994409 | 10:02 |
| opendevreview | kiran pawar proposed openstack/python-manilaclient master: added properties column to share replica list command https://review.opendev.org/c/openstack/python-manilaclient/+/994409 | 10:14 |
| *** vhari_ is now known as vhari | 10:28 | |
| opendevreview | Medha Choudhary proposed openstack/manila master: Fix migration_get_progress to use GET at microversion 2.97 https://review.opendev.org/c/openstack/manila/+/989941 | 10:46 |
| opendevreview | Medha Choudhary proposed openstack/python-manilaclient master: Update migration_get_progress to use GET at microversion 2.97 https://review.opendev.org/c/openstack/python-manilaclient/+/989948 | 10:46 |
| opendevreview | Medha Choudhary proposed openstack/manila-tempest-plugin master: Update migration_get_progress client to use GET at microversion 2.97 https://review.opendev.org/c/openstack/manila-tempest-plugin/+/989949 | 10:47 |
| opendevreview | Medha Choudhary (netapp) proposed openstack/python-manilaclient master: Update migration_progress to use GET at microversion 2.97 https://review.opendev.org/c/openstack/python-manilaclient/+/989948 | 10:49 |
| opendevreview | Srinesh A R proposed openstack/manila master: [WIP] - Snapshot features for Alletra MP B10000 driver https://review.opendev.org/c/openstack/manila/+/992850 | 11:41 |
| opendevreview | Sylvan Le Deunff proposed openstack/manila master: Remove dead share network mocking from test helper https://review.opendev.org/c/openstack/manila/+/994427 | 12:17 |
| opendevreview | Sylvan Le Deunff proposed openstack/manila master: Remove dead share network mocking from test helper https://review.opendev.org/c/openstack/manila/+/994328 | 12:19 |
| stephenfin | gouthamr: carloss: SilviaWachira[m]: I'd like to discuss https://review.opendev.org/c/openstack/python-openstackclient/+/970818 here since there's a lot of back and forth and stuff seems to be getting missed | 13:26 |
| stephenfin | My main issue is this https://review.opendev.org/c/openstack/python-openstackclient/+/970818/comment/aa68e2b4_6041751b/ I don't believe we need to do API version checks during client creation, given we already do these checks on a per-command basis (where a command requires a given MV) and the fact none of the other clients do them. But SilviaWachira[m] presumably added them for some reason, maybe on your request? | 13:28 |
| stephenfin | Have you a good reason for keeping those checks or can we revert something closer to what we had in PS1? https://review.opendev.org/c/openstack/python-openstackclient/+/970818/1..17/openstackclient/share/client.py | 13:28 |
| stephenfin | I'd really like to start merging some of these patches, but this is the base one that we really need to start on | 13:30 |
| opendevreview | Manideep proposed openstack/manila master: NetApp: Fix KeyError 'nas' in REST get_volume_junction_path https://review.opendev.org/c/openstack/manila/+/994439 | 13:51 |
| opendevreview | Manideep proposed openstack/manila master: NetApp: Fix KeyError 'nas' in REST get_volume_junction_path https://review.opendev.org/c/openstack/manila/+/994439 | 13:51 |
| opendevreview | Manideep proposed openstack/manila master: NetApp: Fix KeyError 'nas' in REST get_volume_junction_path https://review.opendev.org/c/openstack/manila/+/994439 | 13:55 |
| opendevreview | Manideep proposed openstack/manila master: NetApp: Fix KeyError 'nas' in REST get_volume_junction_path https://review.opendev.org/c/openstack/manila/+/994439 | 13:57 |
| opendevreview | Manideep proposed openstack/manila master: NetApp: Fix KeyError 'nas' in REST get_volume_junction_path https://review.opendev.org/c/openstack/manila/+/994439 | 13:59 |
| opendevreview | Manideep proposed openstack/manila master: NetApp: Fix KeyError 'nas' in REST get_volume_junction_path https://review.opendev.org/c/openstack/manila/+/994439 | 14:00 |
| gouthamr | stephenfin: SilviaWachira[m]: o/ let me take a look at the code again; yes.. might have gotten refined through our own comments to align with what's working right now in python-manilaclient | 14:08 |
| gouthamr | thanks for flagging it, agree with getting this merged asap; the patch train isn't helping with testing/reviewing :( | 14:08 |
| opendevreview | Gireesh Awasthi proposed openstack/python-manilaclient master: Added python manila client for share server replica https://review.opendev.org/c/openstack/python-manilaclient/+/994502 | 17:18 |
| opendevreview | Gireesh Awasthi proposed openstack/manila master: Added Share Server Replica Support https://review.opendev.org/c/openstack/manila/+/993501 | 17:47 |
| SilviaWachira[m] | stephenfin: I've seen your PS17 comment about the TYPE_CHECKING import — should I go with Option 1 (TYPE_CHECKING block) or Option 2 (just import manilaclient.client at the top level and drop the lazy import)? | 18:04 |
| opendevreview | Claudiu Belu proposed openstack/manila master: tests: Enforce autospec=True on mock patches https://review.opendev.org/c/openstack/manila/+/994191 | 18:11 |
| opendevreview | melanie witt proposed openstack/devstack-plugin-ceph master: Use IPv6 for ceph mon when SERVICE_IP_VERSION=6 https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/986473 | 19:10 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!