| opendevreview | Medha Choudhary proposed openstack/manila master: Fix migration_get_progress to use GET at microversion 2.97 https://review.opendev.org/c/openstack/manila/+/989941 | 05:21 |
|---|---|---|
| opendevreview | Medha Choudhary proposed openstack/python-manilaclient master: Update migration_get_progress to use GET at microversion 2.97 https://review.opendev.org/c/openstack/python-manilaclient/+/989948 | 05:21 |
| opendevreview | Medha Choudhary proposed openstack/manila-tempest-plugin master: Update migration_get_progress client to use GET at microversion 2.97 https://review.opendev.org/c/openstack/manila-tempest-plugin/+/989949 | 05:22 |
| opendevreview | Merged openstack/devstack-plugin-ceph master: Fix RadosGW code path and common bugs https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/978987 | 06:29 |
| opendevreview | Srinesh A R proposed openstack/manila-tempest-plugin master: [WIP] - Add tests for new snapshot_inherit_share_access share type https://review.opendev.org/c/openstack/manila-tempest-plugin/+/994878 | 11:06 |
| opendevreview | Gireesh Awasthi proposed openstack/manila-specs master: Specs for share server replica https://review.opendev.org/c/openstack/manila-specs/+/988495 | 11:40 |
| opendevreview | Medha Choudhary (netapp) proposed openstack/manila master: WIP: Netapp cg-snapshot workflow implementation https://review.opendev.org/c/openstack/manila/+/994884 | 12:13 |
| opendevreview | Srinesh A R proposed openstack/manila-tempest-plugin master: [WIP] - Add tests for new snapshot_inherit_share_access share type https://review.opendev.org/c/openstack/manila-tempest-plugin/+/994878 | 12:42 |
| stephenfin | SilviaWachira[m]: Can you tell me why we need this? https://review.opendev.org/c/openstack/python-openstackclient/+/970818/comment/49ea01b5_3238e4be/ | 14:45 |
| *** vhari_ is now known as vhari | 15:01 | |
| opendevreview | Srinesh A R proposed openstack/manila-tempest-plugin master: [WIP] - Add tests for new snapshot_inherit_share_access share type https://review.opendev.org/c/openstack/manila-tempest-plugin/+/994924 | 15:01 |
| opendevreview | Srinesh A R proposed openstack/manila-tempest-plugin master: [WIP] - Add tests for new snapshot_inherit_share_access share type https://review.opendev.org/c/openstack/manila-tempest-plugin/+/994878 | 15:09 |
| stephenfin | gouthamr: carloss: I've proposed https://review.opendev.org/c/openstack/python-openstackclient/+/994925 and https://review.opendev.org/c/openstack/python-openstackclient/+/994922 as follow-ups to SilviaWachira[m]'s bootstrap patch. If you've time to review today, that should unblock the rest of the stack | 15:10 |
| stephenfin | https://review.opendev.org/c/openstack/python-openstackclient/+/994925/ is important otherwise we'll get inconsistent behavior if python-manilaclient is installed, since commands could come from different places | 15:11 |
| stephenfin | I _think_ the manilaclient commands would be prefered since entrypoint loading is done alphabetically (m < o) but I'd rather not rely on that implementation behavior | 15:12 |
| stephenfin | Also, I am +2 on all current patches in the series now so the ball's back in your court | 15:17 |
| stephenfin | Finally, I am on paternity leave for 4 weeks starting on Monday. I won't be reviewing anything during that time, but if you're happy to continue working through them and reivewing yourself, I'll hit the full stack (and hopefully +W the lot) as soon as I'm back | 15:18 |
| gouthamr | stephenfin: o/ thank you.. that's awesome | 15:28 |
| gouthamr | firstly, congratulations! | 15:28 |
| gouthamr | this is great news.. we'll miss you, and i'll make sure not to tag you in reviews or cause pings in the absence :) | 15:29 |
| gouthamr | i'll take a look at the patches/updates you posted.. ty very much for the help with this, and for guiding SilviaWachira[m] | 15:29 |
| stephenfin | ty! :) | 15:30 |
| opendevreview | Merged openstack/manila-specs master: Add Lustre share driver spec https://review.opendev.org/c/openstack/manila-specs/+/987307 | 15:35 |
| opendevreview | kiran pawar proposed openstack/manila master: Deferred delete share server and share network https://review.opendev.org/c/openstack/manila/+/981706 | 15:41 |
| SilviaWachira[m] | stephenfin: Congratulations! stephenfin | 15:48 |
| JayF | grats stephenfin! enjoy the time away and the new kiddo | 15:49 |
| vhari | big congrats stephenfin! | 16:13 |
| vhari | exciting times :) | 16:13 |
| SilviaWachira[m] | stephenfin: I checked compute, volume, network, and identity client.py on master — none of them call setup_auth(). I'll remove it in a follow-up. | 17:02 |
| stephenfin | SilviaWachira[m]: JayF: vhari: Thanks! :) | 17:03 |
| stephenfin | SilviaWachira[m]: great, thank you. If you can push that update in the next 25 mins or so I can ack it | 17:04 |
| SilviaWachira[m] | stephenfin: My VM is down. I have pinged gouthamr to restart it so I am waiting for him. | 17:09 |
| gouthamr | yikes, doing | 17:09 |
| gouthamr | SilviaWachira[m]: unsure what happened here, but it's done now.. | 17:14 |
| SilviaWachira[m] | gouthamr: Thanks | 17:14 |
| SilviaWachira[m] | stephenfin: 994922 is updated with the setup_auth() removal | 17:28 |
| stephenfin | yup, I'm +2 | 17:29 |
| stephenfin | if gouthamr can take a look we can probably send that into the gate | 17:29 |
| stephenfin | I've +W'd https://review.opendev.org/c/openstack/python-openstackclient/+/970818 | 17:29 |
| SilviaWachira[m] | stephenfin: Thank you! | 17:30 |
| opendevreview | Gireesh Awasthi proposed openstack/manila-specs master: Specs for share server replica https://review.opendev.org/c/openstack/manila-specs/+/988495 | 18:29 |
| opendevreview | Gireesh Awasthi proposed openstack/manila-specs master: Specs for share server replica https://review.opendev.org/c/openstack/manila-specs/+/988495 | 18:35 |
| SilviaWachira[m] | stephenfin, I rebased the stack to resolve the merge conflicts after 970818 merged, but only realized after pushing that the rebase cleared your +2 votes on 970819–970822. I didn't know that would happen, sorry about that. If you have a moment before you go on leave, could you re-+2 those patches? Zuul is currently re-running on all of them. | 19:18 |
| stephenfin | SilviaWachira[m]: I can except you seem to have mistakenly reintroduced some old changes in the process https://review.opendev.org/c/openstack/python-openstackclient/+/970819/24..26 | 19:19 |
| stephenfin | SilviaWachira[m]: mind if I just fix up? | 19:19 |
| SilviaWachira[m] | stephenfin: Please go ahead, thank you! | 19:20 |
| stephenfin | done | 19:31 |
| stephenfin | SilviaWachira[m]: In general, I would advise you to use the `-f` option for git-review | 19:32 |
| stephenfin | That will delete your local copy of the code. When you are working on it next, you can re-download it using `git review -d` | 19:32 |
| gouthamr | ++ | 19:33 |
| stephenfin | This ensures there is only one "source of truth", and you don't end up e.g. accidentally overwriting changes from others | 19:33 |
| stephenfin | SilviaWachira[m]: Additionally, if you want to get an older patchset (revision) of a change (like I just did, where I wanted PS24 for https://review.opendev.org/c/openstack/python-openstackclient/+/970819) you can append the patchset after the change number | 19:34 |
| stephenfin | So e.g. `git review -d 970819,24` or `git review -x 970819,24` | 19:34 |
| SilviaWachira[m] | stephenfin: Thank you so much for fixing this and for the tips, Stephen! | 19:36 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!