| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Use native threading by default https://review.opendev.org/c/openstack/manila/+/997148 | 02:17 |
|---|---|---|
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Guard WSGIService against threading backend https://review.opendev.org/c/openstack/manila/+/997149 | 02:17 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: DNM: Run only Lustre scenario tests https://review.opendev.org/c/openstack/manila-tempest-plugin/+/996955 | 03:18 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Remove eventlet dependency https://review.opendev.org/c/openstack/manila/+/997152 | 03:33 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: DNM: Run only Lustre scenario tests https://review.opendev.org/c/openstack/manila-tempest-plugin/+/996955 | 03:59 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: DNM: Run only Lustre scenario tests https://review.opendev.org/c/openstack/manila-tempest-plugin/+/996955 | 04:00 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Add LUSTRE protocol support and CI job https://review.opendev.org/c/openstack/manila-tempest-plugin/+/996908 | 04:55 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: DNM: Iterate on Lustre scenario tests https://review.opendev.org/c/openstack/manila-tempest-plugin/+/996955 | 04:55 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Add Lustre share driver https://review.opendev.org/c/openstack/manila/+/996907 | 05:14 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Stop parsing WSGI server argv in api entrypoint https://review.opendev.org/c/openstack/manila/+/997161 | 06:15 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Rewrite WSGI deployment guide https://review.opendev.org/c/openstack/manila/+/997162 | 06:15 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Stop parsing WSGI server argv in api entrypoint https://review.opendev.org/c/openstack/manila/+/997161 | 06:22 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Rewrite WSGI deployment guide https://review.opendev.org/c/openstack/manila/+/997162 | 06:22 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Remove eventlet dependency https://review.opendev.org/c/openstack/manila/+/997152 | 07:01 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Stop parsing WSGI server argv in api entrypoint https://review.opendev.org/c/openstack/manila/+/997161 | 07:01 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Rewrite WSGI deployment guide https://review.opendev.org/c/openstack/manila/+/997169 | 07:01 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Stop parsing WSGI server argv in api entrypoint https://review.opendev.org/c/openstack/manila/+/997161 | 07:01 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Rewrite WSGI deployment guide https://review.opendev.org/c/openstack/manila/+/997169 | 07:01 |
| opendevreview | Medha Choudhary (netapp) proposed openstack/manila master: NetApp: Zapi to Rest gaps - configure_cifs_options, default_ad_site and is_kerberos_enabled https://review.opendev.org/c/openstack/manila/+/997073 | 08:43 |
| opendevreview | Medha Choudhary (netapp) proposed openstack/manila master: NetApp: Zapi to Rest gaps - configure_cifs_options, default_ad_site and is_kerberos_enabled https://review.opendev.org/c/openstack/manila/+/997073 | 11:36 |
| opendevreview | Sahil Kumbhar proposed openstack/manila master: share: fix malformed log format strings in backup continuation handlers https://review.opendev.org/c/openstack/manila/+/983702 | 11:57 |
| opendevreview | Sahil Kumbhar proposed openstack/manila master: share: fix malformed log format strings in backup continuation handlers https://review.opendev.org/c/openstack/manila/+/983702 | 12:45 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: Remove rootwrap https://review.opendev.org/c/openstack/manila/+/989170 | 13:58 |
| carloss | o/ zorillas | 14:01 |
| sakumbha | o/ | 14:01 |
| carloss | courtesy ping: dviroel vhari gouthamr carthaca Sai ashrodri gireesh Kumar_T Anoop_Shukla dari-c Silvia-Wachira | 14:01 |
| carloss | time for some bug fun huh? | 14:01 |
| vhari | o/ | 14:02 |
| carloss | welcome sakumbha | 14:02 |
| Anoop_Shukla | O/ | 14:03 |
| Sai | o/ | 14:03 |
| carloss | so we have our bugs list here: | 14:03 |
| carloss | https://etherpad.opendev.org/p/manila-hibiscus-m1-bugsquash | 14:03 |
| carloss | i went through the list myself and tried adding as many notes as I could | 14:04 |
| gouthamr | o/ | 14:04 |
| carloss | for example, all changes that are simply waiting on reviews have "Waiting on reviews" on the notes | 14:04 |
| carloss | or the ones that the authors are likely going to be unresponsive have "Needs assignee" | 14:04 |
| carloss | I think that will help us navigating through the changes more easily | 14:05 |
| carloss | so starting from the top of the list we have a couple of bugs that pretty much need reviews but are lacking reviewers | 14:06 |
| carloss | I'd like to invite you to go through them and sign up for reviews, adding your names to the reviewers list | 14:06 |
| carloss | also, please add your name to the participants list at the top | 14:07 |
| carloss | https://etherpad.opendev.org/p/manila-hibiscus-m1-bugsquash#L6 | 14:07 |
| carloss | let's go through a couple of changes that need some extra attention at the moment | 14:07 |
| carloss | https://etherpad.opendev.org/p/manila-hibiscus-m1-bugsquash#L26 | 14:07 |
| carloss | https://review.opendev.org/c/openstack/manila/+/994439 | 14:07 |
| carloss | thanks Kumar_T for the reviews... Anoop_Shukla Sai can we have someone from the NetApp team looking at the comment Kumar shared? | 14:08 |
| carloss | I'll also review the change. gouthamr already did it too, but would be nice to have that comment sorted out | 14:08 |
| carloss | also, please do let me know if you'd like to remove this bug from the bugsquash list | 14:08 |
| carloss | but honestly I think this is close and we can use the bugsquash momentum to close the bug | 14:09 |
| Sai | > thanks Kumar_T for the reviews... Anoop_Shukla Sai can we have someone from the NetApp team looking at the comment Kumar shared? | 14:10 |
| Sai | Sure carloss | 14:10 |
| Anoop_Shukla | I commented on Kumar’s comment..I think throwing exception should be fine. Let Kumar respond on the comment once..so we can close it | 14:10 |
| carloss | sure, thanks Anoop_Shukla | 14:11 |
| carloss | I'll skip some changes that are pretty much waiting on reviews, as there's not much to talk about them | 14:12 |
| carloss | https://review.opendev.org/c/openstack/manila/+/985679 | 14:12 |
| carloss | just got Kpdev's ping here - will get to it | 14:12 |
| carloss | now skipping to https://etherpad.opendev.org/p/manila-hibiscus-m1-bugsquash#L75 | 14:14 |
| carloss | #link https://bugs.launchpad.net/manila/+bug/2148529 | 14:14 |
| carloss | gouthamr: thanks for the fix | 14:14 |
| carloss | https://review.opendev.org/c/openstack/manila/+/984899 | 14:14 |
| carloss | I see the w-1 | 14:14 |
| carloss | do you think we should keep it as part of the bugsquash, considering it's been hard to reproduce it on CI? | 14:15 |
| gouthamr | this one is "easy" | 14:17 |
| gouthamr | it's not a bug in manila | 14:17 |
| gouthamr | i reported a nfs-ganesha bug, and fixed it up there | 14:18 |
| gouthamr | although we'll need to update ganesha to use this, and there's no urgency imo | 14:18 |
| gouthamr | #link https://gerrithub.io/c/ffilz/nfs-ganesha/+/1237448 | 14:19 |
| gouthamr | #link https://github.com/nfs-ganesha/nfs-ganesha/issues/1396 | 14:19 |
| gouthamr | will update the bug and close it | 14:19 |
| carloss | ack, thank you for the update | 14:20 |
| carloss | and thanks for working on this | 14:20 |
| gouthamr | ++ | 14:21 |
| carloss | next bug that I think requires *some* discussion is: | 14:21 |
| carloss | https://bugs.launchpad.net/manila/+bug/2148041 | 14:21 |
| carloss | thanks for picking this up, sakumbha | 14:21 |
| carloss | and for proposing the fix: | 14:21 |
| carloss | https://review.opendev.org/c/openstack/manila/+/983702 | 14:21 |
| sakumbha | i think two bugs https://bugs.launchpad.net/manila/+bug/2147529 & https://bugs.launchpad.net/manila/+bug/2148041 can be closed with this patch | 14:22 |
| carloss | ack, makes sense. thanks for adding the mention to both in the commit message | 14:22 |
| carloss | you've got my blessing :) | 14:22 |
| carloss | I think other people will get to it soon | 14:23 |
| carloss | I'll abandon the other change | 14:23 |
| gouthamr | ty for tackling this sakumbha | 14:23 |
| Anoop_Shukla | Looks like this is already merged | 14:24 |
| carloss | :) | 14:24 |
| carloss | yep, should make its way to the gate now | 14:25 |
| carloss | moving to the next bug that needs our attention | 14:25 |
| carloss | https://bugs.launchpad.net/manila/+bug/2146277 | 14:25 |
| carloss | we'll also need an assignee for this | 14:26 |
| carloss | https://review.opendev.org/c/openstack/manila/+/982241 | 14:26 |
| carloss | thanks for providing the comments in the change, gouthamr | 14:26 |
| carloss | do we have a volunteer to take this on | 14:26 |
| carloss | this was worked on by an outreach applicant, which I'm not sure will be able to continue the work on the fix | 14:26 |
| carloss | alright, I'll keep the "Needs assignee" | 14:29 |
| carloss | in case people are looking for some other bug to pick up, this will be available | 14:29 |
| carloss | the next one is actually almost the same situation | 14:30 |
| carloss | https://bugs.launchpad.net/manila/+bug/2146268 | 14:30 |
| carloss | https://review.opendev.org/c/openstack/manila/+/982151 | 14:30 |
| carloss | CI is failing and we have some comments provided by gouthamr | 14:30 |
| carloss | we'd need to fix those to get the changes passing on CI and merging | 14:30 |
| carloss | same applies to it :) | 14:31 |
| carloss | moving on... | 14:31 |
| carloss | https://bugs.launchpad.net/manila/+bug/2133203 | 14:31 |
| carloss | https://review.opendev.org/c/openstack/manila/+/970097 | 14:32 |
| carloss | Rajesh proposed the fix and it is an important one | 14:32 |
| carloss | we do have some suggestions as part of the comments though | 14:32 |
| carloss | I can ping Rajesh but if there's no time from their end, I could possibly pick this up | 14:32 |
| carloss | https://bugs.launchpad.net/manila/+bug/2125624 Share backup quotas can't be set | 14:34 |
| carloss | https://review.opendev.org/c/openstack/manila/+/971144 | 14:34 |
| carloss | I was chatting to Zach earlier this week and he mentioned he intends to pick up the changes he has been proposing | 14:35 |
| carloss | so would be nice if we could provide some reviews, even though the change is in merge conflict | 14:35 |
| carloss | this change however is mostly targeted on the client and making the quotas for backups available | 14:35 |
| carloss | it bumps the versions, yes, but our clients are already doing that now | 14:35 |
| gouthamr | sakumbha: do you have bandwidth to tackle https://bugs.launchpad.net/manila/+bug/2146277 and https://bugs.launchpad.net/manila/+bug/2146268 | 14:35 |
| sakumbha | gouthamr: need to check with those bugs | 14:36 |
| gouthamr | please do.. was re-reading my comments, seem like easy ones | 14:36 |
| carloss | sakumbha++ | 14:36 |
| sakumbha | i could try its look 'easy' | 14:36 |
| carloss | awesome | 14:38 |
| carloss | https://bugs.launchpad.net/manila/+bug/2125623 [RFE] Share backups can?t be force deleted | 14:40 |
| carloss | is in a similar situation to the backup quotas | 14:40 |
| carloss | will share reviews | 14:40 |
| carloss | next up | 14:41 |
| carloss | https://bugs.launchpad.net/manila/+bug/2111903 NetApp - Unable to set max-throughput as combining both IOPS and BPS for share creation. | 14:41 |
| carloss | Anoop_Shukla: can we have some netappers eyes here? this contribution comes form an outreachy applicant | 14:42 |
| Anoop_Shukla | Sure! | 14:42 |
| carloss | I have a feeling that this might need some more work | 14:42 |
| carloss | good stuff, thanks | 14:42 |
| Anoop_Shukla | But I see Kumar’s comment that share type is already supporting setting both of them | 14:43 |
| Anoop_Shukla | QOS type* | 14:43 |
| Anoop_Shukla | The idea was to move towards qos type instead of using extra parms.. | 14:44 |
| carloss | oh I see | 14:44 |
| carloss | maybe the bug should no longer be valid then | 14:44 |
| carloss | and the change should be abandoned | 14:44 |
| carloss | i mean, it is valid | 14:45 |
| carloss | but addressed in a different way | 14:45 |
| Anoop_Shukla | Going forward using extra params for QOS should be discouraged IMO | 14:45 |
| carloss | ack | 14:45 |
| gouthamr | downside is that the affected users have to upgrade to get this feature | 14:45 |
| gouthamr | operators* | 14:46 |
| Anoop_Shukla | Yes..depending on which release they are on | 14:46 |
| Anoop_Shukla | But the change looks trivial | 14:46 |
| carloss | yeah | 14:46 |
| Anoop_Shukla | We can go ahead reviewing it, I am not sure if it was tested.. | 14:46 |
| carloss | could be a good backport for older releases | 14:46 |
| carloss | yep, likely not tested | 14:47 |
| Anoop_Shukla | Some NetApp platforms do not support QoS min but just max | 14:47 |
| carloss | more like definitely not tested 😅 | 14:47 |
| Anoop_Shukla | So the change will need to be tested on a platform that supports both | 14:47 |
| carloss | yep | 14:47 |
| Anoop_Shukla | I also see UT coverage for change is missing | 14:48 |
| carloss | ++ | 14:48 |
| Anoop_Shukla | I will be -1 ing with above comments..lets take it forward from there | 14:48 |
| carloss | thanks Anoop_Shukla | 14:48 |
| carloss | next up is | 14:49 |
| carloss | https://bugs.launchpad.net/manila/+bug/2084558 [DOC] Update CLI commands in manage and unmanage snapshots documentation | 14:49 |
| carloss | Change: https://review.opendev.org/c/openstack/manila/+/946272 | 14:49 |
| Anoop_Shukla | This has merge conflicts | 14:51 |
| carloss | well, I think this is because we merged the whole documentation | 14:51 |
| carloss | changes | 14:51 |
| carloss | thanks to gouthamr's series :D | 14:51 |
| carloss | if my memory is not failing me | 14:51 |
| carloss | https://review.opendev.org/c/openstack/manila/+/978275 | 14:52 |
| carloss | https://review.opendev.org/c/openstack/manila/+/978272 | 14:52 |
| carloss | https://review.opendev.org/q/hashtag:%22manila-%3Eopenstackcli%22+(status:open%20OR%20status:merged) | 14:53 |
| carloss | so I think this bug can be closed and the change can be abandoned | 14:53 |
| carloss | done | 14:54 |
| carloss | https://bugs.launchpad.net/manila/+bug/2074114 goodness_function is not applied from conf if driver does not declare it in pool | 14:55 |
| carloss | Change: https://review.opendev.org/c/openstack/manila/+/983040 | 14:55 |
| carloss | is in the same "needs assignee" situation | 14:55 |
| carloss | it is failing CI, but a recheck is needed | 14:55 |
| carloss | which I just triggered | 14:55 |
| carloss | we should see some CI logs soon | 14:55 |
| carloss | https://bugs.launchpad.net/manila/+bug/2020816 LVM driver not enforcing new size when creating share from snapshot | 14:56 |
| carloss | https://review.opendev.org/c/openstack/manila/+/898781 | 14:57 |
| carloss | gouthamr: should we keep this as part of the bugsquash? we'll likely need some fresh logs here too | 14:57 |
| gouthamr | yeah I can look | 14:58 |
| gouthamr | let’s keep it | 14:58 |
| carloss | ack, ty | 14:58 |
| * carloss rechecked the change | 14:58 | |
| carloss | skipping a few of the "needs assignee" | 14:59 |
| carloss | https://bugs.launchpad.net/manila-image-elements/+bug/2160440 | 14:59 |
| carloss | I think this should be closed soon | 14:59 |
| carloss | alright, that was a speed run through bugs that needed some conversation about | 15:00 |
| carloss | do you have another bug you'd like to bring up and discuss as part of this meeting? | 15:00 |
| carloss | let's keep using this channel to discuss bug through this week | 15:00 |
| carloss | I'm tempted to say that the "Outreachy applicant" changes are easy to get in through the week | 15:01 |
| carloss | and would make a huge impact | 15:01 |
| carloss | of course all bugs are equally important, but I think these ones we'll move on quite quickly, we just need a good set of reviewers looking at them | 15:02 |
| carloss | it will help us getting our numbers down | 15:02 |
| carloss | all bug fixes are good potential fixes tbh | 15:02 |
| carloss | so let's try getting as many bugs closed as we can | 15:03 |
| carloss | any other bugs that need attention at the moment? | 15:03 |
| carloss | otherwise, we can wrap up this "meeting" | 15:03 |
| Anoop_Shukla | cool | 15:05 |
| gouthamr | ++ | 15:05 |
| gouthamr | nothing from me | 15:05 |
| carloss | great | 15:06 |
| vhari | carloss, I've reviewed some of the bugs assigned to me, pls feel free to assign me to more bugs as needed | 15:06 |
| carloss | vhari: awesome, thank you | 15:06 |
| sakumbha | thank you! | 15:06 |
| vhari | carloss++ and ty everyone for pitching in | 15:06 |
| carloss | thanks for participating everyone, let's assign ourselves to review some bugs and close as many as we can | 15:06 |
| carloss | we have great potential to get many bugs closed | 15:07 |
| carloss | let's keep chatting on this channel | 15:07 |
| carloss | through the week | 15:07 |
| opendevreview | Merged openstack/manila master: Fix list_extensions() to retry on ConnectFailure https://review.opendev.org/c/openstack/manila/+/986078 | 15:39 |
| opendevreview | Merged openstack/manila master: Reflect rebrand of Pure Storage to Everpure https://review.opendev.org/c/openstack/manila/+/980538 | 15:39 |
| opendevreview | Merged openstack/manila-image-elements master: Modernize container driver docker image https://review.opendev.org/c/openstack/manila-image-elements/+/996927 | 15:42 |
| opendevreview | Merged openstack/manila master: share: fix malformed log format strings in backup continuation handlers https://review.opendev.org/c/openstack/manila/+/983702 | 16:24 |
| opendevreview | Merged openstack/manila-image-elements master: Publish container image to quay.io https://review.opendev.org/c/openstack/manila-image-elements/+/996930 | 17:11 |
| gouthamr | carloss: the quay.io creds seem to have been botched up (mea culpa) | 17:25 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-image-elements master: Fix quay.io credentials for container upload https://review.opendev.org/c/openstack/manila-image-elements/+/997257 | 17:25 |
| gouthamr | let me try again ^ | 17:25 |
| gouthamr | ninja-merged that, because there's no way for anyone to validate what i'm setting there | 17:36 |
| opendevreview | Takashi Kajinami proposed openstack/python-manilaclient master: Direct repository urls to opendev.org https://review.opendev.org/c/openstack/python-manilaclient/+/997279 | 18:20 |
| opendevreview | Takashi Kajinami proposed openstack/python-manilaclient master: Direct repository urls to opendev.org https://review.opendev.org/c/openstack/python-manilaclient/+/997279 | 18:35 |
| opendevreview | Takashi Kajinami proposed openstack/python-manilaclient master: Direct repository urls to opendev.org https://review.opendev.org/c/openstack/python-manilaclient/+/997279 | 18:35 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-image-elements master: Bump buildimages job timeout to 3600s https://review.opendev.org/c/openstack/manila-image-elements/+/997295 | 19:27 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Add Lustre share driver https://review.opendev.org/c/openstack/manila/+/996907 | 19:28 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: LVM: Extend share created from snapshot https://review.opendev.org/c/openstack/manila/+/898781 | 19:50 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Lustre driver: improve unit test coverage https://review.opendev.org/c/openstack/manila/+/997299 | 19:57 |
| opendevreview | Merged openstack/manila-image-elements master: Fix quay.io credentials for container upload https://review.opendev.org/c/openstack/manila-image-elements/+/997257 | 19:59 |
| opendevreview | Merged openstack/python-manilaclient master: Direct repository urls to opendev.org https://review.opendev.org/c/openstack/python-manilaclient/+/997279 | 20:00 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-image-elements master: Add build step to container upload playbook https://review.opendev.org/c/openstack/manila-image-elements/+/997306 | 21:16 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Lustre driver: improve unit test coverage https://review.opendev.org/c/openstack/manila/+/997299 | 21:32 |
| opendevreview | Merged openstack/manila-image-elements master: Bump buildimages job timeout to 3600s https://review.opendev.org/c/openstack/manila-image-elements/+/997295 | 21:35 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Use native threading by default https://review.opendev.org/c/openstack/manila/+/997148 | 22:22 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Guard WSGIService against threading backend https://review.opendev.org/c/openstack/manila/+/997149 | 22:22 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila master: Remove eventlet dependency https://review.opendev.org/c/openstack/manila/+/997152 | 22:22 |
| opendevreview | Merged openstack/manila master: Dell PowerScale: Thin porvisiong feature flag got removed https://review.opendev.org/c/openstack/manila/+/992382 | 22:24 |
| opendevreview | Merged openstack/manila-image-elements master: Add build step to container upload playbook https://review.opendev.org/c/openstack/manila-image-elements/+/997306 | 22:31 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!