| opendevreview | Srinesh A R proposed openstack/manila master: Implement new snapshot_inherit_share_access share capability https://review.opendev.org/c/openstack/manila/+/1000068 | 06:16 |
|---|---|---|
| opendevreview | Srinesh A R proposed openstack/manila master: HPE: Snapshot features for Alletra MP driver https://review.opendev.org/c/openstack/manila/+/992850 | 06:37 |
| opendevreview | Srinesh A R proposed openstack/manila master: HPE: Snapshot features for Alletra MP driver https://review.opendev.org/c/openstack/manila/+/992850 | 06:37 |
| opendevreview | Srinesh A R proposed openstack/manila master: HPE: Snapshot features for Alletra MP driver https://review.opendev.org/c/openstack/manila/+/992850 | 06:45 |
| opendevreview | Srinesh A R proposed openstack/manila-tempest-plugin master: Add tests for new snapshot_inherit_share_access share type https://review.opendev.org/c/openstack/manila-tempest-plugin/+/994878 | 06:58 |
| opendevreview | Manideep proposed openstack/manila-tempest-plugin master: Add tempest tests for share server replication https://review.opendev.org/c/openstack/manila-tempest-plugin/+/998360 | 07:20 |
| opendevreview | Srinesh A R proposed openstack/manila master: Implement new snapshot_inherit_share_access share capability https://review.opendev.org/c/openstack/manila/+/1000068 | 10:23 |
| opendevreview | Srinesh A R proposed openstack/manila master: Implement new snapshot_inherit_share_access_support share capability https://review.opendev.org/c/openstack/manila/+/1000068 | 10:32 |
| opendevreview | Medha Choudhary netapp proposed openstack/manila master: NetApp ONTAP: REST-based CG snapshot lifecycle for share groups https://review.opendev.org/c/openstack/manila/+/994884 | 10:36 |
| opendevreview | Medha Choudhary netapp proposed openstack/manila master: NetApp ONTAP: REST-based CG snapshot lifecycle for share groups https://review.opendev.org/c/openstack/manila/+/994884 | 10:37 |
| opendevreview | Medha Choudhary netapp proposed openstack/manila master: Netapp: Implement ZAPI to REST gaps https://review.opendev.org/c/openstack/manila/+/995364 | 10:37 |
| opendevreview | Medha Choudhary netapp proposed openstack/manila master: NetApp ONTAP: REST-based CG snapshot lifecycle for share groups https://review.opendev.org/c/openstack/manila/+/994884 | 10:48 |
| opendevreview | Medha Choudhary netapp proposed openstack/manila master: Netapp: Implement ZAPI to REST gaps https://review.opendev.org/c/openstack/manila/+/995364 | 10:48 |
| opendevreview | Medha Choudhary netapp proposed openstack/manila master: NetApp ONTAP: REST-based CG snapshot lifecycle for share groups https://review.opendev.org/c/openstack/manila/+/994884 | 10:50 |
| opendevreview | Siddharth Kumar proposed openstack/manila master: Dell PowerStore: Add manage/unmanage share snapshot support https://review.opendev.org/c/openstack/manila/+/993906 | 11:27 |
| opendevreview | Srinesh A R proposed openstack/manila-tempest-plugin master: Add tests for new snapshot_inherit_share_access share type https://review.opendev.org/c/openstack/manila-tempest-plugin/+/994878 | 11:34 |
| opendevreview | Manideep proposed openstack/manila master: Added Share Server Replica Support https://review.opendev.org/c/openstack/manila/+/993501 | 12:31 |
| opendevreview | Manideep proposed openstack/manila master: Added Share Server Replica Support https://review.opendev.org/c/openstack/manila/+/993501 | 16:35 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: Migrate container driver to privsep https://review.opendev.org/c/openstack/manila/+/823579 | 17:10 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: Make LVM's ssh_execute use privsep when running locally https://review.opendev.org/c/openstack/manila/+/993133 | 17:10 |
| opendevreview | Carlos Eduardo proposed openstack/manila master: Remove rootwrap https://review.opendev.org/c/openstack/manila/+/989170 | 17:10 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.openstack.org will be offline momentarily at 18:00 UTC for a patch upgrade (just under an hour from now), but should return within a few minutes. | 17:11 | |
| gouthamr | carloss: any reason for chaining the rootwrap patches? | 17:35 |
| carloss | gouthamr: multiple dependencies from one another and a bunch of merge conflicts that I am trying to solve before pushing all of the changes | 17:35 |
| gouthamr | ah | 17:36 |
| carloss | e.g. container depends on network and depends on lvm (which is at this point merged) | 17:36 |
| carloss | I was dealing with a lot of merge conflicts. this is the way I found to reuse code and don't leave merge conflicts behind | 17:36 |
| carloss | and be able to get reviews in all of the changes without discouraging reviewers to look because there's a merge conflict :) | 17:36 |
| gouthamr | the "merge conflict" hint on gerrit? | 17:37 |
| carloss | > the "merge conflict" hint on gerrit? | 17:37 |
| carloss | yes | 17:37 |
| gouthamr | (i generally ignore that until the final-ish review) | 17:37 |
| carloss | I mean, I hate that this is consuming a lot of CI, that is why I try going through all changes and fixing comments/issues before I submit the whole stack again | 17:38 |
| gouthamr | you have the harder job | 17:38 |
| carloss | I can undo it as well, keep dependencies separate, but that means we all will need to be more vigilant to what happens in one change affecting another... this way I can also already see the impact of one change later on, as it was the case of something I was messing in the manila/data that also impacted ZFS (pretty much OS stuff) | 17:39 |
| gouthamr | let me work through it as it is.. if i see something that can be cleanly rebased on master, i'll flag it in my review | 17:41 |
| gouthamr | the os layer could use some redoing.. it's been bothering me a bit that it's pretty "generic" | 17:41 |
| carloss | ack, thank you | 17:42 |
| carloss | I think generic was a bit intentional at the beginning | 17:42 |
| carloss | at the end it started growing up into a bunch of if/else conditionals to add flags for every specific use case | 17:42 |
| gouthamr | or separate privsep methods can work too... | 17:43 |
| carloss | so really don't mind making changes if we need to be more specific | 17:43 |
| carloss | yep, the networking more recently is doing more separate methods | 17:43 |
| opendevreview | Manideep proposed openstack/manila master: Added Share Server Replica Support https://review.opendev.org/c/openstack/manila/+/993501 | 17:55 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org is going offline momentarily for a patch upgrade, but should return within a few minutes. | 18:02 | |
| carloss | gouthamr: apparently the LVM driver job has been perma-failing since yesterday | 18:06 |
| carloss | https://paste.opendev.org/show/bpHTD158hIqCC4VhczMC/ | 18:06 |
| carloss | starting to look into it now, but it's failing to ssh into the instances | 18:06 |
| carloss | for the scenario tests | 18:06 |
| gouthamr | weird, do you think a newer manila-image-elements image broke it | 18:07 |
| carloss | I don't think so | 18:07 |
| carloss | the weird thing is that the generic driver seems to be passing | 18:07 |
| carloss | so may be and may not be | 18:07 |
| gouthamr | hmm, we can try a pin on an older image and see if it helps. | 18:07 |
| carloss | cephfsnfs also passes | 18:08 |
| carloss | s/pases/fails | 18:08 |
| carloss | but cephfsnative passes 🤔 | 18:08 |
| gouthamr | hmm, an ssh timeout could just mean that the instance isn't sshable before we try | 18:08 |
| carloss | yep | 18:09 |
| gouthamr | i think we've pinned the image for cephfsnative | 18:09 |
| gouthamr | https://github.com/openstack/manila-tempest-plugin/blob/master/zuul.d/manila-tempest-jobs.yaml#L374-L377 | 18:09 |
| carloss | ah, true | 18:09 |
| gouthamr | it could be that the latest images need a different flavor | 18:10 |
| gouthamr | the image grew ~150mb | 18:10 |
| gouthamr | [ ]manila-service-image-1.3.0-77-g8cd2097.qcow22022-06-13 12:00798M | 18:11 |
| gouthamr | [ ]manila-service-image-1.3.0-97-g2ec232a.qcow22026-08-06 21:26951M | 18:11 |
| gouthamr | let's pin the image to manila-service-image-1.3.0-77-g8cd2097.qcow2 and unblock gate | 18:11 |
| carloss | ah, yes! that explains it | 18:11 |
| gouthamr | in the meantime, i can work on https://review.opendev.org/c/openstack/manila-tempest-plugin/+/996973 | 18:11 |
| gouthamr | can you help me merge this: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/998084 | 18:12 |
| gouthamr | vhari: ^ | 18:12 |
| gouthamr | this will be needed for the manila-test-image change | 18:13 |
| carloss | you've got 1/2 blessings :) | 18:14 |
| carloss | I'll pin the image for lvm and cephfsnfs then | 18:14 |
| gouthamr | ++ ty | 18:17 |
| carloss | I'm assuming manila-service-image-1.3.0-76-ga216835.qcow2 can do the trick if I pin it to it | 18:18 |
| carloss | let's see | 18:18 |
| gouthamr | yeah | 18:18 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Use manila-test-image for non-generic driver jobs https://review.opendev.org/c/openstack/manila-tempest-plugin/+/996973 | 18:24 |
| opendevreview | Carlos Eduardo proposed openstack/manila-tempest-plugin master: Pin manila-service-image for LVM and Ceph NFS https://review.opendev.org/c/openstack/manila-tempest-plugin/+/1000141 | 18:40 |
| carloss | ^ hopefully this does the trick - I'll be watching the CI | 18:40 |
| gouthamr | thanks, i can cue it up | 18:49 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-tempest-plugin master: Use manila-test-image for non-generic driver jobs https://review.opendev.org/c/openstack/manila-tempest-plugin/+/996973 | 18:52 |
| gouthamr | ^ rebased on top of your change | 18:52 |
| carloss | ++ | 18:52 |
| gouthamr | ugh, we need crudini in manila-test-image since that's how we set some ceph.conf opts | 20:16 |
| gouthamr | we can "hack" it in | 20:19 |
| gouthamr | \\ | 20:19 |
| opendevreview | Goutham Pacha Ravi proposed openstack/manila-test-image master: Add crudini to client image https://review.opendev.org/c/openstack/manila-test-image/+/1000151 | 20:19 |
| gouthamr | carloss: if you're still around, and can help get this in, we can check if it'll work on the native cephfs job as well.. right now, things are working as expected on lvm/zfsonlinux/cephnfs etc.. | 20:20 |
| carloss | hey | 20:21 |
| carloss | still around | 20:21 |
| * carloss looks | 20:21 | |
| gouthamr | ++ ty | 20:23 |
| carloss | gouthamr: https://review.opendev.org/c/openstack/manila-test-image/+/1000151/1/common-files/usr/bin/crudini#60 | 20:34 |
| * carloss trying to be efficient with reviews and save time looking at sed regexes | 20:35 | |
| carloss | i fed it to claude and got a suggestion that it stops at the first space. So for an existing line like client quota = true, cur_key extracts just client, which won't match the full key client quota. This means the script will never update an existing key that contains spaces — it'll append a duplicate instead. | 20:35 |
| gouthamr | gah, thanks.. | 20:35 |
| carloss | np | 20:36 |
| carloss | am still around, so no rush... can merge whenever you have the patch ready | 20:36 |
| gouthamr | carloss: did claude test this? | 20:37 |
| gouthamr | have it run a test | 20:37 |
| carloss | ah, good question | 20:37 |
| * carloss spending tokens | 20:37 | |
| carloss | :p | 20:37 |
| gouthamr | funny money | 20:38 |
| carloss | https://www.irccloud.com/pastebin/4qFVq8oq/ | 20:40 |
| carloss | ^ my session output | 20:40 |
| carloss | the empty lines below the echos being the "nothing being extracted" | 20:42 |
| gouthamr | wait, why is it rebuilding the regex :P | 20:43 |
| gouthamr | tell it to run the script as is | 20:43 |
| gouthamr | it's webfetching and hallucinating some of the garbled characters perhaps? | 20:44 |
| carloss | yeah, I think so | 20:44 |
| gouthamr | it's gotten me before with that behavior. webfetch doesn't work on JS. It'll do better to grab the patch locally and read from the filesystem | 20:45 |
| gouthamr | here's something i opened a while ago: https://github.com/anthropics/claude-code/issues/36295 | 20:46 |
| carloss | I think all of that was because I added the magic words: is there a regression risk? and shared the url | 20:46 |
| carloss | one more reason to fully switch to gertty :D | 20:46 |
| carloss | thanks man, looks good to me | 20:47 |
| carloss | sorry for the extra noise | 20:47 |
| gouthamr | all good :) thanks for reviewing! | 20:47 |
| * carloss bbiab | 20:47 | |
| opendevreview | Merged openstack/manila-tempest-plugin master: Pin manila-service-image for LVM and Ceph NFS https://review.opendev.org/c/openstack/manila-tempest-plugin/+/1000141 | 21:52 |
| opendevreview | Merged openstack/manila-test-image master: Add crudini to client image https://review.opendev.org/c/openstack/manila-test-image/+/1000151 | 22:37 |
| opendevreview | Merged openstack/manila master: add missing unit tests for manila/share/qos_types https://review.opendev.org/c/openstack/manila/+/984127 | 22:57 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!