Thursday, 2025-07-31

opendevreviewCuiye Liu proposed openstack/manila master: Dell PowerScale: Rename Isilon to PowerScale in Manila Driver  https://review.opendev.org/c/openstack/manila/+/95273602:56
opendevreviewkiran pawar proposed openstack/python-manilaclient master: Add support of encryption_key_ref option for share create  https://review.opendev.org/c/openstack/python-manilaclient/+/93963904:58
kpdevHi @gouthamr04:59
kpdevwe decided to have end user specifying either href or UUID of barbican secret. Please let end user have flexibility to have both the way barbican secret GET API supports both.05:00
kpdevWe have decided and worked and tested that way.05:00
gouthamrsorry, i don't see a reason why we need information we already have, or could be incorrecty05:01
gouthamrmanila talks to barbican over an internal endpoint05:01
gouthamrpresumably05:02
gouthamrwhy would the API need the user to provide a URL that could be a "public" endpoint? 05:02
gouthamrwe discussed this when reviewing the specification05:02
gouthamri see that carloss and haixin made the same points on the server patch.. 05:03
gouthamri guess we're not seeing the use case for accepting a URL, if we did, we'd need to sanitize something like that and extract a UUID from it05:04
kpdevbut carloss agreed to have both https://meetings.opendev.org/irclogs/%23openstack-meeting-alt/%23openstack-meeting-alt.2025-07-10.log.html05:05
gouthamr"otherwise end user everytime need to get href, and parse uuid out of it to provide share create option" - what does this mean?05:06
gouthamrwhere will the end user get this href?05:07
kpdevhref, means barbican secret href05:07
kpdevincluding https05:07
kpdevso end user need to get UUID only out of it and provide for share create API05:07
kpdevso I assume, why not let him provide whole href 05:08
gouthamrhonestly, i'm baffled looking at the secrets API05:09
gouthamri.e., barbican's api-ref05:10
gouthamrkpdev: please don't update patches yet, allow me to review the change completely - might need until EOD 05:10
kpdevI was looking for more convinience as intially someone suggested to allow share create API to accept barbican secnret name as well05:10
kpdevbut thats not possible.05:11
gouthamrname isn't unique is it?05:11
kpdevsince name can not be unique and barbican API does not accept name in GET query05:11
kpdevso we have only UUID and href.05:11
kpdevI am fine with only UUID only. 05:12
gouthamri'd like that, but, i realize now that "openstack secret list" is probably how the user will find the ref to provide05:13
gouthamrsigh05:13
gouthamrbarbican, like most openstack services can have internal and public endpoints, correct?05:14
gouthamrso i find it silly that the API is populating the public endpoint - maybe i don't know why 05:16
kpdevyes, it can have interal and public endpoints.05:18
kpdevmight be on devstack both are same. so we can not take whole href, is it why you want only UUID ?05:18
gouthamrhttps://github.com/openstack/nova/blob/24803136ac82832e1dbaad2244647bc0d08e5ac8/nova/db/main/models.py#L75205:19
gouthamr^ because that's how we're going to use it05:20
gouthamrwhy would we need the href?05:20
kpdevwhile storing in db, we are also storing only UUID05:20
gouthamr*facepalm*05:20
kpdevwhile end user is allowed to specify either05:20
gouthamrso add this optimization to the CLI if you'd like05:21
gouthamrlets keep the API clean with and ensure we are given a UUID05:21
kpdevok, I will remove from manila and keep in manilaclient.05:22
kpdevAnother w.r.t server_encryption_keys quota05:22
kpdevhttps://specs.openstack.org/openstack/manila-specs/specs/flamingo/share_encryption.html this will be specifically server_encryption_keys as we are restrcting number of shareservers with unique keys to be created under project05:23
gouthamryes, this was discussed on the spec - and i merged the spec with the expectation that we'd correct this in the code05:23
kpdevit can not control share encryption keys if any driver in future support share specific encryption keys05:23
gouthamrno, carthaca and i were trying to tell you that whether its share or server encryption, the user shouldn't really care - the administrator drives this with the help of share type extra-specs05:24
gouthamrso, the admin can control the number of keys allowed per project05:24
kpdevthe model is tied with share server  and so I think quota will share_server_encruption keys05:24
kpdev>no, carthaca and i were trying to tell you that whether its share or server encryption, the user shouldn't really care - the administrator drives this with the help of share type extra-specs05:24
kpdevthis is w.r.t end user API option05:24
kpdevuser can specifiy either share encryptio key or share server encryption key05:24
gouthamrand the quota iirc, but, maybe you're talking about some implementation complexity05:25
kpdevbut its not tied with qouta05:25
gouthamrallow me to review the quota implementation, i've not done that yet05:25
kpdevok05:25
gouthamri'll be logging off now, but i'll get back to this later in your day and we can probably chat during the weekly meeting or on the patch directly05:26
kpdevfor end user he specifi key which can be either share or share server encryption key. but for driver supporting share server, quota is used and henec specific to share_server_encryption_keys05:26
kpdevok05:26
gouthamri'll check this part out in your code05:27
opendevreviewCuiye Liu proposed openstack/manila master: Dell PowerScale: Rename Isilon to PowerScale in Manila Driver  https://review.opendev.org/c/openstack/manila/+/95273607:08
opendevreviewCuiye Liu proposed openstack/manila master: Dell PowerScale: Rename Isilon to PowerScale in Manila Driver  https://review.opendev.org/c/openstack/manila/+/95273607:40
opendevreviewJan Jasek proposed openstack/manila-ui master: [WIP] Add manila-ui job and first manila-ui integration tests  https://review.opendev.org/c/openstack/manila-ui/+/95609808:33
opendevreviewOpenStack Proposal Bot proposed openstack/manila-ui master: Imported Translations from Zanata  https://review.opendev.org/c/openstack/manila-ui/+/95622711:10
opendevreviewMerged openstack/manila-ui master: Imported Translations from Zanata  https://review.opendev.org/c/openstack/manila-ui/+/95622712:00
opendevreviewCuiye Liu proposed openstack/manila master: Dell PowerScale: Rename Isilon to PowerScale in Manila Driver  https://review.opendev.org/c/openstack/manila/+/95273615:10
opendevreviewMerged openstack/manila master: sqlalchemy: Use built-in declarative  https://review.opendev.org/c/openstack/manila/+/95375819:47
opendevreviewMerged openstack/devstack-plugin-ceph master: move ceph jobs to debian 12  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/95571421:29
opendevreviewMerged openstack/manila-tempest-plugin master: Fix share type used in negative quota test  https://review.opendev.org/c/openstack/manila-tempest-plugin/+/95604622:37
opendevreviewMerged openstack/manila master: Make create_service_share_servers wait until VM is created  https://review.opendev.org/c/openstack/manila/+/95411222:37
*** tosky_ is now known as tosky22:50

Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!