*** jdaggett has joined #openstack-marconi | 00:36 | |
*** jdaggett has quit IRC | 00:40 | |
*** nosnos has joined #openstack-marconi | 00:45 | |
*** kgriffs_afk is now known as kgriffs | 01:00 | |
*** kgriffs is now known as kgriffs_afk | 01:31 | |
*** kgriffs_afk is now known as kgriffs | 01:32 | |
*** jdaggett has joined #openstack-marconi | 01:36 | |
*** kgriffs is now known as kgriffs_afk | 01:38 | |
*** kgriffs_afk is now known as kgriffs | 01:39 | |
*** jdaggett has quit IRC | 01:41 | |
*** kgriffs is now known as kgriffs_afk | 01:56 | |
*** kgriffs_afk is now known as kgriffs | 02:07 | |
*** kgriffs is now known as kgriffs_afk | 02:41 | |
*** tvb has joined #openstack-marconi | 05:53 | |
*** nosnos has quit IRC | 06:08 | |
*** nosnos has joined #openstack-marconi | 06:54 | |
*** flaper87|afk is now known as flaper87 | 07:58 | |
*** yassine has joined #openstack-marconi | 08:15 | |
openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Move api.py under v1/ since https://review.openstack.org/49698 | 08:38 |
---|---|---|
*** flaper87 is now known as flaper87|afk | 09:00 | |
*** flaper87|afk is now known as flaper87 | 09:05 | |
*** ykaplan has joined #openstack-marconi | 09:14 | |
*** tvb has quit IRC | 09:52 | |
*** tvb has joined #openstack-marconi | 09:53 | |
*** malini has joined #openstack-marconi | 10:30 | |
*** malini has left #openstack-marconi | 10:31 | |
*** malini has joined #openstack-marconi | 11:06 | |
*** flaper87 is now known as flaper87|afk | 11:15 | |
*** tedross has joined #openstack-marconi | 11:26 | |
*** nosnos has quit IRC | 11:32 | |
*** flaper87|afk is now known as flaper87 | 11:51 | |
*** vkmc has joined #openstack-marconi | 11:59 | |
*** vkmc has quit IRC | 11:59 | |
*** vkmc has joined #openstack-marconi | 11:59 | |
*** alcabrera has joined #openstack-marconi | 12:31 | |
alcabrera | Morning. :) | 12:31 |
flaper87 | alcabrera: goood morning | 12:31 |
flaper87 | :) | 12:32 |
alcabrera | flaper87: :D | 12:35 |
*** mpanetta has joined #openstack-marconi | 12:41 | |
alcabrera | oooohh, I saw this in my email just now. | 12:41 |
alcabrera | "Feature freeze is over" | 12:41 |
mpanetta | alcabrera: o/ | 12:42 |
mpanetta | Mornin :) | 12:42 |
alcabrera | mpanetta: o/ | 12:42 |
mpanetta | How goes? | 12:42 |
openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Move api.py under v1/ since https://review.openstack.org/49698 | 12:45 |
alcabrera | Pretty well. I'm possibly not getting enough sleep this week, but alright otherwise. :) | 12:47 |
alcabrera | mpanetta: you? | 12:47 |
*** kgriffs_afk is now known as kgriffs | 12:47 | |
mpanetta | Pretty much the same here :) | 12:48 |
mpanetta | I'm about ready to try and tackle the pypy issue | 12:48 |
alcabrera | sweet | 12:48 |
mpanetta | BTW, I did an install using the native package for pypy, not a source install. | 12:48 |
*** kgriffs is now known as kgriffs_afk | 12:48 | |
*** malini is now known as malini_afk | 12:48 | |
mpanetta | kgriffs_afk: Did we scare you away? :P | 12:48 |
alcabrera | mpanetta: I never do a source install for pypy. It's too long of a process, based on what I've read. I always download the precompiled binary from pypy.org | 12:49 |
*** mpanetta has quit IRC | 12:49 | |
*** mpanetta has joined #openstack-marconi | 12:49 | |
flaper87 | alcabrera: now you scared him | 12:49 |
alcabrera | lol | 12:49 |
flaper87 | :D | 12:49 |
flaper87 | alcabrera: it is indeed LOOONG | 12:49 |
flaper87 | the compilation takes like, FOREVER | 12:50 |
flaper87 | :D | 12:50 |
alcabrera | 2+ hours - maybe longer than building the Linux kernel | 12:50 |
alcabrera | :P | 12:50 |
* flaper87 used to have 1 working copy per branch with a pre-compiled pypy | 12:50 | |
*** mpanetta_ has joined #openstack-marconi | 12:54 | |
*** mpanetta has quit IRC | 12:54 | |
*** mpanetta has joined #openstack-marconi | 12:57 | |
*** mpanetta_ has quit IRC | 12:57 | |
mpanetta | Sorry | 12:57 |
mpanetta | Having network issues | 12:58 |
mpanetta | Trying to get them resolved. | 12:58 |
*** flaper87 is now known as flaper87|afk | 12:58 | |
mpanetta | What did I miss about compiing pypy? | 12:58 |
alcabrera | mpanetta: I'm not sure. I'm tinkering with running a trivial wsgi app using uwsgi + pypy and I'm encountering the same issue. (libpypy-c.so missing) | 13:01 |
mpanetta | alcabrera: That is very odd. | 13:01 |
mpanetta | I wonder what the all mighty google has to say... Let me look :) | 13:02 |
mpanetta | Found in uwsgi docs: "As of August 2013 all of the required patches to PyPy have been merged, so you can get an official source tarball release. Unfortunately you still need to build/translate libpypy-c by yourself, or download one of the following files (they require libssl 1.0):" | 13:03 |
mpanetta | http://uwsgi-docs.readthedocs.org/en/latest/PyPy.html | 13:04 |
mpanetta | afk | 13:04 |
alcabrera | mpanetta: :/ | 13:09 |
alcabrera | That seems like quite the hassle. | 13:09 |
*** jcru has joined #openstack-marconi | 13:17 | |
mpanetta | Yeah | 13:18 |
mpanetta | Bah, I don't get this. Why don't they build and install the library by default? | 13:23 |
*** flaper87|afk is now known as flaper87 | 13:24 | |
flaper87 | fucking network | 13:24 |
alcabrera | mpanetta: That's a great question. My best guess is that since uwsgi is written almost exclusively in C, it has some special entry points that depend on libpypy-c.so being present to use. | 13:25 |
*** malini_afk is now known as malini | 13:28 | |
*** amitgandhi has joined #openstack-marconi | 13:28 | |
*** kgriffs_afk is now known as kgriffs | 13:39 | |
alcabrera | flaper87: Could I get two reviews from you this morning/afternoon? :D | 13:43 |
alcabrera | 1. Proxy logging: https://review.openstack.org/#/c/49585/ | 13:43 |
flaper87 | alcabrera: Absolutely | 13:43 |
alcabrera | 2. [bug] Proxy dups queues: https://review.openstack.org/#/c/49599/ | 13:43 |
alcabrera | flaper87: awesome! :) | 13:43 |
* flaper87 has been heads down on the client | 13:43 | |
flaper87 | we're almost there guys, almost there | 13:44 |
alcabrera | flaper87: I'll review the client code, meanwhile. | 13:44 |
flaper87 | I now need to figure out how the heck I'm going to split all this in several patches | 13:44 |
alcabrera | Ooohh, the patch-splitting problem, haha. I've run into that several times now. :P | 13:44 |
mpanetta | they use scripts to do that for the linux source. | 13:45 |
flaper87 | mpanetta: you need black magic to do that in Python, too many corner cases | 13:46 |
zyuan | alcabrera: i tried a unittest with listing queues, and i got 200. does that mean the bug we met yesterday is fixed? | 13:47 |
flaper87 | In the kernel they get a MiddleFingerException from the compiler if something is wrong | 13:47 |
alcabrera | zyuan: hmmm... it shouldn't be fixed yet. | 13:47 |
alcabrera | flaper87: lol! | 13:47 |
flaper87 | :D | 13:47 |
zyuan | alcabrera: where i got the result. i can't tell the boundary of mocking | 13:48 |
alcabrera | brb | 13:48 |
mpanetta | flaper87: ah | 13:48 |
mpanetta | lol on the exception :P | 13:49 |
alcabrera | back | 13:49 |
mpanetta | wb | 13:52 |
kgriffs | flaper87: i think this one is all set - https://review.openstack.org/#/c/49451/ | 13:55 |
flaper87 | kgriffs: +2'd | 13:56 |
alcabrera | kgriffs: that one is blocked by jenkins. | 13:57 |
flaper87 | kgriffs: FYI, you're allowed to kick jenkins ass, no one will be mad at you for that! | 13:59 |
*** russellb is now known as rustlebee | 14:11 | |
*** jcru has quit IRC | 14:17 | |
*** jcru has joined #openstack-marconi | 14:18 | |
*** flaper87 is now known as flaper87|afk | 14:30 | |
fvollero | :) howdy | 14:31 |
fvollero | alcabrera: I got to deal with other stuff, but i tried to look at proxy app with gunicorn, it miserably fail to start :( | 14:33 |
fvollero | alcabrera: http://ur1.ca/fu1cc | 14:35 |
*** flaper87|afk is now known as flaper87 | 14:36 | |
alcabrera | fvollero: Hey! :D | 14:38 |
fvollero | flaper87: meh | 14:38 |
fvollero | i have a question, there's a pluggable way to use different storage components, correct? | 14:40 |
flaper87 | fvollero: right | 14:43 |
fvollero | flaper87: so I can wake up a morning and add the elasticsearch storage component | 14:43 |
flaper87 | fvollero: right, if you do let me know because I was planning to do so | 14:43 |
flaper87 | :P | 14:44 |
fvollero | flaper87: well well well :) great minds thing alike | 14:44 |
fvollero | s/thing/think/ | 14:44 |
flaper87 | fvollero: feel free to take over and implement it! | 14:44 |
fvollero | flaper87: uhm, you already scratched something ? | 14:44 |
flaper87 | fvollero: alcabrera has a great example of how an external storage plugin repo should look like | 14:44 |
flaper87 | fvollero: alcabrera was working on the redis one in an external repo | 14:45 |
fvollero | flaper87: ok, so i'll take inspiration from the redis one? | 14:45 |
flaper87 | fvollero: nope, just the idea but it should be very similar to Mongodb's | 14:45 |
alcabrera | flaper87, fvollero: That repo needs some clean-up for sure. :P | 14:45 |
alcabrera | The redis one. | 14:45 |
alcabrera | Two hackdays of fighting with stevedore before I knew how to drive stevedore, haha. | 14:46 |
flaper87 | fvollero: take the structure from the redis one and the inspiration from your inner self | 14:46 |
flaper87 | fvollero: ah, and if you want, take a look at Mongodb's backend, that should give you some ideas | 14:46 |
flaper87 | :P | 14:46 |
* flaper87 enjoys trolling fvollero | 14:46 | |
alcabrera | fvollero: the mongodb advice is solid. It's how I got a start with redis backend. | 14:46 |
flaper87 | alcabrera: I'll review your patches in a bit. | 14:50 |
alcabrera | fvollero: I just took a look at that error! | 14:51 |
alcabrera | (http://paste.fedoraproject.org/44328/97310138/) | 14:51 |
alcabrera | You need to update your six module. | 14:51 |
fvollero | alcabrera: yep :) i sorted out few secs ago :D | 14:52 |
fvollero | flaper87: yeah yeah yeah... /me remind to smash the cocosette left for flavio | 14:53 |
* fvollero hugs flaper87 | 14:53 | |
fvollero | alcabrera: thanks :) i'm gonna take a look at both in a sec | 14:54 |
flaper87 | fvollero: wait wait wait wait, lets not get to aggressive! Leave that poor cocosette in its box right next to the others you'll send me | 14:54 |
flaper87 | and yeah, notice the PLURAL!!!!!! | 14:54 |
flaper87 | :D | 14:54 |
fvollero | flaper87: hahahahahhahaha | 14:54 |
fvollero | flaper87: i don't know how much i can make them last :) (Also the Toronto chocolates) | 14:55 |
*** tvb has quit IRC | 14:55 | |
flaper87 | fvollero: http://s.f87.me/176jyTv | 14:57 |
fvollero | flaper87: hahaahhahaah | 14:58 |
fvollero | alcabrera: redis support is...in ? | 14:58 |
*** amitgandhi has quit IRC | 14:59 | |
*** amitgandhi has joined #openstack-marconi | 14:59 | |
alcabrera | fvollero: redis support is stuck. I haven'y had time to work on it. :P | 15:01 |
* alcabrera eats the cocosette | 15:01 | |
*** alcabrera is now known as alcabrera|afk | 15:03 | |
*** alcabrera|afk is now known as alcabrera | 15:05 | |
*** kgriffs is now known as kgriffs_afk | 15:11 | |
*** kgriffs_afk is now known as kgriffs | 15:15 | |
*** kgriffs is now known as kgriffs_afk | 15:16 | |
fvollero | alcabrera: ahhahahahaha | 15:19 |
*** ayoung_ has joined #openstack-marconi | 15:27 | |
*** ayoung_ is now known as ayoung | 15:28 | |
*** flaper87 is now known as flaper87|afk | 15:39 | |
*** yassine has quit IRC | 15:41 | |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(proxy): listing opts returns lists https://review.openstack.org/49595 | 15:42 |
*** whenry has quit IRC | 15:47 | |
*** whenry has joined #openstack-marconi | 16:00 | |
alcabrera | zyuan: +2 ^^ | 16:05 |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: fix: listing queue fails when detailed=True https://review.openstack.org/49783 | 16:11 |
*** amitgandhi is now known as amitgandhi_afk | 16:11 | |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: fix: do not duplicate queues across partitions https://review.openstack.org/49599 | 16:14 |
alcabrera | flaper87|afk: Could you add a default implementation of __contains__() to oslo.cache.backends so that 'key in cache' works? :D | 16:16 |
alcabrera | I noticed this feature while handling some code review a moment ago. | 16:17 |
*** mpanetta has quit IRC | 16:23 | |
*** mpanetta has joined #openstack-marconi | 16:23 | |
*** alcabrera is now known as alcabrera|afk | 16:34 | |
*** tvb has joined #openstack-marconi | 16:35 | |
*** flaper87|afk is now known as flaper87 | 16:37 | |
flaper87 | alcabrera|afk: I wanted to avoid having magic methods there, TBH, | 16:38 |
flaper87 | alcabrera|afk: that will lead to having __getitem__ __setitem__ and whatnot | 16:38 |
flaper87 | which I'm not fully opposed to but it's definitely something to consider | 16:38 |
*** alcabrera|afk is now known as alcabrera | 16:38 | |
alcabrera | flaper87: ah, cool. Thanks for the rationale! | 16:39 |
alcabrera | I can understand that. | 16:39 |
flaper87 | FIRE IN THE HOLE!!!!! | 16:39 |
openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Split get_transport into 2 different functions https://review.openstack.org/49786 | 16:39 |
openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Make the request object API aware https://review.openstack.org/49787 | 16:39 |
openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Implement HTTP Transport https://review.openstack.org/49788 | 16:39 |
openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Complete refactor of api.py https://review.openstack.org/49698 | 16:39 |
alcabrera | flaper87: silly fact, though - even hacking.py thinks that 'key in cache' is the preferred method, hahaha. | 16:39 |
alcabrera | I had to add # noqa to the line 'cache.has_key'. :P | 16:39 |
alcabrera | flaper87: wooooot - client patches! awesome! | 16:40 |
flaper87 | alcabrera: ahhhhhhh right, mmh, I think I changed that in the implementation | 16:40 |
flaper87 | weird | 16:40 |
flaper87 | It should be exists | 16:40 |
flaper87 | instead of has_key | 16:40 |
flaper87 | alcabrera: https://review.openstack.org/#/c/32544/15/openstack/common/cache/backends.py | 16:40 |
flaper87 | line 79 | 16:40 |
flaper87 | looks like we've an old version | 16:41 |
flaper87 | alcabrera: lets see how it goes with the split thing, hopefully the dependancy chain is right | 16:41 |
alcabrera | flaper87: we have an old version. :P | 16:41 |
alcabrera | I verified it just now. | 16:41 |
flaper87 | alcabrera: mind updating it ? | 16:42 |
flaper87 | alcabrera: sorry for not having reviewed your patches yet | 16:42 |
alcabrera | flaper87: no worries, and thanks for commiting to it! :) | 16:42 |
flaper87 | I'll do it today before you leave, that's for sure! | 16:42 |
alcabrera | Awesome! | 16:42 |
flaper87 | alcabrera: I had all those client things in my head and I was afraid to forget something | 16:43 |
alcabrera | The two are small patches, and will help greatly while debugging the proxy in our test environments. :) | 16:43 |
alcabrera | esp. the logging | 16:43 |
alcabrera | flaper87: I understand entirely. I'll probably be heads down on some proxy features very soon. | 16:44 |
flaper87 | alcabrera: Should this be error? LOG.warning('GET v1 - no partitions registered') | 16:46 |
flaper87 | Since an error is raised right after that log line | 16:46 |
alcabrera | flaper87: yup, that's a good call. The system fails hard if no partitions are registered. | 16:46 |
alcabrera | I'll update that. | 16:46 |
flaper87 | alcabrera: there are 2 cases like that | 16:46 |
flaper87 | alcabrera: reviewed the first | 16:47 |
flaper87 | brb | 16:47 |
alcabrera | k | 16:48 |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: add logging to proxy https://review.openstack.org/49585 | 16:48 |
alcabrera | flaper87: I'm going to hold off on porting over the oslo.cache changes until the critical proxy [bug] is merged. Once that is merged, I'll update the code to use cache.exists rather than cache.has_key and update the marconi instance of oslo.cache. | 16:54 |
*** fvollero is now known as fvollero|gone | 16:57 | |
*** jdaggett has joined #openstack-marconi | 17:14 | |
*** jdaggett has quit IRC | 17:16 | |
*** amitgandhi_afk is now known as amitgandhi | 17:24 | |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: fix: do not duplicate queues across partitions https://review.openstack.org/49599 | 17:31 |
*** flaper87 is now known as flaper87|afk | 17:40 | |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: fix: listing queue fails when detailed=True https://review.openstack.org/49783 | 17:45 |
*** jdaggett has joined #openstack-marconi | 17:46 | |
alcabrera | zyuan: +2 | 17:48 |
zyuan | thanks | 17:51 |
*** jdaggett has quit IRC | 17:51 | |
zyuan | alcabrera: i tried to send mock DELETE, but it has no visible effect. cache problem again? | 17:54 |
*** jdaggett has joined #openstack-marconi | 17:58 | |
*** kgriffs_afk is now known as kgriffs | 18:05 | |
alcabrera | zyuan: shouldn't be - cache is invalidated from the patch you depend on if DELETE queue => HTTP 2xx | 18:07 |
alcabrera | kgriffs: o/ | 18:07 |
kgriffs | yo | 18:08 |
zyuan | alcabrera: i guess i know what's wrong (my problem, probably) | 18:13 |
zyuan | you know waht, we should use contextmgrs... | 18:15 |
zyuan | it's not too late. let me draft one. | 18:15 |
alcabrera | zyuan: cmgrs +1 | 18:16 |
kgriffs | zyuan: https://review.openstack.org/#/c/49783/2/tests/unit/proxy/test_queues.py | 18:31 |
kgriffs | L114 | 18:31 |
kgriffs | won't those queues get removed when their partitions are deleted @ L52? | 18:32 |
zyuan | kgriffs: it seems that the data is still there | 18:33 |
kgriffs | hmm | 18:33 |
alcabrera | kgriffs: they won't get removed - partition delete does not trigger queue deletion (yet) | 18:33 |
amitgandhi | kgriffs: meeting | 18:33 |
zyuan | i guess the partition is gone, but since the marconi servers are mocked... | 18:33 |
zyuan | yea. i think | 18:33 |
zyuan | with self.templqueue(...): | 18:34 |
zyuan | looks better | 18:34 |
zyuan | temp_queue('q1', 'q2', ...) | 18:34 |
*** jdaggett has quit IRC | 18:46 | |
*** jergerber has quit IRC | 19:02 | |
openstackgerrit | Kurt Griffiths proposed a change to openstack/marconi: chore: Rename MONGODB_TEST_LIVE to MARCONI_TEST_MONGODB https://review.openstack.org/49451 | 19:03 |
*** alcabrera is now known as alcabrera|afk | 19:04 | |
*** amitgandhi has quit IRC | 19:07 | |
*** amitgandhi has joined #openstack-marconi | 19:09 | |
*** jdaggett has joined #openstack-marconi | 19:09 | |
openstackgerrit | A change was merged to openstack/marconi: chore: Rename MONGODB_TEST_LIVE to MARCONI_TEST_MONGODB https://review.openstack.org/49451 | 19:20 |
openstackgerrit | Kurt Griffiths proposed a change to openstack/marconi: chore: Designate semi-private "friend" helper methods as such https://review.openstack.org/49812 | 19:28 |
*** malini is now known as malini_afk | 19:44 | |
*** oz_akan_ has joined #openstack-marconi | 19:52 | |
oz_akan_ | kgriffs: around? | 19:53 |
kgriffs | yeah | 19:55 |
*** jdaggett has quit IRC | 20:06 | |
*** alcabrera|afk is now known as alcabrera | 20:15 | |
*** amitgandhi has quit IRC | 20:17 | |
*** amitgandhi has joined #openstack-marconi | 20:18 | |
*** ykaplan has quit IRC | 20:20 | |
alcabrera | kgriffs: ping | 20:26 |
alcabrera | Just made it out of a lengthy meeting. :P | 20:26 |
alcabrera | I'm up for discussion on <name change> lookup.py | 20:26 |
*** jdaggett has joined #openstack-marconi | 20:28 | |
*** tvb has quit IRC | 20:29 | |
alcabrera | kgriffs: I'm about to head out, but I've responded with comments inline. Let me know your thoughts, and if you agree, I'll file a bug report when I get a chance (probably Monday morning). | 20:35 |
kgriffs | oh, ok | 20:35 |
kgriffs | we uh, sorta need this ASAP. :p | 20:35 |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: fix: do not duplicate queues across partitions https://review.openstack.org/49599 | 20:36 |
alcabrera | kgriffs: I did fix up the 'q:' 'p:' stuff already. :D | 20:37 |
kgriffs | alcabrera: yeah, I'm fine with doing the refactoring in a followup patch | 20:37 |
alcabrera | The only thing I'm not addressing atm is refactoring lookup.py | 20:37 |
alcabrera | cool | 20:37 |
alcabrera | and test_queues.py does depend on that L94 that executes the create queue logic. | 20:38 |
kgriffs | quick clarification before you go on that | 20:38 |
kgriffs | you are creating a queue that already exists, so you get 204 | 20:39 |
kgriffs | but | 20:39 |
kgriffs | wouldn't there be an entry in the catalogue from the previous operation to create the queue? | 20:39 |
kgriffs | or are you mocking me?! | 20:39 |
kgriffs | ;) | 20:40 |
kgriffs | i mean, how did the queue get "created" in the first place without being also put into the catalogue? | 20:40 |
alcabrera | lol | 20:40 |
* kgriffs thinks everyone is secretly mocking him | 20:41 | |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(test): queue context for proxy https://review.openstack.org/49830 | 20:41 |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: fix: listing queue fails when detailed=True https://review.openstack.org/49783 | 20:41 |
mpanetta | I'm feeling mocked :P The latest code does not work. :P | 20:42 |
alcabrera | That test needs to include a note that it's to account for a situation where the catalogue and queues have already grown inconsistent, so if the queues-storage returns a 204, the catalogue store does not get updated. | 20:42 |
kgriffs | ah | 20:46 |
kgriffs | yes | 20:46 |
kgriffs | please add teh notez | 20:46 |
alcabrera | kgriffs: will do, then I'm out. :) | 20:47 |
zyuan | kgriffs: i just noticed that HTTPBadRequestBody are overused by me | 20:47 |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: fix: do not duplicate queues across partitions https://review.openstack.org/49599 | 20:51 |
alcabrera | kgriffs: comments addressed. :D | 20:51 |
alcabrera | I wrote an epic note there while I worked out how this scenario could ever come to be. | 20:51 |
alcabrera | (short of mocking kgriffs. :P ) | 20:51 |
*** malini_afk is now known as malini | 20:51 | |
zyuan | kgriffs: ping | 20:54 |
kgriffs | hey | 20:55 |
zyuan | but my patch which uses BadRequestBody again is reasonable | 20:55 |
zyuan | wait... | 20:55 |
zyuan | header is not a part of body... | 20:56 |
zyuan | ok... | 20:56 |
zyuan | and about the error message | 20:56 |
zyuan | python gives | 20:56 |
zyuan | "badly formed hexadecimal UUID string" | 20:56 |
zyuan | i think that's enough... | 20:56 |
zyuan | re BadRequestBody, we need a distinct BadRequest for input validation | 20:58 |
*** tvb has joined #openstack-marconi | 21:01 | |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(api): give validation resp a different title https://review.openstack.org/49837 | 21:11 |
*** mpanetta has quit IRC | 21:12 | |
kgriffs | zyuan: "badly formed hexadecimal UUID string" | 21:13 |
zyuan | ? | 21:13 |
kgriffs | it is ok, except who knows what it might change to in a future version of python? Also, it sounds awkward and I think we can make it more human-friendly. | 21:13 |
kgriffs | also, we can't do translations on result from str(ex) | 21:14 |
kgriffs | i.e., _(str(ex)) doesn't work | 21:14 |
kgriffs | (or, at least, hacking/pyflakes complains if you try it) | 21:15 |
zyuan | can i duplicate error messages (smile) | 21:16 |
zyuan | let me seee... only 2 places in total | 21:16 |
zyuan | ah, try except around. it seems that it worth a function | 21:17 |
alcabrera | Have a great weekend, guys. :) | 21:23 |
*** ykaplan has joined #openstack-marconi | 21:23 | |
*** alcabrera has quit IRC | 21:24 | |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(api): give validation resp a different title https://review.openstack.org/49837 | 21:25 |
*** vkmc has quit IRC | 21:28 | |
*** tedross has quit IRC | 21:32 | |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(api): Client-ID is now a real UUID https://review.openstack.org/49378 | 21:32 |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(api): Client-ID is now a real UUID https://review.openstack.org/49378 | 21:37 |
openstackgerrit | Kurt Griffiths proposed a change to openstack/marconi: Log names of drivers being loaded. https://review.openstack.org/49843 | 21:37 |
openstackgerrit | A change was merged to openstack/marconi: fix: do not duplicate queues across partitions https://review.openstack.org/49599 | 21:42 |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(test): queue context for proxy https://review.openstack.org/49830 | 21:45 |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: fix: listing queue fails when detailed=True https://review.openstack.org/49783 | 21:45 |
*** jcru has quit IRC | 21:46 | |
openstackgerrit | A change was merged to openstack/marconi: feat(proxy): listing opts returns lists https://review.openstack.org/49595 | 21:46 |
*** malini is now known as malini_afk | 21:48 | |
zyuan | kgriffs: don't forget https://review.openstack.org/#/c/49783/ (not sure whether you can merge it, but it's a ... bug) | 21:49 |
kgriffs | done | 21:50 |
kgriffs | :D | 21:50 |
kgriffs | thanks! | 21:50 |
zyuan | kgriffs: thank you. have a good weekend! | 21:50 |
kgriffs | likewise, man. take care. | 21:51 |
openstackgerrit | A change was merged to openstack/marconi: fix: listing queue fails when detailed=True https://review.openstack.org/49783 | 21:52 |
*** oz_akan_ has quit IRC | 22:06 | |
*** amitgandhi has quit IRC | 22:16 | |
openstackgerrit | Kurt Griffiths proposed a change to openstack/marconi: feat: add logging to proxy https://review.openstack.org/49585 | 22:28 |
*** kgriffs is now known as kgriffs_afk | 22:31 | |
*** ametts has quit IRC | 23:03 | |
*** oz_akan_ has joined #openstack-marconi | 23:18 | |
*** oz_akan_ has quit IRC | 23:22 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!