| *** reed has quit IRC | 00:41 | |
| *** nosnos has joined #openstack-marconi | 00:43 | |
| *** tedross has joined #openstack-marconi | 01:15 | |
| *** amitgandhi has quit IRC | 01:26 | |
| *** openstack has joined #openstack-marconi | 01:34 | |
| *** amitgandhi has joined #openstack-marconi | 02:03 | |
| *** tedross has quit IRC | 02:19 | |
| *** amitgandhi has quit IRC | 02:37 | |
| *** amitgandhi has joined #openstack-marconi | 02:40 | |
| *** malini is now known as malini_afk | 02:55 | |
| *** openstackgerrit has quit IRC | 03:16 | |
| *** openstackgerrit has joined #openstack-marconi | 03:17 | |
| *** vkmc has quit IRC | 03:24 | |
| *** amitgandhi has quit IRC | 03:37 | |
| *** amitgandhi has joined #openstack-marconi | 04:07 | |
| *** metral has quit IRC | 04:12 | |
| *** amitgandhi has quit IRC | 04:24 | |
| *** metral has joined #openstack-marconi | 04:38 | |
| *** amitgandhi has joined #openstack-marconi | 04:49 | |
| *** amitgandhi has quit IRC | 05:07 | |
| *** amitgandhi has joined #openstack-marconi | 05:32 | |
| *** amitgandhi has quit IRC | 05:34 | |
| *** amitgandhi1 has joined #openstack-marconi | 05:34 | |
| *** amitgandhi1 has quit IRC | 05:51 | |
| *** amitgandhi has joined #openstack-marconi | 06:16 | |
| *** amitgandhi1 has joined #openstack-marconi | 06:18 | |
| *** amitgandhi has quit IRC | 06:18 | |
| *** amitgandhi1 has quit IRC | 06:46 | |
| *** amitgandhi has joined #openstack-marconi | 07:11 | |
| *** amitgandhi1 has joined #openstack-marconi | 07:14 | |
| *** amitgandhi has quit IRC | 07:14 | |
| *** amitgandhi1 has quit IRC | 07:33 | |
| *** amitgandhi has joined #openstack-marconi | 07:57 | |
| *** yassine has joined #openstack-marconi | 08:13 | |
| *** amitgandhi has quit IRC | 08:17 | |
| *** amitgandhi has joined #openstack-marconi | 08:43 | |
| *** amitgandhi has quit IRC | 08:54 | |
| *** nosnos has quit IRC | 09:12 | |
| *** nosnos has joined #openstack-marconi | 09:13 | |
| *** nosnos has quit IRC | 09:17 | |
| *** amitgandhi has joined #openstack-marconi | 09:49 | |
| *** amitgandhi has quit IRC | 09:54 | |
| *** amitgandhi has joined #openstack-marconi | 10:50 | |
| *** amitgandhi has quit IRC | 10:55 | |
| *** amitgandhi has joined #openstack-marconi | 11:50 | |
| *** tedross has joined #openstack-marconi | 12:09 | |
| *** amitgandhi has quit IRC | 12:25 | |
| *** alcabrera has joined #openstack-marconi | 12:28 | |
| alcabrera | Good morning! | 12:28 |
|---|---|---|
| *** oz_akan_ has joined #openstack-marconi | 12:29 | |
| *** jcru has joined #openstack-marconi | 12:34 | |
| *** vkmc has joined #openstack-marconi | 12:37 | |
| *** amitgandhi has joined #openstack-marconi | 12:56 | |
| *** amitgandhi has quit IRC | 13:01 | |
| *** fvollero|gone is now known as fvollero | 13:11 | |
| *** malini_afk is now known as malini | 13:17 | |
| *** mpanetta has joined #openstack-marconi | 13:21 | |
| mpanetta | Morning all | 13:28 |
| mpanetta | kgriffs_afk: when you get in, I would like to continue where we left off yesterday. | 13:28 |
| malini | good morning!! | 13:28 |
| mpanetta | malini: Morning! | 13:29 |
| mpanetta | And yes, it will be good :) | 13:29 |
| malini | of course!! | 13:30 |
| alcabrera | mpanetta, malini: Morning. :) | 13:33 |
| malini | howdy alcabrera? | 13:35 |
| *** amitgandhi has joined #openstack-marconi | 13:35 | |
| mpanetta | Morning alcabrera! | 13:38 |
| *** ametts has joined #openstack-marconi | 13:59 | |
| mpanetta | morning ametts | 14:00 |
| ametts | Howdy. | 14:00 |
| alcabrera | ametts: hey! :) | 14:05 |
| ametts | Howdy otra vez | 14:07 |
| alcabrera | ¡gracias! | 14:08 |
| *** amitgandhi has quit IRC | 14:16 | |
| *** amitgandhi has joined #openstack-marconi | 14:16 | |
| *** jergerber has joined #openstack-marconi | 14:26 | |
| *** tedross has quit IRC | 14:33 | |
| alcabrera | zyuan, kgriffs_afk, flaper87|afk, ametts: pre-review completed on the admin API feature line and the catalogue storage driver. Reviews needed for those. Let me know if you have questions. :D | 14:35 |
| *** whenry has joined #openstack-marconi | 14:43 | |
| *** amitgandhi has quit IRC | 14:43 | |
| *** whenry has quit IRC | 14:45 | |
| *** whenry has joined #openstack-marconi | 14:46 | |
| malini | alcabrera: Can you post the links for all the patches ready for review? | 15:04 |
| alcabrera | malini: sure thing | 15:05 |
| alcabrera | Here they come! | 15:05 |
| alcabrera | (in order, too) | 15:05 |
| alcabrera | 1. https://review.openstack.org/#/c/50701/ | 15:05 |
| alcabrera | 2. https://review.openstack.org/#/c/50702/ | 15:05 |
| alcabrera | 3. https://review.openstack.org/#/c/50721/ | 15:06 |
| alcabrera | 4. https://review.openstack.org/#/c/50815/ | 15:06 |
| alcabrera | 5. https://review.openstack.org/#/c/50998/ | 15:06 |
| alcabrera | 6. https://review.openstack.org/#/c/52160/ | 15:06 |
| alcabrera | malini: that's all of them. | 15:06 |
| malini | thx alcabrera | 15:06 |
| alcabrera | the first five are the admin API feature line, and the last one is the catalogue storage driver. | 15:06 |
| *** kgriffs_afk is now known as kgriffs | 15:08 | |
| alcabrera | kgriffs: o/ | 15:08 |
| malini | alcabrera: where do the sharding logs live? dont they need an entry in marconi-queues.conf-sample ? | 15:09 |
| alcabrera | malini: they're logged as part of marconi-queues.conf | 15:09 |
| alcabrera | the sharding component is a new feature on the core marconi-queues project, so they live together. :) | 15:09 |
| malini | So it'll be the same location as marconi server logs ? | 15:10 |
| alcabrera | yup | 15:10 |
| alcabrera | good question, though! Thanks for considering that. Logging wasn't something that came to mind beyond making sure that the transpoprt resource was indicating what was going on. | 15:11 |
| *** tedross has joined #openstack-marconi | 15:11 | |
| alcabrera | **came to my mind... | 15:11 |
| *** whenry has quit IRC | 15:15 | |
| kgriffs | hey there. reviewing ur patches now | 15:16 |
| alcabrera | kgriffs: awesome! I'm working on the eom:bastion and responding to everett's questions now. :) | 15:16 |
| kgriffs | rock on | 15:17 |
| alcabrera | We're getting great feedback. I | 15:17 |
| alcabrera | I'll add his thoughts to the wiki when I'm down. | 15:17 |
| alcabrera | api.next~ | 15:17 |
| alcabrera | *done | 15:17 |
| malini | everett's feedback caught be my surprise.. | 15:18 |
| malini | I thought we meant to return 404 when queue is not found for GET messages | 15:18 |
| malini | as in here https://wiki.openstack.org/wiki/Marconi/specs/api/v1/errors#Get_Messages | 15:18 |
| alcabrera | hmmm | 15:19 |
| malini | did we change something to intentionally return 204 on GET message non existing queue? | 15:19 |
| alcabrera | not quite | 15:19 |
| alcabrera | I see what happened | 15:19 |
| malini | The only valid case we return 204 on non existing is delete | 15:19 |
| alcabrera | Yes, we return 404 when we do GET /v1/queues/not_exists | 15:19 |
| alcabrera | However | 15:19 |
| alcabrera | We return 204 for the case of GET /v1/queues/not_exists/messages | 15:20 |
| kgriffs | oops | 15:20 |
| kgriffs | sounds like a bug | 15:20 |
| malini | to me too | 15:20 |
| alcabrera | I think I also recall the rationale for this. | 15:20 |
| malini | I was abt to open one, but the docs explanation confused me | 15:20 |
| alcabrera | It hjad something to do with treating that endpoint as a filtering endpoint. | 15:20 |
| alcabrera | Either way | 15:20 |
| alcabrera | 404 seems like the right call there | 15:20 |
| malini | yes..let me open tht bug now | 15:21 |
| kgriffs | i haven't caught up on my email - was that the feedback, that we should return 404 there? | 15:21 |
| malini | kgriffs: yes | 15:21 |
| kgriffs | ok | 15:21 |
| alcabrera | yup, that's the gist of it. | 15:21 |
| kgriffs | malini, have you confirmed the bug yourself? | 15:21 |
| malini | GET /messages on a non existing queue should return 404. we currently return 204 | 15:21 |
| alcabrera | Now that I've recalled the rationale and understand the situation better, writing this email will be a breeze. :D | 15:22 |
| malini | yes..I confirmed it | 15:22 |
| kgriffs | ok | 15:22 |
| alcabrera | awesome | 15:22 |
| kgriffs | i will give this high priority to fix | 15:22 |
| kgriffs | we are getting behind on bugs, btw | 15:22 |
| malini | kgriffs: I didnt have a test for tht :-$ | 15:22 |
| kgriffs | need to get sharding done! | 15:22 |
| malini | will add a test as well | 15:22 |
| alcabrera | malini: thanks! | 15:22 |
| kgriffs | malini: i'm sure you will remedy that. ;) | 15:22 |
| alcabrera | Whoever writes the fix should also add a unit test for this scenario. | 15:23 |
| alcabrera | I'll volunteer once I roll out the bastion. | 15:23 |
| alcabrera | Unless someone gets to it first. ;D | 15:23 |
| malini | alcabrera: are you responding to Everett? | 15:25 |
| alcabrera | kgriffs, malini: are either of you filing the bug report atm? | 15:26 |
| alcabrera | malini: yes :) | 15:26 |
| malini | https://bugs.launchpad.net/marconi/+bug/1243752 | 15:26 |
| malini | Plz include the bug in the response | 15:26 |
| alcabrera | malini: Thanks! | 15:26 |
| alcabrera | Was about to, heh. :) | 15:26 |
| malini | thanks!! | 15:26 |
| zyuan | kgriffs: there was no such a bug, but flavio wanted to make it 204 due to performance, and we agreed | 15:28 |
| kgriffs | problem is it is confusing users | 15:28 |
| kgriffs | we need to be careful when balancing implementation details against UC | 15:29 |
| kgriffs | s/UC/UX | 15:29 |
| zyuan | from an API point of view, i +1 for 404 | 15:29 |
| kgriffs | let's try to get it done without sacrificing performance. TBD. | 15:29 |
| zyuan | but practically i just +0 for 204 instead of -1 | 15:29 |
| zyuan | let me take a look | 15:31 |
| kgriffs | kk | 15:31 |
| kgriffs | don't forget to assign yourself to the bug | 15:31 |
| alcabrera | email sent - back to eom:bastion. :) | 15:32 |
| kgriffs | thx | 15:36 |
| kgriffs | alcabrera: re https://review.openstack.org/#/c/50701/12/marconi/queues/transport/wsgi/admin/driver.py | 15:40 |
| kgriffs | is the health endpoint only exposed in admin mode? | 15:41 |
| alcabrera | kgriffs: no, it's exposed in both modes. | 15:41 |
| alcabrera | In the final patch, I actually unify this. Now I realize I double-health'd the app. | 15:41 |
| alcabrera | looking for context... | 15:42 |
| alcabrera | kgriffs: https://review.openstack.org/#/c/50998/5/marconi/queues/transport/wsgi/admin/driver.py | 15:42 |
| mpanetta | double healthed? | 15:43 |
| alcabrera | mpanetta: I add the /v1/health route *twice* when running in admin mode. | 15:43 |
| mpanetta | Oops | 15:43 |
| mpanetta | Ah ok | 15:43 |
| alcabrera | It's harmless, but silly. | 15:43 |
| *** amitgandhi has joined #openstack-marconi | 15:44 | |
| kgriffs | can you make a note to fix that? | 15:45 |
| alcabrera | Will do. I made in the final patch. | 15:45 |
| alcabrera | I'll make another in the initial patch. | 15:45 |
| alcabrera | kgriffs: noted, thanks! | 15:46 |
| alcabrera | **I made one in... | 15:47 |
| zyuan | kgriffs: look at this change c1a564b4 | 15:52 |
| *** jergerber has quit IRC | 15:53 | |
| *** mpanetta is now known as mpanetta_afk | 15:53 | |
| zyuan | if claim does not return 404, how messages do? | 15:53 |
| malini | zyuan: I was abt to update the bug report - 204s for claims on non existing queues :D | 16:03 |
| zyuan | ... | 16:04 |
| zyuan | i go lunch and handle leasing stuff; come back no early then 1:30 | 16:05 |
| alcabrera | brb, grabbing lunch and going for a walk. | 16:06 |
| alcabrera | zyuan: enjoy, and good luck! | 16:06 |
| *** amitgandhi has quit IRC | 16:06 | |
| *** alcabrera is now known as alcabrera|afk | 16:06 | |
| *** amitgandhi has joined #openstack-marconi | 16:06 | |
| *** yassine has quit IRC | 16:16 | |
| *** alcabrera|afk is now known as alcabrera | 16:22 | |
| *** mpanetta_afk is now known as mpanetta | 16:53 | |
| *** tacuddy2000 has joined #openstack-marconi | 16:57 | |
| *** tacuddy2000 has quit IRC | 16:57 | |
| *** tacuddy2000 has joined #openstack-marconi | 16:58 | |
| *** amitgandhi has quit IRC | 17:19 | |
| kgriffs | alcabrera: I just finished reviewing this one: https://review.openstack.org/#/c/50702/ | 17:22 |
| alcabrera | kgriffs: I just received the email on it! | 17:22 |
| alcabrera | Thanks! | 17:22 |
| alcabrera | I'll look it over very shortly. I'm responding to flaper87|afk's email. | 17:23 |
| *** kgriffs is now known as kgriffs_afk | 17:31 | |
| *** fvollero has quit IRC | 17:35 | |
| *** ametts has quit IRC | 17:40 | |
| *** amitgandhi has joined #openstack-marconi | 17:41 | |
| *** reed has joined #openstack-marconi | 17:41 | |
| *** alcabrera is now known as alcabrera|afk | 17:45 | |
| *** asalkeld has joined #openstack-marconi | 17:59 | |
| asalkeld | hi, is there anyway of working around this: https://bugs.launchpad.net/marconi/+bug/1243845 | 18:01 |
| *** alcabrera|afk is now known as alcabrera | 18:01 | |
| alcabrera | asalkeld: let's see... | 18:01 |
| alcabrera | hmmm | 18:01 |
| alcabrera | This error is new to me. All of the interesting scenarios. I'm trying to think of a workaround. | 18:02 |
| asalkeld | a server shouldn't be doing termio | 18:02 |
| alcabrera | I have one idea. | 18:02 |
| alcabrera | It's possible to launch marconi using an external WSGI container, say, 'uwsgi' or 'gunicorn'. | 18:03 |
| alcabrera | That might avoid the termio silliness. | 18:03 |
| asalkeld | maybe | 18:03 |
| asalkeld | ok, I'll look into that, or fixing it | 18:03 |
| *** kgriffs_afk is now known as kgriffs | 18:03 | |
| alcabrera | thanks! | 18:04 |
| alcabrera | I'd appreciate if you updated the ticket with your findings. :) | 18:04 |
| asalkeld | sure | 18:04 |
| *** whenry has joined #openstack-marconi | 18:08 | |
| alcabrera | kgriffs: responded on that review - greatly appreciated! :D | 18:11 |
| *** amitgandhi has quit IRC | 18:21 | |
| openstackgerrit | Angus Salkeld proposed a change to openstack/marconi: Don't enable_echo when we don't have a tty https://review.openstack.org/53415 | 18:28 |
| *** asalkeld is now known as asalkeld_eating | 18:29 | |
| alcabrera | kgriffs: can we get a quick review on this: https://review.openstack.org/#/c/53415/ (Closes a recently discovered bug, +5 LOC) | 18:31 |
| *** tacuddy2000 has quit IRC | 18:33 | |
| zyuan | kgriffs: ping | 18:39 |
| *** alcabrera has quit IRC | 18:46 | |
| *** amitgandhi has joined #openstack-marconi | 18:51 | |
| *** whenry has quit IRC | 18:59 | |
| *** alcabrera has joined #openstack-marconi | 19:00 | |
| alcabrera | kgriffs: I like messages.Item + messages.List | 19:01 |
| alcabrera | Thanks for the suggestions! | 19:02 |
| *** JRow has joined #openstack-marconi | 19:06 | |
| *** reed has quit IRC | 19:14 | |
| *** asalkeld_eating is now known as asalkeld | 19:16 | |
| *** JRow has left #openstack-marconi | 19:18 | |
| *** malini is now known as malini_afk | 19:32 | |
| kgriffs | kk | 19:35 |
| zyuan | kgriffs: have you saw the Claim change? so is the 204 when listing messages when there is no queue considered as a bug? | 19:36 |
| zyuan | (i noticed that ralational db can also benefit from this "shortcut") | 19:37 |
| *** asalkeld has quit IRC | 19:37 | |
| kgriffs | it is considered a bug, based on user feedback | 19:38 |
| kgriffs | 404 was expected | 19:38 |
| zyuan | but, if change this, many places need to be changed as well | 19:39 |
| zyuan | do it all over the places? | 19:39 |
| openstackgerrit | A change was merged to openstack/marconi: Don't enable_echo when we don't have a tty https://review.openstack.org/53415 | 19:39 |
| * kgriffs is looking | 19:39 | |
| zyuan | (we can't have something partially just to address a user feedback) | 19:39 |
| zyuan | (all or nothing) | 19:39 |
| zyuan | partially done* | 19:40 |
| alcabrera | it'll require some changes to how we handle the storage aspect. | 19:40 |
| alcabrera | currently, we just issue queries over the message collection. | 19:41 |
| alcabrera | w/o regard to the queue collection. | 19:41 |
| alcabrera | that's why we don't check for existence. | 19:41 |
| *** asalkeld has joined #openstack-marconi | 19:41 | |
| alcabrera | so there's an overlap in the case that a queue has no messages and a queue just doesn't exist. | 19:41 |
| openstackgerrit | DennyZhang proposed a change to openstack/marconi: update quickstart document for marconi https://review.openstack.org/53435 | 19:43 |
| kgriffs | so, now that we have oslo.cache, what about having a queue exists check in the storage driver? | 19:44 |
| zyuan | but this overlap does not seem to be harmful | 19:44 |
| zyuan | it's already there | 19:45 |
| kgriffs | i mean, modifying it to use cache, and then calling it from message listing | 19:45 |
| alcabrera | kgriffs: hmmm, good point. I hadn't considered leveraging oslo.cache. | 19:45 |
| zyuan | but... you know, more checking, higher chance of race condition in other storage | 19:45 |
| zyuan | while the result from 1 query is more "correct" | 19:46 |
| kgriffs | you would have to purge the cache when queue is deleted, but I thing it would be OK, practically speaking, if once in a while someone gets a 204 when they should have gotten 404 | 19:47 |
| zyuan | it's rare, because queue are not exptected to be deleted often | 19:47 |
| *** whenry has joined #openstack-marconi | 19:48 | |
| alcabrera | I'm +1 for the cache idea. I also believe the race condition is benign. | 19:50 |
| kgriffs | do we want to base this fix on alcabrera's patches since those set up cache in the bootstrap? | 19:51 |
| kgriffs | (iirc) | 19:51 |
| kgriffs | speaking of which, does the cache backend just default to in-memory? | 19:52 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: add shard management resource https://review.openstack.org/50702 | 19:54 |
| alcabrera | kgriffs: yes, it defaults to in-memory. | 19:54 |
| kgriffs | ok | 19:54 |
| kgriffs | i would hate give up our super easy "kick-the-tires" install, e.g., | 19:54 |
| alcabrera | so that'd be a per-process queues cache - which is actually a problem. | 19:55 |
| alcabrera | Unless we added TTLs. | 19:55 |
| kgriffs | pip install; marconi-server | 19:55 |
| kgriffs | is it really a problem? Real deployments would use memcached or something anyway, right? | 19:56 |
| kgriffs | bbl - got a meeting | 19:56 |
| alcabrera | kgriffs: well, it's more of a gotcha, really. :P | 19:56 |
| alcabrera | k | 19:56 |
| openstackgerrit | DennyZhang proposed a change to openstack/marconi: update quickstart document for marconi https://review.openstack.org/53435 | 19:57 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: shards storage controller interface https://review.openstack.org/50721 | 19:59 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: shards mongodb driver + tests https://review.openstack.org/50815 | 19:59 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: integrate shard storage with transport https://review.openstack.org/50998 | 20:03 |
| *** whenry has quit IRC | 20:06 | |
| *** amitgandhi has quit IRC | 20:08 | |
| *** amitgandhi has joined #openstack-marconi | 20:08 | |
| *** kgriffs is now known as kgriffs_afk | 20:09 | |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: integrate shard storage with transport https://review.openstack.org/50998 | 20:10 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: add catalogue storage driver for queues https://review.openstack.org/52160 | 20:11 |
| alcabrera | rebasing complete | 20:11 |
| alcabrera | I'm headed home. I'll continue work on eom:bastion tomorrow. | 20:11 |
| zyuan | see you | 20:11 |
| alcabrera | zyuan: :D | 20:11 |
| *** alcabrera has quit IRC | 20:12 | |
| *** amitgandhi has quit IRC | 20:22 | |
| *** amitgandhi has joined #openstack-marconi | 20:27 | |
| *** asalkeld has quit IRC | 20:28 | |
| *** asalkeld has joined #openstack-marconi | 20:28 | |
| *** reed has joined #openstack-marconi | 20:39 | |
| *** kgriffs_afk is now known as kgriffs | 20:42 | |
| *** asalkeld has quit IRC | 21:08 | |
| *** asalkeld has joined #openstack-marconi | 21:08 | |
| *** jergerber has joined #openstack-marconi | 21:15 | |
| openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(health): make health API storage-aware https://review.openstack.org/53457 | 21:26 |
| *** alcabrera has joined #openstack-marconi | 21:38 | |
| *** whenry has joined #openstack-marconi | 21:42 | |
| *** amitgandhi has quit IRC | 21:46 | |
| *** oz_akan_ has quit IRC | 21:52 | |
| *** amitgandhi has joined #openstack-marconi | 21:52 | |
| *** amitgandhi has quit IRC | 21:57 | |
| *** tedross has quit IRC | 21:58 | |
| *** kgriffs is now known as kgriffs_afk | 22:09 | |
| *** alcabrera has quit IRC | 22:14 | |
| *** mpanetta has quit IRC | 22:15 | |
| *** whenry has quit IRC | 22:16 | |
| asalkeld | is the marconi client functional? | 22:35 |
| asalkeld | and where is the cli? | 22:36 |
| asalkeld | I asked this months ago, I hope there has been progress | 22:36 |
| *** openstack has joined #openstack-marconi | 22:47 | |
| *** asalkeld is now known as asalkeld_lunch | 23:20 | |
| *** jergerber has quit IRC | 23:23 | |
| *** jcru has quit IRC | 23:32 | |
| *** whenry has joined #openstack-marconi | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!