| openstackgerrit | Merged openstack/masakari master: Add ha_enabled_instance_metadata_key config option https://review.opendev.org/740777 | 02:06 |
|---|---|---|
| *** vishalmanchanda has joined #openstack-masakari | 06:40 | |
| *** jawad_axd has joined #openstack-masakari | 10:07 | |
| *** vishalmanchanda has quit IRC | 13:04 | |
| *** priteau has joined #openstack-masakari | 14:30 | |
| *** vishalmanchanda has joined #openstack-masakari | 14:58 | |
| yoctozepto | noonedeadpunk: have some time for masakari - I see it actually fails when unsetting/emptying the list | 15:52 |
| yoctozepto | the test I mean | 15:53 |
| yoctozepto | it would make sense to also test if it actually tries to use the passed in 'fake' string | 15:53 |
| noonedeadpunk | yoctozepto: I mean test does not fail if we provide non empty string - the one which we expect to fail | 15:57 |
| noonedeadpunk | and not sure how do we test that - method returns non.... | 15:58 |
| noonedeadpunk | *none | 15:58 |
| noonedeadpunk | yeah, agree that return_value is not used.... | 16:00 |
| noonedeadpunk | not sure how to handle that tbh ;( | 16:00 |
| yoctozepto | noonedeadpunk: ok, I'll just sit down to those tests, worry not | 16:01 |
| yoctozepto | and then we merge and backport 8-) | 16:02 |
| noonedeadpunk | so, actually exception raised anyway in test_find_compute_service_non_existing_host_name ? we can kind of just drop mock_services? | 16:03 |
| noonedeadpunk | but yeah. I guess you have the way more experience in unit testing, you're a core! :p | 16:03 |
| yoctozepto | noonedeadpunk: general experience, yes | 16:06 |
| * noonedeadpunk has neither | 16:06 | |
| yoctozepto | noonedeadpunk: ack, no problem | 16:07 |
| noonedeadpunk | never had to write tests for stuff I'm weriting, except openstack contrbutions, but here I mostly just look on samples and do the same.... | 16:08 |
| yoctozepto | noonedeadpunk: isn't that the whole idea behind programming? :D | 16:15 |
| noonedeadpunk | and how about reading books? :p | 16:15 |
| noonedeadpunk | xD | 16:15 |
| noonedeadpunk | but yeah | 16:15 |
| yoctozepto | noonedeadpunk: books don't allow copy-paste | 16:16 |
| yoctozepto | noonedeadpunk: need copiable ebooks | 16:16 |
| noonedeadpunk | I guess that's _the reason_ why they are not so popular nowadays :)) | 16:16 |
| yoctozepto | must be! | 16:16 |
| *** jawad_axd has quit IRC | 16:24 | |
| *** jawad_axd has joined #openstack-masakari | 16:37 | |
| *** jawad_axd has quit IRC | 17:15 | |
| *** jawad_axd has joined #openstack-masakari | 18:00 | |
| openstackgerrit | Radosław Piliszek proposed openstack/masakari master: Search in nova services instead of hypervisors https://review.opendev.org/728629 | 18:06 |
| *** jawad_axd has quit IRC | 18:15 | |
| *** vishalmanchanda has quit IRC | 18:28 | |
| *** priteau has quit IRC | 19:12 | |
| *** jawad_axd has joined #openstack-masakari | 19:19 | |
| *** jawad_axd has quit IRC | 20:06 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!