| alanbach | Hello everyone o/ | 06:53 |
|---|---|---|
| alanbach | Are we going to have a meeting today? | 07:00 |
| say3no_ | hi | 07:02 |
| alanbach | Hello! | 07:02 |
| say3no_ | yes, | 07:03 |
| say3no_ | It starts at 16:00 today. Sorry for the slight delay. | 07:03 |
| say3no_ | sorry, 16:00 means JST 16:00 | 07:03 |
| say3no_ | #startmeeting masakari | 07:04 |
| opendevmeet | Meeting started Mon Apr 13 07:04:26 2026 UTC and is due to finish in 60 minutes. The chair is say3no_. Information about MeetBot at http://wiki.debian.org/MeetBot. | 07:04 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 07:04 |
| opendevmeet | The meeting name has been set to 'masakari' | 07:04 |
| masahito | o/ | 07:06 |
| alanbach | Hello o/ | 07:06 |
| say3no_ | https://etherpad.opendev.org/p/masakari-meeting-2026.1 | 07:06 |
| say3no_ | #topic [alanbach] (Please feel free to move this if there are more important topics) Kindly requesting a review on https://review.opendev.org/c/openstack/masakari/+/978343 | 07:07 |
| alanbach | I was here to kindly ask for another set of eyes on that review | 07:07 |
| alanbach | The concurrent database insertion in Masakari HA has been becoming more problematic for our clients, that's why I proposed a small change in the create_notification_function function | 07:09 |
| say3no_ | I sincerely apologize for the delay. I'm aware you've been following up on this since Mar 24, and I haven't been able to get to it until now. | 07:09 |
| alanbach | https://review.opendev.org/c/openstack/masakari/+/978343/3/masakari/ha/api.py#350 | 07:09 |
| alanbach | No worries at all! | 07:09 |
| alanbach | Thank you so much for looking into it | 07:10 |
| say3no_ | "Understood. Indeed, depending on the race condition, the current design can result in multiple notifications being created. | 07:12 |
| alanbach | Correct, introducing the random pause allows the current duplicate detection function to catch them and it has been working reliably in my lab | 07:13 |
| alanbach | I have a reproducer script added here: https://bugs.launchpad.net/masakari/+bug/2028450/+attachment/5949483/+files/lp2028450-reproducer.bash | 07:13 |
| alanbach | Using it to reproduce as well as test the fix | 07:14 |
| say3no_ | I'd like to discuss this a bit further, if you don't mind. My honest impression is that this PR is more of a workaround than a fundamental fix. I genuinely don't have a settled view on how we should handle PRs like this as a project — I'd value your perspective. From your point of view, what would be the right way to address this issue at its root? | 07:16 |
| say3no_ | Honestly, part of me feels we could just merge this as-is. On the other hand, for a workaround of this size, I'm not fully convinced it needs to live upstream — it might be just as well maintained as a local patch on alanbach's side. I'd love to hear your thoughts. | 07:18 |
| alanbach | I believe having the coordination engine should prevent this (please correct me if I am wrong), however the issue is not all deployments have this configured. For example Charmed OpenStack to this day does not support the coordination engine | 07:19 |
| alanbach | On top of that we still support older versions of Masakari which do not have support for coordination engine | 07:20 |
| alanbach | The goal is to apply a similar patch to at least remedy the issue for the time being | 07:20 |
| alanbach | I am considering this change more of a safety fallback system where the coordinator is not configured | 07:23 |
| say3no_ | Thanks for the discussion. I've added a few comments on the proposal for your consideration. | 07:26 |
| say3no_ | https://review.opendev.org/c/openstack/masakari/+/978343/comments/798712ba_41451fcf | 07:26 |
| say3no_ | Once these four points are addressed, I'm happy to give it a +2 and proceed with the merge. Thank you for working on this | 07:27 |
| alanbach | Great idea! Thank you so much - I'll implement this and will sent a fresh patchset for review | 07:28 |
| alanbach | Thank you again for the discussions and the review | 07:28 |
| alanbach | Have a great rest of the day o/ I am dropping now it is 00:30am here :-D | 07:29 |
| say3no_ | Not at all — thank you for joining the discussion. Hearing from people who actually use Masakari in production is genuinely encouraging for us. Please come back anytime! | 07:29 |
| say3no_ | oyasumi nasai | 07:29 |
| alanbach | Thank you | 07:30 |
| say3no_ | Next topic | 07:30 |
| say3no_ | #topic PTG Topics and slot https://etherpad.opendev.org/p/masakari-ptg-2026.2 | 07:31 |
| say3no_ | I've added some details to the PTG discussion topics on the etherpad. | 07:36 |
| say3no_ | I'm currently looking for the page to register PTG time slots... | 07:40 |
| say3no_ | #link https://ptg.opendev.org/ptg.html | 07:41 |
| say3no_ | I'm thinking of booking the following slots for Masakari. If any of these are inconvenient for you, please speak up! Mon/Tue 07:00 UTC (16:00 JST, 09:00 CEST) Mon/Tue 08:00 UTC (17:00 JST, 10:00 CEST) | 07:57 |
| say3no_ | I'll proceed with the booking via PTGbot after this. Thank you all for joining today's discussion! | 07:58 |
| say3no_ | #endmeeting | 07:58 |
| opendevmeet | Meeting ended Mon Apr 13 07:58:37 2026 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 07:58 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/masakari/2026/masakari.2026-04-13-07.04.html | 07:58 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/masakari/2026/masakari.2026-04-13-07.04.txt | 07:58 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/masakari/2026/masakari.2026-04-13-07.04.log.html | 07:58 |
| opendevreview | Alan Baghumian proposed openstack/masakari master: ha/api : create_notification https://review.opendev.org/c/openstack/masakari/+/978343 | 20:49 |
| opendevreview | Alan Baghumian proposed openstack/masakari master: ha/api : create_notification https://review.opendev.org/c/openstack/masakari/+/978343 | 20:54 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!