| *** Sukhdev has joined #openstack-meeting-3 | 00:02 | |
| *** wchrisj has joined #openstack-meeting-3 | 00:02 | |
| *** eguz has quit IRC | 00:08 | |
| *** wchrisj has quit IRC | 00:10 | |
| *** Sukhdev is now known as Sukhdev__ | 00:27 | |
| *** SumitNaiksatam has quit IRC | 01:07 | |
| *** SumitNaiksatam has joined #openstack-meeting-3 | 01:24 | |
| *** MaxV_ has joined #openstack-meeting-3 | 01:34 | |
| *** MaxV_ has quit IRC | 01:40 | |
| *** Sukhdev__ has quit IRC | 02:02 | |
| *** coolsvap|afk is now known as coolsvap | 02:30 | |
| *** MaxV_ has joined #openstack-meeting-3 | 02:37 | |
| *** david-lyle has joined #openstack-meeting-3 | 02:38 | |
| *** MaxV_ has quit IRC | 02:41 | |
| *** alexpilotti has quit IRC | 02:46 | |
| *** amotoki has quit IRC | 03:06 | |
| *** beyounn has quit IRC | 03:32 | |
| *** eghobo has joined #openstack-meeting-3 | 03:36 | |
| *** wchrisj has joined #openstack-meeting-3 | 03:55 | |
| *** rand738 has quit IRC | 04:01 | |
| *** david_lyle_ has joined #openstack-meeting-3 | 04:01 | |
| *** rand738 has joined #openstack-meeting-3 | 04:01 | |
| *** david-lyle has quit IRC | 04:01 | |
| *** lblanchard has joined #openstack-meeting-3 | 04:11 | |
| *** wchrisj has quit IRC | 04:11 | |
| *** david_lyle_ has quit IRC | 04:37 | |
| *** david-lyle has joined #openstack-meeting-3 | 04:38 | |
| *** MaxV_ has joined #openstack-meeting-3 | 04:38 | |
| *** MaxV_ has quit IRC | 04:43 | |
| *** xazel has quit IRC | 04:53 | |
| *** eghobo has quit IRC | 05:05 | |
| *** eghobo has joined #openstack-meeting-3 | 05:05 | |
| *** enykeev has joined #openstack-meeting-3 | 05:05 | |
| *** enykeev has quit IRC | 05:07 | |
| *** enykeev has joined #openstack-meeting-3 | 05:08 | |
| *** lpetrut has joined #openstack-meeting-3 | 05:10 | |
| *** lblanchard has quit IRC | 05:14 | |
| *** amotoki has joined #openstack-meeting-3 | 05:28 | |
| *** MaxV_ has joined #openstack-meeting-3 | 05:39 | |
| *** MaxV_ has quit IRC | 05:44 | |
| *** yamahata has joined #openstack-meeting-3 | 06:00 | |
| *** enykeev has quit IRC | 06:03 | |
| *** MaxV_ has joined #openstack-meeting-3 | 06:04 | |
| *** MaxV_ has quit IRC | 06:08 | |
| *** ttrifonov_zZzz is now known as ttrifonov | 06:08 | |
| *** MaxV_ has joined #openstack-meeting-3 | 06:12 | |
| *** enykeev has joined #openstack-meeting-3 | 06:22 | |
| *** lpetrut has quit IRC | 06:24 | |
| *** yamahata has quit IRC | 06:24 | |
| *** lpetrut has joined #openstack-meeting-3 | 06:25 | |
| *** MaxV_ has quit IRC | 06:29 | |
| *** nacim has joined #openstack-meeting-3 | 06:37 | |
| *** yamahata has joined #openstack-meeting-3 | 06:45 | |
| *** lpetrut has quit IRC | 06:47 | |
| *** nacim has quit IRC | 06:50 | |
| *** jcoufal has joined #openstack-meeting-3 | 07:22 | |
| *** MaxV_ has joined #openstack-meeting-3 | 07:37 | |
| *** nacim has joined #openstack-meeting-3 | 08:05 | |
| *** yamahata has quit IRC | 08:18 | |
| *** eguz has joined #openstack-meeting-3 | 08:26 | |
| *** eghobo has quit IRC | 08:30 | |
| *** eguz has quit IRC | 08:42 | |
| *** jtomasek has joined #openstack-meeting-3 | 08:48 | |
| *** alexpilotti has joined #openstack-meeting-3 | 09:50 | |
| *** Adri2000 has quit IRC | 10:38 | |
| *** Adri2000 has joined #openstack-meeting-3 | 10:39 | |
| *** Adri2000 has joined #openstack-meeting-3 | 10:39 | |
| *** alexpilotti has quit IRC | 10:46 | |
| *** coolsvap is now known as coolsvap|afk | 10:56 | |
| *** alexpilotti has joined #openstack-meeting-3 | 10:59 | |
| *** david-lyle has quit IRC | 11:20 | |
| *** mwagner_lap has quit IRC | 12:02 | |
| *** xuhanp has joined #openstack-meeting-3 | 12:23 | |
| *** jpomero has quit IRC | 12:56 | |
| *** jpomero has joined #openstack-meeting-3 | 13:26 | |
| *** mfer has joined #openstack-meeting-3 | 13:35 | |
| *** jcoufal has quit IRC | 13:45 | |
| *** jcoufal has joined #openstack-meeting-3 | 13:46 | |
| *** mwagner_lap has joined #openstack-meeting-3 | 13:47 | |
| *** pbelanyi has joined #openstack-meeting-3 | 13:59 | |
| *** wchrisj has joined #openstack-meeting-3 | 13:59 | |
| *** peristeri has joined #openstack-meeting-3 | 14:14 | |
| *** jpich has joined #openstack-meeting-3 | 14:15 | |
| *** wchrisj has left #openstack-meeting-3 | 14:15 | |
| *** cjellick has quit IRC | 14:21 | |
| *** pbelanyi has left #openstack-meeting-3 | 14:25 | |
| *** dolphm is now known as dolphem | 14:31 | |
| *** jtomasek has quit IRC | 14:38 | |
| *** jcoufal has quit IRC | 14:43 | |
| *** jtomasek has joined #openstack-meeting-3 | 14:53 | |
| *** david-lyle has joined #openstack-meeting-3 | 14:54 | |
| *** jcoufal has joined #openstack-meeting-3 | 15:03 | |
| *** akrivoka has joined #openstack-meeting-3 | 15:03 | |
| *** xuhanp has quit IRC | 15:06 | |
| *** xuhanp has joined #openstack-meeting-3 | 15:10 | |
| *** xuhanp has quit IRC | 15:10 | |
| *** cjellick has joined #openstack-meeting-3 | 15:11 | |
| *** jtomasek has quit IRC | 15:47 | |
| *** clu_ has joined #openstack-meeting-3 | 15:49 | |
| *** tzumainn has joined #openstack-meeting-3 | 15:55 | |
| *** tmazur has joined #openstack-meeting-3 | 15:55 | |
| *** pbelanyi has joined #openstack-meeting-3 | 15:59 | |
| *** coolsvap|afk is now known as coolsvap | 15:59 | |
| jrist | o/ | 16:00 |
|---|---|---|
| tzumainn | hi all! | 16:00 |
| clu_ | hi! | 16:00 |
| *** eghobo has joined #openstack-meeting-3 | 16:00 | |
| * jrist waves to tzumainn | 16:00 | |
| *** santibaldassin has joined #openstack-meeting-3 | 16:01 | |
| * tzumainn waves to jrist | 16:01 | |
| pbelanyi | hi | 16:01 |
| * jcoufal waves to tzumainn and jrist | 16:01 | |
| david-lyle | #startmeeting Horizon | 16:01 |
| openstack | Meeting started Tue Apr 15 16:01:49 2014 UTC and is due to finish in 60 minutes. The chair is david-lyle. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:01 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:01 |
| *** openstack changes topic to " (Meeting topic: Horizon)" | 16:01 | |
| openstack | The meeting name has been set to 'horizon' | 16:01 |
| lsmola | hello | 16:01 |
| *** eghobo has quit IRC | 16:01 | |
| david-lyle | Hello everyone | 16:01 |
| jpich | Hello | 16:02 |
| jcoufal | o/ hello everyone | 16:02 |
| jrist | o/ | 16:02 |
| tmazur | hello o/ | 16:02 |
| santibaldassin | hi everyone | 16:02 |
| akrivoka | hey | 16:02 |
| *** doug-fish has joined #openstack-meeting-3 | 16:02 | |
| david-lyle | #link https://wiki.openstack.org/wiki/Meetings/Horizon | 16:02 |
| david-lyle | #topic: Release Status | 16:03 |
| *** openstack changes topic to ": Release Status (Meeting topic: Horizon)" | 16:03 | |
| david-lyle | RC2 appears to be holding up with no blocking issues having been raised, this looks like our final RC | 16:03 |
| david-lyle | \o/ | 16:04 |
| akrivoka | awesome | 16:04 |
| david-lyle | The last thing I need to do is post the release notes | 16:04 |
| david-lyle | when I do that, hopefully today, I'll ask everyone to take a look and correct my mistakes | 16:05 |
| jpich | Cool, looking forward to the patch! | 16:05 |
| david-lyle | Aside, from that, I think we're focused on Juno | 16:05 |
| *** lcheng has joined #openstack-meeting-3 | 16:06 | |
| jrist | well done, everyone | 16:06 |
| david-lyle | The deadline for session proposals is five days away, so if there's something you feel needs to be discussed at the summit, get your proposal in | 16:07 |
| david-lyle | #topic DocImpact tag (jpich) | 16:07 |
| *** openstack changes topic to "DocImpact tag (jpich) (Meeting topic: Horizon)" | 16:08 | |
| * jcoufal will add one more session proposal focused on tuskar-ui | 16:08 | |
| jpich | Hey! | 16:08 |
| *** ttrifonov is now known as ttrifonov_zZzz | 16:08 | |
| david-lyle | jcoufal +1 | 16:08 |
| *** amotoki_ has joined #openstack-meeting-3 | 16:08 | |
| jcoufal | (sorry for jumping into your topic, jpich) :) | 16:08 |
| jpich | I was chatting with someone on the docs team last week and realised we haven't been very good at using the DocImpact tag in Horizon (or I missed it!). It would be helpful to the docs team if we could include the tag at least for major changes and "procedure" changes - I'm guessing things around new configuration / upgrade / installation information. | 16:08 |
| jpich | jcoufal: We're flexible here ;) | 16:08 |
| *** MaxV_ has quit IRC | 16:08 | |
| jpich | I'm still a bit fuzzy on when it is appropriate to use it for us (so many changes impact the user experience in some way) but we can refine our approach to using the tag as we understand it better :) | 16:08 |
| jpich | Somme additional reading: https://wiki.openstack.org/wiki/Documentation/DocImpact http://justwriteclick.com/2013/09/17/openstack-docimpact-flag-walk-through/ and I'm sure the folks at #openstack-doc are happy to answer any question, too | 16:09 |
| tzumainn | jpich, one question | 16:10 |
| tzumainn | looking through the baremetal example in the second link, it strikes me that a lot of those questions are exactly the same ones a reviewer would have | 16:10 |
| david-lyle | other than internal bug fixes, don't all changes in the UI potential doc impact | 16:10 |
| tzumainn | are reviewers expected to just ask those questions through the gerrit comment system? | 16:10 |
| david-lyle | have potential that is | 16:10 |
| tzumainn | or is there an expectation that the commit message have a certain level of self-documentation? | 16:11 |
| *** eghobo has joined #openstack-meeting-3 | 16:11 | |
| jpich | tzumainn: I'm guessing in an ideal world these should be answered in the commit message and blueprint details, yes | 16:11 |
| tzumainn | jpich, is that a standard - i.e., should reviewers -1 and ask for details on how to test a change? | 16:12 |
| jpich | david-lyle: These are my thoughts as well, which is when it was clarified to me to care more about "procedure" changes rather than changes in the look | 16:12 |
| jpich | david-lyle: I think we should start using it for major changes, the kind we self-document at the moment. Some of this should probably also live in the generic openstack guides? | 16:12 |
| *** nacim has quit IRC | 16:13 | |
| jpich | like settings, or how to use policies | 16:13 |
| jpich | how to set up the dashboard to work with keystone v3 - probably these would have been great commits for DocImpact | 16:13 |
| david-lyle | jpich, I see | 16:13 |
| jpich | tzumainn: I think it'd be great to have that information but it hasn't been customary to block on it being missing. I'd lean toward strongly encouraging people to think about it and add that sort of info to the bug reports or blueprints, but not block on it... That'd be my thoughts on that | 16:14 |
| tzumainn | jpich, okay, that sounds sensible enough - thanks! | 16:14 |
| tzumainn | er, sorry, I now realize that I was re-directing away from your intended topic :P | 16:14 |
| jpich | david-lyle: I'm still figuring this stuff out too :) | 16:15 |
| david-lyle | jpich, thanks for raising, I think this a great thing to keep in mind. Even if it just means more complete commit messages for Horizon use. I think we've been flagging a bit on those lately | 16:15 |
| jpich | tzumainn: It's documentish! I was bringing this up as a general "FYI, more things we should probably try to pay attention to" | 16:15 |
| *** eghobo has quit IRC | 16:16 | |
| * lsmola has to disappear soon today | 16:16 | |
| amotoki_ | hi, i totally agree the discussion above. at least changes which impact install guide and could admin guide should have DocImpact.. | 16:16 |
| jpich | david-lyle: More useful commit messages is good! | 16:16 |
| jpich | -1 on a typo in the commit message is uncool in my world though :-) | 16:16 |
| jpich | amotoki: Agreed. We probably should explore what's missing in these guides for Horizon and help the docs team fill the gaps as well | 16:17 |
| david-lyle | yeah, let's not go crazy | 16:17 |
| tzumainn | jpich, lol, agreed | 16:17 |
| lsmola | jpich: agree, my vi doesn't have spellcheck | 16:17 |
| amotoki_ | Reagrding documentation, we use django style configuration and we need to explore how to sync our configurations with the config guide. | 16:18 |
| jpich | lsmola: emacs has a spellchecker if you like ;) | 16:18 |
| tzumainn | and jpich starts the flame war | 16:18 |
| annegentle | do feel free to file doc bugs in http://bugs.launchpad.net/openstack-manuals for those missed DocImpact opportunities - you all will know better than us what should be docc'ed | 16:19 |
| annegentle | amotoki_: it'd be great to automate those | 16:19 |
| jpich | amotoki: Yep, which brings to mind https://bugs.launchpad.net/horizon/+bug/1300710 and https://bugs.launchpad.net/horizon/+bug/1221115 which we probably want in the guides as well | 16:19 |
| *** eghobo has joined #openstack-meeting-3 | 16:19 | |
| jpich | annegentle: Thanks! That's what I had in mind, hopefully we can help with writing them too rather than just overload the docs team even more | 16:20 |
| annegentle | jpich: sure! we are happy to take highly detailed doc bugs and turn them into docs if tools are an issue though, that's all I mean. | 16:20 |
| jpich | annegentle: That's useful information, thanks! | 16:21 |
| amotoki_ | jpich: thanks for filing it. in other projects configurations are extracted from code base but it is not for Horizon. we need to explore how to improve it in Juno. | 16:22 |
| david-lyle | yes, the horizon settings/conf mechanism is different and we'll have to provide a mechanism to pull it automagically | 16:22 |
| jpich | yep | 16:23 |
| david-lyle | anything else on this topic | 16:23 |
| jpich | Not from me, thanks for your attention and consideration folks! | 16:23 |
| amotoki_ | nothing from me too. | 16:23 |
| david-lyle | thanks! | 16:24 |
| david-lyle | #topic Open Discussion | 16:24 |
| *** openstack changes topic to "Open Discussion (Meeting topic: Horizon)" | 16:24 | |
| tzumainn | so, related to my point above - is there a way to ask for patches to have more documentation associated with them, because a lot of those patches are fairly complex and it feels like a potential blocker for reviewers? | 16:24 |
| david-lyle | tzumainn, absolutely | 16:25 |
| annegentle | tzumainn: educate all your reviewers | 16:25 |
| david-lyle | if you don't feel like enough information is provided to do a proper review, ask for it in the review | 16:25 |
| tzumainn | so, I'm going to admit that by "reviewers" I meant "me" : ) | 16:25 |
| jrist | so subtle | 16:25 |
| jrist | what is everyone's thoughts on using polyfills or similar mechanisms for supporting older browsers with newer features (i.e. the recent 'input type number' bug) | 16:26 |
| annegentle | tzumainn: I can't think of an automated way, or a test that runs each time | 16:26 |
| jomara | tzumainn: your idea is going mainnstream | 16:26 |
| david-lyle | you are likely not alone, and when looking back at the commit log, one sentence commit statements aren't very helpful | 16:26 |
| jomara | tzumainn: ar eyou talking about commit docs, internal source comments, user guide stuff, or all of the above? | 16:26 |
| * david-lyle could have missed the point | 16:26 | |
| tzumainn | jomara, I'm talking about picking up a patch from gerrit and trying to figure out how to review it : ) | 16:26 |
| jomara | so, whatever it is, enough to read about it and figure it out | 16:27 |
| jpich | david-lyle: Agreed with all you said either way :-) | 16:27 |
| jcoufal | jrist: I think we shouldn't pay so much extra effort to support old browsers, other than those which are officially supported | 16:27 |
| jrist | do we have a list of officially supported browsers | 16:27 |
| jrist | jcoufal: for instance, input type number is not supported in current firefox, 28 | 16:28 |
| jrist | pretty bad | 16:28 |
| jrist | so not necessarily older browsers | 16:28 |
| jcoufal | wait, really? current firefox doesn't support number type? | 16:28 |
| jrist | nope | 16:28 |
| jrist | 29 maybe. 28 no | 16:28 |
| * jcoufal amazed | 16:28 | |
| jrist | there are many things like that | 16:28 |
| jcoufal | From my point of view, I would say that it depends on the type of the problem and browser | 16:29 |
| david-lyle | the hard limitation we have is ie 8 and greater, other than that we assume the browsers do a good job of staying reasonably up-to-date | 16:29 |
| david-lyle | soon ie 8 should go away | 16:29 |
| jcoufal | general rule I have is - are you using latest new versions? you get great UX, are you using old stuff? it's usable for you, but you don't get the best you can | 16:30 |
| jpich | There's some serious bugs open about our ie 8 support though I seem to remember | 16:30 |
| jrist | is there a list somewhere | 16:30 |
| jrist | of supported browsers | 16:30 |
| jcoufal | i think david-lyle just described the rule above | 16:30 |
| david-lyle | actually when XP eol'd we should be able to stop support ie8, it is also eol | 16:30 |
| doug-fish | https://github.com/openstack/horizon/blob/master/doc/source/contributing.rst#javascript | 16:30 |
| jomara | not bad! | 16:30 |
| jcoufal | david-lyle: I can't wait for this to happen :) | 16:31 |
| jpich | doug-fish: Thanks! I knew it was somewhere but my grepping failed me :) | 16:31 |
| david-lyle | jcoufal, the date was April 8 | 16:31 |
| clu_ | i think for older browsers, we should at least have a warning message somewhere that says: "horizon is not fully supported" | 16:31 |
| david-lyle | it is done | 16:31 |
| doug-fish | jpich: glad to help. Took me a while as well! | 16:31 |
| tzumainn | so, there's a specific case here | 16:31 |
| tzumainn | https://review.openstack.org/#/c/82908/ | 16:31 |
| jpich | https://bugs.launchpad.net/horizon/+bug/1260281 - probably needs to be fixed and backported to icehouse | 16:31 |
| tzumainn | the fix only works on these browsers: https://review.openstack.org/#/c/82908/ | 16:31 |
| tzumainn | so the question is - should this fix be accepted or not? | 16:32 |
| jrist | clu_: supported is a loaded word | 16:32 |
| jcoufal | david-lyle: so we are safe to say, that for J we are dropping IE8 support as well | 16:32 |
| jrist | tzumainn: thansk for bringing that up | 16:32 |
| jrist | what do we mean by supported | 16:32 |
| tzumainn | jrist, np, I had similar thought processes when looking at that patch | 16:32 |
| david-lyle | jcoufal, seems so | 16:32 |
| jrist | how about "Horizon and OpenStack Dashboard don't work well on browsers older than ...." | 16:32 |
| tzumainn | jrist, so if that's the case, would the fix in the review above be accepted as closing the bug? | 16:33 |
| david-lyle | jrist, more like "... are not supported on ... | 16:33 |
| jrist | david-lyle: do we offer support? | 16:33 |
| jrist | support is a loaded word, like I said | 16:34 |
| david-lyle | jrist good point | 16:34 |
| jrist | tzumainn: no I don't think it does, thus my initial nack | 16:34 |
| amotoki_ | Another idea is to have a list of tested browsers with versions. | 16:34 |
| * david-lyle thought jrist was the support organization | 16:34 | |
| jrist | I agree with Maxime | 16:34 |
| tzumainn | jrist, yeah, I +1'd with an understanding it was a partial fix, but I can see your point | 16:34 |
| jrist | david-lyle: ha | 16:34 |
| david-lyle | :) | 16:34 |
| clu_ | amotoki_ - this is a good idea | 16:34 |
| jrist | amotoki_: yeah, that is what I'm thinking | 16:35 |
| jcoufal | jrist: I am on Maxime's side as well. It is not enough to use number type as a proper validation check | 16:35 |
| jrist | so my original question | 16:36 |
| jrist | what is everyone's thoughts on polyfills | 16:36 |
| jrist | or similar mechanisms | 16:36 |
| jrist | even IE9 doesn't support dozens of HTML5 things | 16:36 |
| jcoufal | I am not very sure if the polyfill will ensure the validation | 16:37 |
| jcoufal | isn't it only providing the look? | 16:37 |
| jrist | it will, in the input number case | 16:37 |
| jrist | in this case prevent non digit | 16:37 |
| jcoufal | well then I would be in favor of that (in case of number picker) | 16:37 |
| jrist | yeah, it is an example of other places where polyfills might be useful | 16:38 |
| jcoufal | depends on case to case, but in this one it seems reasonable to me | 16:38 |
| jrist | jcoufal: thanks. anyone else? :) | 16:38 |
| jrist | I wish Maxime were here | 16:38 |
| jpich | Can continue the discussion on channel later when he's around | 16:38 |
| jrist | yeah | 16:39 |
| jrist | ok thanks | 16:39 |
| jpich | If it fixes things and the licence is compatible seems ok to me! | 16:39 |
| clu_ | i've seen some FIXME/TODOs in the code... do we do occasional sweeps to see if the issue can be resolved now? | 16:40 |
| clu_ | if so, write up bugs or something, otherwise things get forgotten and the FIXME/TODO list grows | 16:40 |
| jpich | Ideally people would file a bug at the same time they submit a patch with a TODO | 16:41 |
| doug-fish | I guess that's something we can add to our reviewer checklist | 16:41 |
| david-lyle | clu_, that would be a good idea. Unfortunately, a lot of them are waiting on better support outside of Horizon, like server side filter criteria | 16:41 |
| david-lyle | we could open a bug on something like that, but it would likely expire before we can address it | 16:42 |
| clu_ | david-lyle: agreed, we shouldn't write those up | 16:42 |
| amotoki_ | by greping the code, we have 77 TODOs but 30 TODOs comes from one person (router dashboard)..... Apart from this, we hvae ~40 TODO/FIXME. | 16:43 |
| jpich | Ideally we'd add a horizon task to the bug in the related project but that's not always possible | 16:43 |
| david-lyle | ideally :) | 16:43 |
| jpich | It's nice to imagine the ideal world sometimes :-) | 16:43 |
| david-lyle | amotoki_ 40 should be fairly easy to catagorize as actionable or not | 16:44 |
| jrist | lol jpich | 16:44 |
| tzumainn | I must say that it's nice that the cores in horizon are still optimists | 16:44 |
| david-lyle | jpich, sometimes that's all we have | 16:44 |
| *** eguz has joined #openstack-meeting-3 | 16:45 | |
| amotoki_ | can i discuss another topic? | 16:45 |
| jpich | Please | 16:46 |
| amotoki_ | i would like to know opinions on backward compat of "horizon" module. | 16:46 |
| amotoki_ | https://review.openstack.org/#/c/86068/2/horizon/tables/actions.py | 16:46 |
| amotoki_ | this patch removes existing fields in BacthAction. | 16:46 |
| amotoki_ | I wonder we should consider backward-compat of horizon module or not. | 16:47 |
| jpich | We will have to be better at it when we separate it from the dashboard for sure | 16:47 |
| amotoki_ | fair enough to me. | 16:48 |
| jpich | This might be a topic worthy of a more meaty/thoughtful conversation on list... | 16:48 |
| *** eghobo has quit IRC | 16:49 | |
| amotoki_ | agree. i just want to know initial feedbacks. | 16:49 |
| david-lyle | I think existing fields should be a high hurdle | 16:50 |
| david-lyle | as an extensible framework, we potentially break existing deploys | 16:50 |
| amotoki_ | yes. that is in my mind. I remember Gabriel mentioned so in past reviews. | 16:51 |
| david-lyle | I have to look at this particular patch in more depth to understand the intent better | 16:52 |
| david-lyle | I think the story will actually be smoother after the split, because we will have packaged versions of the toolkit that doesn't have to be updated with Horizon | 16:53 |
| david-lyle | makes our testing matrix more complex of course | 16:53 |
| david-lyle | s/Horizon/openstack_dashboard_future_name/ | 16:54 |
| santibaldassin | hey folks..I'd like to have a quick talk about client side validations if there's no other topic | 16:55 |
| david-lyle | sure | 16:55 |
| santibaldassin | so, there are a couple of patches were we are doing an api call to get quota usages do do client side validations that are already done by nova | 16:56 |
| santibaldassin | https://review.openstack.org/#/c/76107/ | 16:56 |
| santibaldassin | https://review.openstack.org/#/c/70158/14/openstack_dashboard/dashboards/admin/projects/workflows.py | 16:56 |
| jpich | It's usually nicer to show an error on the form by the field that has the issue, rather than let the user submit it then have to start from scratch again to correct an error | 16:58 |
| santibaldassin | I have two concerns, one is that we are increasing the number of request that we are doing to complete the operation and the other is that if the backend *no matter if its nova or cinder or any other module) changes the way they do the validation, we'll have to change the validation in horizon too | 16:58 |
| *** coolsvap is now known as coolsvap|afk | 16:58 | |
| jpich | Although for that one in particular, do the APIs actually prevent you from setting a quota less than what is currently used? | 17:00 |
| david-lyle | let's continue this in the horizon room or on the review | 17:00 |
| jpich | well, we're out of time, we can continue on the channel - although I have to jump in another meeting now | 17:00 |
| santibaldassin | jpich: I'm ok with showing friendly user. I think we could do it without the extra api calls | 17:00 |
| david-lyle | Thanks everyone have a great week. | 17:00 |
| santibaldassin | thanks | 17:00 |
| david-lyle | #endmeeting | 17:00 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings" | 17:00 | |
| openstack | Meeting ended Tue Apr 15 17:00:56 2014 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 17:00 |
| amotoki_ | thanks all! | 17:00 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/horizon/2014/horizon.2014-04-15-16.01.html | 17:01 |
| jcoufal | thank you guys | 17:01 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/horizon/2014/horizon.2014-04-15-16.01.txt | 17:01 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/horizon/2014/horizon.2014-04-15-16.01.log.html | 17:01 |
| *** doug-fish has left #openstack-meeting-3 | 17:01 | |
| jpich | Thanks everyone | 17:01 |
| *** clu_ has quit IRC | 17:01 | |
| *** pbelanyi has left #openstack-meeting-3 | 17:01 | |
| akrivoka | thanks everyone | 17:02 |
| tmazur | thanks all! | 17:04 |
| *** tmazur has quit IRC | 17:04 | |
| *** jpich has left #openstack-meeting-3 | 17:04 | |
| jrist | cheers | 17:05 |
| *** SumitNaiksatam has quit IRC | 17:11 | |
| *** akrivoka has left #openstack-meeting-3 | 17:13 | |
| *** lpetrut has joined #openstack-meeting-3 | 17:13 | |
| *** santibaldassin has left #openstack-meeting-3 | 17:19 | |
| *** lpetrut has quit IRC | 17:19 | |
| *** SumitNaiksatam has joined #openstack-meeting-3 | 17:27 | |
| *** lpetrut has joined #openstack-meeting-3 | 17:31 | |
| *** overlayer has joined #openstack-meeting-3 | 17:41 | |
| *** sarob has joined #openstack-meeting-3 | 17:44 | |
| *** amotoki_ has quit IRC | 17:45 | |
| *** beyounn has joined #openstack-meeting-3 | 17:49 | |
| *** mfer has quit IRC | 17:51 | |
| *** mfer has joined #openstack-meeting-3 | 17:51 | |
| *** jpomero has quit IRC | 17:57 | |
| *** dolphem is now known as dolphm | 18:01 | |
| *** lcheng has quit IRC | 18:02 | |
| *** eguz has quit IRC | 18:03 | |
| *** jpomero has joined #openstack-meeting-3 | 18:04 | |
| *** eghobo has joined #openstack-meeting-3 | 18:04 | |
| *** sarob has quit IRC | 18:17 | |
| *** sarob has joined #openstack-meeting-3 | 18:17 | |
| *** sarob has quit IRC | 18:22 | |
| *** sarob has joined #openstack-meeting-3 | 18:30 | |
| *** tzumainn has left #openstack-meeting-3 | 18:39 | |
| *** Sukhdev has joined #openstack-meeting-3 | 18:40 | |
| *** MaxV_ has joined #openstack-meeting-3 | 18:43 | |
| *** MaxV_ has quit IRC | 18:47 | |
| *** MaxV_ has joined #openstack-meeting-3 | 18:50 | |
| *** overlayer has quit IRC | 18:57 | |
| *** dtroyer has joined #openstack-meeting-3 | 18:57 | |
| *** briancurtin has joined #openstack-meeting-3 | 18:58 | |
| *** jamielennox has joined #openstack-meeting-3 | 18:59 | |
| *** bknudson has joined #openstack-meeting-3 | 19:00 | |
| briancurtin | #startmeeting python-openstacksdk | 19:00 |
| openstack | Meeting started Tue Apr 15 19:00:24 2014 UTC and is due to finish in 60 minutes. The chair is briancurtin. Information about MeetBot at http://wiki.debian.org/MeetBot. | 19:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 19:00 |
| *** openstack changes topic to " (Meeting topic: python-openstacksdk)" | 19:00 | |
| openstack | The meeting name has been set to 'python_openstacksdk' | 19:00 |
| briancurtin | If you're here for the python-openstacksdk meeting, can you state your name and affiliation? | 19:01 |
| *** wchrisj has joined #openstack-meeting-3 | 19:01 | |
| briancurtin | FYI i know alex isn't going to make it, i believe ed is on vacation the rest of the week | 19:01 |
| bknudson | Brant Knudson -- IBm | 19:02 |
| briancurtin | Brian Curtin, Rackspace | 19:02 |
| wchrisj | Chris Johnson, HP | 19:02 |
| dtroyer | Dean Troyer, Nebula | 19:02 |
| jamielennox | Jamie Lennox, Red Hat | 19:02 |
| briancurtin | I think that'll probably be it | 19:03 |
| jamielennox | small one today | 19:03 |
| briancurtin | Just a quick mention before getting going: so far the probably 7-8 people I've talked to about the general goals and direction of this project here at PyCon are pretty excited to see where it goes. may have a few people to jump in and get involved as well | 19:03 |
| *** zigo has quit IRC | 19:04 | |
| *** dstanek has joined #openstack-meeting-3 | 19:04 | |
| briancurtin | since Ed isn't here, perhaps we start with jamielennox | 19:04 |
| briancurtin | #topic https://review.openstack.org/#/c/86227/ Add base resource class | 19:05 |
| *** openstack changes topic to "https://review.openstack.org/#/c/86227/ Add base resource class (Meeting topic: python-openstacksdk)" | 19:05 | |
| *** jpomero_ has joined #openstack-meeting-3 | 19:05 | |
| *** sarob has quit IRC | 19:05 | |
| briancurtin | jamielennox: i only took a look shortly before the meeting since i was occupied, but i'm a fan of this FWIW | 19:05 |
| jamielennox | right, so i realize that the base class there is a long way from perfect - but in general i prefer the concept of doing class based lookups rather than managers | 19:05 |
| *** MaxV_ has quit IRC | 19:05 | |
| *** sarob has joined #openstack-meeting-3 | 19:06 | |
| jamielennox | the mixing it with managers actually worked better than i anticipated though | 19:06 |
| jamielennox | dtroyer: you and i have discussed the managers concepts a few times, did you get a chance to look at that layout? | 19:06 |
| dtroyer | sadly, no. | 19:07 |
| *** jpomero has quit IRC | 19:07 | |
| jamielennox | i was starting another client recently and found again that the managers approach (and the base classes in OSLO) don't cover all situations | 19:07 |
| *** zigo has joined #openstack-meeting-3 | 19:07 | |
| bknudson | another client? | 19:08 |
| bknudson | for kite? | 19:08 |
| jamielennox | bknudson: yes | 19:08 |
| bknudson | jamielennox: just start with the openstack-sdk | 19:08 |
| briancurtin | jamielennox: what are some of these situations where it doesn't work? | 19:09 |
| jamielennox | partially it's about implementation there | 19:09 |
| jamielennox | but essentially there is not a base resource key | 19:09 |
| jamielennox | or more correctly there is a base resource key - but the resource is just a string | 19:09 |
| jamielennox | eg { 'key': 'abcdef' } | 19:10 |
| *** sarob has quit IRC | 19:10 | |
| jamielennox | anyway - either the manager or base class approach can be improved to make these things work - i think it's just a matter of choosing the general direction | 19:11 |
| bknudson | jamielennox: class Manager says it's only there for compatibility with existing clients... but there's no existing clients at this point. | 19:11 |
| jamielennox | also there was the situation there where a lot of operations (like get) aren't supported by kite | 19:12 |
| bknudson | a resource without a GET operation... weird. | 19:12 |
| jamielennox | bknudson: it was a way of keeping compatability if we need to go the client.users.list() approach | 19:12 |
| jamielennox | bknudson: key's are private - you can't retrieve them | 19:12 |
| bknudson | bknudson: is HEAD supported? | 19:13 |
| dtroyer | I'd be all for not having any compatability layers in the SDK. If we need them they should be explicitly marked and separate | 19:13 |
| briancurtin | +1 to dtroyer | 19:13 |
| jamielennox | bknudson: talking to yourself? - no it's not | 19:13 |
| jamielennox | dtroyer: i agree | 19:13 |
| jamielennox | without it it just means you have to pass a session object around a lot | 19:14 |
| jamielennox | there is probably some way we could abstract that at a higher level | 19:14 |
| jamielennox | but i don't see that as a problem for a basic version specific class | 19:16 |
| briancurtin | agreed | 19:16 |
| jamielennox | i'm also not convinced on the _by_id suffix to distinguish classmethods but i figure that's a detail at this point | 19:17 |
| briancurtin | yeah, i think that's fine | 19:20 |
| bknudson | jamielennox: what's an example of a resource, like identity.User ? | 19:20 |
| jamielennox | bknudson: yes | 19:20 |
| bknudson | jamielennox: do you think some of the Resource API depends on how well OpenStack REST APIs conform to some convention? | 19:22 |
| jamielennox | briancurtin: the issue with urljoin is that it obeys web semantics, so if you urljoin('prefix', '/path') it would take that as you clicking on a url for /path and ignore the prefix | 19:22 |
| briancurtin | jamielennox: ah, ignore me then | 19:23 |
| bknudson | for example, it's got "resource_key" and "resources_key" -- but maybe there's no plural form of the key element. | 19:23 |
| *** sarob has joined #openstack-meeting-3 | 19:23 | |
| jamielennox | bknudson: i do, but i see that as the 90% case (and the way that it is handled by almost all clients now) | 19:23 |
| jamielennox | bknudson: you can also override classmethods | 19:23 |
| dtroyer | re: the urljoin() stuff, would it make sense to consolidate the manual handling into our own version of urljoin() with the desired behaviour? | 19:24 |
| jamielennox | dtroyer: yea, it would | 19:25 |
| *** terrylhowe has joined #openstack-meeting-3 | 19:25 | |
| jamielennox | i don't think any of those locations are doing anything funny | 19:25 |
| jamielennox | bknudson: also in the case of resource_eky and resources_key everywhere that they are used in resource.py should be lead with a if self.resource_key: block | 19:26 |
| *** MaxV_ has joined #openstack-meeting-3 | 19:26 | |
| wchrisj | encapsulation FTW dtroyer | 19:26 |
| briancurtin | yep, now that i know urljoin is wrong, +1 to doing that | 19:27 |
| briancurtin | anything else on this one for now? unfortunately i'm behind and need to have more looks, so i don't have much input at the moment | 19:30 |
| dtroyer | I think my biggest conceptual hurdle to this approach is the semantics of list(). All other actions you either have a resource or the information to create one. | 19:30 |
| dtroyer | I don't think it is a blocker though | 19:30 |
| wchrisj | Do we have a consensus on the Manager class? | 19:31 |
| wchrisj | Is it staying or going? | 19:31 |
| dtroyer | if it only there for compat I think it can go | 19:32 |
| wchrisj | +1 dtroyer | 19:32 |
| jamielennox | i can remove it for now | 19:33 |
| jamielennox | i don't think we need it currenlty | 19:33 |
| *** MaxV_ has quit IRC | 19:33 | |
| briancurtin | sounds good | 19:33 |
| wchrisj | Dont have a strong feeling on it, but do think the simpler we can start, the better; it doesnt seem to add much value. | 19:33 |
| jamielennox | dtroyer: would you like to just remove list() for now as well | 19:35 |
| jamielennox | all we really need at this point is a consensus on the object vs manager approach | 19:36 |
| dtroyer | not yet, I want to think about how it should look though... | 19:36 |
| bknudson | it would be nice if there was example client code | 19:36 |
| jamielennox | bknudson: right, i know the keystone stuff well enough to have a go at that | 19:37 |
| wchrisj | The sooner that I can fire up the client and at minimum just do a basic auth, the better | 19:37 |
| wchrisj | even if it's not the pluggable auth that is the end goal | 19:37 |
| dtroyer | bknudson: I've thought that too. I have some small scripts that I used for testing Session and discovery | 19:38 |
| dtroyer | should we have some samples in the repo at some point? | 19:38 |
| briancurtin | wchrisj: YES. i'm hoping to get some time later today or tomorrow to bring back an old proposal of alex gaynor's, and then hopefully soon enough we pick a route and run with it | 19:38 |
| briancurtin | dtroyer: absolutely | 19:38 |
| jamielennox | yea, it will depend on how we adhere to that old proposal of having an object per request we make | 19:39 |
| wchrisj | briancurtin What did Alex's proposal specifically address? | 19:39 |
| briancurtin | not sure how to define "some point", but i'd really like that to be sooner than later | 19:39 |
| bknudson | I'm always a fan of having as much of the documentation in the docstrings as we can | 19:39 |
| bknudson | even sample code | 19:39 |
| briancurtin | wchrisj: i don't really have a great description of it, but i'll dig up the original file (it was one of the examples that we removed before kicking off the session wrapper) | 19:41 |
| wchrisj | briancurtin - I remember the proposal; dont remember the specific content | 19:41 |
| briancurtin | wchrisj: here's what it was: https://github.com/stackforge/python-openstacksdk/blob/956418f5d87156673a2daf3b67ed31b285e15690/api_strawman/client.py | 19:42 |
| bknudson | I hope we don't have to build the auth data with json.dumps({"auth": {"passwordCredentials"...) by the time this is done | 19:43 |
| wchrisj | briancurtin - Understood. My only issue is that code is pretty monolithic; would prefer OO approach... | 19:44 |
| bknudson | oh, I thought this was sample client code. | 19:44 |
| jamielennox | my ideal here is that even if we don't import the other clients that session and auth plugin (which are almost exactly the same as keystoneclient) could be extracted into a base library | 19:45 |
| briancurtin | bknudson: i guess i'll sit down with alex and see what he intends with it | 19:45 |
| wchrisj | bknudson - It is sample client code | 19:45 |
| jamielennox | to be shared between -sdk and other clients | 19:45 |
| briancurtin | i could have just misunderstood it | 19:45 |
| wchrisj | ok | 19:45 |
| jamielennox | new review upload without a manager and with a urljoin | 19:46 |
| jamielennox | https://review.openstack.org/#/c/86227/ | 19:46 |
| dtroyer | if everything could only be that fast… ;) | 19:47 |
| wchrisj | w00t | 19:47 |
| *** peristeri has quit IRC | 19:48 | |
| jamielennox | dtroyer: you are right on list() not everything supports marker and limit and there are a number of problems there that i think are best tackled as we come across them | 19:50 |
| jamielennox | so long as list() etc are explicity enabled (rather than now where every manager automatically gets a list, update etc that doesn't always work) i don't see this being a problem | 19:51 |
| jamielennox | there were a lot of comments on the first review about duplicating the session calls into the resource.py file - did that need make sense? | 19:52 |
| jamielennox | and for bonus points did anyone have an opinion on the Session Binding review i linked https://review.openstack.org/#/c/86237/ and if it would be useful here? | 19:53 |
| dtroyer | I think the Accept header should be handled in Session, enabled with an arg, and those methods can all go away | 19:53 |
| dtroyer | more than just the Resource object will want it | 19:54 |
| jamielennox | dtroyer: in the general case (and assuming that plugins here will have similar functionality to ksc) there is more than just accept that is going to be different per client view though | 19:55 |
| jamielennox | particularly i'm thinking service_type and service_version | 19:55 |
| terrylhowe | It definitely doesn't belong in a resource class, but as long as the plan is to get rid of it in the future ... | 19:55 |
| dtroyer | sure, and that's where the headers arg comes in, but this Accept is pretty common | 19:55 |
| jamielennox | terrylhowe: ++ | 19:56 |
| jamielennox | dtroyer: i'm willing to put accept in as a special case | 19:56 |
| jamielennox | dtroyer: but service_type etc aren't headers and they will otherwise need to be set on every call | 19:56 |
| dtroyer | it matches the json handling that is already there. | 19:57 |
| dtroyer | service_type, etc get their own Resource subclass? or mixin or whatever? | 19:57 |
| jamielennox | dtroyer: the point of the current session object is to be able to do a .get('/path/to', service_type='identity', version=(3,1)) and have the session/plugins manage the catalog for you | 19:58 |
| jamielennox | s/the point/a point | 19:59 |
| dtroyer | there's no reason that can't continue, that doesn't belong in the low-level Session/request interface | 19:59 |
| dtroyer | maybe it isn't called 'Session' though… | 20:00 |
| jamielennox | dtroyer: where does it belong then? | 20:00 |
| wchrisj | that's been my concern from the start | 20:00 |
| jamielennox | it's very tied up there in keystoneclient because that's where auth lives | 20:00 |
| dtroyer | at the level (yet to be named) that manages the auth and Session and what would be managers if we had them? | 20:00 |
| wchrisj | I just think of most of this activity as transport related | 20:01 |
| wchrisj | http layer | 20:01 |
| *** markmcclain has joined #openstack-meeting-3 | 20:01 | |
| wchrisj | session is the data that must be maintained for the user/consumer | 20:01 |
| wchrisj | IMO | 20:01 |
| wchrisj | unless I'm missing some context here | 20:01 |
| bknudson | I think that would be the service catalog? | 20:01 |
| bknudson | would include the | 20:01 |
| bknudson | and the token | 20:02 |
| briancurtin | now that we're over time and i have to head somewhere in a min, i'm outta here | 20:02 |
| briancurtin | #endmeeting | 20:02 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings" | 20:02 | |
| openstack | Meeting ended Tue Apr 15 20:02:19 2014 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 20:02 |
| jamielennox | wchrisj: right, but auth needs to be lined to that | 20:02 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/python_openstacksdk/2014/python_openstacksdk.2014-04-15-19.00.html | 20:02 |
| bknudson | thanks | 20:02 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/python_openstacksdk/2014/python_openstacksdk.2014-04-15-19.00.txt | 20:02 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/python_openstacksdk/2014/python_openstacksdk.2014-04-15-19.00.log.html | 20:02 |
| wchrisj | headed to openstack-sdks | 20:02 |
| *** bknudson has left #openstack-meeting-3 | 20:02 | |
| wchrisj | jaimielennox ^^ | 20:02 |
| *** jamielennox has left #openstack-meeting-3 | 20:03 | |
| *** sarob has quit IRC | 20:12 | |
| *** sarob has joined #openstack-meeting-3 | 20:12 | |
| *** sarob has quit IRC | 20:17 | |
| *** MaxV_ has joined #openstack-meeting-3 | 20:31 | |
| *** dstanek has quit IRC | 20:38 | |
| *** Sukhdev has quit IRC | 20:40 | |
| *** terrylhowe has left #openstack-meeting-3 | 20:43 | |
| *** jcoufal has quit IRC | 20:44 | |
| *** dstanek has joined #openstack-meeting-3 | 20:45 | |
| *** mwagner_lap has quit IRC | 20:50 | |
| *** sarob has joined #openstack-meeting-3 | 20:51 | |
| *** sarob has quit IRC | 20:51 | |
| *** sarob has joined #openstack-meeting-3 | 20:51 | |
| *** zigo has quit IRC | 21:06 | |
| *** zigo has joined #openstack-meeting-3 | 21:08 | |
| *** sarob has quit IRC | 21:19 | |
| *** coolsvap|afk has quit IRC | 21:25 | |
| *** coolsvap|afk has joined #openstack-meeting-3 | 21:26 | |
| *** jpomero_ has quit IRC | 21:28 | |
| *** mfer has quit IRC | 21:46 | |
| *** garyduan has quit IRC | 21:46 | |
| *** sarob has joined #openstack-meeting-3 | 21:50 | |
| *** lpetrut has quit IRC | 22:03 | |
| *** david_lyle_ has joined #openstack-meeting-3 | 22:04 | |
| *** david-lyle has quit IRC | 22:07 | |
| *** MaxV_ has quit IRC | 22:15 | |
| *** dstanek has quit IRC | 22:19 | |
| *** overlayer has joined #openstack-meeting-3 | 22:25 | |
| *** markmcclain has quit IRC | 22:32 | |
| *** sarob has quit IRC | 22:37 | |
| *** sarob has joined #openstack-meeting-3 | 22:37 | |
| *** sarob has quit IRC | 22:42 | |
| *** dstanek has joined #openstack-meeting-3 | 22:46 | |
| *** david_lyle_ has quit IRC | 22:57 | |
| *** mwagner_lap has joined #openstack-meeting-3 | 23:04 | |
| *** eguz has joined #openstack-meeting-3 | 23:16 | |
| *** eguz has quit IRC | 23:16 | |
| *** eguz has joined #openstack-meeting-3 | 23:16 | |
| *** dstanek has quit IRC | 23:18 | |
| *** eghobo has quit IRC | 23:20 | |
| *** sarob has joined #openstack-meeting-3 | 23:21 | |
| *** eguz has quit IRC | 23:24 | |
| *** sarob has quit IRC | 23:26 | |
| *** eghobo has joined #openstack-meeting-3 | 23:28 | |
| *** openstackstatus has quit IRC | 23:32 | |
| *** openstackstatus has joined #openstack-meeting-3 | 23:33 | |
| *** eguz has joined #openstack-meeting-3 | 23:39 | |
| *** eghobo has quit IRC | 23:43 | |
| *** overlayer has quit IRC | 23:50 | |
| *** sarob has joined #openstack-meeting-3 | 23:51 | |
| *** dstanek has joined #openstack-meeting-3 | 23:55 | |
| *** sarob has quit IRC | 23:56 | |
| *** sarob has joined #openstack-meeting-3 | 23:57 | |
| *** mordred has quit IRC | 23:58 | |
| *** mordred has joined #openstack-meeting-3 | 23:58 | |
| *** ChanServ changes topic to "Restarting gerrit really quick to fix replication issue" | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!