Thursday, 2019-02-21

*** jamesmcarthur has quit IRC00:01
*** macza has quit IRC00:06
*** markvoelker has joined #openstack-meeting-300:19
*** mjturek has joined #openstack-meeting-300:45
*** mjturek has quit IRC00:51
*** slaweq has quit IRC00:52
*** logan- has quit IRC01:22
*** logan- has joined #openstack-meeting-301:23
*** logan- has quit IRC01:31
*** logan- has joined #openstack-meeting-301:31
*** sdake has quit IRC01:44
*** sdake has joined #openstack-meeting-301:46
*** jamesmcarthur has joined #openstack-meeting-302:10
*** jamesmcarthur has quit IRC02:37
*** jamesmcarthur has joined #openstack-meeting-302:42
*** purplerbot has quit IRC02:43
*** purplerbot has joined #openstack-meeting-302:44
*** hongbin has joined #openstack-meeting-302:48
*** sdake has quit IRC02:48
*** sdake has joined #openstack-meeting-302:49
*** psachin has joined #openstack-meeting-302:52
*** sdake has quit IRC02:57
*** sdake has joined #openstack-meeting-303:00
*** dklyle has quit IRC03:03
*** jamesmcarthur has quit IRC03:08
*** apetrich has quit IRC03:14
*** dklyle has joined #openstack-meeting-303:17
*** markvoelker has quit IRC03:20
*** jamesmcarthur has joined #openstack-meeting-303:32
*** spsurya has joined #openstack-meeting-303:34
*** jamesmcarthur has quit IRC04:00
*** jamesmcarthur has joined #openstack-meeting-304:01
*** jamesmcarthur has quit IRC04:05
*** markvoelker has joined #openstack-meeting-304:21
*** ianychoi has quit IRC04:31
*** sdake has quit IRC04:50
*** markvoelker has quit IRC04:55
*** sdake has joined #openstack-meeting-304:55
*** hongbin has quit IRC05:04
*** diablo_rojo has quit IRC05:05
*** sdake has quit IRC05:14
*** sdake has joined #openstack-meeting-305:16
*** yamamoto has quit IRC05:44
*** yamamoto has joined #openstack-meeting-305:48
*** sdake has quit IRC05:48
*** sdake has joined #openstack-meeting-305:50
*** markvoelker has joined #openstack-meeting-305:52
*** sdake has quit IRC06:03
*** sdake has joined #openstack-meeting-306:05
*** markvoelker has quit IRC06:25
*** spsurya has quit IRC06:25
*** sdake has quit IRC06:37
*** Luzi has joined #openstack-meeting-306:40
*** igordc has quit IRC06:52
*** yamamoto has quit IRC06:59
*** slaweq has joined #openstack-meeting-307:08
*** psachin has quit IRC07:10
*** spsurya has joined #openstack-meeting-307:17
*** pcaruana has joined #openstack-meeting-307:19
*** markvoelker has joined #openstack-meeting-307:22
*** sambetts_ has quit IRC07:29
*** sambetts_ has joined #openstack-meeting-307:30
*** psachin has joined #openstack-meeting-307:32
*** apetrich has joined #openstack-meeting-307:33
*** yamamoto has joined #openstack-meeting-307:38
*** markvoelker has quit IRC07:55
*** _pewp_ has quit IRC07:58
*** _pewp_ has joined #openstack-meeting-307:59
*** tssurya has joined #openstack-meeting-307:59
*** ralonsoh has joined #openstack-meeting-308:51
*** markvoelker has joined #openstack-meeting-308:52
*** yamamoto has quit IRC08:56
*** yamamoto has joined #openstack-meeting-309:04
*** e0ne has joined #openstack-meeting-309:14
*** markvoelker has quit IRC09:25
*** moguimar has joined #openstack-meeting-309:33
*** tssurya has quit IRC09:43
*** tssurya has joined #openstack-meeting-309:57
*** yamamoto has quit IRC09:58
*** markvoelker has joined #openstack-meeting-310:17
*** spsurya has quit IRC10:22
*** yamamoto has joined #openstack-meeting-310:34
*** psachin has quit IRC10:38
*** yamamoto has quit IRC10:39
*** psachin has joined #openstack-meeting-310:42
*** lpetrut has joined #openstack-meeting-311:03
*** tssurya has quit IRC11:05
*** psachin has quit IRC11:22
*** yamamoto has joined #openstack-meeting-311:29
*** raildo has joined #openstack-meeting-311:33
*** yamamoto has quit IRC11:34
*** sdake has joined #openstack-meeting-312:02
*** tssurya has joined #openstack-meeting-312:18
*** e0ne has quit IRC12:24
*** yamamoto has joined #openstack-meeting-312:28
*** edleafe has joined #openstack-meeting-312:30
*** e0ne has joined #openstack-meeting-312:31
*** yamamoto has quit IRC12:34
*** yamamoto has joined #openstack-meeting-313:03
*** yamamoto has quit IRC13:08
*** markvoelker has quit IRC13:17
*** markvoelker has joined #openstack-meeting-313:18
*** markvoelker has quit IRC13:22
*** sdake has quit IRC13:23
*** tosky has joined #openstack-meeting-313:24
*** sdake has joined #openstack-meeting-313:25
*** yamamoto has joined #openstack-meeting-313:36
*** sdake has quit IRC13:36
*** yamamoto has quit IRC13:36
*** sdake has joined #openstack-meeting-313:38
*** jamesmcarthur has joined #openstack-meeting-313:43
*** yamamoto has joined #openstack-meeting-313:47
*** tellesnobrega has joined #openstack-meeting-313:57
*** jamesmcarthur has quit IRC13:58
*** jamesmcarthur has joined #openstack-meeting-313:58
tellesnobrega#startmeeting sahara14:00
openstackMeeting started Thu Feb 21 14:00:22 2019 UTC and is due to finish in 60 minutes.  The chair is tellesnobrega. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
*** openstack changes topic to " (Meeting topic: sahara)"14:00
openstackThe meeting name has been set to 'sahara'14:00
toskyo/14:00
tellesnobregawaiting to see if jeremyfreudberg joins14:01
tellesnobregaapparently not14:02
tellesnobrega#topic News/Updates14:02
*** openstack changes topic to "News/Updates (Meeting topic: sahara)"14:02
*** njohnston has joined #openstack-meeting-314:02
*** njohnston has left #openstack-meeting-314:02
tellesnobregaI'm stuck on python3 issue related to pickle14:03
tellesnobregaI've reached out for some help but nothing so far has worked14:03
*** jamesmcarthur has quit IRC14:03
toskypickles from pickle14:03
tellesnobregaI'm now trying to set up a python3 only image so I can test if the error is only related to python2->python3 or even with both environments running on python3 if it still raises the same issue14:04
toskyI've helped with a tons of backports to the older branches14:04
toskywe have a blocker for merging stuff to pike, the issue is a bit complex and this bug contains all the details: https://bugs.launchpad.net/tempest/+bug/181602214:05
openstackLaunchpad bug 1816022 in tempest "Incompatible requirements break tempest (at least) on stable/pike" [Undecided,New]14:05
toskyI still need to test the mapr fixes14:07
toskybut we are in a better shape, also the number of open reviews lowered (thanks to a Friday-night review by Jeremy :)14:07
tellesnobregayes, I guess python 3 is the only critical stuff right now14:08
tellesnobregashould I  explain a bit of the python 3 issue here14:11
tellesnobregaso we have it on records?14:11
toskyyep, I'd say so14:11
tellesnobrega#topic python314:11
*** openstack changes topic to "python3 (Meeting topic: sahara)"14:11
toskyso we can point to these logs in emails14:11
tellesnobregaSo, the issue we are facing with python3 now is related to pickle14:11
tellesnobregaSahara uses Pickle to serialize functions (path of a function) to send them to be executed in a Subprocess.Popen14:12
tellesnobregaeither locally or over ssh (depending on the command)14:12
tellesnobregaAt first, the error being returned was a Run of input, which we fixed by adding buffer on the process and dumping from pickle into the subprocess buffer14:13
*** yamamoto has quit IRC14:13
tellesnobregaright now, the error being returned is a invalid load key '<', which we thought to be encoding but that didn't pay off14:14
*** sdake has quit IRC14:14
*** yamamoto has joined #openstack-meeting-314:14
toskyunless we encoded it in the wrong way, but it's difficult to say14:14
*** yamamoto has quit IRC14:14
*** yamamoto has joined #openstack-meeting-314:15
tellesnobregathe most consistent suggestion from python experts was to replace pickle with json, for safety, but I'm not sure how to do the proper serialization with json14:15
tellesnobregadid I miss anything tosky ?14:16
toskyI don't think so14:16
toskyI mean, nothing else to add14:17
tellesnobregacool14:17
tellesnobregamaybe jeremy will read and come up with something to help14:17
*** jeremyfreudberg has joined #openstack-meeting-314:18
jeremyfreudbergsorry, forgot about the meeting...14:18
jeremyfreudberganything for me to weigh in on?14:18
fungireplacing pickle with structured data serialization14:18
*** markvoelker has joined #openstack-meeting-314:18
* fungi is lurking14:18
tellesnobregafungi, we need help on that14:19
tellesnobregaanyone who is willing to do so is more than welcome14:19
*** yamamoto has quit IRC14:19
fungioh, i was answering jeremyfreudberg's question14:19
tellesnobregaoh, ok14:20
tellesnobregajeremyfreudberg, we are kind of blocked on python3 pickle issue14:20
fungithough i am interested in it from the vmt perspective simply because there are a number of potential risks with pickle use, i doubt i have time to implement anything there14:20
fungiseeing more occurrences of pickle get squashed in favor of safer serialization would be nice14:21
toskyfungi: do you know of examples of such replacements that already happened in openstack (or anywhere else)?14:21
tellesnobregafungi, we understand that, and I'm willing to replace it, if I can get some help understanding how to do it14:22
fungitosky: i don't have any specific examples off the top of my head though i think there have been at least a few over the years14:22
fungido you pass complex objects and/or functions over pickle, or just basic data types?14:23
tellesnobregafunctions14:23
tellesnobregabut iiuc the serialization is just a path of the function14:24
fungiin that case it may not be any safer security-wise if you want to be able to send arbitrary functions to a subprocess for execution (avoiding doing that "accidentally" is the main reason most people warn against using pickle, after all)14:25
tellesnobregafungi, here is an example of what happens in sahara14:25
tellesnobrega>>> ser = pickle.dumps(identity)14:25
tellesnobrega>>> ser14:25
tellesnobrega‘c__main__\nidentity\np0\n.’14:25
tellesnobregabut we do it on subprocess stdin14:26
fungiyeah, i mean in this case the risk is low anyway because you're (hopefully) never going to have untrusted pickle data passed into these subprocesses anyway14:28
fungii expect you're fighting the use of binary sequences for file descriptors in python314:28
tellesnobregathere are only a few cases of that happening and none are controlled by the user14:28
toskyour case is complicated by the fact that we trasmit the python code from python3 to python214:29
toskyas most of the hadoop vendors still run (and will run for a while) on older distributions14:29
*** jamesmcarthur has joined #openstack-meeting-314:29
fungioh, in that case the pickle is likely just not valid at all. i don't know that python2 can be expected to even make use of a pickle payload from python314:30
fungihas anyone looked into whether that's supported?14:30
tellesnobregaeven we specify the protocol?14:30
jeremyfreudbergtosky, are we sure that's what's happening? i thought the pickling was just between sahara-engine and _sahara-subprocess , no depickling done on the instances14:31
jeremyfreudbergbut i might have missed something14:31
*** sdake has joined #openstack-meeting-314:31
toskyoh14:31
toskyuhm, maybe14:31
toskybetter if I just follow the discussion :)14:31
tellesnobregajeremyfreudberg, when we call _execute_command("ls .ssh/authorized_keys") doesn't it run on the instances?14:32
fungiahh, yeah looks like perhaps if you write the pickle as data stream format #2 in python3 then python2.3 and later should be able to read it14:32
tellesnobregafungi, I have set pickle to use protocol=2, it solved some issues, but the ones we are seeing now came up14:33
*** jamesmcarthur has quit IRC14:34
jeremyfreudbergtellesnobrega: with _execute_command i think that is after the depickling has already happened (we open an ssh session with paramiko and the command is just a string)14:34
fungiyeah, pickle is pretty opaque without digging into pep 307 and earlier relevant protocol specifications it builds on14:35
fungiso hard to say14:35
jeremyfreudbergtellesnobrega, i  will look a little closer, there may be some info that i am missing14:36
tellesnobregajeremyfreudberg,  thanks, please do, I might be mistaken as well14:36
fungias far as the "invalid load key '<'" exceptions14:36
tellesnobregawhat I saw is the same pickling path for bot _connect (when we open the ssh connection) and the _execute_command14:37
jeremyfreudbergtellesnobrega: what's "path"?14:37
tellesnobregajeremyfreudberg, I mean, it goes through the same logic, pickling the function and sending to subprocess stdin and same for args and kwargs14:39
jeremyfreudbergoh, got it14:39
*** hongbin has joined #openstack-meeting-314:42
*** hongbin has quit IRC14:42
jeremyfreudbergtosky, tellesnobrega, has anyone actually looked at the full traceback with the "Ran out of input" error?14:44
jeremyfreudberg(the traceback is suppressed in the logs)14:44
toskyI did not14:44
tellesnobregame neither14:44
toskyuhm, if it's suppressed, where should it be visible?14:44
tellesnobregaI think I saw it once, while running with debug, but not much was useful, but you can try as well14:45
jeremyfreudberghttps://github.com/openstack/sahara/blob/8659169c84c9a2198d5aee9e94c6d145a1f8d93c/sahara/service/engine.py#L12514:45
toskyah, removing that exception, or printing more details14:47
jeremyfreudbergyup14:48
jeremyfreudberginstead of the repr of the exception, the entire trace would be helpful, at least to me14:49
tellesnobregajeremyfreudberg, I will run again and get that exception14:50
tellesnobregaand send by email14:50
jeremyfreudbergtellesnobrega: great, thanks!14:50
jeremyfreudberg(no need for it in the gate, it's just the one spot)14:50
*** mjturek has joined #openstack-meeting-314:51
tellesnobregaok14:51
*** sdake has quit IRC14:51
*** markvoelker has quit IRC14:53
jeremyfreudbergany other topics for these last few minutes?14:53
toskythere was an interesting discussion yesterday evening on #openstack-sahara about the dashboard, please check the logs14:54
* jeremyfreudberg looking now14:54
toskyI fixed the native integration tests again following your suggestions (now experimental), ready to be merged and backported to remove the legacy job14:54
*** yamamoto has joined #openstack-meeting-314:57
jeremyfreudbergright now every test fails, right? or are there a very small number which pass14:57
jeremyfreudbergin any case, ivan is in enough agreement that we can merge the patch14:57
toskyall of them fails, for different reasons :)14:58
toskybut they are executed14:58
jeremyfreudbergyup,  i see. 8 tests run and 8 tests failed :)14:58
tellesnobregacool14:58
jeremyfreudbergso let's merge that14:58
tellesnobregayes14:58
jeremyfreudbergwe're at the hour14:59
tellesnobregayes14:59
tellesnobregathanks jeremyfreudberg and tosky14:59
tellesnobregaand thanks fungi as well14:59
tellesnobregalets see if we can figure out the python3 issue this week15:00
tellesnobregasee you all next week15:00
tellesnobrega#endmeeting15:00
toskysee you!15:00
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/"15:00
openstackMeeting ended Thu Feb 21 15:00:11 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:00
openstackMinutes:        http://eavesdrop.openstack.org/meetings/sahara/2019/sahara.2019-02-21-14.00.html15:00
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/sahara/2019/sahara.2019-02-21-14.00.txt15:00
openstackLog:            http://eavesdrop.openstack.org/meetings/sahara/2019/sahara.2019-02-21-14.00.log.html15:00
*** tosky has left #openstack-meeting-315:00
*** jeremyfreudberg has left #openstack-meeting-315:00
*** tellesnobrega has left #openstack-meeting-315:00
*** hongbin has joined #openstack-meeting-315:00
*** yamamoto has quit IRC15:01
*** sdake has joined #openstack-meeting-315:02
*** jamesmcarthur has joined #openstack-meeting-315:10
*** Luzi has quit IRC15:12
*** jamesmcarthur has quit IRC15:17
*** aagate has joined #openstack-meeting-315:17
*** xubozhang has joined #openstack-meeting-315:24
*** xubozhang has quit IRC15:31
*** apetrich has quit IRC15:36
*** xubozhang has joined #openstack-meeting-315:37
*** apetrich has joined #openstack-meeting-315:41
*** liuyulong has quit IRC15:43
*** liuyulong has joined #openstack-meeting-315:43
*** sdake has quit IRC15:48
*** jamesmcarthur has joined #openstack-meeting-315:48
*** markvoelker has joined #openstack-meeting-315:50
*** sdake has joined #openstack-meeting-315:50
*** jamesmcarthur has quit IRC15:53
*** jamesmcarthur has joined #openstack-meeting-315:58
*** jamesmcarthur has quit IRC15:58
*** jamesmcarthur has joined #openstack-meeting-315:58
*** moguimar has quit IRC15:59
*** moguimar has joined #openstack-meeting-315:59
*** diablo_rojo has joined #openstack-meeting-316:00
*** moguimar has quit IRC16:01
*** moguimar has joined #openstack-meeting-316:02
*** Gaasmann has joined #openstack-meeting-316:06
*** Gaasmann has left #openstack-meeting-316:06
*** jamesmcarthur has quit IRC16:13
*** e0ne has quit IRC16:23
*** markvoelker has quit IRC16:23
*** macza has joined #openstack-meeting-316:24
*** jamesmcarthur has joined #openstack-meeting-316:27
*** yamamoto has joined #openstack-meeting-316:45
*** lpetrut has quit IRC16:46
*** lpetrut has joined #openstack-meeting-316:49
*** yamamoto has quit IRC16:50
*** pcaruana has quit IRC17:07
*** tssurya has quit IRC17:08
*** moguimar has quit IRC17:17
*** yamamoto has joined #openstack-meeting-317:20
*** markvoelker has joined #openstack-meeting-317:20
*** jamesmcarthur_ has joined #openstack-meeting-317:24
*** yamamoto has quit IRC17:25
*** jamesmcarthur has quit IRC17:27
*** yamamoto has joined #openstack-meeting-317:47
*** markvoelker has quit IRC17:53
*** lpetrut has quit IRC17:54
*** sdake has quit IRC18:05
*** sdake has joined #openstack-meeting-318:05
*** igordc has joined #openstack-meeting-318:09
*** markvoelker has joined #openstack-meeting-318:50
*** ralonsoh has quit IRC18:56
*** liuyulong has quit IRC19:13
*** yamahata__ has quit IRC19:14
*** manjeets has quit IRC19:14
*** yamahata__ has joined #openstack-meeting-319:14
*** manjeets has joined #openstack-meeting-319:14
*** markvoelker has quit IRC19:23
*** jamesmcarthur_ has quit IRC19:56
*** jamesmcarthur has joined #openstack-meeting-319:57
*** jamesmcarthur has quit IRC20:01
*** e0ne has joined #openstack-meeting-320:14
*** jamesmcarthur has joined #openstack-meeting-320:18
*** markvoelker has joined #openstack-meeting-320:21
*** e0ne has quit IRC20:37
*** jamesmcarthur has quit IRC20:40
*** jamesmcarthur has joined #openstack-meeting-320:40
*** jamesmcarthur has quit IRC20:45
*** macza has quit IRC20:45
*** macza has joined #openstack-meeting-320:45
*** _pewp_ has quit IRC20:48
*** _pewp_ has joined #openstack-meeting-320:48
*** jamesmcarthur has joined #openstack-meeting-320:53
*** markvoelker has quit IRC20:55
*** macza has quit IRC21:19
*** slaweq has quit IRC21:35
*** slaweq has joined #openstack-meeting-321:48
*** markvoelker has joined #openstack-meeting-321:53
*** macza has joined #openstack-meeting-321:53
*** macza has quit IRC21:55
*** macza has joined #openstack-meeting-321:55
*** jamesmcarthur has quit IRC21:57
*** jamesmcarthur has joined #openstack-meeting-322:05
*** jamesmcarthur has quit IRC22:07
*** markvoelker has quit IRC22:25
*** sdake has quit IRC22:27
*** slaweq has quit IRC22:43
*** slaweq has joined #openstack-meeting-322:55
*** slaweq has quit IRC23:00
*** slaweq has joined #openstack-meeting-323:11
*** sdake has joined #openstack-meeting-323:12
*** slaweq has quit IRC23:16
*** markvoelker has joined #openstack-meeting-323:22
*** igordc has quit IRC23:30
*** sdake has quit IRC23:33
*** sdake has joined #openstack-meeting-323:38
*** raildo has quit IRC23:39
*** sdake has quit IRC23:46
*** sdake has joined #openstack-meeting-323:48
*** sdake has quit IRC23:51
*** sdake_ has joined #openstack-meeting-323:51
*** markvoelker has quit IRC23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!