| *** ricolin has joined #openstack-meeting-5 | 01:04 | |
| *** topol has joined #openstack-meeting-5 | 01:12 | |
| *** ricolin_ has joined #openstack-meeting-5 | 01:18 | |
| *** ricolin has quit IRC | 01:20 | |
| *** topol has quit IRC | 02:33 | |
| *** topol has joined #openstack-meeting-5 | 03:05 | |
| *** topol has quit IRC | 03:10 | |
| *** Rockyg has quit IRC | 04:01 | |
| *** rarcea has joined #openstack-meeting-5 | 05:59 | |
| *** topol has joined #openstack-meeting-5 | 06:46 | |
| *** topol has quit IRC | 06:50 | |
| *** ralonsoh has joined #openstack-meeting-5 | 06:51 | |
| *** matrohon_ has joined #openstack-meeting-5 | 06:51 | |
| *** ricolin_ has quit IRC | 07:57 | |
| *** ricolin has joined #openstack-meeting-5 | 07:58 | |
| *** racedo has joined #openstack-meeting-5 | 08:01 | |
| *** ricolin_ has joined #openstack-meeting-5 | 08:04 | |
| *** ricolin has quit IRC | 08:04 | |
| *** ricolin__ has joined #openstack-meeting-5 | 08:06 | |
| *** HelenYao has quit IRC | 08:07 | |
| *** ricolin_ has quit IRC | 08:09 | |
| *** ricolin_ has joined #openstack-meeting-5 | 08:15 | |
| *** ricolin__ has quit IRC | 08:18 | |
| *** aarefiev_afk is now known as aarefiev | 08:29 | |
| *** ralonsoh_ has joined #openstack-meeting-5 | 08:36 | |
| *** ralonsoh_ has quit IRC | 08:36 | |
| *** ralonsoh_ has joined #openstack-meeting-5 | 08:37 | |
| *** ralonsoh has quit IRC | 08:39 | |
| *** HelenYao has joined #openstack-meeting-5 | 09:19 | |
| *** ramishra has left #openstack-meeting-5 | 09:32 | |
| *** topol has joined #openstack-meeting-5 | 10:08 | |
| *** topol has quit IRC | 10:13 | |
| *** ricolin_ has quit IRC | 10:56 | |
| *** ralonsoh__ has joined #openstack-meeting-5 | 10:57 | |
| *** ralonsoh_ has quit IRC | 11:01 | |
| *** markvoelker has quit IRC | 11:06 | |
| *** markvoelker has joined #openstack-meeting-5 | 11:06 | |
| *** markvoelker has quit IRC | 11:11 | |
| *** rarcea has quit IRC | 11:11 | |
| *** topol has joined #openstack-meeting-5 | 11:16 | |
| *** benj_ has quit IRC | 12:00 | |
| *** zenirc369 has joined #openstack-meeting-5 | 12:19 | |
| *** benj_ has joined #openstack-meeting-5 | 12:32 | |
| *** markvoelker has joined #openstack-meeting-5 | 12:39 | |
| *** zenirc369 has quit IRC | 12:55 | |
| *** topol has quit IRC | 14:04 | |
| *** ricolin has joined #openstack-meeting-5 | 14:10 | |
| *** topol has joined #openstack-meeting-5 | 14:46 | |
| *** aarefiev is now known as aarefiev_afk | 15:01 | |
| *** zenirc369 has joined #openstack-meeting-5 | 15:07 | |
| *** phuongnh has joined #openstack-meeting-5 | 15:54 | |
| *** hshiina has joined #openstack-meeting-5 | 15:55 | |
| *** mjturek has joined #openstack-meeting-5 | 16:00 | |
| joanna | #startmeeting ironic_bfv | 16:02 |
|---|---|---|
| openstack | Meeting started Thu Apr 20 16:02:12 2017 UTC and is due to finish in 60 minutes. The chair is joanna. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:02 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:02 |
| *** openstack changes topic to " (Meeting topic: ironic_bfv)" | 16:02 | |
| openstack | The meeting name has been set to 'ironic_bfv' | 16:02 |
| joanna | morning! I am sorry for the late start :) | 16:02 |
| mjturek | o/ | 16:03 |
| hshiina | o/ | 16:03 |
| joanna | #topic Announcements/Reminders | 16:03 |
| *** openstack changes topic to "Announcements/Reminders (Meeting topic: ironic_bfv)" | 16:03 | |
| joanna | Does anyone have any announcements? | 16:04 |
| mjturek | I updated the cinder driver patch yesterday, but would like to discuss the comments later on | 16:04 |
| mjturek | There are a couple I didn't address | 16:05 |
| joanna | mjturek: great! I see that in the agenda - will it be fine to discuss in Discussion part? | 16:05 |
| mjturek | joanna: totally | 16:05 |
| joanna | great :) | 16:05 |
| joanna | moving on | 16:05 |
| joanna | #topic Current Status | 16:05 |
| *** openstack changes topic to "Current Status (Meeting topic: ironic_bfv)" | 16:05 | |
| joanna | follow up patch for common code got merged :) | 16:05 |
| hshiina | great! | 16:06 |
| mjturek | \o/ | 16:06 |
| *** zenirc369 has quit IRC | 16:07 | |
| joanna | From what I see in Etherpad, that was the only merged patch since last meeting, other patches are WIP and have new review comments | 16:08 |
| joanna | mjturek: thank you for taking care of the driver patch! | 16:09 |
| mjturek | joanna: np it's been really interesting | 16:09 |
| joanna | mjturek: awesome! :) | 16:09 |
| joanna | shall we move to Planning? | 16:09 |
| mjturek | +1 | 16:09 |
| joanna | #topic Planning/Priorities | 16:10 |
| hshiina | shall we update other patches to solve conflicts? | 16:10 |
| *** openstack changes topic to "Planning/Priorities (Meeting topic: ironic_bfv)" | 16:10 | |
| joanna | I think that driver patch should stay a priority since it's a direct dependency of the merged patches | 16:10 |
| mjturek | agreed | 16:11 |
| joanna | We can think about additional patch to put to weekly pirority list on Monday to accelerate | 16:11 |
| joanna | how about https://review.openstack.org/#/c/406290 ? | 16:12 |
| mjturek | joanna: I think there's going to need to be a db patch for getting volume target from volume id (I'd like to handle this). It'll probably be needed to get the driver patch merged | 16:12 |
| mjturek | but I'm fine with 406290 | 16:13 |
| hshiina | i agree, let's rebase and add it to list | 16:14 |
| joanna | mjturek: If you plan to update the wiring patch, you can rebase it on top of your DB reading change, so it won't get lost | 16:14 |
| mjturek | surely | 16:14 |
| joanna | mjturek: when the read volume target is ready it can be added to priority list instead. The point is to get reviews as fast as possible :) | 16:15 |
| joanna | mjturek, hshiina: great! | 16:15 |
| mjturek | ahhh understood joanna | 16:15 |
| joanna | #info Add https://review.openstack.org/#/c/406290 to weekly priority list | 16:15 |
| joanna | should we move to Discussion? | 16:16 |
| mjturek | sure! | 16:17 |
| hshiina | yes | 16:17 |
| joanna | #topic Discussion | 16:17 |
| *** openstack changes topic to "Discussion (Meeting topic: ironic_bfv)" | 16:17 | |
| mjturek | joanna: hshiina: will be referring to comments here https://review.openstack.org/#/c/366197/39/ironic/drivers/modules/storage/cinder.py | 16:17 |
| *** ricolin has quit IRC | 16:17 | |
| joanna | mjturek: do you want to do that one by one? | 16:17 |
| mjturek | yeah please | 16:17 |
| mjturek | so the first one on line 217 | 16:18 |
| mjturek | I beleive vdrok is right. The function seems to achieve the same thing as detach_volumes | 16:18 |
| *** matrohon_ has quit IRC | 16:19 | |
| mjturek | is anyone opposed to removing the function> | 16:19 |
| mjturek | ?* | 16:19 |
| joanna | mjturek: it does it in two ways | 16:19 |
| joanna | first it tries to run with no errors allowed | 16:19 |
| joanna | then, if it fails, it logs that aborting volume attached failed on detach (that's something specfifc) | 16:20 |
| joanna | and then tries once again woth allowing errors | 16:20 |
| mjturek | is the error reporting that important though? | 16:20 |
| mjturek | that we need a new function for it? | 16:20 |
| joanna | I think the idea of retrying with allowed errors was to detect additional issues with the system | 16:21 |
| mjturek | hmmm, alright. I'll bring that up with vdrok and see what he thinks | 16:21 |
| mjturek | I'll ping you and hshiina as well to weigh in | 16:21 |
| joanna | I can imagine that if there's something wrong with cinder, so all the ops should fail, as an admin, I'd like to know that | 16:21 |
| joanna | and I think unsuccessful attach may happen even when there are no issues, but if also detach fails that's something worth looking at | 16:22 |
| mjturek | yeah I might see the value there | 16:22 |
| mjturek | right | 16:23 |
| joanna | but vdrok is right saying that it uses the functionality of detach, it's just a failure handler to add context to logs | 16:23 |
| mjturek | got it | 16:23 |
| joanna | we can be less informative, or use these contents inline | 16:23 |
| joanna | However it would be also worth for other possible usages of this function | 16:24 |
| mjturek | right right | 16:24 |
| joanna | does it help at all :)? | 16:24 |
| mjturek | yeah definitely, but I think I'll need to bring it up with vdrok | 16:24 |
| mjturek | before making a decision | 16:25 |
| joanna | sure :) | 16:25 |
| mjturek | :) | 16:25 |
| mjturek | so moving on to generate_connector comment on 376 | 16:25 |
| joanna | ln 376? | 16:25 |
| mjturek | yep! | 16:25 |
| mjturek | mariojv was asking if Cinder does this. I haven't found anything but haven't looked too much | 16:26 |
| mjturek | and I genuinely don't know the answer to 2 or 3 :) | 16:26 |
| mjturek | I would assume no to 2 | 16:26 |
| joanna | hmm | 16:26 |
| mjturek | but was wondering if either of you had insight | 16:26 |
| mjturek | if not I'll bug Julia :) | 16:26 |
| joanna | target_iqn should be in volume_target | 16:27 |
| hshiina | nova passes ip and iqn to cinder | 16:27 |
| mjturek | so she's saying that we need to translate from the connector_id to the IQN | 16:28 |
| mjturek | the connector_Id is the IP | 16:29 |
| mjturek | but by the time we hit nova we should have the IQN? | 16:30 |
| mjturek | and looking at the data structure that this returns, it looks like we'll need IQN | 16:31 |
| mjturek | I'm probably going to see if Julia has any insight | 16:31 |
| joanna | mjturek: that is a good idea | 16:32 |
| mjturek | cool cool | 16:32 |
| joanna | mjturek: from how I see it we have to pass all the connection info to nova | 16:32 |
| mjturek | ahhh | 16:32 |
| mjturek | okay so then it is probably a TODO that must be handled | 16:32 |
| joanna | however, it should already be in volume_connector | 16:32 |
| mjturek | oh | 16:33 |
| mjturek | okay cool | 16:33 |
| joanna | and the IQN can be generated from the other data contained in volume_target, so even if for any reason it's not available, it can be generated | 16:33 |
| mjturek | makes sense | 16:33 |
| joanna | (although it might be a good idea to inform that the volume_connector info is incomplete) | 16:33 |
| joanna | s/volume_target/volume_connector/, sorry :) | 16:33 |
| mjturek | right :) | 16:34 |
| mjturek | okay, makes perfect sense then | 16:34 |
| mjturek | so final comment is 409 | 16:34 |
| mjturek | I think what vdrok means here is that we may have more than one volume connector but one might be broken | 16:35 |
| mjturek | would checking len(data) be helpful here? | 16:36 |
| joanna | I see, because vailid variable is reused in the switch case | 16:36 |
| mjturek | ahhhh right | 16:37 |
| joanna | yes I think it's a good idea | 16:37 |
| joanna | :) | 16:37 |
| mjturek | cool, will do then :) | 16:37 |
| mjturek | that's all I had | 16:37 |
| joanna | great! | 16:38 |
| hshiina | regarding last issue, i don't think multi volume connectors mean multipath | 16:38 |
| joanna | hshiina: this is about that there might be both ip and iqn for the same volume? | 16:38 |
| joanna | hshiina: please take a look at comment in revision 34 | 16:39 |
| hshiina | joanna, yes | 16:40 |
| joanna | ln 409 | 16:40 |
| *** ralonsoh__ has quit IRC | 16:40 | |
| joanna | hshiina: does it answer the quesion? | 16:42 |
| *** zenirc369 has joined #openstack-meeting-5 | 16:43 | |
| hshiina | joanna, i haven't fully understood multipath. but, multipath seems more complicated | 16:45 |
| mjturek | so it sounds like it simply means that multiple paths are available to the volume. The fact that an IP and IQN are available means multiple paths are available, even if it's just for one driver | 16:46 |
| mjturek | one volume* | 16:46 |
| joanna | from what I understand what Julia is saying, there is no harm in setting multipath to true, as driver should handle that | 16:46 |
| joanna | mjturek: I think that since it's confusing, maybe it's a goos idea to add a comment there explaining why multipath is handled this way? | 16:48 |
| joanna | also, can you confirm with Julia that it's a proper way to handle multipath? | 16:48 |
| *** zenirc369 has quit IRC | 16:49 | |
| mjturek | joanna: agreed | 16:49 |
| joanna | hshiina: are you ok with that? :) | 16:49 |
| *** zenirc369 has joined #openstack-meeting-5 | 16:49 | |
| hshiina | multipath is listed in feature capabilities in the approved spce: https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/boot-from-volume-reference-drivers.html | 16:50 |
| hshiina | joanna, it's ok to confirm with Julia | 16:50 |
| joanna | hshiina: it's listed here as a potential capability - so maybe it's a good idea to have a happy scenario now, and when it's ready add better support for multipath if what we have is insufficient? | 16:52 |
| hshiina | joanna, yes | 16:53 |
| joanna | mjturek: if that will be fine with Julia, this comment may be a TODO comment for the future, then :) | 16:53 |
| joanna | cool! that was the only item, should we move to open discussion? | 16:54 |
| mjturek | sure, I'll reach out to her later and ping hshiina as well | 16:54 |
| joanna | mjturek: that's awesome! | 16:54 |
| mjturek | +1 | 16:54 |
| hshiina | mjturek, thanks | 16:54 |
| joanna | #info mjturek to follow up on multipath with hshiina and TheJulia | 16:54 |
| joanna | #topic Open Discussion | 16:54 |
| *** openstack changes topic to "Open Discussion (Meeting topic: ironic_bfv)" | 16:54 | |
| joanna | so this might be the last BFV meeting I attend. I will miss working on it! Please do not hesitate to contact me with any questions or anything :) | 16:55 |
| mjturek | joanna: :( will do | 16:56 |
| mjturek | joanna: do we need someone to facilitate the meeting> | 16:56 |
| mjturek | I'd be happy to help unless hshiina would rather do it | 16:56 |
| joanna | TheJulia should be back next week | 16:57 |
| joanna | so I think there's no such need :) | 16:57 |
| mjturek | joanna: okay great! | 16:57 |
| joanna | awesome! | 16:57 |
| joanna | so are we done? | 16:57 |
| hshiina | yes. | 16:57 |
| joanna | great! | 16:57 |
| mjturek | ttyl all | 16:57 |
| joanna | good luck & have fun! :) | 16:57 |
| hshiina | joanna, thank you for your work! | 16:58 |
| mjturek | you too joanna :) | 16:58 |
| joanna | thank you :) | 16:58 |
| joanna | #endmeeting | 16:58 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings" | 16:58 | |
| openstack | Meeting ended Thu Apr 20 16:58:05 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:58 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/ironic_bfv/2017/ironic_bfv.2017-04-20-16.02.html | 16:58 |
| *** mjturek has left #openstack-meeting-5 | 16:58 | |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/ironic_bfv/2017/ironic_bfv.2017-04-20-16.02.txt | 16:58 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/ironic_bfv/2017/ironic_bfv.2017-04-20-16.02.log.html | 16:58 |
| *** hshiina has quit IRC | 17:03 | |
| *** racedo has quit IRC | 17:13 | |
| *** phuongnh has quit IRC | 17:34 | |
| *** matrohon_ has joined #openstack-meeting-5 | 19:01 | |
| *** rarcea has joined #openstack-meeting-5 | 19:22 | |
| *** rarcea has quit IRC | 20:32 | |
| *** krtaylor has quit IRC | 21:16 | |
| *** matrohon_ has quit IRC | 21:19 | |
| *** krtaylor has joined #openstack-meeting-5 | 21:23 | |
| *** zenirc369 has quit IRC | 21:45 | |
| *** bzhao_ has joined #openstack-meeting-5 | 22:10 | |
| *** topol has quit IRC | 22:20 | |
| *** markvoelker has quit IRC | 23:39 | |
| *** topol has joined #openstack-meeting-5 | 23:40 | |
| *** topol has quit IRC | 23:55 | |
| *** topol has joined #openstack-meeting-5 | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!