| *** lukepatrick has quit IRC | 00:21 | |
| *** dixiaoli has joined #openstack-meeting-5 | 00:55 | |
| *** dixiaoli has quit IRC | 00:56 | |
| *** dixiaoli has joined #openstack-meeting-5 | 00:56 | |
| *** ramishra has quit IRC | 01:19 | |
| *** yamahata has quit IRC | 01:48 | |
| *** iyamahat has quit IRC | 01:54 | |
| *** ramishra has joined #openstack-meeting-5 | 02:30 | |
| *** lukepatrick has joined #openstack-meeting-5 | 02:32 | |
| *** ricolin has joined #openstack-meeting-5 | 02:39 | |
| *** markvoelker_ has quit IRC | 02:41 | |
| *** zhipeng has joined #openstack-meeting-5 | 02:54 | |
| *** zhipeng has quit IRC | 03:06 | |
| *** lukepatrick has quit IRC | 03:49 | |
| *** ramishra has left #openstack-meeting-5 | 04:18 | |
| *** markvoelker has joined #openstack-meeting-5 | 04:42 | |
| *** iyamahat has joined #openstack-meeting-5 | 05:10 | |
| *** iyamahat has quit IRC | 05:11 | |
| *** iyamahat has joined #openstack-meeting-5 | 05:11 | |
| *** markvoelker has quit IRC | 05:17 | |
| *** rarcea has joined #openstack-meeting-5 | 05:18 | |
| *** korzen_ has joined #openstack-meeting-5 | 05:24 | |
| *** markvoelker has joined #openstack-meeting-5 | 06:14 | |
| *** makowals has joined #openstack-meeting-5 | 06:27 | |
| *** markvoelker has quit IRC | 06:47 | |
| *** markvoelker has joined #openstack-meeting-5 | 07:44 | |
| *** TuanVu_ has joined #openstack-meeting-5 | 08:02 | |
| *** TuanVu has joined #openstack-meeting-5 | 08:03 | |
| *** Mutter has joined #openstack-meeting-5 | 08:08 | |
| *** TuanVu has quit IRC | 08:09 | |
| *** yamamoto has joined #openstack-meeting-5 | 08:10 | |
| *** Mutter has quit IRC | 08:11 | |
| *** markvoelker has quit IRC | 08:16 | |
| *** iyamahat has quit IRC | 08:29 | |
| *** markvoelker has joined #openstack-meeting-5 | 09:13 | |
| *** yamamoto has quit IRC | 09:16 | |
| *** yamamoto has joined #openstack-meeting-5 | 09:17 | |
| *** yamamoto has quit IRC | 09:27 | |
| *** yamamoto has joined #openstack-meeting-5 | 09:29 | |
| *** yamamoto has quit IRC | 09:30 | |
| *** markvoelker has quit IRC | 09:46 | |
| *** makowals has quit IRC | 10:03 | |
| *** TuanVu_ has quit IRC | 10:26 | |
| *** yamamoto has joined #openstack-meeting-5 | 10:31 | |
| *** yamamoto has quit IRC | 10:36 | |
| *** dixiaoli has quit IRC | 10:51 | |
| *** yamamoto has joined #openstack-meeting-5 | 11:33 | |
| *** yamamoto has quit IRC | 11:38 | |
| *** makowals has joined #openstack-meeting-5 | 11:43 | |
| *** markvoelker has joined #openstack-meeting-5 | 11:44 | |
| *** markvoelker has quit IRC | 12:16 | |
| *** markvoelker has joined #openstack-meeting-5 | 12:32 | |
| *** korzen_ is now known as korzen | 12:34 | |
| *** yamamoto has joined #openstack-meeting-5 | 12:34 | |
| *** yamamoto has quit IRC | 12:41 | |
| *** rarcea has quit IRC | 12:49 | |
| *** rarcea has joined #openstack-meeting-5 | 13:01 | |
| *** lukepatrick has joined #openstack-meeting-5 | 13:22 | |
| *** annp has joined #openstack-meeting-5 | 13:29 | |
| *** lukepatrick has quit IRC | 13:32 | |
| *** yamamoto has joined #openstack-meeting-5 | 13:36 | |
| *** yamamoto has quit IRC | 13:42 | |
| *** korzen has quit IRC | 13:43 | |
| *** Mutter_ has joined #openstack-meeting-5 | 13:45 | |
| *** Mutter_ is now known as TuanVu | 13:45 | |
| *** lujinluo has joined #openstack-meeting-5 | 13:54 | |
| *** ihrachys has joined #openstack-meeting-5 | 14:00 | |
| ihrachys | #startmeeting neutron_upgrades | 14:00 |
|---|---|---|
| openstack | Meeting started Thu Aug 24 14:00:43 2017 UTC and is due to finish in 60 minutes. The chair is ihrachys. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| ihrachys | lujinluo, hi | 14:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| *** openstack changes topic to " (Meeting topic: neutron_upgrades)" | 14:00 | |
| openstack | The meeting name has been set to 'neutron_upgrades' | 14:00 |
| ihrachys | manjeets, is off today | 14:00 |
| lujinluo | ihrachys: o/ | 14:00 |
| TuanVu | Hi everybody | 14:00 |
| lujinluo | i see | 14:01 |
| ihrachys | TuanVu, hey! | 14:01 |
| *** annp_ has joined #openstack-meeting-5 | 14:01 | |
| ihrachys | we have no action items from prev meeting. I think we can just run through patches up for review. | 14:01 |
| annp_ | Hi | 14:01 |
| ihrachys | annp_, hey! | 14:01 |
| TuanVu | Hi ihrachys | 14:01 |
| annp_ | Hi ihrachys. :) | 14:02 |
| ihrachys | #topic OVO patches | 14:02 |
| *** openstack changes topic to "OVO patches (Meeting topic: neutron_upgrades)" | 14:02 | |
| ihrachys | https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db | 14:02 |
| ihrachys | Floating IP: https://review.openstack.org/#/c/396351/ | 14:03 |
| lujinluo | I have a question regarding floating ip | 14:03 |
| lujinluo | i met check policy failure | 14:03 |
| lujinluo | because of the absence of tenant_id | 14:03 |
| ihrachys | where is the error? | 14:03 |
| lujinluo | e.g http://logs.openstack.org/51/396351/28/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/0e31319/console.html#_2017-08-24_09_10_47_777599 | 14:04 |
| lujinluo | It ha in API layer, as I observed | 14:04 |
| lujinluo | It is* | 14:04 |
| *** derekh has joined #openstack-meeting-5 | 14:04 | |
| *** annp has quit IRC | 14:05 | |
| ihrachys | lujinluo, we probably return a dict from plugin to api layer that doesn't have tenant_id in it | 14:05 |
| *** annp__ has joined #openstack-meeting-5 | 14:05 | |
| lujinluo | yes, but how can we mitigate that? i mean we switched from tenant_id to project_id in ovo | 14:05 |
| lujinluo | there is no longer tenant_id in floating ip ovo | 14:06 |
| ihrachys | I think we still return tenant_id (in addition to project_id) in dicts generated with .to_dict() | 14:06 |
| *** TuanVu_ has joined #openstack-meeting-5 | 14:06 | |
| lujinluo | i see. | 14:06 |
| lujinluo | i will add tenant_id to .to_dict() then | 14:06 |
| ihrachys | I think it should already be there | 14:07 |
| ihrachys | sec | 14:07 |
| lujinluo | it is possible that i deleted it, not 100% sure though | 14:07 |
| ihrachys | this is generic implementation for tenant_id field: https://github.com/openstack/neutron/blob/master/neutron/objects/base.py#L244-L247 | 14:08 |
| ihrachys | and this, I think, should add tenant_id to the dict: https://github.com/openstack/neutron/blob/master/neutron/objects/base.py#L121-L125 | 14:08 |
| lujinluo | i did not modify base.py, then they are not working as expected..? | 14:09 |
| ihrachys | for what I understand, the request that fails is to get floatingip | 14:10 |
| ihrachys | which should be get_floatingip in plugin code | 14:10 |
| ihrachys | this: https://github.com/openstack/neutron/blob/master/neutron/db/l3_db.py#L1390-L1393 | 14:11 |
| ihrachys | in your patch, you changed the type of result of _get_floatingip to an OVO object | 14:12 |
| ihrachys | (before the patch, it was a sqlalchemy model) | 14:12 |
| lujinluo | Ahh, i see. https://review.openstack.org/#/c/396351/28/neutron/db/l3_db.py@1037 i should change this line as well | 14:12 |
| ihrachys | that being said, _make_floatingip_dict should have correctly extract tenant_id: https://github.com/openstack/neutron/blob/master/neutron/db/l3_db.py#L1036 | 14:12 |
| ihrachys | lujinluo, yeah, I am not sure we implement __getitem__ for tenant_id | 14:13 |
| lujinluo | it should be floatingip['project_id']. thanks, i will double check tmr | 14:13 |
| ihrachys | cool | 14:13 |
| ihrachys | next is https://review.openstack.org/#/c/495810/ "Use Agent OVO in agents_db and test_agents_db" | 14:13 |
| ihrachys | it's pretty red | 14:14 |
| TuanVu_ | hi, we're still working on it | 14:14 |
| annp__ | I and Tuan just working on it | 14:14 |
| annp__ | we have issue with _get_dict | 14:14 |
| ihrachys | ack, we'll look closer when it's ready | 14:14 |
| ihrachys | next is https://review.openstack.org/#/c/370452/ "OVO for NetworkDhcpAgentBinding" | 14:15 |
| TuanVu_ | hi Ihrachys | 14:15 |
| TuanVu_ | could you please wait | 14:15 |
| ihrachys | TuanVu_, eh, sure. what's up? | 14:15 |
| TuanVu_ | we have one concern and hopefully you could help | 14:15 |
| TuanVu_ | yes, regarding to _get_dict | 14:16 |
| ihrachys | TuanVu_, which patch do we talk about, agent one? | 14:16 |
| TuanVu_ | https://review.openstack.org/#/c/495810/5/neutron/db/agents_db.py | 14:16 |
| TuanVu_ | yes | 14:16 |
| TuanVu_ | line 178 | 14:17 |
| TuanVu_ | for this function | 14:17 |
| TuanVu_ | conf = jsonutils.loads(json_value) | 14:17 |
| TuanVu_ | we cannot load json_value | 14:18 |
| TuanVu_ | it looks like there's problem with unicode string | 14:18 |
| ihrachys | have you checked that json_value is a legit JSON string? | 14:18 |
| *** annp has joined #openstack-meeting-5 | 14:18 | |
| TuanVu_ | therefore, there are several tests failed and we still couldn't figure out how to fix it | 14:18 |
| *** annp__ has quit IRC | 14:19 | |
| *** annp_ has quit IRC | 14:19 | |
| lujinluo | is is because in OVO, "configuraton" is DictOfMiscValuesField? | 14:19 |
| TuanVu_ | hmm, we've tried to dump it, and it looks legit | 14:20 |
| TuanVu_ | could you please clarify more, Ihra and Luo ? | 14:20 |
| ihrachys | TuanVu_, I think lujinluo is onto smth here. maybe the attribute you extract is already a dict | 14:20 |
| ihrachys | so you may not need to do .loads() | 14:20 |
| *** makowals has quit IRC | 14:20 | |
| ihrachys | have you checked its type? | 14:20 |
| TuanVu_ | what do you think, An-san? | 14:20 |
| lujinluo | https://review.openstack.org/#/c/411830/ this patch declares the type pf "configurations" | 14:21 |
| ihrachys | TuanVu_, f.e see https://review.openstack.org/#/c/495810/5/neutron/objects/agent.py@75 | 14:21 |
| annp | sorry, i just lost connection. :) | 14:21 |
| annp | let me see | 14:21 |
| *** marst has joined #openstack-meeting-5 | 14:22 | |
| TuanVu_ | thank you, Luo and Ihra, I'm also checking | 14:22 |
| annp | I will try with ihrachys's suggestion tomorrow, | 14:23 |
| annp | Please go ahead | 14:23 |
| ihrachys | ok, thanks | 14:23 |
| ihrachys | next is https://review.openstack.org/#/c/370452/ "OVO for NetworkDhcpAgentBinding" | 14:23 |
| ihrachys | I already +2d it, we need 2nd opinion to merge | 14:23 |
| ihrachys | moving on. next is https://review.openstack.org/#/c/361443/, "OVO for L3HARouter" | 14:24 |
| ihrachys | I need to repeat review for the patch, I see TuanVu_ respinned it yesterday | 14:24 |
| TuanVu_ | yes, I did | 14:24 |
| TuanVu_ | thanks for your insightful review, Ihrachys | 14:25 |
| ihrachys | I see some discussion here: https://review.openstack.org/#/c/361443/46/neutron/objects/l3_hamode.py@53 give me a second to read it | 14:25 |
| *** TuanVu has quit IRC | 14:25 | |
| TuanVu_ | ok | 14:26 |
| ihrachys | ok I see what's going on there. I think it's fine to leave it as-is. I would suggest we leave a TODO here to get back to it, but it's not a must. | 14:26 |
| ihrachys | I think it's the right thing not to try to unravel the whole stack of interdependencies in one go\ | 14:27 |
| TuanVu_ | ok then | 14:27 |
| ihrachys | next is https://review.openstack.org/#/c/429829/, "Allow Agent object to be queryable by dict's key field" | 14:27 |
| ihrachys | TuanVu_, you respinned it | 14:28 |
| ihrachys | I wonder whether it's still needed | 14:28 |
| ihrachys | the patch is quite old, not sure it applies now. do we have some code that would benefit from it? | 14:28 |
| lujinluo | i went through the unittest of agent, and it seems we do not need it anymore | 14:28 |
| TuanVu_ | yeah, I've checked that too | 14:29 |
| ihrachys | ok, then let's abandon? we can always revive if needed. | 14:29 |
| TuanVu_ | but since being a newbie, I'm not sure if we still need it | 14:29 |
| TuanVu_ | ok, no problem | 14:30 |
| TuanVu_ | I'll abandon this patch | 14:30 |
| ihrachys | thanks! | 14:30 |
| ihrachys | there are no more patches in the review queue that have new developments | 14:31 |
| ihrachys | any patch from those I haven't mentioned that you would like to discuss? | 14:31 |
| *** annp_ has joined #openstack-meeting-5 | 14:31 | |
| *** annp has quit IRC | 14:32 | |
| lujinluo | ihrachys: thanks for changing the topic of Port patch! I always forgot to do it ;) | 14:32 |
| TuanVu_ | Hi | 14:32 |
| TuanVu_ | I have one question | 14:32 |
| ihrachys | TuanVu_, shoot | 14:32 |
| TuanVu_ | about the strategy for updating patches for Agent (eg: the order of files to be updated) | 14:32 |
| ihrachys | TuanVu_, what's the question? | 14:34 |
| ihrachys | have we lost TuanVu_ ? | 14:36 |
| TuanVu_ | after working on "agents_db", I realize that when continue working on other files (eg: l3agentscheduler), there are lots of changes need to be done on agents_db | 14:36 |
| TuanVu_ | sorry, I'm trying to explain my concern in a simple way | 14:36 |
| ihrachys | TuanVu_, np, I thought that's connectivity issues | 14:36 |
| ihrachys | TuanVu_, so in general, I think it's fine to split patches as much as to simplify review / reduce their size | 14:37 |
| ihrachys | it's easier to land small patches | 14:37 |
| TuanVu_ | yes, I totally agree with that idea | 14:37 |
| ihrachys | there is no requirement that you switch all uses of a model in one go | 14:37 |
| TuanVu_ | but regarding to the order of file to be updated | 14:37 |
| *** yamamoto has joined #openstack-meeting-5 | 14:38 | |
| ihrachys | how does the order play out in this particular case? | 14:38 |
| TuanVu_ | especially for Agent OVO which is pretty big and complicated, do you have any suggestion for "the order of files to be updated" | 14:38 |
| TuanVu_ | eg: which one first, then what is the next one | 14:39 |
| TuanVu_ | yes, the order plays a pretty big deal | 14:39 |
| ihrachys | there are two files at play, agents_db and l3agentscheduler? or there are more? | 14:39 |
| TuanVu_ | well, there are lots of files need to be updated for Agent OVO (about 10, I think) | 14:40 |
| TuanVu_ | https://review.openstack.org/#/c/495810/ | 14:40 |
| TuanVu_ | after above patch, I'm about to move on to l3agentscheduler | 14:41 |
| TuanVu_ | and when working with l3agentscheduler, I'll need to update agents_db again | 14:41 |
| TuanVu_ | so that's the problem I would like to mention here | 14:42 |
| ihrachys | ok. I don't have specifics to give very specific answer, but what I would do is I would try to take the smallest bit you can tackle from one of those files [f.e. a single method], try to migrate it to OVO and see where it leads you (and do the minimal necessary change in other files to adopt to the change and pass CI without touching other code) | 14:42 |
| ihrachys | TuanVu_, oh, you mean you want to base your scheduler work on that other patch? | 14:42 |
| TuanVu_ | I mean, looks like it would be better to update agents_db at the end | 14:42 |
| ihrachys | if so, you can stack them in git | 14:42 |
| TuanVu_ | thank you, Ihar | 14:43 |
| TuanVu_ | I got your idea :) | 14:43 |
| ihrachys | TuanVu_, in the agents_db patch, if the only remaining issue is with json.loads() and it will be ready to merge, I think that's what we should concentrate on | 14:44 |
| TuanVu_ | "I would try to take the smallest bit you can tackle from one of those files [f.e. a single method], try to migrate it to OVO and see where it leads you (and do the minimal necessary change in other files to adopt to the change and pass CI without touching other code)" | 14:44 |
| ihrachys | but in the meantime, you can work on scheduler patch, just make sure you base it on the agents_db one | 14:44 |
| *** yamamoto has quit IRC | 14:44 | |
| TuanVu_ | yes, thanks for your advice | 14:45 |
| TuanVu_ | I really appreciate it :) | 14:45 |
| ihrachys | you do it with: git review -d 495810 ; <edit scheduler code>; git commit -a -m "blablabla"; git review | 14:45 |
| ihrachys | the first command (git review -d ...) will download the state of git tree with the agents_db patch on top | 14:45 |
| TuanVu_ | yeah, I got your idea | 14:45 |
| ihrachys | so when you execute the last command (git review), it will send both patches, but the first is the same, so it is not affected | 14:46 |
| ihrachys | ok, cool | 14:46 |
| ihrachys | I guess that's all we had for today unless someone has anything more to discuss | 14:46 |
| lujinluo | none from me | 14:46 |
| *** ralonsoh has joined #openstack-meeting-5 | 14:46 | |
| annp_ | me too | 14:46 |
| TuanVu_ | same here | 14:46 |
| ihrachys | TuanVu_, annp_, lujinluo thanks for all the effort | 14:47 |
| ihrachys | #endmeeting | 14:47 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings" | 14:47 | |
| openstack | Meeting ended Thu Aug 24 14:47:10 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:47 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2017/neutron_upgrades.2017-08-24-14.00.html | 14:47 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/neutron_upgrades/2017/neutron_upgrades.2017-08-24-14.00.txt | 14:47 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2017/neutron_upgrades.2017-08-24-14.00.log.html | 14:47 |
| TuanVu_ | thank you Ihar, Luo and An-san | 14:47 |
| lujinluo | ihrachys: not a problem ;) have a nice day annp_ TuanVu_ have a good rest | 14:47 |
| *** ralonsoh has quit IRC | 14:47 | |
| annp_ | Ihar, TuanVu and Lou, thanks | 14:47 |
| TuanVu_ | thank you guys | 14:47 |
| TuanVu_ | see you all later :) | 14:47 |
| *** TuanVu_ has quit IRC | 14:50 | |
| *** lujinluo has quit IRC | 14:55 | |
| *** annp_ has quit IRC | 15:06 | |
| *** lukepatrick has joined #openstack-meeting-5 | 15:16 | |
| *** yamamoto has joined #openstack-meeting-5 | 15:40 | |
| *** yamamoto has quit IRC | 15:45 | |
| *** lukepatrick has quit IRC | 15:45 | |
| *** amotoki is now known as amotoki__away | 15:47 | |
| *** lukepatrick has joined #openstack-meeting-5 | 16:22 | |
| *** gagehugo has joined #openstack-meeting-5 | 16:27 | |
| *** yamamoto has joined #openstack-meeting-5 | 16:41 | |
| *** iyamahat has joined #openstack-meeting-5 | 16:47 | |
| *** yamamoto has quit IRC | 16:47 | |
| *** yamahata has joined #openstack-meeting-5 | 16:47 | |
| *** derekh has quit IRC | 16:55 | |
| *** rarcea has quit IRC | 16:59 | |
| *** yamamoto has joined #openstack-meeting-5 | 17:43 | |
| *** yamamoto has quit IRC | 17:48 | |
| *** lukepatrick has quit IRC | 18:13 | |
| *** lukepatrick has joined #openstack-meeting-5 | 18:18 | |
| *** dixiaoli has joined #openstack-meeting-5 | 18:22 | |
| *** dixiaoli has quit IRC | 18:26 | |
| *** lukepatrick has quit IRC | 18:34 | |
| *** lukepatrick has joined #openstack-meeting-5 | 18:43 | |
| *** yamamoto has joined #openstack-meeting-5 | 18:44 | |
| *** gagehugo has left #openstack-meeting-5 | 18:49 | |
| *** yamamoto has quit IRC | 18:50 | |
| *** yamamoto has joined #openstack-meeting-5 | 19:46 | |
| *** yamamoto has quit IRC | 19:51 | |
| *** yamamoto has joined #openstack-meeting-5 | 19:51 | |
| *** lukepatrick has quit IRC | 20:03 | |
| *** lukepatrick has joined #openstack-meeting-5 | 20:14 | |
| *** iyamahat has quit IRC | 20:23 | |
| *** iyamahat has joined #openstack-meeting-5 | 20:28 | |
| *** derekh has joined #openstack-meeting-5 | 20:35 | |
| *** yamamoto has quit IRC | 20:45 | |
| *** derekh has quit IRC | 20:46 | |
| *** ricolin_ has joined #openstack-meeting-5 | 21:18 | |
| *** ricolin has quit IRC | 21:21 | |
| *** yamamoto has joined #openstack-meeting-5 | 21:46 | |
| *** yamamoto has quit IRC | 21:51 | |
| *** ihrachys_ has joined #openstack-meeting-5 | 22:04 | |
| *** ihrachys has quit IRC | 22:06 | |
| *** ihrachys_ is now known as ihrachys | 22:07 | |
| *** ihrachys has quit IRC | 22:34 | |
| *** lukepatrick has quit IRC | 22:46 | |
| *** yamamoto has joined #openstack-meeting-5 | 22:47 | |
| *** yamamoto has quit IRC | 22:53 | |
| *** marst has quit IRC | 23:05 | |
| *** yamamoto has joined #openstack-meeting-5 | 23:49 | |
| *** yamamoto has quit IRC | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!