| *** iyamahat_ has quit IRC | 00:01 | |
| *** iyamahat_ has joined #openstack-meeting-5 | 00:05 | |
| *** iyamahat_ has quit IRC | 00:06 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 00:19 | |
| *** yamamoto has quit IRC | 00:24 | |
| *** yamamoto has joined #openstack-meeting-5 | 00:27 | |
| *** yamamoto has quit IRC | 00:39 | |
| *** ricolin has joined #openstack-meeting-5 | 01:10 | |
| *** felipemonteiro has quit IRC | 01:35 | |
| *** yamamoto has joined #openstack-meeting-5 | 01:39 | |
| *** yamamoto has quit IRC | 01:47 | |
| *** markvoelker has joined #openstack-meeting-5 | 01:50 | |
| *** yamahata has joined #openstack-meeting-5 | 02:18 | |
| *** yamamoto has joined #openstack-meeting-5 | 02:19 | |
| *** markvoelker has quit IRC | 02:36 | |
| *** yamahata has quit IRC | 02:38 | |
| *** yamahata has joined #openstack-meeting-5 | 02:39 | |
| *** yamahata has quit IRC | 02:54 | |
| *** yamamoto_ has joined #openstack-meeting-5 | 03:12 | |
| *** yamamoto has quit IRC | 03:16 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 03:18 | |
| *** felipemonteiro has quit IRC | 03:57 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 04:15 | |
| *** spzala has joined #openstack-meeting-5 | 04:31 | |
| *** felipemonteiro has quit IRC | 04:39 | |
| *** tuanla____ has joined #openstack-meeting-5 | 04:41 | |
| *** spzala has quit IRC | 04:42 | |
| *** mariusv has joined #openstack-meeting-5 | 05:46 | |
| *** mariusv has quit IRC | 05:46 | |
| *** markvoelker has joined #openstack-meeting-5 | 05:47 | |
| *** markvoelker has quit IRC | 06:40 | |
| *** markvoelker has joined #openstack-meeting-5 | 06:42 | |
| *** yamamoto has joined #openstack-meeting-5 | 06:45 | |
| *** yamamoto_ has quit IRC | 06:49 | |
| *** dims_ has quit IRC | 07:21 | |
| *** dims has joined #openstack-meeting-5 | 07:25 | |
| *** markvoelker has quit IRC | 10:13 | |
| *** ricolin has quit IRC | 10:28 | |
| *** tuanla____ has quit IRC | 11:21 | |
| *** roman_g has joined #openstack-meeting-5 | 11:22 | |
| *** derekh has joined #openstack-meeting-5 | 11:25 | |
| *** yamamoto has quit IRC | 12:01 | |
| *** yamamoto has joined #openstack-meeting-5 | 12:01 | |
| *** markvoelker has joined #openstack-meeting-5 | 12:14 | |
| *** markvoelker has quit IRC | 12:48 | |
| *** haint has joined #openstack-meeting-5 | 12:48 | |
| *** krtaylor_ has quit IRC | 12:50 | |
| *** hoangcx_ has joined #openstack-meeting-5 | 13:01 | |
| *** kiennt26_ has joined #openstack-meeting-5 | 13:28 | |
| *** markvoelker has joined #openstack-meeting-5 | 13:44 | |
| *** lujinluo has joined #openstack-meeting-5 | 13:56 | |
| *** TuanVu has joined #openstack-meeting-5 | 13:56 | |
| *** annp has joined #openstack-meeting-5 | 13:58 | |
| ihrachys | #startmeeting neutron_upgrades | 14:02 |
|---|---|---|
| openstack | Meeting started Thu Jan 11 14:02:20 2018 UTC and is due to finish in 60 minutes. The chair is ihrachys. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:02 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:02 |
| *** openstack changes topic to " (Meeting topic: neutron_upgrades)" | 14:02 | |
| openstack | The meeting name has been set to 'neutron_upgrades' | 14:02 |
| lujinluo | o/ | 14:02 |
| ihrachys | hey, sorry for late start | 14:02 |
| lujinluo | not a problem at all! | 14:02 |
| ihrachys | there were no action items | 14:02 |
| ihrachys | as some of you may have noticed, gate is unstable to the point where we can't land much these days | 14:03 |
| lujinluo | yeah, portbinding patch has gone through around 10 recheck without passing zuul, LOL | 14:03 |
| TuanVu | Hi everybody :) | 14:04 |
| annp | hi | 14:04 |
| ihrachys | multiple reasons: meltdown CVE patched in infra slowed down some jobs; infra patching services triggered POST_FAILUREs and TIMEOUTs; there are duplicate jobs because while we are moving from project-config jobs to in-tree jobs for zuulv3... | 14:04 |
| *** kiennt26_ has quit IRC | 14:04 | |
| ihrachys | I don't think we will be able to land much until we at least fix gate setup for zuulv3 | 14:04 |
| *** hungpv_ has joined #openstack-meeting-5 | 14:05 | |
| lujinluo | ok, understood | 14:05 |
| ihrachys | it doesn't stop us from working on patches and reviewing them, but sets expectations properly | 14:05 |
| TuanVu | thanks for the info, Ihar | 14:05 |
| *** kiennt26_ has joined #openstack-meeting-5 | 14:05 | |
| ihrachys | oh good news - duplicate jobs are mostly gone: https://review.openstack.org/#/c/530500/ | 14:05 |
| ihrachys | so rechecks may be more effective now | 14:05 |
| annp | +1 | 14:06 |
| ihrachys | anyway... let's dive into patches | 14:06 |
| ihrachys | https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db | 14:07 |
| ihrachys | before we go through those requiring reviews, let's (re)check those with W+1 | 14:07 |
| ihrachys | ok I see both patches are rechecked | 14:07 |
| ihrachys | not sure if before or after the project-config change landed. | 14:08 |
| ihrachys | so it may need another round of rechecks :) | 14:08 |
| ihrachys | ok now top to bottom | 14:08 |
| ihrachys | first is https://review.openstack.org/521797 "Use Router OVO in external_net_db" | 14:08 |
| hungpv_ | Is there anything needs to be concerned? | 14:10 |
| ihrachys | I am looking right now | 14:10 |
| ihrachys | a minor question: https://review.openstack.org/#/c/521797/16..21/neutron/db/external_net_db.py | 14:10 |
| ihrachys | why do we need to call .all() if you iterate through it right away? | 14:10 |
| ihrachys | I think when you iterate, it will already call .all() under the hood | 14:10 |
| ihrachys | (or better, will fetch records lazily) | 14:11 |
| hungpv_ | Oh, i didn't know it | 14:11 |
| hungpv_ | I'll check again | 14:11 |
| ihrachys | I think that's what will happen. it's a minor thing, not a bother really. | 14:11 |
| hungpv_ | Ok | 14:12 |
| ihrachys | ok this is more serious: https://review.openstack.org/#/c/521797/21/neutron/objects/router.py | 14:14 |
| ihrachys | I don't think the code is correct | 14:15 |
| ihrachys | and I would say, at this point we should first fix test coverage for the code because it's clearly not covered properly if this didn't trigger an error. | 14:16 |
| ihrachys | so I am with slaweq on adding a UT | 14:16 |
| *** annp has quit IRC | 14:17 | |
| lujinluo | why is 'gw_port_id' not updatable? | 14:17 |
| *** markvoelker has quit IRC | 14:18 | |
| hungpv_ | Hmm, let's me recall | 14:18 |
| ihrachys | it's a foreign key so maybe that | 14:19 |
| hungpv_ | I'll check again tomorrow | 14:20 |
| ihrachys | though it should be able to be None I guess? | 14:20 |
| lujinluo | yes | 14:20 |
| lujinluo | nullable is true | 14:20 |
| ihrachys | good question | 14:21 |
| ihrachys | lujinluo, please leave a comment for that one there | 14:21 |
| *** annp has joined #openstack-meeting-5 | 14:21 | |
| lujinluo | done | 14:22 |
| ihrachys | ok cool | 14:22 |
| ihrachys | so clearly there is more work to do there | 14:22 |
| ihrachys | moving on | 14:22 |
| ihrachys | https://review.openstack.org/#/c/507772/ "Use Network OVO in db_base_plugin" | 14:23 |
| TuanVu | I’ve already updated the patch as your recommendation and still continue working on it | 14:23 |
| TuanVu | At this moment, I’m working on this failed unit test: | 14:23 |
| TuanVu | “neutron.tests.unit.plugins.ml2.test_plugin.TestNetworksV2.test_update_network_set_not_shared_other_tenant_returns_409” | 14:23 |
| TuanVu | It’s failing at create_port step | 14:23 |
| TuanVu | 14:24 | |
| TuanVu | It looks like we have problem with “obj_context.session.refresh” | 14:24 |
| TuanVu | I’m trying to apply the same solution from xujun’s patch set | 14:24 |
| TuanVu | https://review.openstack.org/#/c/530182/17/neutron/objects/base.py | 14:24 |
| TuanVu | 14:24 | |
| ihrachys | do you have any significant comments from previous patchsets not addressed yet? | 14:24 |
| TuanVu | But I’m not sure if it’ll work, so any suggestion is welcome | 14:24 |
| TuanVu | hmm, let me see .. | 14:25 |
| TuanVu | ok, I think all of your comments have been addressed in the latest patch | 14:26 |
| TuanVu | PS22 | 14:26 |
| TuanVu | my main concern at this moment is above failed unit test: "“neutron.tests.unit.plugins.ml2.test_plugin.TestNetworksV2.test_update_network_set_not_shared_other_tenant_returns_409” | 14:27 |
| ihrachys | am I looking at the very latest patchset? | 14:28 |
| ihrachys | 22 | 14:28 |
| ihrachys | because I see some replies that something is Done but it's the smae | 14:29 |
| ihrachys | *same | 14:29 |
| TuanVu | could you please point out which one? | 14:29 |
| ihrachys | like https://review.openstack.org/#/c/507772/19..22/neutron/plugins/ml2/plugin.py line 888 | 14:29 |
| ihrachys | or 874 same file | 14:29 |
| ihrachys | https://review.openstack.org/#/c/507772/19..22/neutron/objects/network.py line 313 seems wrong - you ripped off implementation; I think you should have it there, otherwise it won't detect existing tenants relying on a rbac entry | 14:30 |
| ihrachys | also https://review.openstack.org/#/c/507772/19..22/neutron/db/db_base_plugin_common.py line 299 | 14:30 |
| ihrachys | it says you went with all Network but the code is same | 14:30 |
| ihrachys | so I am not sure if it's latest / all comments handled. | 14:31 |
| ihrachys | the missing implementation for bound tenants is especially concerning | 14:32 |
| ihrachys | because it should have functional impact on the object | 14:32 |
| ihrachys | we can't have this merged without rbac behavior fixed for the object | 14:32 |
| TuanVu | hmm, lot's of concern, so let me answer one by one, is that ok? | 14:32 |
| TuanVu | https://review.openstack.org/#/c/507772/19..22/neutron/plugins/ml2/plugin.py line 888 | 14:33 |
| ihrachys | yeah go ahead. maybe not every one but this one and bound tenants implementation may be worth a discussion right now | 14:34 |
| ihrachys | or if you have legit answers to each, we can as well follow up in gerrit | 14:34 |
| TuanVu | somehow I missed this one, thank you for pointing that out | 14:34 |
| TuanVu | yeah, better to follow up on gerrit | 14:34 |
| TuanVu | about bound tenants implementation, I'll update it as your recommendation | 14:35 |
| TuanVu | thanks a lot, Ihar | 14:35 |
| ihrachys | ok cool | 14:35 |
| ihrachys | next in list is https://review.openstack.org/530182 "Use Router OVO in l3_db" | 14:35 |
| ihrachys | I don't think I ever checked it | 14:35 |
| ihrachys | this is probably the most controversial thing there: https://review.openstack.org/#/c/530182/17/neutron/objects/base.py | 14:36 |
| ihrachys | (refresh OVO method) | 14:36 |
| TuanVu | it looks like xujun is not online | 14:37 |
| TuanVu | is that ok? | 14:38 |
| ihrachys | though it kinda makes sense to reflect hacks we already have with sqlalchemy | 14:38 |
| ihrachys | TuanVu, yeah I think we will move on. I will leave feedback there. there is another issue with 'description' field there (that is supposed to be introduced by standard attributes logic already) | 14:39 |
| ihrachys | next is https://review.openstack.org/#/c/506037/ "Part II of Integrate Port OVO" | 14:40 |
| ihrachys | lujinluo, I assume we were waiting for port binding to land | 14:40 |
| ihrachys | which should hopefully be next days granted the gate works | 14:40 |
| lujinluo | besides that, it also needs some extra work | 14:40 |
| lujinluo | so no hurry ;) | 14:40 |
| ihrachys | oh ok. would you benefit from a review iteration? | 14:41 |
| lujinluo | no, maybe after i make it pass all the tests | 14:41 |
| ihrachys | ok good | 14:42 |
| ihrachys | there are no patches in queue that seem ready for a discussion otherwise | 14:42 |
| ihrachys | anything that we missed? (like, patches with wrong topic?) | 14:43 |
| ihrachys | I have this revert in trunk service to unbreak the way we use engine facades in scope of OVO: https://review.openstack.org/#/c/532343/ | 14:44 |
| ihrachys | that's similar to IPAllocation issue that I was talking a while back | 14:44 |
| ihrachys | ok seems like nothing | 14:46 |
| ihrachys | I walked through etherpad with remaining bits: http://etherpad.openstack.org/p/neutron-remaining-ovo and stroke through those patches that merged | 14:46 |
| lujinluo | oh thanks Ihar | 14:47 |
| ihrachys | port binding section should be mostly gone this week | 14:47 |
| TuanVu | thanks for your update, Ihar | 14:47 |
| ihrachys | there is lots of work still though | 14:48 |
| lujinluo | yeah | 14:48 |
| ihrachys | ok, anything else you want to discuss? | 14:48 |
| lujinluo | none from me | 14:48 |
| TuanVu | me either | 14:48 |
| ihrachys | ok | 14:49 |
| ihrachys | if you have cycles and have no patches on your plate, etherpad would be a good place to look for next thing | 14:49 |
| ihrachys | thanks everyone for joining | 14:49 |
| lujinluo | thanks everyone! | 14:49 |
| ihrachys | we meet next week! | 14:49 |
| ihrachys | #endmeeting | 14:49 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 14:49 | |
| openstack | Meeting ended Thu Jan 11 14:49:34 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:49 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-01-11-14.02.html | 14:49 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-01-11-14.02.txt | 14:49 |
| TuanVu | thank you guys | 14:49 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-01-11-14.02.log.html | 14:49 |
| ihrachys | have a good evening | 14:49 |
| TuanVu | see you guys next week :) | 14:49 |
| lujinluo | have a good day Ihar ;) | 14:49 |
| *** lujinluo has quit IRC | 14:50 | |
| *** zhipeng has joined #openstack-meeting-5 | 14:54 | |
| *** markvoelker has joined #openstack-meeting-5 | 15:02 | |
| *** markvoelker has quit IRC | 15:02 | |
| *** ihrachys has quit IRC | 15:05 | |
| *** ihrachys has joined #openstack-meeting-5 | 15:05 | |
| *** annp has quit IRC | 15:05 | |
| *** hoangcx_ has quit IRC | 15:12 | |
| *** cleong has joined #openstack-meeting-5 | 15:20 | |
| *** markvoelker has joined #openstack-meeting-5 | 15:24 | |
| *** TuanVu has quit IRC | 15:35 | |
| *** TuanVu has joined #openstack-meeting-5 | 15:36 | |
| *** TuanVu has quit IRC | 15:36 | |
| *** TuanVu has joined #openstack-meeting-5 | 15:36 | |
| *** TuanVu has quit IRC | 15:37 | |
| *** yamamoto has quit IRC | 15:37 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 15:37 | |
| *** TuanVu has joined #openstack-meeting-5 | 15:37 | |
| *** TuanVu has quit IRC | 15:38 | |
| *** yamamoto has joined #openstack-meeting-5 | 15:38 | |
| *** TuanVu has joined #openstack-meeting-5 | 15:38 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 15:38 | |
| *** zhipeng has quit IRC | 15:38 | |
| *** TuanVu has quit IRC | 15:38 | |
| *** TuanVu has joined #openstack-meeting-5 | 15:39 | |
| *** TuanVu has quit IRC | 15:39 | |
| *** TuanVu has joined #openstack-meeting-5 | 15:40 | |
| *** yamamoto has quit IRC | 15:43 | |
| *** felipemonteiro has quit IRC | 15:43 | |
| *** TuanVu has quit IRC | 15:45 | |
| *** kiennt26_ has quit IRC | 15:48 | |
| *** dtantsur has joined #openstack-meeting-5 | 15:58 | |
| *** derekh has quit IRC | 15:59 | |
| *** mjturek has joined #openstack-meeting-5 | 16:02 | |
| *** ricolin has joined #openstack-meeting-5 | 16:04 | |
| *** mjturek has quit IRC | 16:17 | |
| *** mjturek has joined #openstack-meeting-5 | 16:18 | |
| *** hungpv_ has quit IRC | 16:44 | |
| *** dtantsur has left #openstack-meeting-5 | 16:47 | |
| *** felipemonteiro_ has quit IRC | 16:58 | |
| *** iyamahat has joined #openstack-meeting-5 | 17:03 | |
| *** iyamahat has quit IRC | 17:11 | |
| *** mjturek has quit IRC | 17:13 | |
| *** mjturek has joined #openstack-meeting-5 | 17:14 | |
| *** roman_g has quit IRC | 17:15 | |
| *** amotoki has quit IRC | 17:24 | |
| *** ricolin has quit IRC | 17:51 | |
| *** yamamoto has joined #openstack-meeting-5 | 18:00 | |
| *** yamamoto has quit IRC | 18:04 | |
| *** iyamahat has joined #openstack-meeting-5 | 18:43 | |
| *** yamahata has joined #openstack-meeting-5 | 18:53 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 18:55 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 18:56 | |
| *** felipemonteiro has quit IRC | 19:00 | |
| *** mjturek has quit IRC | 21:00 | |
| *** mjturek has joined #openstack-meeting-5 | 21:01 | |
| *** krtaylor has joined #openstack-meeting-5 | 21:02 | |
| *** krtaylor has quit IRC | 21:03 | |
| *** krtaylor has joined #openstack-meeting-5 | 21:04 | |
| *** cleong has quit IRC | 21:33 | |
| *** markvoelker has quit IRC | 22:49 | |
| *** markvoelker has joined #openstack-meeting-5 | 22:49 | |
| *** markvoelker has quit IRC | 22:54 | |
| *** felipemonteiro_ has quit IRC | 22:55 | |
| *** markvoelker has joined #openstack-meeting-5 | 22:56 | |
| *** markvoelker has quit IRC | 22:59 | |
| *** markvoelker has joined #openstack-meeting-5 | 23:00 | |
| *** markvoelker has quit IRC | 23:05 | |
| *** mjturek has quit IRC | 23:09 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!