| *** yamamoto has joined #openstack-meeting-5 | 00:06 | |
| *** persia has joined #openstack-meeting-5 | 00:49 | |
| *** tuanla____ has joined #openstack-meeting-5 | 00:53 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 01:01 | |
| *** felipemonteiro has quit IRC | 01:04 | |
| *** tuanla____ has quit IRC | 01:15 | |
| *** tuanla____ has joined #openstack-meeting-5 | 01:15 | |
| *** jlvillal has quit IRC | 01:55 | |
| *** cargonza has quit IRC | 01:55 | |
| *** cargonza has joined #openstack-meeting-5 | 01:55 | |
| *** jlvillal has joined #openstack-meeting-5 | 01:55 | |
| *** yamahata has quit IRC | 02:42 | |
| *** iyamahat has quit IRC | 02:42 | |
| *** kiennt26 has joined #openstack-meeting-5 | 03:06 | |
| *** jayahn has quit IRC | 03:30 | |
| *** TheJulia has quit IRC | 03:30 | |
| *** beisner has quit IRC | 03:30 | |
| *** polvi has quit IRC | 03:30 | |
| *** saneax has quit IRC | 03:30 | |
| *** beisner has joined #openstack-meeting-5 | 03:31 | |
| *** polvi has joined #openstack-meeting-5 | 03:31 | |
| *** jayahn has joined #openstack-meeting-5 | 03:31 | |
| *** TheJulia has joined #openstack-meeting-5 | 03:31 | |
| *** saneax has joined #openstack-meeting-5 | 03:36 | |
| *** tuanla____ has quit IRC | 04:00 | |
| *** tuanla____ has joined #openstack-meeting-5 | 04:01 | |
| *** kiennt26 has quit IRC | 05:04 | |
| *** spzala has quit IRC | 05:48 | |
| *** spzala has joined #openstack-meeting-5 | 05:48 | |
| *** spzala has quit IRC | 05:53 | |
| *** felipemonteiro_ has quit IRC | 06:21 | |
| *** makowals has joined #openstack-meeting-5 | 06:56 | |
| *** dims has quit IRC | 07:12 | |
| *** dims has joined #openstack-meeting-5 | 07:14 | |
| *** dims has quit IRC | 07:19 | |
| *** dims has joined #openstack-meeting-5 | 07:20 | |
| *** MarkBaker has joined #openstack-meeting-5 | 07:42 | |
| *** tuanla____ has quit IRC | 07:54 | |
| *** tuanla____ has joined #openstack-meeting-5 | 08:01 | |
| *** notmyname has quit IRC | 08:13 | |
| *** notmyname has joined #openstack-meeting-5 | 08:16 | |
| *** tuanla____ has quit IRC | 08:16 | |
| *** tuanla____ has joined #openstack-meeting-5 | 08:18 | |
| *** MarkBaker has quit IRC | 08:30 | |
| *** tuanla____ has quit IRC | 08:34 | |
| *** tuanla____ has joined #openstack-meeting-5 | 08:35 | |
| *** tuanla____ has quit IRC | 08:53 | |
| *** tuanla____ has joined #openstack-meeting-5 | 08:57 | |
| *** MarkBaker has joined #openstack-meeting-5 | 09:36 | |
| *** derekh has joined #openstack-meeting-5 | 09:39 | |
| *** spzala has joined #openstack-meeting-5 | 09:50 | |
| *** spzala has quit IRC | 09:54 | |
| *** tuanla_____ has joined #openstack-meeting-5 | 10:15 | |
| *** tuanla____ has quit IRC | 10:17 | |
| *** MarkBaker has quit IRC | 10:37 | |
| *** MarkBaker has joined #openstack-meeting-5 | 10:59 | |
| *** MarkBaker has quit IRC | 11:18 | |
| *** MarkBaker has joined #openstack-meeting-5 | 11:20 | |
| *** yamamoto has quit IRC | 11:51 | |
| *** yamamoto has joined #openstack-meeting-5 | 11:55 | |
| *** tuanla____ has joined #openstack-meeting-5 | 12:00 | |
| *** tuanla_____ has quit IRC | 12:02 | |
| *** tuanla____ has quit IRC | 12:03 | |
| *** hoangcx_ has joined #openstack-meeting-5 | 12:27 | |
| *** spzala has joined #openstack-meeting-5 | 12:29 | |
| *** MarkBaker has quit IRC | 12:32 | |
| *** spzala has quit IRC | 12:33 | |
| *** MarkBaker has joined #openstack-meeting-5 | 12:46 | |
| *** yamamoto has quit IRC | 12:58 | |
| *** yamamoto has joined #openstack-meeting-5 | 13:01 | |
| *** MarkBaker has quit IRC | 13:04 | |
| *** yamamoto has quit IRC | 13:16 | |
| *** cleong has joined #openstack-meeting-5 | 13:33 | |
| *** yamamoto has joined #openstack-meeting-5 | 13:35 | |
| *** TuanVu has joined #openstack-meeting-5 | 13:51 | |
| *** lujinluo has joined #openstack-meeting-5 | 13:58 | |
| *** spzala has joined #openstack-meeting-5 | 14:00 | |
| *** ihrachys has joined #openstack-meeting-5 | 14:01 | |
| ihrachys | give me a minute and we will start | 14:01 |
|---|---|---|
| *** hungpv_ has joined #openstack-meeting-5 | 14:02 | |
| lujinluo | sure, take your time Ihar | 14:02 |
| ihrachys | #startmeeting neutron_upgrades | 14:03 |
| openstack | Meeting started Thu Jan 18 14:03:05 2018 UTC and is due to finish in 60 minutes. The chair is ihrachys. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:03 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:03 |
| *** openstack changes topic to " (Meeting topic: neutron_upgrades)" | 14:03 | |
| openstack | The meeting name has been set to 'neutron_upgrades' | 14:03 |
| ihrachys | hey! | 14:03 |
| lujinluo | o/ | 14:03 |
| hungpv_ | Hi | 14:03 |
| TuanVu | hi Ihar | 14:03 |
| TuanVu | hi Luo | 14:03 |
| ihrachys | https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db | 14:04 |
| ihrachys | before we go through patches on review, I wonder why port binding one - https://review.openstack.org/#/c/407868/ - is still not in | 14:04 |
| *** kiennt26_ has joined #openstack-meeting-5 | 14:04 | |
| *** kiennt26_ has quit IRC | 14:04 | |
| ihrachys | ok now some timeouts in grenade | 14:05 |
| lujinluo | yeah.. | 14:05 |
| ihrachys | that's kinda concerning that we can't get it in. is there maybe some bug or smth. | 14:05 |
| *** spzala has quit IRC | 14:05 | |
| lujinluo | that's what worrying me. maybe i should at lease rebase it? | 14:05 |
| ihrachys | ah no seems like most latest failures are known. the last timeout on grenade is new to me but it doesn't surprise me. | 14:05 |
| ihrachys | there is something infra is doing these days that make landing patches impossible. restarting zuul etc. | 14:06 |
| ihrachys | rebase does nothing | 14:06 |
| ihrachys | because zuul merges your tree with latest master before testing it out | 14:06 |
| ihrachys | and if it will fail to merge, it will say so | 14:06 |
| lujinluo | i see. then maybe recheck again to see if we are blessed this time? | 14:06 |
| ihrachys | so re: latest grenade failure: | 14:07 |
| ihrachys | 2018-01-18 03:48:28.179626 | primary | 2018-01-18 03:48:28.179 | Running base stack.sh | 14:07 |
| ihrachys | 2018-01-18 06:31:50.469578 | primary | /home/zuul/workspace/devstack-gate/functions.sh: line 976: 9348 Killed timeout -s 9 ${REMAINING_TIME}m bash -c "source $WORKSPACE/devstack-gate/functions.sh && $cmd" | 14:07 |
| ihrachys | so it started to deploy stack and failed right there | 14:07 |
| ihrachys | didn't even get to tests or upgrade | 14:07 |
| ihrachys | so it definitely is not about your patch | 14:08 |
| ihrachys | because it never rolled in new code | 14:08 |
| ihrachys | yeah let me recheck | 14:08 |
| lujinluo | understood. thanks! | 14:08 |
| ihrachys | but yeah that's sad | 14:08 |
| ihrachys | anyway. looking at patches up for review now. | 14:09 |
| ihrachys | https://review.openstack.org/#/c/506037/ "Part II of Integrate Port OVO" | 14:09 |
| ihrachys | I noticed you respinned it | 14:09 |
| ihrachys | is it ready for review now? | 14:09 |
| lujinluo | i just checked the failed tests. they are still related to the transition but review would be helpful atm | 14:10 |
| ihrachys | there are some failures in api tests, and traces here: http://logs.openstack.org/37/506037/15/check/neutron-tempest-plugin-api/2b646cb/logs/screen-q-svc.txt.gz?level=WARNING | 14:10 |
| ihrachys | ok I will eye ball it | 14:10 |
| lujinluo | thanks ;) | 14:10 |
| ihrachys | then we have https://review.openstack.org/#/c/507772/ "Use Network OVO in db_base_plugin" | 14:11 |
| TuanVu | The good news is: “All the functional tests have been passed” | 14:12 |
| TuanVu | We’re working on 12 remaining failed unit tests | 14:12 |
| ihrachys | yeah, I see you reduced the number of failures a lot! | 14:12 |
| TuanVu | thank you, Ihar :) | 14:12 |
| TuanVu | thanks to the great support from you and Slawek | 14:13 |
| ihrachys | drop me another email or ping me in irc when those are fixed | 14:14 |
| ihrachys | ok, next is https://review.openstack.org/#/c/521797/ "Use Router OVO in external_net_db" | 14:14 |
| TuanVu | thank you, sure | 14:15 |
| hungpv_ | Hi Ihar, I restored the previous logic and add a UT for it | 14:16 |
| ihrachys | I think it was close to completion the last time | 14:16 |
| ihrachys | I see. maybe you reverted a bit too much. for example, consolidating arguments - projects and new_project - into a single one | 14:17 |
| ihrachys | I will walk through the patch again today | 14:17 |
| hungpv_ | The problem here that I haven't figured out an effective way to blend them | 14:18 |
| hungpv_ | If possible, please leave some suggestions | 14:18 |
| ihrachys | hungpv_, isn't just having a single list of all of them and passing it to ~ query operator do the same as we do now? | 14:19 |
| ihrachys | what query does is first look for objects with project_id not in 'projects' | 14:19 |
| ihrachys | then it also filters out anything with 'new_project' | 14:20 |
| ihrachys | I don't get why we can't just filter out projects + new_project in the first step and avoid the second one | 14:20 |
| *** annp_ has joined #openstack-meeting-5 | 14:20 | |
| hoangcx_ | ihrachys: AFAIK, projects is db record and new_project is uuid. How we can consolidate them in a list? | 14:20 |
| ihrachys | no 'projects' are just list or set of strings | 14:21 |
| ihrachys | (list) | 14:21 |
| ihrachys | at least if you restore: | 14:22 |
| ihrachys | tenants_with_entries = [tenants_with_entry[0] | 14:22 |
| ihrachys | for tenants_with_entry | 14:22 |
| ihrachys | in tenants_with_entries] | 14:22 |
| ihrachys | neutron doesn't even have a model for projects in its database | 14:22 |
| hoangcx_ | https://review.openstack.org/#/c/521797/23/neutron/db/external_net_db.py | 14:23 |
| hoangcx_ | L234 in new code not return that result is not .all() | 14:23 |
| hoangcx_ | s/is not/if not | 14:24 |
| ihrachys | hoangcx_, well, do .all() (that's same as the tenants_with_entries calculation above) | 14:24 |
| hoangcx_ | ihrachys: https://review.openstack.org/#/c/521797/23/neutron/objects/router.py | 14:26 |
| ihrachys | I will have a look. I want to play with the UT you added to see if it triggers all the code we touch. | 14:26 |
| hoangcx_ | you mean L221 -L222 need a for loop above? | 14:26 |
| ihrachys | hoangcx_, no you had it in PS21 | 14:26 |
| ihrachys | https://review.openstack.org/#/c/521797/21..23/neutron/db/external_net_db.py | 14:26 |
| ihrachys | see to the left, line 236 | 14:26 |
| ihrachys | you were extracting project_id strings from query, then passing them as a list of strings into OVO method | 14:27 |
| ihrachys | which is the right way to do | 14:27 |
| hoangcx_ | ihrachys: yeah | 14:27 |
| ihrachys | currently you pass a query object there instead, which is not great for isolation of concerns between sqlalchemy and OVO layers. OVO layer shouldn't accept, or return, anything related to SQLAlchemy | 14:28 |
| ihrachys | you had it correct in PS21 | 14:28 |
| hoangcx_ | ihrachys: then in OVO method https://review.openstack.org/#/c/521797/23/neutron/objects/router.py | 14:28 |
| hoangcx_ | We need check for all item in list of consolidated projects? | 14:28 |
| ihrachys | then in OVO method, you just do lines 218-222 and you don't need lines 223-225 | 14:29 |
| ihrachys | because new_project is already in projects | 14:29 |
| hoangcx_ | the problem here is that how L222 work with that? | 14:29 |
| ihrachys | what's about 222 | 14:30 |
| ihrachys | it takes a list of project_id strings in and it filters out all db models that have any of those project_ids | 14:30 |
| ihrachys | ~ means NOT | 14:30 |
| hoangcx_ | But in original code it is not a strings | 14:31 |
| hoangcx_ | You can set a break point to see that. | 14:31 |
| hungpv_ | So we can keep that query and just add new_project to list of projects? | 14:31 |
| ihrachys | sure. because it constructs a query in a single place. but you now have two places where queries happen, and we better not pass queries across the boundary | 14:32 |
| ihrachys | yes, add new_project to the list | 14:32 |
| ihrachys | you already had it! | 14:32 |
| ihrachys | in PS21 | 14:33 |
| ihrachys | anyway, I think we should wrap up and move on. I will comment on the patch later. | 14:33 |
| hoangcx_ | ++ | 14:33 |
| ihrachys | ok next is https://review.openstack.org/#/c/530182/ "Use Router OVO in l3_db" | 14:33 |
| ihrachys | I walked through it yesterday, left some comments, most of them basically are - 'there are more occurrences of using db models in the module, some added as part of this patch, and we should expand the patch to remove them too' | 14:34 |
| lujinluo | agree | 14:35 |
| hoangcx_ | I have also looked this patch today and it seems not ready in general at the moment. | 14:35 |
| ihrachys | there are also some logical issues there | 14:35 |
| ihrachys | yeah, it needs more work | 14:35 |
| hoangcx_ | The purpose of our work it to convert current direct db query to use OVO. But the patch seems not | 14:35 |
| *** mjturek has joined #openstack-meeting-5 | 14:36 | |
| ihrachys | it did some progress but left a lot of things intact, so now it passes .db_obj around etc. Which shouldn't happen except in some specific places where we interact with existing extensions / plugins / callbacks | 14:36 |
| ihrachys | and even that should eventually change | 14:37 |
| ihrachys | ok moving on | 14:37 |
| ihrachys | https://review.openstack.org/529551 "Use Router OVO in metering_db" | 14:37 |
| ihrachys | I see this patch has a long history | 14:38 |
| ihrachys | we even +W it at some point | 14:38 |
| hoangcx_ | This patch just need re-approval | 14:38 |
| ihrachys | does it depend on some other patch? | 14:39 |
| hungpv_ | Yes, but nothing changed from +W | 14:39 |
| hungpv_ | No, it doesn't | 14:39 |
| hungpv_ | I made a mistake and now it's corrected | 14:39 |
| ihrachys | ok you just detached it | 14:39 |
| ihrachys | great | 14:40 |
| hungpv_ | Yes, I think it can be safely merged | 14:40 |
| ihrachys | ok I pushed it in gate | 14:40 |
| ihrachys | thanks! | 14:40 |
| hungpv_ | Thank you! | 14:41 |
| hoangcx_ | ++ | 14:41 |
| ihrachys | other patches in review queue seem to be not ready | 14:41 |
| ihrachys | any other patches to look through? | 14:42 |
| ihrachys | or topics to discuss? | 14:42 |
| lujinluo | none from me | 14:42 |
| hungpv_ | No for me | 14:43 |
| ihrachys | ok good. | 14:43 |
| ihrachys | we can continue in gerrit | 14:43 |
| ihrachys | thanks for joining, you can have your 17 minutes back. enjoy the evening! | 14:43 |
| ihrachys | #endmeeting | 14:44 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 14:44 | |
| openstack | Meeting ended Thu Jan 18 14:44:07 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:44 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-01-18-14.03.html | 14:44 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-01-18-14.03.txt | 14:44 |
| lujinluo | yeah, thanks everyone | 14:44 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-01-18-14.03.log.html | 14:44 |
| TuanVu | thank you guys, see you later | 14:44 |
| hoangcx_ | Have a nice day from our late night :) | 14:44 |
| hungpv_ | Thanks everyone, see u | 14:44 |
| *** lujinluo has quit IRC | 14:45 | |
| *** hungpv_ has left #openstack-meeting-5 | 14:45 | |
| *** makowals has quit IRC | 14:52 | |
| *** hoangcx_ has quit IRC | 14:53 | |
| *** makowals has joined #openstack-meeting-5 | 14:53 | |
| *** annp_ has quit IRC | 15:04 | |
| *** makowals has quit IRC | 15:12 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 15:25 | |
| *** felipemonteiro__ has joined #openstack-meeting-5 | 15:26 | |
| *** felipemonteiro__ has quit IRC | 15:30 | |
| *** felipemonteiro_ has quit IRC | 15:30 | |
| *** felipemonteiro__ has joined #openstack-meeting-5 | 15:30 | |
| *** spzala has joined #openstack-meeting-5 | 15:32 | |
| *** makowals has joined #openstack-meeting-5 | 16:08 | |
| *** yamamoto has quit IRC | 16:09 | |
| *** makowals has quit IRC | 16:12 | |
| *** yamamoto has joined #openstack-meeting-5 | 16:14 | |
| *** ricolin has quit IRC | 16:26 | |
| *** yamamoto has quit IRC | 16:27 | |
| *** felipemonteiro__ has quit IRC | 16:29 | |
| *** TuanVu has quit IRC | 16:33 | |
| *** yamamoto has joined #openstack-meeting-5 | 16:39 | |
| *** yamamoto has quit IRC | 16:44 | |
| *** yamamoto has joined #openstack-meeting-5 | 16:49 | |
| *** yamamoto has quit IRC | 16:49 | |
| *** TuanVu has joined #openstack-meeting-5 | 16:56 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 17:21 | |
| *** TuanVu has quit IRC | 17:39 | |
| *** yamahata has joined #openstack-meeting-5 | 17:40 | |
| *** yamamoto has joined #openstack-meeting-5 | 17:50 | |
| *** yamamoto has quit IRC | 18:00 | |
| *** derekh has quit IRC | 18:00 | |
| *** iyamahat has joined #openstack-meeting-5 | 18:02 | |
| *** iyamahat has quit IRC | 19:11 | |
| *** yamahata has quit IRC | 19:11 | |
| *** iyamahat has joined #openstack-meeting-5 | 19:29 | |
| *** yamahata has joined #openstack-meeting-5 | 19:48 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 20:18 | |
| *** felipemonteiro has quit IRC | 20:21 | |
| *** jlvillal has quit IRC | 20:31 | |
| *** jlvillal has joined #openstack-meeting-5 | 20:31 | |
| *** mjturek has quit IRC | 21:14 | |
| *** mjturek has joined #openstack-meeting-5 | 21:21 | |
| *** mjturek has quit IRC | 21:32 | |
| *** mjturek has joined #openstack-meeting-5 | 21:34 | |
| *** cleong has quit IRC | 21:37 | |
| *** ihrachys has quit IRC | 21:54 | |
| *** makowals has joined #openstack-meeting-5 | 22:15 | |
| *** felipemonteiro_ has quit IRC | 23:05 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!