Thursday, 2018-03-22

*** felipemonteiro__ has joined #openstack-meeting-500:07
*** mjturek has quit IRC00:07
*** felipemonteiro__ has quit IRC00:40
*** yamamoto has joined #openstack-meeting-500:52
*** yamamoto has quit IRC00:57
*** yamamoto has joined #openstack-meeting-501:53
*** yamamoto has quit IRC01:59
*** seungkyua has joined #openstack-meeting-502:22
*** seungkyua has quit IRC02:26
*** yamamoto has joined #openstack-meeting-502:37
*** yamamoto has quit IRC02:46
*** ricolin has joined #openstack-meeting-502:55
*** yamamoto has joined #openstack-meeting-502:56
*** tuanla____ has joined #openstack-meeting-503:55
*** persia has quit IRC04:13
*** persia has joined #openstack-meeting-504:14
*** iyamahat has quit IRC04:27
*** felipemonteiro__ has joined #openstack-meeting-504:45
*** felipemonteiro__ has quit IRC04:57
*** radeks_ has joined #openstack-meeting-506:12
*** radeks__ has joined #openstack-meeting-506:13
*** iyamahat has joined #openstack-meeting-506:15
*** radeks_ has quit IRC06:17
*** iyamahat has quit IRC06:46
*** iyamahat has joined #openstack-meeting-506:46
*** iyamahat has quit IRC07:19
*** slaweq has quit IRC07:25
*** slaweq has joined #openstack-meeting-507:26
*** hungpv_ has joined #openstack-meeting-507:29
*** markvoelker has quit IRC07:35
*** shananigans has quit IRC08:05
*** diman has joined #openstack-meeting-508:06
*** shananigans has joined #openstack-meeting-508:09
*** tuanla____ has quit IRC08:25
*** tuanla____ has joined #openstack-meeting-508:26
*** markvoelker has joined #openstack-meeting-508:34
*** tuanla____ has quit IRC08:46
*** tuanla____ has joined #openstack-meeting-508:47
*** diman has quit IRC09:18
*** hungpv_ has quit IRC09:35
*** diman has joined #openstack-meeting-509:50
*** ricolin has quit IRC10:26
*** derekh has joined #openstack-meeting-510:33
*** diman has quit IRC10:34
*** korzen has quit IRC11:49
*** MarkBaker has quit IRC11:52
*** korzen has joined #openstack-meeting-511:54
*** markvoelker has quit IRC12:34
*** markvoelker has joined #openstack-meeting-512:34
*** diman has joined #openstack-meeting-512:37
*** diman has quit IRC12:41
*** hoangcx_ has joined #openstack-meeting-512:45
*** korzen has quit IRC12:50
*** korzen has joined #openstack-meeting-512:54
*** yamamoto has quit IRC12:54
*** yamamoto has joined #openstack-meeting-513:21
*** diman has joined #openstack-meeting-513:42
*** diman has quit IRC13:47
*** lujinluo has joined #openstack-meeting-513:52
*** yamamoto has quit IRC13:53
*** hungpv has joined #openstack-meeting-513:53
*** felipemonteiro__ has joined #openstack-meeting-513:55
*** mlavalle has joined #openstack-meeting-513:56
*** mjturek has joined #openstack-meeting-514:00
*** ihrachys has joined #openstack-meeting-514:00
ihrachys#startmeeting neutron_upgrades14:01
openstackMeeting started Thu Mar 22 14:01:11 2018 UTC and is due to finish in 60 minutes.  The chair is ihrachys. Information about MeetBot at http://wiki.debian.org/MeetBot.14:01
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:01
*** openstack changes topic to " (Meeting topic: neutron_upgrades)"14:01
openstackThe meeting name has been set to 'neutron_upgrades'14:01
mlavalleo/14:01
lujinluoo/14:01
*** TuanVu has joined #openstack-meeting-514:01
ihrachyshey mlavalle lujinluo thanks for joining14:01
mlavallehi lujinluo. Nice to see you!14:01
ihrachysTuanVu, o/14:01
TuanVuHi Ihar :)14:01
lujinluomlavalle: hi! nice to see you here!14:01
TuanVuHi Luo14:02
mlavallehi TuanVu14:02
TuanVuHi mlavalle14:02
hungpvhello14:02
mlavallehi hungpv14:03
ihrachyswe have the usual technical stuff to discuss today + one organizational topic. I suggest we don't hold the latter and discuss it straight away14:03
ihrachys#topic Chair14:03
*** openstack changes topic to "Chair (Meeting topic: neutron_upgrades)"14:03
*** felipemonteiro_ has joined #openstack-meeting-514:03
*** diman has joined #openstack-meeting-514:04
*** tuanla____ has quit IRC14:04
ihrachysI may no longer be able to spend much time on Neutron in the near future (think month or so)14:04
ihrachysbecause I am moving to another project (out of realm of OpenStack)14:05
lujinluo:( soooo sad to hear that14:05
*** annp_ has joined #openstack-meeting-514:05
ihrachysthat's not going to happen overnight or tomorrow, but that's going to happen14:05
* mlavalle said the same. still in shock14:05
ihrachysI am sorry for letting you down14:06
TuanVuwell, not happy to hear that14:06
hungpv:( so sad14:06
ihrachysanyway, we need to set everything correctly so that there is no disruption in what we are working on14:06
TuanVuI really appreciate your great help so far, Ihar. Not only for me but also for the whole project and other members14:06
mlavalleihrachys: you never let us down. it's just that we love you in Neutron, so we don't want to see you go. But we undrstand it is good for you14:06
lujinluo++14:07
mlavalleMake us proud in your next project!14:07
ihrachysand first obvious question is, assuming I no longer am able to pay much time to the project, we need to pass some batons I carried till now to responsible folks14:07
ihrachysI already discussed a bunch of 'batons' with mlavalle several days ago14:07
*** felipemonteiro__ has quit IRC14:07
ihrachysone baton we don't have anyone committed to yet is leading this group / chairing the meeting14:08
*** yamamoto has joined #openstack-meeting-514:08
*** diman has quit IRC14:08
ihrachysand if it fits your plans lujinluo I would like to ask you to take over the role since you are probably the most involved and experienced person in this group. what do you think?14:09
mlavalle++14:09
TuanVu++14:10
ihrachysagain, I am not going away over night, and I am here to help you with whatever you need in next month or so.14:10
mlavalleand I will lend a hand whenever you think it is necssary14:10
lujinluoI see. I'd love to step up and it would be really appreciated if I could get some necessary help from mlavalle or ihrachys when needed14:11
mlavalleThis team is very importnt to Neutron so we want to keep it in good hands14:11
lujinluothanks for trusting me. i am surprised (in a good way)14:11
ihrachysthe good news is that I am a terrible leader anyhow, so it should be easy peasy for you to do x10 better. :)14:11
lujinluoLOL, no way. You are a wonderful leader and helpful reviewer ihrachys14:12
mlavalle++14:12
ihrachyslujinluo, great! I will propose the necessary changes for irc meetings repo to have you a co-chair, and we can discuss when you feel comfortable to take it over.14:13
lujinluounderstood.14:13
*** yamamoto has quit IRC14:13
ihrachysbtw with me eventually gone, it could also make sense to move the meeting to some better time for Asia since everyone else is there. that will be your decision to make of course.14:14
mlavalleAbsolutely14:15
ihrachyslujinluo, thanks for stepping in, I really appreciate (I am sure mlavalle does too)14:15
mlavalleof course I am delighted that you are stepping up to the plate14:15
TuanVuI believe Luo will be a great leader :)14:15
lujinluoagain, I am really surprised that you choose to believe in me. I feel like more motivated for work tmr, LOL14:16
mlavalle:-)14:16
ihrachysyes. another thing related to me stepping down at some point is that the group will loose the only focused core developer with ability to merge. mlavalle will need to look closer at what can be done with it. it may be giving coreship to someone in this group, or assigning someone from outside the group to support the effort.14:17
ihrachyslujinluo, I am surprised you are surprised but ok!14:17
mlavalleI will keep a close eye on reviews and I will help to develop cores in this area14:17
lujinluoyes. and we should probably shout out to slawek more often14:18
lujinluo;)14:18
ihrachysyeah that could work14:19
ihrachysok enough of this topic, let's talk code now :)14:19
mlavalleyeah!14:19
ihrachys#topic OVO14:19
*** openstack changes topic to "OVO (Meeting topic: neutron_upgrades)"14:20
ihrachysI guess the first thing to discuss should be https://review.openstack.org/#/c/553617/ since it was blocking a bunch of patches14:20
ihrachysit's "objects: automatically detect whether engine facade is used"14:20
TuanVuyes14:20
ihrachysthat would allow objects to use the correct way to nest subtransactions depending on runtime context14:21
lujinluowe got new comments from Michael14:21
ihrachyswe may want to have it moved to autonested_transaction at some point to broaden the scope to outside OVO since it seems like a good approach to stop carrying about the new and old ways of nesting, not just for OVO.14:22
mlavallethat's a good point14:23
lujinluoyeah14:23
ihrachysyeah I see Michael's comments, posted just now14:23
*** yamamoto has joined #openstack-meeting-514:24
ihrachysI will need to dive in but looks like he is not happy about it in general. which means I will need to rework it. One thing he noticed there is that refresh() doesn't really refresh relationships. which is very surprising to me. (I am sure this detach code always assumed it.)14:25
ihrachysseems like there is more work to do there.14:25
mlavalleit did well with zuul, though14:26
ihrachysyeah that's a good part. but maybe we overcomplicate things there with the whole refresh / expunge thingy14:27
ihrachysI may need to talk to Michael about why we (think we) need the code14:27
mlavalleI am going to rebase https://review.openstack.org/#/c/545501/ on top of it to see what happens14:28
*** yamamoto has quit IRC14:28
ihrachysmlavalle, yeah I guess it's worth experimenting like that. the general idea of the patch will stand, it's just that maybe we will need to rework sqlalchemy specifics.14:29
mlavalleyeap14:29
lujinluoagree14:29
ihrachysok I will spend some time on understanding what Michael feels bad about there :)14:31
ihrachyslet's now move to pure OVO patches14:31
ihrachyshttps://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db14:31
ihrachyshttps://review.openstack.org/507772 "Use Network OVO in db_base_plugin"14:31
TuanVuI'm still working on the answers for your concerns14:32
ihrachysI believe TuanVu had some issues with the same detach code there. I tried to rebase the patch on top of mine and it seemed to have passed the previously failing test case.14:32
TuanVuwao, really?14:33
ihrachysso probably the test case TuanVu was most concerned about would be ok with the fix14:33
TuanVuthat's awesome!14:33
TuanVuthank you so much, Ihar :)14:33
lujinluogood to hear that. TuanVu seems to be struggling with the detach codes for a long time14:33
ihrachysTuanVu, yeah, I dropped you an email 15 minutes before the meeting14:33
TuanVuthank you Ihar, I'm not at work at the moment, so I cannot check that email right now14:34
*** MarkBaker has joined #openstack-meeting-514:34
ihrachysnp14:34
TuanVuhowever, I have a question14:34
ihrachysshoot14:34
TuanVuhttps://review.openstack.org/#/c/507772/39/neutron/objects/base.py@32014:35
ihrachyswait. I now realize that I may have tested with the exception handler. sec.14:36
ihrachyseh sorry TuanVu I am dumb, I haven't checked that the handler was still there. it still fails.14:37
TuanVuok, and one more note: the test (queries constant) was modified in my last patch set14:37
ihrachysnow take back all the praise and thanks you gave me14:37
TuanVuhaha, no problem, Ihar14:37
ihrachysright, you are talking about https://review.openstack.org/#/c/507772/39/neutron/tests/unit/db/test_db_base_plugin_v2.py14:37
TuanVuno way I'm gonna take them back :))14:37
TuanVuyes14:38
TuanVuI've already sent you the explanation in my last email14:38
*** yamamoto has joined #openstack-meeting-514:39
TuanVuI've tried to remove the exception, and also tried to make sure new facade is being used14:39
TuanVuhowever, there's still error:14:39
TuanVuInvalidRequestError: Instance '<Network at 0x7f9654402f90>' is not persistent within this Session14:39
ihrachysyeah I now see my fix doesn't make a dent there :-x14:40
TuanVumaybe I'm not doing it correctly, I'm not sure :-?14:41
TuanVubut as far as I understand, it's just14:41
TuanVu- Network to "new_facade = True"14:41
TuanVu- db_api.autonested_transaction(context.session): => cls.db_context_reader(context):14:41
TuanVuthat's all, am I right?14:41
ihrachysyes that would work. with my patch merged it would not require any action on your side at all since OVO object would be aware of execution context (which way to open nested subtransaction was used above it)14:42
ihrachysI now understand that you still have this issue even with the patch. I will consider your use case when working on the next patch set.14:43
TuanVuhowever, as you've tested (rebased my patch on your patch), it's still not working, right?14:43
*** yamamoto has quit IRC14:43
mlavalleyeah, it's good input to Ihar's patch14:43
ihrachysyeah the patch is clearly not ready and I will work on it today. I am hopeful Michael will have more to say when I explain him how we got there.14:44
TuanVuah, I got it!14:44
TuanVuthank you in advance, Ihar :)14:45
TuanVuI really appreciate it14:45
*** iyamahat has joined #openstack-meeting-514:45
ihrachysas for number of queries test change, I would still like us to understand better what triggers additional queries.14:46
TuanVuyeah, I'll continue to dig deeper14:46
*** yamamoto has joined #openstack-meeting-514:46
*** yamamoto has quit IRC14:46
ihrachysI am hesitant to touch the test case, it's meant to be a sign of a mistake somewhere. I saw you mentioned external network fetch triggering the additional queries. if so, maybe we don't eagerly load a relationship for external attribute. I would need to understand it better but let's focus on facade / detach failures first.14:48
ihrachysok next patch is https://review.openstack.org/#/c/549168/ "Use Router OVO in l3_db.py"14:49
ihrachysit's all red in CI14:49
TuanVuyeah, sure14:49
ihrachysso I am not sure whether it makes sense to look at it.14:49
ihrachysI don't see any other suspects in the review queue worth discussion. (it became rather calm in terms of new patches lately while we are resolving framework issues with facade and detach...)14:50
hungpvyes, I have some issue14:51
ihrachysdoes anyone have a patch asking for discussion?14:51
ihrachyshungpv, go14:51
hungpvmaybe i'll send you an email to explain ihrachys?14:51
hungpvi'm little tired today14:52
lujinluoone update of A.I from last week. i pushed a follow-up of the new_facade UT fix https://review.openstack.org/#/c/553754/ and it is already merged (yay!)14:52
ihrachyshungpv, well yeah but maybe better to keep discussions on gerrit (if there is a patch of course)14:52
*** felipemonteiro__ has joined #openstack-meeting-514:53
TuanVucongrats, Luo :)14:53
mlavallelujinluo: it went right in :-)14:53
ihrachysTuanVu, that's actually true about emails you send me. it makes sense to have everything on gerrit, especially now that I may not have as much time for neutron in the near future.14:53
ihrachyslujinluo, oh that's great.14:54
lujinluomlavalle: yeah. slawek has been very responsive14:54
ihrachysheh. slaweq is an unsung hero of neutron :)14:54
*** hungpv_ has joined #openstack-meeting-514:55
TuanVu@Ihar: yeah, I intended to post on Gerrit at first, however I forgot my password and password recovery was not working14:55
TuanVuso ... I emailed to you14:55
TuanVuI'll make sure to update on gerrit first next time :)14:55
ihrachysTuanVu, no problem, I am just saying it will better to have it in public eye and for everyone to be able to chime in14:55
ihrachysok seems like we don't have anything else to discuss today14:56
mlavalle++14:56
hungpv_@ihrachys: sure, I'll keep posting on Gerrit14:56
TuanVuthank you Ihar, I got it :)14:56
mlavalleTuanVu: you are in Ho Chi Minh City, right?14:56
ihrachysthanks lujinluo for stepping in, I really appreciate. I will reach out to you in next week about our plans for passing the role14:56
TuanVuyes, I'm in HCM city timezone14:57
lujinluoihrachys: understood!14:57
*** felipemonteiro_ has quit IRC14:57
ihrachysthanks folks!14:57
mlavallehow about you lujinluo and hungpv_.... I what cities are you located?14:57
ihrachys#endmeeting14:57
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/"14:57
openstackMeeting ended Thu Mar 22 14:57:39 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)14:57
openstackMinutes:        http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-03-22-14.01.html14:57
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-03-22-14.01.txt14:57
openstackLog:            http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-03-22-14.01.log.html14:57
lujinluomlavalle: i am based in Tokyo14:58
TuanVuI and Hung are based in Hanoi14:58
lujinluomlavalle: hungpv is in HCM timezone too14:58
TuanVucongrats on your new position, Luo-san :D14:58
mlavalleI am in Austin Texas, which is US Central time14:58
lujinluoso, TuanVu and hungpv_ are UTC +7, ana I am UTC +914:59
hungpv_👍14:59
mlavallethat's UTC - 5 this time of the ye14:59
mlavalleyear14:59
*** hungpv has quit IRC14:59
mlavallecool14:59
lujinluooh right, it is summer time now14:59
lujinluook, so see you guys next week!15:01
lujinluohave a good day ihrachys and mlavalle15:01
*** hoangcx_ has quit IRC15:01
*** seungkyua has joined #openstack-meeting-515:02
mlavallelujinluo: you too. Thanks for taking up the challenge :-)15:02
TuanVuthank you guys, see you guys soon !15:02
TuanVuhave a great day ahead, mlavalle :)15:02
*** seungkyua has quit IRC15:02
hungpv_Congrats luo-san.15:02
hungpv_See you guys15:02
lujinluomlavalle: thanks for offering me the opportunity to challenge myself15:02
mlavalleTuanVu:, hungpv_, lujinluo: good night!15:03
TuanVuthank you, mlavalle15:03
*** TuanVu has quit IRC15:05
*** TuanVu has joined #openstack-meeting-515:06
mlavallelujinluo: I know remember that you mentioned in Dublin you are based in Tokyo15:07
lujinluomlavalle: Haha, yeah. I see now you matched my face and name15:08
lujinluomlavalle: it was nice talking to you today. I have to get some sleep now. good night :)15:09
mlavallegood night!15:09
*** annp_ has quit IRC15:10
*** lujinluo has quit IRC15:14
*** MarkBaker has quit IRC15:19
*** TuanVu has quit IRC15:19
*** felipemonteiro__ has quit IRC15:21
*** felipemonteiro__ has joined #openstack-meeting-515:21
*** MarkBaker has joined #openstack-meeting-515:32
*** yamamoto has joined #openstack-meeting-515:47
*** ricolin has joined #openstack-meeting-515:47
*** yamamoto has quit IRC15:53
*** mlavalle has left #openstack-meeting-516:02
*** MarkBaker has quit IRC16:04
*** felipemonteiro_ has joined #openstack-meeting-516:05
*** felipemonteiro__ has quit IRC16:09
*** diman has joined #openstack-meeting-516:10
*** MarkBaker has joined #openstack-meeting-516:16
*** yamamoto has joined #openstack-meeting-516:17
*** yamamoto has quit IRC16:22
*** yamamoto has joined #openstack-meeting-516:32
*** yamamoto has quit IRC16:36
*** iyamahat has quit IRC16:41
*** yamahata has quit IRC16:45
*** yamamoto has joined #openstack-meeting-516:47
*** yamamoto has quit IRC16:52
*** iyamahat has joined #openstack-meeting-516:57
*** mjturek has quit IRC16:58
*** mjturek has joined #openstack-meeting-516:58
*** mjturek has quit IRC17:01
*** mjturek has joined #openstack-meeting-517:01
*** yamamoto has joined #openstack-meeting-517:02
*** ricolin has quit IRC17:04
*** yamamoto has quit IRC17:06
*** diman has quit IRC17:13
*** hungpv_ has quit IRC17:14
*** yamahata has joined #openstack-meeting-517:16
*** yamamoto has joined #openstack-meeting-517:17
*** yamamoto has quit IRC17:22
*** diman has joined #openstack-meeting-517:23
*** yamamoto has joined #openstack-meeting-517:32
*** derekh has quit IRC17:35
*** yamamoto has quit IRC17:37
*** yamamoto has joined #openstack-meeting-517:47
*** yamamoto has quit IRC17:52
*** felipemonteiro has joined #openstack-meeting-517:56
*** felipemonteiro_ has quit IRC17:59
*** yamamoto has joined #openstack-meeting-518:02
*** yamamoto has quit IRC18:06
*** yamamoto has joined #openstack-meeting-518:06
*** yamamoto has quit IRC18:06
*** diman has quit IRC18:06
*** felipemonteiro has quit IRC18:42
*** felipemonteiro has joined #openstack-meeting-518:43
*** yamamoto has joined #openstack-meeting-519:06
*** diman has joined #openstack-meeting-519:11
*** yamamoto has quit IRC19:13
*** diman has quit IRC19:15
*** yamamoto has joined #openstack-meeting-520:09
*** yamamoto has quit IRC20:14
*** diman has joined #openstack-meeting-520:29
*** nkp349 has quit IRC20:33
*** mcnanci has quit IRC20:33
*** icolwell has quit IRC20:33
*** diman has quit IRC20:33
*** yamamoto has joined #openstack-meeting-521:10
*** yamamoto has quit IRC21:16
*** radeks__ has quit IRC21:16
*** radeks__ has joined #openstack-meeting-521:17
*** diman has joined #openstack-meeting-521:28
*** diman has quit IRC21:32
*** yamamoto has joined #openstack-meeting-521:55
*** ihrachys has left #openstack-meeting-522:17
*** diman has joined #openstack-meeting-522:27
*** diman has quit IRC22:32
*** felipemonteiro has quit IRC23:03
*** diman has joined #openstack-meeting-523:12
*** diman has quit IRC23:17

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!