| *** ttran00 has joined #openstack-meeting-5 | 00:28 | |
| *** zhipeng has joined #openstack-meeting-5 | 00:33 | |
| *** zhipeng has quit IRC | 00:35 | |
| *** mjturek has joined #openstack-meeting-5 | 00:39 | |
| *** mjturek has quit IRC | 00:40 | |
| *** ricolin has joined #openstack-meeting-5 | 01:51 | |
| *** yamamoto has joined #openstack-meeting-5 | 02:55 | |
| *** yamamoto has quit IRC | 05:09 | |
| *** yamamoto has joined #openstack-meeting-5 | 05:10 | |
| *** radeks_ has joined #openstack-meeting-5 | 06:27 | |
| *** hoangcx has quit IRC | 06:38 | |
| *** hoangcx has joined #openstack-meeting-5 | 06:38 | |
| *** hoangcx has quit IRC | 06:49 | |
| *** hoangcx has joined #openstack-meeting-5 | 06:49 | |
| *** yamamoto has quit IRC | 06:49 | |
| *** slaweq has quit IRC | 06:55 | |
| *** slaweq has joined #openstack-meeting-5 | 06:55 | |
| *** yamamoto has joined #openstack-meeting-5 | 06:59 | |
| *** hoangcx has quit IRC | 07:32 | |
| *** hoangcx has joined #openstack-meeting-5 | 07:32 | |
| *** derekh has joined #openstack-meeting-5 | 08:45 | |
| *** radeks has joined #openstack-meeting-5 | 09:38 | |
| *** yamamoto has quit IRC | 10:10 | |
| *** yamamoto has joined #openstack-meeting-5 | 10:17 | |
| *** njohnston has joined #openstack-meeting-5 | 11:07 | |
| *** yamamoto has quit IRC | 11:23 | |
| *** radeks has quit IRC | 11:35 | |
| *** yamamoto has joined #openstack-meeting-5 | 11:47 | |
| *** radeks has joined #openstack-meeting-5 | 11:58 | |
| *** radeks has quit IRC | 12:03 | |
| *** radeks has joined #openstack-meeting-5 | 12:21 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 12:23 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 12:27 | |
| *** felipemonteiro has quit IRC | 12:29 | |
| *** hoangcx has quit IRC | 12:56 | |
| *** hoangcx has joined #openstack-meeting-5 | 12:57 | |
| *** mjturek has joined #openstack-meeting-5 | 13:03 | |
| *** mlavalle has joined #openstack-meeting-5 | 13:52 | |
| *** lujinluo has joined #openstack-meeting-5 | 13:53 | |
| *** hongbin has joined #openstack-meeting-5 | 13:55 | |
| *** TuanVu has joined #openstack-meeting-5 | 13:55 | |
| lujinluo | #startmeeting neutron_upgrades | 14:00 |
|---|---|---|
| openstack | Meeting started Thu May 10 14:00:11 2018 UTC and is due to finish in 60 minutes. The chair is lujinluo. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| *** openstack changes topic to " (Meeting topic: neutron_upgrades)" | 14:00 | |
| openstack | The meeting name has been set to 'neutron_upgrades' | 14:00 |
| lujinluo | hello everyone! | 14:00 |
| mlavalle | o/ | 14:00 |
| TuanVu | Hi Luo | 14:00 |
| *** ihar has joined #openstack-meeting-5 | 14:00 | |
| TuanVu | Hi mlavalle | 14:00 |
| ihar | o/ | 14:00 |
| lujinluo | o/ | 14:00 |
| TuanVu | Hi Ihar | 14:01 |
| lujinluo | We do not have any action items from last meeting | 14:01 |
| * mlavalle is multitasking in two meetings today. Could be slow to respond ;-) | 14:01 | |
| lujinluo | but last week we have these two patches merged: https://review.openstack.org/#/c/553617/ and https://review.openstack.org/#/c/563736/ | 14:02 |
| *** annp_ has joined #openstack-meeting-5 | 14:02 | |
| lujinluo | Now ovo can automatically detect which engine facade to use! thanks ihar ! \o/ | 14:02 |
| ihar | no one reverted any of them right? | 14:02 |
| ihar | I may have missed :) | 14:02 |
| lujinluo | as far as i spied, no :) | 14:03 |
| TuanVu | yeah, it's great that finally Ihar's 2 patches got merged :D | 14:04 |
| lujinluo | #topic OVO | 14:04 |
| *** openstack changes topic to "OVO (Meeting topic: neutron_upgrades)" | 14:04 | |
| lujinluo | https://review.openstack.org/#/q/topic:bp/adopt-oslo-versioned-objects-for-db+(status:open) | 14:04 |
| lujinluo | https://review.openstack.org/#/c/549168/ the first one is still pretty red | 14:04 |
| *** hungpv_ has joined #openstack-meeting-5 | 14:04 | |
| lujinluo | hungpv_: do you have any updates you want to share with us about https://review.openstack.org/#/c/549168/ ? | 14:05 |
| hungpv_ | Hi, not really at this moment. I'm trying a new solution for this. | 14:06 |
| hungpv_ | Will update on Gerrit | 14:06 |
| lujinluo | ok. then next one | 14:07 |
| lujinluo | https://review.openstack.org/#/c/565773/ tag ovo | 14:07 |
| lujinluo | i went through this one this afternoon | 14:07 |
| lujinluo | it only moves db queries to ovo file | 14:07 |
| lujinluo | which is not what we eventually want | 14:08 |
| ihar | yeah as always, we want the OVO boundary to not talk in sqlalchemy-speak | 14:08 |
| lujinluo | yes, i will leave a comment to suggest him/her not to simply move db queries | 14:09 |
| ihar | that should probably be some kind of code inside base.py that would handle extra filter (tags) accordingly | 14:09 |
| ihar | for all objects that have tags | 14:09 |
| lujinluo | agree | 14:10 |
| *** yamamoto has quit IRC | 14:10 | |
| ihar | is it just me, or no one is talking? :) | 14:14 |
| njohnston | Not just you :-) | 14:14 |
| mlavalle | not just you | 14:14 |
| mlavalle | LOL | 14:14 |
| TuanVu | can we move on to the next patch? | 14:15 |
| lujinluo | not just you, sorry i was typing the comment in gerrit | 14:15 |
| TuanVu | oh, ok then :) | 14:15 |
| lujinluo | ok next two patches are in an effort to solve the constant db queries in network ovo patches | 14:15 |
| TuanVu | yeah | 14:15 |
| lujinluo | https://review.openstack.org/#/c/565358/ this one is not to fetch none listed ovo objects | 14:16 |
| TuanVu | thanks for the great help from Ihar, the problem with duplicated queries for "networksecuritybindings" and "externalnetworks" has been solved :) | 14:16 |
| lujinluo | and it then breaks portbindinglevel test, which is addressed by https://review.openstack.org/#/c/566750/ | 14:16 |
| ihar | yeah. this one has an issue with segment returned as None to agents | 14:16 |
| lujinluo | ihar: for the latter, i hard-coded segment creation in test_base.py | 14:17 |
| ihar | it doesn't really break anything. the issue with the test you mentioned is that it's not really executed | 14:17 |
| lujinluo | oh yeah | 14:17 |
| ihar | the other patch attempts to enable the test, then I can add a unit test on top that would validate (and help to fix) the None-segment issue | 14:17 |
| ihar | the only place the segment issue is popping up currently is tempest and that's not the best environment to debug | 14:18 |
| ihar | so there is more work to do in regards to the none-fields patch | 14:18 |
| ihar | and of course I don't have a lot of time to invest in the project and will get to it on Monday only. so if some can shake the patches to merge before I reach there that would be great. | 14:19 |
| *** zhipeng has joined #openstack-meeting-5 | 14:20 | |
| lujinluo | much well explained than i could, haha. | 14:20 |
| lujinluo | anyway, i wrote some ugly codes in the portbindinglevel one and will try to refactor it. Then I will help with the none-fields patch and i think it would be better if TuanVu could work on it with me too | 14:21 |
| lujinluo | since we need network ovo patch to validate the none-fields patch | 14:22 |
| TuanVu | I'll try my best :) | 14:22 |
| TuanVu | thank you in advance, Luo | 14:22 |
| ihar | lujinluo: but the test patch seems to pass zuul with your latest upload | 14:23 |
| ihar | meaning it could use some reviews? | 14:23 |
| lujinluo | ihar: yeah, but the codes are really ugly, haha | 14:23 |
| ihar | ok gotcha I will need to check | 14:24 |
| lujinluo | thanks | 14:24 |
| ihar | oh I see what you did there. yeah we need to improve it. but that's a good start | 14:25 |
| lujinluo | then TuanVu and i will see how we can revise the non-field patch. if we make any process, we will send you updates | 14:25 |
| ihar | maybe base test class need hooking mechanism to allow subclasses to do this kind of object injection into the failing test case | 14:25 |
| ihar | lujinluo: thanks! | 14:25 |
| lujinluo | :-) thank you! | 14:25 |
| lujinluo | https://review.openstack.org/#/c/507772/ next is the network ovo patch, that we have discussed a little bit | 14:26 |
| lujinluo | it is blocked by the two patches mentioned earlier | 14:26 |
| lujinluo | TuanVu: besides the constant queried issue, do you have anything else that is not clear? | 14:26 |
| TuanVu | yeah, but at least the problem with duplicated queries for "networksecuritybindings" and "externalnetworks" has been solved | 14:27 |
| TuanVu | At this moment, there's only 1 remaining failed unit test due to duplicated query for RBAC: | 14:27 |
| TuanVu | "neutron.tests.unit.objects.test_network.NetworkDbObjectTestCase.test_get_objects_queries_constant" | 14:27 |
| TuanVu | other than this failing test case, I have no other concern yet | 14:27 |
| ihar | yeah but what's the plan with rbac | 14:28 |
| TuanVu | honestly, I haven't had any plan yet | 14:28 |
| TuanVu | because I haven't figured out how to handle "shared" | 14:29 |
| ihar | there is a rbac metaclass that wraps around objects like network that should help with that | 14:30 |
| TuanVu | as you see, Ihar, duplicated query issue for RBAC is raised when _load_shared is triggered | 14:30 |
| TuanVu | thanks for your suggestion, Ihar. Could you please explain more? | 14:31 |
| ihar | right. somewhere down the _load_shared path rbac entries are fetched not from the model you already have but fetched again | 14:31 |
| ihar | I would imagine that whatever is returned from neutron/objects/db/api.py should be a model with rbac_entries pre-fetched | 14:31 |
| ihar | I don't have details about how the rbac metaclass works on me (that was a long time ago) but that's a bird eye view | 14:32 |
| ihar | the fact that you don't pass fetched model into _load_shared may be relevant | 14:33 |
| TuanVu | thanks, could you please explain more about "passing fetched model"? | 14:34 |
| TuanVu | btw, I'll check more about rbac metaclass as your suggestion | 14:34 |
| ihar | base get_object[s] always calls to neutron/objects/db/api.py that fetches the sqlalchemy model and returns it to the base class that then converts it to object fields, and also stores it as self.db_obj. the rbac entries required to determine if the network is shared or not should be already present on the said model. | 14:36 |
| ihar | the fact that you see redundant sql statements probably means that while we already have the rbac entries on the model, they are not used when calculating shared state | 14:36 |
| ihar | which suggests to me that the model is not used (or not used properly) somewhere deep in _load_shared implementation | 14:37 |
| ihar | I think it would help to first determine which exact code triggers the redundant statements | 14:37 |
| ihar | and then figure out how to rewrite it to reuse the self.db_obj model | 14:37 |
| TuanVu | yeah, I see | 14:38 |
| TuanVu | here's the code which triggers the redundant statements | 14:39 |
| TuanVu | https://review.openstack.org/#/c/507772/46/neutron/objects/network.py@289 | 14:39 |
| *** zhipeng has quit IRC | 14:39 | |
| TuanVu | based on your suggestion, I think I'll need to rewrite my _load_shared function | 14:40 |
| ihar | yeah but that's just top of the stack. | 14:40 |
| ihar | it may be that the get_shared_with_tenant needs some tweaks | 14:40 |
| TuanVu | hmm ... yeah, I'll dig deeper | 14:41 |
| lujinluo | ok | 14:43 |
| lujinluo | let's move to the next one then | 14:44 |
| lujinluo | https://review.openstack.org/#/c/544206/ port binding ovo which is by me | 14:44 |
| TuanVu | thank you very much, Ihar. Your suggestions do help a lot! | 14:44 |
| lujinluo | i promised Miguel to rebase it upon his patch, but i did not have enough time to fix all the failed UTs in my local environment | 14:45 |
| lujinluo | I will respin it hopefully before next meeting | 14:45 |
| ihar | lujinluo: you can always push a wip version :) | 14:45 |
| ihar | if nothing else for backup | 14:45 |
| lujinluo | ihar: nice suggestion. we love red anyway, \o/ | 14:46 |
| * ihar never leaves a patch on local environment. what if tomorrow a volcano errupts under my chair? | 14:46 | |
| lujinluo | well, i have to say, this could possibly happen in Japan | 14:46 |
| TuanVu | good point, Ihar, haha | 14:46 |
| ihar | hahaha | 14:46 |
| TuanVu | +1, Luo, haha | 14:46 |
| ihar | here too. maybe not volcano but I am sitting right now right above the Hayward fault. | 14:47 |
| lujinluo | ahh, a lot of earthquakes? | 14:47 |
| ihar | nah it's nothing compared to Japan | 14:48 |
| ihar | though I admit it's quite a lot for where I came from! | 14:48 |
| ihar | we had like 3 in the last year | 14:48 |
| ihar | I didn't have a single one back in Europe in my whole life | 14:48 |
| lujinluo | haha | 14:49 |
| ihar | anyhoo... :) | 14:49 |
| mlavalle | Growing up in Mexico City, you get used to 2 or 3 erathquakes every year | 14:49 |
| lujinluo | back to ovo.. | 14:49 |
| TuanVu | I feel so lucky because of living in a country without volcano or earth quake now | 14:49 |
| mlavalle | and the ocassional big one | 14:49 |
| lujinluo | ok back to earthquakes again.. | 14:50 |
| lujinluo | we have 2 - 3 like per month, i guess? | 14:50 |
| TuanVu | haha | 14:50 |
| ihar | :))) lujinluo wow. you probably don't even mind an occasional 5-6 one right? :) | 14:50 |
| *** felipemonteiro_ has quit IRC | 14:50 | |
| lujinluo | the latest national wide alert was about a volcano eruption 3 weeks ago | 14:51 |
| ihar | the price of the beatiful Japanese hills and mountains I guess | 14:52 |
| lujinluo | i think the first thing i will do tmr morning would be pushing the wip patch to gerrit | 14:52 |
| ihar | ok great. any more ovo stuff in the queue? | 14:52 |
| lujinluo | no, the rest are not touched since last week | 14:52 |
| lujinluo | #topic open discussion | 14:53 |
| *** openstack changes topic to "open discussion (Meeting topic: neutron_upgrades)" | 14:53 | |
| TuanVu | there's OVO for Segments and Service Type | 14:53 |
| TuanVu | but I'll continue working on them after OVO for Network patch | 14:53 |
| mlavalle | Just wanted to mention that IMO, https://review.openstack.org/#/c/414251 is good now for next round of reviews | 14:53 |
| lujinluo | cool, let's tackle them down one by one! | 14:54 |
| mlavalle | and I have a series of smaller (bite size) patches that depend on it https://review.openstack.org/#/q/topic:bp/live-migration-portbinding+(status:open+OR+status:merged) | 14:54 |
| ihar | mlavalle: ack | 14:54 |
| mlavalle | that series completes the implementation of multiple port binding | 14:54 |
| ihar | mlavalle: do you have tempest patches for the feature? | 14:54 |
| *** annp_ has quit IRC | 14:54 | |
| mlavalle | ihar: that's the next step | 14:55 |
| lujinluo | mlavalle: ack. | 14:55 |
| ihar | mlavalle: ok it would be nice to have these before we merge. what d'you think? | 14:56 |
| mlavalle | ihar: mhhh I would like to merge to make it easier for the NOva guys to test their code | 14:56 |
| mlavalle | otherwise we are rebasing all the time | 14:57 |
| ihar | mlavalle: ack | 14:57 |
| mlavalle | ihar: I won't forget the Tempest testing. I promise | 14:57 |
| mlavalle | it is really the very next step | 14:57 |
| ihar | ok I will review it first thing when I get time for openstack | 14:58 |
| mlavalle | :-) | 14:58 |
| lujinluo | ok! we have 2 more mins left for anyone who has anything else to share | 14:59 |
| lujinluo | if not, then we can close it for today! | 14:59 |
| mlavalle | o/ | 14:59 |
| *** mlavalle has left #openstack-meeting-5 | 14:59 | |
| lujinluo | #endmeeting | 14:59 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 14:59 | |
| openstack | Meeting ended Thu May 10 14:59:50 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:59 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-05-10-14.00.html | 14:59 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-05-10-14.00.txt | 14:59 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-05-10-14.00.log.html | 14:59 |
| lujinluo | thank you everyone. See you next week! | 15:00 |
| TuanVu | thank you, see you soon | 15:00 |
| *** TuanVu has quit IRC | 15:05 | |
| *** lujinluo has quit IRC | 15:05 | |
| *** yamamoto has joined #openstack-meeting-5 | 15:11 | |
| *** yamamoto has quit IRC | 15:19 | |
| *** hoangcx has quit IRC | 15:41 | |
| *** derekh has quit IRC | 17:00 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 17:17 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 17:20 | |
| *** felipemonteiro has quit IRC | 17:24 | |
| *** ricolin has quit IRC | 17:24 | |
| *** ianychoi_ has joined #openstack-meeting-5 | 17:32 | |
| *** ianychoi has quit IRC | 17:35 | |
| *** sshank has joined #openstack-meeting-5 | 17:42 | |
| *** hungpv_ has quit IRC | 17:44 | |
| *** sshank has quit IRC | 17:47 | |
| *** sshank has joined #openstack-meeting-5 | 17:51 | |
| *** radeks__ has joined #openstack-meeting-5 | 17:57 | |
| *** radeks_ has quit IRC | 17:58 | |
| *** radeks has quit IRC | 18:00 | |
| *** mjturek has quit IRC | 18:19 | |
| *** felipemonteiro__ has joined #openstack-meeting-5 | 18:51 | |
| *** felipemonteiro_ has quit IRC | 18:51 | |
| *** radeks__ has quit IRC | 18:58 | |
| *** sshank has quit IRC | 19:00 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 19:04 | |
| *** felipemonteiro__ has quit IRC | 19:07 | |
| *** felipemonteiro_ has quit IRC | 19:14 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 19:14 | |
| *** mjturek has joined #openstack-meeting-5 | 19:44 | |
| *** radeks__ has joined #openstack-meeting-5 | 19:56 | |
| *** felipemonteiro__ has joined #openstack-meeting-5 | 19:59 | |
| *** felipemonteiro_ has quit IRC | 20:02 | |
| *** radeks_ has joined #openstack-meeting-5 | 20:03 | |
| *** radeks__ has quit IRC | 20:06 | |
| *** radeks_ has quit IRC | 20:33 | |
| *** felipemonteiro__ has quit IRC | 21:00 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 21:02 | |
| *** slaweq has quit IRC | 21:09 | |
| *** slaweq has joined #openstack-meeting-5 | 21:10 | |
| *** felipemonteiro has quit IRC | 21:17 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 21:23 | |
| *** slaweq has quit IRC | 21:24 | |
| *** slaweq has joined #openstack-meeting-5 | 21:25 | |
| *** slaweq has quit IRC | 21:30 | |
| *** felipemonteiro has quit IRC | 21:44 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 21:46 | |
| *** slaweq has joined #openstack-meeting-5 | 22:11 | |
| *** felipemonteiro has quit IRC | 22:14 | |
| *** slaweq has quit IRC | 22:16 | |
| *** spiette has quit IRC | 22:40 | |
| *** spiette has joined #openstack-meeting-5 | 22:45 | |
| *** hongbin has quit IRC | 22:55 | |
| *** yamamoto has joined #openstack-meeting-5 | 23:37 | |
| *** yamamoto has quit IRC | 23:42 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!