Thursday, 2018-07-05

*** jgu_ has quit IRC00:01
*** jgu__ has quit IRC00:15
*** ricolin_ has joined #openstack-meeting-501:10
*** jgu_ has joined #openstack-meeting-502:44
*** jgu_ has quit IRC03:30
*** MarkBaker has quit IRC03:42
*** roman_g_ has quit IRC03:49
*** njohnston has quit IRC04:28
*** njohnston has joined #openstack-meeting-504:29
*** ianychoi has joined #openstack-meeting-505:34
*** roman_g_ has joined #openstack-meeting-506:42
*** MarkBaker has joined #openstack-meeting-507:05
*** yamamoto has quit IRC07:18
*** yamamoto has joined #openstack-meeting-507:26
*** yamamoto has quit IRC07:42
*** yamamoto has joined #openstack-meeting-508:10
*** iyamahat has joined #openstack-meeting-508:29
*** yamahata has quit IRC08:32
*** MarkBaker has quit IRC08:33
*** derekh has joined #openstack-meeting-508:36
*** iyamahat has quit IRC08:42
*** MarkBaker has joined #openstack-meeting-508:46
*** hoangcx has joined #openstack-meeting-509:35
*** spsurya_ has quit IRC09:49
*** ricolin_ has quit IRC09:57
*** ricolin has joined #openstack-meeting-509:57
*** ricolin_ has joined #openstack-meeting-509:58
*** ricolin_ has quit IRC09:58
*** radeks has joined #openstack-meeting-511:01
*** radeks has quit IRC11:05
*** radeks has joined #openstack-meeting-511:06
*** ricolin has quit IRC11:14
*** radeks has quit IRC11:39
*** radeks has joined #openstack-meeting-511:48
*** radeks has quit IRC12:37
*** radeks has joined #openstack-meeting-512:47
*** mjturek has joined #openstack-meeting-513:11
*** ricolin has joined #openstack-meeting-513:22
*** mjturek has quit IRC13:24
*** zhipeng has joined #openstack-meeting-513:48
*** jgu_ has joined #openstack-meeting-513:49
*** TuanVu has joined #openstack-meeting-513:52
*** annp has joined #openstack-meeting-513:59
njohnston#startmeeting neutron_upgrades14:01
openstackMeeting started Thu Jul  5 14:01:34 2018 UTC and is due to finish in 60 minutes.  The chair is njohnston. Information about MeetBot at http://wiki.debian.org/MeetBot.14:01
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:01
*** openstack changes topic to " (Meeting topic: neutron_upgrades)"14:01
openstackThe meeting name has been set to 'neutron_upgrades'14:01
njohnstonHello all14:01
TuanVuHi Nate :)14:02
njohnstonUnfortunately lujinluo has been called away on urgent family business.  We wish her the best!14:02
TuanVuoh, thanks for the notice, Nate14:02
njohnstonShe asked me to take care of the meeting this week and, if I remember correctly, next as well.14:03
TuanVuoh, what a bad news14:04
njohnstonThe action items from last week are both ones for her, so let's skip them for now and perhaps we can address them in due course.14:04
TuanVuhopefully she'll come back soon14:04
njohnston#topic OVO14:04
*** openstack changes topic to "OVO (Meeting topic: neutron_upgrades)"14:04
*** hungpv has joined #openstack-meeting-514:04
njohnston#link https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db14:04
njohnstonI have a few up this week, starting with14:05
njohnston#link https://review.openstack.org/57905314:05
njohnstonI need to look at the testing more clearly and figure out why tests are failing.14:06
njohnstonI will have an update on that later today14:06
TuanVuthanks14:06
njohnston#link https://review.openstack.org/57967814:06
TuanVuI've just left a comment on that one14:07
TuanVuIt'll be merged soon, I think14:07
njohnstonI saw your comment, TuanVu, and that makes me scratch my head because I put it back.  I'll do it again, the right way this time. :-)14:08
njohnstonthanks for your reviews14:08
TuanVuawesome :)14:08
njohnstonnext is one of yours14:08
njohnstonsorry, one of Van's14:08
njohnston#link https://review.openstack.org/54916814:09
njohnstonThis one has a long history14:09
njohnstonbut it seems to be failing everything except pep8 and sphinx docs14:10
hungpvyes, i've tried to reduce the failed casasse14:10
njohnstonthen you have looked at it more than I have :-)14:11
njohnstonwhat did you see?14:11
hungpvone off common problem14:11
hungpvI encountered for those UTs14:12
hungpvis something like "    router['router']['id'], KeyError: 'router'14:13
hungpvi'm still wrap my head around it14:13
hungpvcan you give a suggestion14:13
hungpvi feel that some OVO code I've converted incorrectly14:14
hungpvbut haven't figured out it14:14
njohnstonHmm, it strikes me as odd that a router would have a field called 'router'.  Why would the object be built to nest router information like that?14:14
njohnstonok, we can continue the discussion in gerrit14:15
hungpvok cool14:16
hungpvthank you nate14:16
njohnston#link https://review.openstack.org/57968914:16
njohnstonThis is one of mine; I just asked for a recheck14:17
TuanVuit looks great14:17
TuanVuthere's only 1 failed fullstack test remaining14:17
njohnstonI added a note on this to the tracking spreadsheet as well, like 62: This partially covers the needed work.  But we need to talk about db/provisioning_blocks.py, because models are being passed to functions there as arguments.14:18
TuanVuthe recheck will solve it, I think14:18
TuanVuyeah, I see14:18
njohnstonSo the method being called from test_provisioning_blocks.py is add_model_for_resource: https://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/provisioning_blocks.py#n3614:19
njohnstonthat takes a db model and maps it to a callback resource14:19
hungpvlooks very good14:20
njohnstonSo I think provisioning_blocks.py will be one of the last things converted; it is noted so in the spreadsheet (line 128 in one of lujinluo's sections)14:21
njohnstonbut I wanted to discuss it with you just to be transparent14:21
TuanVuthanks for this info, Nate14:21
njohnstonnext up is TuanVu with14:22
njohnston#link https://review.openstack.org/50777214:22
TuanVuI’ll need to spend more time on it to figure out how to build the compatibility layer14:22
TuanVuI’ll upload a new patch set soon14:22
*** jgu_ has quit IRC14:22
njohnstonDo you know what it is that vmware-nsx is using?14:23
TuanVuother than what have been mentioned by boden, I haven't covered all of them yet14:25
njohnstonI don't have anything else to add on this topic, moving on14:27
njohnston#link https://review.openstack.org/57968214:27
njohnstonThanks manjeets for the review; he suggested that I incorporate some additional model transitions I mad missed.  That is on my todo list for this week.14:28
njohnston#link https://review.openstack.org/56248914:29
njohnstonTuanVu, tell us about this14:29
TuanVuyeah14:29
TuanVuAs the discussion in last IRC meeting, in order to avoid blocking the delivery of OVO, I've moved joins to object and add corresponding TODO for it.14:30
*** jgu_ has joined #openstack-meeting-514:30
TuanVuIf you have any other suggestions, please don't hesitate to let me know.14:30
*** hungpv_ has joined #openstack-meeting-514:31
njohnstonI just +1ed it, it looks good to me14:31
*** hungpv has quit IRC14:31
TuanVuthank you, Nate14:31
*** jgu__ has joined #openstack-meeting-514:31
TuanVuso I'll apply the same solution for https://review.openstack.org/#/c/561834/14:32
njohnstonvery good14:32
njohnston#link https://review.openstack.org/56577314:33
njohnstonthat says updated 6 days ago, but I don't see what updated14:33
njohnstonhopefully lajoskatona has completed the timeboxed assignment and can return to this14:33
njohnstonI will ask for a status update in gerrit14:34
TuanVuok, that's great14:34
njohnston#link https://review.openstack.org/56183414:35
njohnstonTuanVu, tell us about this14:35
*** jgu_ has quit IRC14:35
TuanVuit's the same with Service Type patch which has just got +1 from you14:35
TuanVuabout doing "join queries"14:35
njohnstonindeed, I look forward to the new PS14:36
TuanVuyeah, I will upload it tomorrow morning14:37
njohnstonThe next few changes are from lujinluo, and are in merge conflict14:38
njohnstonso I think we should leave them until she can return14:38
TuanVuok14:38
TuanVuI agree14:38
njohnstonI did want to circle back to one change from earlier14:39
njohnstonbecause it has an issue that I am not sure how to resolve14:40
njohnston#link https://review.openstack.org/#/c/579053/ revisited14:40
njohnstonthat code is failing the unit test neutron.tests.unit.ipam.test_subnet_alloc.TestSubnetAllocation.test_subnetpool_concurrent_allocation_exception14:41
*** spiette has joined #openstack-meeting-514:42
TuanVuI see14:42
njohnstonThe code for that test is here: https://git.openstack.org/cgit/openstack/neutron/tree/neutron/tests/unit/ipam/test_subnet_alloc.py#n19014:42
njohnstonYou can see that the test has the expectation that the db model will reject the addition with an ORM error14:42
njohnstonI am not sure how to best implement that in an OVO way14:43
njohnstonDoes anyone have any thoughts?14:43
TuanVuhmm, I have no experience with this so I have no idea at this moment. I'll put it on my check list tomorrow and send you feedback if there's any14:45
TuanVuis that ok?14:45
njohnstonThat would be wonderful14:45
njohnston#topic Open Discussion14:46
*** openstack changes topic to "Open Discussion (Meeting topic: neutron_upgrades)"14:46
njohnstonDoes anyone have anything else they would like to discuss?14:46
TuanVuone question about Rolling Upgrade14:46
TuanVufor example from Queens to Rocky14:47
TuanVuis that possible without current state of OVO?14:47
TuanVusorry14:47
TuanVuI mean *is that possible with current state of OVO?*14:48
njohnstonI would not consider myself a deep expert on that yet, but I feel pretty safe in saying that it is probably not safe yet.14:49
njohnstonThere are a few central changes that are waiting on everything to be converted to OVO, and then they can be done14:50
TuanVuthank you Nate14:50
TuanVuI ask this because we're about to do some tests for this14:50
njohnstonlike line 68 on the spreadsheet in neutron/db/db_base_plugin_common.py14:50
njohnstonand the add_model_to_resource code in neutron/db/provisioning_blocks.py we discussed earlier14:51
TuanVuthanks for giving your opinion on this matter14:52
TuanVuI really appreciate it :)14:52
njohnstoni think it will be less bumpy than before, but the spreadsheet says we are only 26% done so I am afraid I can't give better news :-)14:52
njohnstonanything else?14:53
TuanVuyeah, thank you Nate14:53
*** spiette has quit IRC14:53
TuanVuthat's all from me14:54
njohnstonThanks for everything TuanVu and hungpv_, look forward to chatting with you next week.14:54
hungpv_thank you nate, sweee u14:54
TuanVusee you soon Nate14:55
TuanVu:)14:55
njohnston#endmeeting14:55
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/"14:55
openstackMeeting ended Thu Jul  5 14:55:39 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)14:55
openstackMinutes:        http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-07-05-14.01.html14:55
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-07-05-14.01.txt14:55
openstackLog:            http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-07-05-14.01.log.html14:55
*** spiette has joined #openstack-meeting-514:58
*** zhipeng has quit IRC14:59
*** MarkBaker has quit IRC15:06
*** hongbin has joined #openstack-meeting-515:08
*** MarkBaker has joined #openstack-meeting-515:21
*** hungpv_ has quit IRC15:25
*** jgu__ has quit IRC15:29
*** MarkBaker has quit IRC15:30
*** radeks has quit IRC15:35
*** MarkBaker has joined #openstack-meeting-515:43
*** TuanVu has quit IRC15:45
*** radeks has joined #openstack-meeting-515:55
*** radeks has quit IRC16:22
*** radeks has joined #openstack-meeting-516:30
*** ricolin has quit IRC16:43
*** annp has quit IRC16:44
*** iyamahat has joined #openstack-meeting-516:47
*** derekh has quit IRC17:02
*** mjturek has joined #openstack-meeting-517:12
*** iyamahat has quit IRC17:12
*** iyamahat has joined #openstack-meeting-517:26
*** yamahata has joined #openstack-meeting-517:27
*** mjturek has quit IRC18:26
*** hongbin has quit IRC18:48
*** hongbin has joined #openstack-meeting-518:48
*** jgu_ has joined #openstack-meeting-519:15
*** jgu__ has joined #openstack-meeting-519:16
*** jgu_ has quit IRC19:19
*** radeks has quit IRC19:27
*** jgu__ has quit IRC20:31
*** jgu_ has joined #openstack-meeting-520:32
*** jgu_ has quit IRC22:25
*** hongbin has quit IRC22:50
*** jgu_ has joined #openstack-meeting-523:00
*** ianychoi_ has joined #openstack-meeting-523:01
*** jgu_ has quit IRC23:03
*** jgu_ has joined #openstack-meeting-523:04
*** ianychoi has quit IRC23:04

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!