*** jgu_ has quit IRC | 00:01 | |
*** jgu__ has quit IRC | 00:15 | |
*** ricolin_ has joined #openstack-meeting-5 | 01:10 | |
*** jgu_ has joined #openstack-meeting-5 | 02:44 | |
*** jgu_ has quit IRC | 03:30 | |
*** MarkBaker has quit IRC | 03:42 | |
*** roman_g_ has quit IRC | 03:49 | |
*** njohnston has quit IRC | 04:28 | |
*** njohnston has joined #openstack-meeting-5 | 04:29 | |
*** ianychoi has joined #openstack-meeting-5 | 05:34 | |
*** roman_g_ has joined #openstack-meeting-5 | 06:42 | |
*** MarkBaker has joined #openstack-meeting-5 | 07:05 | |
*** yamamoto has quit IRC | 07:18 | |
*** yamamoto has joined #openstack-meeting-5 | 07:26 | |
*** yamamoto has quit IRC | 07:42 | |
*** yamamoto has joined #openstack-meeting-5 | 08:10 | |
*** iyamahat has joined #openstack-meeting-5 | 08:29 | |
*** yamahata has quit IRC | 08:32 | |
*** MarkBaker has quit IRC | 08:33 | |
*** derekh has joined #openstack-meeting-5 | 08:36 | |
*** iyamahat has quit IRC | 08:42 | |
*** MarkBaker has joined #openstack-meeting-5 | 08:46 | |
*** hoangcx has joined #openstack-meeting-5 | 09:35 | |
*** spsurya_ has quit IRC | 09:49 | |
*** ricolin_ has quit IRC | 09:57 | |
*** ricolin has joined #openstack-meeting-5 | 09:57 | |
*** ricolin_ has joined #openstack-meeting-5 | 09:58 | |
*** ricolin_ has quit IRC | 09:58 | |
*** radeks has joined #openstack-meeting-5 | 11:01 | |
*** radeks has quit IRC | 11:05 | |
*** radeks has joined #openstack-meeting-5 | 11:06 | |
*** ricolin has quit IRC | 11:14 | |
*** radeks has quit IRC | 11:39 | |
*** radeks has joined #openstack-meeting-5 | 11:48 | |
*** radeks has quit IRC | 12:37 | |
*** radeks has joined #openstack-meeting-5 | 12:47 | |
*** mjturek has joined #openstack-meeting-5 | 13:11 | |
*** ricolin has joined #openstack-meeting-5 | 13:22 | |
*** mjturek has quit IRC | 13:24 | |
*** zhipeng has joined #openstack-meeting-5 | 13:48 | |
*** jgu_ has joined #openstack-meeting-5 | 13:49 | |
*** TuanVu has joined #openstack-meeting-5 | 13:52 | |
*** annp has joined #openstack-meeting-5 | 13:59 | |
njohnston | #startmeeting neutron_upgrades | 14:01 |
---|---|---|
openstack | Meeting started Thu Jul 5 14:01:34 2018 UTC and is due to finish in 60 minutes. The chair is njohnston. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:01 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:01 |
*** openstack changes topic to " (Meeting topic: neutron_upgrades)" | 14:01 | |
openstack | The meeting name has been set to 'neutron_upgrades' | 14:01 |
njohnston | Hello all | 14:01 |
TuanVu | Hi Nate :) | 14:02 |
njohnston | Unfortunately lujinluo has been called away on urgent family business. We wish her the best! | 14:02 |
TuanVu | oh, thanks for the notice, Nate | 14:02 |
njohnston | She asked me to take care of the meeting this week and, if I remember correctly, next as well. | 14:03 |
TuanVu | oh, what a bad news | 14:04 |
njohnston | The action items from last week are both ones for her, so let's skip them for now and perhaps we can address them in due course. | 14:04 |
TuanVu | hopefully she'll come back soon | 14:04 |
njohnston | #topic OVO | 14:04 |
*** openstack changes topic to "OVO (Meeting topic: neutron_upgrades)" | 14:04 | |
*** hungpv has joined #openstack-meeting-5 | 14:04 | |
njohnston | #link https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db | 14:04 |
njohnston | I have a few up this week, starting with | 14:05 |
njohnston | #link https://review.openstack.org/579053 | 14:05 |
njohnston | I need to look at the testing more clearly and figure out why tests are failing. | 14:06 |
njohnston | I will have an update on that later today | 14:06 |
TuanVu | thanks | 14:06 |
njohnston | #link https://review.openstack.org/579678 | 14:06 |
TuanVu | I've just left a comment on that one | 14:07 |
TuanVu | It'll be merged soon, I think | 14:07 |
njohnston | I saw your comment, TuanVu, and that makes me scratch my head because I put it back. I'll do it again, the right way this time. :-) | 14:08 |
njohnston | thanks for your reviews | 14:08 |
TuanVu | awesome :) | 14:08 |
njohnston | next is one of yours | 14:08 |
njohnston | sorry, one of Van's | 14:08 |
njohnston | #link https://review.openstack.org/549168 | 14:09 |
njohnston | This one has a long history | 14:09 |
njohnston | but it seems to be failing everything except pep8 and sphinx docs | 14:10 |
hungpv | yes, i've tried to reduce the failed casasse | 14:10 |
njohnston | then you have looked at it more than I have :-) | 14:11 |
njohnston | what did you see? | 14:11 |
hungpv | one off common problem | 14:11 |
hungpv | I encountered for those UTs | 14:12 |
hungpv | is something like " router['router']['id'], KeyError: 'router' | 14:13 |
hungpv | i'm still wrap my head around it | 14:13 |
hungpv | can you give a suggestion | 14:13 |
hungpv | i feel that some OVO code I've converted incorrectly | 14:14 |
hungpv | but haven't figured out it | 14:14 |
njohnston | Hmm, it strikes me as odd that a router would have a field called 'router'. Why would the object be built to nest router information like that? | 14:14 |
njohnston | ok, we can continue the discussion in gerrit | 14:15 |
hungpv | ok cool | 14:16 |
hungpv | thank you nate | 14:16 |
njohnston | #link https://review.openstack.org/579689 | 14:16 |
njohnston | This is one of mine; I just asked for a recheck | 14:17 |
TuanVu | it looks great | 14:17 |
TuanVu | there's only 1 failed fullstack test remaining | 14:17 |
njohnston | I added a note on this to the tracking spreadsheet as well, like 62: This partially covers the needed work. But we need to talk about db/provisioning_blocks.py, because models are being passed to functions there as arguments. | 14:18 |
TuanVu | the recheck will solve it, I think | 14:18 |
TuanVu | yeah, I see | 14:18 |
njohnston | So the method being called from test_provisioning_blocks.py is add_model_for_resource: https://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/provisioning_blocks.py#n36 | 14:19 |
njohnston | that takes a db model and maps it to a callback resource | 14:19 |
hungpv | looks very good | 14:20 |
njohnston | So I think provisioning_blocks.py will be one of the last things converted; it is noted so in the spreadsheet (line 128 in one of lujinluo's sections) | 14:21 |
njohnston | but I wanted to discuss it with you just to be transparent | 14:21 |
TuanVu | thanks for this info, Nate | 14:21 |
njohnston | next up is TuanVu with | 14:22 |
njohnston | #link https://review.openstack.org/507772 | 14:22 |
TuanVu | I’ll need to spend more time on it to figure out how to build the compatibility layer | 14:22 |
TuanVu | I’ll upload a new patch set soon | 14:22 |
*** jgu_ has quit IRC | 14:22 | |
njohnston | Do you know what it is that vmware-nsx is using? | 14:23 |
TuanVu | other than what have been mentioned by boden, I haven't covered all of them yet | 14:25 |
njohnston | I don't have anything else to add on this topic, moving on | 14:27 |
njohnston | #link https://review.openstack.org/579682 | 14:27 |
njohnston | Thanks manjeets for the review; he suggested that I incorporate some additional model transitions I mad missed. That is on my todo list for this week. | 14:28 |
njohnston | #link https://review.openstack.org/562489 | 14:29 |
njohnston | TuanVu, tell us about this | 14:29 |
TuanVu | yeah | 14:29 |
TuanVu | As the discussion in last IRC meeting, in order to avoid blocking the delivery of OVO, I've moved joins to object and add corresponding TODO for it. | 14:30 |
*** jgu_ has joined #openstack-meeting-5 | 14:30 | |
TuanVu | If you have any other suggestions, please don't hesitate to let me know. | 14:30 |
*** hungpv_ has joined #openstack-meeting-5 | 14:31 | |
njohnston | I just +1ed it, it looks good to me | 14:31 |
*** hungpv has quit IRC | 14:31 | |
TuanVu | thank you, Nate | 14:31 |
*** jgu__ has joined #openstack-meeting-5 | 14:31 | |
TuanVu | so I'll apply the same solution for https://review.openstack.org/#/c/561834/ | 14:32 |
njohnston | very good | 14:32 |
njohnston | #link https://review.openstack.org/565773 | 14:33 |
njohnston | that says updated 6 days ago, but I don't see what updated | 14:33 |
njohnston | hopefully lajoskatona has completed the timeboxed assignment and can return to this | 14:33 |
njohnston | I will ask for a status update in gerrit | 14:34 |
TuanVu | ok, that's great | 14:34 |
njohnston | #link https://review.openstack.org/561834 | 14:35 |
njohnston | TuanVu, tell us about this | 14:35 |
*** jgu_ has quit IRC | 14:35 | |
TuanVu | it's the same with Service Type patch which has just got +1 from you | 14:35 |
TuanVu | about doing "join queries" | 14:35 |
njohnston | indeed, I look forward to the new PS | 14:36 |
TuanVu | yeah, I will upload it tomorrow morning | 14:37 |
njohnston | The next few changes are from lujinluo, and are in merge conflict | 14:38 |
njohnston | so I think we should leave them until she can return | 14:38 |
TuanVu | ok | 14:38 |
TuanVu | I agree | 14:38 |
njohnston | I did want to circle back to one change from earlier | 14:39 |
njohnston | because it has an issue that I am not sure how to resolve | 14:40 |
njohnston | #link https://review.openstack.org/#/c/579053/ revisited | 14:40 |
njohnston | that code is failing the unit test neutron.tests.unit.ipam.test_subnet_alloc.TestSubnetAllocation.test_subnetpool_concurrent_allocation_exception | 14:41 |
*** spiette has joined #openstack-meeting-5 | 14:42 | |
TuanVu | I see | 14:42 |
njohnston | The code for that test is here: https://git.openstack.org/cgit/openstack/neutron/tree/neutron/tests/unit/ipam/test_subnet_alloc.py#n190 | 14:42 |
njohnston | You can see that the test has the expectation that the db model will reject the addition with an ORM error | 14:42 |
njohnston | I am not sure how to best implement that in an OVO way | 14:43 |
njohnston | Does anyone have any thoughts? | 14:43 |
TuanVu | hmm, I have no experience with this so I have no idea at this moment. I'll put it on my check list tomorrow and send you feedback if there's any | 14:45 |
TuanVu | is that ok? | 14:45 |
njohnston | That would be wonderful | 14:45 |
njohnston | #topic Open Discussion | 14:46 |
*** openstack changes topic to "Open Discussion (Meeting topic: neutron_upgrades)" | 14:46 | |
njohnston | Does anyone have anything else they would like to discuss? | 14:46 |
TuanVu | one question about Rolling Upgrade | 14:46 |
TuanVu | for example from Queens to Rocky | 14:47 |
TuanVu | is that possible without current state of OVO? | 14:47 |
TuanVu | sorry | 14:47 |
TuanVu | I mean *is that possible with current state of OVO?* | 14:48 |
njohnston | I would not consider myself a deep expert on that yet, but I feel pretty safe in saying that it is probably not safe yet. | 14:49 |
njohnston | There are a few central changes that are waiting on everything to be converted to OVO, and then they can be done | 14:50 |
TuanVu | thank you Nate | 14:50 |
TuanVu | I ask this because we're about to do some tests for this | 14:50 |
njohnston | like line 68 on the spreadsheet in neutron/db/db_base_plugin_common.py | 14:50 |
njohnston | and the add_model_to_resource code in neutron/db/provisioning_blocks.py we discussed earlier | 14:51 |
TuanVu | thanks for giving your opinion on this matter | 14:52 |
TuanVu | I really appreciate it :) | 14:52 |
njohnston | i think it will be less bumpy than before, but the spreadsheet says we are only 26% done so I am afraid I can't give better news :-) | 14:52 |
njohnston | anything else? | 14:53 |
TuanVu | yeah, thank you Nate | 14:53 |
*** spiette has quit IRC | 14:53 | |
TuanVu | that's all from me | 14:54 |
njohnston | Thanks for everything TuanVu and hungpv_, look forward to chatting with you next week. | 14:54 |
hungpv_ | thank you nate, sweee u | 14:54 |
TuanVu | see you soon Nate | 14:55 |
TuanVu | :) | 14:55 |
njohnston | #endmeeting | 14:55 |
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 14:55 | |
openstack | Meeting ended Thu Jul 5 14:55:39 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:55 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-07-05-14.01.html | 14:55 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-07-05-14.01.txt | 14:55 |
openstack | Log: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-07-05-14.01.log.html | 14:55 |
*** spiette has joined #openstack-meeting-5 | 14:58 | |
*** zhipeng has quit IRC | 14:59 | |
*** MarkBaker has quit IRC | 15:06 | |
*** hongbin has joined #openstack-meeting-5 | 15:08 | |
*** MarkBaker has joined #openstack-meeting-5 | 15:21 | |
*** hungpv_ has quit IRC | 15:25 | |
*** jgu__ has quit IRC | 15:29 | |
*** MarkBaker has quit IRC | 15:30 | |
*** radeks has quit IRC | 15:35 | |
*** MarkBaker has joined #openstack-meeting-5 | 15:43 | |
*** TuanVu has quit IRC | 15:45 | |
*** radeks has joined #openstack-meeting-5 | 15:55 | |
*** radeks has quit IRC | 16:22 | |
*** radeks has joined #openstack-meeting-5 | 16:30 | |
*** ricolin has quit IRC | 16:43 | |
*** annp has quit IRC | 16:44 | |
*** iyamahat has joined #openstack-meeting-5 | 16:47 | |
*** derekh has quit IRC | 17:02 | |
*** mjturek has joined #openstack-meeting-5 | 17:12 | |
*** iyamahat has quit IRC | 17:12 | |
*** iyamahat has joined #openstack-meeting-5 | 17:26 | |
*** yamahata has joined #openstack-meeting-5 | 17:27 | |
*** mjturek has quit IRC | 18:26 | |
*** hongbin has quit IRC | 18:48 | |
*** hongbin has joined #openstack-meeting-5 | 18:48 | |
*** jgu_ has joined #openstack-meeting-5 | 19:15 | |
*** jgu__ has joined #openstack-meeting-5 | 19:16 | |
*** jgu_ has quit IRC | 19:19 | |
*** radeks has quit IRC | 19:27 | |
*** jgu__ has quit IRC | 20:31 | |
*** jgu_ has joined #openstack-meeting-5 | 20:32 | |
*** jgu_ has quit IRC | 22:25 | |
*** hongbin has quit IRC | 22:50 | |
*** jgu_ has joined #openstack-meeting-5 | 23:00 | |
*** ianychoi_ has joined #openstack-meeting-5 | 23:01 | |
*** jgu_ has quit IRC | 23:03 | |
*** jgu_ has joined #openstack-meeting-5 | 23:04 | |
*** ianychoi has quit IRC | 23:04 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!