*** yamahata has quit IRC | 00:40 | |
*** yamahata has joined #openstack-meeting-5 | 00:56 | |
*** mjturek has joined #openstack-meeting-5 | 00:57 | |
*** slaweq has joined #openstack-meeting-5 | 01:11 | |
*** slaweq has quit IRC | 01:15 | |
*** roman_g has joined #openstack-meeting-5 | 04:07 | |
*** skazi has quit IRC | 04:55 | |
*** slaweq has joined #openstack-meeting-5 | 05:11 | |
*** roman_g has quit IRC | 05:12 | |
*** slaweq has quit IRC | 05:16 | |
*** skazi has joined #openstack-meeting-5 | 05:45 | |
*** lemko has joined #openstack-meeting-5 | 05:46 | |
*** dims has quit IRC | 06:29 | |
*** slaweq has joined #openstack-meeting-5 | 06:29 | |
*** jamesgu has joined #openstack-meeting-5 | 06:30 | |
*** dims has joined #openstack-meeting-5 | 06:33 | |
*** slaweq has quit IRC | 06:34 | |
*** dims has quit IRC | 06:38 | |
*** dims has joined #openstack-meeting-5 | 06:39 | |
*** slaweq has joined #openstack-meeting-5 | 06:41 | |
*** slaweq has quit IRC | 06:46 | |
*** slaweq has joined #openstack-meeting-5 | 06:50 | |
*** roman_g has joined #openstack-meeting-5 | 06:50 | |
*** slaweq has quit IRC | 07:03 | |
*** slaweq has joined #openstack-meeting-5 | 07:05 | |
*** ralonsoh has joined #openstack-meeting-5 | 07:29 | |
*** roman_g has quit IRC | 07:47 | |
*** roman_g has joined #openstack-meeting-5 | 08:23 | |
*** skazi has quit IRC | 08:35 | |
*** derekh has joined #openstack-meeting-5 | 08:42 | |
*** yamahata has quit IRC | 08:57 | |
*** skazi has joined #openstack-meeting-5 | 09:33 | |
*** derekh has quit IRC | 12:00 | |
*** derekh has joined #openstack-meeting-5 | 12:00 | |
*** yamahata has joined #openstack-meeting-5 | 12:47 | |
*** dims has quit IRC | 13:12 | |
*** dims has joined #openstack-meeting-5 | 13:14 | |
*** dims has quit IRC | 13:19 | |
*** mjturek has joined #openstack-meeting-5 | 13:25 | |
*** mjturek has quit IRC | 13:42 | |
*** mjturek has joined #openstack-meeting-5 | 13:45 | |
*** annp_ has joined #openstack-meeting-5 | 13:54 | |
*** lujinluo has joined #openstack-meeting-5 | 13:56 | |
lujinluo | #startmeeting neutron_upgrades | 14:00 |
---|---|---|
openstack | Meeting started Thu Oct 11 14:00:21 2018 UTC and is due to finish in 60 minutes. The chair is lujinluo. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
*** openstack changes topic to " (Meeting topic: neutron_upgrades)" | 14:00 | |
openstack | The meeting name has been set to 'neutron_upgrades' | 14:00 |
lujinluo | o/ | 14:00 |
ralonsoh | hi | 14:00 |
*** mjturek has quit IRC | 14:00 | |
lujinluo | hi ralonsoh! | 14:00 |
njohnston | o/ | 14:01 |
lujinluo | o/ njohnston | 14:01 |
lujinluo | ok, let's get started | 14:01 |
lujinluo | #topic OVO | 14:01 |
*** openstack changes topic to "OVO (Meeting topic: neutron_upgrades)" | 14:01 | |
lujinluo | #link https://review.openstack.org/#/q/topic:bp/adopt-oslo-versioned-objects-for-db+status:open | 14:01 |
lujinluo | #link https://review.openstack.org/#/c/608198/ NetworkRBAC in neutron/db/db_base_plugin_v2.py | 14:02 |
ralonsoh | I replied to njohnston | 14:02 |
ralonsoh | IMO, is almost almost ready | 14:03 |
ralonsoh | It will depends on https://review.openstack.org/#/c/609691/ | 14:03 |
ralonsoh | the functional tests | 14:03 |
njohnston | just added +1 | 14:04 |
ralonsoh | njohnston thanks!! | 14:04 |
lujinluo | ack. i will review it today | 14:04 |
lujinluo | #link https://review.openstack.org/#/c/608628/ Use NetworkRBAC OVO in neutron/db/external_net_db.py | 14:05 |
ralonsoh | functional tests in https://review.openstack.org/#/c/609692/ | 14:05 |
ralonsoh | addressed all comments in last commit | 14:06 |
*** mjturek has joined #openstack-meeting-5 | 14:07 | |
njohnston | Sorry I have not been active on that review; I'll try to take a pass later | 14:07 |
lujinluo | awesome. by taking a quick look at the codes, i think they are generally fine. i will review it today as well. | 14:08 |
lujinluo | (me neither. will try to get back on track this week, sorry :( | 14:08 |
lujinluo | next two are functional tests of the previous two patches | 14:09 |
lujinluo | #link https://review.openstack.org/#/c/609691/ functional tests of #link https://review.openstack.org/#/c/608198/ | 14:09 |
lujinluo | #link https://review.openstack.org/#/c/609692/ functional tests of #link https://review.openstack.org/#/c/608628/ | 14:10 |
lujinluo | I will review the four of them within this week! | 14:10 |
ralonsoh | thanks! no rush | 14:10 |
lujinluo | thanks for the great work ralonsoh! | 14:10 |
ralonsoh | lujinluo: no problem, that was a suggestion made by njohnston | 14:11 |
*** TuanVu has joined #openstack-meeting-5 | 14:11 | |
lujinluo | thank you! njohnston | 14:11 |
* njohnston is very appreciative of ralonsoh's great work | 14:11 | |
lujinluo | next is port binding #link https://review.openstack.org/#/c/544206/ | 14:11 |
lujinluo | i addressed most of the comments from hongbin and manjeet, except for 2 left, which i do not think i will revise the codes, but i need to run some local tests to justify the changes | 14:12 |
lujinluo | i will finish it this week too. then reviews are welcome :) | 14:13 |
njohnston | I do have one question | 14:13 |
*** TuanVu has quit IRC | 14:13 | |
njohnston | You turn on new engine facade in this change | 14:14 |
*** TuanVu has joined #openstack-meeting-5 | 14:14 | |
lujinluo | yes | 14:14 |
njohnston | This is pre-empting the engine-facade section in the agenda I realize, but I wonder if that should be a separate change? Or does it positively affect the functioning of what you're changing here? | 14:15 |
lujinluo | yes, the changes made in that patch requires using new engine facade. let me find an example here | 14:16 |
lujinluo | https://review.openstack.org/#/c/544206/24/neutron/plugins/ml2/plugin.py@399 | 14:18 |
njohnston | ok | 14:19 |
*** TuanVu has quit IRC | 14:19 | |
lujinluo | this update() inside _process_port_binding() then __create_port_db() is inside a writer transaction | 14:19 |
njohnston | yep, that makes sense | 14:20 |
njohnston | ok, cool, I am good to move on :-) | 14:20 |
lujinluo | good! | 14:20 |
*** TuanVu has joined #openstack-meeting-5 | 14:20 | |
lujinluo | let's move to the next one | 14:20 |
lujinluo | #link https://review.openstack.org/#/c/608638/ | 14:21 |
lujinluo | Use NetworkRBAC OVO in tests/unit/db/test_db_base_plugin_v2.py | 14:21 |
ralonsoh | last comment already addressed | 14:21 |
*** dims has joined #openstack-meeting-5 | 14:22 | |
lujinluo | good job! and i will review it right after the meeting | 14:23 |
lujinluo | thank you so much for your work ralonsoh!! | 14:24 |
lujinluo | next is the retry decorator changes in neutron-lib #link https://review.openstack.org/#/c/605365/ | 14:24 |
lujinluo | i replied to michel's concern but he has not replied yet | 14:25 |
njohnston | He's right about it, but it is a transitional accomodation | 14:26 |
njohnston | with a finite lifetime | 14:26 |
lujinluo | yeah | 14:26 |
lujinluo | will wait for a while before approaching him on irc | 14:27 |
lujinluo | #link https://review.openstack.org/#/c/602497/ use ovo for L3HARouterAgentPortBinding in l3_hamode | 14:27 |
lujinluo | for this patch, does zuul hang somewhere? or did i miss anything | 14:28 |
njohnston | hmm | 14:29 |
lujinluo | let me try if recheck would help or not | 14:30 |
njohnston | it's parent has not merged https://review.openstack.org/#/c/607076/ | 14:30 |
njohnston | so that is to be expected | 14:30 |
lujinluo | oh, got it | 14:31 |
lujinluo | thanks for the recheck | 14:31 |
njohnston | :-) | 14:31 |
lujinluo | #link https://review.openstack.org/#/c/507772/ network OVO | 14:32 |
lujinluo | TuanVu: since you are here today, do you happen to have any updates on it? | 14:32 |
njohnston | last time I looked at it I came away with the same questions you had posted lujinluo so I maintained my -1 | 14:33 |
TuanVu | Hi Luo and Nate | 14:33 |
njohnston | Hi TuanVu! | 14:34 |
lujinluo | hi TuanVu! | 14:34 |
TuanVu | I intended to update it this week but couldn't manage to have enough time | 14:34 |
TuanVu | I will try to update it soon | 14:34 |
TuanVu | thanks a lot for your kind help | 14:34 |
lujinluo | ack! | 14:35 |
njohnston | thanks | 14:35 |
lujinluo | the rest of the patches are not updated since previous meeting. and let's give them some time | 14:35 |
lujinluo | #topic engine facade | 14:36 |
*** openstack changes topic to "engine facade (Meeting topic: neutron_upgrades)" | 14:36 | |
lujinluo | #link https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/enginefacade-switch | 14:36 |
lujinluo | last week, i said i have a local patch working on, but sadly i have not finished it :( | 14:36 |
lujinluo | i will try to finish it this week and push for review | 14:36 |
lujinluo | #topic open discussion | 14:37 |
*** openstack changes topic to "open discussion (Meeting topic: neutron_upgrades)" | 14:37 | |
njohnston | Are there any other objects that we think we can switch to the new facade, on a per-object basis? | 14:37 |
njohnston | the Agent object, for example? | 14:38 |
lujinluo | i have not gone through the codes so i cannot tell for sure, but theoretically speaking for the objects that we have already converted, should be fine to switch on new facade | 14:38 |
njohnston | according to the tracking spreadsheet, work on that jas completed | 14:38 |
njohnston | I think I'll push up something to enable the new facade on that, and let's see how well it works | 14:39 |
lujinluo | great | 14:39 |
njohnston | if that works OK then we can move on Network and Router as next steps | 14:40 |
lujinluo | yep! | 14:40 |
njohnston | #action njohnston to push change that enables new engine facade for Agent object | 14:40 |
lujinluo | thanks! | 14:41 |
lujinluo | does anyone have anything else? | 14:41 |
lujinluo | if not, i have one small favor i would like to ask | 14:42 |
ralonsoh | sure | 14:42 |
njohnston | ok | 14:42 |
lujinluo | first i am sorry i was not active enough to track the changes last week, and i saw people actually added me as reviewers to those new patches | 14:42 |
lujinluo | but that one goes to my previous company email, which i did not have access to.. | 14:43 |
lujinluo | i mean i dont have access anymore | 14:43 |
lujinluo | so if possible.. please add the account with my gmail address, :) | 14:43 |
*** dims has quit IRC | 14:43 | |
njohnston | ok | 14:43 |
ralonsoh | ok | 14:43 |
lujinluo | i will also contact the admin ppl to see if they can remove the old account for good | 14:44 |
lujinluo | thanks! njohnston ralonsoh | 14:44 |
ralonsoh | thanks! | 14:44 |
njohnston | np | 14:44 |
lujinluo | ok, if that's it. let's call it a day :-) | 14:44 |
njohnston | I have one other thing | 14:44 |
lujinluo | sure | 14:44 |
njohnston | I am starting to play around with how best to implement baked qieries | 14:45 |
njohnston | I have a very WIP change here: https://review.openstack.org/609715 | 14:45 |
lujinluo | is it the one we may need for all the joins? | 14:45 |
njohnston | it speeds up operations. Basically it short cuts the process of constructing the text of the SQL query. Especially for frequently invoked queries that never change it will be a significant speed boost. | 14:47 |
lujinluo | sounds very impressive | 14:47 |
njohnston | it was already implemented in ODL; check out https://review.openstack.org/#/c/591363/ for comparison | 14:48 |
*** dims has joined #openstack-meeting-5 | 14:48 | |
lujinluo | got it. will check on both patches. this will be a big performance gain in large scale systems | 14:49 |
njohnston | absolutely | 14:50 |
*** annp_ has quit IRC | 14:51 | |
lujinluo | yeah, would be very interested to see how it works! | 14:52 |
njohnston | that is all for me | 14:52 |
lujinluo | ok if nothing else, let's call it a day! | 14:53 |
lujinluo | thanks everyone for joining | 14:53 |
lujinluo | have a good day/night | 14:53 |
ralonsoh | bye | 14:53 |
lujinluo | and hope to see you all next week! | 14:53 |
lujinluo | #endmeeting | 14:53 |
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 14:53 | |
openstack | Meeting ended Thu Oct 11 14:53:44 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:53 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-10-11-14.00.html | 14:53 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-10-11-14.00.txt | 14:53 |
openstack | Log: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-10-11-14.00.log.html | 14:53 |
*** lujinluo has quit IRC | 15:03 | |
*** mugsie has joined #openstack-meeting-5 | 15:23 | |
*** roman_g has quit IRC | 15:24 | |
*** roman_g has joined #openstack-meeting-5 | 15:26 | |
*** mjturek has quit IRC | 15:51 | |
*** lujinluo has joined #openstack-meeting-5 | 16:04 | |
*** lujinluo has quit IRC | 16:24 | |
*** skazi has quit IRC | 16:36 | |
*** mjturek has joined #openstack-meeting-5 | 16:42 | |
*** derekh has quit IRC | 16:59 | |
*** mjturek has quit IRC | 17:01 | |
*** TuanVu has quit IRC | 17:29 | |
*** TuanVu has joined #openstack-meeting-5 | 17:29 | |
*** TuanVu has quit IRC | 17:30 | |
*** TuanVu has joined #openstack-meeting-5 | 17:30 | |
*** TuanVu has quit IRC | 17:30 | |
*** TuanVu has joined #openstack-meeting-5 | 17:31 | |
*** TuanVu has quit IRC | 17:31 | |
*** TuanVu has joined #openstack-meeting-5 | 17:32 | |
*** TuanVu has quit IRC | 17:32 | |
*** yamahata has quit IRC | 17:37 | |
*** hongbin has joined #openstack-meeting-5 | 17:38 | |
*** ianychoi has quit IRC | 17:41 | |
*** zenirc369 has joined #openstack-meeting-5 | 17:46 | |
*** zenirc369 has quit IRC | 17:51 | |
*** skazi has joined #openstack-meeting-5 | 17:53 | |
*** yamahata has joined #openstack-meeting-5 | 18:09 | |
*** ralonsoh has quit IRC | 18:32 | |
*** lemko has quit IRC | 21:46 | |
*** hongbin has quit IRC | 23:04 | |
*** yamahata has quit IRC | 23:37 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!