| *** markvoelker has quit IRC | 00:01 | |
| *** slaweq has quit IRC | 00:15 | |
| *** sgrasley has joined #openstack-meeting-5 | 00:17 | |
| *** sgrasley has quit IRC | 00:35 | |
| *** jamesgu_ has quit IRC | 01:33 | |
| *** markvoelker has joined #openstack-meeting-5 | 02:03 | |
| *** lujinluo has quit IRC | 02:03 | |
| *** lujinluo has joined #openstack-meeting-5 | 02:04 | |
| *** lujinluo has quit IRC | 02:09 | |
| *** iyamahat_ has quit IRC | 02:23 | |
| *** yamahata has quit IRC | 02:24 | |
| *** markvoelker has quit IRC | 02:35 | |
| *** lujinluo has joined #openstack-meeting-5 | 02:49 | |
| *** lujinluo has quit IRC | 02:55 | |
| *** markvoelker has joined #openstack-meeting-5 | 03:32 | |
| *** markvoelker has quit IRC | 04:06 | |
| *** yamahata has joined #openstack-meeting-5 | 04:07 | |
| *** iyamahat has joined #openstack-meeting-5 | 04:07 | |
| *** lujinluo has joined #openstack-meeting-5 | 05:01 | |
| *** markvoelker has joined #openstack-meeting-5 | 05:02 | |
| *** lujinluo has quit IRC | 05:05 | |
| *** lujinluo has joined #openstack-meeting-5 | 05:06 | |
| *** markvoelker has quit IRC | 05:36 | |
| *** roman_g has quit IRC | 05:42 | |
| *** lujinluo has quit IRC | 06:19 | |
| *** markvoelker has joined #openstack-meeting-5 | 06:33 | |
| *** markvoelker has quit IRC | 07:05 | |
| *** lujinluo has joined #openstack-meeting-5 | 07:18 | |
| *** lujinluo has quit IRC | 07:23 | |
| *** lujinluo has joined #openstack-meeting-5 | 07:57 | |
| *** slaweq has joined #openstack-meeting-5 | 07:58 | |
| *** lujinluo has quit IRC | 08:02 | |
| *** markvoelker has joined #openstack-meeting-5 | 08:03 | |
| *** slaweq has quit IRC | 08:18 | |
| *** ralonsoh has joined #openstack-meeting-5 | 08:22 | |
| *** ralonsoh has quit IRC | 08:22 | |
| *** ralonsoh has joined #openstack-meeting-5 | 08:23 | |
| *** markvoelker has quit IRC | 08:36 | |
| *** derekh has joined #openstack-meeting-5 | 09:16 | |
| *** markvoelker has joined #openstack-meeting-5 | 09:33 | |
| *** ralonsoh has quit IRC | 10:02 | |
| *** ralonsoh has joined #openstack-meeting-5 | 10:03 | |
| *** markvoelker has quit IRC | 10:07 | |
| *** lujinluo has joined #openstack-meeting-5 | 10:32 | |
| *** lujinluo has quit IRC | 10:36 | |
| *** markvoelker has joined #openstack-meeting-5 | 11:04 | |
| *** markvoelker has quit IRC | 11:36 | |
| *** skazi has quit IRC | 11:41 | |
| *** skazi has joined #openstack-meeting-5 | 12:29 | |
| *** markvoelker has joined #openstack-meeting-5 | 12:31 | |
| *** njohnston has joined #openstack-meeting-5 | 13:33 | |
| *** stokvis has joined #openstack-meeting-5 | 13:38 | |
| *** lujinluo has joined #openstack-meeting-5 | 13:49 | |
| *** annp_ has joined #openstack-meeting-5 | 13:56 | |
| lujinluo | #startmeeting neutron_upgrades | 14:00 |
|---|---|---|
| openstack | Meeting started Thu Nov 1 14:00:11 2018 UTC and is due to finish in 60 minutes. The chair is lujinluo. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| *** openstack changes topic to " (Meeting topic: neutron_upgrades)" | 14:00 | |
| openstack | The meeting name has been set to 'neutron_upgrades' | 14:00 |
| njohnston | o/ | 14:00 |
| lujinluo | o/ | 14:00 |
| ralonsoh | hi | 14:00 |
| lujinluo | hi njohnston and ralonsoh ! | 14:00 |
| njohnston | Happy November! | 14:01 |
| annp_ | hi | 14:01 |
| lujinluo | LOL | 14:01 |
| lujinluo | hi annp_ | 14:01 |
| annp_ | hi lujinluo | 14:01 |
| lujinluo | thank you for chairing the meeting last week njohnston | 14:02 |
| lujinluo | really appreciated that | 14:02 |
| njohnston | Always happy to help :-) | 14:02 |
| lujinluo | do we have any AIs carried from last week? if not, we can safely jump into the patches | 14:02 |
| njohnston | looking... | 14:03 |
| njohnston | ah that's right, nobody showed up :-) | 14:03 |
| njohnston | it was just me | 14:03 |
| lujinluo | oops | 14:04 |
| lujinluo | sorry to hear that... | 14:04 |
| njohnston | so going back a week | 14:04 |
| lujinluo | two weeks ago, we have 2 AIs. | 14:04 |
| njohnston | AI1: njohnston pick tests from https://review.openstack.org/609749 and step through with pdb to detect failure | 14:04 |
| njohnston | I did that, but I was not able to drill down on the problem. Still working on it in the background. | 14:05 |
| *** hongbin has joined #openstack-meeting-5 | 14:05 | |
| lujinluo | Got it. | 14:05 |
| njohnston | AI2: lujin to keep an eye on Network OVO in db_base_plugin | 14:05 |
| njohnston | I think that has been happening :-) | 14:05 |
| lujinluo | yeah, tuan pushed another patch set but only to resolve merge conflict | 14:06 |
| lujinluo | but i believe he will finish working on to address our concerns soon | 14:07 |
| lujinluo | i will follow him | 14:07 |
| lujinluo | ok then, let's jump into the patches | 14:08 |
| lujinluo | #topic OVO | 14:08 |
| *** openstack changes topic to "OVO (Meeting topic: neutron_upgrades)" | 14:08 | |
| lujinluo | #link https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db | 14:08 |
| lujinluo | #link https://review.openstack.org/#/c/579053/ Use OVO in neutron/ipam/subnet_alloc.py | 14:08 |
| njohnston | I brought that one back from the dead | 14:09 |
| njohnston | I pushed a change to fix the merge conflict | 14:09 |
| ralonsoh | I think this is going to fail again | 14:09 |
| lujinluo | on test_subnetpool_concurrent_allocation_exception ? | 14:09 |
| njohnston | and now I am working on the review feedback | 14:09 |
| ralonsoh | comments in PS10 and PS11 | 14:09 |
| njohnston | it definitely will for the reason you identified, ralonsoh | 14:09 |
| njohnston | right | 14:09 |
| lujinluo | i see. | 14:09 |
| njohnston | the thing is I am looking for the right place to mock to create a concurrent allocation exception | 14:10 |
| njohnston | but with the new code it looks like what is happening is that an IpamSubnet object is getting instantiated | 14:10 |
| *** spiette has quit IRC | 14:11 | |
| lujinluo | i see. | 14:12 |
| njohnston | I guess the thing to do is to mock subnet_pool.update() and have that throw the exception | 14:12 |
| lujinluo | so it is still how we can mock .update() | 14:12 |
| lujinluo | yeah | 14:12 |
| njohnston | ok, if no objections that is what I'll do | 14:14 |
| njohnston | the only other alternative | 14:14 |
| njohnston | is to mock update_object in the base update method https://git.openstack.org/cgit/openstack/neutron/tree/neutron/objects/base.py#n806 | 14:15 |
| lujinluo | well, i think it might be easier to mock update_object as it has direct db access | 14:16 |
| lujinluo | as update() is only calling methods from db_api | 14:17 |
| njohnston | ok | 14:18 |
| njohnston | your wish is my command | 14:18 |
| *** sgrasley has joined #openstack-meeting-5 | 14:18 | |
| lujinluo | LOL, but i have not done as much research as you did. you are the master of this patch | 14:18 |
| lujinluo | just my rough idea that it might be easier to mock update_object() | 14:19 |
| njohnston | sounds good | 14:19 |
| lujinluo | i will keep a close eye on that patch! since i am finishing all the midterms this week, so i will more bandwidth for openstack, haha | 14:20 |
| lujinluo | let's move to the next | 14:21 |
| lujinluo | #link https://review.openstack.org/#/c/549168/ Router OVO | 14:21 |
| lujinluo | annp_: hi, i see it is still WIP, but do you have anything you want to share? | 14:21 |
| annp_ | lujinluo, Hi, I'm making progress on that. | 14:22 |
| annp_ | However, gate still red | 14:22 |
| annp_ | Currently, I've just cleanup something, | 14:23 |
| lujinluo | yes, router is a rather big object. you change one place and it may propagate to many more. | 14:23 |
| lujinluo | annp_: sounds good. | 14:24 |
| annp_ | lujinluo, yes. I'm debugging some test failed related to gw_port | 14:24 |
| lujinluo | got it. | 14:25 |
| annp_ | lujinluo, could you take a look and give me some advise if you have time. | 14:25 |
| annp_ | Thanks in advance. :-) | 14:25 |
| lujinluo | sure. i will add it to my review list | 14:25 |
| lujinluo | #action lujinluo to review https://review.openstack.org/#/c/549168/ | 14:26 |
| lujinluo | then let's move to next | 14:26 |
| lujinluo | Use NetworkRBAC OVO in neutron/db/db_base_plugin_v2.py | 14:26 |
| lujinluo | #link https://review.openstack.org/#/c/608198/ | 14:26 |
| lujinluo | it has been sent to the queue, and Rodolfo just rechecked Zuul failure. Let's pray for Zuul's mercy | 14:27 |
| njohnston | :-) | 14:27 |
| lujinluo | #link https://review.openstack.org/#/c/608628/ | 14:28 |
| lujinluo | may the same mercy go to ^ | 14:28 |
| *** spiette has joined #openstack-meeting-5 | 14:28 | |
| lujinluo | #link https://review.openstack.org/#/c/610182/ Support fetching specific db column in OVO | 14:29 |
| lujinluo | this patch has receive multiple +1 from our team | 14:29 |
| lujinluo | let me add miguel and slawek to it and ask them to do the final check | 14:30 |
| ralonsoh | lujinluo: the CI is going to be back once we have requirements updated | 14:30 |
| *** spiette has quit IRC | 14:31 | |
| njohnston | +1 | 14:31 |
| lujinluo | which patch are you talking about? ralonsoh networkRBAC or specifi db column? or maybe both? | 14:32 |
| ralonsoh | lujinluo: I'm talking about the CI | 14:32 |
| lujinluo | Ah, I see. | 14:33 |
| ralonsoh | lujinluo: once requirements repo is updated will have the CI back | 14:33 |
| *** spiette has joined #openstack-meeting-5 | 14:33 | |
| lujinluo | Got it | 14:34 |
| lujinluo | ok, let's move to next patch | 14:36 |
| lujinluo | #link https://review.openstack.org/#/c/610184/ | 14:36 |
| lujinluo | Convert Subnet to OVO in ipam_pluggable_backend.py | 14:37 |
| lujinluo | this patch utilize fetching specific db column | 14:37 |
| lujinluo | and should wait for that one to get in first | 14:37 |
| lujinluo | but the change is quite simple | 14:38 |
| lujinluo | oops, i missed on patch in the between | 14:38 |
| lujinluo | #link https://review.openstack.org/#/c/608638/ Use NetworkRBAC OVO in tests/unit/db/test_db_base_plugin_v2.py | 14:38 |
| lujinluo | it is hit by merge conflict | 14:39 |
| ralonsoh | lujinluo, waiting for the previous ones to be merged | 14:39 |
| lujinluo | understood. | 14:39 |
| ralonsoh | once I have the previous two patches, I'll rebase this one | 14:39 |
| lujinluo | sounds good | 14:40 |
| lujinluo | :-) | 14:40 |
| lujinluo | next is a WIP patch | 14:40 |
| lujinluo | #link https://review.openstack.org/#/c/609848/ Convert Port to OVO in db/ipam_pluggable_backend.py | 14:40 |
| *** stokvis has quit IRC | 14:40 | |
| lujinluo | it is still pretty red. let's give it some time | 14:41 |
| lujinluo | #link https://review.openstack.org/#/c/507772/ Network OVO | 14:42 |
| lujinluo | still i will keep an eye on this patch and talk to tuan to see if he needs more help from our team | 14:42 |
| lujinluo | #link https://review.openstack.org/#/c/610280/ Use RBACBaseObject OVO in neutron/db/rbac_db_mixin.py | 14:43 |
| ralonsoh | same as previous one | 14:43 |
| lujinluo | got it! | 14:43 |
| lujinluo | #link https://review.openstack.org/#/c/611461/ | 14:45 |
| lujinluo | this is the bug fix of #1789434 | 14:45 |
| lujinluo | we have decided to wait for it to pass all the gate tests before reviewing it | 14:46 |
| lujinluo | next is the retry decorator | 14:46 |
| lujinluo | #link https://review.openstack.org/#/c/602362/ | 14:47 |
| lujinluo | Lajos proposed a new patch about two weeks ago | 14:47 |
| njohnston | ah yes, I remember this one | 14:47 |
| lujinluo | i have not review it myself yet | 14:47 |
| njohnston | I can take a look at that, give a fresh eye to it | 14:47 |
| lujinluo | thanks! njohnston | 14:48 |
| lujinluo | next is mine | 14:48 |
| lujinluo | #link https://review.openstack.org/#/c/544206/ Port Binding OVO | 14:48 |
| lujinluo | I will another patch set soon to resolve the merge conflict and address Hongbin's comment | 14:49 |
| hongbin | o/ | 14:49 |
| lujinluo | that's all the patches we have for OVO | 14:50 |
| lujinluo | hi hongbin ! | 14:50 |
| hongbin | lujinluo: it looks the meeting is over :) | 14:50 |
| hongbin | s/almost | 14:50 |
| lujinluo | half of it is over, we still have another topic, lol | 14:50 |
| lujinluo | #topic engine facade | 14:50 |
| *** openstack changes topic to "engine facade (Meeting topic: neutron_upgrades)" | 14:50 | |
| lujinluo | #link https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/enginefacade-switch | 14:50 |
| lujinluo | although we only have one patch to discuss | 14:50 |
| lujinluo | Remove context guard of Agent OVO | 14:51 |
| lujinluo | #link https://review.openstack.org/#/c/611462/ | 14:51 |
| * hongbin is lurking | 14:51 | |
| lujinluo | hongbin had a comment which i think makes sense | 14:51 |
| lujinluo | i will revise the patch set, to add the transaction guard back in new engine facade | 14:52 |
| hongbin | cool | 14:52 |
| lujinluo | indeed there are two transactions opened | 14:52 |
| lujinluo | and we should guard them together | 14:52 |
| lujinluo | #topic open discussion | 14:53 |
| *** openstack changes topic to "open discussion (Meeting topic: neutron_upgrades)" | 14:53 | |
| lujinluo | i just noticed Berlin summit is around the corner! | 14:53 |
| lujinluo | anyone from our team is going? | 14:53 |
| lujinluo | have fun! | 14:53 |
| hongbin | i will go there | 14:53 |
| * njohnston cannot make it this time, sadly | 14:53 | |
| lujinluo | njohnston: i am not going either. :( | 14:54 |
| lujinluo | wow, have fun hongbin! | 14:54 |
| hongbin | lujinluo: thanks | 14:54 |
| lujinluo | does anyone have anything else to share? | 14:54 |
| lujinluo | if not, let's call it a day! we only have 6 min left this time | 14:54 |
| njohnston | thanks all | 14:55 |
| lujinluo | thank you all for joining the meeting this time. hope to see you all next week | 14:55 |
| lujinluo | #endmeeting | 14:55 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 14:55 | |
| openstack | Meeting ended Thu Nov 1 14:55:40 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:55 |
| ralonsoh | bye | 14:55 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-11-01-14.00.html | 14:55 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-11-01-14.00.txt | 14:55 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-11-01-14.00.log.html | 14:55 |
| *** njohnston has left #openstack-meeting-5 | 14:56 | |
| *** lujinluo has quit IRC | 15:05 | |
| *** jamesgu_ has joined #openstack-meeting-5 | 15:12 | |
| *** annp_ has quit IRC | 15:31 | |
| *** slaweq has joined #openstack-meeting-5 | 16:29 | |
| *** spiette has quit IRC | 17:18 | |
| *** spiette has joined #openstack-meeting-5 | 17:26 | |
| *** slaweq has quit IRC | 17:27 | |
| *** derekh has quit IRC | 18:00 | |
| *** iyamahat has quit IRC | 18:05 | |
| *** yamahata has quit IRC | 18:05 | |
| *** ralonsoh has quit IRC | 18:13 | |
| *** iyamahat has joined #openstack-meeting-5 | 18:19 | |
| *** yamahata has joined #openstack-meeting-5 | 18:38 | |
| *** spiette has quit IRC | 18:53 | |
| *** spiette has joined #openstack-meeting-5 | 19:17 | |
| *** slaweq has joined #openstack-meeting-5 | 20:50 | |
| *** hongbin has quit IRC | 21:30 | |
| *** iyamahat has quit IRC | 21:33 | |
| *** slaweq has quit IRC | 21:36 | |
| *** iyamahat has joined #openstack-meeting-5 | 21:39 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!