| *** TxGirlGeek has quit IRC | 00:01 | |
| *** hongbin has quit IRC | 00:05 | |
| *** sdake has joined #openstack-meeting-alt | 00:05 | |
| *** sdake has quit IRC | 00:29 | |
| *** sdake has joined #openstack-meeting-alt | 00:49 | |
| *** masahito has joined #openstack-meeting-alt | 01:04 | |
| *** masahito has quit IRC | 01:08 | |
| *** sdake has quit IRC | 01:09 | |
| *** jcoufal has quit IRC | 01:22 | |
| *** gyee has quit IRC | 01:33 | |
| *** liuyulong has joined #openstack-meeting-alt | 01:50 | |
| *** jcoufal has joined #openstack-meeting-alt | 02:01 | |
| *** TxGirlGeek has joined #openstack-meeting-alt | 02:02 | |
| *** whoami-rajat has joined #openstack-meeting-alt | 02:11 | |
| *** liuyulong has quit IRC | 02:21 | |
| *** dims has quit IRC | 02:38 | |
| *** bhavikdbavishi has joined #openstack-meeting-alt | 02:50 | |
| *** dims has joined #openstack-meeting-alt | 02:55 | |
| *** iyamahat has quit IRC | 02:59 | |
| *** yamahata has quit IRC | 03:00 | |
| *** sdake has joined #openstack-meeting-alt | 03:00 | |
| *** masahito has joined #openstack-meeting-alt | 03:05 | |
| *** masahito has quit IRC | 03:09 | |
| *** apetrich has quit IRC | 03:15 | |
| *** yamahata has joined #openstack-meeting-alt | 03:35 | |
| *** tetsuro has quit IRC | 04:04 | |
| *** TxGirlGeek has quit IRC | 04:18 | |
| *** hongbin has joined #openstack-meeting-alt | 04:48 | |
| *** hongbin has quit IRC | 05:04 | |
| *** lbragstad has quit IRC | 05:16 | |
| *** e0ne has joined #openstack-meeting-alt | 06:12 | |
| *** igordc has quit IRC | 06:30 | |
| *** tetsuro has joined #openstack-meeting-alt | 06:31 | |
| *** zzzeek has quit IRC | 06:33 | |
| *** tetsuro has quit IRC | 06:35 | |
| *** zzzeek has joined #openstack-meeting-alt | 06:37 | |
| *** radeks_ has joined #openstack-meeting-alt | 06:54 | |
| *** sridharg has joined #openstack-meeting-alt | 07:00 | |
| *** e0ne has quit IRC | 07:05 | |
| *** ccamacho has joined #openstack-meeting-alt | 07:15 | |
| *** markvoelker has joined #openstack-meeting-alt | 07:26 | |
| *** kopecmartin|off is now known as kopecmartin | 07:30 | |
| *** jcoufal has quit IRC | 07:39 | |
| *** slaweq has joined #openstack-meeting-alt | 07:39 | |
| *** slaweq has quit IRC | 07:43 | |
| *** jcoufal has joined #openstack-meeting-alt | 07:56 | |
| *** markvoelker has quit IRC | 07:59 | |
| *** slaweq has joined #openstack-meeting-alt | 08:03 | |
| *** apetrich has joined #openstack-meeting-alt | 08:17 | |
| *** lhinds has quit IRC | 08:51 | |
| *** iyamahat has joined #openstack-meeting-alt | 08:52 | |
| *** lhinds has joined #openstack-meeting-alt | 08:55 | |
| *** ttsiouts has joined #openstack-meeting-alt | 08:56 | |
| *** markvoelker has joined #openstack-meeting-alt | 08:56 | |
| *** haleyb has quit IRC | 09:03 | |
| *** ttsiouts has quit IRC | 09:06 | |
| *** ttsiouts has joined #openstack-meeting-alt | 09:07 | |
| *** ttsiouts has quit IRC | 09:11 | |
| *** iyamahat has quit IRC | 09:11 | |
| *** e0ne has joined #openstack-meeting-alt | 09:15 | |
| *** ttsiouts has joined #openstack-meeting-alt | 09:15 | |
| *** tssurya has joined #openstack-meeting-alt | 09:21 | |
| *** janki has joined #openstack-meeting-alt | 09:29 | |
| *** markvoelker has quit IRC | 09:29 | |
| *** panda|off is now known as panda | 09:46 | |
| *** derekh has joined #openstack-meeting-alt | 09:48 | |
| *** bhavikdbavishi has quit IRC | 09:52 | |
| *** masahito has joined #openstack-meeting-alt | 09:58 | |
| *** masahito has quit IRC | 10:02 | |
| *** erlon has joined #openstack-meeting-alt | 10:10 | |
| *** markvoelker has joined #openstack-meeting-alt | 10:26 | |
| *** apetrich has quit IRC | 10:27 | |
| *** rnoriega has quit IRC | 10:35 | |
| *** rnoriega has joined #openstack-meeting-alt | 10:36 | |
| *** apetrich has joined #openstack-meeting-alt | 10:41 | |
| *** e0ne has quit IRC | 10:46 | |
| *** e0ne has joined #openstack-meeting-alt | 10:52 | |
| *** priteau has joined #openstack-meeting-alt | 10:53 | |
| *** purplerbot has quit IRC | 10:57 | |
| *** purplerbot has joined #openstack-meeting-alt | 10:57 | |
| *** markvoelker has quit IRC | 10:59 | |
| *** rfolco has joined #openstack-meeting-alt | 11:05 | |
| *** yamahata has quit IRC | 11:20 | |
| *** ttsiouts has quit IRC | 11:23 | |
| *** e0ne has quit IRC | 11:24 | |
| *** ttsiouts has joined #openstack-meeting-alt | 11:24 | |
| *** ttsiouts has quit IRC | 11:28 | |
| *** e0ne has joined #openstack-meeting-alt | 11:34 | |
| *** sdake has quit IRC | 11:41 | |
| *** sdake has joined #openstack-meeting-alt | 11:48 | |
| *** janki has quit IRC | 11:51 | |
| *** markvoelker has joined #openstack-meeting-alt | 11:57 | |
| *** igordc has joined #openstack-meeting-alt | 11:58 | |
| *** masahito has joined #openstack-meeting-alt | 11:59 | |
| *** masahito has quit IRC | 12:04 | |
| *** lpetrut has joined #openstack-meeting-alt | 12:17 | |
| *** ttsiouts has joined #openstack-meeting-alt | 12:21 | |
| *** markvoelker has quit IRC | 12:29 | |
| *** armstrong has joined #openstack-meeting-alt | 12:54 | |
| *** e0ne has quit IRC | 13:01 | |
| *** e0ne has joined #openstack-meeting-alt | 13:04 | |
| *** igordc has quit IRC | 13:16 | |
| *** igordc has joined #openstack-meeting-alt | 13:18 | |
| *** bhavikdbavishi has joined #openstack-meeting-alt | 13:20 | |
| *** bhavikdbavishi has quit IRC | 13:22 | |
| *** bhavikdbavishi has joined #openstack-meeting-alt | 13:22 | |
| *** e0ne has quit IRC | 13:25 | |
| *** haleyb has joined #openstack-meeting-alt | 13:25 | |
| *** markvoelker has joined #openstack-meeting-alt | 13:26 | |
| *** e0ne has joined #openstack-meeting-alt | 13:29 | |
| *** e0ne has quit IRC | 13:30 | |
| *** e0ne has joined #openstack-meeting-alt | 13:32 | |
| *** e0ne has quit IRC | 13:34 | |
| *** e0ne has joined #openstack-meeting-alt | 13:35 | |
| *** jcoufal has quit IRC | 13:37 | |
| *** bhavikdbavishi has quit IRC | 13:39 | |
| *** lujinluo has joined #openstack-meeting-alt | 13:53 | |
| *** lbragstad has joined #openstack-meeting-alt | 13:57 | |
| *** markvoelker has quit IRC | 13:58 | |
| lujinluo | #startmeeting neutron_upgrades | 14:00 |
|---|---|---|
| openstack | Meeting started Thu Jan 31 14:00:25 2019 UTC and is due to finish in 60 minutes. The chair is lujinluo. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| *** openstack changes topic to " (Meeting topic: neutron_upgrades)" | 14:00 | |
| openstack | The meeting name has been set to 'neutron_upgrades' | 14:00 |
| lujinluo | o/ | 14:00 |
| lujinluo | I will be waiting for others to join. If you everyone happens to be busy, I will quickly go through the updates we have today for record. | 14:02 |
| lujinluo | #topic OVO | 14:02 |
| *** openstack changes topic to "OVO (Meeting topic: neutron_upgrades)" | 14:02 | |
| lujinluo | #link https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db | 14:02 |
| lujinluo | #link https://review.openstack.org/#/c/544206/ port binding | 14:02 |
| lujinluo | Thanks nate for reviewing the patch! I resolved the merge conflict yesterday and obviously i missed something thus it failed at zuul | 14:03 |
| lujinluo | I will push another patch set to fix it later today | 14:03 |
| lujinluo | and we don't have updates on other patches last week | 14:04 |
| lujinluo | Hopefully i will be able to spend more time on new patches this week | 14:06 |
| lujinluo | #topic open discussion | 14:06 |
| *** openstack changes topic to "open discussion (Meeting topic: neutron_upgrades)" | 14:06 | |
| lujinluo | nate and I are now have a discussion about whether we should pass ovo object in register.notify() | 14:07 |
| lujinluo | an example patch is #link https://review.openstack.org/#/c/624815/ Utilize bulk port creation ops in ml2 plugin | 14:07 |
| lujinluo | to be more specific #link https://review.openstack.org/#/c/624815/28/neutron/db/db_base_plugin_v2.py@1307 | 14:08 |
| *** sdake has quit IRC | 14:08 | |
| lujinluo | we will see where this is going | 14:09 |
| lujinluo | and that's all i have for today | 14:09 |
| lujinluo | ok, let's call it a short meeting today :) | 14:11 |
| *** e0ne has quit IRC | 14:13 | |
| lujinluo | #endmeeting | 14:14 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 14:14 | |
| openstack | Meeting ended Thu Jan 31 14:14:04 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:14 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2019/neutron_upgrades.2019-01-31-14.00.html | 14:14 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/neutron_upgrades/2019/neutron_upgrades.2019-01-31-14.00.txt | 14:14 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2019/neutron_upgrades.2019-01-31-14.00.log.html | 14:14 |
| *** dave-mccowan has joined #openstack-meeting-alt | 14:18 | |
| *** lujinluo has quit IRC | 14:20 | |
| *** sridharg has quit IRC | 14:27 | |
| *** dtrainor has quit IRC | 14:34 | |
| *** dtrainor has joined #openstack-meeting-alt | 14:38 | |
| *** sridharg has joined #openstack-meeting-alt | 14:39 | |
| *** sridharg has quit IRC | 14:39 | |
| *** sdake has joined #openstack-meeting-alt | 14:39 | |
| *** dave-mccowan has quit IRC | 14:41 | |
| *** e0ne has joined #openstack-meeting-alt | 14:45 | |
| *** igordc has quit IRC | 14:48 | |
| *** igordc has joined #openstack-meeting-alt | 14:49 | |
| *** jcoufal has joined #openstack-meeting-alt | 14:53 | |
| *** bswartz has joined #openstack-meeting-alt | 14:55 | |
| *** markvoelker has joined #openstack-meeting-alt | 14:56 | |
| *** ganso has joined #openstack-meeting-alt | 14:57 | |
| tbarron | #startmeeting manila | 15:00 |
| openstack | Meeting started Thu Jan 31 15:00:26 2019 UTC and is due to finish in 60 minutes. The chair is tbarron. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| *** openstack changes topic to " (Meeting topic: manila)" | 15:00 | |
| openstack | The meeting name has been set to 'manila' | 15:00 |
| bswartz | .o/ | 15:00 |
| tbarron | bswartz: hi | 15:00 |
| tbarron | ping ganso | 15:00 |
| tbarron | ping gouthamr | 15:00 |
| tbarron | ping amito | 15:00 |
| amito | hey o/ | 15:00 |
| *** carthaca has joined #openstack-meeting-alt | 15:01 | |
| carthaca | hi | 15:01 |
| tbarron | zhongjun isn't online but recently did a review :) | 15:01 |
| tbarron | hi amito carthaca | 15:01 |
| tbarron | ping vkmc | 15:01 |
| tbarron | ping toabctl | 15:01 |
| toabctl | hey | 15:01 |
| tbarron | ping erlon | 15:01 |
| ganso | hello | 15:02 |
| tbarron | ping tpsilva (wonder if he's still doing manila ...) | 15:02 |
| *** cNilesh has joined #openstack-meeting-alt | 15:02 | |
| tbarron | that's the ping list | 15:02 |
| tbarron | i'll give it a couple minutes ... | 15:02 |
| ganso | tbarron: he doesn't work for NetApp anymore | 15:02 |
| * bswartz hands gouthamr a coffee | 15:03 | |
| tbarron | ganso: that's what I heard, but w'd like canonical folks here too! | 15:03 |
| * tbarron is certainly wearing his upstream hat today | 15:03 | |
| ganso | lol | 15:03 |
| *** carlos_silva has joined #openstack-meeting-alt | 15:04 | |
| tbarron | toabctl: hi! | 15:04 |
| *** armstrong has quit IRC | 15:04 | |
| gouthamr | o/ | 15:04 |
| gouthamr | ty bswartz :) | 15:04 |
| tbarron | ping xyang | 15:04 |
| tbarron | OK let's go | 15:05 |
| tbarron | Hi All! | 15:05 |
| tbarron | #link https://wiki.openstack.org/wiki/Manila/Meetings | 15:05 |
| tbarron | #topic announcements | 15:06 |
| *** openstack changes topic to "announcements (Meeting topic: manila)" | 15:06 | |
| tbarron | cinder meetup is next week in RTP area of North Carolina | 15:06 |
| tbarron | if you are around and can attend talk to jungleboyj | 15:07 |
| tbarron | I have a bunch of conflicts but may do some of it | 15:07 |
| tbarron | the manila zorillas always consider WWCD | 15:07 |
| jungleboyj | :-) | 15:07 |
| tbarron | what would cinder do | 15:07 |
| tbarron | even if we like to do it better :) | 15:07 |
| jungleboyj | If people are interested we would be happy to have you attend. | 15:08 |
| tbarron | That's all I have for announcements. | 15:08 |
| tbarron | jungleboyj: thanks | 15:08 |
| tbarron | Anyone else have announcements? | 15:08 |
| tbarron | #topic share shrinking issue - gouthamr you are up. | 15:09 |
| *** openstack changes topic to "share shrinking issue - gouthamr you are up. (Meeting topic: manila)" | 15:09 | |
| gouthamr | o/ ty tbarron, this was a review question | 15:10 |
| jungleboyj | tbarron: Hope you can make it for some of the meetings. :-) Or post meeting fun. | 15:10 |
| gouthamr | #LINK LINK: https://review.openstack.org/#/c/632615/13/manila/share/drivers/dell_emc/plugins/unity/client.py@309 | 15:10 |
| gouthamr | #LINK: https://review.openstack.org/#/c/632615/13/manila/share/drivers/dell_emc/plugins/unity/client.py@309 | 15:10 |
| bswartz | I would have expected a shrink to fail in this case | 15:11 |
| gouthamr | bswartz: ack, that's what i'm familiar with too | 15:11 |
| tbarron | gouthamr: do they not have the ability to detect this condition? | 15:11 |
| bswartz | Unless we're able to shrink the share all the way down to the desired size, I would expect failure and no resize at all | 15:12 |
| tbarron | gouthamr: in advance of modifying the share ... | 15:12 |
| ganso | it should fail | 15:12 |
| gouthamr | tbarron: per the response, seems like no.. | 15:12 |
| ganso | because the manila DB will believe the share is a 2GB share | 15:12 |
| ganso | while it is not | 15:12 |
| bswartz | Then the user can retry again for a shrink to a larger size | 15:12 |
| tbarron | bswartz: I agree that should be the requirement | 15:13 |
| bswartz | so gouthamr: what is the specific issue we need to decide here? | 15:13 |
| gouthamr | that's it, actually - i was wondering what we'd do here | 15:14 |
| *** IgorYozhikov__ has quit IRC | 15:14 | |
| tbarron | gouthamr: so they can do the shrink, detect that it was partial, do an implicit expand back to the original size, and fail the shrink :) | 15:14 |
| gouthamr | because the committer says they can't detect the usage and fail the operation | 15:14 |
| gouthamr | tbarron: that's one option in case they can't predetermine what the usage on the share is | 15:15 |
| tbarron | gouthamr: I think you should explain the semantics manila expects and propose that if they can't do anything better. | 15:15 |
| gouthamr | ack | 15:15 |
| tbarron | it's kinda like a db transaction rollback. | 15:15 |
| tbarron | back ends with limitations have to do more work | 15:16 |
| *** bhavikdbavishi has joined #openstack-meeting-alt | 15:16 | |
| gouthamr | on those lines, however, how does one recover from that error condition they've put themselves in? | 15:16 |
| *** IgorYozhikov__ has joined #openstack-meeting-alt | 15:16 | |
| gouthamr | "STATUS_SHRINKING_POSSIBLE_DATA_LOSS_ERROR" | 15:16 |
| * gouthamr is sorry for the caps - copy pasta | 15:16 | |
| tbarron | why are they in that condition? I don't understand. | 15:16 |
| tbarron | They are shrinking ... not done yet in manila | 15:17 |
| gouthamr | tbarron: when a user tries to shrink a share beyond the usage size, the 'status' is set to that ^ | 15:17 |
| tbarron | in their back end they shrunk to 3gb instead of 2 | 15:17 |
| *** TxGirlGeek has joined #openstack-meeting-alt | 15:18 | |
| tbarron | their usage is 3gb | 15:18 |
| tbarron | the driver brings the share back to 4gb on their back end | 15:18 |
| gouthamr | afaict, the only ways seem to be: try to shrink again to a valid size, or contact a privileged user (admin) to reset the status | 15:18 |
| tbarron | and failis the shrink | 15:18 |
| *** priteau has quit IRC | 15:19 | |
| gouthamr | tbarron: yes, the driver failing with that error, puts the share in "share_shrinking_possible_data_loss" status | 15:19 |
| tbarron | gouthamr their driver shouldn't fail with that error | 15:19 |
| tbarron | oh | 15:19 |
| tbarron | i see now | 15:19 |
| tbarron | why do we say possible data loss just b/c the shrink failed | 15:20 |
| ganso | gouthamr: so you think that, if they were able to detect and by raising a proper exception, manila should set the share status back to available instead of shrink error, correct? | 15:20 |
| tbarron | if a driver can know it can't do an op b/c it's unsafe and refuses it seems like there should be a different status | 15:21 |
| ganso | tbarron: because the driver raises the exception and we currently (AFAIK) have no way to tell if the shrink has been attempted and failed, or if the driver just detected that it cannot do. | 15:21 |
| tbarron | ganso: yeah I understand now | 15:21 |
| tbarron | seems like we have a limitation then. | 15:21 |
| ganso | tbarron: we should handle different exceptions for this method | 15:21 |
| ganso | tbarron: but we aren't | 15:22 |
| gouthamr | ganso: yeah, would that be weird? we can set a user-message | 15:22 |
| ganso | tbarron: I wouldn't say it is a limitation, we need a code improvement | 15:22 |
| tbarron | so they should also propose some core work for that code improvement | 15:22 |
| ganso | gouthamr: but we need a code improvement to avoid the shrink error status. | 15:22 |
| ganso | gouthamr: user message is not enough | 15:23 |
| tbarron | ganso: one person's limitation is another's enhancement opportunity | 15:23 |
| ganso | tbarron: =) | 15:23 |
| ganso | either way, I think we have several drivers that fall into the same category | 15:24 |
| gouthamr | ganso: why though? i know it is terribly weird if something appears to be happening, and then randomly goes back to "available" | 15:24 |
| *** sdake has quit IRC | 15:24 | |
| tbarron | gouthamr: ganso: today the user will have to go to an admin to get it fixed but they could do a little bit of work and add exception handling for a diffrent exception and it would be better | 15:24 |
| gouthamr | ganso: but the alternatives to get yourselves out of that situation is 1) Shrink the share again to a valid size (which isn't too obvious) | 15:25 |
| gouthamr | 2) go to the admin | 15:25 |
| ganso | tbarron: gouthamr thinks the lack of status change is wierd | 15:25 |
| ganso | I partially agree with that | 15:25 |
| ganso | both solutions have advantages and disadvantages | 15:25 |
| gouthamr | yeah, because you can't do anything else in manila with a share that's actually not in an error state if the driver bailed out correctly | 15:26 |
| ganso | going back to available and triggering a user message sounds good to me | 15:26 |
| tbarron | what's weird is that every kind of error leaves the user needing to go to an admin | 15:26 |
| *** hongbin has joined #openstack-meeting-alt | 15:26 | |
| ganso | tbarron: +1 | 15:26 |
| tbarron | if a back end is smart enough to block an operation and leavae hte user safe we ought to be able to handle that | 15:26 |
| *** lpetrut has quit IRC | 15:27 | |
| tbarron | gouthamr: but we're moving into a bigger issue than thhis particular review | 15:27 |
| gouthamr | tbarron: yes we are | 15:27 |
| * gouthamr its a trap | 15:27 | |
| tbarron | let's have them do the right thing given our current framework | 15:27 |
| ganso | gouthamr you brought a can of worms | 15:27 |
| tbarron | and I'll put the can of worms on next agenda | 15:27 |
| tbarron | next week's agenda | 15:28 |
| tbarron | we can all think about it and have headaches in the mean time | 15:28 |
| *** lseki_ has joined #openstack-meeting-alt | 15:28 | |
| tbarron | gouthamr: you ok with that? | 15:28 |
| gouthamr | haha, works for me - to the current question on the review on what the Unity driver should do, i like the solution and will let them know | 15:28 |
| tbarron | #topic pylint again | 15:29 |
| *** openstack changes topic to "pylint again (Meeting topic: manila)" | 15:29 | |
| tbarron | ganso brought up all the spurious pylint failures last week | 15:29 |
| *** markvoelker has quit IRC | 15:29 | |
| tbarron | but I think we can make some headway | 15:29 |
| tbarron | as an experiment: | 15:29 |
| tbarron | #link https://review.openstack.org/#/c/633576/ | 15:30 |
| tbarron | touches every file, so they all get examined | 15:30 |
| tbarron | and filters out the test files, alembic migrations, etc | 15:30 |
| tbarron | which are full of noise | 15:30 |
| tbarron | the report is small enough that one can find genuine issues | 15:30 |
| tbarron | and fix them | 15:31 |
| tbarron | and some issues that should be handled with # pylint ignore comments | 15:31 |
| tbarron | so I propose that we leave this job to go red for a while | 15:31 |
| tbarron | but make progress on cleaning up the codebase | 15:32 |
| tbarron | That means reviewers should look at it when it's red. | 15:32 |
| tbarron | Only the files touched by the review are examined. | 15:32 |
| gouthamr | tbarron: did things change significantly in pylint 1.9.0, or should we bring back the ignores we had in the old tools/lintstack.py | 15:32 |
| tbarron | Try to clean up the non test code files in the course of a review | 15:32 |
| tbarron | It can be a followup. | 15:32 |
| tbarron | gouthamr: I don't really know but I think the main thing was not so much the ignores as that | 15:33 |
| tbarron | the old job used to work as a ratchet, only looking for newly introduced issues | 15:34 |
| ganso | tbarron: do you plan to merge that "skip workaround"? | 15:34 |
| tbarron | ganso: not until it's more refined | 15:34 |
| bswartz | So these pylint warning are legit? | 15:35 |
| tbarron | bswartz: enough of them that they're worth looking at | 15:35 |
| bswartz | Any new contributors looking for low hanging fruit? | 15:35 |
| tbarron | I've done two reviews fixing stuff already | 15:35 |
| tbarron | Sometimes a fix is just to add pylint ignores, as in | 15:36 |
| bswartz | Yeah but in those cases the warnings aren't legit | 15:36 |
| bswartz | I was asking if it's finding things that we would actually want to fix, absent any lint checker | 15:36 |
| tbarron | #link https://review.openstack.org/#/c/634210/ | 15:36 |
| tbarron | bswartz: we do want to fix duplicate methods in general | 15:36 |
| tbarron | bswartz: just did that in a driver review | 15:37 |
| bswartz | Then why not globally disable E0102? | 15:37 |
| tbarron | bswartz: the author didn't know he had a method by the same name | 15:37 |
| gouthamr | tbarron: afair we used to disable E0102 | 15:37 |
| bswartz | Oh I got it backwards | 15:37 |
| bswartz | I see | 15:37 |
| tbarron | bswartz: b/c usually you want to know and remove the method | 15:37 |
| tbarron | bswartz: but in api code with microversion decorators it's ok | 15:37 |
| gouthamr | oh, can we disable it in a subdirectory? | 15:38 |
| tbarron | bswartz: and only two # pylint ignore comments were missing, we usually do it | 15:38 |
| tbarron | gouthamr: well even in a file you only want to ignore sometimes | 15:38 |
| tbarron | gouthamr: but to your question, yes for pylint but no for our script | 15:39 |
| tbarron | gouthamr: our script picks individual files and runs pylint against them in a way that the .pylintrc directives to skip certain dirs don't have effect | 15:39 |
| tbarron | at least in my experimentation | 15:39 |
| tbarron | that's why I'm modifying the script to ignore subdirs | 15:40 |
| tbarron | we could give the script an ignore-list | 15:40 |
| gouthamr | yes, that'd be helpful | 15:40 |
| carthaca | maybe it it possible to let the microversion decorator do the job to pylint ignore? | 15:40 |
| tbarron | like for the alembic stuff and maybe the wsgi stuff | 15:40 |
| tbarron | carthaca: be my guest :) | 15:41 |
| *** ccamacho has quit IRC | 15:41 | |
| tbarron | I'm hearing lots of good optimization ideas, feel free to propose improvements! | 15:41 |
| tbarron | My point wasn't to declare a policy but rather to give you folks a heads up and engage interest and efforts in cleanup. | 15:41 |
| tbarron | bswartz point that a lot of these are low-hanging fruit is a good one. | 15:42 |
| tbarron | ok | 15:42 |
| tbarron | #topic skip third party jobs on WIP patches?? | 15:42 |
| *** openstack changes topic to "skip third party jobs on WIP patches?? (Meeting topic: manila)" | 15:42 | |
| tbarron | Now that our job queue definitions are in tree it's easy | 15:42 |
| tbarron | to modify .zuul.yaml in WIP patches to run only the jobs relevant to your patch | 15:43 |
| bswartz | Are you talking about 3rd party CI? | 15:43 |
| tbarron | You're working on the lvm driver, just run the lvm job in the check queue until | 15:43 |
| *** priteau has joined #openstack-meeting-alt | 15:43 | |
| tbarron | you're ready to merge. | 15:44 |
| bswartz | Or the upstream CI? | 15:44 |
| tbarron | save resources, run faster. | 15:44 |
| tbarron | bswartz: so far laying groundwork, upstream so far. | 15:44 |
| bswartz | Could the approach be used by 3rd party CIs too? | 15:44 |
| tbarron | bswartz: bingo | 15:44 |
| bswartz | What exactly do I do to .zuul.yaml if I have a WIP patch? | 15:45 |
| tbarron | bswartz: and if a third party job sees WIP status on a patch it would skip | 15:45 |
| gouthamr | bswartz: yank out all the jobs except the one you care about :) | 15:45 |
| tbarron | unless there's an explicit run-netappm etc | 15:45 |
| bswartz | Seems like a good way to economize on compute resources | 15:45 |
| ganso | tbarron: I'm confused. The approach I saw in your pylint patch skips 1st party jobs, not 3rd party | 15:45 |
| gouthamr | bswartz: like this: | 15:46 |
| gouthamr | #LINK https://review.openstack.org/#/c/545695/28/.zuul.yaml | 15:46 |
| tbarron | ganso: cause I don't have a way to skip third pary, that's why I brought this up | 15:46 |
| tbarron | ganso: I think your CI has to check for something and decide to skip | 15:46 |
| bswartz | gouthamr: that doesn't help with skipping 3rd party CI | 15:46 |
| tbarron | ganso: gouthamr's idea is that we also mark the review WIP | 15:47 |
| gouthamr | doesn't, thought your question pertained to our jobs | 15:47 |
| tbarron | ganso: bswartz: your CI would then skp | 15:47 |
| tbarron | skip | 15:47 |
| tbarron | the code poster would do two things: | 15:47 |
| ganso | tbarron: yep, but all the effort to skip 3rd party jobs would be on 3rd parties side, I believe there is nothing we can do right now to achieve that without changes in 3rd parties' sidde | 15:47 |
| tbarron | 1) modify zuul.yaml | 15:47 |
| tbarron | 2) mark the review WIP | 15:47 |
| tbarron | ganso: that's what I'm saying also | 15:48 |
| bswartz | You mean just the word "WIP" in the commit message should skip the jobs? | 15:48 |
| bswartz | Or workflow -1? | 15:48 |
| ganso | why not the workflow -1? | 15:48 |
| gouthamr | we could use Workflow -1 | 15:48 |
| ganso | bswartz: +1 | 15:48 |
| tbarron | bswartz: ganso: gouthamr: that's better | 15:48 |
| gouthamr | that's easier to detect/parse in the older zuul that most third party CIs are running | 15:48 |
| gouthamr | just a simple change to their config | 15:48 |
| bswartz | The problem is you can't workflow -1 until after the review is live | 15:49 |
| bswartz | So there's a race condition | 15:49 |
| gouthamr | bswartz: not really | 15:49 |
| bswartz | I guess as long as 3rd party CIs aren't too fast it doesn't matter | 15:49 |
| gouthamr | bswartz: we encourage third party CIs not to run until upstream CI has voted | 15:49 |
| bswartz | But then it's a totally different approach to modifying .zuul.yaml to disable first party jobs | 15:49 |
| ganso | bswartz: but most 3rd party CIs have their jobs triggered only when Zuul +1's | 15:49 |
| *** ccamacho has joined #openstack-meeting-alt | 15:50 | |
| tbarron | bswartz: yes, it would be nice to have an elegant central solution but I don't have one in hand | 15:50 |
| *** yamahata has joined #openstack-meeting-alt | 15:51 | |
| tbarron | ganso: do you want to adjust netapp to not run if Workflow -1? | 15:51 |
| bswartz | Okay, 2 different approaches are fine | 15:51 |
| ganso | tbarron: when I have some time to, sure | 15:52 |
| * tbarron sends ganso some of gouthamr's free time | 15:52 | |
| * ganso receives plenty of free time! | 15:52 | |
| tbarron | I'm guessing this is a small change for each third party CI that will actually | 15:52 |
| gouthamr | free, what's that? | 15:52 |
| tbarron | save its maintainers time. | 15:52 |
| tbarron | #topic bugs | 15:53 |
| *** openstack changes topic to "bugs (Meeting topic: manila)" | 15:53 | |
| tbarron | jgrosso is on PTO but | 15:53 |
| tbarron | gouthamr has been working with him in his free time | 15:53 |
| gouthamr | it's just as easy with zuulv3: https://zuul-ci.org/docs/zuul/user/config.html#pipeline | 15:53 |
| tbarron | and jgrosso has a spreadsheet of bugs in the works | 15:54 |
| gouthamr | #zuulIsCool | 15:54 |
| tbarron | he's going to email cores and other active reviewers soon | 15:54 |
| tbarron | and we'll post the spreadsheet and a proposed bug backlog reduction plan | 15:55 |
| tbarron | a lot of it will be agreeing to some cleanup and prioiritization | 15:55 |
| tbarron | can't spell ^^^ | 15:55 |
| tbarron | So don't put mail from jgrosso in your spam folder please :) | 15:56 |
| tbarron | gouthamr: anyting you have on $topic? | 15:56 |
| gouthamr | tbarron: nope, that's mostly it - i'm excited to get this work started | 15:56 |
| tbarron | #topic open discussion | 15:56 |
| *** openstack changes topic to "open discussion (Meeting topic: manila)" | 15:56 | |
| tbarron | :) | 15:56 |
| * gouthamr jgrosso is clearly not as lazy as him | 15:56 | |
| tbarron | he's quite organized | 15:57 |
| gouthamr | actually, i suggested he mail openstack-discuss | 15:57 |
| tbarron | gouthamr: agree | 15:57 |
| tbarron | ok, seems like we're through for today. | 15:58 |
| tbarron | Thanks everyone!! | 15:58 |
| bswartz | Perfectly on time | 15:58 |
| tbarron | #endmeeting | 15:58 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 15:58 | |
| openstack | Meeting ended Thu Jan 31 15:58:25 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:58 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/manila/2019/manila.2019-01-31-15.00.html | 15:58 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/manila/2019/manila.2019-01-31-15.00.txt | 15:58 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/manila/2019/manila.2019-01-31-15.00.log.html | 15:58 |
| gouthamr | ping _pewp_ | 15:58 |
| gouthamr | :P | 15:58 |
| * bswartz slaps gouthamr around a bit with a large trout | 15:59 | |
| gouthamr | aw man, just wanted to flip some tables is all | 15:59 |
| bswartz | Oh I forgot that was the bot's name! | 15:59 |
| bswartz | Does it still respond to commands? | 15:59 |
| * gouthamr pages jungleboyj | 15:59 | |
| jungleboyj | What? | 16:00 |
| ganso | @! | 16:00 |
| _pewp_ | ganso (ه’́⌣’̀ه )／ | 16:00 |
| tbarron | beelzebug | 16:00 |
| jungleboyj | You mean pewp bot? | 16:00 |
| jungleboyj | @! | 16:00 |
| _pewp_ | jungleboyj (♦亝д 亝)ﾉ | 16:00 |
| jungleboyj | Use '@' to call him. | 16:00 |
| gouthamr | ah! | 16:00 |
| gouthamr | @!! | 16:00 |
| bswartz | @help | 16:01 |
| *** carthaca has left #openstack-meeting-alt | 16:01 | |
| tbarron | not a very helpful guy | 16:01 |
| gouthamr | :P needs more free time | 16:01 |
| *** rdopiera has quit IRC | 16:18 | |
| *** sdake has joined #openstack-meeting-alt | 16:21 | |
| *** igordc has quit IRC | 16:24 | |
| *** rdopiera has joined #openstack-meeting-alt | 16:25 | |
| *** markvoelker has joined #openstack-meeting-alt | 16:27 | |
| *** ganso has left #openstack-meeting-alt | 16:31 | |
| *** TxGirlGeek has quit IRC | 16:35 | |
| *** cNilesh has quit IRC | 16:38 | |
| *** e0ne has quit IRC | 16:46 | |
| *** priteau has quit IRC | 16:50 | |
| *** lseki_ has left #openstack-meeting-alt | 16:54 | |
| *** markvoelker has quit IRC | 17:00 | |
| *** TxGirlGeek has joined #openstack-meeting-alt | 17:04 | |
| *** kopecmartin is now known as kopecmartin|off | 17:04 | |
| *** iyamahat has joined #openstack-meeting-alt | 17:07 | |
| *** iyamahat has quit IRC | 17:09 | |
| *** iyamahat has joined #openstack-meeting-alt | 17:09 | |
| *** ttsiouts has quit IRC | 17:13 | |
| *** ccamacho has quit IRC | 17:13 | |
| *** ttsiouts has joined #openstack-meeting-alt | 17:13 | |
| *** tssurya has quit IRC | 17:17 | |
| *** ttsiouts has quit IRC | 17:18 | |
| *** gyee has joined #openstack-meeting-alt | 17:19 | |
| *** sdake has quit IRC | 17:28 | |
| *** ccamacho has joined #openstack-meeting-alt | 17:53 | |
| *** iyamahat has quit IRC | 17:54 | |
| *** yamahata has quit IRC | 17:54 | |
| *** bhavikdbavishi has quit IRC | 17:58 | |
| *** bhavikdbavishi has joined #openstack-meeting-alt | 17:59 | |
| *** derekh has quit IRC | 18:00 | |
| *** sdake has joined #openstack-meeting-alt | 18:07 | |
| *** iyamahat has joined #openstack-meeting-alt | 18:07 | |
| *** igordc has joined #openstack-meeting-alt | 18:07 | |
| *** Swami has joined #openstack-meeting-alt | 18:10 | |
| *** iyamahat_ has joined #openstack-meeting-alt | 18:15 | |
| *** iyamahat has quit IRC | 18:18 | |
| *** yamahata has joined #openstack-meeting-alt | 18:26 | |
| *** macza has joined #openstack-meeting-alt | 18:30 | |
| *** bhavikdbavishi has quit IRC | 18:30 | |
| *** e0ne has joined #openstack-meeting-alt | 18:39 | |
| *** panda is now known as panda|off | 18:41 | |
| *** e0ne has quit IRC | 18:48 | |
| *** TxGirlGeek has quit IRC | 18:51 | |
| *** TxGirlGeek has joined #openstack-meeting-alt | 18:53 | |
| *** lpetrut has joined #openstack-meeting-alt | 18:57 | |
| *** bhavikdbavishi has joined #openstack-meeting-alt | 19:21 | |
| *** bhavikdbavishi has quit IRC | 19:23 | |
| *** erlon has quit IRC | 19:23 | |
| *** markvoelker has joined #openstack-meeting-alt | 19:27 | |
| *** TxGirlGeek has quit IRC | 19:48 | |
| *** jcoufal has quit IRC | 19:50 | |
| *** rnoriega has quit IRC | 19:57 | |
| *** rnoriega has joined #openstack-meeting-alt | 19:57 | |
| *** markvoelker has quit IRC | 20:00 | |
| *** TxGirlGeek has joined #openstack-meeting-alt | 20:05 | |
| *** igordc has quit IRC | 20:37 | |
| *** igordc has joined #openstack-meeting-alt | 20:39 | |
| *** rfolco has quit IRC | 20:40 | |
| *** carlos_silva has quit IRC | 20:43 | |
| *** markvoelker has joined #openstack-meeting-alt | 20:57 | |
| *** TxGirlGeek has quit IRC | 21:00 | |
| *** efried has quit IRC | 21:02 | |
| *** efried has joined #openstack-meeting-alt | 21:02 | |
| *** jcoufal has joined #openstack-meeting-alt | 21:02 | |
| *** efried has quit IRC | 21:16 | |
| *** efried has joined #openstack-meeting-alt | 21:17 | |
| *** TxGirlGeek has joined #openstack-meeting-alt | 21:25 | |
| *** iyamahat_ has quit IRC | 21:29 | |
| *** markvoelker has quit IRC | 21:30 | |
| *** radeks_ has quit IRC | 21:35 | |
| *** iyamahat has joined #openstack-meeting-alt | 21:38 | |
| *** lpetrut has quit IRC | 21:54 | |
| *** lpetrut has joined #openstack-meeting-alt | 21:58 | |
| *** ccamacho has quit IRC | 22:10 | |
| *** lpetrut has quit IRC | 22:14 | |
| *** jcoufal has quit IRC | 22:19 | |
| *** macza has quit IRC | 22:23 | |
| *** macza has joined #openstack-meeting-alt | 22:24 | |
| *** IgorYozhikov__ has quit IRC | 22:27 | |
| *** markvoelker has joined #openstack-meeting-alt | 22:27 | |
| *** sdake has quit IRC | 22:30 | |
| *** IgorYozhikov__ has joined #openstack-meeting-alt | 22:36 | |
| *** macza_ has joined #openstack-meeting-alt | 22:40 | |
| *** markvoelker has quit IRC | 22:41 | |
| *** macza has quit IRC | 22:43 | |
| *** sdake has joined #openstack-meeting-alt | 22:45 | |
| *** IgorYozhikov__ has quit IRC | 22:52 | |
| *** IgorYozhikov__ has joined #openstack-meeting-alt | 23:00 | |
| *** whoami-rajat has quit IRC | 23:00 | |
| *** masahito has joined #openstack-meeting-alt | 23:08 | |
| *** masahito has quit IRC | 23:12 | |
| *** slaweq has quit IRC | 23:14 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!