Thursday, 2020-03-26

*** jcoufal has joined #openstack-meeting-alt00:03
*** jcoufal has quit IRC00:06
*** macz_ has joined #openstack-meeting-alt00:22
*** macz_ has quit IRC00:27
*** gyee has quit IRC00:39
*** ysandeep|away is now known as ysandeep00:43
*** jamesmcarthur has quit IRC00:46
*** lbragstad has quit IRC00:46
*** jamesmcarthur has joined #openstack-meeting-alt01:01
*** Liang__ has joined #openstack-meeting-alt01:17
*** jamesmcarthur has quit IRC01:23
*** tetsuro has joined #openstack-meeting-alt01:24
*** ysandeep is now known as ysandeep|rover01:25
*** diablo_rojo has quit IRC02:01
*** mixos has joined #openstack-meeting-alt02:13
*** mixos has quit IRC02:14
*** apetrich has quit IRC03:10
*** diablo_rojo has joined #openstack-meeting-alt03:10
*** jamesmcarthur has joined #openstack-meeting-alt03:18
*** jamesmcarthur has quit IRC03:22
*** jamesmcarthur has joined #openstack-meeting-alt03:27
*** jamesmcarthur has quit IRC03:33
*** jamesmcarthur has joined #openstack-meeting-alt03:34
*** ijw has quit IRC03:39
*** tetsuro has quit IRC03:46
*** tetsuro has joined #openstack-meeting-alt03:49
*** jamesmcarthur has quit IRC04:23
*** jamesmcarthur has joined #openstack-meeting-alt04:26
*** masahito has joined #openstack-meeting-alt04:33
*** jamesmcarthur has quit IRC04:34
*** jamesmcarthur has joined #openstack-meeting-alt04:34
*** jamesmcarthur has quit IRC04:43
*** jamesmcarthur has joined #openstack-meeting-alt04:44
*** links has joined #openstack-meeting-alt05:12
*** maaritamm has joined #openstack-meeting-alt05:17
*** ijw has joined #openstack-meeting-alt05:27
*** diablo_rojo has quit IRC05:39
*** rcernin has quit IRC05:40
*** rcernin has joined #openstack-meeting-alt05:41
*** rcernin has quit IRC05:41
*** rcernin has joined #openstack-meeting-alt05:42
*** rcernin has quit IRC05:42
*** rcernin has joined #openstack-meeting-alt05:47
*** jamesmcarthur has quit IRC05:55
*** jamesmcarthur has joined #openstack-meeting-alt05:57
*** maaritamm has quit IRC05:59
*** rcernin has quit IRC06:02
*** jamesmcarthur has quit IRC06:02
*** rcernin has joined #openstack-meeting-alt06:02
*** rcernin has quit IRC06:05
*** rcernin has joined #openstack-meeting-alt06:05
*** jamesmcarthur has joined #openstack-meeting-alt06:07
*** vhari has joined #openstack-meeting-alt06:09
*** jamesmcarthur has quit IRC06:30
*** maaritamm has joined #openstack-meeting-alt06:35
*** ysandeep|rover is now known as ysandeep|rover|l07:35
*** ysandeep|rover|l is now known as ysandeep|roveraf07:35
*** ysandeep|roveraf is now known as ysandeep|rover|l07:36
*** belmoreira has joined #openstack-meeting-alt07:44
*** vishalmanchanda has joined #openstack-meeting-alt07:56
*** slaweq has joined #openstack-meeting-alt08:01
*** apetrich has joined #openstack-meeting-alt08:03
*** belmoreira has quit IRC08:09
*** toabctl has quit IRC08:30
*** gshippey has joined #openstack-meeting-alt08:31
*** ysandeep|rover|l is now known as ysandeep|rover08:35
*** e0ne has joined #openstack-meeting-alt08:51
*** Liang__ is now known as LiangFang09:03
*** macz_ has joined #openstack-meeting-alt09:10
*** toabctl has joined #openstack-meeting-alt09:14
*** macz_ has quit IRC09:14
*** e0ne_ has joined #openstack-meeting-alt09:25
*** e0ne has quit IRC09:25
*** derekh has joined #openstack-meeting-alt09:37
*** wxy-xiyuan has quit IRC09:39
*** wxy-xiyuan has joined #openstack-meeting-alt09:39
*** e0ne_ has quit IRC09:50
*** e0ne has joined #openstack-meeting-alt09:51
*** rcernin has quit IRC09:51
*** LiangFang has quit IRC10:06
*** macz_ has joined #openstack-meeting-alt10:26
*** macz_ has quit IRC10:30
*** masahito has quit IRC10:31
*** tetsuro has quit IRC10:34
*** e0ne has quit IRC10:59
*** e0ne has joined #openstack-meeting-alt10:59
*** e0ne has quit IRC11:00
*** e0ne has joined #openstack-meeting-alt11:00
*** andrebeltrami has joined #openstack-meeting-alt11:13
*** e0ne_ has joined #openstack-meeting-alt11:46
*** e0ne has quit IRC11:47
*** jcoufal has joined #openstack-meeting-alt11:49
*** e0ne has joined #openstack-meeting-alt11:50
*** e0ne_ has quit IRC11:50
*** e0ne has quit IRC11:53
*** e0ne has joined #openstack-meeting-alt11:54
*** jcoufal has quit IRC12:05
*** e0ne has quit IRC12:14
*** macz_ has joined #openstack-meeting-alt12:14
*** e0ne has joined #openstack-meeting-alt12:14
*** raildo has joined #openstack-meeting-alt12:16
*** lpetrut has joined #openstack-meeting-alt12:18
*** macz_ has quit IRC12:19
*** rfolco has joined #openstack-meeting-alt12:20
*** e0ne has quit IRC12:28
*** e0ne has joined #openstack-meeting-alt12:28
*** jcoufal has joined #openstack-meeting-alt12:30
*** lbragstad has joined #openstack-meeting-alt12:42
*** e0ne_ has joined #openstack-meeting-alt13:41
*** e0ne has quit IRC13:41
*** ysandeep|rover is now known as ysandeep|away14:10
*** jamesmcarthur has joined #openstack-meeting-alt14:51
*** ganso has joined #openstack-meeting-alt14:52
*** sfernand has joined #openstack-meeting-alt14:53
*** jamesmcarthur has quit IRC14:59
*** jamesmcarthur has joined #openstack-meeting-alt15:00
gouthamr#startmeeting manila15:00
openstackMeeting started Thu Mar 26 15:00:29 2020 UTC and is due to finish in 60 minutes.  The chair is gouthamr. Information about MeetBot at http://wiki.debian.org/MeetBot.15:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:00
*** openstack changes topic to " (Meeting topic: manila)"15:00
openstackThe meeting name has been set to 'manila'15:00
dviroelo/15:00
tbarronhey15:00
maaritammo/15:01
gouthamrcourtesy ping: xyang toabctl ganso vkmc amito lseki carloss15:01
lsekio/15:01
carlosshi :)15:01
gouthamrwe'll be missing vhari likely today, i'll drive the bug triage15:01
vhario/15:01
andrebeltramihi15:01
*** macz_ has joined #openstack-meeting-alt15:01
gansohello15:02
*** macz_ has quit IRC15:02
vharigouthamr, ack may need to step out for a bit, ty for driving the bugs on the list today15:02
gouthamro/15:02
gouthamrvhari: sure thing15:02
gouthamragenda for this meeting: https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting15:02
gouthamrThank you all for joining15:02
*** jamesmcarthur_ has joined #openstack-meeting-alt15:02
*** macz_ has joined #openstack-meeting-alt15:02
gouthamrHope you're all doing well in these virulent times15:03
gouthamr#topic Announcements15:03
*** openstack changes topic to "Announcements (Meeting topic: manila)"15:03
gouthamrFirst up, a release time line check15:04
gouthamrUssuri-3/Feature Freeze is in 2 weeks15:04
gouthamrthat deadline also includes Client Library Releases for Ussuri - python-manilaclient and manila-ui15:04
gouthamr#link: https://releases.openstack.org/ussuri/schedule.html#u-ff15:04
gouthamrSo, please give features that touch CLI review preference and we'll discuss them in a bit15:05
gouthamrDoes anyone anticipate anything to slip at this stage? Or any gotchas that we must be aware of?15:05
gouthamrhoping not :)15:06
gouthamrPlease note two new stable branch updates for manila:15:06
gouthamr#link https://releases.openstack.org/train/index.html#train-manila (manila 9.1.1)15:06
gouthamr#link https://releases.openstack.org/stein/index.html#stein-manila (manila 8.1.1)15:06
gouthamrThese were released this morning and include important bug fixes, so users are recommended to update to these versions at the earliest15:07
*** jamesmcarthur has quit IRC15:07
gouthamrcontinuing with release themes, i added manila project deadlines to the Victoria Release schedule15:08
gouthamr#link https://releases.openstack.org/victoria/schedule.html (Victoria cycle schedule + manila deadlines)15:08
vkmco/15:08
* vkmc sneaks in late15:08
gouthamrjust as i said her name15:08
lsekihaha15:08
vkmchehe15:08
dviroellol15:09
gouthamrplease take a look at the deadlines added, and lets discuss them here - these are not set in stone15:09
gouthamralthough i allowed the patch to merge before bringing your attention to it, my bad15:09
gouthamrso, before we move on to our next topic, i'd like to note some peculiarities with the upcoming release15:10
gouthamrIf you missed this email on the ML:15:10
gouthamr#link http://lists.openstack.org/pipermail/openstack-discuss/2020-February/012735.html ([all] Proposed release schedule for Victoria)15:10
* gouthamr Victoria will be a slightly shorter release cycle15:11
gouthamr"Part of the reason for the slightly shorter schedule was to wrap up prior to the Summit"15:11
gouthamrIt's still not as short a cycle as Ocata was15:12
gouthamrbut, i needed to adjust some deadlines15:12
gouthamri'm proposing that Manila's spec freeze be three weeks before M-215:13
gouthamrthe new driver deadline remains M-215:13
gouthamrfeature proposal freeze is two weeks prior to feature freeze15:13
gouthamrgah, three weeks*15:14
gouthamrand you've four weeks between PTG and spec freeze15:14
gouthamrdoes anyone disagree with this proposal?15:14
gouthamryou don't have to - right now, please let me know if you think this can't work for any reason and we'll bring it up in an upcoming meeting and adjust timelines15:15
gouthamrMy last announcement today is for the upcoming TC/PTL elections:15:16
gouthamr#link http://lists.openstack.org/pipermail/openstack-discuss/2020-March/013597.html ([all][elections][ptl][tc] Combined PTL/TC Nominations Kickoff)15:16
gouthamrdunno if you're shy or respectful, but, no-one reached out to me to attempt to be PTL :P15:17
gouthamrso i've a plan brewing to groom folks to step up15:18
gouthamrif no-one self-nominates to lead us, i'll seek self-nominations for the Wallaby release, and i'll mentor you through the Victoria cycle15:18
gouthamr*crickets*15:19
gouthamranywho, it gives me time to document all things that one does being a project team lead and discuss how we can make things better15:19
vkmcwe are not yet done with gouthamr's ptlness15:20
vkmcseems so15:20
vkmcxD15:20
carlossvkmc ++15:20
carloss:D15:20
dviroel:)15:20
gouthamr<315:20
gouthamrAny other announcements for today?15:20
dviroelyes15:20
gouthamrgo for it, dviroel15:20
dviroelwe have new manila contributor from our side15:21
dviroelfelipe_rodrigues, welcome!15:21
lseki🎉15:21
carlosswelcome, felipe_rodrigues :D15:21
felipe_rodriguesThank you!  :)15:21
andrebeltramiWelcome! :p15:21
vkmcwee, welcome!15:21
gouthamrfelipe_rodrigues: welcome, thank you for joining us!15:21
* gouthamr reaches for the zorilla stamp15:21
*** gyee has joined #openstack-meeting-alt15:21
dviroelhope to see lots of patches from felipe_rodrigues soon :)15:22
gouthamrfelipe_rodrigues: are you sure your last name isn't viroel, because we just heard of another felipe around here and i'm always suspicious of dviroel15:22
andrebeltramihahaha!15:23
carlosshehe15:23
lsekihaha15:23
gouthamrnever too young to be a zorilla15:23
* dviroel dviroel already reserved fviroel id for the future15:23
gouthamrdviroel: hah! smart dad15:24
felipe_rodriguesahahaha15:24
gouthamrcool, thank you for making the introduction dviroel15:24
gouthamranything else before we move on?15:24
gouthamr#topic Tracking our work15:24
*** openstack changes topic to "Tracking our work (Meeting topic: manila)"15:24
gouthamr#link https://etherpad.openstack.org/p/manila-ussuri-review-focus (Ussuri cycle review focus etherpad)15:25
gouthamrHow're things looking here? lets do a rollcall15:25
gouthamrSupport query user message by timestamp15:25
gouthamr#link https://review.opendev.org/#/c/706438/ (manila)15:25
gouthamr#link https://review.opendev.org/#/c/708807/ (python-manilaclient)15:25
gouthamrthis has gotten some review attention - any reason to think we can't merge soon'15:26
gouthamri'll take a look at both these today, i don't see any blockers15:26
gouthamr[Unity] Manage/unmanage share server/share/snap15:27
gouthamr#link https://review.opendev.org/#/c/688227/15:27
gouthamra number of us have taken a look at this code, couple of issues we've tried conveying to the author/s15:27
gouthamrtheir CI is currently broken, we'll discuss why in a second15:28
dviroel^ not sure why they don't want to enable manage/unmanage tests on their ci15:28
dviroelshould be possible just to enable them only for this change15:29
carlossyep, dviroel... i've asked that as well in my most recent comment15:29
carlossbut didn't get any response yet15:29
gouthamrcarloss: can you -1 with your comment, might get their attention15:29
carlossgouthamr ok15:29
gouthamrI don't see any reviewers added for the next one15:30
gouthamrGraduate share groups feature15:30
gouthamr#link https://review.opendev.org/#/q/topic:bp/graduate-share-groups-feature+(status:open+OR+status:merged)15:30
gouthamrah ty dviroel15:31
carlossi've got a review from vkmc15:31
carlosson the manila change15:31
* vkmc hides15:31
gouthamrcool, so it's moving fine15:31
vkmcoh it's was a good thing15:31
vkmcok15:31
gouthamrTenant based quotas for share replicas and replica sizes15:31
vkmc:)15:31
gouthamrlol15:32
gouthamr#link https://review.opendev.org/#/q/topic:bp/graduate-share-groups-feature+(status:open+OR+status:merged)15:32
gouthamrgah15:32
gouthamr#link https://review.opendev.org/#/q/topic:bp/limit-share-replicas-per-share+(status:open+OR+status:merged)15:32
gouthamrthis has been getting good reviewer attention too15:32
gouthamrand looks good for the most part, anything to add carloss?15:32
carlossty for reviewing, gouthamr and ty for the review/QA, dviroel15:32
dviroeldidn't  added my comments on that yet, but I'm working on QA'ing15:32
gouthamrawesome15:33
gouthamrCreate share from snapshot in another pool or backend15:33
gouthamr#link https://review.opendev.org/#/q/topic:bp/create-share-from-snapshot-in-another-pool-or-backend+(status:open+OR+status:merged)15:33
gouthamrthis is the most complicated set of changes in my view for our attention15:33
gouthamri'd like some more eyes on it, if possible15:33
gouthamrincluding the driver patch from NetApp:15:33
gouthamr#link https://review.opendev.org/#/c/712642/15:33
gouthamrcarthaca: your review would be valuable too ^15:34
* carthaca bookmarks the 3 links above to do some review15:34
* gouthamr notes how people are reading his mind today15:34
gouthamrthank you carthaca15:35
dviroelandrebeltrami is working on QA NetApp driver also15:35
dviroelso please andrebeltrami, post your comments there too15:35
andrebeltramiSure!15:35
gouthamralright, the rest of the reviews on that etherpad aren't really features, and we have some time to get to them15:35
gouthamrplease correct me if that's not the case15:36
dviroelagree15:36
gouthamrcool, anything else about these reviews before we move on?15:37
gouthamr#topic NetApp Share Server NFS modify implementation (carthaca)15:37
*** openstack changes topic to "NetApp Share Server NFS modify implementation (carthaca) (Meeting topic: manila)"15:37
gouthamr#link: https://etherpad.openstack.org/p/manila-netapp-share-server-nfs-modify (NetApp Share Server NFS modify proposal etherpad)15:37
gouthamrcarthaca: you're up15:37
carthacaHi, thanks15:37
carthacaI hope it is okay I just put this very netapp specific topic on the agenda.15:37
carthacaBut I wanted to collect feedback before coding something that I would never be able to contribute back and had to maintain in my fork forever ^^15:37
carthacaPlease have a look at my etherpad and comment, ask, discuss ;)15:38
*** josecastroleon has joined #openstack-meeting-alt15:38
vkmcjosecastroleon, o/15:38
josecastroleonhi15:38
gouthamrcarthaca: is this entirely netapp specific? or did you intend on generalizing this solution?15:39
gouthamri've a couple of questions15:39
gouthamr"give my customers the possibiility to select certain nfs vserver settings"15:40
carthacawell not all of that options are netapp specific, but I'm not that familiar with the other back ends15:41
gouthamrcarthaca: that isn't entirely congruent with the way share servers are designed15:41
gouthamrcarthaca: users have no control over them15:41
carthacacurrently only via security services15:42
gouthamrcarthaca: yes, those and share networks are the only aspects they can view/manipulate about their share servers15:42
*** jcoufal has quit IRC15:43
gouthamrcarthaca: and these server side settings may not make sense to share networks, security services or individual shares (as you noted)15:43
gouthamrcarthaca: but, the netapp driver already handles something like this today15:43
gouthamri forget how, but, nfs versions can be configured15:44
carthacayes, you can set this in the config15:44
gouthamrah, so its not exactly defined per tenant then15:45
*** priteau has joined #openstack-meeting-alt15:45
carthacabut that would mean I would have to run multiple manila-share services for the same backend or something15:45
gouthamrtrue15:45
gouthamrhmmm, at the outset, it feels like you could define scoped share type extra-specs and set these options when the first share is created15:46
dviroelthis looks like qos, but for share-servers15:46
dviroelcould work in the same way, i guess15:47
gouthamrbut, when the share type extra-specs are manipulated and the next share is created, the driver can choose to either manipulate the existing share server or create a new one15:47
gouthamrdviroel: true, or any other scoped extra-spec that we'd plumb directly to the driver15:48
gouthamrcarthaca: i'm not against generalizing this solution, but we'll probably need to discuss the possibilities/merits in a longer meeting15:49
dviroelmight need a common capability also, to identify backends that support it and have it enabled15:49
dviroelthe rest is up to the driver15:50
gouthamri recall a similar request to determine root squash and all squash nfs options15:51
gouthamri can dig up that discussion from a past PTG to see what ideas were considered, a proposal was not made15:52
*** ijw_ has joined #openstack-meeting-alt15:53
carthacasounds related, I think this option is called ignore-nt-acl-for-root at netapp nfs modify15:53
gouthamrack15:54
gouthamrcool, i think we've some AIs on this carthaca - we'll see what was discussed earlier wrt share server side customizations, please explore if scoped extra-specs can be considered15:54
gouthamrif you're planning on a generalized implementation, a specification would be required15:54
carthacacool, thanks for the feedback15:55
gouthamrif it just pertains to netapp, a spec is not necessary, just file a bp for project tracking15:55
gouthamrcool, we only have 5 minutes15:55
* gouthamr looks into the bug etherpad 15:55
gouthamrdviroel: we might have to look at https://bugs.launchpad.net/manila/+bug/1868586 outside of this meeting15:56
openstackLaunchpad bug 1868586 in Manila "tempest complains 'Share network xxx could not be found.' " [Undecided,New]15:56
gouthamri want to skip bug triage today and give ~3 mins to open discussion15:56
gouthamrtaht okay?15:56
vkmc+115:56
gouthamr#topic Open Discussion15:56
*** openstack changes topic to "Open Discussion (Meeting topic: manila)"15:56
dviroelgouthamr: ok15:56
priteaugouthamr: you can take a bit more time if you need15:56
gouthamrah, thank you priteau - you're kind :) we'll do the triage on our channel15:57
*** ijw has quit IRC15:57
gouthamranyone has anything to discuss?15:57
josecastroleonyes15:57
gouthamrjosecastroleon: o/15:57
josecastroleonwe have just had a nasty behavior on our manila setup15:58
josecastroleonwe have 4 different cephfs backends behind15:59
josecastroleoneach of them mapped to a share type15:59
josecastroleonso scheduling should be easy right?15:59
josecastroleonwe were seeing a continuous increase of scheduling time15:59
*** jamesmcarthur_ has quit IRC16:00
*** jakecoll has joined #openstack-meeting-alt16:00
gouthamrjosecastroleon: oh, weird - do you mind us moving over to #openstack-manila16:00
josecastroleonsure16:00
gouthamrjosecastroleon: thank you, lets continue there16:00
gouthamrthanks all for attending, we'll discuss this scheduling issue on #openstack-manila, please join us there if you can16:01
dviroelthanks!16:01
gouthamr#endmeeting16:01
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/"16:01
openstackMeeting ended Thu Mar 26 16:01:10 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:01
openstackMinutes:        http://eavesdrop.openstack.org/meetings/manila/2020/manila.2020-03-26-15.00.html16:01
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/manila/2020/manila.2020-03-26-15.00.txt16:01
openstackLog:            http://eavesdrop.openstack.org/meetings/manila/2020/manila.2020-03-26-15.00.log.html16:01
*** jamesmcarthur has joined #openstack-meeting-alt16:01
priteau#startmeeting blazar16:01
openstackMeeting started Thu Mar 26 16:01:25 2020 UTC and is due to finish in 60 minutes.  The chair is priteau. Information about MeetBot at http://wiki.debian.org/MeetBot.16:01
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:01
*** openstack changes topic to " (Meeting topic: blazar)"16:01
openstackThe meeting name has been set to 'blazar'16:01
priteau#topic Roll call16:01
*** openstack changes topic to "Roll call (Meeting topic: blazar)"16:01
priteauHi jakecoll16:01
jakecollHi priteau16:02
priteau#topic Ussuri priorities16:02
*** openstack changes topic to "Ussuri priorities (Meeting topic: blazar)"16:02
priteauOne of the priorities for Ussuri is to implement network reservation16:02
priteauThank you jakecoll for resubmitting an updated patch16:03
priteau#link https://review.opendev.org/#/c/668749/16:03
priteauI've started to review but need more time on it to complete16:03
jakecollNo problem. I can update when you are done.16:04
priteauI have two pieces of advice when updating patches16:04
priteau1) use grep (or ripgrep/ack/ag) to find code that might be relevant to comments16:04
priteaufor example I pointed out the vfc code a few days ago but noticed today that there are still a couple of vfc references in the latest one16:05
priteauand 2) check back to the spec to make sure it matches the API we agreed on16:05
jakecollYea, I see the vfc code in the models now. I'll fix that.16:06
jakecollAre the differences in the spec API based on the allocations patch I added?16:07
priteauNo, I think we just made some minor changes to the format16:07
priteauLike, using segmentation_id instead of segment_id16:07
*** ysandeep|away is now known as ysandeep16:08
jakecolloh, I see16:09
priteauIt would be really good if we could have a tempest scenario for this as well, but do you feel like you could write one?16:09
jakecollI've never written one16:10
jakecollWhere are tempest scenarios for blazar?16:10
priteauhttps://opendev.org/openstack/blazar-tempest-plugin/src/branch/master/blazar_tempest_plugin/tests/scenario16:10
priteauMaybe if I can start a template for a new one with the right config, you could extend with some tests16:11
priteauIt will need a custom config to enable the network plugin, plus make sure the neutron config is compatible16:12
jakecollI could potentially. I get a lot of pushback from Kate these days on contributing upstream because of the time commitment.16:12
jakecollWhat is tempest?16:13
priteauTesting framework for OpenStack16:13
priteauhttps://docs.openstack.org/tempest/latest/16:13
jakecollIt's an integration tool. Maybe this is something we can add to our CI/CD pipeline on Chameleon in the future.16:14
priteauThen ignore it for now, I'll ping you if I get something started where you could contribute a few more tests16:14
jakecollok, thanks16:15
priteauYes, you can run it against an OpenStack cloud. I would advise using Rally to manage it16:15
priteauRally: https://docs.openstack.org/rally/latest/16:15
priteauThough it might not play well with Chameleon because it wouldn't know that it needs reservations to launch instances16:15
priteauAnyway, that's getting off topic16:16
*** number80 has quit IRC16:16
priteauAnything else that you would like to highlight? I know there are specs from Jason that I need to finish reviewing16:16
jakecollI pushed a bug fix recently16:16
priteauA very good one indeed16:17
priteauDid you see tetsuro's comment?16:17
priteau> Is it difficult to reproduce the bug in the unit tests by mocking the exception?16:17
jakecollYes16:18
priteauDo you think that's feasible?16:19
jakecollI imagine you could throw an exception with the unit test and then see if it fails. However, I haven't had time to play around with it. Not sure how the tests handle looping calls.16:19
jakecollprobs not actually16:20
jakecoll    def test_start(self):        # NOTE(starodubcevna): it's useless to test start() now, but may be in        # future it become useful        pass16:21
jakecollWe don't even test the start function where the fix is implemented.16:21
priteauThat is some old code!16:22
*** number80 has joined #openstack-meeting-alt16:22
priteauOK, more thought needed16:23
priteauHave you deployed the fix to prod?16:24
jakecollYep, we haven't run into the issue since16:24
priteauAn alternative would be to make sure the exception is handled correctly16:26
priteauDid you figure out where the exception came from exactly?16:26
jakecollIt was a DBConnectionError16:29
priteauSo something that could be thrown by any db code really16:31
*** josecastroleon has quit IRC16:31
priteauOK, thanks for the patch, I will check again with Tetsuro if he can allow it without tests16:31
priteauAnything else?16:31
jakecollNope. Did you get a chance to review Jason's specs?16:32
jakecollHe's back in office tomorrow16:32
jakecollor... online16:32
priteauI reviewed one of them, left some comments16:33
priteauStill need to look at the other one16:33
priteauGood to know that he's back soon16:33
*** jamesmcarthur has quit IRC16:33
*** jamesmcarthur has joined #openstack-meeting-alt16:34
jakecollI believe that is all on my end16:34
priteauSame for me. Thanks for your time!16:35
jakecoll:+1:16:35
jakecollthanks for the comments16:35
priteauBye16:35
priteau#endmeeting16:35
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/"16:35
openstackMeeting ended Thu Mar 26 16:35:51 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:35
openstackMinutes:        http://eavesdrop.openstack.org/meetings/blazar/2020/blazar.2020-03-26-16.01.html16:35
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/blazar/2020/blazar.2020-03-26-16.01.txt16:35
openstackLog:            http://eavesdrop.openstack.org/meetings/blazar/2020/blazar.2020-03-26-16.01.log.html16:35
*** jamesmcarthur_ has joined #openstack-meeting-alt16:36
*** jamesmcarthur has quit IRC16:37
*** ysandeep is now known as ysandeep|away16:41
*** jamesmcarthur_ has quit IRC16:46
*** jamesmcarthur has joined #openstack-meeting-alt16:47
*** jakecoll has quit IRC16:52
*** jamesmcarthur has quit IRC16:53
*** e0ne_ has quit IRC17:12
*** jamesmcarthur has joined #openstack-meeting-alt17:12
*** e0ne has joined #openstack-meeting-alt17:12
*** lpetrut has quit IRC17:21
*** ccamacho has joined #openstack-meeting-alt17:31
*** ccamacho has quit IRC17:32
*** openstack has quit IRC17:49
*** openstack has joined #openstack-meeting-alt17:53
*** ChanServ sets mode: +o openstack17:53
*** derekh has quit IRC18:00
*** jamesmcarthur has quit IRC18:20
*** jamesmcarthur has joined #openstack-meeting-alt18:21
*** links has quit IRC18:23
*** jamesmcarthur has quit IRC18:24
*** jamesmcarthur has joined #openstack-meeting-alt18:24
*** jamesmcarthur has quit IRC18:26
*** jamesmcarthur has joined #openstack-meeting-alt18:27
*** gshippey has quit IRC18:27
*** jamesmcarthur has quit IRC18:36
*** jamesmcarthur has joined #openstack-meeting-alt18:37
*** diablo_rojo has joined #openstack-meeting-alt18:47
*** jamesmcarthur has quit IRC18:50
*** jamesmcarthur has joined #openstack-meeting-alt18:50
*** e0ne has joined #openstack-meeting-alt19:18
*** e0ne has quit IRC19:39
*** jamesmcarthur has quit IRC20:09
*** jamesmcarthur has joined #openstack-meeting-alt20:15
*** e0ne has joined #openstack-meeting-alt20:20
*** e0ne has quit IRC20:29
*** e0ne has joined #openstack-meeting-alt20:29
*** priteau has quit IRC20:41
*** e0ne has quit IRC20:42
*** jamesmcarthur has quit IRC20:45
*** lbragstad has quit IRC20:58
*** jamesmcarthur has joined #openstack-meeting-alt21:08
*** raildo_ has joined #openstack-meeting-alt21:09
*** raildo has quit IRC21:12
*** jamesmcarthur has quit IRC21:30
*** jamesmcarthur has joined #openstack-meeting-alt21:33
*** jamesmcarthur has quit IRC21:59
*** jamesmcarthur has joined #openstack-meeting-alt22:01
*** andrebeltrami has quit IRC22:22
*** sfernand has quit IRC22:23
*** rcernin has joined #openstack-meeting-alt22:25
*** vhari has quit IRC22:34
*** rfolco has quit IRC22:45
*** jamesmcarthur has quit IRC22:46
*** rfolco has joined #openstack-meeting-alt22:46
*** rfolco has quit IRC22:52
*** slaweq has quit IRC22:59
*** jamesmcarthur has joined #openstack-meeting-alt23:02
*** macz_ has quit IRC23:06
*** rcernin has quit IRC23:06
*** rcernin has joined #openstack-meeting-alt23:07
*** rcernin has quit IRC23:07
*** rcernin has joined #openstack-meeting-alt23:08
*** slaweq has joined #openstack-meeting-alt23:11
*** slaweq has quit IRC23:15
*** maaritamm has quit IRC23:29
*** jamesmcarthur has quit IRC23:32
*** tetsuro has joined #openstack-meeting-alt23:33
*** jamesmcarthur has joined #openstack-meeting-alt23:33
*** lbragstad has joined #openstack-meeting-alt23:33
*** tetsuro has quit IRC23:35
*** tetsuro has joined #openstack-meeting-alt23:37
*** jamesmcarthur has quit IRC23:38
*** vishalmanchanda has quit IRC23:39
*** raildo_ has quit IRC23:44
*** tetsuro has quit IRC23:47
*** jamesmcarthur has joined #openstack-meeting-alt23:53

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!