Wednesday, 2020-08-05

*** tetsuro has joined #openstack-meeting-alt00:07
*** jamesmcarthur has quit IRC00:09
*** jamesmcarthur has joined #openstack-meeting-alt00:11
*** jamesmcarthur has quit IRC00:12
*** jamesmcarthur has joined #openstack-meeting-alt00:12
*** jamesmcarthur has quit IRC00:13
*** _erlon_ has quit IRC00:14
*** jamesmcarthur has joined #openstack-meeting-alt00:18
*** jamesmcarthur has quit IRC00:20
*** jamesmcarthur has joined #openstack-meeting-alt00:30
*** gyee has quit IRC00:30
*** jamesmcarthur has quit IRC00:32
*** jamesmcarthur has joined #openstack-meeting-alt00:37
*** jamesmcarthur has quit IRC00:38
*** jamesmcarthur has joined #openstack-meeting-alt00:44
*** tetsuro_ has joined #openstack-meeting-alt00:54
*** tetsuro_ has quit IRC00:56
*** tetsuro_ has joined #openstack-meeting-alt00:56
*** tetsuro has quit IRC00:58
*** tetsuro_ has quit IRC00:59
*** tetsuro has joined #openstack-meeting-alt00:59
*** rfolco has quit IRC01:39
*** dave-mccowan has joined #openstack-meeting-alt01:46
*** jamesmcarthur has quit IRC01:59
*** tetsuro_ has joined #openstack-meeting-alt02:11
*** dave-mccowan has quit IRC02:13
*** apetrich has quit IRC02:14
*** tetsuro has quit IRC02:15
*** diurnalist has joined #openstack-meeting-alt02:20
*** diurnalist has quit IRC02:42
*** diurnalist has joined #openstack-meeting-alt02:44
*** rcernin has joined #openstack-meeting-alt03:07
*** markvoelker has joined #openstack-meeting-alt03:10
*** tetsuro_ has quit IRC03:12
*** markvoelker has quit IRC03:15
*** jamesmcarthur has joined #openstack-meeting-alt03:37
*** jamesmcarthur has quit IRC03:42
*** markvoelker has joined #openstack-meeting-alt03:46
*** markvoelker has quit IRC03:51
*** markvoelker has joined #openstack-meeting-alt03:53
*** diurnalist has quit IRC03:54
*** yamamoto has quit IRC04:02
*** markvoelker has quit IRC04:05
*** vishalmanchanda has joined #openstack-meeting-alt04:15
*** yamamoto has joined #openstack-meeting-alt04:19
*** jamesmcarthur has joined #openstack-meeting-alt04:28
*** jamesmcarthur has quit IRC04:55
*** diurnalist has joined #openstack-meeting-alt05:01
*** lbragstad_ has joined #openstack-meeting-alt05:04
*** diurnalist has quit IRC05:06
*** lbragstad has quit IRC05:07
*** jamesmcarthur has joined #openstack-meeting-alt05:15
*** yaawang has quit IRC06:02
*** yaawang has joined #openstack-meeting-alt06:02
*** rdopiera has joined #openstack-meeting-alt06:03
*** yaawang has quit IRC06:20
*** yaawang has joined #openstack-meeting-alt06:21
*** e0ne has joined #openstack-meeting-alt06:47
*** yaawang has quit IRC06:57
*** yaawang has joined #openstack-meeting-alt06:58
*** jamesmcarthur has quit IRC06:58
*** rcernin has quit IRC06:58
*** jamesmcarthur has joined #openstack-meeting-alt06:59
*** rcernin_ has joined #openstack-meeting-alt07:00
*** jamesmcarthur has quit IRC07:03
*** rcernin_ has quit IRC07:05
*** apetrich has joined #openstack-meeting-alt07:06
*** rcernin has joined #openstack-meeting-alt07:06
*** slaweq has joined #openstack-meeting-alt07:07
*** tosky has joined #openstack-meeting-alt07:38
*** e0ne_ has joined #openstack-meeting-alt07:54
*** e0ne has quit IRC07:54
*** jamesmcarthur has joined #openstack-meeting-alt08:17
*** tosky has quit IRC08:26
*** jamesmcarthur has quit IRC08:27
*** tosky has joined #openstack-meeting-alt08:27
*** ralonsoh has joined #openstack-meeting-alt08:30
*** derekh has joined #openstack-meeting-alt08:51
*** tetsuro has joined #openstack-meeting-alt08:54
*** rcernin has quit IRC09:04
*** rcernin has joined #openstack-meeting-alt09:04
*** rcernin has quit IRC09:05
*** rcernin has joined #openstack-meeting-alt09:05
*** tetsuro has quit IRC09:11
*** yaawang has quit IRC09:35
*** yaawang has joined #openstack-meeting-alt09:36
*** e0ne_ has quit IRC09:42
*** e0ne has joined #openstack-meeting-alt09:43
*** e0ne has quit IRC09:46
*** e0ne has joined #openstack-meeting-alt09:46
*** ralonsoh has quit IRC09:50
*** e0ne has quit IRC09:53
*** e0ne has joined #openstack-meeting-alt09:54
*** whoami-rajat__ has joined #openstack-meeting-alt09:55
*** e0ne has quit IRC10:04
*** e0ne has joined #openstack-meeting-alt10:04
*** e0ne_ has joined #openstack-meeting-alt10:06
*** e0ne has quit IRC10:09
*** e0ne has joined #openstack-meeting-alt10:16
*** e0ne_ has quit IRC10:16
*** rcernin has quit IRC10:23
*** jamesmcarthur has joined #openstack-meeting-alt10:24
*** jamesmcarthur has quit IRC10:31
*** hemna has quit IRC10:38
*** hemna has joined #openstack-meeting-alt10:38
*** yamamoto has quit IRC10:56
*** yamamoto has joined #openstack-meeting-alt11:01
*** ralonsoh has joined #openstack-meeting-alt11:08
*** markvoelker has joined #openstack-meeting-alt11:16
*** raildo has joined #openstack-meeting-alt11:21
*** markvoelker has quit IRC11:25
*** rfolco has joined #openstack-meeting-alt11:51
*** rcernin has joined #openstack-meeting-alt11:57
*** yamamoto has quit IRC11:58
*** rcernin has quit IRC12:02
*** tsmith_ has joined #openstack-meeting-alt12:24
*** derekh has quit IRC12:24
*** yamamoto has joined #openstack-meeting-alt12:26
*** tsmith2 has quit IRC12:27
*** tsmith_ is now known as tsmith212:27
*** yamamoto has quit IRC12:36
*** rcernin has joined #openstack-meeting-alt13:01
*** Adri2000 has quit IRC13:04
*** yamamoto has joined #openstack-meeting-alt13:07
*** derekh has joined #openstack-meeting-alt13:09
*** priteau has joined #openstack-meeting-alt13:09
*** Adri2000 has joined #openstack-meeting-alt13:11
*** enriquetaso has joined #openstack-meeting-alt13:12
*** yamamoto has quit IRC13:15
*** rcernin has quit IRC13:15
*** jamesmcarthur has joined #openstack-meeting-alt13:16
*** ayoung has joined #openstack-meeting-alt13:32
*** raildo has quit IRC13:35
*** raildo has joined #openstack-meeting-alt13:38
*** raildo has quit IRC13:43
*** raildo has joined #openstack-meeting-alt13:43
*** raildo has quit IRC13:44
*** raildo has joined #openstack-meeting-alt13:44
*** raildo_ has joined #openstack-meeting-alt13:46
*** kaisers has joined #openstack-meeting-alt13:47
*** dave-mccowan has joined #openstack-meeting-alt13:49
*** raildo_ has quit IRC13:50
*** rambo_li has joined #openstack-meeting-alt13:56
*** vishakha has joined #openstack-meeting-alt13:57
*** rosmaita has joined #openstack-meeting-alt13:59
*** Liang__ has joined #openstack-meeting-alt13:59
*** Liang__ is now known as LiangFang14:00
*** whoami-rajat has joined #openstack-meeting-alt14:00
rosmaita#startmeeting cinder14:00
openstackMeeting started Wed Aug  5 14:00:18 2020 UTC and is due to finish in 60 minutes.  The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
*** openstack changes topic to " (Meeting topic: cinder)"14:00
openstackThe meeting name has been set to 'cinder'14:00
toskyo/14:00
e0neрш14:00
e0nehi14:00
eharneyhi14:00
*** dave-mccowan has quit IRC14:00
kaiserso/14:00
rajinirhi14:00
LiangFango/14:00
whoami-rajatHi14:00
walshh_hi14:00
rambo_lio/14:00
rosmaitagood turnout14:01
rosmaita#link https://etherpad.openstack.org/p/cinder-victoria-meetings14:01
rosmaitanot much on the agenda today, so i'll wait another minute for stragglers14:01
lsekio/14:01
geguileohi! o/14:02
rosmaitaok, guess that's everybody14:02
enriquetasohi14:02
rosmaitaok, *now* that's everybody14:02
enriquetaso:)14:02
rosmaita#topic updates - virtual mid-cycle14:02
*** openstack changes topic to "updates - virtual mid-cycle (Meeting topic: cinder)"14:02
rosmaitait's next week on Wednesday at this time, so we won't have a team meeting14:03
rosmaitaactually, we will, it will just be the midcycle14:03
rosmaitaanyway: 12 August 2020 14:00-1600 UTC14:03
rosmaitawe'll do it in bluejeans, connection info is in the email14:04
rosmaita#link http://lists.openstack.org/pipermail/openstack-discuss/2020-August/016289.html14:04
rosmaitadon't forget to add topics to the etherpad14:04
rosmaita#link https://etherpad.opendev.org/p/cinder-victoria-mid-cycles14:05
rosmaita#topic updates - monthly video weekly meeting survey14:05
*** openstack changes topic to "updates - monthly video weekly meeting survey (Meeting topic: cinder)"14:05
rosmaitaeveryone who took the survey said we should to a video meeting again14:06
rosmaitaall 4 of them14:06
rosmaitaso our last meeting of August will be video + IRC again14:06
rosmaita#topic updates - gate excitement14:06
*** openstack changes topic to "updates - gate excitement (Meeting topic: cinder)"14:06
rosmaitayou may have noticed that the gates were flakey earlier this week14:06
rosmaitai believe they are back to normal now14:07
rosmaitasmcginnis put up a patch that got the cinder gate moving for a while14:07
rosmaitaand then a longer-term fix was found14:07
rosmaitafor the lower-constraints job failure14:07
rosmaita#link http://lists.openstack.org/pipermail/openstack-discuss/2020-August/016295.html14:07
rosmaitaand, grenade was blowing up in stable/ussuri14:08
rosmaitalooks like that is fixed now too14:08
rosmaita#link https://review.opendev.org/#/c/744753/14:08
rosmaitahopefully that will be all the excitement for this week14:08
rosmaitathat's all from me -- anyone have any news they'd like to share?14:08
rosmaita#topic Release notes for bugs14:09
*** openstack changes topic to "Release notes for bugs (Meeting topic: cinder)"14:09
rosmaitageguileo: that's you14:10
geguileothanks14:10
geguileowe tend to add bug numbers in the release notes14:10
geguileobut not always14:10
geguileoand some of us just add the number, and others also add the link to the LP bug14:10
geguileoI think we should reach a consensus on what we want to have14:11
geguileofor consistency purposes14:11
e0neIMO, link to launchpad and some brief description will be great14:11
rosmaitai agree14:11
geguileook, whoami-rajat pointed it out in some of his reviews14:11
toskywould it make sense to see if reno could parse and expand the launchpad link automatically from a keyword like lpnnnnn ?14:11
tosky(maybe it's already there)14:11
geguileotosky: oh, if that existed it would be great14:12
rosmaitai don't think it's already there, but it's a good idea14:12
geguileobut in the meantime I think we kind of agree that having the link is what we want14:12
rosmaitabut for now, let's do it by hand14:12
whoami-rajatgeguileo, yep, rosmaita pointed that out in my reviews and I've been using that since :)14:12
eharneythat may get messy if it's a bug on multiple projects14:12
geguileook, then I think we can start doing that and mentioning it in the reviews14:12
geguileoI think we have a reno page in our docs14:13
geguileoif we do, I'll mention this resolution there14:13
rosmaitasounds good14:13
rosmaitawhile we are on this topic14:13
geguileook14:13
rosmaitai try to point this out in reviews, but it would be good for driver change renos to begin with the driver name14:14
rosmaitawould make it easier for operators to find it14:14
rosmaitasomething like14:14
rosmaitaFoo driver: fixed the bar in the baz.14:14
geguileosounds good14:15
geguileoand we could do that in the first line of commit messages as well14:15
rosmaitaor Foo driver: `Bug #1234 <http...>`_: fixed the bar in the baz14:15
openstackbug 1234 in Launchpad itself "Gina is an unmaintainable mess of command line options, environment variables and shell scripts" [Medium,Fix released] https://launchpad.net/bugs/1234 - Assigned to Daniel Henrique Debonzi (debonzi)14:15
whoami-rajatmakes sense14:15
rosmaitawell at least bug 1234 is fixed14:15
whoami-rajat:D14:15
geguileolol14:16
lsekilol14:16
rosmaitaok, that will really improve the release notes14:16
rosmaitathanks, geguileo14:16
rosmaitaany other observations?14:16
geguileoI'll propose a format in the patch and we can decide how we exactly want it14:16
geguileothanks everyone :-)14:16
rosmaitaexcellent14:16
rosmaita#topic what to return when a request fails because the default volume type doesn't exist14:17
*** openstack changes topic to "what to return when a request fails because the default volume type doesn't exist (Meeting topic: cinder)"14:17
e0nenot a 500 :)14:17
rosmaitathis is something whoami-rajat is working on now14:17
rosmaitai think this is a legitimate 500 though14:17
rosmaitait's a server side mis-configuration14:17
whoami-rajatspecifically create volume request fails14:17
eharney500 sounds right for that case14:18
rosmaitaor anything that needs to access the default volume type14:18
rosmaitathe situation is that we are now requiring the default_volume_type to be set14:18
rosmaitabut if the operator has a typo14:18
rosmaitathen it can't be found14:18
rosmaitaand since we don't allow untyped volumes since traing14:18
rosmaita*train14:18
*** jamesmcarthur has quit IRC14:18
rosmaitawe fail the request14:18
e0newe've got InvalidConfigurationValue, 400 (https://github.com/openstack/cinder/blob/master/cinder/exception.py#L249)14:18
e0nebut 400 doesn't looks good too:(14:19
eharney400 indicates that the problem is with the request from the user, which doesn't fit this14:19
e0neeharney: +1. that's why I don't like this option14:20
rosmaitai guess you could stretch things and say if the user calls the admin and complains before making the next request, that's a 40014:20
rosmaitabut it really seems it's a server-side thing14:20
e0nerosmaita: +114:21
rosmaitahopefully it won't happen a lot14:21
e0neI don't like 500 errors but I can't propose a good enough solution :(14:21
whoami-rajatproviding a wrong volume type in request is good for a 400 but sadly returns 40414:21
whoami-rajathere 500 makes sense to me as well14:21
rosmaitano, if the requestor makes a mistake, should be 4xx14:22
rosmaitabecause they can fix the request14:22
whoami-rajatyep, that was a different topic, just using that to explain why 500 makes sense here14:23
rosmaitaok, i misunderstood14:23
rosmaitaok, looks like there's support for this to be a 500 ?14:23
eharneyyes14:23
whoami-rajat+114:23
rosmaitaok, well hopefully operators will be careful in their configuration and won't see this very often14:24
rosmaita#topic Support volume re-image14:25
*** openstack changes topic to "Support volume re-image (Meeting topic: cinder)"14:25
rosmaita#link https://review.opendev.org/#/c/606346/14:25
rosmaitarambo_li: that's you14:25
rambo_liyes14:25
rosmaitathis is a blast from the past14:26
rambo_liyeah14:26
rambo_libut the nova rebuild is need this14:26
rambo_liI well hopefully this reimage api will merged in Victoria14:28
rosmaitai don't think anyone is philosophically opposed to this, so it's mostly a matter of getting reviews14:30
rosmaitawe should probably add some tests to cinder-tempest-plugin to verify the functionality14:31
eharneyi am still skeptical about allowing the reimage operation on volumes with status "error"14:31
rosmaitathat does seem a bit odd14:32
eharneyi think it will just not work in many cases14:32
*** redrobot has joined #openstack-meeting-alt14:32
rambo_lieharney: the volume status is "error" means the volume data is bad, so we can reimage this, any problem?14:34
eharneyit could mean many different things, including, there isn't actually a volume14:35
eharney"error" indicating anything about the data on the volume is probably the rare case14:35
rosmaitarambo_li: what's the status of the nova side of this?14:36
*** geguileo has quit IRC14:36
*** geguileo has joined #openstack-meeting-alt14:37
rambo_lithe volume is reserved14:37
rambo_liwhen do the rebuild action14:38
rosmaitaok, let's discuss this more at the midcycle next week14:38
rosmaitai don't remember that stein spec at all and need to read through it14:38
rosmaitaand also the comments on the nova spec14:38
rosmaita#link https://review.opendev.org/#/c/739349/1114:38
rosmaitaanything else?14:39
rosmaita#topic generic NFS online extend14:40
* jungleboyj sneaks in late.14:40
*** openstack changes topic to "generic NFS online extend (Meeting topic: cinder)"14:40
rosmaitalseki: you're up14:40
lsekio/14:40
lsekiso, currently generic NFS fails to extend an attached volume14:41
lsekiand I'm working on a fix that lets Nova do the actual extend operation14:41
lsekithe problem is: what if nova fails to do this extend operation14:41
lsekithe volume would remain with the original size, but the volume size would get inconsistent in Cinder DB14:42
lsekiLee Yarwood from Nova proj told that Nova creates an action14:42
lseki#link https://github.com/openstack/nova/blob/49c3ac7dfa7aca5504f9d19958ff82a40e47f5a1/nova/compute/api.py#L5316-L532314:42
lsekiwhich Cinder could poll for, to check if it succeeded or not14:43
lsekiI'm not familiar with polling Nova things from Cinder14:43
lsekiso I'd like to know if there's a similar code that I could take as an example14:43
smcginnisWe generally don't. We don't want to have tight coupling with Nova, as much as possible.14:44
eharneyi'm not sure that cinder currently has any code that consumes events from nova14:44
eharneywe do have code to trigger events there in the other direction, presumably doing this would use a similar infrastructure14:45
whoami-rajati think we do some sort of polling for snapshot of attached volumes?14:47
eharneyin that case, nova updates a value that cinder can see in the db, we don't have to poll nova14:48
rosmaitacan we do the same thing here?14:49
rosmaitai am not familiar with that code14:49
eharneywe shouldn't copy the way the snapshot update happens, because it's a hacky mess14:50
eharneywould probably be easier to just the nova events API14:50
rosmaitaok, i am anti-hacky-mess14:50
whoami-rajathttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/remotefs.py#L1677-L172114:51
eharneyin this case, what is it we're waiting for nova to do exactly?14:52
whoami-rajatbut as Eric said, we should do the it optimally14:52
eharneyi guess libvirt is just extending the file14:53
LiangFanglseki: could we let cinder give nova a callback, when nova finished, it call callback, and the cinder update DB? need to let nova handle callback14:53
lsekihmm do Cinder & Nova have such callback mechanism?14:55
whoami-rajateharney, waiting for the blockRebase or blockCommit to complete? i think it updates a field in snapshot (progress) to 90 when it completes14:55
eharneywhoami-rajat: that's for snapshots, not for extend14:55
whoami-rajateharney, oh, i thought you asked for snapshots case, my bad14:56
rosmaitalseki: can you map out how you see this working on an etherpad or something, and we can discuss more next week?  (you can send something to the ML when your etherpad is up, and we can look earlier and all be ready for a discussion)14:56
eharneyplease test whether this works with encryption and whether it works with volumes attached to instances that are shutoff14:56
rosmaitasounds like on the nova side, lyarwood at least is in favor of polling the server actions API14:56
eharneyiirc the encryption case is already known to have problems14:57
lsekirosmaita: sure, I will write the alternatives14:57
rosmaitalseki: the extend is initiated from the cinder side, is that correct?14:57
rosmaitaso we could reject unsupported configurations14:58
lsekirosmaita: correct14:58
rosmaitaok, that sounds good14:59
rosmaitasorry everyone, looks like we are out of time for open discussion14:59
whoami-rajatthanks!14:59
rosmaitafeel free to talk in #openstack-cinder if you have something on your mind14:59
LiangFangI rememer resize is initiate from Nova, extend volume is initiate from cinder14:59
lsekity folks!14:59
rosmaita#endmeeting14:59
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/"14:59
openstackMeeting ended Wed Aug  5 14:59:53 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)14:59
openstackMinutes:        http://eavesdrop.openstack.org/meetings/cinder/2020/cinder.2020-08-05-14.00.html14:59
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/cinder/2020/cinder.2020-08-05-14.00.txt14:59
openstackLog:            http://eavesdrop.openstack.org/meetings/cinder/2020/cinder.2020-08-05-14.00.log.html14:59
e0ne#startmeeting horizon15:00
openstackMeeting started Wed Aug  5 15:00:47 2020 UTC and is due to finish in 60 minutes.  The chair is e0ne. Information about MeetBot at http://wiki.debian.org/MeetBot.15:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:00
*** openstack changes topic to " (Meeting topic: horizon)"15:00
openstackThe meeting name has been set to 'horizon'15:00
e0nehi15:00
vishalmanchandahi15:01
*** diurnalist has joined #openstack-meeting-alt15:01
e0nevishalmanchanda: let's wait few minutes more15:02
amotokihi, beer time :)15:02
vishalmanchandasure.15:02
e0neamotoki: you're lucky enough. it's too early for beer for me15:02
vishalmanchanda🙂15:03
amotokiI'm off today, so it is not surprising even if I have beer in your time :p15:03
e0neok. let's start15:04
vishalmanchandae0ne: Do we have mid-cycle meeting?15:04
e0ne#topic virtual mid-cycle15:04
*** openstack changes topic to "virtual mid-cycle (Meeting topic: horizon)"15:04
e0newe've got a very few responses in the poll15:05
e0nehttps://doodle.com/poll/dkmsai49v4zzpca215:05
e0neso I don't I'm not sure what to do15:06
e0neit's up to you to decide15:06
e0nedo we want to have it this week or move later this cycle?15:07
amotokiI just added my vote for case we have it this week15:08
vishalmanchandaWe can do it tomorrow15:09
e0nelooks like tomorrow it the best date for everybody15:09
e0newe can do a call tomorrow to catch-up current release priorities15:11
vishalmanchandacool.15:11
*** ayoung has quit IRC15:11
e0neamotoki: what about you?15:11
amotokiI am okay with tomorrow15:12
*** ayoung has joined #openstack-meeting-alt15:12
e0negood. I'll send an update to the mailing list once I'll manage what software will we use15:12
vishalmanchandaat 13 UTC.15:12
amotokiwhich time slots? 3UTC or 13UTC?15:13
e0ne13.00 UTC15:13
*** LiangFang has quit IRC15:13
e0neit got more positive votes15:13
amotokisounds good. I haven't checked vote result.15:14
e0ne#topic Open Discussion15:16
*** openstack changes topic to "Open Discussion (Meeting topic: horizon)"15:16
e0neI'm skipping updates because there are no updates from me15:16
e0neand Victoria priorities will be discussed tomorrow15:17
vishalmanchandaamotoki: Could you take a look at this patch https://review.opendev.org/#/c/734161/15:17
vishalmanchandaIvan already voted.15:17
amotokivishalmanchanda: sure but you need to keep in mind that I am off this week15:18
vishalmanchandaLet me know if any concern about this patch. I will try to fix asap.15:18
vishalmanchandaamotoki: yeah.15:18
vishalmanchandae0ne: amotoki : Also i need your attention on this patch https://review.opendev.org/#/c/708069/15:19
vishalmanchandaPlease see my comment on P.S 1515:20
vishalmanchandasorry:(.15:20
*** rambo_li has quit IRC15:20
vishalmanchandaIt is already fixed.15:21
e0nevishalmanchanda: according to docstring. here is a good example: https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html15:21
*** ayoung has quit IRC15:22
e0nevishalmanchanda: and here is a pep: https://www.python.org/dev/peps/pep-0257/15:22
vishalmanchandae0ne: thanks for the link i will take a look.15:22
vishalmanchandaActually I have left some comments on P.S 18 for this patch https://review.opendev.org/#/c/708069/15:23
vishalmanchandaI am referring this situation https://pasteboard.co/JkaA9tX.png15:23
vishalmanchandaWe have fix this in plugins as well.15:24
vishalmanchandahttps://review.opendev.org/#/c/708069/18/openstack_dashboard/dashboards/admin/volume_types/forms.py@13315:24
*** ayoung has joined #openstack-meeting-alt15:24
e0nesorry, I didn't get what do you mean15:25
vishalmanchandaI am trying to say we have to change this https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/volume_types/forms.py#L13215:28
vishalmanchandaexceptions.handle(15:28
vishalmanchanda        request, _('Unable to create encrypted volume15:28
vishalmanchanda        type.'), redirect= redirect)15:28
vishalmanchandabasically removes ex from here otherwise it looks like this https://pasteboard.co/JkaA9tX.png15:29
e0neyep, we need to remove it15:30
vishalmanchandayeah that's what i am trying to say.15:30
e0neand probably, we have to it in plugins too:)15:30
e0ne:(15:30
vishalmanchandaWe have to do similar changes in plugins15:30
*** tosky has quit IRC15:31
e0nevishalmanchanda: now I understand your comment15:31
*** jamesmcarthur has joined #openstack-meeting-alt15:31
vishalmanchandaSo we need be very careful about this patch https://review.opendev.org/#/c/708069/15:33
vishalmanchandaI mean when to merge it.15:33
e0ne+115:33
vishalmanchandabecause let's say if we merge it in horizon for Victoria cycle then we need to same changes for plugins in the same cycle otherwise it looks ugly.15:34
e0nehow many plugins are affected?15:36
vishalmanchandaI have not checked it yet15:36
e0neit could be a blocker15:36
vishalmanchandabut we have around 30 horizon plugins. I hope changes should be less.15:37
e0nee.g. if we need to fix only 3-5 plugins - we can do it fast15:37
e0neif we have to fix 10-15+ plugins - it will be painful15:37
vishalmanchandae0ne: ok I will check after the meeting .15:38
e0nethanks15:38
vishalmanchandaIn that case we also need to send a mail on open-discuss about this change.15:38
amotokiwe might check a caller in exceptions.handle() and determine if the new feature shoudl be enabled.15:38
e0neamotoki: it could be a pretty good workaround15:39
amotokiwe can disable it until we complete a plugin supports it (i means we need to drop exception messages from the base message)15:39
amotokianother question: do we want to cover JS messages in this bp?15:40
vishalmanchandasounds good.15:40
vishalmanchandaamotoki: TBH I haven't thought of it yet.15:41
vishalmanchandabut we can take a look.15:41
*** lbragstad_ is now known as lbragstad15:42
*** rosmaita has left #openstack-meeting-alt15:43
amotokiregardless of whether we cover JS side soon or not, we need to take it into account for consistency.15:43
e0neamotoki: JS side will be good too15:43
amotokie0ne: what do you mean by "good"?15:44
e0neI don't want to have more feature gaps between django and angular-based views15:44
e0neamotoki: I mean it would be great to have it in15:44
*** slaweq_ has joined #openstack-meeting-alt15:45
amotokie0ne: got it. we are in a same page15:45
e0ne:)15:45
*** slaweq has quit IRC15:45
*** slaweq_ is now known as slaweq15:45
vishalmanchandathen I will check how to cover Js/angular sides as well.15:45
e0nevishalmanchanda: thank you, Vishal!15:47
vishalmanchandae0ne: yw.15:47
e0newe've got 10 minutes more15:50
vishalmanchandaI have noting more to discuss.15:51
amotokime either15:52
e0nethanks everybody for your contributions! see you tomorrow!15:53
vishalmanchandabye.15:54
amotokibye15:54
e0ne#endmeeting15:54
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/"15:54
openstackMeeting ended Wed Aug  5 15:54:26 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:54
openstackMinutes:        http://eavesdrop.openstack.org/meetings/horizon/2020/horizon.2020-08-05-15.00.html15:54
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/horizon/2020/horizon.2020-08-05-15.00.txt15:54
openstackLog:            http://eavesdrop.openstack.org/meetings/horizon/2020/horizon.2020-08-05-15.00.log.html15:54
*** ayoung has quit IRC15:54
*** e0ne has quit IRC15:56
*** ayoung has joined #openstack-meeting-alt15:57
*** diurnalist has quit IRC16:12
*** diurnalist has joined #openstack-meeting-alt16:17
*** markvoelker has joined #openstack-meeting-alt16:27
*** vhari has joined #openstack-meeting-alt16:28
*** tosky has joined #openstack-meeting-alt16:29
*** enriquetaso has quit IRC16:37
*** gyee has joined #openstack-meeting-alt16:48
*** derekh has quit IRC17:00
*** e0ne has joined #openstack-meeting-alt17:09
*** yamamoto has joined #openstack-meeting-alt17:14
*** yamamoto has quit IRC17:18
*** priteau has quit IRC17:38
*** enriquetaso has joined #openstack-meeting-alt17:40
*** raildo has quit IRC18:03
*** raildo has joined #openstack-meeting-alt18:08
*** e0ne has quit IRC18:10
*** raildo_ has joined #openstack-meeting-alt18:11
*** ralonsoh has quit IRC18:12
*** raildo_ has quit IRC18:13
*** ayoung has quit IRC18:20
*** ayoung has joined #openstack-meeting-alt18:23
*** e0ne has joined #openstack-meeting-alt18:26
*** dave-mccowan has joined #openstack-meeting-alt18:40
*** raildo has quit IRC18:46
*** raildo has joined #openstack-meeting-alt18:48
*** e0ne has quit IRC18:51
*** enriquetaso has quit IRC18:52
*** tosky has quit IRC19:39
*** tmazur has joined #openstack-meeting-alt19:41
*** tmazur has quit IRC19:43
*** dave-mccowan has quit IRC19:45
*** jamesmcarthur has quit IRC19:49
*** jamesmcarthur has joined #openstack-meeting-alt19:49
*** jamesmcarthur has quit IRC19:54
*** jamesmcarthur has joined #openstack-meeting-alt20:21
*** vishalmanchanda has quit IRC20:25
*** enriquetaso has joined #openstack-meeting-alt20:25
*** gyee has quit IRC20:36
*** gyee has joined #openstack-meeting-alt20:38
*** raildo has quit IRC20:40
*** raildo has joined #openstack-meeting-alt20:40
*** smcginni1 has joined #openstack-meeting-alt20:47
*** smcginnis has quit IRC20:50
*** smcginni1 is now known as smcginnis20:50
*** raildo has quit IRC20:57
*** ayoung has quit IRC21:10
*** slaweq has quit IRC21:18
*** enriquetaso has quit IRC21:20
*** gyee has quit IRC21:24
*** tosky has joined #openstack-meeting-alt21:25
*** gyee has joined #openstack-meeting-alt21:25
*** whoami-rajat has quit IRC21:33
*** vishakha has quit IRC21:36
*** rcernin has joined #openstack-meeting-alt21:36
*** rdopiera has quit IRC21:41
*** yamamoto has joined #openstack-meeting-alt21:45
*** adam_g has quit IRC21:52
*** markmcclain has quit IRC21:53
*** rcernin has quit IRC22:03
*** yamamoto has quit IRC22:11
*** rcernin has joined #openstack-meeting-alt22:17
*** rcernin has quit IRC22:40
*** rcernin has joined #openstack-meeting-alt22:40
*** rcernin has quit IRC22:40
*** rcernin has joined #openstack-meeting-alt22:44
*** jamesmcarthur has quit IRC22:59
*** markmcclain has joined #openstack-meeting-alt23:12
*** adam_g has joined #openstack-meeting-alt23:12
*** tosky has quit IRC23:14
*** diurnalist has quit IRC23:24
*** ayoung has joined #openstack-meeting-alt23:26
*** irclogbot_0 has quit IRC23:34
*** irclogbot_0 has joined #openstack-meeting-alt23:37

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!