Wednesday, 2020-09-09

*** tsmith2 has quit IRC00:33
*** Liang__ has joined #openstack-meeting-alt01:23
*** tetsuro has joined #openstack-meeting-alt01:23
*** gyee has quit IRC01:25
*** tetsuro has quit IRC01:25
*** ricolin_ has joined #openstack-meeting-alt01:31
*** wxy has joined #openstack-meeting-alt01:31
*** Liang__ is now known as LiangFang02:08
*** enriquetaso has quit IRC02:27
*** rcernin has quit IRC02:29
*** zzzeek has quit IRC03:18
*** zzzeek has joined #openstack-meeting-alt03:19
*** rcernin has joined #openstack-meeting-alt03:29
*** zzzeek has quit IRC03:55
*** zzzeek has joined #openstack-meeting-alt03:58
*** belmoreira has joined #openstack-meeting-alt04:23
*** carthaca has quit IRC04:32
*** zzzeek has quit IRC04:45
*** zzzeek has joined #openstack-meeting-alt04:48
*** zzzeek has quit IRC05:17
*** zzzeek has joined #openstack-meeting-alt05:18
*** vishalmanchanda has joined #openstack-meeting-alt06:14
*** LiangFang has quit IRC06:17
*** Liang__ has joined #openstack-meeting-alt06:18
*** ralonsoh has joined #openstack-meeting-alt06:34
*** e0ne has joined #openstack-meeting-alt06:35
*** e0ne has quit IRC06:39
*** slaweq has joined #openstack-meeting-alt06:51
*** jtomasek has joined #openstack-meeting-alt07:01
*** rdopiera has joined #openstack-meeting-alt07:27
*** rdopiera has quit IRC07:31
*** rdopiera has joined #openstack-meeting-alt07:32
*** tosky has joined #openstack-meeting-alt07:57
*** Liang__ is now known as LiangFang08:00
*** Roamer` has joined #openstack-meeting-alt08:07
*** slaweq has quit IRC08:20
*** rcernin has quit IRC08:20
*** apetrich has joined #openstack-meeting-alt08:26
*** slaweq has joined #openstack-meeting-alt08:29
*** derekh has joined #openstack-meeting-alt08:32
*** apetrich has quit IRC08:39
*** carthaca has joined #openstack-meeting-alt08:39
*** ianychoi__ has quit IRC08:40
*** apetrich has joined #openstack-meeting-alt08:44
*** slaweq has quit IRC08:49
*** LiangFang has quit IRC09:29
*** e0ne has joined #openstack-meeting-alt09:32
*** ricolin_ has quit IRC09:38
*** ralonsoh has quit IRC10:01
*** ralonsoh has joined #openstack-meeting-alt10:02
*** priteau has joined #openstack-meeting-alt10:43
*** rcernin has joined #openstack-meeting-alt10:53
*** rcernin has quit IRC11:28
*** raildo has joined #openstack-meeting-alt11:30
*** lkoranda has joined #openstack-meeting-alt11:36
*** rcernin has joined #openstack-meeting-alt11:45
*** lkoranda has quit IRC11:52
*** lkoranda has joined #openstack-meeting-alt11:53
*** rfolco has joined #openstack-meeting-alt12:02
*** jhesketh has quit IRC12:17
*** jhesketh has joined #openstack-meeting-alt12:17
*** derekh has quit IRC12:31
*** andrebeltrami has joined #openstack-meeting-alt12:36
*** rcernin has quit IRC12:41
*** enriquetaso has joined #openstack-meeting-alt12:56
*** derekh has joined #openstack-meeting-alt13:06
*** tmazur has joined #openstack-meeting-alt13:14
*** rcernin has joined #openstack-meeting-alt13:15
*** kaisers_ has joined #openstack-meeting-alt13:22
*** jhesketh has quit IRC13:31
*** rcernin has quit IRC13:41
*** sfernand has joined #openstack-meeting-alt13:41
*** vishakha has joined #openstack-meeting-alt13:47
*** thgcorrea has joined #openstack-meeting-alt13:54
*** Liang__ has joined #openstack-meeting-alt13:55
*** Liang__ is now known as LiangFang13:55
*** rosmaita has joined #openstack-meeting-alt13:59
*** whoami-rajat__ has joined #openstack-meeting-alt13:59
rosmaita#startmeeting cinder14:00
openstackMeeting started Wed Sep  9 14:00:31 2020 UTC and is due to finish in 60 minutes.  The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
*** openstack changes topic to " (Meeting topic: cinder)"14:00
openstackThe meeting name has been set to 'cinder'14:00
rosmaita#topic roll call14:00
jungleboyjo/  Kind of ... Double booked.14:00
*** openstack changes topic to "roll call (Meeting topic: cinder)"14:00
toskyo/14:00
walshh_hi14:00
whoami-rajat__Hi14:00
kaisers_hi14:00
LiangFanghi14:00
rosmaitajungleboyj: that's fine ... you are back, which is the key thing14:00
e0nehi14:01
sfernandhi14:01
jungleboyj:-)  Yeah, still trying to catch up on e-mail.  :-)14:01
rosmaitagood turnout14:01
enriquetasohi14:01
rosmaita#link https://etherpad.opendev.org/p/cinder-victoria-meetings14:01
lsekio/14:02
dviroelhi14:02
rosmaitaok, let's get started14:02
rosmaita#topic updates - check job failures update14:03
*** openstack changes topic to "updates - check job failures update (Meeting topic: cinder)"14:03
*** slaweq has joined #openstack-meeting-alt14:03
rosmaitathere was a code change to tempest on 4 september that broke us14:03
rosmaitaparticularly cinder-tempest-plugin-lvm-lio-barbican and os-brick-src-tempest-lvm-lio-barbican14:03
rosmaitayou may have seen 3 VolumesBackupsTest failures with "Failed validating 'type' in schema['properties']['backup']['properties']['name']"14:04
rosmaitathe fix was merged late yesterday14:04
rosmaitahttps://review.opendev.org/#/c/750360/14:04
rajiniro/14:04
LiangFangthis blocked us a lot, thanks rosmaita14:04
rosmaitatook it 11 hours to get checked, gated, and merged14:04
rosmaitaso go ahead and recheck if you're seeing that problem, should be ok now14:05
rosmaitado it fast before something else breaks14:05
rosmaita#topic updates - python-cinderclient14:05
*** openstack changes topic to "updates - python-cinderclient (Meeting topic: cinder)"14:05
rosmaitavictoria release of cinderclient must happen tomorrow14:05
rosmaitaone un-merged approved patch: https://review.opendev.org/#/c/739223/14:05
rosmaitadepends on this un-merged cinder change:14:06
rosmaita#link https://review.opendev.org/#/c/739223/14:06
rosmaitawhoami-rajat__: have you had a chance to look at the unit test failures?14:06
whoami-rajat__rosmaita: yeah, still trying to figure out if it's a legit error or not14:06
rosmaitaok14:06
whoami-rajat__nothing is changed along the lines of failure14:07
smcginnis#link https://review.opendev.org/#/c/73770714:07
smcginnisI think that's the one you meant for the last one.14:07
whoami-rajat__yeah ^^14:07
rosmaitasmcginnis: ty14:07
rosmaitasean is correct, the cinder patch is ^^14:07
rosmaitamy only concern is around the policy stuff, but i think that could be addressed in a follow-up14:08
rosmaitaas far as the stuff that would impact the cinderclient, i think we are ok14:08
whoami-rajat__yep working on that as well14:08
*** lkoranda has quit IRC14:08
rosmaitaso as long as the check agrees, we should be good14:09
*** LiangFang has quit IRC14:09
rosmaita#topic updates - python-brick-cinderclient-ext14:09
*** openstack changes topic to "updates - python-brick-cinderclient-ext (Meeting topic: cinder)"14:09
rosmaitathis also gets its victoria release tomorrow14:09
rosmaitanot much activity on it recently14:09
rosmaitaand no open reviews14:09
rosmaitaso i just wanted to flag that in case anyone knows of some important pending issue?14:10
rosmaitalet me know, otherwise we will cut the stable/victoria branch at the current HEAD of master and release14:11
*** ricolin_ has joined #openstack-meeting-alt14:11
rosmaita#updates - bugfix protocol reminder14:11
rosmaita#topic updates - bugfix protocol reminder14:11
*** openstack changes topic to "updates - bugfix protocol reminder (Meeting topic: cinder)"14:11
rosmaitareminder that any bugfixes for brick or clients go to master first, then must be backported to stable/victoria14:12
rosmaitawe already have some for brick, will discuss in a minute14:12
rosmaita#topic updates - feature freeze14:12
*** openstack changes topic to "updates - feature freeze (Meeting topic: cinder)"14:12
rosmaitaM-3 release day is FEATURE FREEZE14:12
rosmaitathis is the current features list:14:13
rosmaitahttps://blueprints.launchpad.net/cinder/victoria14:13
*** ricolin_ has quit IRC14:13
*** Liang__ has joined #openstack-meeting-alt14:13
rosmaitasome are sitting with one +2, so cores, please take a look14:13
rosmaita#topic updates - soft string freeze14:13
*** openstack changes topic to "updates - soft string freeze (Meeting topic: cinder)"14:13
rosmaitaM-3 release day is  Soft String Freeze14:14
rosmaitawhat this is:14:14
rosmaita"You are no longer allowed to accept proposed changes containing modifications in user-facing strings. Such changes should be rejected by the review team and postponed until the next series development opens (which should happen when RC1 is published)."14:14
rosmaitaso reviewers, please keep that in mind14:14
rosmaitathe idea is to give the translations team time to get stuff translated14:14
rosmaitaok, so that's all the updates14:15
rosmaita#topic M-3 release?14:15
*** openstack changes topic to "M-3 release? (Meeting topic: cinder)"14:15
*** Liang__ is now known as LiangFang14:15
rosmaitawe are not required to do an M-3 release14:15
rosmaitaso i am not sure whether there's any advantage in doing it14:16
rosmaitaother than it gives us a hard timestamp for M-314:16
rosmaitai think that all the features with blueprints are underway to the point were everything could merge by Friday14:17
rosmaita(given active reviewing and revising activity)14:17
rosmaitasmcginnis: jungleboyj: what do you think?14:18
smcginnisIf we don't have anyone downstream asking for a beta release, I think we should skip it.14:18
rosmaitai think if we release M-3 it has to be on thursday, wereas if we don't we can declare M-3 to be EOD eastern time on Friday14:19
jungleboyjIf we aren't required I don't think we have to.  I defer to smcginnis .14:19
rosmaitaok, that is my feeling ... we are getting packaging feedback from the RDO team14:19
rosmaitathat's really the only reason i can think of for having a beta14:19
rosmaitagive packagers a head start14:19
rosmaitabut i think most wait for RC-1 to see that we are serious about what will be in the release14:19
smcginnisDid the RDO team ask for an actual release to help with that?14:20
e0nerosmaita: +114:20
rosmaitasmcginnis: no, they are continually doing it themselves14:20
smcginnisOK, good. Then I think we can just skip it and get ready for the RC1 release coming up.14:20
rosmaitawhat i meant was, they don't need a beta, and they give us the feedback i think a beta would get us14:20
jungleboyjsmcginnis:  ++14:21
rosmaitaok, cool14:21
jungleboyjSounds good.14:21
rosmaitaso to be clear: we will declare M-3 to be 5 pm New York time on Friday14:21
jungleboyj++14:21
rosmaitaany features not merged by then will require a Feature Freeze Exception14:22
smcginnis++14:22
rosmaitabut let's push and get this done, and no FFEs will be necessary and we can concentrate on bug fixes for RC-time14:22
rosmaita#topic os-brick situation14:22
*** openstack changes topic to "os-brick situation (Meeting topic: cinder)"14:22
rosmaitaos-brick victoria release, 4.0.0 was released last week14:23
rosmaitaRDO project was looking at packaging it and noticed that we added a big honking bindep14:23
smcginnisGlad they caught that. We didn't in our code reviews.14:24
rosmaitawhich was not good, so with some discussion in openstack-cinder channel yesterday (i think it was), we reverted it14:24
rosmaita#link https://review.opendev.org/#/c/750444/114:24
rosmaitaand we replaced it with a lightweight fix that is in the gate now:14:24
rosmaita#link https://review.opendev.org/#/c/750452/14:24
rosmaitaso apologies to smcginnis and hemna, who has actually suggested the lightweight fix14:25
e0nerosmaita: can we release 4.0.1 for victoria with the fix?14:25
whoami-rajat__I'm still thinking if the new patch is tested properly and we might end up facing another issue with it14:25
rosmaitae0ne: that tis the plan14:25
rosmaitawhoami-rajat__: can you articulate your concerns a bit?14:26
rosmaitaso before we can release 4.0.1, we need to backport the changes to stable/victoria14:26
rosmaitathe changes are:14:26
whoami-rajat__i need to collect some links, can i share after the meeting?14:26
rosmaita#link https://review.opendev.org/#/c/750649/14:26
rosmaita#link https://review.opendev.org/75065514:26
rosmaitawhoami-rajat__: that is fine, we can talk in openstack cinder14:27
rosmaitaok, so my opinion is:14:27
whoami-rajat__ok14:27
rosmaitawe should definitely revert the change and release 4.0.114:27
e0nerosmaita: +114:27
rosmaitawhether 4.0.1 includes the new fix will depend on whoami-rajat__ and others' discussion in the cinder channel today14:28
rosmaitasound good?14:28
rosmaitathat will at least remove the bad bindep14:28
rosmaitabut i agree with whoami-rajat__ that we don't want to do another release with more problems14:28
rosmaitaok, so once we have 4.0.1 i will file an FFE with the requirements team14:29
rosmaitaso that we can change the victoria os-brick upper-constraint to 4.0.1 before release14:29
smcginnisAt least we have a very good reason for seeking an exception.14:30
jungleboyj:-)14:30
rosmaitaok, so let's have a disucssion in #openstack-cinder after this meeting and sort out what will be in 4.0.114:30
rosmaitathanks!14:31
rosmaita#topic volume-local-cache14:31
*** openstack changes topic to "volume-local-cache (Meeting topic: cinder)"14:31
rosmaitaLiangFang: you have been dropping in and out, so i guess a bad connection14:31
LiangFangyes, now in14:31
rosmaitaso the current status is14:31
LiangFang:)14:31
rosmaitaos-brick support has been merged into victoria14:31
rosmaitathe cinder extra-specs patch looks good14:32
rosmaitacould you give us a quick idea of where the nova changes and CI stuff stand?14:32
LiangFangthe UT of nova patch previously blocked by os-brick, but now it should work14:33
LiangFangbut i need to change os-brick from 3.1.0 to 4.0.014:33
LiangFangin nova14:33
rosmaitawhat are the odds of the nova side stuff merging in victoria?14:34
LiangFangI have not talked too much with them recently, long time ago, they said want to see storage patch go first.14:35
rosmaitaright, that makes sense14:35
rosmaitasmcginnis: jungleboyj: i will need your feedback on what i am about to say14:36
rosmaitai think it makes sense not to hold up the extra-specs support14:36
rosmaitabut also we will not make a big deal about it14:36
rosmaitabecause it doesn't actually do anything useful yet14:37
jungleboyjI think I agree with what you have said.  :-)14:38
rosmaitaok, and i think hemna agrees too (he just +2d the patch)14:38
jungleboyj:-)14:39
rosmaitaok, and LiangFang we will expect documentation for this in wallaby14:39
rosmaitaand then we can announce it as a real feature once the nova side is complete in wallaby14:39
jungleboyj++14:39
smcginnis👍14:40
LiangFangI have finished doc and push the patch this week14:40
jungleboyjCool.14:40
LiangFangbecause customer also need the doc14:40
rosmaitaLiangFang: excellent14:40
rosmaitaok, so that is also useful info, that you actually have all this working somewhere14:41
rosmaitamakes me feel better :)14:41
rosmaita#topic selection of forum submissions14:41
*** openstack changes topic to "selection of forum submissions (Meeting topic: cinder)"14:41
LiangFangcustomer want write-back mode14:41
rosmaitaso we have gathered our brainstorming on this etherpad:14:41
rosmaita#link https://etherpad.opendev.org/p/2020-Wallaby-cinder-brainstorming14:41
rosmaitaso it is now our difficult task to narrow that stuff down to 2 topics14:42
rosmaitamission accomplished!14:42
lsekilol14:42
jungleboyj:-)  Done!14:42
rosmaitaunless anyone absolutely hates one of those, i will submit both of those before the deatline14:42
rosmaita*deadline14:42
jungleboyjI think those are good topics.14:43
rosmaitaworks for me!14:43
rosmaitathat was easy14:43
rosmaita#topic Should we be able to create a volume from a source with a different volume type?14:43
*** openstack changes topic to "Should we be able to create a volume from a source with a different volume type? (Meeting topic: cinder)"14:43
rosmaita#link https://bugs.launchpad.net/cinder/+bug/187407614:43
openstackLaunchpad bug 1874076 in Cinder "create volume from source volume fails if different volume type" [Undecided,New]14:43
rosmaitawalshh_: that's you14:43
walshh_thanks14:44
walshh_Just wondering if this functionality should be working14:44
walshh_it is blocked in the scheduler for us14:44
walshh_has anyone here information on this?14:44
smcginnisDoes seem like it should be an implicit retype. Though that introduces a lot of tricky corner cases.14:44
jungleboyjI think that is working as designed.14:44
smcginnisYeah, I think that is intentional.14:45
walshh_so you should not be able to create a volume from a source using a different volume type?14:45
smcginnisCorrect.14:45
walshh_ok.  that was easy :-)14:45
jungleboyjRight, in case the volume is of that type for a reason.14:45
smcginnisWorkaround would be to create it as the same type, then retype. Or at least attempt to retype.14:45
jungleboyj++14:46
walshh_thanks, i just wanted to check it wasn't just us14:46
jungleboyjNot just you.  :-)14:46
walshh_it is possible to choose a different volume type in the UI14:46
walshh_should this be blocked?14:46
enriquetasoshould we close bug 1874076 then?14:47
openstackbug 1874076 in Cinder "create volume from source volume fails if different volume type" [Undecided,New] https://launchpad.net/bugs/187407614:47
jungleboyjIt seems that the UI should not allow selecting the destination type.14:48
smcginnisYeah, that might be a horizon bug.14:49
walshh_thanks.  I will open a bug against horizon.14:49
walshh_thanks for the clarification14:50
jungleboyj++14:50
jungleboyjThanks walshh_14:50
rosmaitai think the problem is that they are just making a general volume-create call, and don't have built-in logic to sort out what parameters can be successfully combined in the call14:50
rosmaitaour api doesn't help much beyond rejecting your request14:51
walshh_it doesn't get beyond the scheduler14:51
rosmaitaanything else about this topic?14:52
jungleboyjSo, I think the original bug can be closed as Working as Designed.14:53
*** rfolco is now known as rfolco|ruck14:53
rosmaita#topic open discussion14:54
*** openstack changes topic to "open discussion (Meeting topic: cinder)"14:54
*** jadonn has joined #openstack-meeting-alt14:54
rosmaitaok, don't forget, after this meeting, discussion in #openstack-cinder about whether the "new" fix for ceph octopus should go into 4.0.114:55
rosmaita(for os-brick)14:55
toskyas part of the "move to focal" goal, a few base nodesets are going to switch soon; testing has been done, but still, keep an eye on the jobs in the next soon14:55
toskyas part of the "native zuulv3" goal, there is just one job pending, which is the trickiest to adapt, but I will come out with a solution before rc14:56
toskyEOL14:56
rosmaitatosky: ++14:56
toskyuhm, rather EOF14:56
rosmaitathanks for all your work on the zuulv3 nativity14:56
rosmaita1.5 minutes14:58
rosmaitaok, thanks everyone ... please review anything that needs it in https://blueprints.launchpad.net/cinder/victoria14:59
rosmaitathat is the highest priority for reviewing14:59
rosmaita#endmeeting14:59
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/"14:59
openstackMeeting ended Wed Sep  9 14:59:50 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)14:59
openstackMinutes:        http://eavesdrop.openstack.org/meetings/cinder/2020/cinder.2020-09-09-14.00.html14:59
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/cinder/2020/cinder.2020-09-09-14.00.txt14:59
openstackLog:            http://eavesdrop.openstack.org/meetings/cinder/2020/cinder.2020-09-09-14.00.log.html14:59
e0ne#startmeeting horizon15:01
openstackMeeting started Wed Sep  9 15:01:14 2020 UTC and is due to finish in 60 minutes.  The chair is e0ne. Information about MeetBot at http://wiki.debian.org/MeetBot.15:01
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:01
*** openstack changes topic to " (Meeting topic: horizon)"15:01
openstackThe meeting name has been set to 'horizon'15:01
vishalmanchandahi15:01
tmazuro/15:01
rdopierao/15:01
jadonn0/15:01
*** lkoranda has joined #openstack-meeting-alt15:03
e0neok, let's start15:04
e0neI hope amotoki will join us later15:04
*** slaweq has quit IRC15:04
e0ne#topic Notices15:04
*** openstack changes topic to "Notices (Meeting topic: horizon)"15:04
amotokihi, just working on a document :)15:04
e0ne:)15:04
e0neso, we're reaching victoria-3 milestone this week15:05
e0ne#link https://releases.openstack.org/victoria/schedule.html15:05
e0neit's also Soft StringFreeze15:05
e0ne"You are no longer allowed to accept proposed changes containing modifications in user-facing strings. Such changes should be rejected by the review team and postponed until the next series development opens (which should happen when RC1 is published)."15:05
e0neplease, be careful with approval any changes with user-facing strings15:06
e0nesome usual reminders about PTG and Summit15:08
e0neHorizon Virtual PTG planning etherpad15:08
e0ne#link https://etherpad.opendev.org/p/horizon-w-ptg15:08
e0nefeel free to add topics you would like to discuss15:09
e0negeneral PTG details and registration information could be found  here:15:09
e0ne#link https://www.openstack.org/ptg15:09
e0neVirtual Open Infrastructure summit details are available:15:10
e0ne#link https://www.openstack.org/summit15:10
e0neplease, don't forget to register for PTG and Summit if you're going to attend them15:10
e0nethat's all updates from me15:11
*** LiangFang has quit IRC15:11
*** tsmith2 has joined #openstack-meeting-alt15:11
e0ne#topic victoria-3 milestone (feature freeze)15:11
*** openstack changes topic to "victoria-3 milestone (feature freeze) (Meeting topic: horizon)"15:11
e0neamotoki: thanks for work on policy-in-code15:12
e0ne#link https://review.opendev.org/#/c/750134/15:12
*** lpetrut has joined #openstack-meeting-alt15:12
e0neamotoki: I agree with you that it's better to have it in early in Wallaby release15:12
amotokirelated to this, I checked if the existing policy rules in horizon match back-end services.15:13
amotokihttps://etherpad.opendev.org/p/horizon-victoria-policy-check15:13
e0neI'm feeling OK to merge such changes just before FF except cases when we really need such patches15:13
amotokithe check is based on policy-in-code patch, so I don't know the check is based on the current horizon codebase.15:13
amotokithe current horizon codebase == the current policy.json files in horizon15:14
e0netechnically, the patch contains pretty small code changes but it could break anything15:16
amotokie0ne: yeah, that's true15:17
e0neamotoki: did you check that it doesn't break horizon upgrades?15:17
* e0ne just notices that there is no release note15:17
amotokie0ne: I haven't checked the upgrade.15:17
amotokiat least I confirmed it works even when the current policy.json files exist15:18
e0neI propose to test this patch before putting +1/+2 on it and merge it once Wallaby cycle starts15:18
amotokiagree. sounds fair and steady15:19
-amotoki- is aware of missing release note15:19
e0ne:)15:19
e0ne#agreed to move policy-in-code to the next cycle15:20
e0ne#topic victoria-3 milestone (feature freeze): Error messages refactoring15:20
*** aning has quit IRC15:20
*** openstack changes topic to "victoria-3 milestone (feature freeze): Error messages refactoring (Meeting topic: horizon)"15:20
*** tsmith2 has quit IRC15:20
e0ne#link https://review.opendev.org/#/q/topic:bp/refactor-error-messages+(status:open+OR+status:merged)15:21
e0nethere is only one patch left for horizon:15:21
e0ne#link https://review.opendev.org/#/c/749739/15:21
e0neand some clean up patches to plugins15:21
*** aning has joined #openstack-meeting-alt15:22
e0neamotoki, rdopiera: please, review this patch ^^15:22
*** tsmith2 has joined #openstack-meeting-alt15:22
e0neI forgot to mention that Feature Freeze is tomorrow15:22
*** jhesketh has joined #openstack-meeting-alt15:23
e0nevishalmanchanda: you did a great  job with this feature during this release15:23
amotokie0ne: I thought this follow-up is a bug fix while it is nice to land it earilier.15:23
vishalmanchandae0ne: thanks for helping me with JS Hack:)15:24
e0neamotoki: technically, you're right15:24
*** aning_ has joined #openstack-meeting-alt15:25
*** tsmith_ has joined #openstack-meeting-alt15:25
e0neamotoki: but since it contains "Partially-Implements blueprint" text in the commit message I would like to treat it as a minor feature and force to merge it before FF15:25
e0neamotoki: of course, you can disagree with me :)15:26
amotokie0ne: one question on the patch is whether .....fadeIn(100) is assigned to "this_alert" and you call .find() method on it.15:26
*** aning has quit IRC15:26
*** tsmith2 has quit IRC15:27
*** tsmith_ is now known as tsmith215:27
amotokie0ne: I will add my comment after the meeting. I haven't checked the detail code behind this but you may know more.15:27
e0neamotoki: sorry, could you please point me into the code with 'fadeIn(100)' call15:28
e0ne?15:28
amotokihttps://review.opendev.org/#/c/749739/3/horizon/static/horizon/js/horizon.messages.js15:28
amotokiL.50 and L.5615:28
amotokiI will add my comment anyway15:28
e0neoh.. I've got what do you mean15:29
e0nefadeIn returns jQuery instance15:30
e0neamotoki: https://api.jquery.com/fadeIn/15:30
amotokie0ne: thanks15:30
e0nein our case, it will be some html element15:31
e0neamotoki: np15:31
*** zzzeek has quit IRC15:31
*** zzzeek has joined #openstack-meeting-alt15:32
e0nelet's move on15:32
e0ne#topic victoria-3 milestone (feature freeze): Cinder user messages15:32
*** openstack changes topic to "victoria-3 milestone (feature freeze): Cinder user messages (Meeting topic: horizon)"15:32
e0ne#link https://review.opendev.org/#/c/734161/15:32
vishalmanchandaI have to add some U.T test for this patch.15:33
amotokiI made several clean up comments yesterday and most of them were minor and fixed.15:34
amotokithe remaining thing is the new code has no test coverage.15:34
e0neI didn't look on the lates patch-set. will do it after the meeting15:34
vishalmanchandaI will try to push it by tomorrow. Let's see if we also get this feature in this cycle.15:34
amotokiI am okay with either. UT in this patch or in a follow-up patch15:35
e0nevishalmanchanda: is the only reason to not merge it is test coverage, you can ask for FFE tomorrow15:35
vishalmanchandaamotoki: It have some test to check "message-list" at least.15:35
vishalmanchandaamotoki: ok I will add U.T in follow-up patch.15:36
vishalmanchandawill update the patch after the meeting.15:36
amotokivishalmanchanda: precisely speaking, the API code has coverage. no coverage for panel implementation.15:36
vishalmanchandaamotoki: yeah as there is no url I have added in this change so I didn't able to do much thing with res.15:36
vishalmanchandaamotoki: I tried to do something like this  https://review.opendev.org/#/c/734161/10/openstack_dashboard/dashboards/project/volumes/tests.py@1506 but it didn't work out15:37
*** zzzeek has quit IRC15:37
*** zzzeek has joined #openstack-meeting-alt15:38
amotokivishalmanchanda: I don't have a good answer right now in the meeting.15:40
*** belmoreira has quit IRC15:40
vishalmanchandaamotoki: e0ne : If it's fine for both of you I can add these U.T in a follow-up patch.15:41
e0neI'm OK with it15:42
*** zzzeek has quit IRC15:42
amotokias mentioned above, I am okay15:42
vishalmanchandae0ne: amotoki thanks. then I will update it after the meeting.15:43
e0ne#topic victoria-3 milestone (feature freeze): Add flatten_volume_from_snapshot config option15:44
*** openstack changes topic to "victoria-3 milestone (feature freeze): Add flatten_volume_from_snapshot config option (Meeting topic: horizon)"15:44
e0ne#link https://review.opendev.org/#/c/741990/515:44
e0nevishalmanchanda, amotoki: thanks for your reviews15:45
e0neI'll ask Oleksiy  to update this patch tomorrow15:45
amotokie0ne: is "flatten" a common word in cinder?15:45
*** zzzeek has joined #openstack-meeting-alt15:45
e0nehe used cinder-specific tems which are not obvious for everybody15:45
e0neamotoki: yes, in case of RBD and maybe few other drivers15:46
vishalmanchandae0ne: yeah first I am also confused then I refer this document https://docs.openstack.org/cinder/ussuri/drivers.html#rbddriver15:46
e0newe'll try to find a better name for this15:47
amotokiI see. I am okay to use "flatten" if we have a good description.15:47
amotokithe other thing from me is about the test name.15:47
e0nemy main question is: shoud we treat this patch as a feature or as a test fix?15:47
e0neit adds a new config option but only for integration tests config15:47
amotokiI think it is a fix or a workaround in tests15:47
amotokinot a feature15:48
e0neamotoki: ok, so we can merge it after FF and before RC15:48
amotokiwe don't touch any feature in our main code. it touches only the test codes, so I think it is not a target of FF.15:48
amotokie0ne: exactly. that's my thought.15:48
e0neamotoki: got it. it was not clear to my, so I added it for today's discussion15:49
amotokie0ne: thanks15:49
e0neamotoki: np15:49
e0nethat's all I've found in gerrit as a horizon feature proposal15:49
*** zzzeek has quit IRC15:50
*** zzzeek has joined #openstack-meeting-alt15:51
e0neif you know about any other feature in progress, just let us know15:51
e0ne#topic victoria-3 milestone: horizon beta-1 release15:51
*** openstack changes topic to "victoria-3 milestone: horizon beta-1 release (Meeting topic: horizon)"15:51
amotokie0ne: I have a topic around https://review.opendev.org/#/c/743600/ in on-demand agenda.15:52
amotokigo ahead this topic first15:52
e0neit's not mandatory anymore but15:52
e0neI prefer to get this release to make sure that plugins are not broken15:53
e0nebut I'm OK if we decide to skip beta release15:53
amotokiit is a good idea to cut a release.15:54
amotokiour last release was shipped about three months ago now15:54
amotokiprecisely speaking, it is not a beta release though. we adopt the intermediary release model.15:54
e0neok, let's do it tomorrow once vishalmanchanda's patches will be merged15:54
e0neamotoki: you're right15:55
e0nemy point is: it's not a release candidate and not a final release for victoria15:55
amotokie0ne: yeah, i know it too15:56
*** zzzeek has quit IRC15:56
e0neamotoki: ok, let's move to your topic15:56
e0ne#topic Open Discussion15:56
*** openstack changes topic to "Open Discussion (Meeting topic: horizon)"15:56
amotokihttps://review.opendev.org/#/c/743600/ proposed a revert ot OPENSTACK_NOVA_EXTENSIONS_BLACKLIST deprecation15:57
e0newe've got 5 minutes left but we can continue in #openstack-horizon channel15:57
amotokithe discussion turns out what we want is just SimpleTenantUsage in the setting.15:57
amotokiso I think it is better to introduce a new setting15:57
amotokiI just pushed a draft of the document to clarify it https://review.opendev.org/#/c/750693/1/doc/source/configuration/settings.rst15:58
amotokiwe have two ways now15:58
amotokithe one is to clarify OPENSTACK_NOVA_EXTENSIONS_BLACKLIST will not be dropped until a new setting is implemented15:58
amotokithe other is to add a new setting in this release15:58
amotokiboth would be simple15:59
amotokiI would like to know your opinions15:59
*** lpetrut has quit IRC15:59
amotokiwe run out of time, so please give me feedback in #-horizon channel.15:59
*** zzzeek has joined #openstack-meeting-alt15:59
e0nelet's continue in #openstack-horizon15:59
e0ne#endmeeting16:00
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/"16:00
openstackMeeting ended Wed Sep  9 16:00:04 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:00
openstackMinutes:        http://eavesdrop.openstack.org/meetings/horizon/2020/horizon.2020-09-09-15.01.html16:00
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/horizon/2020/horizon.2020-09-09-15.01.txt16:00
openstackLog:            http://eavesdrop.openstack.org/meetings/horizon/2020/horizon.2020-09-09-15.01.log.html16:00
*** zzzeek has quit IRC16:04
*** zzzeek has joined #openstack-meeting-alt16:05
*** rosmaita has left #openstack-meeting-alt16:05
*** rdopiera has quit IRC16:13
*** dosaboy has quit IRC16:51
*** slaweq has joined #openstack-meeting-alt16:57
*** derekh has quit IRC17:00
*** andrebeltrami has quit IRC17:06
*** slaweq has quit IRC17:12
*** gyee has joined #openstack-meeting-alt17:33
*** belmoreira has joined #openstack-meeting-alt17:35
*** e0ne has quit IRC17:37
*** ralonsoh has quit IRC18:05
*** zzzeek has quit IRC18:33
*** zzzeek has joined #openstack-meeting-alt18:34
*** zzzeek has quit IRC18:41
*** zzzeek has joined #openstack-meeting-alt18:42
*** zzzeek has quit IRC18:50
*** zzzeek has joined #openstack-meeting-alt18:50
*** zzzeek has quit IRC18:55
*** zzzeek has joined #openstack-meeting-alt18:56
*** priteau has quit IRC18:57
*** zzzeek has quit IRC19:03
*** zzzeek has joined #openstack-meeting-alt19:05
*** apetrich has quit IRC19:11
*** slaweq has joined #openstack-meeting-alt19:17
*** zzzeek has quit IRC19:21
*** zzzeek has joined #openstack-meeting-alt19:23
*** kaisers_ has quit IRC19:27
*** tosky has quit IRC19:37
*** vishalmanchanda has quit IRC19:45
*** slaweq has quit IRC20:51
*** whoami-rajat__ has quit IRC20:52
*** slaweq has joined #openstack-meeting-alt20:55
*** slaweq has quit IRC20:59
*** rfolco|ruck has quit IRC21:03
*** slaweq has joined #openstack-meeting-alt21:26
*** slaweq has quit IRC21:31
*** jtomasek has quit IRC21:56
*** raildo has quit IRC22:22
*** vishakha has quit IRC22:26
*** tmazur has quit IRC22:29
*** rcernin has joined #openstack-meeting-alt22:55
*** rcernin has quit IRC22:56
*** rcernin has joined #openstack-meeting-alt22:56
*** enriquetaso has quit IRC23:13
*** zzzeek has quit IRC23:17
*** zzzeek has joined #openstack-meeting-alt23:19
*** dosaboy has joined #openstack-meeting-alt23:28
*** zzzeek has quit IRC23:38
*** zzzeek has joined #openstack-meeting-alt23:40
*** zzzeek has quit IRC23:59

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!