*** yamamoto has joined #openstack-meeting-alt | 00:12 | |
*** tosky has quit IRC | 00:14 | |
*** yamamoto has quit IRC | 00:23 | |
*** ricolin has joined #openstack-meeting-alt | 00:37 | |
*** yamamoto has joined #openstack-meeting-alt | 00:39 | |
*** yamamoto has quit IRC | 00:47 | |
*** yamamoto has joined #openstack-meeting-alt | 01:27 | |
*** gyee has quit IRC | 01:38 | |
*** yamamoto has quit IRC | 01:38 | |
*** yamamoto has joined #openstack-meeting-alt | 01:50 | |
*** macz_ has quit IRC | 02:08 | |
*** zzzeek has quit IRC | 02:17 | |
*** zzzeek has joined #openstack-meeting-alt | 02:19 | |
*** rcernin has quit IRC | 02:22 | |
*** rcernin has joined #openstack-meeting-alt | 02:26 | |
*** enriquetaso has quit IRC | 02:32 | |
*** zzzeek has quit IRC | 02:35 | |
*** zzzeek has joined #openstack-meeting-alt | 02:36 | |
*** macz_ has joined #openstack-meeting-alt | 03:20 | |
*** macz_ has quit IRC | 03:25 | |
*** sangeet has quit IRC | 03:37 | |
*** ajitha has joined #openstack-meeting-alt | 04:23 | |
*** vishalmanchanda has joined #openstack-meeting-alt | 04:30 | |
*** ianychoi has joined #openstack-meeting-alt | 04:36 | |
*** macz_ has joined #openstack-meeting-alt | 05:02 | |
*** macz_ has quit IRC | 05:06 | |
*** yamamoto has quit IRC | 05:24 | |
*** yamamoto has joined #openstack-meeting-alt | 05:32 | |
*** yamamoto has quit IRC | 05:34 | |
*** yamamoto has joined #openstack-meeting-alt | 06:11 | |
*** yamamoto has quit IRC | 06:20 | |
*** macz_ has joined #openstack-meeting-alt | 06:29 | |
*** macz_ has quit IRC | 06:34 | |
*** yamamoto has joined #openstack-meeting-alt | 06:51 | |
*** yamamoto has quit IRC | 07:00 | |
*** slaweq has joined #openstack-meeting-alt | 07:01 | |
*** rdopiera has joined #openstack-meeting-alt | 07:15 | |
*** yamamoto has joined #openstack-meeting-alt | 07:30 | |
*** yamamoto has quit IRC | 07:38 | |
*** ralonsoh has joined #openstack-meeting-alt | 07:43 | |
*** yamamoto has joined #openstack-meeting-alt | 08:01 | |
*** yamamoto has quit IRC | 08:05 | |
*** baojg has quit IRC | 08:34 | |
*** baojg has joined #openstack-meeting-alt | 08:35 | |
*** baojg has quit IRC | 08:35 | |
*** rcernin has quit IRC | 08:37 | |
*** ircuser-1 has quit IRC | 08:38 | |
*** baojg has joined #openstack-meeting-alt | 08:42 | |
*** tosky has joined #openstack-meeting-alt | 08:44 | |
*** lpetrut has joined #openstack-meeting-alt | 08:47 | |
*** yamamoto has joined #openstack-meeting-alt | 09:16 | |
*** yamamoto has quit IRC | 09:23 | |
*** ricolin has quit IRC | 09:38 | |
*** yamamoto has joined #openstack-meeting-alt | 10:03 | |
*** yamamoto has quit IRC | 10:16 | |
*** e0ne has joined #openstack-meeting-alt | 10:29 | |
*** yamamoto has joined #openstack-meeting-alt | 10:47 | |
*** yamamoto has quit IRC | 10:57 | |
*** yamamoto has joined #openstack-meeting-alt | 10:57 | |
*** bnemec has quit IRC | 11:00 | |
*** bnemec has joined #openstack-meeting-alt | 11:01 | |
*** baojg has quit IRC | 11:04 | |
*** baojg has joined #openstack-meeting-alt | 11:05 | |
*** baojg has quit IRC | 11:40 | |
*** baojg has joined #openstack-meeting-alt | 11:41 | |
*** macz_ has joined #openstack-meeting-alt | 11:46 | |
*** macz_ has quit IRC | 11:51 | |
*** baojg has quit IRC | 11:55 | |
*** baojg has joined #openstack-meeting-alt | 11:56 | |
*** enriquetaso has joined #openstack-meeting-alt | 12:01 | |
*** raildo has joined #openstack-meeting-alt | 12:14 | |
*** ricolin has joined #openstack-meeting-alt | 12:18 | |
*** kevinz has joined #openstack-meeting-alt | 12:36 | |
*** zzzeek has quit IRC | 12:45 | |
*** zzzeek has joined #openstack-meeting-alt | 12:47 | |
*** liuyulong has joined #openstack-meeting-alt | 14:00 | |
*** liuyulong has quit IRC | 14:33 | |
*** baojg has quit IRC | 14:36 | |
*** baojg has joined #openstack-meeting-alt | 14:37 | |
*** miniroy has joined #openstack-meeting-alt | 14:47 | |
*** tmazur has joined #openstack-meeting-alt | 14:50 | |
*** cliffparsons has quit IRC | 14:51 | |
*** cliffparsons has joined #openstack-meeting-alt | 14:52 | |
*** andrebeltrami has joined #openstack-meeting-alt | 14:56 | |
gouthamr | o/ zorillas - we're in https://meetpad.opendev.org/ManilaW-ReleaseBugSquash for our bug squash! join us there :) | 15:01 |
---|---|---|
gouthamr | courtesy ping: ganso vkmc dviroel lseki carloss tbarron andrebeltrami felipe_rodrigues ^ | 15:03 |
*** tosky has quit IRC | 15:18 | |
*** tosky has joined #openstack-meeting-alt | 15:22 | |
*** tosky has quit IRC | 15:26 | |
*** macz_ has joined #openstack-meeting-alt | 15:39 | |
*** tosky has joined #openstack-meeting-alt | 15:50 | |
priteau | #startmeeting blazar | 16:00 |
openstack | Meeting started Thu Nov 19 16:00:22 2020 UTC and is due to finish in 60 minutes. The chair is priteau. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
*** openstack changes topic to " (Meeting topic: blazar)" | 16:00 | |
openstack | The meeting name has been set to 'blazar' | 16:00 |
*** vishalmanchanda has quit IRC | 16:00 | |
priteau | #topic Roll call | 16:00 |
*** openstack changes topic to "Roll call (Meeting topic: blazar)" | 16:00 | |
*** diurnalist has joined #openstack-meeting-alt | 16:05 | |
diurnalist | o/ | 16:05 |
priteau | o/ | 16:06 |
priteau | Hi diurnalist | 16:06 |
diurnalist | Welcome back! | 16:06 |
priteau | Thank you | 16:07 |
priteau | Sorry for skipping a couple of meetings due to being away | 16:08 |
priteau | We are now returning to our regular schedule | 16:08 |
priteau | I wanted to catch up with you, I saw a number of updated patches but I haven't had time to look at them yet | 16:09 |
diurnalist | sounds good | 16:09 |
diurnalist | yes, I haven't had much time for upstream contributions myself, but had a day where I tried to go through all of our patches and try to get them up | 16:09 |
diurnalist | rebasing on master etc | 16:10 |
diurnalist | jakecoll doesn't work on the project anymore, but before he left (end of last week) he helped me write up some of the missing docs for network reservations | 16:10 |
priteau | I saw an updated patch from him last Friday | 16:11 |
priteau | I was wondering if he was going to be involved again | 16:11 |
priteau | I've got limited time for reviews until end of last week most likely, are there some patches that you would suggest are good candidates to be merged? | 16:12 |
priteau | I see network reservation still needs work | 16:12 |
diurnalist | Yes, I think it needs pep fixes at minimum. We had also discussed a tempest test, should we still try that? I think the difficulty was that the network plugin needs to be enabled by default, likely | 16:14 |
diurnalist | These ones are pretty small: https://review.opendev.org/#/c/762006/ https://review.opendev.org/#/c/761994/ https://review.opendev.org/#/c/761990/ https://review.opendev.org/#/c/589899/ | 16:15 |
priteau | I was asking for the tempest test mostly because my manual testing of the patch back in… April? uncovered various issues (even though unit tests were passing) | 16:15 |
priteau | Just left feedback about the first one | 16:16 |
diurnalist | I see your comment on the shuffling, I forgot we had discussed the toggle | 16:16 |
diurnalist | Once those are in I would move on to brushing up the enforcement stuff and submitting that | 16:16 |
priteau | I forgot about the traceback one, adding it to my list to look at later | 16:16 |
diurnalist | this one has been sitting for a while and is probably the most complicated (other than net res.) https://review.opendev.org/#/c/731586/ | 16:17 |
priteau | Yeah it's a though one, need some proper review session to go through it | 16:18 |
priteau | I'll try to schedule one soon | 16:18 |
diurnalist | ok, appreciated-- I have also thought about setting aside some time to perform some other refactors. In my opinion much of the plugin logic could/should be pulled up one level into the base implementation, or some other component | 16:19 |
diurnalist | really there are 2 refactors I have been kicking around: | 16:20 |
diurnalist | 1.) update lease tear-down to gracefully handle individual reservation termination errors. I already have a patch for this and we're testing now. Currently a termination halts on the first failed reservation teardown failure. | 16:20 |
diurnalist | 2.) move resource filtering out of plugins and make it shared business logic | 16:21 |
priteau | Both would be really good | 16:22 |
diurnalist | what I would really like to do long-term is support out-of-tree resource plugins. i envision moving more stuff to core concerns will make it much easier to do this | 16:22 |
priteau | Another I thought about is common code for handling extra capabilities | 16:22 |
diurnalist | :nod: | 16:22 |
priteau | Currently there's lots of code duplication to do this across both hosts and networks | 16:22 |
diurnalist | yes, especially that extra capabilities are really just a key/value system that can apply to any resource type | 16:23 |
priteau | Do you see out of tree resource plugins being loaded like scheduler filters in nova/ | 16:23 |
diurnalist | I'm not 100% how nova does it. I am familiar with the Ironic way, where it's via entry_points | 16:24 |
diurnalist | which I think is fine, and pairs well with stevedore | 16:24 |
priteau | ironic's way might be more modern since it was written more recently | 16:25 |
diurnalist | the way that would work is you'd define an entry point namespace like "blazar.resource_type" and then your python module would export an entry point like "my_type = module.path.to:Thing" | 16:25 |
priteau | I tend to see more old patterns in nova than in the rest of OpenStack projects | 16:25 |
diurnalist | and then blazar conf would have "enabled_plugins = physical:host,my_type" or similar | 16:26 |
diurnalist | as long as the module is installed in the same python path as blazar, everything's good | 16:26 |
*** rdopiera has quit IRC | 16:27 | |
priteau | I am not too familiar with this area but I guess it should work | 16:27 |
priteau | We mostly need to make sure there are no conflicts between plugins | 16:28 |
diurnalist | yes, and I think the trickiest thing is going to be how to handle DB dependencies. the DB schema might need to change, which is going to be painful | 16:29 |
diurnalist | OSC also uses entry points btw, this describes it a bit: https://docs.openstack.org/python-openstackclient/latest/contributor/plugins.html | 16:29 |
priteau | Separate DBs maybe? | 16:30 |
diurnalist | I guess Neutron is the other project to look at here | 16:30 |
priteau | That way you could have an alembic serial number by plugin | 16:30 |
diurnalist | one question to think about is: can all resource plugins share a db. is there anything that is not possible w/ this | 16:31 |
diurnalist | tricky because some resource properties are more important than others, like hypervisor_hostname for the physical host plugin | 16:32 |
priteau | I thought alembic migrations would conflict, but maybe not | 16:32 |
priteau | I can see in neutron-lbaas it uses alembic as well | 16:33 |
priteau | and AFAIK it was using the neutron db | 16:33 |
diurnalist | i think it has its own tables that it targets though, could be wrong | 16:33 |
diurnalist | vpnaas is similar | 16:33 |
*** gyee has joined #openstack-meeting-alt | 16:34 | |
priteau | Yes, separate tables but same db | 16:34 |
priteau | Could we keep resource plugins constrained to their own separate tables | 16:35 |
priteau | They would still be able to manipulate existing tables, but through the existing models (no schema changes) | 16:35 |
diurnalist | yes, i think that's workable. the extra capabilities functionality is a bit tricky to express this way, maybe there is a way | 16:35 |
diurnalist | plugins should not be responsible for implementing that IMO | 16:36 |
priteau | Maybe with an additional layer in the DB, a resources table that would describe which plugin is responsible for each resource | 16:38 |
priteau | And extra caps would reference this table, rather than the custom table from the plugin | 16:38 |
priteau | A bit like how there is a split between the reservations table and computehost_reservations / instance_reservations | 16:38 |
diurnalist | i'll have to look again to see how that works | 16:41 |
priteau | There might be some details that I've not considered but it's worth trying | 16:41 |
*** lpetrut has quit IRC | 16:42 | |
diurnalist | :nod: | 16:43 |
diurnalist | will keep kicking it around, at some point there will need to be a spec. it's more of a general direction i think things should move | 16:43 |
priteau | I am all for it if it makes your life easier | 16:44 |
priteau | Anything else to cover? | 16:45 |
diurnalist | one other thing: has anybody worked on making blazarclient osc-compatible? | 16:46 |
priteau | Good question | 16:46 |
diurnalist | i am wondering if it might be a good project for a new hire as a way of getting acquainted w/ the process. a bit hard for us to argue for its utility, but it's always bugged me :) | 16:47 |
priteau | There was a start a while ago from someone in the community, but I don't think the patches were submitted upstream | 16:47 |
priteau | I'll see if I can get the patches, but it might be difficult | 16:48 |
priteau | It could be a good project to get used to the client and the API. It's not really useful for learning about the internals of the service of course. | 16:49 |
diurnalist | i think if the patches are very old it may be worth it to just start over | 16:49 |
diurnalist | ok, i'll let you know if it gets scheduled | 16:50 |
diurnalist | otherwise nothing else from me, I don't think. there is a general question of how to handle upstream contributions given that it seems like you are the only active reviewer these days | 16:50 |
*** gyee has quit IRC | 16:50 | |
priteau | Maybe you should become core reviewer ;-) Although that doesn't really help with your own patches | 16:51 |
priteau | But if there are contributions from the new hire in your group, we could merge them with +2 from you and I | 16:53 |
diurnalist | that may be helpful | 16:53 |
priteau | I'll propose something :) | 16:54 |
diurnalist | in principle i worry about taking a bit too much extra responsibility, but in practice we are the main ones proposing things these days, and i'm reviewing that code anyways | 16:54 |
priteau | Yes I don't think it would add much workload for you | 16:55 |
priteau | Let's wrap up | 16:56 |
priteau | Thanks a lot for joining! | 16:56 |
priteau | #endmeeting | 16:56 |
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 16:56 | |
openstack | Meeting ended Thu Nov 19 16:56:27 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:56 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/blazar/2020/blazar.2020-11-19-16.00.html | 16:56 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/blazar/2020/blazar.2020-11-19-16.00.txt | 16:56 |
openstack | Log: http://eavesdrop.openstack.org/meetings/blazar/2020/blazar.2020-11-19-16.00.log.html | 16:56 |
*** andrebeltrami has quit IRC | 17:02 | |
*** macz_ has quit IRC | 17:05 | |
*** gyee has joined #openstack-meeting-alt | 17:05 | |
*** ralonsoh_ has joined #openstack-meeting-alt | 17:27 | |
*** ralonsoh has quit IRC | 17:28 | |
*** hemna has quit IRC | 17:46 | |
*** diurnalist has quit IRC | 17:46 | |
*** hemna has joined #openstack-meeting-alt | 17:47 | |
*** macz_ has joined #openstack-meeting-alt | 17:53 | |
*** geguileo has quit IRC | 18:03 | |
*** macz_ has quit IRC | 18:08 | |
*** esantos_63 has joined #openstack-meeting-alt | 18:12 | |
*** esantos_63 is now known as ecsantos | 18:13 | |
*** esantos_56 has joined #openstack-meeting-alt | 18:16 | |
*** esantos_56 is now known as ecsantos | 18:17 | |
*** ecsantos has quit IRC | 18:25 | |
*** ecsantos91 has joined #openstack-meeting-alt | 18:30 | |
*** ecsantos91 has quit IRC | 18:31 | |
*** macz_ has joined #openstack-meeting-alt | 18:51 | |
*** ralonsoh_ has quit IRC | 18:53 | |
*** macz_ has quit IRC | 19:19 | |
*** macz_ has joined #openstack-meeting-alt | 19:37 | |
*** ajitha has quit IRC | 20:16 | |
*** rcernin has joined #openstack-meeting-alt | 20:33 | |
*** rcernin has quit IRC | 20:37 | |
*** ircuser-1 has joined #openstack-meeting-alt | 20:55 | |
*** rcernin has joined #openstack-meeting-alt | 21:02 | |
*** e0ne has quit IRC | 21:24 | |
*** baojg has quit IRC | 22:56 | |
*** baojg has joined #openstack-meeting-alt | 22:57 | |
*** tmazur has quit IRC | 23:08 | |
*** baojg has quit IRC | 23:20 | |
*** baojg has joined #openstack-meeting-alt | 23:21 | |
*** rcernin has quit IRC | 23:35 | |
*** rcernin has joined #openstack-meeting-alt | 23:35 | |
*** baojg has quit IRC | 23:42 | |
*** baojg has joined #openstack-meeting-alt | 23:42 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!