*** tosky has quit IRC | 00:04 | |
*** macz_ has quit IRC | 00:58 | |
*** rcernin_ has joined #openstack-meeting-alt | 01:09 | |
*** rcernin has quit IRC | 01:10 | |
*** reddy1 has quit IRC | 01:17 | |
*** enriquetaso has joined #openstack-meeting-alt | 01:20 | |
*** kevinz has joined #openstack-meeting-alt | 01:40 | |
*** enriquetaso has quit IRC | 02:15 | |
*** benj_- has joined #openstack-meeting-alt | 02:35 | |
*** benj_ has quit IRC | 02:35 | |
*** benj_- is now known as benj_ | 02:35 | |
*** rcernin_ has quit IRC | 02:46 | |
*** macz_ has joined #openstack-meeting-alt | 02:55 | |
*** macz_ has quit IRC | 03:00 | |
*** rfolco has joined #openstack-meeting-alt | 03:11 | |
*** rfolco has quit IRC | 03:32 | |
*** gyee has quit IRC | 03:43 | |
*** macz_ has joined #openstack-meeting-alt | 03:46 | |
*** macz_ has quit IRC | 03:50 | |
*** vishalmanchanda has joined #openstack-meeting-alt | 05:02 | |
*** zzzeek has quit IRC | 05:39 | |
*** zzzeek has joined #openstack-meeting-alt | 05:39 | |
*** zzzeek has quit IRC | 05:46 | |
*** zzzeek has joined #openstack-meeting-alt | 05:48 | |
*** ricolin has joined #openstack-meeting-alt | 05:59 | |
*** zzzeek has quit IRC | 06:02 | |
*** zzzeek has joined #openstack-meeting-alt | 06:06 | |
*** yamamoto has quit IRC | 06:48 | |
*** lseki has quit IRC | 06:55 | |
*** lkoranda has joined #openstack-meeting-alt | 07:25 | |
*** yamamoto has joined #openstack-meeting-alt | 07:29 | |
*** lkoranda has quit IRC | 07:35 | |
*** yamamoto has quit IRC | 07:39 | |
*** zzzeek has quit IRC | 07:40 | |
*** zzzeek has joined #openstack-meeting-alt | 07:41 | |
*** zzzeek has quit IRC | 07:53 | |
*** zzzeek has joined #openstack-meeting-alt | 07:55 | |
*** slaweq has joined #openstack-meeting-alt | 08:00 | |
*** zzzeek has quit IRC | 08:31 | |
*** tosky has joined #openstack-meeting-alt | 08:33 | |
*** zzzeek has joined #openstack-meeting-alt | 08:34 | |
*** zzzeek has quit IRC | 08:39 | |
*** zzzeek has joined #openstack-meeting-alt | 08:41 | |
*** e0ne has joined #openstack-meeting-alt | 08:54 | |
*** zzzeek has quit IRC | 08:59 | |
*** zzzeek has joined #openstack-meeting-alt | 09:00 | |
*** zzzeek has quit IRC | 09:05 | |
*** zzzeek has joined #openstack-meeting-alt | 09:06 | |
*** zzzeek has quit IRC | 09:11 | |
*** michael-mcaleer has joined #openstack-meeting-alt | 09:12 | |
*** lseki has joined #openstack-meeting-alt | 09:12 | |
*** zzzeek has joined #openstack-meeting-alt | 09:14 | |
*** derekh has joined #openstack-meeting-alt | 09:18 | |
*** zzzeek has quit IRC | 09:23 | |
*** zzzeek has joined #openstack-meeting-alt | 09:25 | |
*** vishalmanchanda has quit IRC | 09:36 | |
*** smyers_ has joined #openstack-meeting-alt | 09:40 | |
*** zzzeek has quit IRC | 09:41 | |
*** smyers has quit IRC | 09:42 | |
*** smyers_ is now known as smyers | 09:42 | |
*** zzzeek has joined #openstack-meeting-alt | 09:42 | |
*** tosky_ has joined #openstack-meeting-alt | 09:47 | |
*** tosky is now known as Guest24372 | 09:49 | |
*** tosky_ is now known as tosky | 09:49 | |
*** Guest24372 has quit IRC | 09:50 | |
*** zzzeek has quit IRC | 09:57 | |
*** lpetrut has joined #openstack-meeting-alt | 09:57 | |
*** zzzeek has joined #openstack-meeting-alt | 09:58 | |
*** vishalmanchanda has joined #openstack-meeting-alt | 10:07 | |
*** yamamoto has joined #openstack-meeting-alt | 10:12 | |
*** zzzeek has quit IRC | 10:13 | |
*** zzzeek has joined #openstack-meeting-alt | 10:14 | |
*** baojg has quit IRC | 10:18 | |
*** baojg has joined #openstack-meeting-alt | 10:18 | |
*** lbragstad has quit IRC | 10:31 | |
*** lbragstad has joined #openstack-meeting-alt | 10:31 | |
*** zzzeek has quit IRC | 10:44 | |
*** zzzeek has joined #openstack-meeting-alt | 10:47 | |
*** zzzeek has quit IRC | 11:07 | |
*** zzzeek has joined #openstack-meeting-alt | 11:09 | |
*** macz_ has joined #openstack-meeting-alt | 11:18 | |
*** macz_ has quit IRC | 11:23 | |
*** rdopiera has joined #openstack-meeting-alt | 11:31 | |
*** yamamoto has quit IRC | 11:32 | |
*** zzzeek has quit IRC | 11:41 | |
*** zzzeek has joined #openstack-meeting-alt | 11:44 | |
*** raildo has joined #openstack-meeting-alt | 11:53 | |
*** yamamoto has joined #openstack-meeting-alt | 11:55 | |
*** zzzeek has quit IRC | 11:55 | |
*** zzzeek has joined #openstack-meeting-alt | 11:57 | |
*** yamamoto has quit IRC | 12:00 | |
*** rfolco has joined #openstack-meeting-alt | 12:01 | |
*** baojg has quit IRC | 12:09 | |
*** baojg has joined #openstack-meeting-alt | 12:09 | |
*** zzzeek has quit IRC | 12:11 | |
*** zzzeek has joined #openstack-meeting-alt | 12:13 | |
*** zzzeek has quit IRC | 12:18 | |
*** yamamoto has joined #openstack-meeting-alt | 12:20 | |
*** zzzeek has joined #openstack-meeting-alt | 12:20 | |
*** zzzeek has quit IRC | 12:31 | |
*** zzzeek has joined #openstack-meeting-alt | 12:32 | |
*** baojg has quit IRC | 12:42 | |
*** baojg has joined #openstack-meeting-alt | 12:43 | |
*** zzzeek has quit IRC | 13:34 | |
*** felipe_rodrigues has joined #openstack-meeting-alt | 13:35 | |
*** zzzeek has joined #openstack-meeting-alt | 13:36 | |
*** zzzeek has quit IRC | 13:45 | |
*** thgcorrea has joined #openstack-meeting-alt | 13:48 | |
*** zzzeek has joined #openstack-meeting-alt | 13:49 | |
*** lbragstad has quit IRC | 13:54 | |
*** eharney has joined #openstack-meeting-alt | 13:56 | |
*** lbragstad has joined #openstack-meeting-alt | 13:57 | |
*** rosmaita has joined #openstack-meeting-alt | 13:57 | |
*** lbragstad has quit IRC | 13:57 | |
*** lbragstad has joined #openstack-meeting-alt | 13:58 | |
*** TusharTgite has joined #openstack-meeting-alt | 13:58 | |
*** geguileo has joined #openstack-meeting-alt | 13:58 | |
*** rafaelweingartne has joined #openstack-meeting-alt | 13:59 | |
*** liuyulong has joined #openstack-meeting-alt | 13:59 | |
rosmaita | #startmeeting cinder | 14:00 |
---|---|---|
openstack | Meeting started Wed Dec 16 14:00:48 2020 UTC and is due to finish in 60 minutes. The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
*** openstack changes topic to " (Meeting topic: cinder)" | 14:00 | |
openstack | The meeting name has been set to 'cinder' | 14:00 |
rosmaita | #topic roll call | 14:01 |
*** openstack changes topic to "roll call (Meeting topic: cinder)" | 14:01 | |
michael-mcaleer | hi | 14:01 |
*** enriquetaso has joined #openstack-meeting-alt | 14:01 | |
walshh_ | hi | 14:01 |
eharney | howdy | 14:01 |
rafaelweingartne | \o | 14:01 |
TusharTgite | hi | 14:01 |
e0ne | hi | 14:01 |
enriquetaso | hi | 14:01 |
jungleboyj | o/ | 14:01 |
tosky | o/ | 14:02 |
felipe_rodrigues | o/ | 14:02 |
rosmaita | ok, let's get started | 14:02 |
rosmaita | hello everyone | 14:02 |
rosmaita | #link https://etherpad.openstack.org/p/cinder-wallaby-meetings | 14:03 |
rosmaita | #topic announcements | 14:03 |
*** openstack changes topic to "announcements (Meeting topic: cinder)" | 14:03 | |
*** lbragstad_ has joined #openstack-meeting-alt | 14:03 | |
rosmaita | lseki wishes to announce that he has moved to Red Hat | 14:03 |
rosmaita | if you have NetApp questions, the person to contact from now on is sfernand | 14:03 |
sfernand | yep | 14:04 |
rosmaita | deadlines update | 14:04 |
rosmaita | the spec freeze is on Friday this week | 14:04 |
jungleboyj | lseki: Congratulations. | 14:04 |
rosmaita | #link https://releases.openstack.org/wallaby/schedule.html#w-cinder-spec-freeze | 14:04 |
rosmaita | we'll look at some specs later in the meeting | 14:04 |
*** ecsantos has joined #openstack-meeting-alt | 14:04 | |
rosmaita | there will NOT be a cinder meeting on 30 December | 14:05 |
rosmaita | so, next week's meeting on 23 December will be the last meeting of the month, so we will hold it in videoconf | 14:05 |
rosmaita | connection info will be on the agenda etherpad | 14:05 |
*** lbragstad has quit IRC | 14:05 | |
michael-mcaleer | I wont be present, ill be on leave already, but I will have the bug report ready for you all to look at | 14:05 |
rosmaita | great, ty | 14:05 |
rosmaita | last announcement: | 14:06 |
jungleboyj | I will be on vacation. :-) | 14:06 |
rosmaita | slacker | 14:06 |
rosmaita | :) | 14:06 |
jungleboyj | Hey now! | 14:06 |
jungleboyj | :-) | 14:06 |
rosmaita | we have one community goal on the verge of completion | 14:06 |
rosmaita | #link https://review.opendev.org/c/openstack/cinder/+/763917 | 14:06 |
rosmaita | please review this patch so we can get it out of the way | 14:06 |
rosmaita | i can't approve it because i am co-author | 14:07 |
* jungleboyj will look | 14:07 | |
rosmaita | thank you, i withdraw my "slacker" comment | 14:07 |
jungleboyj | :-) | 14:07 |
rosmaita | that's all from me, anyone else have an announcement? | 14:07 |
* lseki sneaks in, but also in another meeting | 14:07 | |
lseki | jungleboyj: thanks | 14:08 |
rosmaita | #topic New meeting time proposal | 14:08 |
*** openstack changes topic to "New meeting time proposal (Meeting topic: cinder)" | 14:08 | |
rosmaita | lseki: that's you if you can multitask | 14:08 |
lseki | I'll try | 14:08 |
jungleboyj | :-) Good topic. I have the same problem. | 14:08 |
rosmaita | ok, we used to have the cinder meeting at 1500 UTC | 14:08 |
lseki | so now I have a conflicting daily meeting at 14:00-14:30 UTC | 14:09 |
rosmaita | we moved it to be more friendly to APAC people | 14:09 |
rosmaita | but i haven't seen evidence that it has helped | 14:09 |
rosmaita | so we may have to think of another way to encourage APAC participation | 14:10 |
rosmaita | unfortunately, if we move to 1500 then it conflicts with the horizon meeting | 14:10 |
* jungleboyj liked it when it was 1600 :-) | 14:10 | |
rosmaita | well, that would solve the horizon problem | 14:11 |
lseki | 1600 works for me as well | 14:11 |
lseki | but might be even worse for APAC folks | 14:12 |
rosmaita | ok, i guess the thing to do is to take a poll | 14:12 |
jungleboyj | Works for me as it moves it out beyond all my APAC meetings. | 14:12 |
rosmaita | which could result in 1300 for all i know | 14:12 |
rosmaita | :D | 14:12 |
rosmaita | ok, to be clear, next week's meeting will be at 1400 UTC as usual | 14:13 |
rosmaita | i'll get a poll out today | 14:13 |
rosmaita | #action rosmaita - poll for meeting time change | 14:13 |
rosmaita | does anyone have any radical change suggestions, like changing the day of week? | 14:14 |
rosmaita | hearing none, i'll go with some conservative suggestions and an open space for suggestions | 14:15 |
jungleboyj | ++ | 14:15 |
lseki | ++ | 14:15 |
e0ne | rosmaita: another day of week works for me | 14:15 |
rosmaita | e0ne: would it be possible to swap time slots with horizon? | 14:16 |
rosmaita | or would that be bad for the horizon team? | 14:16 |
e0ne | rosmaita I need to ask for the team | 14:16 |
e0ne | rosmaita it should not be an issue | 14:16 |
rosmaita | ok, thanks, i definitely don't want to schedule a meeting that has a conflict for you | 14:17 |
rosmaita | #topic bug report | 14:17 |
*** openstack changes topic to "bug report (Meeting topic: cinder)" | 14:17 | |
michael-mcaleer | thanks rosmaita | 14:17 |
michael-mcaleer | we had quite a few opened this week, 11 to be exact | 14:17 |
michael-mcaleer | I will save time by not including the summary here, they are all in the bug report #link https://etherpad.opendev.org/p/cinder-wallaby-r18-bug-review | 14:17 |
michael-mcaleer | if anyone has any comments just reply after I link the bug, I will go through them in the same order as the etherpad | 14:18 |
michael-mcaleer | Cinder bug #1: Target volume type is still in use #link https://bugs.launchpad.net/cinder/+bug/1907157 | 14:18 |
openstack | Launchpad bug 1907157 in Cinder "Target volume type is still in use" [Medium,Triaged] | 14:18 |
openstack | bug 1 in Ubuntu Malaysia LoCo Team "Microsoft has a majority market share" [Critical,In progress] https://launchpad.net/bugs/1 - Assigned to MFauzilkamil Zainuddin (apogee) | 14:18 |
*** TusharTgite has quit IRC | 14:18 | |
michael-mcaleer | never mind the second part about ubuntu malaysia, thats my improper formatting | 14:18 |
rosmaita | yeah, that is not cinder's fault | 14:19 |
michael-mcaleer | ok, we were added to it by submitter because they thought we might have some input or suggestions | 14:19 |
*** TusharTgite has joined #openstack-meeting-alt | 14:19 | |
rosmaita | i will look | 14:19 |
michael-mcaleer | np | 14:20 |
michael-mcaleer | Cinder bug 2: Attachment update API returns 500 when it should return 400 #link https://bugs.launchpad.net/cinder/+bug/1907295 | 14:20 |
openstack | Launchpad bug 1907295 in Cinder "attachment update API returns 500 when it should return 400" [Medium,Triaged] - Assigned to Eric Harney (eharney) | 14:20 |
rosmaita | it may be the image cache | 14:20 |
eharney | i ran into this while chasing a different issue | 14:20 |
eharney | the log basically said "HTTP 500" with no useful context about why | 14:20 |
eharney | i'll either chase it down or just close this if i can't reproduce it | 14:20 |
eharney | (also seems like a bug in itself that we can log HTTP 500 with no info, but that's probably a whole different can of worms) | 14:21 |
michael-mcaleer | np thanks eharney | 14:22 |
michael-mcaleer | Cinder bug 3: py38 ReplicationTestCase unit test failure #link https://bugs.launchpad.net/cinder/+bug/1907672 | 14:22 |
openstack | Launchpad bug 1907672 in Cinder "py38 ReplicationTestCase unit test failure" [Low,Triaged] | 14:22 |
openstack | bug 3 in mono (Ubuntu) "Custom information for each translation team" [Undecided,Fix committed] https://launchpad.net/bugs/3 | 14:22 |
eharney | this is just a flaky unit test that needs some work | 14:23 |
michael-mcaleer | yeah it looked fairly simple | 14:23 |
michael-mcaleer | Cinder bug_ 4: Cannot set quota for volume type #link https://bugs.launchpad.net/cinder/+bug/1907750 | 14:23 |
openstack | Launchpad bug 1907750 in Cinder "Cannot set quota for volume type" [Low,Triaged] - Assigned to haobing1 (haobing1) | 14:23 |
michael-mcaleer | this is limited to cases where second attempt at quota uses explicitly upper case variation of the first volume-type name | 14:25 |
michael-mcaleer | submitter confirmed in a follow up comment | 14:25 |
*** TusharTgite has quit IRC | 14:25 | |
michael-mcaleer | any insights/comments or will we move on? | 14:26 |
*** TusharTgite has joined #openstack-meeting-alt | 14:26 | |
michael-mcaleer | Cinder bug_ 5: cinder-backup does not allow to enable 'fast-diff' feature for backup images stored in ceph #link https://bugs.launchpad.net/cinder/+bug/1907964 | 14:27 |
openstack | Launchpad bug 1907964 in Cinder "cinder-backup does not allow to enable 'fast-diff' feature for backup images stored in ceph" [Low,In progress] - Assigned to Christian Rohmann (christian-rohmann) | 14:27 |
rosmaita | the suggestion that when you delete a volume type, all the associated stuff should also be deledte sounds correct | 14:27 |
michael-mcaleer | yeah it is a fair assumption | 14:27 |
michael-mcaleer | if there is no vols associated it should be fine to delete | 14:27 |
eharney | fast-diff looks like an improvement we should investigate for rbd, more a perf enhancement than a bug | 14:28 |
michael-mcaleer | eharney will I change this to importance: wishlist? it is already in progress by user and changes have been proposed | 14:29 |
eharney | makes sense | 14:29 |
michael-mcaleer | no problem, I will reply to submitters latest comment | 14:29 |
michael-mcaleer | Cinder bug_ 6: use md5 to check volume metadata #link https://bugs.launchpad.net/cinder/+bug/1908040 | 14:30 |
openstack | Launchpad bug 1908040 in Cinder "use md5 to check volume metadata" [Undecided,Invalid] | 14:30 |
michael-mcaleer | subsequently marked as invalid after response from eharney | 14:30 |
michael-mcaleer | Cinder bug_ 7: "publish_service_capabilities" periodic task blocks cinder-volume #link | 14:31 |
michael-mcaleer | this one may be of higher importance than medium because it references environments at scale issues | 14:31 |
eharney | i just marked this one as a duplicate, it's a known ceph issue that we fixed | 14:31 |
michael-mcaleer | ty | 14:31 |
michael-mcaleer | last cinder bug is a driver one | 14:32 |
michael-mcaleer | Cinder bug_ 8: ibm_storage driver: the "OSvol:" prefix should be optional in the volume name #link https://bugs.launchpad.net/cinder/+bug/1908181 | 14:32 |
openstack | Launchpad bug 1908181 in Cinder "ibm_storage driver: the "OSvol:" prefix should be optional in the volume name" [Low,Triaged] | 14:32 |
michael-mcaleer | this is a customer request for a driver change | 14:32 |
michael-mcaleer | it has been tagged correctly so hopefully IBM driver team see it and pick it up | 14:32 |
rosmaita | anyone from ibm here? | 14:32 |
rosmaita | well, hopefully they are watching launchpad | 14:33 |
rosmaita | ok, thanks, michael-mcaleer | 14:33 |
michael-mcaleer | os-brick next | 14:33 |
rosmaita | #topic specs | 14:33 |
*** openstack changes topic to "specs (Meeting topic: cinder)" | 14:33 | |
rosmaita | oops | 14:33 |
michael-mcaleer | haha | 14:33 |
rosmaita | #topic bugs continued | 14:33 |
*** openstack changes topic to "bugs continued (Meeting topic: cinder)" | 14:33 | |
michael-mcaleer | pulled the trigger a bit quick | 14:33 |
michael-mcaleer | only three left, one is a duplicate | 14:33 |
michael-mcaleer | os-brick bug_ 1: Evacuation results in multipath residue when use fc #link https://bugs.launchpad.net/os-brick/+bug/1906768 | 14:34 |
openstack | Launchpad bug 1906768 in os-brick "Evacuation results in multipath residue when use fc" [Undecided,New] | 14:34 |
michael-mcaleer | and this one is a duplicate of the first ... | 14:34 |
michael-mcaleer | os-brick bug_ 2: fibre channel driver can not disconnet volume when VM to be evacuated #link https://bugs.launchpad.net/os-brick/+bug/1907442 | 14:34 |
openstack | Launchpad bug 1907442 in os-brick " fibre channel driver can not disconnet volume when VM to be evacuated" [Undecided,Invalid] | 14:34 |
eharney | pretty sure a lot of multipath fixes made it back to queens | 14:34 |
eharney | the answer is probably: upgrade from pike :/ | 14:34 |
michael-mcaleer | should the same be relayed to the submitter? | 14:34 |
rosmaita | i'll leave a note | 14:35 |
michael-mcaleer | ty rosmaita | 14:35 |
rosmaita | pike is EOL | 14:35 |
michael-mcaleer | and the last bug for this week... | 14:35 |
michael-mcaleer | python-cinderclient bug_ 1: backup delete fail #link https://bugs.launchpad.net/python-cinderclient/+bug/1907542 | 14:35 |
openstack | Launchpad bug 1907542 in python-cinderclient "backup delete fail" [Low,Triaged] - Assigned to FengJiankui (fengjiankui) | 14:35 |
enriquetaso | mmm | 14:36 |
eharney | seems unlikely to be a client bug | 14:36 |
michael-mcaleer | are you thinking more cinder? | 14:37 |
e0ne | it sounds like and API bug | 14:37 |
eharney | yeah but unless we have a backup-delete cascade option (i think we don't?) it's probably not actually a bug | 14:37 |
eharney | don't users have to delete dependent backups first? | 14:38 |
eharney | i forget | 14:38 |
rosmaita | yes, but the issue is that it's reporting that there isn't a dependent backup | 14:38 |
michael-mcaleer | from my own work with our own driver yes that was my experience | 14:38 |
rosmaita | when there is one in error state | 14:38 |
michael-mcaleer | yeah the CLI output should say has_dependent_backups = True | 14:39 |
eharney | i'm not sure it should say True if the second backup failed | 14:39 |
rosmaita | probably not, but you need to be able to find the failed backup somehow | 14:40 |
eharney | right | 14:40 |
michael-mcaleer | the failed backup is still linked to the backup, albeit just in namespace because it failed | 14:40 |
*** tmazur has joined #openstack-meeting-alt | 14:40 | |
michael-mcaleer | would has_failed_backups be more suitable? | 14:40 |
eharney | no | 14:40 |
eharney | we could have the delete failure message list the id of the second backup | 14:41 |
eharney | also should probably have a backup-delete --cascade option like we do for volume snaps to make this easier | 14:42 |
rosmaita | or auto-delete dependents that are in error state? | 14:42 |
rosmaita | but i agree that --cascade would be useful | 14:42 |
eharney | that could work too | 14:42 |
rosmaita | well, it looks like FengJiankui wants to work on it | 14:43 |
rosmaita | i'll leave a note for him on the bug | 14:43 |
michael-mcaleer | thats all from me this week, thanks everyone for the input | 14:43 |
rosmaita | if he can't make the meeting, mabye we can discuss on the ML | 14:43 |
rosmaita | thanks michael-mcaleer | 14:44 |
rosmaita | #topic specs | 14:44 |
*** openstack changes topic to "specs (Meeting topic: cinder)" | 14:44 | |
rosmaita | anyone here with questions about their spec proposal?/ | 14:44 |
rosmaita | i think i've left comment on everything but https://review.opendev.org/c/openstack/cinder-specs/+/764628 | 14:45 |
eharney | i vaguely remember discussing this glance ceph optimization years ago | 14:46 |
eharney | it's something we should look into, not sure if it needs a full spec process or not | 14:47 |
rosmaita | i guess a launchpad BP will do as a driver optimization | 14:48 |
rosmaita | thanks eric | 14:49 |
eharney | the proposal is basically: we currently optimize image->volume in situations where we can with ceph -- so do it in the other direction too | 14:49 |
rosmaita | well, if no one here has questions about their specs, we can move on | 14:51 |
rosmaita | just cinder-cores, please review specs so they can meet the freeze deadline | 14:52 |
rosmaita | #topic open discussion | 14:52 |
*** openstack changes topic to "open discussion (Meeting topic: cinder)" | 14:52 | |
eharney | someone added a line about mypy? | 14:53 |
michael-mcaleer | yeah that was my | 14:53 |
michael-mcaleer | me* | 14:53 |
michael-mcaleer | I started to look at some of the code submissions for myPy from walshh_ and although it is straight forward there is still some questions on how to properly review it | 14:53 |
eharney | well | 14:54 |
michael-mcaleer | things like when/when not to use myPy type settings, etc., its difficult because there is no reference correct way that things should be done | 14:54 |
eharney | running "tox -e mypy" and reading the html report will basically tell you if it's working | 14:54 |
eharney | type settings? | 14:54 |
michael-mcaleer | even at that, the uploaded patchset runs cleanly with mypy but I could see some methods where types are defined but others are not in different files and couldnt discern the difference why one function had them and another did not | 14:55 |
michael-mcaleer | type settings = wha the type is set to for input/return parameters for each function | 14:55 |
michael-mcaleer | what* | 14:55 |
eharney | yes, this is the sticking point for most reviewers i think -- trying to determine the goal for coverage to consider it good enough to merge | 14:56 |
michael-mcaleer | ok, makes sense, I was incorrectly under assumption it was full coverage but wasn't sure | 14:56 |
eharney | some people have been leaning that way, but i still question if that makes sense at the beginning of this | 14:56 |
michael-mcaleer | it's a lot of work to hit 100% coverage from what ive seen in the few submissions in already | 14:57 |
michael-mcaleer | not complicated changes, just a lot of them | 14:57 |
eharney | the problem is, even if you hit 100% coverage in a file, it won't actually be fully covered unless you also hit that in every file it imports etc | 14:57 |
eharney | so, we could do that, but i'm still not convinced it's the most efficient use of effort | 14:58 |
michael-mcaleer | no problem, that gives me a bit more direction with reviews for now anyway, I will wait for core reviewer comments to see if there is a consistent set of 'guidelines' or 'best practices' for this work | 14:59 |
rosmaita | let's discuss this in video next week | 14:59 |
michael-mcaleer | thanks eharney | 14:59 |
rosmaita | will be a bit easier to hash it out | 14:59 |
rosmaita | ok, we need to make room for horizon | 14:59 |
rosmaita | thanks for attending | 14:59 |
* eharney is out of the office next week | 14:59 | |
e0ne | rosmaita: thanks ;) | 14:59 |
rosmaita | please review specs! | 15:00 |
rosmaita | #endmeeting cinder | 15:00 |
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 15:00 | |
openstack | Meeting ended Wed Dec 16 15:00:13 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:00 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/cinder/2020/cinder.2020-12-16-14.00.html | 15:00 |
michael-mcaleer | same as me, ill catch up in the new year, have a great holiday everyone! | 15:00 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/cinder/2020/cinder.2020-12-16-14.00.txt | 15:00 |
openstack | Log: http://eavesdrop.openstack.org/meetings/cinder/2020/cinder.2020-12-16-14.00.log.html | 15:00 |
*** TusharTgite has left #openstack-meeting-alt | 15:00 | |
e0ne | #startmeeting horizon | 15:00 |
*** ecsantos has left #openstack-meeting-alt | 15:01 | |
tmazur | o/ | 15:01 |
vishalmanchanda | hi | 15:01 |
e0ne | where is openstack bot? | 15:01 |
*** belmoreira has joined #openstack-meeting-alt | 15:01 | |
e0ne | #startmeeting horizon | 15:01 |
e0ne | #startmeeting horizon | 15:01 |
openstack | Meeting started Wed Dec 16 15:01:33 2020 UTC and is due to finish in 60 minutes. The chair is e0ne. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
*** openstack changes topic to " (Meeting topic: horizon)" | 15:01 | |
openstack | The meeting name has been set to 'horizon' | 15:01 |
e0ne | oh.. it was my typo: a space before a command | 15:01 |
e0ne | let's start our meeting today | 15:03 |
e0ne | #topic Notices | 15:05 |
*** openstack changes topic to "Notices (Meeting topic: horizon)" | 15:05 | |
e0ne | nothing special for horizon thiss week | 15:06 |
*** zzzeek has quit IRC | 15:06 | |
e0ne | I would like tot say thanks everybody who works of fixing gate failures this week | 15:07 |
amotoki | note that rocky gate is still broken | 15:07 |
vishalmanchanda | Also I think all stable branches lower-constraints and npm-test job is still failing | 15:08 |
*** zzzeek has joined #openstack-meeting-alt | 15:08 | |
vishalmanchanda | I am sure about stable/victoria atleast | 15:08 |
e0ne | that's true:( | 15:09 |
e0ne | it's good that we know how to fix it | 15:09 |
vishalmanchanda | yup:) | 15:09 |
e0ne | a new pip release affects a lot of projects | 15:10 |
e0ne | it has more strict checks for dependencies | 15:10 |
amotoki | there are several failure modes now. a combo of pip and l-c is one which affects a lot. | 15:11 |
e0ne | +1 | 15:11 |
amotoki | I believe victoria failure is caused by l-c | 15:11 |
e0ne | amotoki: it does: https://zuul.opendev.org/t/openstack/build/e2476fa3a48e4c3dae1739e1f47d4bfd | 15:12 |
amotoki | yeah | 15:13 |
amotoki | browser stuff is a different thing but I am tno sure what actually triggers it. | 15:14 |
*** reddy has joined #openstack-meeting-alt | 15:14 | |
e0ne | I also kindly ask to add recheck comments while you're reviewing patches to master branch | 15:14 |
*** ralonsoh has quit IRC | 15:15 | |
e0ne | I'm surprised why browser tests failed on stable branches too | 15:15 |
*** ralonsoh has joined #openstack-meeting-alt | 15:15 | |
*** ricolin_ has joined #openstack-meeting-alt | 15:15 | |
amotoki | I wonder some change happened in chromium-browser package... | 15:15 |
amotoki | so it affects stable branches too | 15:16 |
e0ne | if there is no upper limit for a version, it becomes obvious | 15:16 |
e0ne | #link Bug deputy report | 15:22 |
*** lpetrut has quit IRC | 15:23 | |
e0ne | since most of us are working on gate fixes, I didn't fill this section | 15:23 |
e0ne | I'm working on a but from a previous meeting | 15:24 |
vishalmanchanda | I can be the volunteer for next week bug deputy report. | 15:24 |
e0ne | there are two new bugs in the queue https://bugs.launchpad.net/horizon/+bugs?search=Search&field.status=New&orderby=-datecreated&start=0 | 15:25 |
e0ne | vishalmanchanda: great! | 15:25 |
e0ne | #topic Open Discussion | 15:26 |
*** openstack changes topic to "Open Discussion (Meeting topic: horizon)" | 15:26 | |
e0ne | amotoki. tmazur, vishalmanchanda: do you have anything to discuss? | 15:27 |
amotoki | nothing from me | 15:27 |
e0ne | I've got two topic that came to me just before the meeting | 15:27 |
vishalmanchanda | e0ne: small update from my side. | 15:27 |
tmazur | nothing from my side. I am working on new tests failures now, after switching to Firefox | 15:27 |
e0ne | vishalmanchanda: sure, go ahead | 15:28 |
vishalmanchanda | As most of know due to this Chrome browser issue few horizon plugins are also failing. | 15:28 |
vishalmanchanda | So I have pushed patches for most of them Please take a look once you have time. | 15:29 |
tmazur | vishalmanchanda: I'll take a look today | 15:30 |
vishalmanchanda | Some plugins using phamtonjs and chrome browser so I have just removed chrome browser from them but not added firefox browser. | 15:30 |
vishalmanchanda | tmazur: thanks. | 15:30 |
e0ne | vishalmanchanda: please, add a link into the etherpad, so we won't lose it | 15:30 |
vishalmanchanda | e0ne: sure will do that. | 15:30 |
e0ne | vishalmanchanda: thanks | 15:30 |
vishalmanchanda | that's all from my side. | 15:31 |
amotoki | isn't better to announce it to the mailing list? | 15:32 |
amotoki | I don't want to make it done only by horizon-core | 15:32 |
e0ne | amotoki: good point | 15:32 |
vishalmanchanda | amotoki: +1. | 15:32 |
e0ne | rosmaita asked me if we can swap time slots with cinder team | 15:33 |
e0ne | it's one time earlier than horizon's meeting | 15:33 |
e0ne | cinder-core team has a lot of conflicts with other meetings, so they are going to change a meeting time | 15:34 |
e0ne | I know, we just voted few weeks ago to not change a meeting time | 15:34 |
amotoki | i have a conflict with neutron l3 meeting. if we swap, I will join here as background. | 15:34 |
e0ne | amotoki: I think it's a show-stopper for us | 15:35 |
tmazur | can we shift it one hour forward then as it was before? | 15:35 |
e0ne | tmazur: I'm afraid, it will be too late for amotoki and vishalmanchanda | 15:35 |
vishalmanchanda | e0ne: work for me atleast. | 15:36 |
amotoki | i cannot promise i will be there at 1am :) | 15:36 |
e0ne | let's leave it as is | 15:37 |
e0ne | I'll ping rosmaita with our decision | 15:37 |
amotoki | i understand e0ne is active in cinder too and it is worth considering | 15:37 |
e0ne | I'm pretty sure, we'll find a suitable time for cinder | 15:38 |
e0ne | the other topic I want to discuss is: | 15:38 |
e0ne | Fix Material theme to work with any combination of pyScss and MDI icons | 15:38 |
e0ne | #link https://review.opendev.org/c/openstack/horizon/+/730288 | 15:38 |
e0ne | amotoki: there is no good and easy solution to test it | 15:39 |
e0ne | amotoki: we can do it manually | 15:39 |
e0ne | amotoki: or add some tests to check if less is compiled into the correct css | 15:39 |
e0ne | but for such tests we have to do manual tests before | 15:40 |
e0ne | from the pyScss side, there are a lot of tests which are broken now :( | 15:40 |
e0ne | so I can't guarantee that it works without issues | 15:41 |
*** liuyulong has quit IRC | 15:42 | |
e0ne | but my patch fixes at least *all found* issues and makes material theme usable | 15:42 |
amotoki | previousy I checked it in some pages and also checked the compressed css is expected but it doesn't look enough or I missed something. | 15:42 |
e0ne | I can't hard push it, I can only say that I tested it both with our QA and we didn't find anything | 15:43 |
amotoki | so I am not sure how I can believe myself when voting +2... more eyes would be really appreciated. | 15:43 |
e0ne | amotoki: I absolutely agree with you | 15:44 |
e0ne | just for the note is patch should be tested using running horizon | 15:45 |
amotoki | it is okay to update the lower requirement in the master, but IIRC we broke some stable branches so we need to fix them at least. | 15:45 |
e0ne | amotoki: are you talking about our job failures? | 15:47 |
amotoki | e0ne: I am talking about MDI stuff | 15:48 |
amotoki | IIRC we support two versions of pyScss and a lower one does not work in stable branches | 15:48 |
e0ne | amotoki: we can change lower-contraint in stable branches if it's really needed | 15:49 |
amotoki | but I am not sure I remember it correctly | 15:49 |
e0ne | but it's better to do a fix without version bump | 15:49 |
e0ne | FYI, I checked my fix with victoria and ussuri too | 15:49 |
amotoki | at least if it works previously why we need to change it? I am not sure | 15:49 |
e0ne | it works with some issues | 15:51 |
e0ne | I'm not saying that we need to change a pyscss version | 15:51 |
e0ne | I just mentioned that it's a possible to do it if needed | 15:51 |
e0ne | that's everything from me according this topic | 15:53 |
vishalmanchanda | JFYI I have added few horizon plugin patch's with chrome issue resolved on our etherpad https://etherpad.opendev.org/p/horizon-release-priorities#61 | 15:56 |
e0ne | vishalmanchanda: thank you | 15:56 |
tmazur | vishalmanchanda, thank you! | 15:57 |
e0ne | thanks everybody for your contributions and see you next week | 15:57 |
e0ne | #endmeeting | 15:59 |
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 15:59 | |
openstack | Meeting ended Wed Dec 16 15:59:06 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:59 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/horizon/2020/horizon.2020-12-16-15.01.html | 15:59 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/horizon/2020/horizon.2020-12-16-15.01.txt | 15:59 |
openstack | Log: http://eavesdrop.openstack.org/meetings/horizon/2020/horizon.2020-12-16-15.01.log.html | 15:59 |
amotoki | o/ | 15:59 |
*** macz_ has joined #openstack-meeting-alt | 16:04 | |
*** ricolin_ has quit IRC | 16:31 | |
*** rafaelweingartne has quit IRC | 16:32 | |
*** ralonsoh is now known as ralonsoh|afk | 17:00 | |
*** gyee has joined #openstack-meeting-alt | 17:07 | |
*** belmoreira has quit IRC | 17:34 | |
*** michael-mcaleer has quit IRC | 18:11 | |
*** derekh has quit IRC | 18:26 | |
*** rdopiera has quit IRC | 18:54 | |
*** sangeet has joined #openstack-meeting-alt | 19:05 | |
*** sangeet has left #openstack-meeting-alt | 19:07 | |
*** zzzeek has quit IRC | 19:36 | |
*** zzzeek has joined #openstack-meeting-alt | 19:38 | |
*** e0ne has quit IRC | 19:52 | |
*** lbragstad_ is now known as lbragstad | 19:54 | |
*** zzzeek has quit IRC | 20:03 | |
*** zzzeek has joined #openstack-meeting-alt | 20:07 | |
*** zzzeek has quit IRC | 20:14 | |
*** zzzeek has joined #openstack-meeting-alt | 20:17 | |
*** zzzeek has quit IRC | 20:25 | |
*** zzzeek has joined #openstack-meeting-alt | 20:27 | |
*** enriquetaso has quit IRC | 20:49 | |
*** SpamapS has quit IRC | 20:53 | |
*** rfolco has quit IRC | 20:56 | |
*** vishalmanchanda has quit IRC | 20:56 | |
*** baojg has quit IRC | 21:15 | |
*** baojg has joined #openstack-meeting-alt | 21:16 | |
*** baojg has quit IRC | 21:19 | |
*** baojg has joined #openstack-meeting-alt | 21:20 | |
*** ralonsoh|afk has quit IRC | 22:09 | |
*** rcernin has joined #openstack-meeting-alt | 22:17 | |
*** raildo has quit IRC | 22:30 | |
*** slaweq has quit IRC | 22:42 | |
*** derekh has joined #openstack-meeting-alt | 22:58 | |
*** baojg has quit IRC | 23:25 | |
*** baojg has joined #openstack-meeting-alt | 23:26 | |
*** tmazur has quit IRC | 23:48 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!