*** hemna9 is now known as hemna | 06:36 | |
*** dviroel_ is now known as dviroel | 11:20 | |
*** dasm|off is now known as dasm | 13:03 | |
carloss | #startmeeting manila | 15:00 |
---|---|---|
opendevmeet | Meeting started Thu Jun 30 15:00:38 2022 UTC and is due to finish in 60 minutes. The chair is carloss. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
opendevmeet | The meeting name has been set to 'manila' | 15:00 |
gouthamr | o/ | 15:01 |
carloss | courtesy ping: ganso vkmc dviroel felipe_rodrigues ecsantos vhari fabiooliveira gouthamr | 15:01 |
felipe_rodrigues | o/ | 15:01 |
fabiooliveira | o/ | 15:01 |
luizsantos[m] | o/ | 15:01 |
nahimsouza[m] | oi | 15:02 |
caiquemello[m] | o/ | 15:02 |
dviroel_ | o/ | 15:03 |
vkmc | o/ | 15:03 |
carloss | o/ hi all | 15:04 |
carloss | great to have you here today | 15:04 |
carloss | let's get started with our meeting agenda | 15:04 |
ashrodri | o/ | 15:04 |
carloss | #link https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting | 15:04 |
carloss | #topic Announcements | 15:05 |
carloss | Schedule and Deadlines: | 15:05 |
carloss | #link https://releases.openstack.org/zed/schedule.html | 15:05 |
carloss | we are ~1 month away from our driver deadline | 15:06 |
carloss | and we have one candidate for this release: | 15:07 |
carloss | #link https://review.opendev.org/c/openstack/manila/+/825429 | 15:07 |
carloss | fzzf[m] has been working on the driver and the CI | 15:08 |
carloss | the CI seems to be reporting success and the logs are posted there, but apparently the tests are being skipped | 15:09 |
carloss | I'll ask the author | 15:09 |
carloss | but it would be nice if we could start giving some attention to this driver now, to have some anticipated feedback | 15:10 |
dviroel_ | +1 | 15:10 |
gouthamr | ++ | 15:11 |
carloss | I have added it to our review focus etherpad | 15:12 |
carloss | can I have some eyes on this? | 15:12 |
carloss | I can be one of the reviewers | 15:13 |
carloss | gouthamr, dviroel_ | 15:13 |
carloss | also would be nice to have some NetAppers eyes | 15:13 |
carloss | to help with other third party driver being added | 15:14 |
carloss | felipe_rodrigues ecsantos[m] sfernand | 15:14 |
gouthamr | carloss: ack, can do | 15:14 |
felipe_rodrigues | ack | 15:14 |
dviroel_ | me too | 15:16 |
carloss | thank you folks | 15:18 |
carloss | that's all I had for announcements | 15:18 |
carloss | is there any other announcement you would like to share with us today? | 15:18 |
* carloss will take that as a no | 15:20 | |
carloss | #topic Rechecks without reason/comments | 15:20 |
carloss | I briefly talked about this over the PTG where in a call the TC was chatting with the community about some rechecks without further comments | 15:21 |
carloss | they were trying to get us to spread with the community that it is important to add a comment to our rechecks | 15:21 |
carloss | it helps to make a bit more understandable why we are doing some rechecks | 15:22 |
carloss | and thinking more before actually triggering it | 15:23 |
carloss | this surfaced because we have lots and lots of jobs being run for every repository and sometimes our jobs fail due to lack of memory | 15:23 |
carloss | lack of memory which causes rabbit and mysql to fail as side effect | 15:24 |
carloss | so the whole point is to try to reduce the amount of jobs being run so everyone can get clean runs and CI won't have that many jobs running at the same time | 15:24 |
carloss | you may have seen an email from the openstack-discuss mailing list earlier today | 15:25 |
gouthamr | the stats are interesting | 15:25 |
carloss | #link http://lists.openstack.org/pipermail/openstack-discuss/2022-June/029342.html | 15:25 |
carloss | they shared some stats with us :) | 15:25 |
gouthamr | apparently we had 160 rechecks in the last 30 days | 15:25 |
gouthamr | and 108 of them we didn't provide a reason.. | 15:27 |
carloss | yep - that leaves us with a 67.5 rate of what they call "bare rechecks" | 15:27 |
gouthamr | i doubt this number a bit, but a bunch of this is probably our current issues with the stable branches | 15:28 |
gouthamr | but, point taken - we should triage the failure and recheck with reason | 15:29 |
felipe_rodrigues | I have never added the reason, btw :/ | 15:29 |
gouthamr | fire this guy ^ | 15:30 |
carloss | lol | 15:30 |
felipe_rodrigues | sorry | 15:30 |
caiquemello[m] | hahaha | 15:30 |
carloss | no problem, felipe_rodrigues - I have to confess that I used to do not add messages to the rechecks | 15:31 |
carloss | I've been doing it lately | 15:31 |
carloss | the only type of rechecks with messages that won't work are the experimental ones (I hit that issue some times) | 15:32 |
carloss | but yeah, only wanted to bring that up today to talk a bit again about those stats and the reasons why people are caring about those rechecks | 15:33 |
carloss | on to the next topic... | 15:33 |
carloss | #topic Review Focus | 15:33 |
carloss | #link https://etherpad.opendev.org/p/manila-zorilla-review-focus (Review Focus Etherpad) | 15:34 |
carloss | one of the changes of the review focus we have already talked about (the new driver) | 15:34 |
carloss | we have recently merged some code for OSC functional tests as well, so other changes may need a rebase | 15:34 |
carloss | we also have ashrodri's metadata api changes | 15:36 |
carloss | #link https://review.opendev.org/c/openstack/manila/+/825008 (Metadata for Share Snapshots Resource) | 15:36 |
carloss | thank you for the reviews felipe_rodrigues | 15:36 |
gouthamr | felipe_rodrigues++ thanks; /me will review this one today | 15:36 |
carloss | I will get back to that change, but as far as I've seen, it was looking good on the last time | 15:36 |
ashrodri | hey! yeah the snapshots metadata changes are still up for review. I recently added some share access rules ones im working though test failures on | 15:37 |
felipe_rodrigues | I promise review until Friday | 15:37 |
gouthamr | felipe_rodrigues: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/827925 -- you asked about the tests on your review; they're here | 15:37 |
felipe_rodrigues | all.. that's too long away | 15:37 |
felipe_rodrigues | I thought is another patch | 15:38 |
felipe_rodrigues | I already gave my +1.. I just asked to know | 15:39 |
felipe_rodrigues | it's fine to me! | 15:39 |
carloss | cool :) | 15:39 |
carloss | thanks | 15:39 |
carloss | is there any other change you would like to highlight? | 15:39 |
gouthamr | yes | 15:39 |
gouthamr | i wanted to see if we could review-jam some of the OSC changes | 15:40 |
gouthamr | #link https://review.opendev.org/c/openstack/python-manilaclient/+/836239 | 15:40 |
gouthamr | #link https://review.opendev.org/c/openstack/python-manilaclient/+/838233 | 15:40 |
gouthamr | #link https://review.opendev.org/c/openstack/python-manilaclient/+/802791 | 15:40 |
gouthamr | #link https://review.opendev.org/c/openstack/python-manilaclient/+/816401 | 15:40 |
gouthamr | #link https://review.opendev.org/c/openstack/python-manilaclient/+/805107 | 15:40 |
gouthamr | and ashrodri carloss maaritamm ecsantos[m] felipe_rodrigues, fix the merge conflicts here: https://review.opendev.org/q/topic:osc-functional-tests+status:open | 15:41 |
felipe_rodrigues | ack | 15:42 |
carloss | sure gouthamr | 15:42 |
ashrodri | will do :) | 15:42 |
carloss | awesome | 15:44 |
gouthamr | ++ thank you | 15:44 |
carloss | thanks for sharing these, the OSC parity is quite close, let's make this final push to get the remaining commands | 15:44 |
gouthamr | i guess we spoke about co-authors and reviewers for the code patches above | 15:44 |
carloss | ++ - we have that on the PTG notes | 15:44 |
gouthamr | ah true | 15:46 |
gouthamr | thanks for the pointer, i'd forgotten where we'd noted these | 15:46 |
gouthamr | #link https://etherpad.opendev.org/p/zorilla-ptg-manila-osc | 15:46 |
carloss | yep, this one | 15:46 |
carloss | thanks | 15:46 |
gouthamr | so its mostly myself, carloss vkmc and maaritamm | 15:46 |
gouthamr | guess we certainly could use some help! | 15:47 |
gouthamr | so if you've some bandwidth this week, please help.. | 15:47 |
carloss | ++ | 15:49 |
gouthamr | that's all i wanted to highlight | 15:50 |
carloss | thanks gouthamr :D | 15:50 |
gouthamr | nope, thanks for the reviews! | 15:50 |
carloss | #topic Bug Triage | 15:50 |
carloss | I think we still have some minutes for some bug triage | 15:51 |
carloss | #link https://etherpad.openstack.org/p/manila-bug-triage-pad-new (Bug Triage etherpad) | 15:51 |
carloss | vhari couldn't be here with us today, but kindly gathered the list for us to talk | 15:51 |
carloss | we have two stale bugs to talk about today | 15:51 |
carloss | #1 | 15:51 |
carloss | #link https://bugs.launchpad.net/manila/+bug/1585241 (Share Replication: File-based locks don't provide concurrency control in multi-node/multi-AZ deployments Edit) | 15:52 |
* carloss : please ignore the edit at the end of the title | 15:52 | |
carloss | this has been up for a while - is this in your future plans gouthamr? | 15:53 |
gouthamr | ah, this one is still an issue … we could bump down the importance; the fix is relatively simple but hasn’t been a priority | 15:53 |
gouthamr | We need to switch out the Oslo concurrency locks in the share manager with tooz locks (which we have the code for) | 15:54 |
gouthamr | hasn’t been a user concern though - just tech debt | 15:54 |
gouthamr | let’s bump this down to low and set a target - perhaps z3 | 15:55 |
carloss | sure gouthamr - thanks | 15:55 |
carloss | done | 15:55 |
carloss | agree with you on that | 15:55 |
carloss | cool, bug #2 | 15:56 |
carloss | #link https://bugs.launchpad.net/manila/+bug/1866951 ([db] default value for project_only allows non-secure access ) | 15:56 |
gouthamr | haha - both that im procrastinating on | 15:57 |
gouthamr | So this is a wishlist bug … we had a CVE that allowed cross project resource access; and someone suggested this as an alternative | 15:58 |
gouthamr | we could change the default and see if any existing regression tests catch anything | 15:59 |
gouthamr | anyone interested in picking this up as a low-hanging-fruit? | 16:00 |
carloss | cool one to work on :) | 16:00 |
* carloss checks time | 16:01 | |
carloss | thanks for mentioning the context on the issue gouthamr | 16:01 |
carloss | we can link the minutes of this call to the bug too | 16:01 |
carloss | and if there is someone willing to pick it up, pleas let us know | 16:02 |
gouthamr | ++ | 16:02 |
carloss | or just update the assignee on launchpad :p | 16:02 |
carloss | alright, we are 2 minutes over | 16:02 |
carloss | thank you all for joining this meeting today | 16:02 |
carloss | let's continue on #openstack-manila | 16:02 |
carloss | o/ | 16:02 |
gouthamr | thanks carloss | 16:02 |
carloss | #endmeeting | 16:02 |
opendevmeet | Meeting ended Thu Jun 30 16:02:41 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:02 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/manila/2022/manila.2022-06-30-15.00.html | 16:02 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/manila/2022/manila.2022-06-30-15.00.txt | 16:02 |
opendevmeet | Log: https://meetings.opendev.org/meetings/manila/2022/manila.2022-06-30-15.00.log.html | 16:02 |
*** dasm is now known as dasm|off | 20:42 | |
*** dviroel is now known as dviroel|afk | 20:42 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!