| *** dviroel|rover is now known as dviroel|out | 00:10 | |
| *** dviroel is now known as dviroel|rover | 12:12 | |
| whoami-rajat | #startmeeting cinder | 14:00 |
|---|---|---|
| opendevmeet | Meeting started Wed Jul 13 14:00:01 2022 UTC and is due to finish in 60 minutes. The chair is whoami-rajat. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cinder' | 14:00 |
| whoami-rajat | #topic roll call | 14:00 |
| eharney | hi | 14:00 |
| amalashenko | hi | 14:00 |
| simondodsley | hi | 14:00 |
| jungleboyj | o/ | 14:01 |
| aneeeshp13 | hi | 14:01 |
| nahimsouza[m] | o/ | 14:01 |
| rosmaita | o/ | 14:01 |
| whoami-rajat | #link https://etherpad.openstack.org/p/cinder-zed-meetings | 14:02 |
| caiquemello[m] | o/ | 14:02 |
| luizsantos[m] | o/ | 14:02 |
| whoami-rajat | hello | 14:03 |
| geguileo | hi! o/ | 14:04 |
| whoami-rajat | we've the usual people around | 14:04 |
| whoami-rajat | let's get started | 14:04 |
| whoami-rajat | #topic announcements | 14:04 |
| whoami-rajat | first, Deliverables check and library release | 14:04 |
| whoami-rajat | so all deliverable files exist for cinder projects (I've checked) so we don't need to do anything here | 14:04 |
| whoami-rajat | forgot to mention, it's from the release team mail | 14:05 |
| whoami-rajat | #link https://lists.openstack.org/pipermail/openstack-discuss/2022-July/029465.html | 14:05 |
| senrique__ | hi | 14:05 |
| *** senrique__ is now known as enriquetaso | 14:05 | |
| enriquetaso | hello | 14:05 |
| whoami-rajat | the release team has proposed some patches for cinderclient, brick and brick-cinderclient-ext for Zed milestone 2 release | 14:05 |
| whoami-rajat | I think we've some fixes for os-brick that should be released | 14:06 |
| whoami-rajat | not sure about other 2 projects | 14:06 |
| geguileo | whoami-rajat: I added a topic later because I'd like to have 4 patches in the release | 14:06 |
| geguileo | (for os-brick) | 14:06 |
| whoami-rajat | geguileo, ack, yeah i was referring to them | 14:06 |
| whoami-rajat | not sure about other projects, if we've something that needs to be released | 14:06 |
| geguileo | yeah, but I was slower writting it ;-) | 14:06 |
| whoami-rajat | I will check after the meeting and add a comment to the patches | 14:07 |
| whoami-rajat | :D | 14:07 |
| simondodsley | what about your NVMe patches for os-brick? | 14:07 |
| whoami-rajat | i think we can target them for the non-client lib release of Zed | 14:07 |
| whoami-rajat | due to our current priority of drivers, and long list of Nvme patches | 14:08 |
| geguileo | simondodsley: I would love to get those in, but those are huge, so I'm not sure we'll be able to get them | 14:08 |
| simondodsley | however in those long list of drivers are at least 3 NVMe divers | 14:08 |
| whoami-rajat | yep, those drivers will be part of Zed release and we are planning to get all Nvme brick patches in the same | 14:09 |
| aneeeshp13 | I just want to mention about https://review.opendev.org/c/openstack/os-brick/+/836062. This is a needed patch for the Fungible driver. | 14:09 |
| rosmaita | well, releases are cheap ... we can get the M-2 one out as soon as the ceph detach fix is in, and then do another shortly after with nvme changes | 14:10 |
| rosmaita | which it sounds like we will need to do with all the nvme drivers proposed | 14:10 |
| whoami-rajat | aneeeshp13, ack, i think we've them covered in the driver review list (that we will discuss later in the drivers topic) but thanks for mentioning | 14:11 |
| aneeeshp13 | okay thank you | 14:11 |
| jbernard | re releases, i have stable and z-2 patches pending, just let me know if i need to hold off, or update the hash to include something particular | 14:12 |
| whoami-rajat | jbernard, i think we will need to hold the os-brick z-2 patch until we get geguileo's changes in | 14:12 |
| jbernard | yup | 14:12 |
| geguileo | yeah, since I broke the RBD connector and we backported the broken patch :-( | 14:13 |
| whoami-rajat | but it's not released so we're kind of good? ^ | 14:13 |
| whoami-rajat | so moving on | 14:14 |
| whoami-rajat | next, M-2 week | 14:14 |
| whoami-rajat | this week is milestone 2 release | 14:15 |
| whoami-rajat | #link https://releases.openstack.org/zed/schedule.html | 14:15 |
| whoami-rajat | as per the schedule, we've new volume drivers and new target drivers deadline this week | 14:15 |
| whoami-rajat | but i will discuss that in a later topic | 14:15 |
| whoami-rajat | just wanted to mention that as an announcement | 14:16 |
| whoami-rajat | I don't think we've any new target driver proposed this cycle? | 14:16 |
| whoami-rajat | I remember geguileo working on fixing the nvme target driver in cinder but that already exists so not new | 14:17 |
| geguileo | yeah, I have a buch of bug fixes and improvements so that anybody can test NVMe-oF without real hardware | 14:18 |
| rosmaita | geguileo: ++ | 14:18 |
| whoami-rajat | sounds great | 14:18 |
| whoami-rajat | so let's move to topics | 14:19 |
| whoami-rajat | #topic Requesting 4 os-brick patches to be included in the release | 14:19 |
| whoami-rajat | geguileo, that's you | 14:19 |
| geguileo | thanks | 14:19 |
| geguileo | I wanted to ask for reviews on 4 os-brick patches that I think are kind of important | 14:19 |
| geguileo | and I'd like to see them in the release | 14:19 |
| geguileo | the first one is the one that fixes the RBD connector | 14:20 |
| geguileo | it's horribly broken for encrypte volumes | 14:20 |
| geguileo | #link https://review.opendev.org/c/openstack/os-brick/+/849542 | 14:20 |
| geguileo | it's a small one | 14:20 |
| geguileo | the next one is to make extending LUKSv2 volumes work | 14:21 |
| eharney | not sure if you saw my question there, but i convinced myself it's probably fine | 14:21 |
| geguileo | because they currently don't work | 14:21 |
| geguileo | eharney: I didn't, was fighting a different battle, will look after the meeting | 14:21 |
| enriquetaso | oh i thought the question was closed, my bad | 14:21 |
| geguileo | https://review.opendev.org/c/openstack/os-brick/+/836059 | 14:21 |
| geguileo | #link https://review.opendev.org/c/openstack/os-brick/+/836059 | 14:22 |
| rosmaita | eharney: i think your question was more about hardening and not about the patch being incorrect? | 14:22 |
| geguileo | there is a Nova and Tempest test that depend on that one | 14:22 |
| eharney | rosmaita: it was about whether we had actually considered all the types of objects that could be passed into that method | 14:22 |
| rosmaita | yeah, that's what i meant | 14:23 |
| geguileo | eharney: oh, I see your question now... I don't think we return anything that's not a str | 14:23 |
| geguileo | eharney: I'll have a quick look at the different connectors and reply | 14:23 |
| geguileo | the 3rd patch is a simple one, it's about removing a traceback from the os-brick logs every time the get_connector_properties method is called | 14:24 |
| geguileo | it happens if the nvme command is not installed on the system | 14:25 |
| geguileo | #link https://review.opendev.org/c/openstack/os-brick/+/836055 | 14:25 |
| eharney | re: 836059 i'm a little unsure if we should be adding any functionality to the cryptsetup encryptor, but i'll leave a comment for later discussion | 14:25 |
| geguileo | eharney: ok, we can continue the conversation there | 14:26 |
| geguileo | I admit that I wrote that code 4 months ago, so I'll have to refresh my memory ;-) | 14:26 |
| geguileo | The last patch is a patch related to the path_lock configuration option from oslo_concurrency | 14:27 |
| geguileo | os-brick now uses file locks for some critical sections | 14:27 |
| geguileo | and it uses the lock_path from the service that uses os-brick | 14:27 |
| geguileo | but there are cases where multiple services need to use the same location for os-brick locks | 14:27 |
| geguileo | for example HCI systems | 14:27 |
| geguileo | Glance using Cinder as the backend and running on the same host | 14:28 |
| geguileo | one solution is to configure all the services with the same lock_path | 14:28 |
| geguileo | but then you have ALL services using the same directory for their locks, which is not "clean" | 14:28 |
| geguileo | the patch adds support for os-brick to have its own lock_path independent of the one from the service (though defaulting to it) | 14:29 |
| geguileo | #link https://review.opendev.org/c/openstack/os-brick/+/849324 | 14:29 |
| geguileo | this effort has patches on other projects | 14:29 |
| *** dasm|off is now known as dasm | 14:29 | |
| rosmaita | quick question about that one ... you explained clearly in the commit message why the fix requires calling os_brick.setup by consuming services ... what happens if they forget? I think we don't get current behavior, lock_path will be None and in that case oslo.concurrency code will barf an exception? | 14:29 |
| geguileo | nova, cinder, glance, glance-store, devstack | 14:29 |
| geguileo | rosmaita: oh, good point! | 14:30 |
| rosmaita | (or maybe we discuss later in cinder channel after bug squad meeting) | 14:30 |
| geguileo | rosmaita: I'll see if the best way to do it is to fix that scenario in os-brick | 14:31 |
| enriquetaso | sure | 14:31 |
| geguileo | or if we need to merge the other patches first to ensure services use it... | 14:31 |
| rosmaita | yeah, we have a chicken-egg problem | 14:31 |
| geguileo | rosmaita: yea, but I think it should be ok to fail if services don't call the method | 14:32 |
| geguileo | I'll have a look to see if there's a nicer way of doing it | 14:33 |
| rosmaita | yeah, i was hoping maybe | 14:33 |
| rosmaita | let's talk after bug squad | 14:33 |
| geguileo | I may be able to do it automagically | 14:33 |
| geguileo | ok | 14:33 |
| geguileo | well, those are the 4 patches I'd like to see merged | 14:33 |
| geguileo | and thanks for those questions now!! | 14:34 |
| whoami-rajat | thanks geguileo for all the fixes and also giving a brief overview so it becomes easier to review | 14:34 |
| rosmaita | yes, geguileo is the master commit-message-writer | 14:35 |
| enriquetaso | ++ | 14:35 |
| geguileo | lol | 14:35 |
| whoami-rajat | geguileo's commit message should be examples in the doc "How to write a commit message" | 14:35 |
| rosmaita | the doc could just be a gerrit search for geguileo's patches | 14:36 |
| whoami-rajat | so coming back to the topics, let's move on to next topic | 14:36 |
| whoami-rajat | that should also work great | 14:36 |
| whoami-rajat | #topic Extend driver merge deadline | 14:36 |
| whoami-rajat | With the limited amount of time and a big number of drivers proposed this cycle, I would like to extend the deadline to R-10 | 14:37 |
| whoami-rajat | actually rosmaita and I have discussed this | 14:37 |
| whoami-rajat | I will send out a mail to ML, but before that i wanted to bring this to the cinder team | 14:37 |
| whoami-rajat | as per the current schedule, other projects also have driver merge after M-2 | 14:37 |
| whoami-rajat | like R-10 is also Manila new driver merge deadline so it shouldn't be too controversial to reschedule the cinder deadline | 14:38 |
| whoami-rajat | and 2 weeks time should be sufficient to get most (if not all) of the drivers in a working condition and merged | 14:38 |
| simondodsley | My concern is that the NVMe drivers can't merge without the os-brick patches they depend on | 14:39 |
| whoami-rajat | simondodsley, oh, I might have misunderstood the concern before, so we need those os-brick changes released for NVMe drivers to work ... | 14:39 |
| simondodsley | yes - the patches are related to multipathing and a complete refactor of the connector | 14:40 |
| rosmaita | we may have to adjust our ordering of reviews, i guess | 14:40 |
| whoami-rajat | I guess we can do what rosmaita suggested, is to do another brick release shortly | 14:40 |
| whoami-rajat | yeah, need to prioritize the brick patches | 14:41 |
| rosmaita | also, powerflex nvme/tcp driver does not seem to have a patch up | 14:41 |
| simondodsley | not sure if the other NVMe drivers are aware of the patched geguileo has created | 14:41 |
| rosmaita | so we can eliminate that one | 14:41 |
| rosmaita | (maybe) | 14:41 |
| simondodsley | Fungable, Pure and the other DEMC driver | 14:41 |
| rosmaita | and is anyone here from fungible? i can't find a third-party CI for them | 14:41 |
| simondodsley | they should all depend on the new patches | 14:41 |
| whoami-rajat | yeah if the patches aren't proposed yet then no point in prioritizing them after the extended deadline | 14:41 |
| whoami-rajat | for the powerflex nvme driver i mean ^ | 14:42 |
| rosmaita | what i mean is that i think a pre-requisite for getting an extension is that the ci should at least be partially working | 14:42 |
| aneeeshp13 | rosmaita I represent Fungible. I am actively working on the CI. It should be up by end of this week hopefully. | 14:42 |
| whoami-rajat | aneeeshp13, i think you're from fungible? | 14:42 |
| whoami-rajat | ok | 14:42 |
| amalashenko | DEMC here, we updated our CI for NFS driver | 14:43 |
| rosmaita | amalashenko: ok, thanks | 14:43 |
| rosmaita | aneeeshp13: i think we should not prioritize fungible driver for reviews until after the ci is available | 14:44 |
| rosmaita | because it cannot merge without the ci working | 14:44 |
| rosmaita | sucks, i know, but we have too many drivers and too few reviewers | 14:44 |
| whoami-rajat | with that note ^ let's move to the next topic which is the main topic for drivers and we can discuss more things in that | 14:45 |
| whoami-rajat | #topic Driver review | 14:45 |
| rosmaita | ok, sorry | 14:45 |
| whoami-rajat | (and we also have less time) | 14:46 |
| aneeeshp13 | rosmaita okay. np. Will try to bring the CI ASAP. | 14:46 |
| whoami-rajat | #link https://etherpad.opendev.org/p/cinder-zed-new-drivers | 14:46 |
| whoami-rajat | Brian and I have worked on the etherpad to include all the drivers that are proposed for Zed | 14:46 |
| whoami-rajat | Since there are 8 drivers, it is not feasible for only few cores to review all the drivers | 14:46 |
| whoami-rajat | Hence each core should adopt at least 1 driver for review | 14:46 |
| whoami-rajat | There is a reviewers section below the driver patches, cores interested in the driver review can add their names | 14:46 |
| rosmaita | before we do that, let's quickly look at the ordering | 14:47 |
| whoami-rajat | (just pasting notes from the meeting etherpad to quickly summarize it) | 14:47 |
| whoami-rajat | ok | 14:47 |
| sfernand | could you paste the link here | 14:47 |
| sfernand | I will help with reviews | 14:47 |
| rosmaita | #link https://etherpad.opendev.org/p/cinder-zed-new-drivers | 14:47 |
| rosmaita | anyone here from yadro? | 14:48 |
| simondodsley | when did it become a requirement for 3rd party CIs to respond to os-brick patches? | 14:48 |
| rosmaita | i thought it was always a requirement? | 14:49 |
| rosmaita | maybe i just made it up, though | 14:49 |
| simondodsley | never been flagged before that i know of - i can do it, but just wondering | 14:49 |
| simondodsley | it does make sense | 14:49 |
| rosmaita | cinder tests using a released os-brick, so if we dont' test against brick directly, we don't know that something is broken until too late | 14:50 |
| whoami-rajat | i don't think a lot of drivers do it right now but looks like a good thing to do | 14:50 |
| simondodsley | yes - i'm seeing that now with my NVMe driver | 14:50 |
| eharney | IIRC, it was a bit of an issue recently that no FC drivers were reporting on os-brick | 14:50 |
| rosmaita | if it's a new (unstated) requirement, we can make it a nice-to-have for cinder driver approval in Zed, and change it for 2023.1 | 14:51 |
| simondodsley | all the nvme patches for os-brick are not being tested without it and so the current nvme drivers are testing against bad code | 14:51 |
| whoami-rajat | rosmaita, sounds good, would be good to add that in the driver review checklist doc | 14:51 |
| rosmaita | ok, i will post an update | 14:52 |
| whoami-rajat | great thanks | 14:52 |
| rosmaita | and also update the wiki | 14:52 |
| sfernand | yep I believe it makes sense to test os-brick | 14:52 |
| sfernand | but I wasn't aware it was a hard requirement, my bad | 14:52 |
| sfernand | NetApp CI used to have a os-brick job on Zuul v2 but we haven't ported it yet | 14:52 |
| whoami-rajat | yeah, some vendors reference from the wiki ... | 14:52 |
| *** dviroel|rover is now known as dviroel|rover|biab | 14:53 | |
| whoami-rajat | sfernand, i don't think it's a hard requirement as of now but it will be good if vendors do it | 14:53 |
| sfernand | whoami-rajat: yes got it! | 14:53 |
| whoami-rajat | great | 14:53 |
| whoami-rajat | so quickly discussing the main point, there are a lot of drivers and few reviewers, so wanted everyone to take one driver for reviewing | 14:54 |
| whoami-rajat | each driver requires 2 cores | 14:54 |
| whoami-rajat | I've added a reviewers section for each driver in the etherpad | 14:55 |
| whoami-rajat | please add your names if you're interested in looking at a particular one | 14:55 |
| rosmaita | i will sign up for yadro, just because i feel bad about having to postpone them in yoga | 14:55 |
| whoami-rajat | rosmaita, cool, I've already added my name for it so we've 2 for that | 14:55 |
| whoami-rajat | Data core is merged so no need to worry about that | 14:55 |
| rosmaita | who said they are from DEMC? do you know the status of the powerstore nvme/tcp CI ? | 14:56 |
| whoami-rajat | eharney has signed up for nfs, great! | 14:56 |
| amalashenko | I am from DEMC and Oleg | 14:57 |
| olegnest | rosmaita: working on it, will be done within this week | 14:57 |
| whoami-rajat | so people can add names after the meeting as well, just wanted to mention it here | 14:57 |
| rosmaita | olegnest: thanks | 14:57 |
| jungleboyj | I put my name on a couple. | 14:58 |
| whoami-rajat | thanks | 14:58 |
| whoami-rajat | we've 2 minutes, i guess we can quickly discuss geguileo's topic | 14:58 |
| rosmaita | since we are running out of time, whoami-rajat and i will re-order the patches after the meeting so that they are in priority order | 14:58 |
| whoami-rajat | #topic Enable Ceph CI jobs | 14:58 |
| whoami-rajat | rosmaita ++ | 14:58 |
| enriquetaso | i think powerstore CI shouldn't be working due to https://bugs.launchpad.net/cinder/+bug/1981068 | 14:58 |
| geguileo | well, just wanted to mention that I broke the RBD connector in os-brick | 14:59 |
| geguileo | and we didn't notice because we all forgot to check the ceph job :-( | 14:59 |
| geguileo | so I wanted to bring up the topic we discussed a couple of weeks back | 14:59 |
| geguileo | enabling ceph jobs on os-brick and cinder | 14:59 |
| whoami-rajat | yep, discussed for nfs ceph jobs to make them voting | 15:00 |
| rosmaita | that os-brick job looks pretty unstable | 15:00 |
| olegnest | sry, i'm a new here. Can I ask one question or probably I should do it in another channel? | 15:00 |
| rosmaita | maybe we could only run it on changes to the rbd connector or something? | 15:00 |
| whoami-rajat | olegnest, you can ask in the #openstack-cinder channel anytime | 15:00 |
| rosmaita | because i dont' think we can make it voting and ever merge anything | 15:01 |
| olegnest | thanks | 15:01 |
| geguileo | rosmaita: can we make it always run and only voting if there are code changes to its connector code? | 15:01 |
| rosmaita | we can specify irreleveant files for that job | 15:02 |
| geguileo | rosmaita: but that's different... | 15:02 |
| rosmaita | and i think there's a relevent_files also | 15:02 |
| geguileo | that means it only runs when that file changes, which is different | 15:02 |
| geguileo | because we may be breaking the job when changing something that is not in the Ceph job | 15:03 |
| geguileo | sorry, not in the rbd connector code | 15:03 |
| geguileo | so fi the job doesn't even run then reviewers don't even have the possibility of seeing that it's failing | 15:03 |
| rosmaita | well, we could have 2 jobs, one nonvoting on everything, and the other voting only on rbd changes | 15:03 |
| geguileo | or we can make the non-voting not vote when there are changes to RBD connector | 15:04 |
| geguileo | that way only 1 of them runs, right? | 15:04 |
| geguileo | is that possible? | 15:04 |
| rosmaita | not sure | 15:04 |
| geguileo | rosmaita: you don't like any of my ideas :-P | 15:04 |
| rosmaita | but maybe | 15:04 |
| rosmaita | lol | 15:04 |
| whoami-rajat | not sure if that is possible but rosmaita's idea looks clean | 15:04 |
| geguileo | ok, I think we should at least have RBD job vote for its code changes | 15:04 |
| rosmaita | i agree, it's too easy to miss otherwise | 15:05 |
| whoami-rajat | okay we're way overtime than our schedule, let's continue the discussion in cinder channel after BS meeting | 15:05 |
| rosmaita | ok, i will take an action item to try to get something together, if geguileo can give me what files should be relevant for voting | 15:05 |
| whoami-rajat | thanks everyone! | 15:05 |
| whoami-rajat | #endmeeting | 15:05 |
| opendevmeet | Meeting ended Wed Jul 13 15:05:54 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:05 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder/2022/cinder.2022-07-13-14.00.html | 15:05 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder/2022/cinder.2022-07-13-14.00.txt | 15:05 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder/2022/cinder.2022-07-13-14.00.log.html | 15:05 |
| geguileo | rosmaita: thanks! | 15:05 |
| *** dviroel|rover|biab is now known as dviroel|rover | 16:11 | |
| *** dviroel__ is now known as dviroel|rover|biab | 16:42 | |
| *** dviroel|rover|biab is now known as dviroel|rover | 17:21 | |
| *** dasm is now known as dasm|off | 22:08 | |
| *** dviroel|rover is now known as dviroel|rover|Afk | 22:58 | |
| *** dviroel|rover|Afk is now known as dviroel|rover | 23:57 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!