| *** dviroel|out is now known as dviroel|rover | 11:12 | |
| *** dasm|off is now known as dasm | 12:18 | |
| rosmaita | #startmeeting cinder | 14:00 |
|---|---|---|
| opendevmeet | Meeting started Wed Dec 14 14:00:05 2022 UTC and is due to finish in 60 minutes. The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cinder' | 14:00 |
| rosmaita | #topic roll call | 14:00 |
| rosmaita | o/ | 14:00 |
| eharney | hi | 14:00 |
| felipe_rodrigues | hi | 14:00 |
| kgube | hi | 14:00 |
| rosmaita | #link https://etherpad.opendev.org/p/cinder-antelope-meetings | 14:01 |
| happystacker | hello! | 14:01 |
| simondodsley | hi | 14:01 |
| rosmaita | ok, i guess we can get started | 14:02 |
| ganso | o/ | 14:02 |
| jungleboyj | o/ | 14:02 |
| happystacker | o/ | 14:03 |
| rosmaita | (Rajat is stuck on a customer call, that's why I'm chairing the meeting) | 14:03 |
| enriquetaso | hi | 14:03 |
| rosmaita | #topic announcements | 14:03 |
| rosmaita | 1 - cinderlib release tomorrow | 14:03 |
| rosmaita | (we'll talk more about this later) | 14:04 |
| rosmaita | 2 - spec freeze: Friday 16 December 2022 (23:59 UTC) | 14:04 |
| rosmaita | 3 - Festival of XS Reviews on Friday ??? | 14:04 |
| rosmaita | Rajat sent an email asking whether people would be able to attend on Friday | 14:04 |
| rosmaita | #link https://lists.openstack.org/pipermail/openstack-discuss/2022-December/031498.html | 14:05 |
| happystacker | can you clarify on what the spec freeze is? I have a few patches to be reviewed, how will I be impacted by that? | 14:05 |
| rosmaita | but there's been no response, last time i checked | 14:05 |
| rosmaita | happystacker: sure | 14:05 |
| rosmaita | big features require a spec to be approved first, before patches can be merged | 14:05 |
| rosmaita | and since they're big, there's a deadline for filing a spec | 14:06 |
| rosmaita | so the spec needs to be approved by friday, and then the code by milestone-3 | 14:06 |
| rosmaita | so "regular" patches aren't affected by the spec freeze | 14:06 |
| rosmaita | happystacker: does that answer your question? | 14:07 |
| happystacker | ok cool, the spec I was working on (PowerFlex 8GB increment) won't land into Antelope, as I don't have time to do it, so we're good then | 14:07 |
| happystacker | yes absolutely, thanks Brian | 14:07 |
| rosmaita | great | 14:07 |
| rosmaita | ok, back to the Festival of Reviews on friday ... will anyone be around? | 14:08 |
| rosmaita | turnout on the past 2 festivals has been pretty low | 14:08 |
| rosmaita | i hope people aren't losing interest | 14:08 |
| rosmaita | (this is where someone says "yes, i'll be here, we should have the Festival") | 14:08 |
| jungleboyj | I think it has been a busy time of year. | 14:09 |
| rosmaita | jungleboyj: ++ | 14:09 |
| happystacker | I'll be there | 14:09 |
| happystacker | even if I'm not a big contributor | 14:09 |
| jungleboyj | Probably the same for this Friday. :-) | 14:09 |
| rosmaita | i'll be there too | 14:09 |
| rosmaita | OK, let's have it as usual! | 14:09 |
| happystacker | ok | 14:10 |
| jungleboyj | I will try to join for the last hour. | 14:10 |
| rosmaita | #action rosmaita - reply to Rajat's email to say that we will have the festival on friday | 14:10 |
| rosmaita | jungleboyj: sounds good | 14:10 |
| rosmaita | and everyone else, remember that you can always use the Festival dashboard to do reviews on your own | 14:10 |
| rosmaita | you can find it here: https://etherpad.opendev.org/p/cinder-festival-of-reviews | 14:11 |
| simondodsley | I will try and get to it as well | 14:11 |
| happystacker | just to let you know that we have a reorg at dell, and I'm pushing hard to the rest of team that we need to contribute MORE than we do now | 14:11 |
| happystacker | yes, will look into it | 14:11 |
| rosmaita | happystacker: ++ | 14:11 |
| jungleboyj | happystacker: ++ Hope it goes well. | 14:12 |
| rosmaita | ok, and as incentive, remember that anyone who attends can nominate one of their own patches for special attention | 14:12 |
| happystacker | exciting times, I guess yes | 14:12 |
| rosmaita | ok, that's all the announcements | 14:13 |
| rosmaita | #topic reviews needed for cinderlib release | 14:13 |
| rosmaita | whoami-rajat and I finally got the cinderlib gate un-clogged so that we can merge Zed patches | 14:14 |
| rosmaita | just in time, because the release is supposed to happen tomorrow | 14:14 |
| whoami-rajat | mostly rosmaita , thanks a lot for fixing it! | 14:14 |
| rosmaita | there is a stack of patches that need reviews | 14:14 |
| rosmaita | well, "fixing" may be overstating it | 14:15 |
| rosmaita | it turned out that the big problem was unit test isolation | 14:15 |
| rosmaita | which suddenly stopped working and tests were interferring with each other all over the place | 14:15 |
| rosmaita | i really don't understand it, so there's room for someone to dig in and figure out wtf | 14:15 |
| rosmaita | anyway, the big change on https://review.opendev.org/c/openstack/cinderlib/+/867132/ is to run our unit tests in 3 batches and combine the results | 14:16 |
| enriquetaso | Sorry, I'll be on the festival this friday too | 14:16 |
| rosmaita | enriquetaso: ++ | 14:16 |
| rosmaita | i tested it out and the combination works, the only weird thing is that you may have to scroll back to see which set of tests failed | 14:17 |
| rosmaita | anyway, since rajat and I did the first patch, we definitely need another core to review it | 14:18 |
| rosmaita | #link https://review.opendev.org/c/openstack/cinderlib/+/867132/ | 14:18 |
| rosmaita | (this is where I stop and wait for someone to volunteer) | 14:18 |
| jungleboyj | I can take a look. :-) | 14:19 |
| enriquetaso | sure | 14:19 |
| enriquetaso | i can too | 14:19 |
| rosmaita | 2 is better! | 14:19 |
| rosmaita | thanks | 14:19 |
| jungleboyj | That should be good then. | 14:19 |
| rosmaita | the "open for zed" patch is kind of big, but it's not complicated | 14:19 |
| rosmaita | well, it actually is, i guess, but there's documentation explaining exactly what it does | 14:20 |
| rosmaita | #link https://docs.openstack.org/cinderlib/latest/contributor/contributing.html#cinderlib-tox-and-zuul-configuration-maintenance | 14:20 |
| rosmaita | (took me a minute to find it) | 14:21 |
| rosmaita | the other patches in the stack are pretty small and self-explanatory, and one even already has 2 +2s | 14:21 |
| rosmaita | you can find them by going to https://review.opendev.org/c/openstack/cinderlib/+/867132/ and looking at the "Relation chain" in the gerrit interface | 14:22 |
| rosmaita | ok, thanks jungleboyj and enriquetaso | 14:23 |
| rosmaita | #topic reminder: re-review of https://review.opendev.org/c/openstack/cinder/+/812685 | 14:23 |
| rosmaita | i will take a look later today | 14:23 |
| rosmaita | (I've kind of been busy with cinderlib) | 14:23 |
| rosmaita | there's a new PS up addressing earlier comments, so let's keep moving this along | 14:24 |
| rosmaita | ganso: anything to add? | 14:24 |
| ganso | rosmaita: nothing to add =) | 14:24 |
| rosmaita | cool | 14:24 |
| rosmaita | #topic request core reviews of Pure driver patches | 14:25 |
| rosmaita | kind of self-explanatory | 14:25 |
| rosmaita | #link https://review.opendev.org/c/openstack/cinder/+/855060 | 14:25 |
| rosmaita | which is a bugfix, and | 14:25 |
| rosmaita | #link https://review.opendev.org/c/openstack/cinder/+/862365 | 14:25 |
| rosmaita | which adds a feature | 14:25 |
| rosmaita | simondodsley: anything to add? | 14:25 |
| simondodsley | Nope - passing Pure CI and main Zuul. Need some eyes on | 14:26 |
| rosmaita | ok, thanks | 14:26 |
| rosmaita | #topic request review of attached extend spec for NFS drivers | 14:26 |
| rosmaita | this is timely with the freeze fast approaching | 14:26 |
| rosmaita | #link https://review.opendev.org/c/openstack/cinder-specs/+/866718 | 14:27 |
| rosmaita | kgube has rewritten it to address comments from the nova team about what they find acceptable | 14:27 |
| rosmaita | kgube: anything to add? | 14:27 |
| kgube | yeah, it was on hold, because the spec was rewritten and there was no feedback from nova on the new direction | 14:27 |
| kgube | ive finally gotten feedback that the direction is acceptable | 14:27 |
| kgube | for them | 14:28 |
| rosmaita | great | 14:28 |
| kgube | of course, i don'tr know if I even still have a chance of this making freeze | 14:28 |
| rosmaita | eharney: maybe you could put this on your list to review? | 14:28 |
| rosmaita | kgube: i think you can make a case for a freeze extension if that becomes necessary | 14:29 |
| rosmaita | (though it will be up to the PTL to decide) | 14:29 |
| eharney | i'll take a look at it | 14:29 |
| kgube | thanks! | 14:29 |
| rosmaita | ok, that covers our agenda for today | 14:30 |
| rosmaita | #topic open discussion | 14:30 |
| inori | Excuse me, I'd like to bring attention in these patches here. | 14:30 |
| inori | https://review.opendev.org/q/owner:inori | 14:30 |
| inori | These are patches that I've submitted and most of them have passed the CI. Because there's a large difference between our "enterprise" and "community" drivers, so we want to merge them as eraly as possible. | 14:31 |
| inori | So could you please review or reply them at your earliest convenience? | 14:31 |
| rosmaita | your plan is to get all the features from the "enterprise" edition into the community driver? | 14:31 |
| inori | Yes, we do. And now we've submitted some of them. | 14:32 |
| rosmaita | sounds good ... was it your driver where there was a question about versioning, or was that someone else? | 14:33 |
| inori | Most of the patches I submiteed have passed the CI, but there's no one reviewed or reply them. | 14:35 |
| rosmaita | guess it was some other driver if you don't know what I"m talking about! | 14:35 |
| rosmaita | ok, looks like they are independent patches, so the order of reviewing doesn't matter? | 14:36 |
| inori | yes, taht's true. | 14:36 |
| rosmaita | ok, sounds good | 14:37 |
| rosmaita | sounds like we are out of discussion topics | 14:38 |
| rosmaita | thanks everyone ... please use your 20 minutes of free time to review something mentioned in today's meeting! | 14:38 |
| rosmaita | #endmeeting | 14:39 |
| opendevmeet | Meeting ended Wed Dec 14 14:39:00 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:39 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder/2022/cinder.2022-12-14-14.00.html | 14:39 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder/2022/cinder.2022-12-14-14.00.txt | 14:39 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder/2022/cinder.2022-12-14-14.00.log.html | 14:39 |
| jungleboyj | Thanks rosmaita ! | 14:39 |
| inori | but this patch: https://review.opendev.org/c/openstack/cinder/+/847730, core reviewers have comment it, and I responsed the commets, but no other reply from core reviewers. | 14:39 |
| rosmaita | ok, hopefully people will get back to it soon | 14:40 |
| inori | It will be great if you could review and comment on them at your earliest convenience. | 14:44 |
| *** dviroel|rover is now known as dviroel|rover|lunch | 15:52 | |
| *** dviroel|rover|lunch is now known as dviroel|rover | 16:38 | |
| *** tosky_ is now known as tosky | 21:12 | |
| *** dasm is now known as dasm|off | 21:26 | |
| *** dviroel|rover is now known as dviroel|out | 21:31 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!