| *** dviroel_ is now known as dviroel | 11:21 | |
| *** dasm|off is now known as dasm | 13:59 | |
| whoami-rajat | #startmeeting cinder | 14:00 |
|---|---|---|
| opendevmeet | Meeting started Wed Jan 25 14:00:00 2023 UTC and is due to finish in 60 minutes. The chair is whoami-rajat. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cinder' | 14:00 |
| whoami-rajat | #topic roll call | 14:00 |
| simondodsley | o/ | 14:00 |
| tobias-urdin | o/ | 14:01 |
| rosmaita | o/ | 14:01 |
| eharney | hi | 14:01 |
| whoami-rajat | #link https://etherpad.opendev.org/p/cinder-antelope-meetings | 14:01 |
| nahimsouza[m] | o/ | 14:02 |
| happystacker | Hello! | 14:02 |
| keerthivasansuresh | o/ | 14:03 |
| enriquetaso | hi | 14:03 |
| geguileo | hi! | 14:03 |
| whoami-rajat | hello everyone | 14:03 |
| abdi | Hi | 14:03 |
| whoami-rajat | let's get started | 14:03 |
| felipe_rodrigues | hi | 14:03 |
| thiagoalvoravel | o/ | 14:03 |
| gksk | HI | 14:04 |
| ganso | o/ | 14:04 |
| whoami-rajat | #topic announcements | 14:04 |
| whoami-rajat | Security issue with VMDK format | 14:04 |
| whoami-rajat | #link https://security.openstack.org/ossa/OSSA-2023-002.html | 14:04 |
| whoami-rajat | rosmaita, will cover this since he's been working on it | 14:04 |
| rosmaita | sure | 14:05 |
| rosmaita | i see Rajat already posted the link to the patches | 14:05 |
| rosmaita | we are contractually obligated to fix xena, yoga, and zed | 14:05 |
| happystacker | https://review.opendev.org/q/I3c60ee4c0795aadf03108ed9b5a46ecd116894af | 14:06 |
| rosmaita | the rest are "courtesy" patches | 14:06 |
| rosmaita | because people are still using those branches even though we don't release from them any more | 14:06 |
| rosmaita | i stopped at train though | 14:06 |
| happystacker | makes sense not to go beyond | 14:07 |
| rosmaita | anyway, as we get to the older branches, it is harder to actually run tests because of old dependencies | 14:07 |
| whoami-rajat | #link https://review.opendev.org/q/I3c60ee4c0795aadf03108ed9b5a46ecd116894af | 14:07 |
| happystacker | Train is pretty old | 14:07 |
| rosmaita | i had to mess with the tox.ini and requirements.txt and upper constraints to get things to run locally | 14:07 |
| rosmaita | just mentioning that in case you are in a similar situation | 14:08 |
| rosmaita | one thing is that somewhere around ussuri, you need to set basepython=python3.6 to get pep8 and hte docs jobs to work | 14:08 |
| rosmaita | not sure if it's worth backporting that though | 14:08 |
| rosmaita | i think the gate gets around this because they are using older distros when they run the zuul jobs | 14:09 |
| rosmaita | there is one change in the patch that may affect some drivers | 14:10 |
| simondodsley | happystacker: i have customers stuck on Queens as they are using Mirantis OpenStack... it makes me cry | 14:10 |
| roquej | wow, that's terrible! it would make me cry too ;-) | 14:11 |
| rosmaita | simondodsley: someone attached a queens backport to the bug, though i haven't looked at it | 14:11 |
| rosmaita | i did write more detailed than usual commit messages about conflicts during cherry-pick to explain what changes i made | 14:11 |
| whoami-rajat | i think we EOLed queens and deleted the branch? | 14:12 |
| rosmaita | so if you look at train, you get the whole story | 14:12 |
| rosmaita | whoami-rajat: you are correct | 14:12 |
| rosmaita | yeah, if you do need to work with queens, you can check out the queens-eol tag and work from there | 14:13 |
| simondodsley | rosmaita: story... that's a novel :) | 14:13 |
| rosmaita | :D | 14:14 |
| rosmaita | ok, as far as the drivers go ... | 14:14 |
| rosmaita | some drivers call cinder.image.image_utils.convert_image() directly | 14:14 |
| rosmaita | that function now checks to verify that the image data matches the image format that the caller says it is | 14:15 |
| rosmaita | it does this by calling out to 'qeum-img info' | 14:15 |
| rosmaita | anyway, the main point is that you can pass in an image_id and the qumu-img-info stuff | 14:16 |
| rosmaita | but that's optional | 14:16 |
| rosmaita | if you don't pass an image_id, if a problem is encountered, the message will say 'internal image' | 14:16 |
| rosmaita | which for some drivers it is | 14:16 |
| rosmaita | but there are some drivers who do have a glance image id when they make the call | 14:17 |
| rosmaita | so the log/error message will be slightly misleading, but only if there's a problem | 14:17 |
| rosmaita | anyway, i think it affects 3 or so drivers | 14:17 |
| rosmaita | i'll put up patches for master for those drivers, and rely on the driver maintainers to do testing and backports | 14:18 |
| happystacker | It'd worth to do a quick test on our drivers as well | 14:18 |
| rosmaita | happystacker: that's a good point | 14:18 |
| enriquetaso | i'll check the generic-nfs scenario because is affected by this | 14:18 |
| rosmaita | so the VMDK problem is like the backing_file issue with qcow2 images | 14:18 |
| rosmaita | right now, we do check for backing_file reported by quemu-img info | 14:19 |
| rosmaita | this VMDK thing happened because the "backing file" (called a "named extent" by vmware) doesn't show up in that field | 14:20 |
| rosmaita | it shows up in the format specific data in the quem-img info response | 14:20 |
| rosmaita | (if you look at the unit tests on the patch you can see an example) | 14:20 |
| rosmaita | anyway, my point is that I don't know that we have caught this issue for all possible image formats we support | 14:20 |
| rosmaita | (which depends on what the glance disk_formats config option is) | 14:21 |
| happystacker | complex to handle | 14:21 |
| rosmaita | so if you deal with other format images, please look for this kind of exploit | 14:21 |
| rosmaita | because it doesn't matter if your cloud doesn't support format X on the hypervisors | 14:22 |
| rosmaita | it's still poissible for someone to put a X format image into glance, and then create a volume from it | 14:22 |
| rosmaita | at which point cinder will courteously convert the format to raw to write it to disk | 14:22 |
| rosmaita | which is nice in general, but can be bad in some cases! | 14:23 |
| rosmaita | ok, i will shut up now ... ping me if you have any questions | 14:23 |
| happystacker | I have a question around it but we talk in our bug review | 14:23 |
| rosmaita | sure | 14:23 |
| rosmaita | one thing i should say , though | 14:23 |
| rosmaita | if you do discover this issue with another format, please file it as a security bug in Launchpad | 14:24 |
| rosmaita | that will give us time to fix it before it's announced | 14:24 |
| rosmaita | though the bad guys will already know about it, i guess | 14:24 |
| rosmaita | (at least some of them) | 14:24 |
| happystacker | probably... | 14:24 |
| rosmaita | ok, now i will shut up for real | 14:24 |
| whoami-rajat | thanks rosmaita for working on the fix and the detailed summary! | 14:25 |
| rosmaita | np, it didn't look too bad, i just didn't anticipate 50 backports | 14:25 |
| whoami-rajat | current status is we're waiting for xena patch to merge and then we will release all active stable branches i.e. xena, yoga and zed | 14:25 |
| rosmaita | and the tempest and grenad jobs in xena being so uncooperative | 14:25 |
| whoami-rajat | yeah, gate fails for important changes or when a deadline is around | 14:26 |
| whoami-rajat | anyway, thanks again and let's move to the next announcement | 14:26 |
| whoami-rajat | Driver status | 14:27 |
| whoami-rajat | 1) HPE XP | 14:27 |
| whoami-rajat | #link https://review.opendev.org/c/openstack/cinder/+/815582 | 14:27 |
| whoami-rajat | we've approved the HPE driver but i see it is dependent on one hitachi feature | 14:27 |
| whoami-rajat | this https://review.opendev.org/c/openstack/cinder/+/846977 | 14:27 |
| whoami-rajat | is abdi around? | 14:27 |
| abdi | Yes | 14:27 |
| whoami-rajat | hey | 14:28 |
| abdi | Hi | 14:28 |
| whoami-rajat | so do we need that hitachi feature for this driver or it can be done later? later = M3 which is driver feature merge deadline | 14:28 |
| abdi | I believe that feature can be later but I will double check today and get back to you. | 14:29 |
| whoami-rajat | sure, since it is blocking the driver merge, would be good if it can removed as a dependency | 14:30 |
| whoami-rajat | if not needed, rebase the driver on master (removing this dependency) and let me know, i will review again | 14:31 |
| abdi | Ok. I will have that addressed today. | 14:31 |
| whoami-rajat | great thanks | 14:31 |
| abdi | Thank you. | 14:31 |
| whoami-rajat | np | 14:31 |
| whoami-rajat | 2) Fungible NVMe TCP | 14:31 |
| whoami-rajat | #link https://review.opendev.org/c/openstack/cinder/+/849143 | 14:32 |
| whoami-rajat | this driver is merged | 14:32 |
| whoami-rajat | 3) Lustre | 14:32 |
| whoami-rajat | #link https://review.opendev.org/q/topic:bp%252Fadd-lustre-driver | 14:32 |
| whoami-rajat | we've decided to move this to next cycle | 14:32 |
| whoami-rajat | since it doesn't have a working CI yet | 14:32 |
| whoami-rajat | i will add it as a review comment on the patch | 14:32 |
| whoami-rajat | 4) NetApp NVME TCP | 14:32 |
| whoami-rajat | #link https://review.opendev.org/c/openstack/cinder/+/870004 | 14:33 |
| whoami-rajat | I've reviewed it and it mostly resembles the iSCSI driver | 14:33 |
| whoami-rajat | it's missing a releasenote currently and a code section which says it should've been removed in Mitaka | 14:33 |
| whoami-rajat | i checked the same against netapp iSCSI driver so i think it needs to be removed from both drivers | 14:33 |
| whoami-rajat | i.e. iSCSI and new NVMe TCP | 14:34 |
| felipe_rodrigues | thank you whoami-rajat for the review. I saw the comments, I am fixing the issues.. submitting a new patch very soon | 14:34 |
| whoami-rajat | great, thanks felipe_rodrigues | 14:34 |
| whoami-rajat | that's all for the drivers | 14:34 |
| whoami-rajat | next, Upcoming release deadlines | 14:35 |
| whoami-rajat | os-brick (February 9) | 14:35 |
| whoami-rajat | cinderclient (February 16) | 14:35 |
| whoami-rajat | i don't see anything major in both projects this cycle but good to get some open patches merged | 14:35 |
| whoami-rajat | we still have time so things are looking good as of now | 14:35 |
| whoami-rajat | next, 2023.2 (Bobcat) schedule | 14:36 |
| whoami-rajat | i don't remember if i announced it but the next release name is Bobcat | 14:36 |
| whoami-rajat | #link https://review.opendev.org/c/openstack/releases/+/869976 | 14:36 |
| whoami-rajat | the schedule is proposed | 14:36 |
| whoami-rajat | this is the HTML render | 14:36 |
| whoami-rajat | #link https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_280/869976/1/check/openstack-tox-docs/28016f8/docs/bobcat/schedule.html | 14:36 |
| enriquetaso | Lince rojo in Spanish | 14:36 |
| whoami-rajat | it doesn't mention the Bobcat virtual PTG which i think it should | 14:38 |
| whoami-rajat | but i will add that to the review | 14:38 |
| whoami-rajat | finally we've outreachy announcement | 14:38 |
| whoami-rajat | #link https://lists.openstack.org/pipermail/openstack-discuss/2023-January/031869.html | 14:38 |
| whoami-rajat | enriquetaso, would you like to cover this? | 14:39 |
| enriquetaso | sure | 14:39 |
| whoami-rajat | great | 14:39 |
| enriquetaso | (1)Looking for project/goals: Looking for potential intern projects ideas. Please let me know if you have an upstream bug or implementation that could be fixed by an intern (probably basic/medium tasks) | 14:39 |
| enriquetaso | A project could be fixing something that has been broken for a long time and could be fixed in a 3 month period. (small to medium size bug). Or a new partial implementation. | 14:39 |
| enriquetaso | (2)Looking for mentors: I think jbernard is interested in mentoring this round, let me know if anyone is interested as well. | 14:39 |
| enriquetaso | (3)Finally, if you know of any low-hanging-fruit bugs that are not tagged yet, please let me know, I'm going to make a list of easy bugs. | 14:40 |
| jbernard | i am, if needed | 14:40 |
| enriquetaso | This list is going to be used as a tech test before the internship selection. | 14:40 |
| enriquetaso | jbernard, :P | 14:40 |
| whoami-rajat | #link https://lists.openstack.org/pipermail/openstack-discuss/2023-January/031869.html | 14:40 |
| enriquetaso | that's all for me, thanks whoami-rajat | 14:41 |
| whoami-rajat | Sofia has been actively working on the outreachy part since past several cycles and if you've any doubts about it she can clear it (as she cleared my doubts) | 14:41 |
| whoami-rajat | thanks enriquetaso | 14:41 |
| whoami-rajat | does anyone has anything else to announce? | 14:42 |
| Roamer` | about the driver status: I guess I should have mentioned this earlier, but I pushed new revisions for a couple of patches for the StorPool driver these days | 14:42 |
| Roamer` | the last one (of the pure bugfixes) is https://review.opendev.org/c/openstack/cinder/+/843277 | 14:43 |
| Roamer` | the first couple of patches, e.g. https://review.opendev.org/c/openstack/cinder/+/845178 were discussed with, I believe, whoami-rajat a couple of months ago (and yes, it did take me some time to refresh the patches, we had some issues redeploying our CI) | 14:43 |
| Roamer` | and then there is also https://review.opendev.org/c/openstack/cinder/+/847536 - add iSCSI export support to the StorPool driver - which, I believe, in a meeting some months ago people said that it could be seen as a change to the driver, not as a whole new driver | 14:44 |
| Roamer` | so... yeah... basically I guess we would be grateful for some reviews at least for the bugfixes, and preferably also for the iSCSI export functionality | 14:45 |
| whoami-rajat | totally missed that one, i think i avoided review because i was the co-author but i just discussed the idea and really didn't work on the code changes, i think it's good to go | 14:45 |
| whoami-rajat | Roamer`, thanks, you can add the patches in review request section | 14:45 |
| whoami-rajat | though honestly i haven't been actively looking at them, i will try to clear the backlog every week from now on | 14:46 |
| roquej | thank you | 14:46 |
| Roamer` | yeah, thanks a lot | 14:46 |
| whoami-rajat | np | 14:46 |
| Roamer` | so yeah, nothing more from me | 14:46 |
| whoami-rajat | cool, let's move to topics then | 14:47 |
| whoami-rajat | #topic Do we still support stable/victoria and stable/ussuri jobs? | 14:47 |
| whoami-rajat | enriquetaso, that's you | 14:47 |
| enriquetaso | We need to add zed and yoga jobs for NFS CI. My question is if we still need to support the victoria and ussuri jobs or if it's okay to remove them. | 14:47 |
| whoami-rajat | i think you mean in devstack-plugin-nfs and not for every cinder project? | 14:47 |
| enriquetaso | #link https://review.opendev.org/c/openstack/devstack-plugin-nfs/+/871072 | 14:47 |
| enriquetaso | whoami-rajat, honestly, the question is general? I'm a bit lost | 14:48 |
| enriquetaso | but yes, its mainly for nfs | 14:48 |
| eharney | i don't see a reason to remove them from devstack-plugin-nfs? | 14:48 |
| whoami-rajat | since those branches are EM, we do want to keep the gate active | 14:48 |
| whoami-rajat | until they're EOL but yeah others can comment on it | 14:48 |
| rosmaita | well, i believe that for EM, you only need to run unit tests and pep8 | 14:49 |
| eharney | they still work, might as well keep them there, it's not like they run very often | 14:49 |
| eharney | rosmaita: this is for the devstack plugin itself | 14:49 |
| rosmaita | ok, sorry | 14:50 |
| enriquetaso | okay, so we keep then | 14:50 |
| enriquetaso | I'll leave a comment on the patch | 14:51 |
| whoami-rajat | yeah i think that would be good, as eharney said they don't run often and don't take much of gate resources | 14:51 |
| enriquetaso | ++ | 14:51 |
| enriquetaso | thanks | 14:51 |
| whoami-rajat | thanks enriquetaso | 14:52 |
| whoami-rajat | so we don't have any other topics | 14:52 |
| whoami-rajat | let's move to open discussion | 14:52 |
| whoami-rajat | #topic open discussion | 14:52 |
| roquej | What's the process to update documentation? | 14:52 |
| roquej | typically on openstack.org | 14:53 |
| whoami-rajat | in the cinder repo, there's a doc folder | 14:53 |
| whoami-rajat | you can find cinder related documentation there | 14:53 |
| roquej | Ok so basically the same process of proposing code changes | 14:53 |
| whoami-rajat | yes | 14:53 |
| roquej | copy that | 14:53 |
| roquej | thks | 14:53 |
| whoami-rajat | you will need to propose a gerrit patch as normally you would | 14:53 |
| whoami-rajat | np | 14:53 |
| roquej | makes sense, that's what I thoughy to be honest | 14:54 |
| roquej | thought | 14:54 |
| whoami-rajat | we've a bunch of patches in review request section, if you get time please take a look at them | 14:57 |
| whoami-rajat | also I've been seen a lot of review activity, thanks everyone for the reviews | 14:58 |
| whoami-rajat | this is a doc that would be helpful https://docs.openstack.org/cinder/latest/contributor/gerrit.html#efficient-review-guidelines | 14:58 |
| roquej | will look at those shortly | 14:59 |
| whoami-rajat | cool | 14:59 |
| roquej | considering my skill level, I'll try to do my best ;-) | 14:59 |
| whoami-rajat | would be good if everyone can leave a comment with the review stating the part they've looked at and looks good to them so others can save some time | 14:59 |
| whoami-rajat | sure, every review is appreciated :) | 15:00 |
| whoami-rajat | we're out of time | 15:00 |
| whoami-rajat | thanks everyone! | 15:00 |
| whoami-rajat | #endmeeting | 15:00 |
| opendevmeet | Meeting ended Wed Jan 25 15:00:16 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:00 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder/2023/cinder.2023-01-25-14.00.html | 15:00 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder/2023/cinder.2023-01-25-14.00.txt | 15:00 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder/2023/cinder.2023-01-25-14.00.log.html | 15:00 |
| enriquetaso | ++ | 15:00 |
| *** dviroel is now known as dviroel|lunch | 16:08 | |
| *** dviroel|lunch is now known as dviroel | 17:14 | |
| *** dviroel is now known as dviroel|out | 20:52 | |
| *** dasm is now known as dasm|off | 21:51 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!