| *** chuanm6 is now known as chuanm | 11:26 | |
| *** vhari_ is now known as vhari | 12:32 | |
| whoami-rajat | #startmeeting cinder | 14:00 |
|---|---|---|
| opendevmeet | Meeting started Wed Mar 1 14:00:31 2023 UTC and is due to finish in 60 minutes. The chair is whoami-rajat. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cinder' | 14:00 |
| whoami-rajat | #topic roll call | 14:00 |
| thiagoalvoravel | o/ | 14:00 |
| enriquetaso | hello | 14:00 |
| tosky | o/ | 14:01 |
| MatheusAndrade[m] | o/ | 14:01 |
| rosmaita | o/ | 14:01 |
| HelenaDantas[m] | o/ | 14:02 |
| lucasmoliveira059 | o/ | 14:02 |
| whoami-rajat | #link https://etherpad.opendev.org/p/cinder-antelope-meetings | 14:02 |
| whoami-rajat | hello everyone | 14:03 |
| whoami-rajat | let's get started | 14:03 |
| whoami-rajat | #topic announcements | 14:03 |
| whoami-rajat | RC1 this week | 14:03 |
| whoami-rajat | #link https://lists.openstack.org/pipermail/openstack-discuss/2023-February/032438.html | 14:04 |
| whoami-rajat | #link https://review.opendev.org/c/openstack/releases/+/875397 | 14:04 |
| whoami-rajat | I've created an etherpad to prioritize patches for RC1 and RC2, please add your patches here | 14:04 |
| whoami-rajat | #link https://etherpad.opendev.org/p/cinder-antelope-fixes-rc | 14:04 |
| whoami-rajat | during RC1, stable/2023.1 will be cut and 2023.2 will be master | 14:05 |
| whoami-rajat | any changes merged after RC1 needs to be backported to stable/2023.1 to include it in the 2023.1 release | 14:05 |
| felipe_rodrigues | o/ | 14:05 |
| whoami-rajat | in summary, please add your patches (bug fixes) that you think are important and need to go in 2023.1 Antelope release | 14:06 |
| whoami-rajat | next, Vancouver PTG attendance | 14:06 |
| whoami-rajat | #link https://lists.openstack.org/pipermail/openstack-discuss/2023-February/032478.html | 14:06 |
| whoami-rajat | this is a followup on our discussion last week regarding the people interested in joining the physical PTG in Vancouver | 14:07 |
| whoami-rajat | NetApp and pure storage teams have shown their interests | 14:07 |
| whoami-rajat | if you're planning to attend, please reply to the email stating it so we've record of people planning to attend | 14:08 |
| whoami-rajat | next, TC + PTL results are out | 14:08 |
| whoami-rajat | #link https://lists.openstack.org/pipermail/openstack-discuss/2023-February/032442.html | 14:09 |
| whoami-rajat | congratulations rosmaita for running for TC for another tenure! | 14:09 |
| rosmaita | thanks! | 14:09 |
| jungleboyj | ++ Congrats! | 14:09 |
| rosmaita | will most likely be my last time, so anyone interested or curious about serving on the TC, reach out and I'll be happy to fill you in | 14:10 |
| enriquetaso | congrats! | 14:10 |
| whoami-rajat | and just stating it formally if people didn't notice, I will be the PTL again for 2023.2 (Bobcat) | 14:11 |
| whoami-rajat | rosmaita++ | 14:11 |
| enriquetaso | whoami-rajat++ | 14:11 |
| rosmaita | whoami-rajat: congratulations! | 14:11 |
| jungleboyj | Congratulations and thank you! | 14:12 |
| whoami-rajat | thanks! | 14:12 |
| whoami-rajat | and last announcement for today, We have a new TC Chair - Kristi Nikolla | 14:12 |
| whoami-rajat | #link https://lists.openstack.org/pipermail/openstack-discuss/2023-February/032499.html | 14:13 |
| whoami-rajat | gmann stepped down as TC chair after serving 2 years | 14:13 |
| whoami-rajat | so gmann++ for serving as TC chair! | 14:13 |
| jungleboyj | ++ | 14:13 |
| whoami-rajat | that's all for announcements | 14:14 |
| whoami-rajat | anyone would like to announce something? sometimes I miss news | 14:14 |
| whoami-rajat | guess not | 14:15 |
| whoami-rajat | let's move to topics then | 14:15 |
| whoami-rajat | #topic Multiattach issue | 14:16 |
| whoami-rajat | #link https://lists.openstack.org/pipermail/openstack-discuss/2023-February/032389.html | 14:16 |
| whoami-rajat | this was initially raised on ML so i will briefly describe the problem | 14:16 |
| whoami-rajat | we used to support creating multiattach volumes by providing multiattach=True in volume create request body | 14:16 |
| whoami-rajat | this was discouraged as users might accidentally create MA volumes and don't set up a cluster aware FS | 14:17 |
| whoami-rajat | which can eventually lead to data loss | 14:17 |
| whoami-rajat | we switched to using multiattach volume types to create MA volumes | 14:17 |
| whoami-rajat | since volume types are created by admin users | 14:17 |
| whoami-rajat | the deprecation was done in queens but we kept old behavior for compatibility | 14:18 |
| enriquetaso | I think there's a upstream bug for this: | 14:18 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/2008259 | 14:18 |
| whoami-rajat | thanks enriquetaso | 14:18 |
| whoami-rajat | so I proposed 2 changes, one for cinder (to remove the support) and one for tempest (to update test to use new way) | 14:18 |
| enriquetaso | sounds good | 14:19 |
| whoami-rajat | this morning i had a discussion with gmann regarding this and his concern is we're breaking backward compatibility with this change and should be done with a MV | 14:19 |
| whoami-rajat | my argument was we don't want to keep the old behavior since that's a bug | 14:20 |
| whoami-rajat | i need to find logs of that discussion (i will look for that) | 14:20 |
| whoami-rajat | but you can find the details in the tempest patch | 14:20 |
| whoami-rajat | #link https://review.opendev.org/c/openstack/tempest/+/875372 | 14:20 |
| whoami-rajat | and also on the ML | 14:20 |
| whoami-rajat | #link https://lists.openstack.org/pipermail/openstack-discuss/2023-March/032502.html | 14:20 |
| whoami-rajat | found the discussion | 14:21 |
| whoami-rajat | #link https://meetings.opendev.org/irclogs/%23openstack-qa/%23openstack-qa.2023-03-01.log.html#t2023-03-01T01:25:48 | 14:21 |
| whoami-rajat | so i wanted cinder team's input on this, what should be the ideal way forward, 1) remove the compat code altogether 2) keep the compat code and handle it with a new microversion | 14:23 |
| rosmaita | i am against the microversioning | 14:24 |
| rosmaita | this is a data loss issue, so we don't want people doing it | 14:24 |
| whoami-rajat | in case of 2) users will still be able to create multiattach volumes the old way (which we clearly don't want) | 14:24 |
| whoami-rajat | ack, I've the same thought | 14:24 |
| jungleboyj | I would agree with rosmaita . If it is a dataloss issue and shouldn't have been possible in the first place, then it should be fixed. | 14:24 |
| jungleboyj | Not mv'ed . | 14:25 |
| rosmaita | from the API ref, it looks like the 'multiattach' in the request body has been there since 3.0 ? https://docs.openstack.org/api-ref/block-storage/v3/?expanded=create-a-volume-detail#volumes-volumes | 14:25 |
| whoami-rajat | yeah, it was carried over from v2 API | 14:25 |
| whoami-rajat | and we deprecated it with a MV 3.50 (introducing the volume type way) | 14:26 |
| rosmaita | text says "Note that support for multiattach volumes depends on the volume type being used." | 14:26 |
| rosmaita | so if you include --multiattach and the VT doesn't allow it, what happens? | 14:26 |
| whoami-rajat | i think it takes either of those values, if "multiattach" is there it doesn't consider the volume type | 14:27 |
| whoami-rajat | multiattach or extra_specs.get("multiatach"... | 14:27 |
| whoami-rajat | which is again a issue that you rightly pointed out, we're not honoring the volume type | 14:27 |
| rosmaita | well, we could say that's a bug, and change it to keep multiattach in the request body, but reject the request if the VT doesn't allow it? | 14:28 |
| rosmaita | then no API change, but correct behavior? | 14:28 |
| rosmaita | would be kind of stupid, but would be backward compatible | 14:28 |
| whoami-rajat | hmm, but it would still break volume creation for people passing multiattach=True | 14:29 |
| rosmaita | only sometimes | 14:29 |
| rosmaita | :D | 14:29 |
| whoami-rajat | I don't think users use both the ways simultaneously | 14:29 |
| whoami-rajat | if they start using the correct volume type, multiattach automatically becomes redundant | 14:30 |
| whoami-rajat | but i see your point | 14:30 |
| rosmaita | me neither, probably better to just say, this is unsafe, we no longer allow it | 14:30 |
| whoami-rajat | we're keeping the API request consistent but changing it's behavior on backend (is that acceptable change?) | 14:30 |
| rosmaita | well, if it doesn't break tempest, no one will notice | 14:31 |
| whoami-rajat | tempest will break since they create the volume with only multiattach=True | 14:31 |
| whoami-rajat | not providing volume type at all (so it might take the default type which is not MA) | 14:32 |
| rosmaita | gotcha | 14:32 |
| whoami-rajat | so I think the consensus is we don't want to go the microversion way right? | 14:34 |
| rosmaita | what's supposed to happen if you have "multiattach": false on a VT that supports multiattach? | 14:34 |
| rosmaita | or maybe, what does happen currently? | 14:35 |
| whoami-rajat | it has an OR operator so takes either of those values | 14:35 |
| whoami-rajat | here https://review.opendev.org/c/openstack/cinder/+/874865/2/cinder/volume/flows/api/create_volume.py#b499 | 14:36 |
| rosmaita | thanks | 14:36 |
| whoami-rajat | https://github.com/openstack/cinder/blob/master/cinder/volume/flows/api/create_volume.py#L496-L500 | 14:36 |
| rosmaita | ok, so currently, if you say --multiattach=False in the request, but the VT allows it, you get multiattach ... am i right about that? | 14:38 |
| whoami-rajat | rosmaita, yes correct | 14:38 |
| rosmaita | line 500 in https://review.opendev.org/c/openstack/cinder/+/874865/2/cinder/volume/flows/api/create_volume.py#b499 | 14:38 |
| rosmaita | ok, then we definitely need to remove 'multiattach' from the volume-create request | 14:39 |
| rosmaita | i'll try to write something coherent on your tempest patch and see if i can convince gmann | 14:40 |
| whoami-rajat | that would be great, thanks! | 14:40 |
| rosmaita | thanks for the discussion and explaining this | 14:41 |
| whoami-rajat | np, thanks for all the valuable feedback | 14:41 |
| whoami-rajat | so that's all the topics we had for today | 14:41 |
| whoami-rajat | let's move to open discussion | 14:42 |
| whoami-rajat | #topic open discussion | 14:42 |
| eharney | please review this rbd fix: https://review.opendev.org/c/openstack/cinder/+/865855 | 14:42 |
| Tony_Saad | Hey guys we have these antelope Dell driver bugs and was wondering if there are any blockers https://review.opendev.org/c/openstack/cinder/+/768105 https://review.opendev.org/c/openstack/cinder/+/797970 https://review.opendev.org/c/openstack/cinder/+/821739 https://review.opendev.org/c/openstack/cinder/+/858370 | 14:43 |
| whoami-rajat | eharney, added a comment, it's missing a releasenote | 14:45 |
| whoami-rajat | I don't think we've much for open discussion so let's close early | 14:47 |
| whoami-rajat | remember to review the bug fixes important for RC1 and RC2 | 14:47 |
| whoami-rajat | also add your patches on the RC etherpad | 14:47 |
| eharney | we should really look at https://review.opendev.org/c/openstack/cinder/+/873249 | 14:47 |
| eharney | do we use the review-priority flag? | 14:48 |
| Tony_Saad | Hey guys we have these antelope Dell driver bugs and was wondering if there are any blockers https://review.opendev.org/c/openstack/cinder/+/768105 https://review.opendev.org/c/openstack/cinder/+/797970 https://review.opendev.org/c/openstack/cinder/+/821739 https://review.opendev.org/c/openstack/cinder/+/858370 | 14:48 |
| rosmaita | eharney: ++ on 873249 | 14:49 |
| whoami-rajat | eharney, we do and there should be a link to track that but please do set it | 14:49 |
| whoami-rajat | seems important | 14:49 |
| eharney | whoami-rajat: i set it weeks ago | 14:50 |
| whoami-rajat | oh i see, I will find out the tracker link then and we can target that | 14:51 |
| whoami-rajat | hmm these config values haven't been working since beginning | 14:52 |
| whoami-rajat | added it to the RC tracker etherpad | 14:55 |
| enriquetaso | Tony_Saad, I've left a comment on one patch | 14:55 |
| Tony_Saad | thanks! | 14:56 |
| enriquetaso | I'll read more about the context and review 873249 | 14:56 |
| whoami-rajat | we're out of time, thanks everyone for attending! | 15:00 |
| whoami-rajat | #endmeeting | 15:00 |
| opendevmeet | Meeting ended Wed Mar 1 15:00:06 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:00 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder/2023/cinder.2023-03-01-14.00.html | 15:00 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder/2023/cinder.2023-03-01-14.00.txt | 15:00 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder/2023/cinder.2023-03-01-14.00.log.html | 15:00 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!