Thursday, 2023-08-10

*** akrog is now known as geguileo11:18
ashrodri#startmeeting manila15:00
opendevmeetMeeting started Thu Aug 10 15:00:47 2023 UTC and is due to finish in 60 minutes.  The chair is ashrodri. Information about MeetBot at http://wiki.debian.org/MeetBot.15:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:00
opendevmeetThe meeting name has been set to 'manila'15:00
ashrodricourtesy ping dviroel felipe_rodrigues vhari gouthamr carthaca15:00
gouthamro/15:01
carthacahi15:01
ashrodrio/ hello everyone15:01
dviroelo/15:01
thiagoalvoravelo/15:01
ashrodricarloss is on PTO this week, I'll be leading today's meeting15:01
haixino/15:01
ashrodritoday's meeting agenda: #link https://wiki.openstack.org/wiki/Manila/Meetings15:01
felipe_rodrigueso/15:01
caiquemello[m]o/15:02
jayaanandhi15:02
ashrodriwelcome, let's get started15:04
ashrodri#topic Announcements15:04
ashrodri#link https://releases.openstack.org/bobcat/schedule.html 15:04
ashrodriIt is now R-8, and feature proposal freeze is now in effect. 15:05
ashrodriAlso, reminder that PTG registration is now open for Caracal here: #link https://ptg2023.openinfra.dev/15:05
ashrodriDoes anyone have an announcement to bring to our attention?15:05
ashrodriokay, moving on...15:07
ashrodri#topic Review Focus15:07
ashrodri#link https://etherpad.opendev.org/p/manila-bobcat-review-focus15:07
ashrodriFeature freeze is coming up in R-5 along with client release15:07
ashrodriLets work towards reviewing and merging these patches, starting with...15:07
ashrodrishare backups #link https://review.opendev.org/c/openstack/manila/+/34398015:08
ashrodriand cli patch: #link https://review.opendev.org/c/openstack/python-manilaclient/+/34467115:08
ashrodriapi changes look to be in good condition to me, could use some more eyes on the cli patch.15:08
ashrodriI will take a look after this meeting, anyone else volunteering?15:08
gouthamrI’m hoping to defer any more changes to the API patch to follow ups and go ahead with merging this; it’s got a good amount of soak time and plenty reviews…15:10
gouthamrany opposition to this?15:11
ashrodrinot from me, api changes look good to merge15:11
gouthamrtempest tests and CLI are shaping up; we can merge them as soon as they’re reviewed to the same level and passing CI etc15:12
ashrodri++15:13
gouthamr+1 I’ll act on this; with haixin - if you’ve reviewed this, please +1 the latest patch if you’re good with it… feel free to suggest changes; if they are minor, kpdev can address them in a follow up patch15:14
haixinI'll review it again tomorrow :)15:15
gouthamrack thank you haixin15:15
ashrodrithanks gouthamr haixin, moving on to the next patch...15:16
ashrodri#link https://review.opendev.org/c/openstack/manila/+/890291 (Add NetApp Active IQ scheduler weigher)15:17
ashrodriis ready for review15:17
gouthamr+1; will take a look15:18
ashrodrithanks gouthamr 15:18
gouthamrfelipe_rodrigues: is this enabled in the NetApp CI ?15:19
felipe_rodriguesNot yet, we are testing it manually and internally.. we can add a job for it, if you want15:20
gouthamror enable it in existing jobs?15:22
gouthamrafair, you’re enabling multiple backends in these jobs - so it can be tested well? your multisvm job must be multi cluster as well iirc15:23
felipe_rodriguesit is an option..15:23
felipe_rodrigueswe are thinking as multi cluster env15:24
gouthamrack15:25
felipe_rodriguesSince there are some extra API calls, I dont know how it would affect the execution time...15:25
gouthamryou’ve to worry about that for prod deployments too, no? :)15:26
felipe_rodriguesok.. only for tests that depend on scheduler weigher.. there aren't many 15:26
felipe_rodriguesI mean.. my problem is making our development cycle lazy.. 15:27
gouthamrevery backend test will run through the weigher.. 15:27
felipe_rodriguesI see15:27
felipe_rodriguesI will add a non voting job first. as part of our upstream pipeline.. let see how it works... 15:28
felipe_rodrigueswdyt ?15:28
gouthamrsure thing15:29
felipe_rodriguesWe can add it to the community dummy job15:29
felipe_rodrigueswdyt ? 15:29
felipe_rodriguesit is skipped in that scenario.. it should not affect the job in anyway 15:29
gouthamrthat’s an option15:30
felipe_rodriguesthe weigher votes as "0.0" for all hosts when there is at least one non netapp host (as we agreed during PTG)15:30
gouthamrbut, why would you besides seeing the negative testing? I mean to see the functionality of the weigher15:31
gouthamrhmm, probably good enough reason - feel free to enable it in the same patch or as a dependent manila-tempest-plugin change; where the parent dummy driver job is defined15:32
felipe_rodriguesnice15:33
ashrodrithanks gouthamr felipe_rodrigues. next...15:36
ashrodri#link https://review.opendev.org/c/openstack/manila/+/889737 (NetApp SVM migration get progress)15:36
ashrodriis also ready for review 15:36
gouthamrack; I’m taking a look15:38
gouthamrfelipe_rodrigues: could you re-review?15:38
felipe_rodriguesthanks caiquemello[m] for the patch.. I already reviewed, we need more eyes 15:39
felipe_rodriguesoh, sure! I'll take a look again15:39
gouthamrperhaps a good patch to review for new netappers as well15:40
msaravanyes, we started to review.. will review these patches definitely.. 15:40
gouthamr++15:40
felipe_rodriguesI'd like more eyes specially about this point: https://review.opendev.org/c/openstack/manila/+/889737/4..5/manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py#b204815:40
msaravansure 15:41
felipe_rodriguesthks :)15:41
ashrodrithanks for volunteering to review! next, some new Dell drivers: ... 15:43
ashrodri#link https://review.opendev.org/c/openstack/manila/+/880527 (Adds a new Manila driver for Dell PowerFlex storage backend)  15:43
ashrodrithis looks to be in good condition, only missing a +2.15:43
ashrodriand #link https://review.opendev.org/c/openstack/manila/+/885974 (Adds a new Manila driver for Dell PowerStore storage backend)15:44
ashrodrihas a review from gouthamr to be addressed, needs more eyes, any takers? 15:44
felipe_rodriguesI can review it15:45
ashrodri++ felipe_rodrigues thanks!15:48
ashrodriis there another patch we would like to bring attention to here today?15:48
gouthamrI think the resource locks patches have had some attention, thank you for looking!15:49
gouthamrI’ll rebase the changes on top of the share backup patch and update microversion15:50
gouthamr#link https://review.opendev.org/q/topic:bp%252Fallow-locking-shares-against-deletion (Resource Locks)15:50
ashrodrigreat! thanks for adding that to review etherpad, missed it earlier15:50
gouthamrnah, it was missing - my bad15:51
ashrodrino worries, moving on...15:51
ashrodri#topic Bug Triage 15:51
ashrodrivhari has a scheduling conflict, and asked me to lead this part as well15:51
ashrodri#link https://etherpad.openstack.org/p/manila-bug-triage-pad-new 15:52
ashrodrifirst, #link https://bugs.launchpad.net/manila/+bug/203096915:52
ashrodribug is listed as in progress, but is unassigned and shows no related patch. 15:52
ashrodrihis is actually the SVM RFE we spoke about earlier. Wonder why the patch isn't being tracked... gouthamr, thoughts?15:52
gouthamrwe’d have to update the patch on the tracker manually15:53
ashrodriah, okay. will do thanks15:54
felipe_rodriguesthe patch came earlier than the but report 15:54
felipe_rodriguesbug*15:54
ashrodriah yes that makes sense15:54
gouthamrthe openstackci bot that does gerrit updates only looks at the first patch to make up a comment with a link to the patch - weird; so if you’re missing a clearly formatted “Closes-Bug” in the commit message of the first patch, it’ll miss the update15:55
ashrodriokay, last one: #link https://bugs.launchpad.net/manila/+bug/197064915:56
ashrodrivhari asked us to revisit this bug, felipe_rodriguez is the assignee, from about 1 year ago. do you need anything to proceed? we can always change back to unassigned if necessary .15:56
ashrodrisorry, felipe_rodrigues15:56
gouthamrfelipe_rodrigues: this feels like deja vu; I think we discussed this.. your concern is that oversubscription calculations are kicking in even when allocating a thick volume?15:59
felipe_rodriguesyeah.. we have a problem that AFF NetApp ONTAP creates volume as thin while FAS as thick (unless you request a different mode).. this bug has been deprioritized on our list.. However, we should have a open window soon16:01
felipe_rodriguesI will find an assignee internally 16:01
gouthamrokay good stuff16:02
gouthamrthanks16:02
gouthamrtime check, ashrodri16:02
ashrodriyep, we're reaching a little past our usual hour so lets wrap up...16:02
ashrodri#topic Open discussion16:02
ashrodriAnything more to bring up today?16:03
gouthamrgreat job running this meeting… thanks ashrodri16:03
ashrodrihappy to help, thanks for joining us, have a great rest of your day!16:03
ashrodri#endmeeting16:03
opendevmeetMeeting ended Thu Aug 10 16:03:58 2023 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:03
opendevmeetMinutes:        https://meetings.opendev.org/meetings/manila/2023/manila.2023-08-10-15.00.html16:03
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/manila/2023/manila.2023-08-10-15.00.txt16:03
opendevmeetLog:            https://meetings.opendev.org/meetings/manila/2023/manila.2023-08-10-15.00.log.html16:03

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!