*** akrog is now known as geguileo | 11:18 | |
ashrodri | #startmeeting manila | 15:00 |
---|---|---|
opendevmeet | Meeting started Thu Aug 10 15:00:47 2023 UTC and is due to finish in 60 minutes. The chair is ashrodri. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
opendevmeet | The meeting name has been set to 'manila' | 15:00 |
ashrodri | courtesy ping dviroel felipe_rodrigues vhari gouthamr carthaca | 15:00 |
gouthamr | o/ | 15:01 |
carthaca | hi | 15:01 |
ashrodri | o/ hello everyone | 15:01 |
dviroel | o/ | 15:01 |
thiagoalvoravel | o/ | 15:01 |
ashrodri | carloss is on PTO this week, I'll be leading today's meeting | 15:01 |
haixin | o/ | 15:01 |
ashrodri | today's meeting agenda: #link https://wiki.openstack.org/wiki/Manila/Meetings | 15:01 |
felipe_rodrigues | o/ | 15:01 |
caiquemello[m] | o/ | 15:02 |
jayaanand | hi | 15:02 |
ashrodri | welcome, let's get started | 15:04 |
ashrodri | #topic Announcements | 15:04 |
ashrodri | #link https://releases.openstack.org/bobcat/schedule.html | 15:04 |
ashrodri | It is now R-8, and feature proposal freeze is now in effect. | 15:05 |
ashrodri | Also, reminder that PTG registration is now open for Caracal here: #link https://ptg2023.openinfra.dev/ | 15:05 |
ashrodri | Does anyone have an announcement to bring to our attention? | 15:05 |
ashrodri | okay, moving on... | 15:07 |
ashrodri | #topic Review Focus | 15:07 |
ashrodri | #link https://etherpad.opendev.org/p/manila-bobcat-review-focus | 15:07 |
ashrodri | Feature freeze is coming up in R-5 along with client release | 15:07 |
ashrodri | Lets work towards reviewing and merging these patches, starting with... | 15:07 |
ashrodri | share backups #link https://review.opendev.org/c/openstack/manila/+/343980 | 15:08 |
ashrodri | and cli patch: #link https://review.opendev.org/c/openstack/python-manilaclient/+/344671 | 15:08 |
ashrodri | api changes look to be in good condition to me, could use some more eyes on the cli patch. | 15:08 |
ashrodri | I will take a look after this meeting, anyone else volunteering? | 15:08 |
gouthamr | I’m hoping to defer any more changes to the API patch to follow ups and go ahead with merging this; it’s got a good amount of soak time and plenty reviews… | 15:10 |
gouthamr | any opposition to this? | 15:11 |
ashrodri | not from me, api changes look good to merge | 15:11 |
gouthamr | tempest tests and CLI are shaping up; we can merge them as soon as they’re reviewed to the same level and passing CI etc | 15:12 |
ashrodri | ++ | 15:13 |
gouthamr | +1 I’ll act on this; with haixin - if you’ve reviewed this, please +1 the latest patch if you’re good with it… feel free to suggest changes; if they are minor, kpdev can address them in a follow up patch | 15:14 |
haixin | I'll review it again tomorrow :) | 15:15 |
gouthamr | ack thank you haixin | 15:15 |
ashrodri | thanks gouthamr haixin, moving on to the next patch... | 15:16 |
ashrodri | #link https://review.opendev.org/c/openstack/manila/+/890291 (Add NetApp Active IQ scheduler weigher) | 15:17 |
ashrodri | is ready for review | 15:17 |
gouthamr | +1; will take a look | 15:18 |
ashrodri | thanks gouthamr | 15:18 |
gouthamr | felipe_rodrigues: is this enabled in the NetApp CI ? | 15:19 |
felipe_rodrigues | Not yet, we are testing it manually and internally.. we can add a job for it, if you want | 15:20 |
gouthamr | or enable it in existing jobs? | 15:22 |
gouthamr | afair, you’re enabling multiple backends in these jobs - so it can be tested well? your multisvm job must be multi cluster as well iirc | 15:23 |
felipe_rodrigues | it is an option.. | 15:23 |
felipe_rodrigues | we are thinking as multi cluster env | 15:24 |
gouthamr | ack | 15:25 |
felipe_rodrigues | Since there are some extra API calls, I dont know how it would affect the execution time... | 15:25 |
gouthamr | you’ve to worry about that for prod deployments too, no? :) | 15:26 |
felipe_rodrigues | ok.. only for tests that depend on scheduler weigher.. there aren't many | 15:26 |
felipe_rodrigues | I mean.. my problem is making our development cycle lazy.. | 15:27 |
gouthamr | every backend test will run through the weigher.. | 15:27 |
felipe_rodrigues | I see | 15:27 |
felipe_rodrigues | I will add a non voting job first. as part of our upstream pipeline.. let see how it works... | 15:28 |
felipe_rodrigues | wdyt ? | 15:28 |
gouthamr | sure thing | 15:29 |
felipe_rodrigues | We can add it to the community dummy job | 15:29 |
felipe_rodrigues | wdyt ? | 15:29 |
felipe_rodrigues | it is skipped in that scenario.. it should not affect the job in anyway | 15:29 |
gouthamr | that’s an option | 15:30 |
felipe_rodrigues | the weigher votes as "0.0" for all hosts when there is at least one non netapp host (as we agreed during PTG) | 15:30 |
gouthamr | but, why would you besides seeing the negative testing? I mean to see the functionality of the weigher | 15:31 |
gouthamr | hmm, probably good enough reason - feel free to enable it in the same patch or as a dependent manila-tempest-plugin change; where the parent dummy driver job is defined | 15:32 |
felipe_rodrigues | nice | 15:33 |
ashrodri | thanks gouthamr felipe_rodrigues. next... | 15:36 |
ashrodri | #link https://review.opendev.org/c/openstack/manila/+/889737 (NetApp SVM migration get progress) | 15:36 |
ashrodri | is also ready for review | 15:36 |
gouthamr | ack; I’m taking a look | 15:38 |
gouthamr | felipe_rodrigues: could you re-review? | 15:38 |
felipe_rodrigues | thanks caiquemello[m] for the patch.. I already reviewed, we need more eyes | 15:39 |
felipe_rodrigues | oh, sure! I'll take a look again | 15:39 |
gouthamr | perhaps a good patch to review for new netappers as well | 15:40 |
msaravan | yes, we started to review.. will review these patches definitely.. | 15:40 |
gouthamr | ++ | 15:40 |
felipe_rodrigues | I'd like more eyes specially about this point: https://review.opendev.org/c/openstack/manila/+/889737/4..5/manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py#b2048 | 15:40 |
msaravan | sure | 15:41 |
felipe_rodrigues | thks :) | 15:41 |
ashrodri | thanks for volunteering to review! next, some new Dell drivers: ... | 15:43 |
ashrodri | #link https://review.opendev.org/c/openstack/manila/+/880527 (Adds a new Manila driver for Dell PowerFlex storage backend) | 15:43 |
ashrodri | this looks to be in good condition, only missing a +2. | 15:43 |
ashrodri | and #link https://review.opendev.org/c/openstack/manila/+/885974 (Adds a new Manila driver for Dell PowerStore storage backend) | 15:44 |
ashrodri | has a review from gouthamr to be addressed, needs more eyes, any takers? | 15:44 |
felipe_rodrigues | I can review it | 15:45 |
ashrodri | ++ felipe_rodrigues thanks! | 15:48 |
ashrodri | is there another patch we would like to bring attention to here today? | 15:48 |
gouthamr | I think the resource locks patches have had some attention, thank you for looking! | 15:49 |
gouthamr | I’ll rebase the changes on top of the share backup patch and update microversion | 15:50 |
gouthamr | #link https://review.opendev.org/q/topic:bp%252Fallow-locking-shares-against-deletion (Resource Locks) | 15:50 |
ashrodri | great! thanks for adding that to review etherpad, missed it earlier | 15:50 |
gouthamr | nah, it was missing - my bad | 15:51 |
ashrodri | no worries, moving on... | 15:51 |
ashrodri | #topic Bug Triage | 15:51 |
ashrodri | vhari has a scheduling conflict, and asked me to lead this part as well | 15:51 |
ashrodri | #link https://etherpad.openstack.org/p/manila-bug-triage-pad-new | 15:52 |
ashrodri | first, #link https://bugs.launchpad.net/manila/+bug/2030969 | 15:52 |
ashrodri | bug is listed as in progress, but is unassigned and shows no related patch. | 15:52 |
ashrodri | his is actually the SVM RFE we spoke about earlier. Wonder why the patch isn't being tracked... gouthamr, thoughts? | 15:52 |
gouthamr | we’d have to update the patch on the tracker manually | 15:53 |
ashrodri | ah, okay. will do thanks | 15:54 |
felipe_rodrigues | the patch came earlier than the but report | 15:54 |
felipe_rodrigues | bug* | 15:54 |
ashrodri | ah yes that makes sense | 15:54 |
gouthamr | the openstackci bot that does gerrit updates only looks at the first patch to make up a comment with a link to the patch - weird; so if you’re missing a clearly formatted “Closes-Bug” in the commit message of the first patch, it’ll miss the update | 15:55 |
ashrodri | okay, last one: #link https://bugs.launchpad.net/manila/+bug/1970649 | 15:56 |
ashrodri | vhari asked us to revisit this bug, felipe_rodriguez is the assignee, from about 1 year ago. do you need anything to proceed? we can always change back to unassigned if necessary . | 15:56 |
ashrodri | sorry, felipe_rodrigues | 15:56 |
gouthamr | felipe_rodrigues: this feels like deja vu; I think we discussed this.. your concern is that oversubscription calculations are kicking in even when allocating a thick volume? | 15:59 |
felipe_rodrigues | yeah.. we have a problem that AFF NetApp ONTAP creates volume as thin while FAS as thick (unless you request a different mode).. this bug has been deprioritized on our list.. However, we should have a open window soon | 16:01 |
felipe_rodrigues | I will find an assignee internally | 16:01 |
gouthamr | okay good stuff | 16:02 |
gouthamr | thanks | 16:02 |
gouthamr | time check, ashrodri | 16:02 |
ashrodri | yep, we're reaching a little past our usual hour so lets wrap up... | 16:02 |
ashrodri | #topic Open discussion | 16:02 |
ashrodri | Anything more to bring up today? | 16:03 |
gouthamr | great job running this meeting… thanks ashrodri | 16:03 |
ashrodri | happy to help, thanks for joining us, have a great rest of your day! | 16:03 |
ashrodri | #endmeeting | 16:03 |
opendevmeet | Meeting ended Thu Aug 10 16:03:58 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:03 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/manila/2023/manila.2023-08-10-15.00.html | 16:03 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/manila/2023/manila.2023-08-10-15.00.txt | 16:03 |
opendevmeet | Log: https://meetings.opendev.org/meetings/manila/2023/manila.2023-08-10-15.00.log.html | 16:03 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!