| *** mhen_ is now known as mhen | 02:57 | |
| sfernand | hi | 14:02 |
|---|---|---|
| rosmaita | #startmeeting cinder | 14:02 |
| opendevmeet | Meeting started Wed Feb 5 14:02:17 2025 UTC and is due to finish in 60 minutes. The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:02 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:02 |
| opendevmeet | The meeting name has been set to 'cinder' | 14:02 |
| rosmaita | #topic roll call | 14:02 |
| whoami-rajat | hi | 14:02 |
| akawai | o/ | 14:02 |
| nileshthathagar | o/ | 14:02 |
| sp-bmilanov | hello! | 14:02 |
| Sai | o/ | 14:02 |
| rosmaita | hello sfernand, say hi again so you get into the minutes | 14:02 |
| kpdev | hi | 14:02 |
| sfernand | hi | 14:02 |
| sfernand | ;) | 14:03 |
| rosmaita | thanks! | 14:03 |
| jhorstmann | hi | 14:03 |
| rosmaita | ok, let's get started | 14:05 |
| rosmaita | the school bus broke down this morning and Jon had to take his kids to school, so that's why he's not here | 14:05 |
| rosmaita | but, there's a kind of light agenda (except for the review requests) | 14:06 |
| rosmaita | I'm not aware of anything to announce ... anyone got anything? | 14:06 |
| rosmaita | ok, one thing ... looks like PTL self-nomination season is oepn today at 23:45 UTC | 14:07 |
| rosmaita | if you are interested in becoming cinder PTL, either for Flamingo or G or H or something | 14:09 |
| rosmaita | we have several still-active PTLs you can talk to and find out what the job entails | 14:09 |
| rosmaita | (also, i believe that Jon will stand for election again, but i haven't actually asked him) | 14:09 |
| rosmaita | but, might as well think about the future | 14:10 |
| rosmaita | anyone got anything else? | 14:10 |
| rosmaita | ok, on to the topics | 14:11 |
| rosmaita | #topic help to review the powermax bug fixes which are important for third party CI | 14:12 |
| rosmaita | not sure who put this on? | 14:12 |
| rosmaita | possibly nileshthathagar ? | 14:12 |
| nileshthathagar | yes that was me | 14:13 |
| rosmaita | it is awful quiet in here ... am i netsplit? | 14:13 |
| rosmaita | ok, the floor is yours | 14:13 |
| whoami-rajat | we can see you rosmaita | 14:13 |
| rosmaita | :D | 14:13 |
| rosmaita | i am wearing blue today | 14:13 |
| whoami-rajat | :D | 14:14 |
| * whoami-rajat sorry for interrupting, nileshthathagar please go ahead | 14:14 | |
| nileshthathagar | sure thanks there are few patches which required when powermax CI is ready to run | 14:15 |
| rosmaita | nileshthathagar: it sounds like these particular patches are important to get your 3rd party ci working again? | 14:15 |
| rosmaita | (or am i thinking of a different dell driver) | 14:15 |
| nileshthathagar | when powermax CI will get fixed. this patches also required to CI get passed. | 14:16 |
| nileshthathagar | we have all CI gets broken but these patches will help to smooth run of CI when It will get fixed. | 14:17 |
| nileshthathagar | for powermax | 14:17 |
| rosmaita | ok, the cinder community encourages third party ci, so it makes sense to prioritize these reviews | 14:17 |
| nileshthathagar | great. thanks | 14:17 |
| rosmaita | i will commit to looking at the 3 on lines 76-78 in the etherpad immediately following the meeting | 14:18 |
| rosmaita | can i get a commitment from someone else? | 14:18 |
| * sp-bmilanov added the the three lines with changes, maybe nileshthathagar can add more if there are any | 14:19 | |
| rosmaita | ty sp-bmilanov | 14:19 |
| rosmaita | i still think i may be netsplit, though that doesn't seem to happen much with OFTC | 14:20 |
| nileshthathagar | all added. thanks | 14:20 |
| rosmaita | used to happen all the time on freenode | 14:20 |
| rosmaita | ok, next item | 14:20 |
| rosmaita | #topic old patch of the week | 14:20 |
| rosmaita | that's me | 14:20 |
| rosmaita | not my patch, but a patch I came across | 14:21 |
| rosmaita | Record the original size when creating an image from a volume | 14:21 |
| rosmaita | #link https://review.opendev.org/c/openstack/cinder/+/804584 | 14:21 |
| rosmaita | seems very straigthtforward, so i am wondering if i am missing something | 14:21 |
| rosmaita | basically, the idea is that glance has this 'min_disk" image property | 14:22 |
| rosmaita | cinder and nova pay attention to it when you request to do something with an image | 14:22 |
| whoami-rajat | nileshthathagar, i wanted to know more details about the os-brick patch, maybe we can discuss in open-discussion | 14:22 |
| rosmaita | the issue is that if you upload a volume as an image to glance, and it's a qcow2 or something | 14:23 |
| rosmaita | the virtual size of the volume may be bigger than it's actual size in glance | 14:23 |
| rosmaita | and when you request to do an image-to-volume operation in cinder, it can fail | 14:23 |
| rosmaita | if the user picks a size that looks big enough, but really isn't | 14:23 |
| rosmaita | so the proposal is that since we know how big the volume is that we are uploading from cinder | 14:24 |
| nileshthathagar | whoami-rajat, we can discuss in direct chat. I am also in another meeting as well. | 14:24 |
| rosmaita | and since min_disk is in GB | 14:24 |
| sp-bmilanov | this sounds like a Tempest test case as well? | 14:24 |
| whoami-rajat | nileshthathagar, sure | 14:24 |
| whoami-rajat | rosmaita, so when we upload the volume to glance, doesn't glance calculate the virtual_size? | 14:24 |
| rosmaita | cinder can add the min_disk property when the image is uploaded to glance | 14:24 |
| rosmaita | whoami-rajat: i am not sure if it does that in the normal upload path | 14:25 |
| rosmaita | that may be an image import thing | 14:25 |
| rosmaita | (though that may have changed) | 14:25 |
| rosmaita | in any case, we have min_disk tooling already in place (on the download side), so maybe it makes sense to do it on upload? | 14:28 |
| whoami-rajat | certainly adding min_disk property would make volume create from image request fail fast | 14:28 |
| rosmaita | ok, just got confirmation that whoami-rajat is correct, glance does compute virtual_size on the upload path we use | 14:29 |
| whoami-rajat | that was quick! | 14:29 |
| rosmaita | i think fail-fast is the key thing, if we can fail in the REST API response, that's a better user experience | 14:29 |
| rosmaita | whoami-rajat: i just happened to be talking to dansmith in another channel | 14:30 |
| whoami-rajat | yep, also the min_disk property would act as a data point for end user to know what size they should provide for the volume create | 14:30 |
| whoami-rajat | if users are able to see it | 14:30 |
| rosmaita | it's a standard glance property | 14:30 |
| rosmaita | the other thing about min_disk is that it is the same unit as cinder volumes | 14:30 |
| rosmaita | whereas i believe the virtual_size is bytes | 14:31 |
| rosmaita | #link https://docs.openstack.org/api-ref/image/v2/index.html#image-schemas | 14:32 |
| rosmaita | so if it is populated in the database, it will be in the image-show response | 14:33 |
| rosmaita | ok, well we can continue this discussion on the patch ... it would be good to move that along, because requesting a volume create, and getting a 204, and then having the volume go to error status, is not a good user experience | 14:34 |
| rosmaita | now we come to my least favorite part of the meeting | 14:35 |
| rosmaita | #topic review requests | 14:35 |
| yuval | :) | 14:35 |
| rosmaita | we already discussed the dell PowerMax | 14:35 |
| rosmaita | does anyone have anything helpful to point out about the others | 14:36 |
| rosmaita | i think sp-bmilanov did put a comment on line 88 that is helpful | 14:36 |
| sp-bmilanov | yep, I've got one from me | 14:36 |
| rosmaita | (as an explanation of why we need to review quickly) | 14:36 |
| sp-bmilanov | yes, in a nutshell, os-brick now uses the internal API client for communicating with StorPool | 14:37 |
| sp-bmilanov | because the change is merged, but the change that switches the client over inside Cinder is this one, and still not merged | 14:37 |
| sp-bmilanov | it would be really nice not to have a release in which we have to be careful that one is using one, and the other -- another | 14:38 |
| rosmaita | yes, it makes sense to get everything in order | 14:39 |
| rosmaita | just to be clear, this is an "all-or-nothing" patch, i mean, once the cinder patch is merged, you *must* be using os-brick >=6.10.0 | 14:40 |
| sp-bmilanov | the change is 80% a search and replace of the API calls, and 20% inits and stuff that are done differently with the internal client | 14:40 |
| rosmaita | what i mean is, there is not a provision to fall back to look for the old storpool packages | 14:40 |
| sp-bmilanov | yes, I need to check if the requirements.txt reflects this | 14:40 |
| rosmaita | yes, you did update requirements.txt on your patch | 14:40 |
| sp-bmilanov | ah, right, yes, there is no planned fallback, we would like to support the internal client only, not both | 14:41 |
| rosmaita | that's fine, what i am getting at is maybe you should word the release note more strongly | 14:42 |
| rosmaita | to make it clear that not only are the storpool packages not required, they are ignored, you must use the correct version of os-brick | 14:42 |
| rosmaita | (but maybe that's overkill) | 14:42 |
| sp-bmilanov | good point, it should at least mention that it's only the internal client, nothing else | 14:43 |
| sp-bmilanov | it see how you could read it as either-or currently | 14:43 |
| rosmaita | and maybe in the docs, instead of deleting that section, maybe turn it into a note | 14:44 |
| rosmaita | mainly for people upgrading, new users won't care | 14:44 |
| rosmaita | but those are nits and could certainly be a follow up | 14:44 |
| sp-bmilanov | turn it into a note inside the docs? sth like "previously you had to install X, now you need os-brick Y"? | 14:45 |
| sp-bmilanov | or like a proper releasenote with an "upgrade" classifier? | 14:45 |
| sp-bmilanov | the latter sounds better | 14:45 |
| rosmaita | that sounds good to me | 14:46 |
| sp-bmilanov | nice, thanks | 14:46 |
| rosmaita | old users will see the upgrade note, and new users don't need to know anything | 14:46 |
| rosmaita | ok, any comments about any of the other reviews? | 14:47 |
| rosmaita | ok, let's end the meeting early and go do some reviews! | 14:48 |
| rosmaita | #endmeeting | 14:48 |
| opendevmeet | Meeting ended Wed Feb 5 14:48:16 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:48 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder/2025/cinder.2025-02-05-14.02.html | 14:48 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder/2025/cinder.2025-02-05-14.02.txt | 14:48 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder/2025/cinder.2025-02-05-14.02.log.html | 14:48 |
| sp-bmilanov | thanks! | 14:50 |
| whoami-rajat | nileshthathagar, hey, can you join the #openstack-cinder channel | 14:57 |
| nileshthathagar | whoami-rajat, sure. | 15:14 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!