Wednesday, 2012-01-25

mtaylorsalv-orlando_: thanks for the catch00:00
*** dolphm has joined #openstack-meeting00:04
*** somik has quit IRC00:06
*** troytoman is now known as troytoman-away00:11
*** jakedahn_ has joined #openstack-meeting00:11
*** danwent has joined #openstack-meeting00:11
*** jakedahn has quit IRC00:14
*** jakedahn_ is now known as jakedahn00:14
*** ewindisch has quit IRC00:15
*** ewindisch_ is now known as ewindisch00:15
*** pballand has left #openstack-meeting00:17
*** salv-orlando_ has quit IRC00:17
*** dolphm has quit IRC00:22
*** salv-orlando_ has joined #openstack-meeting00:31
salv-orlando_anyone from the Cisco Openstack team online?00:31
*** bhall has joined #openstack-meeting00:41
*** bhall has quit IRC00:42
*** bhall has joined #openstack-meeting00:42
*** bhall has quit IRC00:42
*** bhall has joined #openstack-meeting00:42
danwentsalv-orlando_:  maybe ping netstack list?00:42
danwentsalv-orlando_: btw, bhall will be pinging you witha  quick patch for the API errors branch.  there was an issue with a test he just recently added.00:43
bhallprivmsg'd and emailed00:43
*** debo-os has joined #openstack-meeting00:51
*** sleepsonthefloo has quit IRC01:13
*** novas0x2a|laptop has quit IRC01:17
*** ohnoimdead has quit IRC01:21
*** gyee has quit IRC01:29
*** zns has joined #openstack-meeting01:30
*** bhall has quit IRC01:31
*** zns has quit IRC01:33
*** andrewbogott has quit IRC01:35
*** sarob has quit IRC01:35
*** jakedahn has quit IRC01:38
mtaylordanwent: hey ...
mtaylorsalv-orlando_: ^^01:42
salv-orlando_I'm here01:42
mtaylordanwent: that above is needed for your patch in to python-quantumclient to work01:42
*** bencherian has joined #openstack-meeting01:43
mtaylor(we're close to getting this bad boy done - isn't this fun?)01:43
danwentindeed :)01:43
danwentmtaylor, so lxml needs to be added to quantum-server but not quantum-client?01:43
mtaylordanwent: yeah - quantum-server uses it01:43
salv-orlando_mtaylor: thanks we recently fixed lxml in pip-requires, but that patch should have really fixed as well01:43
danwentgood catch, btw, i think we added it to pip-requires01:43
mtaylorsalv-orlando_: ++01:44
danwentwill approve right now, hopefully salv can also click +201:44
danwentbeat me to it salv!01:44
danwentok, should be getting merged01:45
danwentmtaylor: did you see review from salv-orlando_ about tissue?01:46
danwentafter that, i think we're ready to push the client split01:46
mtayloryes - I'll have a new update for that in a sec01:47
salv-orlando_I'm still here for a +201:47
*** zns has joined #openstack-meeting01:49
danwentbtw, salv, thanks for catching the tissue thing… missed that01:50
salv-orlando_danwent: something to worry about (probably) unit tests in master fail with PLUGIN_DIR=quantum/plugins/openvswitch01:50
salv-orlando_AttributeError: 'module' object has not attribute 'NotImplementedError'01:50
danwenthmm… i am seeing them pass for me.01:51
danwentcan you send me more detailed output?01:51
danwentwhat is your HEAD?01:51
danwentI wonder if this is an issue that brad was seeing with different versions of library for http errors.01:52
danwentthanks for the heads up01:52
salv-orlando_sure... I'll login into IRC from the PC were I do development01:52
danwentyou can just email me as well.01:53
danwentalso, might be helpful to know what distro + version you are running.01:53
*** another-salv has joined #openstack-meeting01:54
danwenttwo salvs!01:54
another-salv  File "./quantum/plugins/openvswitch/", line 41, in <module>01:54
another-salv    from quantum.api.api_common import OperationalStatus01:54
another-salv  File "/home/salvatore/git/quantum-new/quantum/api/", line 28, in <module>01:54
another-salv    from quantum.api import attachments01:54
another-salv  File "/home/salvatore/git/quantum-new/quantum/api/", line 18, in <module>01:54
another-salv    from quantum.api import api_common as common01:54
another-salv  File "/home/salvatore/git/quantum-new/quantum/api/", line 23, in <module>01:54
another-salv    from quantum.api import faults01:54
another-salv  File "/home/salvatore/git/quantum-new/quantum/api/", line 32, in <module>01:54
another-salv    class QuantumHTTPError(webob.exc.HTTPClientError):01:54
another-salv  File "/home/salvatore/git/quantum-new/quantum/api/", line 68, in QuantumHTTPError01:55
another-salv    'explanation': _NOTIMPLEMENTED_EXPL01:55
*** oubiwann has quit IRC01:55
another-salvlast commit is:1dd7766dcadcd52ee0e9cd6c6e4436236816761101:55
danwenthrm, are you running on natty or something else?01:56
salv-orlando_what puzzles me is that this error appears only when PLUGIN_DIR points to openvswitch01:57
danwentI wonder if your install has an outdate version of the "common" code that is in the client repo?01:57
danwentif you reinstall from pip-requires, i'm guessing you'll get updated client code?01:58
salv-orlando_uhm that might explain01:58
danwenti think it probably only happens when you run OVS, because the code that imports NotImplemented is an extension.  Just a guess though.02:00
salv-orlando_I found the issue... it was me being dumb. Basically I though the venv needed to be recreated, and I therefore deleted it before running the test. But since I'm dumb, I deleted .quantum-venv, which was the "old" folder, and not .venv02:01
salv-orlando_still I don't get why it did not happen when running "standard" unit tests...02:01
*** novas0x2a|laptop has joined #openstack-meeting02:02
*** novas0x2a|laptop has quit IRC02:02
*** anotherjesse has joined #openstack-meeting02:02
*** novas0x2a|laptop has joined #openstack-meeting02:02
*** dprince has joined #openstack-meeting02:03
danwentafter a quick glance, i don't either02:03
salv-orlando_I think that it is not a high priority issue though.02:04
danwentyes, and a small fix we can push to milestone-proposed tomorrow02:06
salv-orlando_I'll wait a few more minutes for the updated split patch from mtaylor.02:06
danwentok, in the mean time, what are your thoughts on my comment about the filtering branch returning a pair, vs. using a dict passed by reference.02:06
salv-orlando_Have a look here:,296802:07
*** another-salv has left #openstack-meeting02:07
danwentah, sorry missed that.02:07
salv-orlando_The last changeset basically leverages the fact the filters are passed by reference.02:08
danwentyup, see that.  thanks.02:08
salv-orlando_Should any problem arise with that while I'm sleeping, the previous changeset returns the pair02:08
mtaylorsalv-orlando_, danwent: so I'm hitting the NotImplemented thing above when I try to test the quantumclient code now02:08
*** dprince has quit IRC02:08
danwentmtaylor, do you need to update the version of quantum-client pulled in?02:09
mtaylordanwent: this is in the quantumclient tests :)02:09
danwenthaey salv, why don't you head to bed.  I can get bhall or someone else to be the second +2 once monty and I figure this out.02:09
*** reed has joined #openstack-meeting02:09
mtaylordanwent: if you grab your latest patch and run "tox -v -r -epy27"  ... you'll see the same traceback from above02:10
salv-orlando_Yes, that might be better. Talk to you in a bit, guys!02:10
danwentmtaylor: i think this is pretty easy.  brad made a change to quantum.client after you pulled your repo, I think02:10
danwentlet me check02:10
mtaylordanwent: ah, cool02:10
*** salv-orlando_ has quit IRC02:11
danwentchanges to quantum/client/ and quantum/common/exceptions.py02:11
danwentrepo change race condition :)02:12
danwentI should have noticed it during review02:12
danwenti can propose02:12
mtaylordanwent: ah - well, I think also I'm testing quantumclient against a non-split quantum server - which is also probably fun02:13
*** dendro-afk is now known as dendrobates02:13
*** reed has quit IRC02:18
mtaylordanwent: w00t!02:20
danwentyou win02:20
mtaylordanwent: if that patch goes in, then your patch can go in02:20
danwentok, are you going to push both?02:20
mtaylorand then quantumclient is good02:20
mtaylorwell- you review mine, I'll review yours :)02:21
*** martine has joined #openstack-meeting02:21
mtayloroh - you know - I betcha we're going to need to squash them ... I don't think the first one will pass jenkins02:23
mtaylorwelp. I was wrong. :)02:26
* mtaylor is going to learn to have more patience02:26
danwentI was rushing to beat you to push a squashed commit, then i didn't need it :P02:27
danwentbtw, tox always hangs when I run it (either that, or I am impatient)02:28
mtaylorah - next time try tox -v02:29
mtaylorthat's verbose mode02:29
mtaylorit's likely that you're impatient - it's building a virtualenv02:29
*** jdurgin has quit IRC02:30
danwentright you are :)02:30
*** reed has joined #openstack-meeting02:31
danwentbtw, were you going to push something in response to Salv's question about using tissue?02:31
mtaylordanwent: ok. I have updated the patch (removing tissue for now, we don't have it fully working yet - we'll submit a patch to actually use it)02:33
danwentok, sounds good.  I will run tests, then +2 it.  Will try to track down someone else to +2 as well, but it has been pretty heavily reviewed, so if needed, I can just approve it directly.02:34
mtaylork. it is a big patch though - a proper 2 +2's is proably nice02:34
danwentindeed :)02:35
*** heckj has quit IRC02:35
danwentI want bhall to look through it anyway, so that should do02:35
danwentyou should head out… i imagine it is getting late for you02:35
*** bencherian has quit IRC02:38
*** dendrobates is now known as dendro-afk02:40
danwentmtaylor: ok, i +2'd and ping brad02:42
*** dendro-afk is now known as dendrobates02:42
mtaylordanwent: don't shoot me - I found one more issue. sigh02:48
*** bencherian has joined #openstack-meeting02:49
danwentok, no worries, it hasn't gone in yet.02:49
danwentand even if we find issues tomorrow, we can cherry-pick them to milestone-proposed02:49
*** bencherian has quit IRC02:49
mtaylordanwent: somehow I thought that we needed pep8 >= 0.6.3 - everything else is == 0.6.102:49
mtaylordanwent: check it one more time :(02:50
danwentour required >=0.6.1, not ==, does that matter?02:52
*** martine has quit IRC02:52
mtaylordanwent: not today - 0.6.1 is the latest02:52
*** martine has joined #openstack-meeting02:52
mtaylordanwent: (this is the issue - there is no 0.6.3 :) )02:53
danwentah, got it02:53
danwentok, bhall said he will do second review tonight.  unless there's a huge issue, I will push and assume we can fix any minor issues as part of milestone-proposed.02:54
*** anotherjesse has quit IRC02:57
*** edgarmagana has quit IRC03:01
danwentmtaylor: heading out for food. will be online later if anything pops up.  thanks again for all your help getting quantum integrated into the CI process.03:06
mtaylordanwent: my pleasure! I have a few more non-urgent patches coming03:07
*** adjohn has quit IRC03:07
danwentgreat.  ttyl03:08
*** danwent has quit IRC03:08
*** novas0x2a|laptop has quit IRC03:09
*** jog0 has quit IRC03:16
*** edconzel_ has quit IRC03:26
*** martine has quit IRC03:29
*** debo-os has quit IRC03:41
*** martine has joined #openstack-meeting03:44
*** AlanClark has quit IRC03:45
*** martine has quit IRC03:50
*** danwent has joined #openstack-meeting03:50
*** ewindisch_ has joined #openstack-meeting03:54
*** mjfork has quit IRC03:57
*** sarob has joined #openstack-meeting04:07
*** oubiwann has joined #openstack-meeting04:19
*** sarob_ has joined #openstack-meeting04:24
*** sleepsonthefloo has joined #openstack-meeting04:26
*** sarob has quit IRC04:27
*** oubiwann has quit IRC04:40
*** sleepsonthefloo has quit IRC04:49
*** sleepsonthefloo has joined #openstack-meeting04:49
*** davlap has quit IRC06:01
*** reed has quit IRC06:03
*** zns1 has joined #openstack-meeting06:49
*** ewindisch_ has quit IRC06:50
*** ewindisch_ has joined #openstack-meeting06:50
*** zns has quit IRC06:51
*** byeager has quit IRC06:51
*** sleepsonthefloo has quit IRC06:57
*** novas0x2a|laptop has joined #openstack-meeting07:00
*** GheRivero has quit IRC07:04
*** ghe_ has joined #openstack-meeting07:04
*** yehudasa has quit IRC07:16
*** yehudasa has joined #openstack-meeting07:30
*** zns1 has quit IRC07:31
*** bmcconne has quit IRC07:38
*** salv-orlando has joined #openstack-meeting08:26
*** novas0x2a|lapto1 has joined #openstack-meeting08:29
*** novas0x2a|laptop has quit IRC08:30
*** ghe_ is now known as GheRivero08:39
*** zigo has joined #openstack-meeting09:10
*** derekh has joined #openstack-meeting09:39
*** ewindisch_ has quit IRC09:47
*** derekh has quit IRC09:47
*** derekh has joined #openstack-meeting09:47
*** danwent has quit IRC09:48
*** darraghb has joined #openstack-meeting09:54
*** ewindisch_ has joined #openstack-meeting10:05
*** novas0x2a|lapto1 has quit IRC10:30
*** novas0x2a|laptop has joined #openstack-meeting10:30
*** uvirtbot` has joined #openstack-meeting10:36
*** uvirtbot has quit IRC10:36
*** salv-orlando has left #openstack-meeting11:19
*** mjfork has joined #openstack-meeting11:51
*** mjfork has left #openstack-meeting11:56
*** GheRivero has quit IRC11:58
*** ghe_ has joined #openstack-meeting11:58
*** zigo has quit IRC12:00
*** novas0x2a|laptop has quit IRC12:30
*** markvoelker has joined #openstack-meeting12:38
*** dprince has joined #openstack-meeting13:12
*** zigo has joined #openstack-meeting13:28
*** dolphm has joined #openstack-meeting13:34
*** novas0x2a|laptop has joined #openstack-meeting13:34
*** derekh has quit IRC13:40
*** derekh has joined #openstack-meeting13:53
*** mattray has joined #openstack-meeting13:56
*** dolphm has quit IRC13:59
*** dolphm has joined #openstack-meeting13:59
*** dolphm has quit IRC14:03
*** ayoung has joined #openstack-meeting14:31
*** rkukura has joined #openstack-meeting14:36
*** rkukura has left #openstack-meeting14:36
*** dendrobates is now known as dendro-afk14:52
*** deshantm has joined #openstack-meeting14:54
*** mahmoh has joined #openstack-meeting15:00
*** mestery has joined #openstack-meeting15:04
*** mestery_ has quit IRC15:07
*** davlap has joined #openstack-meeting15:08
*** AlanClark has joined #openstack-meeting15:08
*** GheRivero has joined #openstack-meeting15:18
*** mattray1 has joined #openstack-meeting15:20
*** mattray has quit IRC15:21
*** reed has joined #openstack-meeting15:29
*** novas0x2a|laptop has quit IRC15:30
*** hggdh has quit IRC15:32
*** ke4qqq has quit IRC15:33
*** zigo has quit IRC15:33

Generated by 2.14.0 by Marius Gedminas - find it at!