*** rbudden has quit IRC | 00:03 | |
*** jamesmcarthur has joined #openstack-meeting | 00:11 | |
*** macz_ has quit IRC | 00:30 | |
*** jamesmcarthur has quit IRC | 00:40 | |
*** jmasud has quit IRC | 00:46 | |
*** mlavalle has quit IRC | 00:49 | |
*** jmasud has joined #openstack-meeting | 00:54 | |
*** armax has joined #openstack-meeting | 01:11 | |
*** jamesdenton has quit IRC | 01:33 | |
*** jamesden_ has joined #openstack-meeting | 01:34 | |
*** baojg has joined #openstack-meeting | 01:36 | |
*** armax has quit IRC | 01:44 | |
*** xinranwang has joined #openstack-meeting | 02:01 | |
*** ricolin_ has joined #openstack-meeting | 02:14 | |
*** lbragstad_ is now known as lbragstad | 02:15 | |
*** rbudden has joined #openstack-meeting | 03:15 | |
*** jmasud has quit IRC | 03:17 | |
*** jmasud has joined #openstack-meeting | 03:25 | |
*** jmasud has quit IRC | 03:46 | |
*** yasufum has joined #openstack-meeting | 03:58 | |
*** ricolin_ has quit IRC | 04:20 | |
*** macz_ has joined #openstack-meeting | 04:21 | |
*** ricolin has joined #openstack-meeting | 04:24 | |
*** macz_ has quit IRC | 04:25 | |
*** jmasud has joined #openstack-meeting | 04:28 | |
*** yamamoto_ has joined #openstack-meeting | 04:51 | |
*** yasufum_ has joined #openstack-meeting | 04:52 | |
*** yamamoto has quit IRC | 04:52 | |
*** yasufum has quit IRC | 04:52 | |
*** yasufum_ is now known as yasufum | 04:52 | |
*** jmasud has quit IRC | 05:02 | |
*** xinranwang has quit IRC | 05:07 | |
*** ricolin has quit IRC | 05:11 | |
*** ricolin has joined #openstack-meeting | 05:24 | |
*** jmasud has joined #openstack-meeting | 05:31 | |
*** evrardjp has quit IRC | 05:33 | |
*** evrardjp has joined #openstack-meeting | 05:33 | |
*** rbudden has quit IRC | 05:43 | |
*** vishalmanchanda has joined #openstack-meeting | 05:58 | |
*** rcernin has quit IRC | 06:07 | |
*** jmasud has quit IRC | 06:26 | |
*** jmasud has joined #openstack-meeting | 06:30 | |
*** psahoo has joined #openstack-meeting | 06:34 | |
*** yasufum_ has joined #openstack-meeting | 06:41 | |
*** yasufum has quit IRC | 06:41 | |
*** yasufum_ is now known as yasufum | 06:41 | |
*** gyee has quit IRC | 06:46 | |
*** psahoo_ has joined #openstack-meeting | 06:58 | |
*** psahoo has quit IRC | 07:02 | |
*** lpetrut has joined #openstack-meeting | 07:10 | |
*** ralonsoh has joined #openstack-meeting | 07:41 | |
*** jmasud has quit IRC | 07:53 | |
*** slaweq has joined #openstack-meeting | 07:58 | |
*** yasufum has quit IRC | 07:58 | |
*** e0ne has joined #openstack-meeting | 07:58 | |
*** yasufum has joined #openstack-meeting | 07:58 | |
*** ociuhandu has joined #openstack-meeting | 08:00 | |
*** ociuhandu has quit IRC | 08:05 | |
*** jamesden_ has quit IRC | 08:05 | |
*** jamesdenton has joined #openstack-meeting | 08:06 | |
*** rpittau|afk is now known as rpittau | 08:11 | |
*** tosky has joined #openstack-meeting | 08:16 | |
*** bbowen_ has joined #openstack-meeting | 08:44 | |
*** bbowen has quit IRC | 08:46 | |
*** ociuhandu has joined #openstack-meeting | 08:58 | |
*** jmasud has joined #openstack-meeting | 09:03 | |
*** ociuhandu has quit IRC | 09:04 | |
*** ociuhandu has joined #openstack-meeting | 09:10 | |
*** ociuhandu has quit IRC | 09:14 | |
*** lpetrut_ has joined #openstack-meeting | 09:34 | |
*** tosky has quit IRC | 09:36 | |
*** tosky_ has joined #openstack-meeting | 09:36 | |
*** lpetrut has quit IRC | 09:37 | |
*** yamamoto_ has quit IRC | 09:39 | |
*** tosky_ is now known as tosky | 09:43 | |
*** jamesdenton has quit IRC | 10:00 | |
*** jamesdenton has joined #openstack-meeting | 10:01 | |
*** ociuhandu has joined #openstack-meeting | 10:18 | |
*** yamamoto has joined #openstack-meeting | 10:22 | |
*** jmasud has quit IRC | 10:25 | |
*** yamamoto has quit IRC | 10:28 | |
*** yasufum has quit IRC | 10:28 | |
*** dsariel has joined #openstack-meeting | 10:56 | |
*** rcernin has joined #openstack-meeting | 11:23 | |
*** e0ne has quit IRC | 11:28 | |
*** baojg has quit IRC | 11:41 | |
*** bbowen_ has quit IRC | 11:53 | |
*** bbowen has joined #openstack-meeting | 11:53 | |
*** yamamoto has joined #openstack-meeting | 11:56 | |
*** rcernin has quit IRC | 11:57 | |
*** ricolin has quit IRC | 12:06 | |
*** jamesdenton has quit IRC | 12:18 | |
*** jamesdenton has joined #openstack-meeting | 12:19 | |
*** raildo has joined #openstack-meeting | 12:38 | |
*** yamamoto has quit IRC | 12:40 | |
*** ociuhandu has quit IRC | 12:49 | |
*** seba has joined #openstack-meeting | 13:02 | |
*** rh-jelabarre has joined #openstack-meeting | 13:02 | |
*** tosky has quit IRC | 13:06 | |
*** tosky has joined #openstack-meeting | 13:06 | |
*** ricolin has joined #openstack-meeting | 13:08 | |
*** yamamoto has joined #openstack-meeting | 13:13 | |
*** yamamoto has quit IRC | 13:18 | |
*** yamamoto has joined #openstack-meeting | 13:18 | |
*** ociuhandu has joined #openstack-meeting | 13:23 | |
*** dmacpher has quit IRC | 13:23 | |
*** dmacpher has joined #openstack-meeting | 13:28 | |
*** rosmaita has joined #openstack-meeting | 14:04 | |
*** yasufum has joined #openstack-meeting | 14:05 | |
jokke | #startmeeting glance | 14:09 |
---|---|---|
openstack | Meeting started Thu Jan 21 14:09:23 2021 UTC and is due to finish in 60 minutes. The chair is jokke. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:09 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:09 |
*** openstack changes topic to " (Meeting topic: glance)" | 14:09 | |
openstack | The meeting name has been set to 'glance' | 14:09 |
jokke | #topic roll-call | 14:09 |
*** openstack changes topic to "roll-call (Meeting topic: glance)" | 14:09 | |
jokke | o/ | 14:09 |
rosmaita | o/ | 14:09 |
jokke | #link https://etherpad.openstack.org/p/glance-team-meeting-agenda | 14:10 |
dansmith | o/ | 14:11 |
dansmith | isn't abhishekk back today? | 14:11 |
jokke | Tomorrow, they had good Wedding week ;) | 14:11 |
dansmith | dang | 14:11 |
jokke | I think that's everyone so lets get started | 14:12 |
rosmaita | well, best wishes from the glance team to the newlyweds! | 14:12 |
dansmith | it is his sister I think | 14:12 |
jokke | #topic release updates | 14:13 |
*** openstack changes topic to "release updates (Meeting topic: glance)" | 14:13 | |
jokke | #undo | 14:13 |
openstack | Removing item from minutes: #topic release updates | 14:13 |
rosmaita | dansmith: yes, but still | 14:13 |
jokke | indeed his sister | 14:13 |
jokke | and indeed big GZ! | 14:13 |
jokke | #topic release updates | 14:13 |
*** openstack changes topic to "release updates (Meeting topic: glance)" | 14:13 | |
jokke | So we have m-2 release patch waiting ofr the release team to get it tagged | 14:13 |
jokke | nothing special on that | 14:14 |
jokke | #topic reserved image properties | 14:14 |
*** openstack changes topic to "reserved image properties (Meeting topic: glance)" | 14:14 | |
jokke | dansmith: I think this is yours | 14:14 |
rosmaita | i forget why i put that on the agenda | 14:15 |
dansmith | patches are up, would love some review :) | 14:15 |
rosmaita | oh, yeah, there are some side impacts | 14:15 |
jokke | #link https://review.opendev.org/q/topic:%22os-glance-namespace%22+(status:open%20OR%20status:merged) | 14:15 |
dansmith | I have a nova fix also because nova was abusing some props that this will prevent | 14:15 |
rosmaita | i think we need to remove that deprecated option that disallows custom image properties | 14:16 |
jokke | #link https://specs.openstack.org/openstack/glance-specs/specs/ussuri/approved/glance/deprecate-allow-custom-props.html | 14:16 |
jokke | that one | 14:16 |
rosmaita | yep | 14:16 |
rosmaita | i guess it's assigned to me, but i wonder if cyril might pick it up | 14:17 |
dansmith | that needs to go before the reserved props? just because they could technically put reserved props in the additional list? | 14:17 |
jokke | I also think we should not count os_glance_* for the quota | 14:17 |
dansmith | oh, yeah, I was supposed to look at that, but this doesn't change behavior if we're already doing that | 14:18 |
rosmaita | i agree, though am not sure how easy that will be | 14:18 |
rosmaita | i think our quota management is onion-layered | 14:18 |
jokke | I'm pretty sure it is | 14:18 |
rosmaita | yeah, so the short-term fix would be set a min on the quota that allows for maybe 5 or so of those properties | 14:19 |
rosmaita | and dansmith to answer your question, i am not sure whether the reserved properties would be blocked if custom properties are disallowed | 14:20 |
rosmaita | not sure where that enforcement happens | 14:20 |
dansmith | rosmaita: the enforcement is at the API layer, so I think not | 14:20 |
rosmaita | ok, that would be good | 14:20 |
rosmaita | i think we still need to remove the custom properties turnoff, because all sorts of services rely on them | 14:21 |
*** rajivmucheli has joined #openstack-meeting | 14:21 | |
rosmaita | but maybe we don't have to absolutely do it in wallaby | 14:22 |
jokke | I think we need to deprecate it and wait at least a cycle anyways | 14:22 |
dansmith | does that mean execute on the planned deprecation or cancel the deprecation? | 14:22 |
jokke | as per the standard deprecation policy | 14:22 |
rosmaita | i thought it was deprecated already | 14:22 |
rosmaita | i will check | 14:22 |
jokke | ohh, might be my bad. if it was indeed deprecated in ussuri where that spec is, we should be fine removing it now | 14:23 |
dansmith | right, so I'm asking if rosmaita is talking about undeprecating, or continuing on removal | 14:24 |
rosmaita | yes, glance conf is showing deprecated since ussuri | 14:24 |
rosmaita | i am talking about removing it | 14:24 |
rosmaita | continuing with the deprecation | 14:24 |
dansmith | okay, you said "remove the custom turnoff, because people rely on it" so I was all confused :) | 14:24 |
rosmaita | i wasn't sure if it would impact glance's own use of additional properties | 14:24 |
rosmaita | sorry, what i meant was | 14:24 |
rosmaita | all sorts of services use custom image properties (like cinder_encryption_key_id) | 14:25 |
rosmaita | and some hypervisor stuff for nova | 14:25 |
*** macz_ has joined #openstack-meeting | 14:25 | |
rosmaita | so if you turn them off, all sorts of stuff will break in your cloud | 14:25 |
rosmaita | so we should remove the temptation to turn them off | 14:26 |
dansmith | right, but this is just talking about removing the static list of allowed ones yeah? | 14:26 |
*** markmcclain has quit IRC | 14:26 | |
rosmaita | no | 14:26 |
rosmaita | there's an option that restricts whether *any* properties outside the image schema are allowed | 14:26 |
jokke | dansmith: we have config option that allows deployer to turn off all custom properties that are not supplied by glance | 14:26 |
dansmith | oh, it's a toggle I see | 14:26 |
dansmith | sorry, I thought it was a list for some reason. I'm caught up now | 14:27 |
rosmaita | yeah, not sure why it was there, but it was | 14:27 |
jokke | I think that's still remains from the Images API v1 times | 14:27 |
jokke | so very early days | 14:28 |
rosmaita | yeah, before the "quotas" were introduced | 14:29 |
rosmaita | i blame jay pipes! | 14:29 |
jokke | What I do not know is if we can change the minimum quota or if we just need to document it | 14:29 |
rosmaita | good question | 14:30 |
dansmith | what happens if the user uses all N on create, | 14:30 |
*** macz_ has quit IRC | 14:30 | |
rosmaita | that would be a problem | 14:30 |
dansmith | and then when we go to import... will glance get stuck unable to add os_glance_importing_to_stores? | 14:30 |
rosmaita | that requires some investigation | 14:31 |
rosmaita | comes down to where the enforcement actually happens | 14:31 |
jokke | dansmith: that's why I was saying we just shouldn't count the os_glance_ in the quota at all now when we're preventing external setting of them | 14:31 |
dansmith | well, if it's onioned, I expect way below the api | 14:31 |
dansmith | jokke: yep, I'm totally on board with that, | 14:32 |
dansmith | I'm just saying maybe upping the minimum isn't good enough | 14:32 |
rosmaita | that's my worry, it was implemented while markwash was PTL iirc | 14:32 |
rosmaita | and he was big on the onion | 14:32 |
dansmith | oh, is that who I should name my voodoo doll after? | 14:32 |
jokke | dansmith: agreed and I don't know if we even can do that. Even changing some default values has been massive fight with QA, so I guess if tempest is testing any of the property quota stuff, changing it will be no-go | 14:33 |
rosmaita | i'm pretty sure they don't | 14:33 |
dansmith | I don't think that'd be a fight, FWIW, but that's a good reason to actually exclude it from the quota, in addition to the DoS problem | 14:34 |
jokke | Yeah I don't think enforcing minimum quota will do any good if someone decides that they want feck around | 14:35 |
jokke | anything else about this? | 14:38 |
*** vishalmanchanda has quit IRC | 14:38 | |
rosmaita | only whether we have an action item | 14:39 |
rosmaita | i guess dansmith will look into this? | 14:39 |
dansmith | I still don't think either of these things are important to do before we land this enforcement, | 14:39 |
dansmith | because the enforcement doesn't change the results of either | 14:39 |
rosmaita | i don't disagree, just think we need to have a better understanding of the quota issue before RC time | 14:40 |
jokke | correct I don't see reason why they should land before landing the enforcement patch. Just need to make sure we get it sorted for the release. | 14:40 |
jokke | rosmaita: ++ | 14:40 |
jokke | if it's not trivial to filter the quota enforcement, let file a bug for it so we have tracker | 14:41 |
dansmith | well, not sure why before the release, | 14:41 |
rosmaita | right, and if dansmith casts it as a DoS issue, should be backportable | 14:41 |
dansmith | since the enforcement patch isn't changing the number of keys we're using | 14:41 |
dansmith | but obviously it's a good idea to figure it out | 14:42 |
dansmith | rosmaita: it's kindof a self-dos really, so not super impactful I think | 14:42 |
rosmaita | i agree | 14:42 |
dansmith | "user can prevent ... themselves from using resources" :P | 14:42 |
jokke | well it's yet another very crappy user experience thing ... although I have no idea if anyone is actually using the property quotas | 14:44 |
jokke | Anyways we need to have it fixed or well documented before we push release out | 14:45 |
rosmaita | i think the default is 128 | 14:45 |
rosmaita | so probably no one has run up against this | 14:45 |
jokke | and it's separate even without the enforcement as you can still shoot yourself into the foot as we are now | 14:45 |
jokke | rosmaita: yeah, haven't heard anyone asking about it yet | 14:46 |
jokke | moving on | 14:46 |
*** markmcclain has joined #openstack-meeting | 14:46 | |
jokke | #topic bug fest | 14:46 |
*** openstack changes topic to "bug fest (Meeting topic: glance)" | 14:46 | |
jokke | Just reminder, bug scrub Tuesday next week as it will be milestone+1 week | 14:47 |
jokke | #topic Open discussion | 14:47 |
*** openstack changes topic to "Open discussion (Meeting topic: glance)" | 14:47 | |
jokke | Anything else? | 14:48 |
dansmith | I have a hard stop in 13 minutes, | 14:48 |
dansmith | but would definitely like to talk about the distributed import stuff | 14:48 |
rajivmucheli | jokke did you get a chance to validate the version issue ? pbr commit ? | 14:48 |
rosmaita | jokke: left a comment on your ceph optimization spec | 14:48 |
rosmaita | dansmith: i am all ears | 14:48 |
dansmith | rosmaita: well, I'd mostly like to hear review comments :) | 14:49 |
rosmaita | oh | 14:50 |
jokke | rajivmucheli: still on my list to look. So all: just pointer what we're talking about. rajivmucheli is seeing glance-api reporting version 19.0.0 since Train. Not sure yet wether that is problem on our end or on their fork of the repo, but it's weird anyways | 14:50 |
*** TrevorV has joined #openstack-meeting | 14:50 | |
rajivmucheli | i see the glance_store upgraded but not glance-api version. | 14:51 |
jokke | rosmaita: thanks, just quick remark. I will need to double check that but IIUC that feature has been in RADOSLib for ages, we're just not using it | 14:52 |
rosmaita | cool | 14:52 |
jokke | rosmaita: as that's what cephclient is using | 14:52 |
jokke | for long time | 14:52 |
jokke | If there's nothing else, lets give dansmith 4min to stretch and rest of us can get back to work :D | 14:55 |
rosmaita | nothing from me | 14:56 |
jokke | kk, we can continue is #openstack-glance for anything else. Thanks All! | 14:56 |
jokke | #endmeeting | 14:57 |
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 14:57 | |
openstack | Meeting ended Thu Jan 21 14:57:02 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:57 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/glance/2021/glance.2021-01-21-14.09.html | 14:57 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/glance/2021/glance.2021-01-21-14.09.txt | 14:57 |
openstack | Log: http://eavesdrop.openstack.org/meetings/glance/2021/glance.2021-01-21-14.09.log.html | 14:57 |
gagehugo | #startmeeting security | 15:00 |
openstack | Meeting started Thu Jan 21 15:00:26 2021 UTC and is due to finish in 60 minutes. The chair is gagehugo. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
*** openstack changes topic to " (Meeting topic: security)" | 15:00 | |
openstack | The meeting name has been set to 'security' | 15:00 |
gagehugo | #link https://etherpad.opendev.org/p/security-agenda agenda | 15:00 |
fungi | ahoy | 15:01 |
gagehugo | o/ | 15:01 |
*** rosmaita has left #openstack-meeting | 15:02 | |
redrobot | \o | 15:05 |
gagehugo | Nothing on the agenda today | 15:06 |
gagehugo | #topic open discussion | 15:06 |
*** openstack changes topic to "open discussion (Meeting topic: security)" | 15:06 | |
gagehugo | Anyone have anything? | 15:06 |
fungi | #link https://bugs.launchpad.net/ossa Public reports of suspected vulnerabilities in need of review | 15:08 |
fungi | i think there are 29 at the moment (if you're logged in as a vulnerability manager you may see a higher number) | 15:08 |
fungi | revisiting private reports, it seems we have one where the embargo has expired too, i'll open it up now | 15:10 |
fungi | #link https://launchpad.net/bugs/1892848 XSS in adding JavaScript into the ‘Subnet Name’ field | 15:11 |
openstack | Launchpad bug 1892848 in OpenStack Security Advisory "XSS in adding JavaScript into the ‘Subnet Name’ field" [Undecided,Incomplete] | 15:11 |
fungi | so that brings the total up to 30 which would be nice to get some folks to weigh in on | 15:12 |
fungi | i should revisit my earlier idea to sort them by project and send a list to th eopenstack-discuss ml | 15:13 |
redrobot | I'll try to make some time to review some of those. Not sure how useful I'll be though. 😅 | 15:13 |
*** rajivmucheli has quit IRC | 15:14 | |
gagehugo | thanks fungi, anyone else have anything? | 15:18 |
*** cmart has quit IRC | 15:19 | |
fungi | that was all i had for this week. i'll try to send something to the ml, but infra fires have dominated my available time recently | 15:19 |
*** irclogbot_3 has quit IRC | 15:21 | |
gagehugo | yeah, coming back from vacation has consumed most of my time lately | 15:22 |
gagehugo | thanks fungi, redrobot! Have a good rest of the week! | 15:22 |
*** irclogbot_3 has joined #openstack-meeting | 15:22 | |
gagehugo | #endmeeting | 15:22 |
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 15:22 | |
openstack | Meeting ended Thu Jan 21 15:22:43 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:22 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/security/2021/security.2021-01-21-15.00.html | 15:22 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/security/2021/security.2021-01-21-15.00.txt | 15:22 |
openstack | Log: http://eavesdrop.openstack.org/meetings/security/2021/security.2021-01-21-15.00.log.html | 15:22 |
fungi | thanks gagehugo! | 15:22 |
*** armax has joined #openstack-meeting | 15:25 | |
*** cmart has joined #openstack-meeting | 15:27 | |
*** rh-jelabarre has quit IRC | 15:27 | |
*** rh-jelabarre has joined #openstack-meeting | 15:31 | |
*** lpetrut_ has quit IRC | 15:42 | |
*** armax has quit IRC | 15:48 | |
*** jmasud has joined #openstack-meeting | 15:51 | |
*** psahoo_ has quit IRC | 15:51 | |
*** mlavalle has joined #openstack-meeting | 15:51 | |
*** yasufum has quit IRC | 15:54 | |
*** macz_ has joined #openstack-meeting | 15:59 | |
*** macz_ has quit IRC | 15:59 | |
*** macz_ has joined #openstack-meeting | 16:00 | |
*** armax has joined #openstack-meeting | 16:06 | |
*** dklyle has joined #openstack-meeting | 16:08 | |
*** e0ne has joined #openstack-meeting | 16:29 | |
*** gyee has joined #openstack-meeting | 16:32 | |
*** lpetrut has joined #openstack-meeting | 16:42 | |
*** ociuhandu_ has joined #openstack-meeting | 16:49 | |
*** lpetrut has quit IRC | 16:50 | |
*** armstrong has joined #openstack-meeting | 16:51 | |
*** jamesmcarthur has joined #openstack-meeting | 16:51 | |
*** armax has quit IRC | 16:52 | |
*** ociuhandu has quit IRC | 16:53 | |
*** ociuhandu_ has quit IRC | 16:54 | |
*** njohnston is now known as njohnston|lunch | 17:01 | |
*** lpetrut has joined #openstack-meeting | 17:40 | |
*** diablo_rojo has quit IRC | 17:41 | |
*** rpittau is now known as rpittau|afk | 17:42 | |
*** ralonsoh has quit IRC | 17:52 | |
*** rcernin has joined #openstack-meeting | 17:54 | |
*** lpetrut has quit IRC | 17:55 | |
*** rcernin has quit IRC | 17:59 | |
gmann | #startmeeting policy_popup | 18:02 |
openstack | Meeting started Thu Jan 21 18:02:33 2021 UTC and is due to finish in 60 minutes. The chair is gmann. Information about MeetBot at http://wiki.debian.org/MeetBot. | 18:02 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 18:02 |
*** openstack changes topic to " (Meeting topic: policy_popup)" | 18:02 | |
openstack | The meeting name has been set to 'policy_popup' | 18:02 |
lbragstad | o/ | 18:02 |
gmann | seems two of us, let's quickly discuss the things | 18:04 |
gmann | #link https://etherpad.opendev.org/p/default-policy-meeting-agenda | 18:04 |
gmann | today agenda | 18:04 |
gmann | we had few action item from previous meeting | 18:04 |
gmann | gmann to check with abhishekk on glance point in meeting agenda | 18:05 |
gmann | I am not sure i did it so continuing this | 18:05 |
gmann | #action gmann to check with abhishekk on glance point in meeting agenda | 18:05 |
gmann | gmann to push common persona on oslo policy and release 3.6.1 and lbragstad to review that | 18:05 |
gmann | lbragstad: i think you pushed this | 18:05 |
lbragstad | we had a little debate on that in review | 18:05 |
lbragstad | yeah - and we weren't quite sure what to do with scope_types | 18:06 |
gmann | #link https://review.opendev.org/c/openstack/oslo.policy/+/766536 | 18:06 |
lbragstad | for example, if we set scope_types on personas in oslo.policy, do we expect projects to override them in the actual implementation? | 18:07 |
lbragstad | that wasn't really clear and we weren't sure what the best approach was | 18:07 |
lbragstad | so it fizzled out | 18:07 |
gmann | yeah having system_scope:all in check_str and not scope_type seems little conflicting | 18:08 |
lbragstad | and i can see how that causes confusion | 18:08 |
lbragstad | i don't really care for duplicated check string in each service, but i think i'd rather have that than push something through without thinking about how best to handle it | 18:09 |
gmann | and we can leave scope_type for service side rule to take care of? | 18:09 |
gmann | like done in nova | 18:10 |
lbragstad | we could - but we need to ensure nested DocumentedDefaultRules work as expected with scope checking | 18:10 |
gmann | i see your point. i think it work fine as in nova | 18:11 |
gmann | but we can add test in oslo.policy side too | 18:11 |
lbragstad | i don't think i've seen a case where we nest them | 18:11 |
gmann | ah you mean keeping in both? | 18:12 |
gmann | common rule as well as in specific rule too | 18:12 |
lbragstad | well - a lot of the services will use the composite rules in their services specific policies, right? | 18:12 |
lbragstad | with check_str=rule:system_admin -> which is ultimately imported as a DocumentedRuleDefault instance from oslo.policy | 18:13 |
gmann | but is common rule going to be registered as registered rule in oslo policy? | 18:13 |
gmann | because oslo policy only checks scope type from register rules https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L1026 | 18:14 |
gmann | anyways i was thinking to remove the scope_type from common rules and let service side to define that in their policy | 18:14 |
lbragstad | correct - but the additional recommendation was to use DocumentedDefaultRule for each common persona (check string) so that the definitions for system-admin, system-reader, etc... are all consistent | 18:14 |
lbragstad | across the implementations in services | 18:15 |
gmann | otherwise it is confusing in both way 1. if not checked in oslo policy or 2. checked and erorr | 18:15 |
gmann | yeah DocumentedRuleDefault rule does not force scope_type | 18:16 |
gmann | https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L1256 | 18:16 |
lbragstad | right | 18:16 |
lbragstad | it's optional | 18:16 |
lbragstad | because it landed in oslo.policy prior to the scope work in keystone and related libraries | 18:16 |
gmann | but we cannot make it mandatory until we remove the old/existing policy completely | 18:17 |
lbragstad | so - the approach i proposed was to implement the common persona check strings as instances of DocumentedRuleDefault because we thought it would be nice to have the same definition/help text for each common personas | 18:17 |
gmann | that time we can pass some special case for common rules and ignore those in actrual checking ? | 18:17 |
gmann | +1 fo that | 18:18 |
gmann | for | 18:18 |
lbragstad | otherwise - we could just do something SYSTEM_ADMIN = 'role:admin and system_scope:all' | 18:18 |
lbragstad | if the common bits are just strings, then we shouldn't have any problems putting them in oslo.policy as constants | 18:18 |
lbragstad | otherwise - it was going to be SYSTEM_ADMIN = policy.DocumentedRuleDefault(name='rule:system_admin', check_str='role:admin and system_scope:all') | 18:19 |
lbragstad | and the second case was causing some confusion | 18:19 |
gmann | other problem with having it DocumentedRuleDefault is about deprecation https://review.opendev.org/c/openstack/oslo.policy/+/766536/1/oslo_policy/personas.py#97 | 18:20 |
lbragstad | right | 18:20 |
gmann | and for that services need to define other common rule there side even we make oslo policy common as constant or DocumentedRuleDefault | 18:20 |
gmann | or we can provide set method on DocumentedRuleDefault to set the deprecated rule info | 18:21 |
lbragstad | ok - so are we saying we should or shouldn't move forward with the common personas as DocumentedRuleDefaults in oslo.policy? | 18:23 |
gmann | humm, i would like to have in DocumentedRuleDefaults but from current challenges it seems difficult and going with constant seems easy | 18:25 |
gmann | at least it can be helpful when we remove the 'system:all' special string | 18:25 |
lbragstad | i need more time to think about it and the ramifications of how it's going to work and test it | 18:26 |
gmann | ok, | 18:26 |
gmann | I will also try to consume it on nova side and see how it work/look | 18:26 |
gmann | #action lbragstad to continue on common persona on oslo policy | 18:26 |
lbragstad | for the most part, i've proposed audits for each api and almost all the new check strings are consistent (even if they are duplicated) | 18:26 |
gmann | ok. | 18:27 |
gmann | one more challenge i see in common persona is how to change them 'remove system:all' all together for all projects or one by one. | 18:28 |
gmann | but need to think more on this | 18:28 |
lbragstad | ++ | 18:28 |
gmann | anyways let's continue brainstorming on this. | 18:28 |
gmann | next Action item is | 18:29 |
gmann | lbragstad to finish placement as first | 18:29 |
gmann | I started review the placement patches and I think i should be able to do tomorrow | 18:29 |
lbragstad | #link https://review.opendev.org/q/topic:%2522secure-rbac%2522+(status:open+OR+status:merged)+project:openstack/placement | 18:29 |
gmann | stephen is already +2 on most of them i think | 18:29 |
lbragstad | so - i think placement is pretty much done | 18:29 |
gmann | cool, thanks for that. | 18:29 |
lbragstad | i'm working on cinder and ironic now - and we're trying to work through testing strategies with ddt | 18:30 |
gmann | ok | 18:30 |
lbragstad | ironic has a pretty good start | 18:30 |
gmann | with unit tests? | 18:30 |
lbragstad | they're testing everything that's supported by the legacy RBAC approach | 18:30 |
lbragstad | they're using functional API tests with ddt | 18:30 |
gmann | oh they do not use policy fixture? | 18:30 |
gmann | i mean testing on actual default policy? | 18:31 |
lbragstad | yeah - they're testing all the default policies that exist today without any of the secure rbac changes | 18:31 |
gmann | great | 18:31 |
lbragstad | so - they want protection testing for project-admin and project-member use cases | 18:31 |
lbragstad | as a starting point | 18:32 |
gmann | i see. | 18:32 |
lbragstad | and then as they implement the various personas, they're going to add new tests for the additional personas | 18:32 |
lbragstad | (each class will inherit a different setup that sets the oslo-policy config options that opt them into the new world of enforcement) | 18:32 |
gmann | +1, that is nice. | 18:32 |
lbragstad | i'm attempting to do the same thing with cinder right now | 18:33 |
*** e0ne has quit IRC | 18:33 | |
gmann | but there you have to write all these new tests like done in nova | 18:33 |
lbragstad | i'm not sure how far i'm going to get in two weeks - but i'd like to have enough of a start for others to start jumping in | 18:33 |
gmann | I can take care of glance after checking with glance team which is fist AI | 18:34 |
gmann | my JSON->YAML work is almost done, need to debug some failure thoguh | 18:34 |
lbragstad | ++ | 18:35 |
lbragstad | sounds good | 18:35 |
gmann | let's move next | 18:35 |
gmann | last action item is raildo to update https://review.opendev.org/#/c/743318/ | 18:35 |
gmann | he updated that seems. | 18:36 |
gmann | I think we also covered the agenda topics also as part of action item. | 18:36 |
gmann | lbragstad: anything else you have to discuss? | 18:36 |
gmann | have/want | 18:36 |
lbragstad | i posted this to the openstack-discuss mailing list | 18:37 |
lbragstad | http://lists.openstack.org/pipermail/openstack-discuss/2021-January/019916.html | 18:37 |
raildo | gmann, yo, yeah, I have updated the docs suggestions, but I believe that would be nice to create some spec for the "visibility" function discussed on the previous patch set | 18:37 |
gmann | ah i see | 18:37 |
lbragstad | just clarifying some points that have been brought regarding and important distinction between reader and auditor usecases | 18:37 |
lbragstad | an important* | 18:37 |
raildo | #link https://review.opendev.org/c/openstack/glance/+/742810/3/doc/source/admin/interoperable-image-import.rst | 18:37 |
gmann | lbragstad: +1, that was really nice info. should we add that in some doc in keystone side or so? | 18:38 |
lbragstad | already done | 18:39 |
lbragstad | #link https://review.opendev.org/c/openstack/keystone/+/771509 | 18:39 |
gmann | raildo: yeah, that case we can cover. | 18:39 |
gmann | lbragstad: ah nice :) thanks | 18:39 |
lbragstad | if you want to review it | 18:40 |
gmann | yeah sure, I will check. | 18:40 |
gmann | so raildo point for 'visibility' is in many places in neutron side i think | 18:40 |
lbragstad | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_527/771509/1/check/openstack-tox-docs/5276478/docs/admin/service-api-protection.html#reader | 18:40 |
raildo | yeah, it might want to discuss about this on the next PTG-ish? | 18:40 |
gmann | raildo: ok and merge the current version of 743318/ for now or you want to hold it? | 18:42 |
*** jamesdenton has quit IRC | 18:43 | |
raildo | gmann, I would that we can merge it, I already adding a note saying that we'll discuss the visibility in a future | 18:43 |
raildo | I would say* | 18:43 |
*** jamesdenton has joined #openstack-meeting | 18:43 | |
gmann | +1 from me. | 18:44 |
gmann | I will review the latest version. | 18:44 |
gmann | thanks | 18:44 |
gmann | anything else to discuss? | 18:44 |
lbragstad | i'm good | 18:44 |
raildo | nope | 18:45 |
gmann | thanks lbragstad raildo . | 18:45 |
lbragstad | thanks gmann | 18:45 |
gmann | #endmeeting | 18:45 |
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 18:45 | |
openstack | Meeting ended Thu Jan 21 18:45:23 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 18:45 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/policy_popup/2021/policy_popup.2021-01-21-18.02.html | 18:45 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/policy_popup/2021/policy_popup.2021-01-21-18.02.txt | 18:45 |
openstack | Log: http://eavesdrop.openstack.org/meetings/policy_popup/2021/policy_popup.2021-01-21-18.02.log.html | 18:45 |
*** _mlavalle_1 has joined #openstack-meeting | 18:59 | |
*** njohnston|lunch is now known as njohnston | 19:02 | |
*** mlavalle has quit IRC | 19:03 | |
*** haleyb has quit IRC | 19:27 | |
*** dougwig has quit IRC | 19:27 | |
*** dougwig has joined #openstack-meeting | 19:28 | |
*** haleyb has joined #openstack-meeting | 19:28 | |
*** jamesmcarthur has quit IRC | 19:52 | |
*** slaweq has quit IRC | 19:55 | |
*** jamesmcarthur has joined #openstack-meeting | 20:03 | |
*** jamesdenton has quit IRC | 20:06 | |
*** jamesdenton has joined #openstack-meeting | 20:06 | |
*** irclogbot_3 has quit IRC | 20:14 | |
*** tosky has quit IRC | 20:14 | |
*** tosky has joined #openstack-meeting | 20:15 | |
*** irclogbot_0 has joined #openstack-meeting | 20:16 | |
*** jmasud has quit IRC | 20:34 | |
*** jmasud has joined #openstack-meeting | 20:44 | |
*** TrevorV has quit IRC | 21:12 | |
*** raildo has quit IRC | 21:41 | |
*** manpreet has quit IRC | 21:43 | |
*** jamesmcarthur_ has joined #openstack-meeting | 21:45 | |
*** jamesmcarthur has quit IRC | 21:49 | |
*** rcernin has joined #openstack-meeting | 21:54 | |
*** rcernin has quit IRC | 21:59 | |
*** jamesmcarthur has joined #openstack-meeting | 22:02 | |
*** jamesmcarthur_ has quit IRC | 22:05 | |
*** jmasud has quit IRC | 22:10 | |
*** jmasud has joined #openstack-meeting | 22:12 | |
*** rcernin has joined #openstack-meeting | 22:38 | |
*** jamesmcarthur_ has joined #openstack-meeting | 22:51 | |
*** jamesmcarthur has quit IRC | 22:55 | |
*** rcernin has quit IRC | 22:56 | |
*** rcernin has joined #openstack-meeting | 22:57 | |
*** armstrong has quit IRC | 23:01 | |
*** jamesmcarthur has joined #openstack-meeting | 23:02 | |
*** yamamoto has quit IRC | 23:04 | |
*** yamamoto has joined #openstack-meeting | 23:04 | |
*** jamesmcarthur_ has quit IRC | 23:05 | |
*** jamesmcarthur has quit IRC | 23:12 | |
*** jamesmcarthur has joined #openstack-meeting | 23:16 | |
*** jamesmcarthur has quit IRC | 23:16 | |
*** jamesmcarthur has joined #openstack-meeting | 23:16 | |
*** jmasud has quit IRC | 23:19 | |
*** jmasud has joined #openstack-meeting | 23:22 | |
*** ociuhandu has joined #openstack-meeting | 23:24 | |
*** ociuhandu has quit IRC | 23:29 | |
*** jamesmcarthur has quit IRC | 23:55 | |
*** jamesmcarthur has joined #openstack-meeting | 23:59 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!