| *** soniya29|ruck is now known as soniya29|ruck|lunch | 07:13 | |
| *** soniya29|ruck|lunch is now known as soniya29|ruck | 08:11 | |
| abhishekk | #startmeeting glance | 14:00 |
|---|---|---|
| opendevmeet | Meeting started Thu Nov 18 14:00:02 2021 UTC and is due to finish in 60 minutes. The chair is abhishekk. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'glance' | 14:00 |
| abhishekk | #topic roll call | 14:00 |
| abhishekk | #link https://etherpad.openstack.org/p/glance-team-meeting-agenda | 14:00 |
| abhishekk | o/ | 14:00 |
| abhishekk | waiting for others to join | 14:00 |
| pdeore | o/ | 14:02 |
| abhishekk | lets wait couple of minutes more | 14:02 |
| rosmaita | o/ | 14:02 |
| abhishekk | Ok, lets start, others may/can join in between | 14:04 |
| abhishekk | #topic Announcement | 14:04 |
| abhishekk | OpenInfra summit is back | 14:04 |
| rosmaita | do you know whether the PTG will be there, too? | 14:04 |
| abhishekk | So in person OpenInfra events are back | 14:04 |
| abhishekk | at the moment there is only summit | 14:05 |
| rosmaita | ok | 14:05 |
| abhishekk | I think PTG is still under discussion | 14:05 |
| abhishekk | For early registration you can use, https://openinfra.dev/summit/ | 14:05 |
| abhishekk | It is between 7 to 9 June and in Berlin | 14:05 |
| abhishekk | Hopefully we will be able to meet in person this time | 14:06 |
| jokke_ | fingers crossed | 14:06 |
| abhishekk | ++ | 14:06 |
| abhishekk | Moving ahead | 14:06 |
| abhishekk | #topic release/periodic jobs update | 14:06 |
| abhishekk | This is milestone 1 release week | 14:06 |
| abhishekk | and we are not releasing anything this time | 14:07 |
| abhishekk | So we are good \o/ | 14:07 |
| jokke_ | :P | 14:07 |
| jokke_ | I guess our m1 targets didn't make it ;) | 14:07 |
| abhishekk | :D | 14:07 |
| abhishekk | AND periodic jobs all are green as well | 14:07 |
| jokke_ | uuh | 14:08 |
| jokke_ | that's cool | 14:08 |
| abhishekk | I saw couple of timeouts on glance patches this week, but that is due to heavy queue in the gate | 14:08 |
| abhishekk | Moving to next topic | 14:08 |
| abhishekk | #topic Catching up with reviews and specs | 14:08 |
| abhishekk | We have couple of specs up for reviews | 14:09 |
| abhishekk | So requesting all of you to kindly provide your feedback on them | 14:09 |
| abhishekk | AFAIK, Quota usage API, metadef tag append and resource type modification specs are up | 14:09 |
| abhishekk | Please put some time in reviewing them | 14:10 |
| abhishekk | moving ahead | 14:10 |
| Mitya_Eremeev | sorry | 14:10 |
| Mitya_Eremeev | Could you disscuss my patch ? | 14:10 |
| abhishekk | Mitya_Eremeev, your topic is next so we can discuss it at that time | 14:11 |
| Mitya_Eremeev | sorry))) | 14:11 |
| abhishekk | no problem | 14:11 |
| abhishekk | #topic Secure RBAC - Impact, what's next? | 14:11 |
| abhishekk | lbragstad, if you are around, can you put some light on current Yoga goal for RBAC | 14:12 |
| abhishekk | Does addition of project-manager role has any impact for glance project personas | 14:13 |
| rosmaita | i thought project-manager was a stretch goal for Yoga? | 14:13 |
| abhishekk | yeah, I think so as well | 14:14 |
| rosmaita | here's the proposal: https://review.opendev.org/c/openstack/governance/+/815158 | 14:14 |
| rosmaita | i haven't read the latest version, but looks like dansmith has | 14:14 |
| abhishekk | right, and it has two specific targets | 14:15 |
| abhishekk | 1 is implementation of project-manager role | 14:15 |
| abhishekk | 2 openstack client compatibility | 14:15 |
| lbragstad | o/ | 14:15 |
| lbragstad | i'm catching up on that today | 14:15 |
| abhishekk | cool, here he is | 14:15 |
| lbragstad | and addressing feedback | 14:15 |
| lbragstad | but the biggest change from previous versions is that, | 14:16 |
| abhishekk | lbragstad, ack, I think we can sync some time early next week (if you have time) | 14:16 |
| lbragstad | project-admin will remain an operator specific persona | 14:16 |
| abhishekk | ok | 14:18 |
| abhishekk | when is next RBAC open office hours meeting? | 14:18 |
| lbragstad | the system personas are truly reserved for system-specific APIs (which I don't think glance has?) | 14:18 |
| * lbragstad checks | 14:18 | |
| abhishekk | right | 14:19 |
| lbragstad | the TC is discussing the goal today | 14:19 |
| lbragstad | in about 3 hours | 14:19 |
| abhishekk | Ok, I will try to be there to clear some doubts | 14:19 |
| abhishekk | thank you | 14:19 |
| lbragstad | in 2.5 hours | 14:19 |
| lbragstad | actually | 14:19 |
| abhishekk | and also if you have some time, we can sync as per your availability as well | 14:20 |
| lbragstad | ++ sounds good | 14:20 |
| abhishekk | next week * | 14:20 |
| abhishekk | thank you, please let me know | 14:20 |
| lbragstad | i'll be around all day monday - wednesday | 14:20 |
| lbragstad | so - i can make any time work | 14:20 |
| abhishekk | Great, I will ping you on monday then | 14:20 |
| abhishekk | moving ahead | 14:21 |
| abhishekk | #topic Discussion of spec lite | 14:21 |
| abhishekk | Add ability to purge all needed rows by glance-manage script | 14:21 |
| abhishekk | Mitya_Eremeev, stage is yours | 14:21 |
| abhishekk | just to put some light | 14:22 |
| Mitya_Eremeev | thanks | 14:22 |
| abhishekk | Mitya_Eremeev, reported a bug for the same, and as it is enhancement I have asked him for spec lite | 14:22 |
| abhishekk | #link https://review.opendev.org/c/openstack/glance-specs/+/817938 | 14:22 |
| Mitya_Eremeev | https://review.opendev.org/c/openstack/glance/+/813691 | 14:22 |
| abhishekk | I do think we can have one option max-rows for glance db purge operation | 14:23 |
| abhishekk | Mitya_Eremeev, have you tried that ? | 14:23 |
| Mitya_Eremeev | max-rows have nothing in common with number of all deleted rows | 14:23 |
| Mitya_Eremeev | it's just some limitation how many rows will be deleted by script | 14:24 |
| abhishekk | ok | 14:24 |
| abhishekk | so you just want to delete/purge all rows in one command | 14:25 |
| Mitya_Eremeev | so no guarantess that all deleted rows will be purged | 14:25 |
| Mitya_Eremeev | Yes, I think user should have ability to purge in one pass | 14:25 |
| jokke_ | So currently we're checking that max-rows is at least one. We could be consisten and use -1 there | 14:26 |
| abhishekk | ack, so we have a spec lite up for the same, please review it and give some early feedback to Mitya_Eremeev | 14:26 |
| Mitya_Eremeev | otherwise user wil do some monkey job just by launching script many times until script deleted all | 14:26 |
| abhishekk | so -1 means delete all ? | 14:26 |
| Mitya_Eremeev | no | 14:26 |
| jokke_ | abhishekk: that's how our other limits works | 14:27 |
| abhishekk | Mitya_Eremeev, he is giving suggestion | 14:27 |
| jokke_ | so yeah, --max-rows -1 and --age-in-days 0 would equal to purge all | 14:27 |
| Mitya_Eremeev | if pass key --purhe_all then --max row is just number of rows in one step | 14:28 |
| jokke_ | no need for an extra parameter for that nor breaking anyone | 14:28 |
| Mitya_Eremeev | I don't think that max-rows allows negative values | 14:28 |
| jokke_ | Mitya_Eremeev: that's what I'm saying .... don't add the extra --purhe-all, but allow -1 as --max-rows | 14:29 |
| Mitya_Eremeev | understood | 14:29 |
| abhishekk | Mitya_Eremeev, we can modify it to allow | 14:29 |
| Mitya_Eremeev | but we should not do that | 14:29 |
| abhishekk | jokke_, please add this suggestion on the speclite | 14:29 |
| jokke_ | simple way to indicate that we don't want to patch it ... if we're looping anyways doing it in patches is just tons of extra queries into the db that are not needed | 14:30 |
| jokke_ | abhishekk: sure | 14:30 |
| abhishekk | any specific reason for not doing it Mitya_Eremeev | 14:30 |
| Mitya_Eremeev | sometimes db can be very huge and sometimes it's better to divide deleting in steps | 14:30 |
| dansmith | in nova we have a date-based filter as well, so you can say "older than last month" | 14:31 |
| Mitya_Eremeev | so max-rows helps regarding performance | 14:31 |
| abhishekk | dansmith, I think similar we have age-in-days option | 14:31 |
| dansmith | okay cool, I'm not sure why anyone would use max-rows if they have an age-based option | 14:32 |
| jokke_ | dansmith: well we for some reason default that to 100 rows | 14:32 |
| Mitya_Eremeev | max-rows is just for db performance | 14:32 |
| dansmith | jokke_: oh max-rows counts against an age-based purge as well? | 14:32 |
| Mitya_Eremeev | yes | 14:33 |
| dansmith | yeah, that seems weird to me | 14:33 |
| jokke_ | dansmith: yeah yeah ... by default it does only 100 rows and you loop it as needed or give it sufficient value | 14:33 |
| jokke_ | makes no sense | 14:33 |
| dansmith | maybe loop and do $max_rows at a time until there are no more that satisfy the age query? | 14:33 |
| dansmith | I mean, make the tool do that for them | 14:33 |
| abhishekk | I think if age-in-days is mentioned then it should ignore max-rows | 14:33 |
| jokke_ | as it just introduces more load for db to loop the data and identify those rows | 14:33 |
| abhishekk | I think its time to revisit glance-manage utility tool and do some enhancements there as well | 14:34 |
| dansmith | abhishekk: well, depends on how the loop works - but max-rows may be desirable to avoid loading a billion things into memory just to delete them, | 14:35 |
| dansmith | but the user should expect it to behave sanely, regardless of internal batching, IMHO | 14:35 |
| jokke_ | abhishekk: they both have default values | 14:35 |
| jokke_ | dansmith: but that should be handled in the db_api side, rather than from the command client | 14:36 |
| abhishekk | hmm, I need to recheck how it works, we never looked back once we added purge image table separately | 14:36 |
| jokke_ | batching I mean | 14:36 |
| jokke_ | if needed | 14:36 |
| dansmith | jokke_: as long as it's not handled by the user in the shell, I agree :) | 14:36 |
| abhishekk | :D | 14:36 |
| jokke_ | but any case the 100 line limit is ridiculous | 14:37 |
| abhishekk | We can continue this discussion on spec lite | 14:37 |
| jokke_ | mhm | 14:37 |
| abhishekk | and if required we can change it to spec where we can target all the improvements at once | 14:37 |
| abhishekk | Mitya_Eremeev, thank you for bringing this up | 14:37 |
| Mitya_Eremeev | Thank you all ! | 14:38 |
| abhishekk | moving ahead | 14:38 |
| abhishekk | #topic in-flight encryption without Barbican Consumer API | 14:38 |
| abhishekk | rosmaita, this is you | 14:38 |
| rosmaita | yeah, my -1 on that may be preventing people from looking at it | 14:39 |
| abhishekk | I think I have added in PTG etherpad some feedback but forget to add it to spec before going on Vacation | 14:39 |
| rosmaita | -1 because it's not targeted for yoga | 14:39 |
| abhishekk | will again have a look after the meeting or early tomorrow | 14:40 |
| rosmaita | but i was wondering if dansmith and jokke_ still have reservations about doing this without the secret consumer API? | 14:40 |
| abhishekk | Only reservation is whether we should allow commented code as place holder or we should have dependent patch instead of having commented code in code base | 14:40 |
| dansmith | -1 on commented code, but I'm not up to date on the current state | 14:41 |
| rosmaita | i agree with dansmith on that | 14:41 |
| abhishekk | Yeah, its better to have dependent patch | 14:42 |
| rosmaita | what is it going to depend on? | 14:42 |
| jokke_ | rosmaita: as actual stable feature yes, I've been promoting doing this as experimental so the development work can move on while waiting for the consumer api for over cycle now ;) | 14:42 |
| rosmaita | ok, my only interest is that i want them to get this thing to the state where they can run end-to-end CI tests | 14:43 |
| jokke_ | rosmaita: the non-exiting release patch of barbican to release the consumer api ;) | 14:43 |
| abhishekk | https://review.opendev.org/c/openstack/glance/+/705445/4/glance/api/v2/images.py | 14:43 |
| rosmaita | because there are a bunch of edge cases that will have to be dealt with, i suspect | 14:43 |
| abhishekk | rosmaita, we can move commented code from this patch to a separate patch | 14:43 |
| rosmaita | i wonder about that patch | 14:44 |
| rosmaita | the comment i mean | 14:44 |
| rosmaita | i thought castellan was a backend-neutral library | 14:44 |
| rosmaita | so unlikely to have support for this thing | 14:44 |
| rosmaita | it doesn't even support naming a secret (unless the version i use is way out of date) | 14:45 |
| rosmaita | that's a separate issue, i guess | 14:45 |
| abhishekk | right | 14:46 |
| abhishekk | is encryption weekly meeting still going on? | 14:46 |
| rosmaita | yes, though i keep missing it because i am stupid about the time change | 14:46 |
| rosmaita | mondays at 1300 UTC, i think | 14:47 |
| abhishekk | let me know the timing I will join it (next time) | 14:47 |
| abhishekk | I think it is on Monday | 14:47 |
| abhishekk | Ok, will try to be there this time | 14:47 |
| rosmaita | yes, 1300 utc in #openstack-meeting | 14:47 |
| abhishekk | moving ahead | 14:47 |
| rosmaita | thanks! | 14:48 |
| abhishekk | cool, thank you | 14:48 |
| abhishekk | #topic Open discussion | 14:48 |
| abhishekk | I need to revisit PTG discussions to start up pending works | 14:48 |
| abhishekk | I guess Cache API is one of them | 14:48 |
| abhishekk | So in next meeting we will have some targets for Milestone 2 | 14:49 |
| abhishekk | that's it from me | 14:49 |
| abhishekk | Kindly put some time in spec reviews | 14:49 |
| abhishekk | anything else ? | 14:51 |
| jokke_ | not from me | 14:52 |
| rosmaita | not me | 14:53 |
| dansmith | nay | 14:53 |
| abhishekk | cool, lets wrap up for the day | 14:54 |
| abhishekk | thank you all | 14:54 |
| abhishekk | have a great week ahead | 14:54 |
| jokke_ | thanks | 14:55 |
| abhishekk | #endmeeting | 14:55 |
| opendevmeet | Meeting ended Thu Nov 18 14:55:23 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:55 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/glance/2021/glance.2021-11-18-14.00.html | 14:55 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/glance/2021/glance.2021-11-18-14.00.txt | 14:55 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/glance/2021/glance.2021-11-18-14.00.log.html | 14:55 |
| dansmith | if anyone is here for the policy meeting, we're in meetpad | 18:05 |
| lbragstad | just a heads up the secure-rbac meeting is in https://meetpad.opendev.org/secure-rbac | 18:05 |
| dansmith | https://meetpad.opendev.org/secure-rbac | 18:05 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!