*** soniya29 is now known as soniya29|ruck | 10:06 | |
*** dasm|ruck|afk is now known as dasm|ruck | 13:53 | |
abhishekk | #startmeeting glance | 14:00 |
---|---|---|
opendevmeet | Meeting started Thu Jun 9 14:00:36 2022 UTC and is due to finish in 60 minutes. The chair is abhishekk. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
opendevmeet | The meeting name has been set to 'glance' | 14:00 |
abhishekk | #topic roll call | 14:00 |
abhishekk | #link https://etherpad.openstack.org/p/glance-team-meeting-agenda | 14:00 |
abhishekk | o/ | 14:00 |
abhishekk | rosmaita and dansmith will not be around | 14:00 |
abhishekk | so does pdeore | 14:01 |
jokke_ | o/ | 14:01 |
mrjoshi | o/ | 14:01 |
alistarle | o/ | 14:01 |
pslestang | o/ | 14:01 |
abhishekk | ok we do have enough people,lets start | 14:01 |
croelandt | o/ | 14:01 |
abhishekk | #topic Updates | 14:01 |
abhishekk | This is Summit week and we don't have glance specific updates | 14:01 |
abhishekk | unfortunately no one from glance is at summit for project update this time | 14:02 |
abhishekk | hopefully someone will be there next time | 14:02 |
abhishekk | #topic release/periodic jobs update | 14:02 |
abhishekk | Milestone 2 is 1 month away from now, which is also a spec freeze for us | 14:02 |
abhishekk | Once M2 is over we will not accept any spec | 14:03 |
abhishekk | At this moment 3 specs are open out of 1 is on hold | 14:03 |
abhishekk | we will visit those specs in next topic | 14:03 |
abhishekk | Periodic Jobs, all green except the 'translation update' jobs failure due to some python version dependency conflicts | 14:03 |
abhishekk | everything else is green | 14:04 |
abhishekk | moving to next topic | 14:04 |
abhishekk | #topic Specs for review | 14:04 |
abhishekk | Update proposal for duplicate image download | 14:04 |
abhishekk | #link https://review.opendev.org/c/openstack/glance-specs/+/734683 | 14:04 |
abhishekk | mrjoshi, please ping Brian for his review | 14:04 |
abhishekk | location APIs spec | 14:05 |
abhishekk | #link https://review.opendev.org/c/openstack/glance-specs/+/840882 | 14:05 |
abhishekk | I think this is in good shape and once jokke_ gives green signal we can move forward on this | 14:05 |
abhishekk | croelandt, please have a look at above two specs when you get some time | 14:06 |
abhishekk | Spec for SRBAC system admin persona support in glance | 14:06 |
abhishekk | #link https://review.opendev.org/c/openstack/glance-specs/+/844289 | 14:06 |
croelandt | ok | 14:06 |
abhishekk | This is on hold until the summit discussion and operator feedback on Scope concepts | 14:06 |
jokke_ | Like said in my previous comment, I'm starting to like the direction this is going implementing just the parts we know we need for the usecases and not trying to replicate the already failed API just with different endpoints | 14:06 |
abhishekk | afaik, we don't need to worry about system-scope this cycel | 14:06 |
abhishekk | yep, I am following the discussions on the spec and with the direction it is going I think soon we will be get green signal on this | 14:08 |
jokke_ | I think the Location API thingie could be useful. Now RBAC in place it might change the story yet again, which is quite worrysome atm | 14:08 |
abhishekk | New version is up as well for the same | 14:08 |
jokke_ | ok, I'll see what's in the latest rev after the meeting | 14:08 |
abhishekk | RBAC is on hold as it has some blockers atm | 14:09 |
abhishekk | ack | 14:09 |
abhishekk | lets move forward | 14:09 |
abhishekk | #topic Removed dead code of auth and policy layers | 14:09 |
abhishekk | pdeore has pushed a patch to remove dead code, I have been reviewing it and looks in good shape | 14:09 |
abhishekk | #link https://review.opendev.org/c/openstack/glance/+/845114 | 14:10 |
abhishekk | This patch is removing 3400 odd lines of code | 14:10 |
jokke_ | abhishekk: yes and if you read the ML post about RBAC recently, I think for Images API v2 ever being usable, the scrapping of System/Project scope boundary would be very necessary | 14:10 |
jokke_ | Way to go Pranali!!!! | 14:10 |
jokke_ | \\o \o/ o// o/7 | 14:11 |
abhishekk | jokke_, yes, I am following the current discussion | 14:11 |
croelandt | new goal: remove 100% of the code and start over in Rust | 14:11 |
abhishekk | lol | 14:11 |
jokke_ | croelandt for lifetime PTL, never allowed to anything else! | 14:12 |
jokke_ | *to do* | 14:12 |
croelandt | damn, now I have to learn Rust | 14:12 |
abhishekk | I have given one comment on the last test file,I guess she has removed two tests by mistake there | 14:12 |
abhishekk | moving ahead; | 14:13 |
abhishekk | #topic Open discussion | 14:13 |
jokke_ | abhishekk: I'd be shocked and very positively surprised if there wasn't any small mistakes to catch from that size of an patch ;) | 14:13 |
jokke_ | s/an// | 14:13 |
abhishekk | :D | 14:14 |
alistarle | Regarding https://review.opendev.org/c/openstack/glance/+/840318 we are fixing unit test right now, but we don't know really how tempest are working for functionnal test, do you have idea about that ? | 14:14 |
abhishekk | glance-download Work | 14:14 |
abhishekk | tempest is totally different | 14:14 |
alistarle | functionnal test are not based on tempest ? | 14:15 |
abhishekk | to write functional test I think you need to run one more server which will be very critical or time consuming | 14:15 |
abhishekk | alistarle, no glance functional tests are different from tempest | 14:15 |
jokke_ | alistarle: there is unit, functional & integration tests in the glance repo, tempest tests are their totally own beast in a different repo and will need separate patch all together once the feature is ready to go | 14:15 |
abhishekk | I think dansmith will help us here once he is free from summit workload | 14:16 |
jokke_ | alistarle: under glance/tests/[unit, functional, integration] | 14:16 |
alistarle | oh ok fine, so we can take care of unit, but will probably need help for functionnal & integration | 14:16 |
dansmith | yeah, I'll help with the tempest thing | 14:17 |
abhishekk | alistarle, once you finished fixing existing unit tests, I will help you in writing new one and will try to write functional tests as well | 14:17 |
jokke_ | alistarle: the integration tests in repo are very thin and I don't think there's anything in that scope you would need to be worried about | 14:17 |
abhishekk | ++ | 14:17 |
abhishekk | dansmith, thank you | 14:17 |
abhishekk | most probably I will try to put some time for it in next week | 14:18 |
alistarle | ok nice | 14:18 |
jokke_ | just check the import tests under the glance/tests/functional and you should have pretty decent idea how to adapt. You might need quite a bit of mocking to get any of that done 'though | 14:18 |
abhishekk | for unit yes, mocking is required but for functional i think it should not use mocking | 14:20 |
jokke_ | but abhishekk and dansmith should be great resources and have some opinions what tests to include there | 14:20 |
jokke_ | abhishekk: in that case there probably won't be any functional tests. We have no mechanics to spin up multiple glances with keystones etc. to make any of that process doable | 14:22 |
dansmith | you don't need multiple glances I don't think | 14:22 |
dansmith | you should be able to import from yourself | 14:22 |
jokke_ | might need to rely tempest on the functional side | 14:22 |
abhishekk | :D, once you finished with unit tests I will look at functional tests | 14:23 |
abhishekk | what dansmith said is also correct, but in tempest we can have glance and remote glance as well | 14:23 |
abhishekk | ok, alistarle, pslestang ping me if you face any diffuclties in unit tests | 14:24 |
abhishekk | that's all from me for today | 14:24 |
pslestang | abhishekk: ok thank you | 14:24 |
abhishekk | np :) | 14:24 |
jokke_ | nothing from me, thanks | 14:24 |
abhishekk | cool, lets wrap up then | 14:25 |
abhishekk | thank you all! | 14:25 |
abhishekk | have a nice day and weekend | 14:26 |
jokke_ | same to you | 14:26 |
alistarle | bye | 14:26 |
abhishekk | #endmeeting | 14:26 |
opendevmeet | Meeting ended Thu Jun 9 14:26:18 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:26 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/glance/2022/glance.2022-06-09-14.00.html | 14:26 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/glance/2022/glance.2022-06-09-14.00.txt | 14:26 |
opendevmeet | Log: https://meetings.opendev.org/meetings/glance/2022/glance.2022-06-09-14.00.log.html | 14:26 |
*** dasm|ruck is now known as dasm|ruck|off | 22:08 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!