| croelandt | abhishekk: can we push https://review.opendev.org/c/openstack/glance-specs/+/880030 ? :) | 13:54 |
|---|---|---|
| abhishekk | croelandt, pdeore is PTL now, she has the power to approve or reject :D | 13:58 |
| croelandt | oh right only the PTL can approve? | 13:59 |
| pdeore | #startmeeting glance | 13:59 |
| opendevmeet | Meeting started Thu May 11 13:59:26 2023 UTC and is due to finish in 60 minutes. The chair is pdeore. Information about MeetBot at http://wiki.debian.org/MeetBot. | 13:59 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 13:59 |
| opendevmeet | The meeting name has been set to 'glance' | 13:59 |
| pdeore | #topic roll call | 13:59 |
| pdeore | #link https://etherpad.openstack.org/p/glance-team-meeting-agenda | 13:59 |
| pdeore | o/ | 13:59 |
| pdeore | croelandt, abhishekk I was thinking to wait for today, if there are no objections then I will set the +W | 14:00 |
| pdeore | shall we start? I think everyone is here :) | 14:01 |
| mrjoshi | o/ | 14:01 |
| croelandt | o/ | 14:01 |
| pdeore | ok, let's start | 14:01 |
| pdeore | #topic release/periodic jobs updates | 14:01 |
| rosmaita | o/ | 14:01 |
| pdeore | We are in M1 release week, and i think we are good to tag M1 | 14:01 |
| pdeore | waiting for the config refresh patch to merge, then I will submit the release patch today | 14:02 |
| abhishekk | o/ | 14:02 |
| pdeore | for glance_store release we need to wait for os-brick release | 14:02 |
| abhishekk | rosmaita, could you please keep watch on it? | 14:02 |
| pdeore | rosmaita, can we update the glance_store hash after os-brick release | 14:02 |
| abhishekk | you can update the hash now but release should be done after os-brick release | 14:03 |
| rosmaita | ok, so what i would like to do is this | 14:03 |
| rosmaita | the os-bricks have been released | 14:03 |
| dansmith | o/ | 14:04 |
| rosmaita | but the upper constraints have not been updated | 14:04 |
| rosmaita | due to a pep8 problem | 14:04 |
| rosmaita | anyway, the glance-store change has merged, but i think we should update the min version of os-brick in setup.cfg | 14:04 |
| rosmaita | before doing the new glance_store releases | 14:04 |
| rosmaita | i have patches up for that | 14:05 |
| rosmaita | gimme a sec to find the link | 14:05 |
| rosmaita | https://review.opendev.org/q/topic:bug/2004555+project:openstack/glance_store | 14:05 |
| pdeore | ack, | 14:05 |
| rosmaita | another problem is that as far as i can tell, the stable/2023.1 upper constraints are not being updated by the bot | 14:06 |
| rosmaita | but i can push a patch for that by hand | 14:06 |
| rosmaita | after the pep8 stuff is fixed in requirements | 14:07 |
| pdeore | the master patch is already merged, so we can update the hash, right? | 14:07 |
| rosmaita | we haven't released os-brick from master yet | 14:07 |
| pdeore | yeah, https://review.opendev.org/c/openstack/releases/+/882580 | 14:08 |
| pdeore | we will have to wiat for this | 14:08 |
| rosmaita | or, not, if we don't update the 'extras' in setup.cfg | 14:09 |
| rosmaita | pdeore: thanks for pointing out that patch, didn't realize elod had updated it | 14:10 |
| dansmith | so one option would be to just release it without the dep and then follow up later with a bump right? | 14:10 |
| dansmith | so that people *can* get the fix if they put the versions together | 14:10 |
| dansmith | which right now they can't easily | 14:10 |
| rosmaita | there is that | 14:11 |
| pdeore | ok, so we can release the store after os-brick release without the dep? | 14:13 |
| rosmaita | well, if we don't change the req, you can release glance_store now | 14:14 |
| dansmith | that would be my preference, but on the gradient of concern, glance's exposure to this is probably the lowest of the three projects, so it's certainly less concerning than nova | 14:14 |
| pdeore | ok | 14:15 |
| rosmaita | pdeore: the situation is that the change in glance_store adds some parameters to a os-brick call that haven't changed, so using an old os-brick won't break anything with the new glance_store code | 14:15 |
| rosmaita | (not sure i said that clearly) | 14:16 |
| pdeore | yeah i got your point | 14:16 |
| rosmaita | anyway, new glance_store + old os-brick should be fine, just doesn't give you full protection for the CVE | 14:16 |
| pdeore | rosmaita, Is it possible for you to keep watch on this ? I will try to as much late as possible though | 14:17 |
| rosmaita | but it's the "accidental part" anyway, so pretty low probability | 14:17 |
| rosmaita | i can do it, my time zone is good for this | 14:17 |
| pdeore | rosmaita, gr8 Thanks ! | 14:17 |
| pdeore | ok, let's move to next topic | 14:18 |
| pdeore | Periodic job all green except oslo-tips failure, may be again version conflict issue | 14:18 |
| rosmaita | what we can do is, if the upper constraint hasn't changed by say 1800UTC, we can release without the req change | 14:18 |
| pdeore | rosmaita, ok | 14:18 |
| rosmaita | (sorry, i know you wanted to move on) | 14:18 |
| rosmaita | one more question | 14:18 |
| rosmaita | actually, not ... | 14:19 |
| pdeore | np, I thought we are done :) | 14:19 |
| rosmaita | we will release all the glance_store versions at 1800 UTC | 14:19 |
| pdeore | rosmaita, ack | 14:19 |
| rosmaita | i can ping dansmith to verify the hashes on the release patch | 14:19 |
| dansmith | sure | 14:19 |
| rosmaita | ok, that's all from me, thank you | 14:20 |
| pdeore | cool | 14:20 |
| pdeore | rosmaita, Thanks | 14:20 |
| pdeore | shall we move ahead ? | 14:20 |
| dansmith | I think it's safe :) | 14:21 |
| pdeore | ok, let me continue with the next peridoc job updates :) | 14:21 |
| pdeore | so as I said 2 oslo-tips jobs are still failing with version conflict issue again I think | 14:22 |
| pdeore | but i still wonder how the jobs which were failing till last week started passing without merging the changes submitted by croelandt ? | 14:23 |
| pdeore | or I'm missing some context on this? | 14:23 |
| croelandt | hm | 14:23 |
| rosmaita | it's magic | 14:24 |
| croelandt | yeah | 14:24 |
| pdeore | :D | 14:24 |
| croelandt | everything is magic | 14:24 |
| pdeore | then I think we should wait everytime for this magic to be happened :P | 14:24 |
| pdeore | croelandt, you have abandon the py38 to p310 patch right? | 14:25 |
| croelandt | hm not really | 14:25 |
| pdeore | so we need only the one where nodeset is changed | 14:25 |
| croelandt | we wanted to wait & see the results ont he tips jobs | 14:25 |
| pdeore | ohh ok | 14:25 |
| croelandt | but we never test py310 with tips then? | 14:26 |
| * croelandt is confused | 14:26 | |
| pdeore | i think we did | 14:26 |
| pdeore | ohh no, not tested | 14:27 |
| croelandt | damn it feels like this should be tested somehow | 14:27 |
| rosmaita | "this" == ? | 14:27 |
| pdeore | ok, let's test that and check if these recently failing ones are passing or not | 14:28 |
| pdeore | https://review.opendev.org/c/openstack/glance/+/882185 | 14:28 |
| abhishekk | this == py310 I think | 14:28 |
| croelandt | rosmaita: the tips | 14:28 |
| pdeore | move to next ? | 14:29 |
| pdeore | moving ahead :) | 14:30 |
| pdeore | #topic Important reviews | 14:30 |
| pdeore | #link https://review.opendev.org/c/openstack/glance/+/881940 - Add new add loc api | 14:30 |
| pdeore | #link https://review.opendev.org/c/openstack/glance/+/882498 - Add get loc api | 14:30 |
| pdeore | I have submitted the new location apis changes, kindly please have a look | 14:30 |
| croelandt | Would we like these merged for M1 or was it just the spec? | 14:30 |
| dansmith | pdeore: I really want to review that I have just been slammed lately | 14:31 |
| pdeore | croelandt, it would be nice if we can get those in m1 :) | 14:31 |
| * croelandt stretches fingers | 14:31 | |
| pdeore | #link https://review.opendev.org/c/openstack/glance-specs/+/880030 - Reproposed New Location API spec | 14:32 |
| pdeore | on spec we have 2 +2s | 14:32 |
| pdeore | I will go ahead and will set +W if there are no objections on the design until tommorw. | 14:32 |
| pdeore | the sdk part for these new loc api, I've started working on, will submit the patch tmrw | 14:33 |
| pdeore | any questions? | 14:33 |
| * croelandt has none | 14:34 | |
| pdeore | cool, moving to next | 14:34 |
| pdeore | #topic Specs | 14:34 |
| pdeore | we have 2 more specs for review, so kindly please have a look | 14:34 |
| pdeore | #link https://review.opendev.org/c/openstack/glance-specs/+/880627 - Reproposed Image Encryption Spec | 14:34 |
| pdeore | #link https://review.opendev.org/c/openstack/glance-specs/+/881951 - Spec-lite Add new Location Strategy | 14:34 |
| rosmaita | ack | 14:35 |
| pdeore | moving to next | 14:35 |
| pdeore | #topic Can we delete multiple images from the same store | 14:35 |
| pdeore | mrjoshi_ ^ | 14:35 |
| pdeore | #link https://review.opendev.org/c/openstack/python-openstackclient/+/882086/3/openstackclient/image/v2/image.py#1854 | 14:36 |
| mrjoshi_ | this is regarding the ``glance stores-delete`` which deletes image from store | 14:36 |
| mrjoshi_ | I recently added a patch for adding support of ``glance stores-delete`` equivalent in the openstack client . | 14:36 |
| mrjoshi_ | There's a comment from stephen regarding it ,Currently we can only delete a single image from the store , what if user's want to delete multiple images from the same store? | 14:37 |
| rosmaita | they make multiple requests | 14:37 |
| mrjoshi_ | Can't we have it in a single request | 14:38 |
| rosmaita | we don't have it for image-delete, do we? | 14:38 |
| mrjoshi_ | we do | 14:38 |
| croelandt | we can do openstack image delete IMG1 IMG2 IMG3... ? | 14:38 |
| mrjoshi_ | yes | 14:38 |
| abhishekk | we can certainly do glance image-delete 1 2 3 | 14:39 |
| croelandt | for the sake of consistency, it would make sense to have this behaviour everywhere | 14:39 |
| croelandt | as a user it infuriates me when commands are not consistent | 14:39 |
| rosmaita | that's not in the API, though, is it? (batch delete, i mean) | 14:39 |
| abhishekk | The proposal is to deleted different images from same store at once (we can decide this in next PTG) | 14:40 |
| abhishekk | no that is not in API | 14:40 |
| croelandt | but this could be in the CLI, right? | 14:40 |
| abhishekk | yes | 14:40 |
| abhishekk | its easy to do it in CLI | 14:40 |
| rosmaita | so it wouldn't require any glance-side changes, not sure what the issue is here | 14:41 |
| abhishekk | let me tell you | 14:41 |
| abhishekk | we are adding support to delete image from a store in SDK | 14:41 |
| abhishekk | the maintainer suggested rather than adding new command like image store delete we should pass --store option to existing delete command | 14:41 |
| abhishekk | and then he asked us whether we want to add support to delete multiple images from same store | 14:42 |
| abhishekk | So we can have image delete store image1, 2, 3 and so on | 14:42 |
| rosmaita | so, that's an SDK design decision, that is, whether they want the SDK to diverge from the actual API | 14:44 |
| croelandt | seems fine to me to have the SDK do 3 calls to the API to delete 3 images | 14:44 |
| croelandt | rather than have the user type 3 commands to do the same 3 calls | 14:44 |
| pdeore | +1 | 14:46 |
| pdeore | we have only few mins left | 14:47 |
| mrjoshi_ | so if everyone agrees can we implement this in the patch or should we have a separate patch for it? | 14:47 |
| croelandt | mostly an SDK decision to be honest | 14:48 |
| abhishekk | you can tell them that we can work on it later | 14:49 |
| mrjoshi_ | ok | 14:49 |
| pdeore | shall we move to open discussions now? | 14:50 |
| croelandt | yes | 14:51 |
| pdeore | #Open Discussions | 14:51 |
| pdeore | I will be on PTO from 18th-25th May | 14:51 |
| abhishekk | I don't have anything to for Open discussion | 14:52 |
| croelandt | Would be nice to fix this before M1 as well :) https://review.opendev.org/c/openstack/python-glanceclient/+/880696 | 14:52 |
| pdeore | so won't be there for next 2 weekly meetings, any volunteer to chair the meeting for next 2 week? | 14:52 |
| croelandt | 18th is a public holiday in France | 14:52 |
| croelandt | and I might take some PTO after that, gotta check my balance :p | 14:52 |
| abhishekk | we can call off 18th | 14:53 |
| abhishekk | and 25th if anything comes urgent then I will chair it | 14:53 |
| pdeore | ok, I will send the mail accordingly | 14:53 |
| pdeore | abhishekk, Thanks ! :) | 14:54 |
| pdeore | That's it from me | 14:54 |
| pdeore | anyone has anything else to discuss? | 14:54 |
| pdeore | ok, assuming nothing left.. let's conclude for today ! | 14:55 |
| pdeore | Thanks everyone for joining !! | 14:56 |
| pdeore | #endmeeting | 14:56 |
| opendevmeet | Meeting ended Thu May 11 14:56:17 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:56 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/glance/2023/glance.2023-05-11-13.59.html | 14:56 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/glance/2023/glance.2023-05-11-13.59.txt | 14:56 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/glance/2023/glance.2023-05-11-13.59.log.html | 14:56 |
| *** pdeore is now known as pdeore|afk | 14:57 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!