yasufum | Hi, tacker team. | 08:00 |
---|---|---|
ueha | hi | 08:00 |
takahashi-tsc | hi | 08:00 |
aaina | Hi | 08:00 |
renu | Hello everyone | 08:00 |
yasufum | hi | 08:00 |
yasufum | #startmeeting tacker | 08:01 |
opendevmeet | Meeting started Tue Feb 6 08:01:15 2024 UTC and is due to finish in 60 minutes. The chair is yasufum. Information about MeetBot at http://wiki.debian.org/MeetBot. | 08:01 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 08:01 |
opendevmeet | The meeting name has been set to 'tacker' | 08:01 |
yasufum | #link https://etherpad.opendev.org/p/tacker-meeting | 08:01 |
yasufum | So, let's start the meeting. | 08:01 |
yasufum | The first item is a bug report for a old topic. | 08:03 |
yasufum | #link https://bugs.launchpad.net/tacker/+bug/1629173 | 08:03 |
aaina | Hi everyone..I am Aaina Lohia and I just started working for NEC | 08:04 |
yasufum | hi | 08:05 |
yasufum | welcome | 08:05 |
yasufum | It looks not so critical for me. | 08:05 |
yasufum | And Importance is "wishlist". | 08:05 |
aaina | I was working on this bug: https://bugs.launchpad.net/tacker/+bug/1629173 and I found it to be invalid. The message mentioned in the bug is displayed when we delete a vnf using Legacy API command which will be removed in the next release. I don't know if it has been discussed previously | 08:05 |
aaina | I can change the status to won't fix.. but I am unable to choose that option | 08:06 |
yasufum | It's too old actually, and I don't know about the status of the issue at least. | 08:07 |
renu | I would like to discuss topic "Regarding zuul job for compliance test in tacker from non-voting state to Voting" | 08:07 |
yasufum | renu: ok, sure | 08:07 |
renu | The discussion is for fix approach | 08:08 |
yasufum | ok | 08:08 |
aaina | I investigated this on the master branch anf found it invalid https://usercontent.irccloud-cdn.com/file/gxHaPQOG/image.png | 08:09 |
renu | We are working on zuul job for compliance test in tacker is in non-voting state. (https://bugs.launchpad.net/tacker/+bug/2021454) | 08:10 |
renu | During the analysis we observed multiple issues around the datatype mismatch in api response. | 08:11 |
yasufum | aaina: anyway, I can change the status to "won't fix". | 08:12 |
aaina | ok, thanks! | 08:12 |
renu | Current error is ‘operationParam’ is not type of object. | 08:12 |
yasufum | renu: OK, I'm on the your item. | 08:13 |
renu | As per current tacker implementation the operationParams is a string type however as per ETSI NFV-SOL003v020601p specification document (https://www.etsi.org/deliver/etsi_gs/NFV-SOL/001_099/003/02.06.01_60/gs_NFV-SOL003v020601p.pdf)it should be object type. | 08:14 |
renu | As per our analysis the tacker code needs to fix the operationParams data type from string to object type. | 08:14 |
renu | But the impact of such changes seems to be big. The impacted areas are out of API , changes in DB also (Table vnf_lcm_op_occs will be impacted as currently data type of operation_params is longtext.) | 08:15 |
renu | We would like to know community members suggestion and input for fix approach. | 08:16 |
yasufum | renu: thanks | 08:17 |
yasufum | Is there any comment for the fix? | 08:18 |
yasufum | renu: Could you tell me exactly where the error message is happened? | 08:21 |
renu | The error is coming while running the compliance test example: tacker.tests.compliance.sol003.test_vnflcm.IndividualVnfLcmOperationOccurenceTest.test_get_ind_vnf_lcm_op_occs | 08:21 |
renu | the error message is : <status status="FAIL" starttime="20230904 08:49:24.324" endtime="20230904 08:49:24.423" critical="yes">ValidationError: Validation error for schema VnfLcmOpOcc.schema.json: '{"flavourId": "simple", "extVirtualLinks": [{"id": "net0", "resourceId": "c4370d60-e1bf-4608-be5c-5fc5d31d9b3a", "extCps": [{"cpdId": "CP1", "cpConfig": [{"cpProtocolData": [{"layerProtocol": "IP_OVER_ETHERNET"}]}]}]}], "vimConnectionInfo" | 08:22 |
yasufum | Please wait a moment, I'm finding ... | 08:22 |
renu | In NFV-TST 010 “ ~/api-tests/SOL003/VNFLifecycleManagement-API/schemas/ VnfLcmOpOcc.schema.json” file, there is validation check that operationParams should be of object type as per SOL specification. | 08:23 |
yasufum | It must be here. | 08:24 |
yasufum | #link https://github.com/openstack/tacker/blob/c738e956c62b64a42b1cbec120c31ff38d964cb1/tacker/tests/compliance/sol003/test_vnflcm.py#L226 | 08:24 |
renu | https://opendev.org/openstack/tacker/src/branch/master/tacker/objects/vnf_lcm_op_occs.py#L235 --> code the pperationParams is defined as string 'operation_params': fields.StringField(nullable=True), | 08:30 |
yasufum | I'm not still sure it's OK just convert the datatype. | 08:30 |
yasufum | But It might be work. | 08:30 |
yasufum | So, I'm not opposite for your proposal. | 08:31 |
renu | Also https://github.com/openstack/tacker/blob/c738e956c62b64a42b1cbec120c31ff38d964cb1/tacker/api/vnflcm/v1/controller.py#L304 line the operation_params is populated. | 08:32 |
yasufum | OK, thanks. | 08:32 |
renu | The compliance API validation code is --> https://forge.etsi.org/rep/nfv/api-tests/-/blob/2.8.1-fix-plu/SOL003/VNFLifecycleManagement-API/schemas/VnfLcmOpOcc.schema.json#L42 | 08:33 |
yasufum | Anyway, please provide a bug report on lauhchpad, and add a link to the error the message on zuul if we can see it. | 08:34 |
yasufum | Thanks | 08:34 |
renu | ok | 08:34 |
yasufum | Is there any other comment on the proposal, guys? | 08:35 |
yasufum | Or we can go to the next topic? | 08:35 |
renu | Thanks | 08:35 |
yasufum | renu: you're welcome. | 08:35 |
yasufum | good | 08:36 |
yasufum | k-fukayan: could you share your item? | 08:36 |
fukaya | Yes | 08:36 |
fukaya | my topic is alert to new Patch Creation | 08:37 |
renu | We need to create a bug with detail bug report for this and link it with compliance "https://bugs.launchpad.net/tacker/+bug/1629173" | 08:38 |
renu | Just for confirmation, Is this correct understanding. | 08:38 |
yasufum | renu: perfect, thanks. | 08:39 |
renu | Thanks a lot for confirmation. | 08:39 |
yasufum | oops | 08:39 |
yasufum | just wait | 08:40 |
yasufum | Is it the same issue with 1629173? | 08:40 |
yasufum | I've simply asked to add a new bug report for the your issue. | 08:43 |
renu | ok | 08:43 |
yasufum | thanks | 08:43 |
yasufum | fukaya: sorry, please go on. | 08:44 |
fukaya | my topic is alert to new Patch Creation. | 08:44 |
fukaya | I upload new patch. | 08:45 |
fukaya | https://review.opendev.org/c/openstack/tacker/+/907170 | 08:45 |
fukaya | this patch have many changes for directory and filename. | 08:45 |
fukaya | please be careful conflicts, if you create and upload new patch. | 08:46 |
fukaya | that's all my topic | 08:46 |
yasufum | fukaya: thanks | 08:47 |
yasufum | He and Itsuro have uploaded a terminate huge useless warning messages caused while running all tests for which we've been annoyed so much. | 08:49 |
ueha | Thank you for your notice. I was just deleting a lot of files in response to the Legacy API, so there's probably a lot of conflict ... | 08:51 |
ueha | Anyway, I will share the information to our team. | 08:51 |
yasufum | Sure, thanks kindly. | 08:51 |
yasufum | fukaya: and final one is just for asking review, right? | 08:53 |
fukaya | yes, please review this patch. | 08:54 |
fukaya | https://review.opendev.org/c/openstack/tacker/+/903726 | 08:54 |
yasufum | OK, thanks. | 08:55 |
ueha | fukaya: Thanks, this is my posted patch. | 08:55 |
yasufum | Thank you all. | 08:56 |
ueha | takahashi-tsc: It's not a big patch, so please review it. thanks | 08:56 |
yasufum | So, let's wrap up the meeting if no other comments. | 08:57 |
takahashi-tsc | Sure, I will do it ASAP. | 08:57 |
takahashi-tsc | Sorry for the late | 08:57 |
ueha | no problem, thank you | 08:57 |
yasufum | thanks | 08:59 |
yasufum | See you next week, bye! | 08:59 |
ueha | thanks, bye | 08:59 |
yasufum | #endmeeting | 09:00 |
opendevmeet | Meeting ended Tue Feb 6 09:00:07 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 09:00 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/tacker/2024/tacker.2024-02-06-08.01.html | 09:00 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/tacker/2024/tacker.2024-02-06-08.01.txt | 09:00 |
opendevmeet | Log: https://meetings.opendev.org/meetings/tacker/2024/tacker.2024-02-06-08.01.log.html | 09:00 |
renu | Bye everyone | 09:03 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!