Saturday, 2013-11-02

*** jsergent has quit IRC00:12
*** sdake has joined #openstack-metering00:12
*** sdake has quit IRC00:12
*** sdake has joined #openstack-metering00:12
*** sdake has joined #openstack-metering00:13
*** yjiang5 has quit IRC00:21
*** sdake has quit IRC01:11
*** SergeyLukjanov has quit IRC01:21
*** SergeyLukjanov has joined #openstack-metering01:22
*** SergeyLukjanov is now known as _SergeyLukjanov01:24
*** _SergeyLukjanov has quit IRC01:24
*** SergeyLukjanov has joined #openstack-metering01:25
*** SergeyLukjanov is now known as _SergeyLukjanov01:26
*** _SergeyLukjanov has quit IRC01:27
*** SergeyLukjanov has joined #openstack-metering01:32
*** sphoorti has quit IRC02:02
*** sphoorti has joined #openstack-metering02:04
*** vkmc has quit IRC02:10
*** shakayumi has quit IRC02:15
*** SergeyLukjanov has quit IRC02:19
*** SergeyLukjanov has joined #openstack-metering02:20
*** SergeyLukjanov has quit IRC02:22
*** nati_ueno has joined #openstack-metering02:25
*** sayali_ has joined #openstack-metering02:57
*** sayali_ has quit IRC03:11
*** sayali has joined #openstack-metering03:15
*** sdake has joined #openstack-metering03:25
*** nijaba has joined #openstack-metering03:35
sphoortisileht, are you around?04:43
*** sayali has quit IRC04:47
*** nati_ueno has quit IRC04:50
*** sdake has quit IRC04:50
*** sdake has joined #openstack-metering04:52
*** sdake has quit IRC04:52
*** sdake has joined #openstack-metering04:52
*** sayali has joined #openstack-metering04:59
*** nati_ueno has joined #openstack-metering05:05
*** sdake has quit IRC05:11
*** nati_ueno has quit IRC05:14
openstackgerritJenkins proposed a change to openstack/ceilometer: Imported Translations from Transifex  https://review.openstack.org/5448206:03
*** SergeyLukjanov has joined #openstack-metering06:27
*** SergeyLukjanov has quit IRC06:35
*** SergeyLukjanov has joined #openstack-metering06:41
*** SergeyLukjanov has quit IRC06:53
*** SergeyLukjanov has joined #openstack-metering07:02
*** sayali has quit IRC07:34
*** sayali has joined #openstack-metering07:39
sphoortieglynn, are you around?08:18
*** lsmola has joined #openstack-metering09:01
*** sayali has quit IRC09:04
*** sayali has joined #openstack-metering09:18
*** SergeyLukjanov has quit IRC09:51
*** anujdeshpande has joined #openstack-metering10:20
*** eglynn has quit IRC10:35
*** sayali_ has joined #openstack-metering10:36
*** SergeyLukjanov has joined #openstack-metering10:38
*** sayali has quit IRC10:38
*** sayali has joined #openstack-metering10:41
*** sayali_ has quit IRC10:41
*** SergeyLukjanov has quit IRC10:45
*** sayali_ has joined #openstack-metering10:45
*** sayali has quit IRC10:46
*** sayali__ has joined #openstack-metering11:27
*** sayali has joined #openstack-metering11:30
*** sayali_ has quit IRC11:30
*** sayali__ has quit IRC11:32
*** matsuhashi has joined #openstack-metering12:36
*** julim has joined #openstack-metering12:56
*** julim has quit IRC13:00
*** sayali has quit IRC13:02
*** matsuhashi has quit IRC13:06
*** matsuhashi has joined #openstack-metering13:07
*** sphoorti has quit IRC13:07
*** matsuhashi has quit IRC13:10
*** matsuhashi has joined #openstack-metering13:11
*** sayali has joined #openstack-metering13:46
*** anujdeshpande has quit IRC13:55
*** julim has joined #openstack-metering14:21
*** julim has quit IRC14:26
*** sayali has quit IRC15:05
*** sayali has joined #openstack-metering15:06
*** sphoorti has joined #openstack-metering15:09
*** matsuhashi has quit IRC15:19
*** matsuhashi has joined #openstack-metering15:20
*** matsuhashi has quit IRC15:24
*** sdake has joined #openstack-metering15:39
*** sdake has joined #openstack-metering15:39
*** sayali has quit IRC15:45
*** SergeyLukjanov has joined #openstack-metering15:50
*** eglynn has joined #openstack-metering15:51
sphoortieglynn, there?15:56
*** giroro_ has quit IRC16:01
*** Ruetobas has joined #openstack-metering16:03
*** sayalilunkad has joined #openstack-metering16:05
*** Ruetobas has quit IRC16:07
*** sayalilunkad has quit IRC16:10
*** Ruetobas has joined #openstack-metering16:14
*** sayalilunkad has joined #openstack-metering16:14
*** fnaval_ has joined #openstack-metering16:15
*** sayalilunkad has quit IRC16:19
eglynnsphoorti: very briefly ...16:24
eglynnsphoorti: ok, so you're looking in the neutron source for the point at which the notification is emitted, right?16:24
eglynnsphoorti: have you tried grep?16:24
sphoortino eglynn i didnt try grep :(16:24
eglynnsphoorti: so how did you look?16:25
sphoortiand eglynn the libffi-dev is missing16:25
eglynnsphoorti: missing?16:25
eglynnsphoorti: I literally just installed it on precise myself 10 minutes ago16:26
sphoortisorry eglynn package not found16:26
sphoortiin my error report eglynn16:26
eglynnsphoorti: did you see my last email?16:27
eglynnthe one that said ...16:28
sphoortiyes eglynn16:28
sphoortito install the package16:28
eglynnand 'sudo apt-get install -y gcc libffi-dev' fails for you?16:28
sphoortino eglynn . I mentioned that saying that was the reason why my earlier tox failed.16:29
eglynnsphoorti: yes, I had already asked you in install that package via email16:30
eglynnsphoorti: (I had guessed that was one of the missing dependencies)16:30
eglynnsphoorti: (having hit that issue myself many times ...)16:30
sphoortieglynn, also when i will be cloning ceilometer , what will happen to the one that is there in my devstack?16:30
eglynnsphoorti: nothing will happen to it, the clone are completely independent16:31
eglynnsphoorti: s/clone/clones/16:31
sphoortishould i be cloning ceilometer in my home folder or inside devstack folder?16:31
eglynnsphoorti: lets move on, my time is really short today16:31
eglynnsphoorti: so back to nuetron16:31
sphoortiokay eglynn16:32
eglynnsphoorti: you couldn't find the code that emits the notification16:32
eglynnsphoorti: (without using grep ...)16:32
eglynnsphoorti: so here what you would have found ...16:32
eglynnhttps://github.com/openstack/neutron/blob/master/neutron/api/v2/base.py#L48816:32
sphoortieglynn, i hadnt used grep16:32
eglynnsphoorti: how do you search for patterns in the codebase?16:33
eglynnsphoorti: anyway ... the line:16:33
eglynnnotifier_method = self._resource + '.update.end'16:33
eglynnconstructs the event type that ceilometer will consume16:34
eglynnin this case self._resource = 'router'16:34
eglynngiving the 'router.update.end' string that ceilometer eventually sees16:34
sphoortirouter.update.end triggers the error?16:34
eglynnsphoorti: yes, that's eaxactly what the bug report was telling you16:35
eglynnsphoorti: see https://bugs.launchpad.net/ceilometer/+bug/124329216:35
eglynnsphoorti: whoops, I meant start not end16:35
eglynnsphoorti: sorry16:35
eglynnok, so here's the point16:36
eglynnhow could the tenant ID be missing from the router.update.start/end notifications?16:37
*** sdake has quit IRC16:37
eglynnsphoorti: could it have something to do with the logic in this method?16:38
eglynnhttps://github.com/openstack/neutron/blob/master/neutron/api/v2/base.py#L50016:38
sphoortieglynn, is it this?  not context.is_admin)):16:39
sphoortilike you said in the mail?16:39
eglynnsphoorti: try to think about this logically instead of grasping for a quick answer16:43
eglynnsphoorti: so looking at the code ...16:46
eglynnsphoorti: ... it seems that the _populate_tenant_id method is responsible for adding the tenant ID, right?16:46
sphoortiyes eglynn16:46
eglynnsphoorti: ... where is that method called from?16:46
eglynnsphoorti: ... from prepare_request_body()16:46
eglynnsphoorti: now look at the update() method16:46
eglynnsphoorti: where does the router.update.start notification occur in relation to the Controller.prepare_request_body call?16:47
eglynnsphoorti: ... before? ... or after?16:47
eglynnsphoorti: here are the lines mean:16:49
eglynnhttps://github.com/openstack/neutron/blob/master/neutron/api/v2/base.py#L45316:49
eglynnproduces the notification16:49
eglynnhttps://github.com/openstack/neutron/blob/master/neutron/api/v2/base.py#L45816:49
eglynnprepares the request body16:49
eglynnsphoorti: ... so what's the conclusion?16:49
sphoortieglynn, after my router.update.start i prepare the request body16:49
eglynnsphoorti: ... so the tenant ID is populated when?16:50
sphoortiafter the router.update.start16:50
eglynnsphoorti: ... *after* the router.update.start notification has been sent, exactly!16:50
eglynnsphoorti: now do we have a better understanding of why the ceilometer code is blowing up on this notification?16:51
sphoortiso first we should populate the tenant_id and then the router notification should be emitted?16:51
sphoortibecause ceilometer never gets the tenant_id16:52
eglynnsphoorti: so, we need to investigate whether that neutron code can be restructured so as to ensure the tenant ID is always populated a priori16:52
*** sayali has joined #openstack-metering16:53
eglynnsphoorti: so here's your next task16:53
*** anujdeshpande has joined #openstack-metering16:54
eglynnsphoorti: study that neutron code and figure out a strategy for restructuring it if possible to ensure the tenant ID is set for both start & end notifications16:54
eglynnsphoorti: make sense?16:54
sphoortiyes eglynn16:55
eglynnsphoorti: cool16:55
eglynnsphoorti: so one last question, before I drop off ... how do you search the code?16:56
sphoortii should start using the grep command , right eglynn ?16:57
sphoortii used ctrl-f on the github page16:57
eglynnsphoorti: wouldn't that only search a single source file?16:58
sphoortieglynn, havent used grep command much. Will start using now onwards16:59
sphoortisorry eglynn :(16:59
eglynnsphoorti: here's a very useful idiom ...16:59
eglynnfor example ...16:59
eglynnfind /opt/stack/neutron/ -name "*.py" | xargs grep -n 'update\.start'16:59
sphoortithanks a lot eglynn :)17:00
eglynnsphoorti: right-o I need to drop off, travelling to Hong Knong for most of tomorrow17:00
sphoortieglynn, the unit testing on ceilometer again gave an error and now my virtual box is not responding17:02
sphoortii ll restart that17:02
sphoortiis that testing essential right now?17:02
eglynnsphoorti: running the ceilometer unit tests is not essential if it turns out the fix will be applied in neutron17:03
eglynnsphoorti: though obviously the neutron tests would have to be run17:03
sphoortiokay eglynn i ll first study the code and think of restructuring it.17:04
sphoortiif in case i run into errors or have doubts whom should i ask for help, since you would be travelling?17:04
eglynnsphoorti: since tomorrow is Sunday, there are unlikely to many folks around in any case17:05
sphoortiokay eglynn , so once i make the changes in that logic , i ll have to run neutron tests?17:06
eglynnsphoorti: yes17:06
eglynnsphoorti: I'll reply quickly to your mail on the list for posterity17:07
sphoortiokay eglynn i ll try that17:07
sphoortiwill keep you updated with my progress17:07
sphoortithanks a lot eglynn :)17:07
*** SergeyLukjanov is now known as _SergeyLukjanov17:12
*** _SergeyLukjanov has quit IRC17:13
*** sphoorti has quit IRC17:16
*** nati_ueno has joined #openstack-metering17:18
*** sayali_ has joined #openstack-metering17:22
*** sayali has quit IRC17:25
*** sayali_ has quit IRC17:27
*** sphoorti has joined #openstack-metering17:28
*** sayali_ has joined #openstack-metering17:30
*** eglynn has quit IRC17:30
*** SergeyLukjanov has joined #openstack-metering17:31
*** SergeyLukjanov has quit IRC17:35
*** fnaval_ has quit IRC17:42
*** fnaval_ has joined #openstack-metering17:42
*** fnaval_ has quit IRC17:46
*** ruhe has joined #openstack-metering17:54
*** sdake has joined #openstack-metering18:15
*** ruhe has quit IRC18:45
*** anujdeshpande has quit IRC18:49
*** nati_ueno has quit IRC19:05
*** nati_ueno has joined #openstack-metering19:06
*** nati_ueno has quit IRC19:10
*** sayali_ has quit IRC19:51
*** nati_ueno has joined #openstack-metering20:34
*** lsmola has quit IRC20:39
*** nati_ueno has quit IRC21:14
*** shardy has quit IRC21:15
*** sdake has quit IRC21:22
*** eglynn has joined #openstack-metering21:24
*** sdake has joined #openstack-metering21:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!