*** jsergent has quit IRC | 00:12 | |
*** sdake has joined #openstack-metering | 00:12 | |
*** sdake has quit IRC | 00:12 | |
*** sdake has joined #openstack-metering | 00:12 | |
*** sdake has joined #openstack-metering | 00:13 | |
*** yjiang5 has quit IRC | 00:21 | |
*** sdake has quit IRC | 01:11 | |
*** SergeyLukjanov has quit IRC | 01:21 | |
*** SergeyLukjanov has joined #openstack-metering | 01:22 | |
*** SergeyLukjanov is now known as _SergeyLukjanov | 01:24 | |
*** _SergeyLukjanov has quit IRC | 01:24 | |
*** SergeyLukjanov has joined #openstack-metering | 01:25 | |
*** SergeyLukjanov is now known as _SergeyLukjanov | 01:26 | |
*** _SergeyLukjanov has quit IRC | 01:27 | |
*** SergeyLukjanov has joined #openstack-metering | 01:32 | |
*** sphoorti has quit IRC | 02:02 | |
*** sphoorti has joined #openstack-metering | 02:04 | |
*** vkmc has quit IRC | 02:10 | |
*** shakayumi has quit IRC | 02:15 | |
*** SergeyLukjanov has quit IRC | 02:19 | |
*** SergeyLukjanov has joined #openstack-metering | 02:20 | |
*** SergeyLukjanov has quit IRC | 02:22 | |
*** nati_ueno has joined #openstack-metering | 02:25 | |
*** sayali_ has joined #openstack-metering | 02:57 | |
*** sayali_ has quit IRC | 03:11 | |
*** sayali has joined #openstack-metering | 03:15 | |
*** sdake has joined #openstack-metering | 03:25 | |
*** nijaba has joined #openstack-metering | 03:35 | |
sphoorti | sileht, are you around? | 04:43 |
---|---|---|
*** sayali has quit IRC | 04:47 | |
*** nati_ueno has quit IRC | 04:50 | |
*** sdake has quit IRC | 04:50 | |
*** sdake has joined #openstack-metering | 04:52 | |
*** sdake has quit IRC | 04:52 | |
*** sdake has joined #openstack-metering | 04:52 | |
*** sayali has joined #openstack-metering | 04:59 | |
*** nati_ueno has joined #openstack-metering | 05:05 | |
*** sdake has quit IRC | 05:11 | |
*** nati_ueno has quit IRC | 05:14 | |
openstackgerrit | Jenkins proposed a change to openstack/ceilometer: Imported Translations from Transifex https://review.openstack.org/54482 | 06:03 |
*** SergeyLukjanov has joined #openstack-metering | 06:27 | |
*** SergeyLukjanov has quit IRC | 06:35 | |
*** SergeyLukjanov has joined #openstack-metering | 06:41 | |
*** SergeyLukjanov has quit IRC | 06:53 | |
*** SergeyLukjanov has joined #openstack-metering | 07:02 | |
*** sayali has quit IRC | 07:34 | |
*** sayali has joined #openstack-metering | 07:39 | |
sphoorti | eglynn, are you around? | 08:18 |
*** lsmola has joined #openstack-metering | 09:01 | |
*** sayali has quit IRC | 09:04 | |
*** sayali has joined #openstack-metering | 09:18 | |
*** SergeyLukjanov has quit IRC | 09:51 | |
*** anujdeshpande has joined #openstack-metering | 10:20 | |
*** eglynn has quit IRC | 10:35 | |
*** sayali_ has joined #openstack-metering | 10:36 | |
*** SergeyLukjanov has joined #openstack-metering | 10:38 | |
*** sayali has quit IRC | 10:38 | |
*** sayali has joined #openstack-metering | 10:41 | |
*** sayali_ has quit IRC | 10:41 | |
*** SergeyLukjanov has quit IRC | 10:45 | |
*** sayali_ has joined #openstack-metering | 10:45 | |
*** sayali has quit IRC | 10:46 | |
*** sayali__ has joined #openstack-metering | 11:27 | |
*** sayali has joined #openstack-metering | 11:30 | |
*** sayali_ has quit IRC | 11:30 | |
*** sayali__ has quit IRC | 11:32 | |
*** matsuhashi has joined #openstack-metering | 12:36 | |
*** julim has joined #openstack-metering | 12:56 | |
*** julim has quit IRC | 13:00 | |
*** sayali has quit IRC | 13:02 | |
*** matsuhashi has quit IRC | 13:06 | |
*** matsuhashi has joined #openstack-metering | 13:07 | |
*** sphoorti has quit IRC | 13:07 | |
*** matsuhashi has quit IRC | 13:10 | |
*** matsuhashi has joined #openstack-metering | 13:11 | |
*** sayali has joined #openstack-metering | 13:46 | |
*** anujdeshpande has quit IRC | 13:55 | |
*** julim has joined #openstack-metering | 14:21 | |
*** julim has quit IRC | 14:26 | |
*** sayali has quit IRC | 15:05 | |
*** sayali has joined #openstack-metering | 15:06 | |
*** sphoorti has joined #openstack-metering | 15:09 | |
*** matsuhashi has quit IRC | 15:19 | |
*** matsuhashi has joined #openstack-metering | 15:20 | |
*** matsuhashi has quit IRC | 15:24 | |
*** sdake has joined #openstack-metering | 15:39 | |
*** sdake has joined #openstack-metering | 15:39 | |
*** sayali has quit IRC | 15:45 | |
*** SergeyLukjanov has joined #openstack-metering | 15:50 | |
*** eglynn has joined #openstack-metering | 15:51 | |
sphoorti | eglynn, there? | 15:56 |
*** giroro_ has quit IRC | 16:01 | |
*** Ruetobas has joined #openstack-metering | 16:03 | |
*** sayalilunkad has joined #openstack-metering | 16:05 | |
*** Ruetobas has quit IRC | 16:07 | |
*** sayalilunkad has quit IRC | 16:10 | |
*** Ruetobas has joined #openstack-metering | 16:14 | |
*** sayalilunkad has joined #openstack-metering | 16:14 | |
*** fnaval_ has joined #openstack-metering | 16:15 | |
*** sayalilunkad has quit IRC | 16:19 | |
eglynn | sphoorti: very briefly ... | 16:24 |
eglynn | sphoorti: ok, so you're looking in the neutron source for the point at which the notification is emitted, right? | 16:24 |
eglynn | sphoorti: have you tried grep? | 16:24 |
sphoorti | no eglynn i didnt try grep :( | 16:24 |
eglynn | sphoorti: so how did you look? | 16:25 |
sphoorti | and eglynn the libffi-dev is missing | 16:25 |
eglynn | sphoorti: missing? | 16:25 |
eglynn | sphoorti: I literally just installed it on precise myself 10 minutes ago | 16:26 |
sphoorti | sorry eglynn package not found | 16:26 |
sphoorti | in my error report eglynn | 16:26 |
eglynn | sphoorti: did you see my last email? | 16:27 |
eglynn | the one that said ... | 16:28 |
sphoorti | yes eglynn | 16:28 |
sphoorti | to install the package | 16:28 |
eglynn | and 'sudo apt-get install -y gcc libffi-dev' fails for you? | 16:28 |
sphoorti | no eglynn . I mentioned that saying that was the reason why my earlier tox failed. | 16:29 |
eglynn | sphoorti: yes, I had already asked you in install that package via email | 16:30 |
eglynn | sphoorti: (I had guessed that was one of the missing dependencies) | 16:30 |
eglynn | sphoorti: (having hit that issue myself many times ...) | 16:30 |
sphoorti | eglynn, also when i will be cloning ceilometer , what will happen to the one that is there in my devstack? | 16:30 |
eglynn | sphoorti: nothing will happen to it, the clone are completely independent | 16:31 |
eglynn | sphoorti: s/clone/clones/ | 16:31 |
sphoorti | should i be cloning ceilometer in my home folder or inside devstack folder? | 16:31 |
eglynn | sphoorti: lets move on, my time is really short today | 16:31 |
eglynn | sphoorti: so back to nuetron | 16:31 |
sphoorti | okay eglynn | 16:32 |
eglynn | sphoorti: you couldn't find the code that emits the notification | 16:32 |
eglynn | sphoorti: (without using grep ...) | 16:32 |
eglynn | sphoorti: so here what you would have found ... | 16:32 |
eglynn | https://github.com/openstack/neutron/blob/master/neutron/api/v2/base.py#L488 | 16:32 |
sphoorti | eglynn, i hadnt used grep | 16:32 |
eglynn | sphoorti: how do you search for patterns in the codebase? | 16:33 |
eglynn | sphoorti: anyway ... the line: | 16:33 |
eglynn | notifier_method = self._resource + '.update.end' | 16:33 |
eglynn | constructs the event type that ceilometer will consume | 16:34 |
eglynn | in this case self._resource = 'router' | 16:34 |
eglynn | giving the 'router.update.end' string that ceilometer eventually sees | 16:34 |
sphoorti | router.update.end triggers the error? | 16:34 |
eglynn | sphoorti: yes, that's eaxactly what the bug report was telling you | 16:35 |
eglynn | sphoorti: see https://bugs.launchpad.net/ceilometer/+bug/1243292 | 16:35 |
eglynn | sphoorti: whoops, I meant start not end | 16:35 |
eglynn | sphoorti: sorry | 16:35 |
eglynn | ok, so here's the point | 16:36 |
eglynn | how could the tenant ID be missing from the router.update.start/end notifications? | 16:37 |
*** sdake has quit IRC | 16:37 | |
eglynn | sphoorti: could it have something to do with the logic in this method? | 16:38 |
eglynn | https://github.com/openstack/neutron/blob/master/neutron/api/v2/base.py#L500 | 16:38 |
sphoorti | eglynn, is it this? not context.is_admin)): | 16:39 |
sphoorti | like you said in the mail? | 16:39 |
eglynn | sphoorti: try to think about this logically instead of grasping for a quick answer | 16:43 |
eglynn | sphoorti: so looking at the code ... | 16:46 |
eglynn | sphoorti: ... it seems that the _populate_tenant_id method is responsible for adding the tenant ID, right? | 16:46 |
sphoorti | yes eglynn | 16:46 |
eglynn | sphoorti: ... where is that method called from? | 16:46 |
eglynn | sphoorti: ... from prepare_request_body() | 16:46 |
eglynn | sphoorti: now look at the update() method | 16:46 |
eglynn | sphoorti: where does the router.update.start notification occur in relation to the Controller.prepare_request_body call? | 16:47 |
eglynn | sphoorti: ... before? ... or after? | 16:47 |
eglynn | sphoorti: here are the lines mean: | 16:49 |
eglynn | https://github.com/openstack/neutron/blob/master/neutron/api/v2/base.py#L453 | 16:49 |
eglynn | produces the notification | 16:49 |
eglynn | https://github.com/openstack/neutron/blob/master/neutron/api/v2/base.py#L458 | 16:49 |
eglynn | prepares the request body | 16:49 |
eglynn | sphoorti: ... so what's the conclusion? | 16:49 |
sphoorti | eglynn, after my router.update.start i prepare the request body | 16:49 |
eglynn | sphoorti: ... so the tenant ID is populated when? | 16:50 |
sphoorti | after the router.update.start | 16:50 |
eglynn | sphoorti: ... *after* the router.update.start notification has been sent, exactly! | 16:50 |
eglynn | sphoorti: now do we have a better understanding of why the ceilometer code is blowing up on this notification? | 16:51 |
sphoorti | so first we should populate the tenant_id and then the router notification should be emitted? | 16:51 |
sphoorti | because ceilometer never gets the tenant_id | 16:52 |
eglynn | sphoorti: so, we need to investigate whether that neutron code can be restructured so as to ensure the tenant ID is always populated a priori | 16:52 |
*** sayali has joined #openstack-metering | 16:53 | |
eglynn | sphoorti: so here's your next task | 16:53 |
*** anujdeshpande has joined #openstack-metering | 16:54 | |
eglynn | sphoorti: study that neutron code and figure out a strategy for restructuring it if possible to ensure the tenant ID is set for both start & end notifications | 16:54 |
eglynn | sphoorti: make sense? | 16:54 |
sphoorti | yes eglynn | 16:55 |
eglynn | sphoorti: cool | 16:55 |
eglynn | sphoorti: so one last question, before I drop off ... how do you search the code? | 16:56 |
sphoorti | i should start using the grep command , right eglynn ? | 16:57 |
sphoorti | i used ctrl-f on the github page | 16:57 |
eglynn | sphoorti: wouldn't that only search a single source file? | 16:58 |
sphoorti | eglynn, havent used grep command much. Will start using now onwards | 16:59 |
sphoorti | sorry eglynn :( | 16:59 |
eglynn | sphoorti: here's a very useful idiom ... | 16:59 |
eglynn | for example ... | 16:59 |
eglynn | find /opt/stack/neutron/ -name "*.py" | xargs grep -n 'update\.start' | 16:59 |
sphoorti | thanks a lot eglynn :) | 17:00 |
eglynn | sphoorti: right-o I need to drop off, travelling to Hong Knong for most of tomorrow | 17:00 |
sphoorti | eglynn, the unit testing on ceilometer again gave an error and now my virtual box is not responding | 17:02 |
sphoorti | i ll restart that | 17:02 |
sphoorti | is that testing essential right now? | 17:02 |
eglynn | sphoorti: running the ceilometer unit tests is not essential if it turns out the fix will be applied in neutron | 17:03 |
eglynn | sphoorti: though obviously the neutron tests would have to be run | 17:03 |
sphoorti | okay eglynn i ll first study the code and think of restructuring it. | 17:04 |
sphoorti | if in case i run into errors or have doubts whom should i ask for help, since you would be travelling? | 17:04 |
eglynn | sphoorti: since tomorrow is Sunday, there are unlikely to many folks around in any case | 17:05 |
sphoorti | okay eglynn , so once i make the changes in that logic , i ll have to run neutron tests? | 17:06 |
eglynn | sphoorti: yes | 17:06 |
eglynn | sphoorti: I'll reply quickly to your mail on the list for posterity | 17:07 |
sphoorti | okay eglynn i ll try that | 17:07 |
sphoorti | will keep you updated with my progress | 17:07 |
sphoorti | thanks a lot eglynn :) | 17:07 |
*** SergeyLukjanov is now known as _SergeyLukjanov | 17:12 | |
*** _SergeyLukjanov has quit IRC | 17:13 | |
*** sphoorti has quit IRC | 17:16 | |
*** nati_ueno has joined #openstack-metering | 17:18 | |
*** sayali_ has joined #openstack-metering | 17:22 | |
*** sayali has quit IRC | 17:25 | |
*** sayali_ has quit IRC | 17:27 | |
*** sphoorti has joined #openstack-metering | 17:28 | |
*** sayali_ has joined #openstack-metering | 17:30 | |
*** eglynn has quit IRC | 17:30 | |
*** SergeyLukjanov has joined #openstack-metering | 17:31 | |
*** SergeyLukjanov has quit IRC | 17:35 | |
*** fnaval_ has quit IRC | 17:42 | |
*** fnaval_ has joined #openstack-metering | 17:42 | |
*** fnaval_ has quit IRC | 17:46 | |
*** ruhe has joined #openstack-metering | 17:54 | |
*** sdake has joined #openstack-metering | 18:15 | |
*** ruhe has quit IRC | 18:45 | |
*** anujdeshpande has quit IRC | 18:49 | |
*** nati_ueno has quit IRC | 19:05 | |
*** nati_ueno has joined #openstack-metering | 19:06 | |
*** nati_ueno has quit IRC | 19:10 | |
*** sayali_ has quit IRC | 19:51 | |
*** nati_ueno has joined #openstack-metering | 20:34 | |
*** lsmola has quit IRC | 20:39 | |
*** nati_ueno has quit IRC | 21:14 | |
*** shardy has quit IRC | 21:15 | |
*** sdake has quit IRC | 21:22 | |
*** eglynn has joined #openstack-metering | 21:24 | |
*** sdake has joined #openstack-metering | 21:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!