Thursday, 2015-08-27

*** achanda has joined #openstack-mistral00:11
*** achanda has quit IRC00:19
*** achanda has joined #openstack-mistral00:25
*** zhenguo has joined #openstack-mistral01:05
openstackgerritLingxian Kong proposed openstack/mistral: Add fields filter for workflow query  https://review.openstack.org/20463401:20
*** sergmelikyan has joined #openstack-mistral03:39
*** sergmelikyan has quit IRC03:44
*** achanda has quit IRC04:08
*** achanda has joined #openstack-mistral04:44
*** openstackgerrit has quit IRC05:16
*** openstackgerrit has joined #openstack-mistral05:17
openstackgerritRenat Akhmerov proposed openstack/mistral: Switching to six module where it's not used yet  https://review.openstack.org/21700106:07
rakhmerovxylan_kong: hi, how's it going?06:14
rakhmerovjust wanted to ask you to not forget to review patches )06:14
openstackgerritMerged openstack/mistral-dashboard: Rename Mistral dashboard to Workflow  https://review.openstack.org/21724306:18
*** LimorStotland has joined #openstack-mistral06:52
zhenguorakhmerov: about the devstack plugin patch: https://review.openstack.org/#/c/216729/, and the patch to fix devstack gate job, which one should be merged first?06:52
xylan_kongrakhmerov: sure, do reviews everyday :-)07:01
openstackgerritLingxian Kong proposed openstack/mistral: Add fields filter for workflow query  https://review.openstack.org/20463407:06
*** achanda has quit IRC07:06
xylan_kongrakhmerov: hi, the reason of devstack failure, is because 'test_get_list_executions_with_pagination' test case07:20
xylan_kongrakhmerov: i have resolved that in https://review.openstack.org/#/c/204634/07:21
xylan_kongwait for the jenkins result07:21
xylan_kongbut i still don't know the root cause. what i changed, is get execution list after the 2 executions creation.07:22
rakhmerovok, I need to look at it carefully07:28
openstackgerritMerged openstack/mistral: Mistral documentation: dashboard installation guide  https://review.openstack.org/21666307:35
openstackgerritMerged openstack/mistral: Enabling direct workflow cycles: adding another test  https://review.openstack.org/21658707:42
*** achanda has joined #openstack-mistral07:51
xylan_kongrakhmerov: here?07:54
rakhmerovyes07:58
xylan_kongrakhmerov: i think it's a bug07:58
rakhmerovwhat?07:58
xylan_kongrakhmerov: if you create 2 executions at the same time, say, their created_time stored in db are '2015-08-27 07:36:37.245264' and '2015-08-27 07:36:37.391342'07:59
xylan_kongit's very close07:59
xylan_kongbut when we query exections, date.isoformat() will be called, transfered them into '2015-08-27 07:36:37' for both of them08:00
xylan_kongwhen query with pagination, the result order is unpredictable08:01
rakhmerovyes, true08:12
rakhmerovsorry, I have to be distracted from time to time08:12
rakhmerovdidn't really look at it yet closely08:12
xylan_kongrakhmerov: ok, understand08:12
rakhmerovbut yes, you're right08:12
rakhmerovI often see mistakes like that in the code08:12
rakhmerovrelated with dates and time08:13
openstackgerritRenat Akhmerov proposed openstack/mistral: Enabling direct workflow cycles: adding a parallel cycles test  https://review.openstack.org/21660008:21
rakhmerovxylan_kong: fixed my patch: https://review.openstack.org/#/c/216600/308:21
openstackgerritLingxian Kong proposed openstack/mistral: Add fields filter for workflow query  https://review.openstack.org/20463408:23
xylan_kongrakhmerov: yeah, more simpler than my suggesion08:25
rakhmerov:)08:25
rakhmerovbut you gave a right direction08:25
openstackgerritGal Margalit proposed openstack/mistral-dashboard: WIP - Mistral-dashboard:  Task details overview screen  https://review.openstack.org/21248908:27
^Gal^ignore that msg im pushing a change08:27
^Gal^in a few minutes08:27
xylan_kong:-)08:28
* xylan_kong leave for a while08:28
openstackgerritMerged openstack/mistral: Switching to six module where it's not used yet  https://review.openstack.org/21700108:31
rakhmerovxylan_kong: ooh, you solved the issue with just adding a sleep(1)08:34
rakhmerovnot sure if it's the best solution08:34
rakhmerovthinking...08:35
rakhmerovwhat if you just create 2 executions and sort them not by create_at field?08:35
rakhmerovbut something else08:35
rakhmerovsomething you're sure about08:36
rakhmerovI mean order08:36
xylan_kongrakhmerov: i found the created_at is stored in mysql as '2015-08-27 07:36:37', the 'isoformat()' methond is ok08:36
rakhmerovwf_name, e.g.08:36
xylan_kongrakhmerov: but it's a good idea of your suggestion08:36
xylan_kongi'm confused08:36
rakhmerovyeah, we already have a bunch of sleeps across the code. I'd like we to remove them completely one day08:37
xylan_kongwhy it's returned as '2015-08-27 07:36:37.245264', but stored as '2015-08-27 07:36:37'08:37
rakhmerovwhat are you confused with?08:37
xylan_kongrakhmerov: for the test case, agree with your suggestion08:37
xylan_kongfor the problem, i've no idea...08:37
rakhmerovhm.. I think here's what's going on08:38
rakhmerov1 sec08:38
rakhmerovwhen you first create an execution it's created_at is set to, e.g., '2015-08-27 07:36:37.245264'08:39
rakhmerovwith fractional seconds08:39
xylan_kongyes08:39
rakhmerovit's because you use a value that was not fetched from a DB08:39
rakhmerovbut then during saving it gets shrinked08:40
xylan_kongmaybe it's the reason08:40
rakhmerovand if you fetch it from DB you get what you get08:40
rakhmerovthis is my assumption, not sure on 100%08:40
xylan_kongsounds reasonable, i guess08:40
*** achanda has quit IRC08:50
openstackgerritGal Margalit proposed openstack/mistral-dashboard: mistral-dashboard: added Task details overview screen infrastructure  https://review.openstack.org/21248909:01
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor action execution controller and tests  https://review.openstack.org/21760809:54
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor action execution controller and tests  https://review.openstack.org/21760809:58
openstackgerritMerged openstack/mistral: Enabling direct workflow cycles: adding a parallel cycles test  https://review.openstack.org/21660010:01
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor cron trigger controller with new json type  https://review.openstack.org/21761210:03
*** zhenguo has quit IRC10:10
openstackgerritNikolay Mahotkin proposed openstack/mistral: Mistral documentation: adding configuration guide  https://review.openstack.org/21625810:17
openstackgerritNikolay Mahotkin proposed openstack/mistral: Mistral documentation: adding installation guide  https://review.openstack.org/21552810:17
openstackgerritRenat Akhmerov proposed openstack/mistral: Redactor environment controller with new json type  https://review.openstack.org/21762910:47
openstackgerritLingxian Kong proposed openstack/mistral: Fix failure in execution pagination functioinal tests  https://review.openstack.org/21763010:47
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor action execution controller and tests  https://review.openstack.org/21760810:55
openstackgerritRenat Akhmerov proposed openstack/mistral: Redactor environment controller with new json type  https://review.openstack.org/21762910:55
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor cron trigger controller with new json type  https://review.openstack.org/21761210:55
*** gpaz has joined #openstack-mistral11:20
*** gpaz has quit IRC11:22
xylan_kongrakhmerov nmakhotkin: please review https://review.openstack.org/#/c/217630/, which fixes the devstack failure11:29
rakhmerovok11:31
xylan_kongrakhmerov: thanks11:40
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor environment controller with new json type  https://review.openstack.org/21762911:41
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor execution controller with new json type  https://review.openstack.org/21765311:41
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor execution controller with new json type  https://review.openstack.org/21765312:08
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor action execution controller and tests  https://review.openstack.org/21760812:08
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor environment controller with new json type  https://review.openstack.org/21762912:08
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor cron trigger controller with new json type  https://review.openstack.org/21761212:08
openstackgerritMerged openstack/mistral: Fix failure in execution pagination functioinal tests  https://review.openstack.org/21763012:20
*** openstackgerrit has quit IRC12:31
*** openstackgerrit has joined #openstack-mistral12:32
openstackgerritNikolay Mahotkin proposed openstack/mistral: Mistral documentation: Quickstart  https://review.openstack.org/21768512:32
openstackgerritLingxian Kong proposed openstack/mistral: Support action_execution deletion  https://review.openstack.org/21650912:34
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor execution controller with new json type  https://review.openstack.org/21765312:34
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor task controller with new json type  https://review.openstack.org/21768612:34
openstackgerritLingxian Kong proposed openstack/mistral: Add fields filter for workflow query  https://review.openstack.org/20463412:39
openstackgerritLingxian Kong proposed openstack/mistral: Fixing working concurrency when value is YAQL  https://review.openstack.org/21712712:44
*** gpaz has joined #openstack-mistral12:45
LimorStotlandHi all i have question about mistral types in heat12:49
LimorStotlandI am trying to create stack with the mistral types and retry and i am failing12:50
LimorStotlandi am using this example: http://paste.openstack.org/show/429648/12:51
LimorStotlandthis is what heat sends to mistral : http://paste.openstack.org/show/429649/12:52
LimorStotlandif I am trying to remove the policies have failed12:52
LimorStotlandany idea?12:52
rakhmerovhi LimorStotland12:54
rakhmerovcan you provide the stack trace?12:55
LimorStotlandHi rakhmerov12:55
LimorStotlandheat or mistral?12:55
rakhmerovboth12:55
rakhmerovhonestly, I don't know much about how Heat resources work for Mistral12:55
rakhmerovmy idea is that we, first of all, need to figure out on which side the issue is12:56
rakhmerovMistral or Heat12:56
rakhmerovif it's Mistral's problem then we'll be able to investigate it pretty quickly I guess12:56
rakhmerovif it's HEAT then we need to ask some help from folks who worked on it12:57
LimorStotlandI think the problem is in the heat died because I tried to deploy the workflow heat create and it also failed12:57
rakhmerov(: <><> :)12:58
rakhmerovneed more info12:58
LimorStotlandthe error: http://paste.openstack.org/show/429651/13:00
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor action execution controller and tests  https://review.openstack.org/21760813:03
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor cron trigger controller with new json type  https://review.openstack.org/21761213:03
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor environment controller with new json type  https://review.openstack.org/21762913:04
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor execution controller with new json type  https://review.openstack.org/21765313:04
openstackgerritRenat Akhmerov proposed openstack/mistral: Refactor task controller with new json type  https://review.openstack.org/21768613:04
rakhmerovLimorStotland: it seems like something wrong with Heat resource schema13:06
rakhmerovthe workflow you created is not compliant with it13:06
LimorStotlandI know... so it a heat problem ....13:06
LimorStotlandthat what i suspected...13:06
rakhmerovLimorStotland: you can either write to heat IRC channel or to skraynev who was working on it13:08
openstackgerritGal Margalit proposed openstack/mistral-dashboard: mistral-dashboard: added Task details overview screen infrastructure  https://review.openstack.org/21248913:08
LimorStotlandOk thanks13:08
rakhmerovor it's even better to tlashchova13:08
rakhmerovshe's the exact author of these resources13:09
rakhmerov:)13:09
nmakhotkinhi LimorStotland!13:20
LimorStotlandHi nmakhotkin13:21
nmakhotkindo you use mistral master branch with Heat?13:21
nmakhotkinor stable branch?13:21
LimorStotlandyep it on my devstack13:21
nmakhotkinI've looked through your workflow13:21
nmakhotkinit seems it is a little bit incorrect13:21
LimorStotlandthe wf thet heat create?13:22
LimorStotlandyes i know13:22
LimorStotlandI am not sure way heat create it this way i will try to debug it13:23
nmakhotkinhm13:23
nmakhotkinI guess there is a wrong schema in heat resource13:23
nmakhotkinpolicies block is wrong there13:24
nmakhotkinsee the example - http://paste.openstack.org/show/429648/13:25
*** zhenguo has joined #openstack-mistral13:25
nmakhotkin'retry' should be right in 'task' block13:25
nmakhotkinwe got rid of 'policies' keyword in DSL13:26
LimorStotlandbut heat does not support it13:28
LimorStotlandat least i know where is the bug thanks13:28
LimorStotlandnmakhotkin we remove the policies everything or only in retry?13:35
nmakhotkinit is for all policies13:36
nmakhotkinsee how it should be in the example - https://github.com/openstack/mistral/blob/master/mistral/tests/unit/engine/test_policies.py#L45-L5313:36
LimorStotlandcool thanks !13:38
*** Piet has quit IRC13:56
*** sergmelikyan has joined #openstack-mistral13:58
openstackgerritNikolay Mahotkin proposed openstack/mistral: Mistral documentation: adding configuration guide  https://review.openstack.org/21625814:15
openstackgerritNikolay Mahotkin proposed openstack/mistral: Mistral documentation: adding installation guide  https://review.openstack.org/21552814:15
*** achanda has joined #openstack-mistral14:31
*** achanda has quit IRC14:40
openstackgerritMerged openstack/mistral: Fixing working concurrency when value is YAQL  https://review.openstack.org/21712714:50
*** tonytan4ever has joined #openstack-mistral14:58
*** LimorStotland has quit IRC15:56
*** sergmelikyan has quit IRC16:00
*** zhenguo has quit IRC16:41
*** harlowja has joined #openstack-mistral16:55
*** achanda has joined #openstack-mistral17:22
*** tonytan4ever has quit IRC18:03
*** Piet has joined #openstack-mistral18:03
*** tonytan4ever has joined #openstack-mistral18:35
*** sergmelikyan has joined #openstack-mistral19:33
*** sergmelikyan has quit IRC19:42
*** achanda has quit IRC19:58
*** achanda has joined #openstack-mistral20:22
*** achanda has quit IRC20:22
*** achanda has joined #openstack-mistral20:23
*** gyee has joined #openstack-mistral20:51
*** Piet has quit IRC21:13
*** sergmelikyan has joined #openstack-mistral21:26
*** Piet has joined #openstack-mistral21:30
*** sergmelikyan has quit IRC21:42
*** sergmelikyan has joined #openstack-mistral21:43
*** sergmelikyan has quit IRC21:43
*** tonytan4ever has quit IRC22:36
*** Ephur has quit IRC22:36
*** sergmelikyan has joined #openstack-mistral23:11
*** achanda_ has joined #openstack-mistral23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!