*** achanda has joined #openstack-mistral | 00:11 | |
*** achanda has quit IRC | 00:19 | |
*** achanda has joined #openstack-mistral | 00:25 | |
*** zhenguo has joined #openstack-mistral | 01:05 | |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Add fields filter for workflow query https://review.openstack.org/204634 | 01:20 |
---|---|---|
*** sergmelikyan has joined #openstack-mistral | 03:39 | |
*** sergmelikyan has quit IRC | 03:44 | |
*** achanda has quit IRC | 04:08 | |
*** achanda has joined #openstack-mistral | 04:44 | |
*** openstackgerrit has quit IRC | 05:16 | |
*** openstackgerrit has joined #openstack-mistral | 05:17 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Switching to six module where it's not used yet https://review.openstack.org/217001 | 06:07 |
rakhmerov | xylan_kong: hi, how's it going? | 06:14 |
rakhmerov | just wanted to ask you to not forget to review patches ) | 06:14 |
openstackgerrit | Merged openstack/mistral-dashboard: Rename Mistral dashboard to Workflow https://review.openstack.org/217243 | 06:18 |
*** LimorStotland has joined #openstack-mistral | 06:52 | |
zhenguo | rakhmerov: about the devstack plugin patch: https://review.openstack.org/#/c/216729/, and the patch to fix devstack gate job, which one should be merged first? | 06:52 |
xylan_kong | rakhmerov: sure, do reviews everyday :-) | 07:01 |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Add fields filter for workflow query https://review.openstack.org/204634 | 07:06 |
*** achanda has quit IRC | 07:06 | |
xylan_kong | rakhmerov: hi, the reason of devstack failure, is because 'test_get_list_executions_with_pagination' test case | 07:20 |
xylan_kong | rakhmerov: i have resolved that in https://review.openstack.org/#/c/204634/ | 07:21 |
xylan_kong | wait for the jenkins result | 07:21 |
xylan_kong | but i still don't know the root cause. what i changed, is get execution list after the 2 executions creation. | 07:22 |
rakhmerov | ok, I need to look at it carefully | 07:28 |
openstackgerrit | Merged openstack/mistral: Mistral documentation: dashboard installation guide https://review.openstack.org/216663 | 07:35 |
openstackgerrit | Merged openstack/mistral: Enabling direct workflow cycles: adding another test https://review.openstack.org/216587 | 07:42 |
*** achanda has joined #openstack-mistral | 07:51 | |
xylan_kong | rakhmerov: here? | 07:54 |
rakhmerov | yes | 07:58 |
xylan_kong | rakhmerov: i think it's a bug | 07:58 |
rakhmerov | what? | 07:58 |
xylan_kong | rakhmerov: if you create 2 executions at the same time, say, their created_time stored in db are '2015-08-27 07:36:37.245264' and '2015-08-27 07:36:37.391342' | 07:59 |
xylan_kong | it's very close | 07:59 |
xylan_kong | but when we query exections, date.isoformat() will be called, transfered them into '2015-08-27 07:36:37' for both of them | 08:00 |
xylan_kong | when query with pagination, the result order is unpredictable | 08:01 |
rakhmerov | yes, true | 08:12 |
rakhmerov | sorry, I have to be distracted from time to time | 08:12 |
rakhmerov | didn't really look at it yet closely | 08:12 |
xylan_kong | rakhmerov: ok, understand | 08:12 |
rakhmerov | but yes, you're right | 08:12 |
rakhmerov | I often see mistakes like that in the code | 08:12 |
rakhmerov | related with dates and time | 08:13 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Enabling direct workflow cycles: adding a parallel cycles test https://review.openstack.org/216600 | 08:21 |
rakhmerov | xylan_kong: fixed my patch: https://review.openstack.org/#/c/216600/3 | 08:21 |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Add fields filter for workflow query https://review.openstack.org/204634 | 08:23 |
xylan_kong | rakhmerov: yeah, more simpler than my suggesion | 08:25 |
rakhmerov | :) | 08:25 |
rakhmerov | but you gave a right direction | 08:25 |
openstackgerrit | Gal Margalit proposed openstack/mistral-dashboard: WIP - Mistral-dashboard: Task details overview screen https://review.openstack.org/212489 | 08:27 |
^Gal^ | ignore that msg im pushing a change | 08:27 |
^Gal^ | in a few minutes | 08:27 |
xylan_kong | :-) | 08:28 |
* xylan_kong leave for a while | 08:28 | |
openstackgerrit | Merged openstack/mistral: Switching to six module where it's not used yet https://review.openstack.org/217001 | 08:31 |
rakhmerov | xylan_kong: ooh, you solved the issue with just adding a sleep(1) | 08:34 |
rakhmerov | not sure if it's the best solution | 08:34 |
rakhmerov | thinking... | 08:35 |
rakhmerov | what if you just create 2 executions and sort them not by create_at field? | 08:35 |
rakhmerov | but something else | 08:35 |
rakhmerov | something you're sure about | 08:36 |
rakhmerov | I mean order | 08:36 |
xylan_kong | rakhmerov: i found the created_at is stored in mysql as '2015-08-27 07:36:37', the 'isoformat()' methond is ok | 08:36 |
rakhmerov | wf_name, e.g. | 08:36 |
xylan_kong | rakhmerov: but it's a good idea of your suggestion | 08:36 |
xylan_kong | i'm confused | 08:36 |
rakhmerov | yeah, we already have a bunch of sleeps across the code. I'd like we to remove them completely one day | 08:37 |
xylan_kong | why it's returned as '2015-08-27 07:36:37.245264', but stored as '2015-08-27 07:36:37' | 08:37 |
rakhmerov | what are you confused with? | 08:37 |
xylan_kong | rakhmerov: for the test case, agree with your suggestion | 08:37 |
xylan_kong | for the problem, i've no idea... | 08:37 |
rakhmerov | hm.. I think here's what's going on | 08:38 |
rakhmerov | 1 sec | 08:38 |
rakhmerov | when you first create an execution it's created_at is set to, e.g., '2015-08-27 07:36:37.245264' | 08:39 |
rakhmerov | with fractional seconds | 08:39 |
xylan_kong | yes | 08:39 |
rakhmerov | it's because you use a value that was not fetched from a DB | 08:39 |
rakhmerov | but then during saving it gets shrinked | 08:40 |
xylan_kong | maybe it's the reason | 08:40 |
rakhmerov | and if you fetch it from DB you get what you get | 08:40 |
rakhmerov | this is my assumption, not sure on 100% | 08:40 |
xylan_kong | sounds reasonable, i guess | 08:40 |
*** achanda has quit IRC | 08:50 | |
openstackgerrit | Gal Margalit proposed openstack/mistral-dashboard: mistral-dashboard: added Task details overview screen infrastructure https://review.openstack.org/212489 | 09:01 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor action execution controller and tests https://review.openstack.org/217608 | 09:54 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor action execution controller and tests https://review.openstack.org/217608 | 09:58 |
openstackgerrit | Merged openstack/mistral: Enabling direct workflow cycles: adding a parallel cycles test https://review.openstack.org/216600 | 10:01 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor cron trigger controller with new json type https://review.openstack.org/217612 | 10:03 |
*** zhenguo has quit IRC | 10:10 | |
openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Mistral documentation: adding configuration guide https://review.openstack.org/216258 | 10:17 |
openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Mistral documentation: adding installation guide https://review.openstack.org/215528 | 10:17 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Redactor environment controller with new json type https://review.openstack.org/217629 | 10:47 |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Fix failure in execution pagination functioinal tests https://review.openstack.org/217630 | 10:47 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor action execution controller and tests https://review.openstack.org/217608 | 10:55 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Redactor environment controller with new json type https://review.openstack.org/217629 | 10:55 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor cron trigger controller with new json type https://review.openstack.org/217612 | 10:55 |
*** gpaz has joined #openstack-mistral | 11:20 | |
*** gpaz has quit IRC | 11:22 | |
xylan_kong | rakhmerov nmakhotkin: please review https://review.openstack.org/#/c/217630/, which fixes the devstack failure | 11:29 |
rakhmerov | ok | 11:31 |
xylan_kong | rakhmerov: thanks | 11:40 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor environment controller with new json type https://review.openstack.org/217629 | 11:41 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor execution controller with new json type https://review.openstack.org/217653 | 11:41 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor execution controller with new json type https://review.openstack.org/217653 | 12:08 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor action execution controller and tests https://review.openstack.org/217608 | 12:08 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor environment controller with new json type https://review.openstack.org/217629 | 12:08 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor cron trigger controller with new json type https://review.openstack.org/217612 | 12:08 |
openstackgerrit | Merged openstack/mistral: Fix failure in execution pagination functioinal tests https://review.openstack.org/217630 | 12:20 |
*** openstackgerrit has quit IRC | 12:31 | |
*** openstackgerrit has joined #openstack-mistral | 12:32 | |
openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Mistral documentation: Quickstart https://review.openstack.org/217685 | 12:32 |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Support action_execution deletion https://review.openstack.org/216509 | 12:34 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor execution controller with new json type https://review.openstack.org/217653 | 12:34 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor task controller with new json type https://review.openstack.org/217686 | 12:34 |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Add fields filter for workflow query https://review.openstack.org/204634 | 12:39 |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Fixing working concurrency when value is YAQL https://review.openstack.org/217127 | 12:44 |
*** gpaz has joined #openstack-mistral | 12:45 | |
LimorStotland | Hi all i have question about mistral types in heat | 12:49 |
LimorStotland | I am trying to create stack with the mistral types and retry and i am failing | 12:50 |
LimorStotland | i am using this example: http://paste.openstack.org/show/429648/ | 12:51 |
LimorStotland | this is what heat sends to mistral : http://paste.openstack.org/show/429649/ | 12:52 |
LimorStotland | if I am trying to remove the policies have failed | 12:52 |
LimorStotland | any idea? | 12:52 |
rakhmerov | hi LimorStotland | 12:54 |
rakhmerov | can you provide the stack trace? | 12:55 |
LimorStotland | Hi rakhmerov | 12:55 |
LimorStotland | heat or mistral? | 12:55 |
rakhmerov | both | 12:55 |
rakhmerov | honestly, I don't know much about how Heat resources work for Mistral | 12:55 |
rakhmerov | my idea is that we, first of all, need to figure out on which side the issue is | 12:56 |
rakhmerov | Mistral or Heat | 12:56 |
rakhmerov | if it's Mistral's problem then we'll be able to investigate it pretty quickly I guess | 12:56 |
rakhmerov | if it's HEAT then we need to ask some help from folks who worked on it | 12:57 |
LimorStotland | I think the problem is in the heat died because I tried to deploy the workflow heat create and it also failed | 12:57 |
rakhmerov | (: <><> :) | 12:58 |
rakhmerov | need more info | 12:58 |
LimorStotland | the error: http://paste.openstack.org/show/429651/ | 13:00 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor action execution controller and tests https://review.openstack.org/217608 | 13:03 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor cron trigger controller with new json type https://review.openstack.org/217612 | 13:03 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor environment controller with new json type https://review.openstack.org/217629 | 13:04 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor execution controller with new json type https://review.openstack.org/217653 | 13:04 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Refactor task controller with new json type https://review.openstack.org/217686 | 13:04 |
rakhmerov | LimorStotland: it seems like something wrong with Heat resource schema | 13:06 |
rakhmerov | the workflow you created is not compliant with it | 13:06 |
LimorStotland | I know... so it a heat problem .... | 13:06 |
LimorStotland | that what i suspected... | 13:06 |
rakhmerov | LimorStotland: you can either write to heat IRC channel or to skraynev who was working on it | 13:08 |
openstackgerrit | Gal Margalit proposed openstack/mistral-dashboard: mistral-dashboard: added Task details overview screen infrastructure https://review.openstack.org/212489 | 13:08 |
LimorStotland | Ok thanks | 13:08 |
rakhmerov | or it's even better to tlashchova | 13:08 |
rakhmerov | she's the exact author of these resources | 13:09 |
rakhmerov | :) | 13:09 |
nmakhotkin | hi LimorStotland! | 13:20 |
LimorStotland | Hi nmakhotkin | 13:21 |
nmakhotkin | do you use mistral master branch with Heat? | 13:21 |
nmakhotkin | or stable branch? | 13:21 |
LimorStotland | yep it on my devstack | 13:21 |
nmakhotkin | I've looked through your workflow | 13:21 |
nmakhotkin | it seems it is a little bit incorrect | 13:21 |
LimorStotland | the wf thet heat create? | 13:22 |
LimorStotland | yes i know | 13:22 |
LimorStotland | I am not sure way heat create it this way i will try to debug it | 13:23 |
nmakhotkin | hm | 13:23 |
nmakhotkin | I guess there is a wrong schema in heat resource | 13:23 |
nmakhotkin | policies block is wrong there | 13:24 |
nmakhotkin | see the example - http://paste.openstack.org/show/429648/ | 13:25 |
*** zhenguo has joined #openstack-mistral | 13:25 | |
nmakhotkin | 'retry' should be right in 'task' block | 13:25 |
nmakhotkin | we got rid of 'policies' keyword in DSL | 13:26 |
LimorStotland | but heat does not support it | 13:28 |
LimorStotland | at least i know where is the bug thanks | 13:28 |
LimorStotland | nmakhotkin we remove the policies everything or only in retry? | 13:35 |
nmakhotkin | it is for all policies | 13:36 |
nmakhotkin | see how it should be in the example - https://github.com/openstack/mistral/blob/master/mistral/tests/unit/engine/test_policies.py#L45-L53 | 13:36 |
LimorStotland | cool thanks ! | 13:38 |
*** Piet has quit IRC | 13:56 | |
*** sergmelikyan has joined #openstack-mistral | 13:58 | |
openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Mistral documentation: adding configuration guide https://review.openstack.org/216258 | 14:15 |
openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Mistral documentation: adding installation guide https://review.openstack.org/215528 | 14:15 |
*** achanda has joined #openstack-mistral | 14:31 | |
*** achanda has quit IRC | 14:40 | |
openstackgerrit | Merged openstack/mistral: Fixing working concurrency when value is YAQL https://review.openstack.org/217127 | 14:50 |
*** tonytan4ever has joined #openstack-mistral | 14:58 | |
*** LimorStotland has quit IRC | 15:56 | |
*** sergmelikyan has quit IRC | 16:00 | |
*** zhenguo has quit IRC | 16:41 | |
*** harlowja has joined #openstack-mistral | 16:55 | |
*** achanda has joined #openstack-mistral | 17:22 | |
*** tonytan4ever has quit IRC | 18:03 | |
*** Piet has joined #openstack-mistral | 18:03 | |
*** tonytan4ever has joined #openstack-mistral | 18:35 | |
*** sergmelikyan has joined #openstack-mistral | 19:33 | |
*** sergmelikyan has quit IRC | 19:42 | |
*** achanda has quit IRC | 19:58 | |
*** achanda has joined #openstack-mistral | 20:22 | |
*** achanda has quit IRC | 20:22 | |
*** achanda has joined #openstack-mistral | 20:23 | |
*** gyee has joined #openstack-mistral | 20:51 | |
*** Piet has quit IRC | 21:13 | |
*** sergmelikyan has joined #openstack-mistral | 21:26 | |
*** Piet has joined #openstack-mistral | 21:30 | |
*** sergmelikyan has quit IRC | 21:42 | |
*** sergmelikyan has joined #openstack-mistral | 21:43 | |
*** sergmelikyan has quit IRC | 21:43 | |
*** tonytan4ever has quit IRC | 22:36 | |
*** Ephur has quit IRC | 22:36 | |
*** sergmelikyan has joined #openstack-mistral | 23:11 | |
*** achanda_ has joined #openstack-mistral | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!